From eb2c0aa16bebf03c18a4fd2ac638038e885b0590 Mon Sep 17 00:00:00 2001 From: henning Date: Wed, 11 Jul 2018 09:08:21 +0000 Subject: [PATCH] in if_addgroup(), call the new pfi_group_addmember() instead of pf_group_change() - the latter is called by _addmemeber now to update dynaddr. before this, "set skip on lo", ifconfig lo1 create -> no skip on lo1 until pf rueset got reloaded. Now lo1 gets the skip flag as intended. This has caused much confusion with i. e. gif interfaces in the past. ok benno, very excited ok phessler --- sys/net/if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/net/if.c b/sys/net/if.c index ecff8abad91..e6546dff224 100644 --- a/sys/net/if.c +++ b/sys/net/if.c @@ -1,4 +1,4 @@ -/* $OpenBSD: if.c,v 1.557 2018/07/10 09:30:13 henning Exp $ */ +/* $OpenBSD: if.c,v 1.558 2018/07/11 09:08:21 henning Exp $ */ /* $NetBSD: if.c,v 1.35 1996/05/07 05:26:04 thorpej Exp $ */ /* @@ -2474,7 +2474,7 @@ if_addgroup(struct ifnet *ifp, const char *groupname) TAILQ_INSERT_TAIL(&ifp->if_groups, ifgl, ifgl_next); #if NPF > 0 - pfi_group_change(groupname); + pfi_group_addmember(groupname, ifp); #endif return (0); -- 2.20.1