From debb1f3d6a298a737429d5c0296741be9eea18bb Mon Sep 17 00:00:00 2001 From: tb Date: Wed, 3 Apr 2024 04:20:13 +0000 Subject: [PATCH] Fix warning about DistributionPointName type The warning incorrectly mentioned GEN_OTHERNAME, while this is about fullName vs nameRelativeToCRLIssuer. Also add a comment to indicate that there's no enum or macros obviate the meaning of the magic 0. ok claudio job --- usr.sbin/rpki-client/x509.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/usr.sbin/rpki-client/x509.c b/usr.sbin/rpki-client/x509.c index 45aa1001fe1..7d56f0c8bc4 100644 --- a/usr.sbin/rpki-client/x509.c +++ b/usr.sbin/rpki-client/x509.c @@ -1,4 +1,4 @@ -/* $OpenBSD: x509.c,v 1.85 2024/03/24 00:38:58 tb Exp $ */ +/* $OpenBSD: x509.c,v 1.86 2024/04/03 04:20:13 tb Exp $ */ /* * Copyright (c) 2022 Theo Buehler * Copyright (c) 2021 Claudio Jeker @@ -758,9 +758,10 @@ x509_get_crl(X509 *x, const char *fn, char **crl) " disallowed", fn); goto out; } + /* Need to hardcode the alternative 0 due to missing macros or enum. */ if (dp->distpoint->type != 0) { - warnx("%s: RFC 6487 section 4.8.6: CRL: " - "expected GEN_OTHERNAME, have %d", fn, dp->distpoint->type); + warnx("%s: RFC 6487 section 4.8.6: CRL DistributionPointName:" + " expected fullName, have %d", fn, dp->distpoint->type); goto out; } -- 2.20.1