From c927202dcce59305b6d2279b9daa0df902f413f0 Mon Sep 17 00:00:00 2001 From: beck Date: Wed, 3 May 2023 07:13:18 +0000 Subject: [PATCH] Bring back length check tb ok'ed and I managed to remove while changing tests. ok tb@ --- lib/libcrypto/x509/x509name.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/libcrypto/x509/x509name.c b/lib/libcrypto/x509/x509name.c index 3c9e224c1b0..319d79d74f0 100644 --- a/lib/libcrypto/x509/x509name.c +++ b/lib/libcrypto/x509/x509name.c @@ -1,4 +1,4 @@ -/* $OpenBSD: x509name.c,v 1.32 2023/05/02 14:13:05 beck Exp $ */ +/* $OpenBSD: x509name.c,v 1.33 2023/05/03 07:13:18 beck Exp $ */ /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) * All rights reserved. * @@ -107,7 +107,7 @@ X509_NAME_get_text_by_OBJ(X509_NAME *name, const ASN1_OBJECT *obj, char *buf, goto err; /* We still support the "pass NULL to find out how much" API */ if (buf != NULL) { - if (!CBS_write_bytes(&cbs, buf, len - 1, NULL)) + if (len <= 0 || !CBS_write_bytes(&cbs, buf, len - 1, NULL)) goto err; /* It must be a C string */ buf[text_len] = '\0'; -- 2.20.1