From bd9152030089a1b7b17a69381832f5aefbf11fa7 Mon Sep 17 00:00:00 2001 From: ratchov Date: Sat, 25 Dec 2021 16:25:07 +0000 Subject: [PATCH] Don't accept an empty string as selector value "looks good" edd@ --- usr.bin/sndioctl/sndioctl.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/usr.bin/sndioctl/sndioctl.c b/usr.bin/sndioctl/sndioctl.c index aa174e77249..ffe0654fa94 100644 --- a/usr.bin/sndioctl/sndioctl.c +++ b/usr.bin/sndioctl/sndioctl.c @@ -1,4 +1,4 @@ -/* $OpenBSD: sndioctl.c,v 1.16 2021/03/03 09:40:43 ratchov Exp $ */ +/* $OpenBSD: sndioctl.c,v 1.17 2021/12/25 16:25:07 ratchov Exp $ */ /* * Copyright (c) 2014-2020 Alexandre Ratchov * @@ -706,6 +706,11 @@ cmd(char *line) } break; case SIOCTL_SEL: + if (*pos == '\0') { + fprintf(stderr, "%s.%s: expects value\n", astr, func); + exit(1); + } + /* FALLTROUGH */ case SIOCTL_VEC: case SIOCTL_LIST: for (i = g; i != NULL; i = nextpar(i)) { -- 2.20.1