From a7b03bb48e5dfd3a995e422c17f4d3bec95e7e41 Mon Sep 17 00:00:00 2001 From: claudio Date: Thu, 1 Dec 2022 10:24:28 +0000 Subject: [PATCH] Adjust comment for rtype_from_mftfile(). It is important that RTYPE_INVALID is not an error. It marks file as not handled by rpki-client and they will be ignored after checking that the provided hash matches. New file types should only be added once the needed code in parse_entity() is available. OK tb@ job@ --- usr.sbin/rpki-client/mft.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/usr.sbin/rpki-client/mft.c b/usr.sbin/rpki-client/mft.c index 753f56fd369..486603645e5 100644 --- a/usr.sbin/rpki-client/mft.c +++ b/usr.sbin/rpki-client/mft.c @@ -1,4 +1,4 @@ -/* $OpenBSD: mft.c,v 1.81 2022/11/30 08:16:10 job Exp $ */ +/* $OpenBSD: mft.c,v 1.82 2022/12/01 10:24:28 claudio Exp $ */ /* * Copyright (c) 2022 Theo Buehler * Copyright (c) 2019 Kristaps Dzonsons @@ -195,8 +195,9 @@ valid_mft_filename(const char *fn, size_t len) } /* - * Check that the file is an CER, CRL, GBR or a ROA. - * Returns corresponding rtype or RTYPE_INVALID on error. + * Check that the file is allowed to be part of a manifest and the parser + * for this type is implemented in rpki-client. + * Returns corresponding rtype or RTYPE_INVALID to mark the file as unknown. */ static enum rtype rtype_from_mftfile(const char *fn) -- 2.20.1