From a78270f834242a33383296e78b8f32afaa962c23 Mon Sep 17 00:00:00 2001 From: jsg Date: Tue, 13 Feb 2024 02:14:25 +0000 Subject: [PATCH] fix off-by-one in bounds test found by "buffer overflow 'mvacc_cpu_freqs' 13 <= 13" smatch error ok miod@ --- sys/arch/armv7/marvell/mvacc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/arch/armv7/marvell/mvacc.c b/sys/arch/armv7/marvell/mvacc.c index 6926aaef728..d5791dfd9b3 100644 --- a/sys/arch/armv7/marvell/mvacc.c +++ b/sys/arch/armv7/marvell/mvacc.c @@ -1,4 +1,4 @@ -/* $OpenBSD: mvacc.c,v 1.5 2022/07/11 10:44:08 jmatthew Exp $ */ +/* $OpenBSD: mvacc.c,v 1.6 2024/02/13 02:14:25 jsg Exp $ */ /* * Copyright (c) 2016 Patrick Wildt * @@ -133,7 +133,7 @@ mvacc_get_frequency(void *cookie, uint32_t *cells) cpu = (sar >> SAR_CPU_DDR_FREQ_OPT) & SAR_CPU_DDR_FREQ_OPT_MASK; tclk = (sar >> SAR_TCLK_FREQ_OPT) & SAR_TCLK_FREQ_OPT_MASK; - if (cpu > nitems(mvacc_cpu_freqs)) { + if (cpu >= nitems(mvacc_cpu_freqs)) { printf("%s: invalid cpu frequency", sc->sc_dev.dv_xname); return 0; } -- 2.20.1