From a36dd4fff200bcacada99e3126ab22013c86af0a Mon Sep 17 00:00:00 2001 From: djm Date: Sat, 11 Sep 2021 00:40:24 +0000 Subject: [PATCH] when using SFTP protocol, continue transferring files after a transfer error occurs. This matches original scp/rcp behaviour. ok dtucker@ --- usr.bin/ssh/scp.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/usr.bin/ssh/scp.c b/usr.bin/ssh/scp.c index ee0072eaffe..77eefaf17e9 100644 --- a/usr.bin/ssh/scp.c +++ b/usr.bin/ssh/scp.c @@ -1,4 +1,4 @@ -/* $OpenBSD: scp.c,v 1.233 2021/09/08 23:31:39 djm Exp $ */ +/* $OpenBSD: scp.c,v 1.234 2021/09/11 00:40:24 djm Exp $ */ /* * scp - secure remote copy. This is basically patched BSD rcp which * uses ssh to do the data transfer (instead of using rcmd). @@ -619,7 +619,7 @@ main(int argc, char **argv) * Finally check the exit status of the ssh process, if one was forked * and no error has occurred yet */ - if (do_cmd_pid != -1 && errs == 0) { + if (do_cmd_pid != -1 && (mode == MODE_SFTP || errs == 0)) { if (remin != -1) (void) close(remin); if (remout != -1) @@ -1263,11 +1263,14 @@ source_sftp(int argc, char *src, char *targ, struct sftp_conn *conn) if (local_is_dir(src) && iamrecursive) { if (upload_dir(conn, src, abs_dst, pflag, SFTP_PROGRESS_ONLY, 0, 0, 1) != 0) { - fatal("failed to upload directory %s to %s", + error("failed to upload directory %s to %s", src, abs_dst); + errs = 1; } - } else if (do_upload(conn, src, abs_dst, pflag, 0, 0) != 0) - fatal("failed to upload file %s to %s", src, abs_dst); + } else if (do_upload(conn, src, abs_dst, pflag, 0, 0) != 0) { + error("failed to upload file %s to %s", src, abs_dst); + errs = 1; + } free(abs_dst); free(target); @@ -1505,7 +1508,8 @@ out: free(tmp); globfree(&g); if (err == -1) { - fatal("Failed to download file '%s'", src); + error("Failed to download '%s'", src); + errs = 1; } } -- 2.20.1