From a0e2ca3ce324d3f1c03c7c8b0a3001900cccad88 Mon Sep 17 00:00:00 2001 From: djm Date: Fri, 14 Jan 2022 03:32:52 +0000 Subject: [PATCH] sshsk_sign: trim call to sshkey_fingerprint() the resulting fingerprint doesn't appear to be used for anything, and we end up leaking it. from Pedro Martelletto; ok dtucker & me --- usr.bin/ssh/ssh-sk-client.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/usr.bin/ssh/ssh-sk-client.c b/usr.bin/ssh/ssh-sk-client.c index afd808025fc..71d639e9571 100644 --- a/usr.bin/ssh/ssh-sk-client.c +++ b/usr.bin/ssh/ssh-sk-client.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ssh-sk-client.c,v 1.10 2021/10/28 02:54:18 djm Exp $ */ +/* $OpenBSD: ssh-sk-client.c,v 1.11 2022/01/14 03:32:52 djm Exp $ */ /* * Copyright (c) 2019 Google LLC * @@ -230,7 +230,6 @@ sshsk_sign(const char *provider, struct sshkey *key, u_int compat, const char *pin) { int oerrno, r = SSH_ERR_INTERNAL_ERROR; - char *fp = NULL; struct sshbuf *kbuf = NULL, *req = NULL, *resp = NULL; *sigp = NULL; @@ -256,12 +255,6 @@ sshsk_sign(const char *provider, struct sshkey *key, goto out; } - if ((fp = sshkey_fingerprint(key, SSH_FP_HASH_DEFAULT, - SSH_FP_DEFAULT)) == NULL) { - error_f("sshkey_fingerprint failed"); - r = SSH_ERR_ALLOC_FAIL; - goto out; - } if ((r = client_converse(req, &resp, SSH_SK_HELPER_SIGN)) != 0) goto out; -- 2.20.1