From 9286d81dd19d966f0d757d7321c0adb6a104fc20 Mon Sep 17 00:00:00 2001 From: deraadt Date: Sun, 18 Aug 2024 15:03:01 +0000 Subject: [PATCH] For DVACT_RESUME, let the children know we are ready *after* calling our own wakeup(). The wakeup() won't result in anything running now because DVACT_RESUME is running in "cold !=0, interrupts blocked, scheduler stopped", but it is idiomatically incorrect to inform your children you are ready before you are ready. --- sys/dev/sdmmc/sdmmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/sdmmc/sdmmc.c b/sys/dev/sdmmc/sdmmc.c index 7950050477d..348261ecd2f 100644 --- a/sys/dev/sdmmc/sdmmc.c +++ b/sys/dev/sdmmc/sdmmc.c @@ -1,4 +1,4 @@ -/* $OpenBSD: sdmmc.c,v 1.61 2023/04/19 02:01:02 dlg Exp $ */ +/* $OpenBSD: sdmmc.c,v 1.62 2024/08/18 15:03:01 deraadt Exp $ */ /* * Copyright (c) 2006 Uwe Stuehler @@ -202,8 +202,8 @@ sdmmc_activate(struct device *self, int act) sc->sc_dying = -1; break; case DVACT_RESUME: - rv = config_activate_children(self, act); wakeup(&sc->sc_tskq); + rv = config_activate_children(self, act); break; default: rv = config_activate_children(self, act); -- 2.20.1