From 8390ed4c6f236dc1e4cd3cd9699bc438dd01a8e0 Mon Sep 17 00:00:00 2001 From: dv Date: Fri, 11 Nov 2022 10:52:44 +0000 Subject: [PATCH] Revert removal of toggling interrupt line in vmd vcpu run loop. phessler reports a performance regression. Needs more testing. --- usr.sbin/vmd/vm.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/usr.sbin/vmd/vm.c b/usr.sbin/vmd/vm.c index 458071fe9c3..f1d9b97741c 100644 --- a/usr.sbin/vmd/vm.c +++ b/usr.sbin/vmd/vm.c @@ -1,4 +1,4 @@ -/* $OpenBSD: vm.c,v 1.75 2022/11/10 23:39:51 dv Exp $ */ +/* $OpenBSD: vm.c,v 1.76 2022/11/11 10:52:44 dv Exp $ */ /* * Copyright (c) 2015 Mike Larkin @@ -1512,6 +1512,23 @@ vcpu_run_loop(void *arg) } else vrp->vrp_irq = 0xFFFF; + /* Still more pending? */ + if (i8259_is_pending()) { + /* + * XXX can probably avoid ioctls here by providing intr + * in vrp + */ + if (vcpu_pic_intr(vrp->vrp_vm_id, + vrp->vrp_vcpu_id, 1)) { + fatal("can't set INTR"); + } + } else { + if (vcpu_pic_intr(vrp->vrp_vm_id, + vrp->vrp_vcpu_id, 0)) { + fatal("can't clear INTR"); + } + } + if (ioctl(env->vmd_fd, VMM_IOC_RUN, vrp) == -1) { /* If run ioctl failed, exit */ ret = errno; -- 2.20.1