From 5f3b3788e991ae1c9b79d51dcc9b88892de3ac45 Mon Sep 17 00:00:00 2001 From: gkoehler Date: Wed, 3 Apr 2024 18:32:47 +0000 Subject: [PATCH] Change ipmi(4)'s taskq from IPL_NONE to IPL_MPFLOOR The IPL_NONE mutex didn't block interrupts that can cause a powerpc64 kernel with option WITNESS to "panic: acquiring blockable sleep lock with spinlock or critical section held (kernel_lock) &kernel_lock". ok mpi@ --- sys/dev/ipmi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/dev/ipmi.c b/sys/dev/ipmi.c index 08726f6956c..1e4dad88ae3 100644 --- a/sys/dev/ipmi.c +++ b/sys/dev/ipmi.c @@ -1,4 +1,4 @@ -/* $OpenBSD: ipmi.c,v 1.118 2022/04/08 13:13:14 mbuhl Exp $ */ +/* $OpenBSD: ipmi.c,v 1.119 2024/04/03 18:32:47 gkoehler Exp $ */ /* * Copyright (c) 2015 Masao Uebayashi @@ -1596,7 +1596,8 @@ ipmi_attach_common(struct ipmi_softc *sc, struct ipmi_attach_args *ia) c->c_sc = sc; c->c_ccode = -1; - sc->sc_cmd_taskq = taskq_create("ipmicmd", 1, IPL_NONE, TASKQ_MPSAFE); + sc->sc_cmd_taskq = taskq_create("ipmicmd", 1, IPL_MPFLOOR, + TASKQ_MPSAFE); } int -- 2.20.1