From 539244803cc2fc25aa3c29113a160e7769575ea6 Mon Sep 17 00:00:00 2001 From: tb Date: Fri, 23 Jun 2023 10:33:12 +0000 Subject: [PATCH] Fix return check of bn_hex2bn_cbs() It returns a length, not a Boolean, so check for 0 explicitly. This is purely cosmetic. ok jsing --- lib/libcrypto/bn/bn_convert.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/libcrypto/bn/bn_convert.c b/lib/libcrypto/bn/bn_convert.c index 0dbe20046b8..9ad9f58f939 100644 --- a/lib/libcrypto/bn/bn_convert.c +++ b/lib/libcrypto/bn/bn_convert.c @@ -1,4 +1,4 @@ -/* $OpenBSD: bn_convert.c,v 1.10 2023/06/23 10:31:27 tb Exp $ */ +/* $OpenBSD: bn_convert.c,v 1.11 2023/06/23 10:33:12 tb Exp $ */ /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) * All rights reserved. * @@ -291,13 +291,13 @@ BN_asc2bn(BIGNUM **bnp, const char *s) goto decimal; if (v != 'X' && v != 'x') goto decimal; - if (!bn_hex2bn_cbs(bnp, &cbs_hex)) + if (bn_hex2bn_cbs(bnp, &cbs_hex) == 0) return 0; goto done; decimal: - if (!bn_dec2bn_cbs(bnp, &cbs)) + if (bn_dec2bn_cbs(bnp, &cbs) == 0) return 0; done: -- 2.20.1