From 28f73f25b5125f4bb05a96ce90cd4e3c2a91bb2f Mon Sep 17 00:00:00 2001 From: nicm Date: Mon, 13 May 2024 11:45:05 +0000 Subject: [PATCH] Fix memory leak, from Fadi Afani. --- usr.bin/tmux/arguments.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/usr.bin/tmux/arguments.c b/usr.bin/tmux/arguments.c index bff135ca0e6..71d1cf22118 100644 --- a/usr.bin/tmux/arguments.c +++ b/usr.bin/tmux/arguments.c @@ -1,4 +1,4 @@ -/* $OpenBSD: arguments.c,v 1.63 2024/04/15 08:19:55 nicm Exp $ */ +/* $OpenBSD: arguments.c,v 1.64 2024/05/13 11:45:05 nicm Exp $ */ /* * Copyright (c) 2010 Nicholas Marriott @@ -164,15 +164,17 @@ args_parse_flag_argument(struct args_value *values, u_int count, char **cause, argument = &values[*i]; if (argument->type != ARGS_STRING) { xasprintf(cause, "-%c argument must be a string", flag); + args_free_value(new); + free(new); return (-1); } } if (argument == NULL) { + args_free_value(new); + free(new); if (optional_argument) { log_debug("%s: -%c (optional)", __func__, flag); args_set(args, flag, NULL, ARGS_ENTRY_OPTIONAL_VALUE); - args_free_value(new); - free(new); return (0); /* either - or end */ } xasprintf(cause, "-%c expects an argument", flag); -- 2.20.1