From 1c6577800c3a5f37ee840a974630773cebaab0a6 Mon Sep 17 00:00:00 2001 From: djm Date: Sat, 10 Feb 2018 09:25:34 +0000 Subject: [PATCH] constify some private key-related functions; based on https://github.com/openssh/openssh-portable/pull/56 by Vincent Brillault --- usr.bin/ssh/authfd.c | 8 ++++---- usr.bin/ssh/authfd.h | 4 ++-- usr.bin/ssh/sshconnect.c | 6 +++--- usr.bin/ssh/sshconnect.h | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/usr.bin/ssh/authfd.c b/usr.bin/ssh/authfd.c index e173304c62f..e4d186d01d4 100644 --- a/usr.bin/ssh/authfd.c +++ b/usr.bin/ssh/authfd.c @@ -1,4 +1,4 @@ -/* $OpenBSD: authfd.c,v 1.106 2018/01/23 05:27:21 djm Exp $ */ +/* $OpenBSD: authfd.c,v 1.107 2018/02/10 09:25:34 djm Exp $ */ /* * Author: Tatu Ylonen * Copyright (c) 1995 Tatu Ylonen , Espoo, Finland @@ -389,7 +389,7 @@ ssh_agent_sign(int sock, const struct sshkey *key, static int -ssh_encode_identity_ssh2(struct sshbuf *b, struct sshkey *key, +ssh_encode_identity_ssh2(struct sshbuf *b, const struct sshkey *key, const char *comment) { int r; @@ -424,8 +424,8 @@ encode_constraints(struct sshbuf *m, u_int life, u_int confirm) * This call is intended only for use by ssh-add(1) and like applications. */ int -ssh_add_identity_constrained(int sock, struct sshkey *key, const char *comment, - u_int life, u_int confirm) +ssh_add_identity_constrained(int sock, const struct sshkey *key, + const char *comment, u_int life, u_int confirm) { struct sshbuf *msg; int r, constrained = (life || confirm); diff --git a/usr.bin/ssh/authfd.h b/usr.bin/ssh/authfd.h index 43abf85dadf..41997ce6d29 100644 --- a/usr.bin/ssh/authfd.h +++ b/usr.bin/ssh/authfd.h @@ -1,4 +1,4 @@ -/* $OpenBSD: authfd.h,v 1.41 2017/06/28 01:09:22 djm Exp $ */ +/* $OpenBSD: authfd.h,v 1.42 2018/02/10 09:25:34 djm Exp $ */ /* * Author: Tatu Ylonen @@ -29,7 +29,7 @@ void ssh_close_authentication_socket(int sock); int ssh_lock_agent(int sock, int lock, const char *password); int ssh_fetch_identitylist(int sock, struct ssh_identitylist **idlp); void ssh_free_identitylist(struct ssh_identitylist *idl); -int ssh_add_identity_constrained(int sock, struct sshkey *key, +int ssh_add_identity_constrained(int sock, const struct sshkey *key, const char *comment, u_int life, u_int confirm); int ssh_remove_identity(int sock, struct sshkey *key); int ssh_update_card(int sock, int add, const char *reader_id, diff --git a/usr.bin/ssh/sshconnect.c b/usr.bin/ssh/sshconnect.c index fc7a4f9b9dd..ede82c06e91 100644 --- a/usr.bin/ssh/sshconnect.c +++ b/usr.bin/ssh/sshconnect.c @@ -1,4 +1,4 @@ -/* $OpenBSD: sshconnect.c,v 1.293 2018/02/07 22:52:45 dtucker Exp $ */ +/* $OpenBSD: sshconnect.c,v 1.294 2018/02/10 09:25:35 djm Exp $ */ /* * Author: Tatu Ylonen * Copyright (c) 1995 Tatu Ylonen , Espoo, Finland @@ -1430,8 +1430,8 @@ ssh_local_cmd(const char *args) } void -maybe_add_key_to_agent(char *authfile, struct sshkey *private, char *comment, - char *passphrase) +maybe_add_key_to_agent(char *authfile, const struct sshkey *private, + char *comment, char *passphrase) { int auth_sock = -1, r; diff --git a/usr.bin/ssh/sshconnect.h b/usr.bin/ssh/sshconnect.h index b5029e2347e..dd648b096e9 100644 --- a/usr.bin/ssh/sshconnect.h +++ b/usr.bin/ssh/sshconnect.h @@ -1,4 +1,4 @@ -/* $OpenBSD: sshconnect.h,v 1.31 2017/09/12 06:32:07 djm Exp $ */ +/* $OpenBSD: sshconnect.h,v 1.32 2018/02/10 09:25:35 djm Exp $ */ /* * Copyright (c) 2000 Markus Friedl. All rights reserved. @@ -57,7 +57,7 @@ void ssh_userauth2(const char *, const char *, char *, Sensitive *); void ssh_put_password(char *); int ssh_local_cmd(const char *); -void maybe_add_key_to_agent(char *, struct sshkey *, char *, char *); +void maybe_add_key_to_agent(char *, const struct sshkey *, char *, char *); /* * Macros to raise/lower permissions. -- 2.20.1