From 1648e347e0e459d7c5c6269d2c888a518b896947 Mon Sep 17 00:00:00 2001 From: claudio Date: Wed, 21 Apr 2021 09:36:06 +0000 Subject: [PATCH] HTTP errors are logged by the http module. No need to repeat them. Instead add a logx when a fallback from delta sync to a snapshot happens. --- usr.sbin/rpki-client/rrdp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/usr.sbin/rpki-client/rrdp.c b/usr.sbin/rpki-client/rrdp.c index 8ffd96cbf84..cb8f1cd6c88 100644 --- a/usr.sbin/rpki-client/rrdp.c +++ b/usr.sbin/rpki-client/rrdp.c @@ -1,4 +1,4 @@ -/* $OpenBSD: rrdp.c,v 1.8 2021/04/21 09:03:42 claudio Exp $ */ +/* $OpenBSD: rrdp.c,v 1.9 2021/04/21 09:36:06 claudio Exp $ */ /* * Copyright (c) 2020 Nils Fisher * Copyright (c) 2021 Claudio Jeker @@ -272,6 +272,7 @@ rrdp_failed(struct rrdp *s) s->sxml = new_snapshot_xml(s->parser, &s->current, s); s->task = SNAPSHOT; s->state = RRDP_STATE_REQ; + logx("%s: delta sync failed, fallback to snapshot", s->local); } else { /* * TODO: update state to track recurring failures @@ -373,7 +374,6 @@ rrdp_finished(struct rrdp *s) rrdp_free(s); rrdp_done(id, 1); } else { - warnx("%s: HTTP request failed", s->local); rrdp_failed(s); } } -- 2.20.1