mglocker [Wed, 21 Aug 2024 04:29:43 +0000 (04:29 +0000)]
Add lions.
suggested and ok jmc@
mglocker [Wed, 21 Aug 2024 04:28:05 +0000 (04:28 +0000)]
Add numeric morse codes.
ok jmc@
mglocker [Wed, 21 Aug 2024 04:27:02 +0000 (04:27 +0000)]
Hippo and rhino babies are also calf's.
ok jmc@
mglocker [Wed, 21 Aug 2024 04:25:26 +0000 (04:25 +0000)]
Add new substraction problem which difference results in the answer to the
ultimate question of life, the universe, and everything.
ok jmc@
nicm [Wed, 21 Aug 2024 04:17:09 +0000 (04:17 +0000)]
Revamp extended keys support to more closely match xterm and support
mode 2 as well as mode 1. From Stanislav Kljuhhin (GitHub issue 4038).
This changes tmux to always request mode 2 from parent terminal, change
to an unambiguous internal representation of keys, and adds an option
(extended-keys-format) to control the format similar to the xterm(1)
formatOtherKeys resource.
deraadt [Wed, 21 Aug 2024 03:16:25 +0000 (03:16 +0000)]
If binaries lack a pintable, execve() can now reject them at startup
by returning EINVAL, rather than at runtime when the first system call
occurs (and then probably dumping core). Let's find out if there are
any surprising exceptions we were unaware of (would need a custom linker,
or a non-crt0 runtime)
errno discussions with kettenis, sthen, millert. Vague concensus it is
worth trying now.
deraadt [Wed, 21 Aug 2024 03:07:45 +0000 (03:07 +0000)]
We do not need the PS_LIBCPIN and PS_PIN flag fields anymore, which were
used during devlopment (for visibility). There is speculation claudio will
immediately use these bits for something else.
dlg [Wed, 21 Aug 2024 01:22:31 +0000 (01:22 +0000)]
offset rx buffers by ETHER_ALIGN so ip payloads are properly aligned.
dlg [Wed, 21 Aug 2024 01:17:50 +0000 (01:17 +0000)]
use 2k clusters on the rx ring instead of 9k clusters.
rge can chain mbufs from multiple rx descriptors together to build
a jumbo packet. 1514 byte packets are still the most common, so
avoiding the waste of most of a 9k cluster if we can still makes
sense.
dlg [Wed, 21 Aug 2024 01:12:52 +0000 (01:12 +0000)]
support building a single packet out of multiple rx descriptors.
rge is a bit like intel nics where you can put small mbufs on the
rx ring and it will chain them together to make a jumbo packet.
except unlike intel you can use any sized mbufs for the rx descriptors.
this adds the handling of these packets to the rx path. we're still
putting 9k frames on the ring though.
dlg [Wed, 21 Aug 2024 00:56:58 +0000 (00:56 +0000)]
be more careful about bus_dmamap_syncs for rx ring descriptors.
this is very similar to the changes made for tx where we fill in
everything except the OWN flag on the rx descriptor, call bus_dmamap_sync
as a barrier for the hw, and then flip the ownership of the OWN
bit. this avoids the potential for the hw to see the own bit before
other things in the descriptor, such as the address and length of
the buffer.
while here, trim code that's not currently used. we don't currently
support rxing one packet by assembling buffers from multiple
descriptors, so stop fiddling with the queue mbuf head and tail
pointers. delete rge_discard_rxbuf() cos it looks like a leftover
from code which tries to reuse mbufs on the rx ring. we free mbufs
when there's an error and let the rxr stuff refill.
ok patrick@
no objections from kevlo@
guenther [Tue, 20 Aug 2024 23:40:39 +0000 (23:40 +0000)]
Now that we have dup2(), csh can use it instead of close()+dup().
Also, as used here, dup/dup2 will clear the close-on-exec flag, so
delete the superfluous fcntl(F_SETFD,0) calls
ok deraadt@
patrick [Tue, 20 Aug 2024 21:24:15 +0000 (21:24 +0000)]
Update handling of transfer rings.
patrick [Tue, 20 Aug 2024 21:23:18 +0000 (21:23 +0000)]
Introduce and update HAL SRNG ops.
deraadt [Tue, 20 Aug 2024 16:24:50 +0000 (16:24 +0000)]
match the config_activate_children() sequences found in other usb host
controller drivers.
deraadt [Tue, 20 Aug 2024 16:07:14 +0000 (16:07 +0000)]
having a file called "OWNER" lying around in a directory of
(effectively) public dommain software is weird. put that info
into a better place.
deraadt [Tue, 20 Aug 2024 15:48:32 +0000 (15:48 +0000)]
annotate signal race
bluhm [Tue, 20 Aug 2024 15:30:29 +0000 (15:30 +0000)]
Fix whitespace in amd64 bus dma.
claudio [Tue, 20 Aug 2024 13:31:49 +0000 (13:31 +0000)]
Use msgbuf_queuelen() instead of accessing the queued member directly.
OK tb@
mvs [Tue, 20 Aug 2024 13:29:25 +0000 (13:29 +0000)]
Unlock KERN_MAXFILES.
`maxfiles' is atomically accessed integer which is lockless and
read-only accessed in file descriptors layer.
lim_startup() called during kernel bootstrap, no need to
atomic_load_int() within.
ok mpi
job [Tue, 20 Aug 2024 12:53:47 +0000 (12:53 +0000)]
Update Geofeed reference
RFC 9632 introduced additional constraints and requirements for RPKI-based
Geofeed authenticators (at my request).
dtucker [Tue, 20 Aug 2024 12:36:59 +0000 (12:36 +0000)]
Send only as much data as needed to trigger rekeying.
Speeds up tests by about 10% in the common case, hopefully more when
instrumented with something like valgrind.
sf [Tue, 20 Aug 2024 12:36:09 +0000 (12:36 +0000)]
fix bus_dmamap_destroy
With bounce buffers, we must pass a larger size to free()
ok bluhm@ hshoexer@
jsg [Tue, 20 Aug 2024 12:18:36 +0000 (12:18 +0000)]
regen
jsg [Tue, 20 Aug 2024 12:17:48 +0000 (12:17 +0000)]
add Samsung PM9C1 and PM9C1a
from bmercer@ and Bryan Vyhmeister
claudio [Tue, 20 Aug 2024 12:00:20 +0000 (12:00 +0000)]
Use stats.msg_queue_len instead of looking into the msgbuf struct.
OK tb@
claudio [Tue, 20 Aug 2024 11:59:39 +0000 (11:59 +0000)]
Use msgbuf_queuelen() instead of accessing wbuf.queue for msgbuf structs.
Also export the msgbuf queue len as a stats member so bgpctl does not need
to dig into the msgbuf structure inside struct peer.
This skips imsg related msgbuf since that will be handled by a imsgbuf
specific function.
OK tb@
bluhm [Tue, 20 Aug 2024 11:45:31 +0000 (11:45 +0000)]
Calculate used bounce buffers in amd64 bus dma correctly.
There was an off-by-one bug when comparing the used pages for bounce
buffers with the available pages. As a result _bus_dmamap_load_buffer()
returned ENOMEM although there was one buffer left.
Also the _dm_nused field was updated and never reset in case of an
error. Use a local variable to count the used pages and update
global map->_dm_nused only if _bus_dmamap_load_buffer() was successful.
This fixes hanging network transmits if bounce buffers are enforced
for vio(4).
OK sf@ hshoexer@
djm [Tue, 20 Aug 2024 11:10:04 +0000 (11:10 +0000)]
actually use the length parameter that was passed in rather than a
constant (this makes no difference in practice because the length
is always the same); reported by martin AT nmkd.net
dtucker [Tue, 20 Aug 2024 09:15:49 +0000 (09:15 +0000)]
Merge AEAD test into main test loop. Removes 3 duplicate tests and
speeds overall test up by about 1%.
dtucker [Tue, 20 Aug 2024 09:02:45 +0000 (09:02 +0000)]
Set a default RekeyLimit of 256k. Used unless overridden by a
command-line flag, which simplifies some of the ssh command lines.
dtucker [Tue, 20 Aug 2024 07:52:43 +0000 (07:52 +0000)]
Add Compression=no to default ssh_config. All of the rekey tests use it
(otherwise the encrypted byte counts would not match) so this lets us
simplify the command lines.
mvs [Tue, 20 Aug 2024 07:48:23 +0000 (07:48 +0000)]
Unlock KERN_MAXPROC and KERN_MAXTHREAD from `kern_vars'. Both
`maxprocess' and `maxthread' are atomically accessed integers.
ok mpi
mvs [Tue, 20 Aug 2024 07:47:25 +0000 (07:47 +0000)]
Unlock etherip_sysctl().
- ETHERIPCTL_ALLOW - atomically accessed integer;
- ETHERIPCTL_STATS - per-CPU counters
ok bluhm
mvs [Tue, 20 Aug 2024 07:46:27 +0000 (07:46 +0000)]
Unlock igmp_sysctl(), pfsync_sysctl() and rip6_sysctl(). Each of them is
the only IGMPCTL_STATS, PFSYNCCTL_STATS and RIPV6CTL_STATS per-CPU
counters.
sysctl_rdstruct() has "newp != NULL" check within and also returns
EPERM, no need for redundant check in igmp_sysctl().
ok bluhm
mvs [Tue, 20 Aug 2024 07:44:36 +0000 (07:44 +0000)]
Unlock sysctl_audio().
It is the only KERN_AUDIO_RECORD. `audio_record_enable' is atomically
accessed integer.
Reasonable from deraadt
dtucker [Tue, 20 Aug 2024 07:41:35 +0000 (07:41 +0000)]
Remove duplicate curve25519-sha256 kex. curve25519-sha256@libssh.org
is the pre-standardization name for the same thing, so remove it
as a duplicate. Speeds up test by a tiny amount.
dtucker [Tue, 20 Aug 2024 07:27:25 +0000 (07:27 +0000)]
Unnest rekey param parsing test and use ssh not sshd. ssh uses the same
parsing code, now has "-G" to dump its config and is slightly faster
to start up. This speeds up the test slightly (~5%) in the common case
but should help more during instrumented tests, eg under valgrind, where
startup costs are magnified.
sf [Tue, 20 Aug 2024 07:04:29 +0000 (07:04 +0000)]
virtio_mmio: Return early if no device
If there is no device, don't write to any registers.
ok jan@
jsg [Tue, 20 Aug 2024 05:52:04 +0000 (05:52 +0000)]
another FXE -> FXe
ok miod@
jsg [Tue, 20 Aug 2024 05:36:38 +0000 (05:36 +0000)]
add (), | has higher precedence than ?:
ok mglocker@
deraadt [Tue, 20 Aug 2024 05:22:05 +0000 (05:22 +0000)]
nasty whitespace
djm [Tue, 20 Aug 2024 03:48:30 +0000 (03:48 +0000)]
place shielded keys (i.e. keys at rest in RAM) into memory allocated
using mmap(3) with MAP_CONCEAL set. This prevents exposure of the
key material in coredumps, etc (this is in addition to other measures
we take in this area).
ok deraadt@
dlg [Tue, 20 Aug 2024 00:09:12 +0000 (00:09 +0000)]
rework rge tx start and completion to better bus_dmamap_sync tx descriptors
ok patrick@
thanks to kettenis@ for reminding me how computers work again.
millert [Mon, 19 Aug 2024 15:08:21 +0000 (15:08 +0000)]
Fix CVE-2024-43688, buffer underflow for very large step values
In get_number(), reject values that are so large that they are
interpreted as negative numbers. In set_range(), step values smaller
than one or larger than the "stop" value are ignored. This prevents
bit_nset() from being called with out-of-range values.
Bug found by Dave G. of Supernetworks.
deraadt [Mon, 19 Aug 2024 14:46:41 +0000 (14:46 +0000)]
whitespaces
deraadt [Mon, 19 Aug 2024 14:24:24 +0000 (14:24 +0000)]
now that suspend operations are done as quiesce, we can try to use
the MXT_T7_POWER_MODE_DEEP_SLEEP operation.
jsg [Mon, 19 Aug 2024 13:01:47 +0000 (13:01 +0000)]
correctly indent a line
job [Mon, 19 Aug 2024 12:44:33 +0000 (12:44 +0000)]
Prepare for releasing version 9.2
jsg [Mon, 19 Aug 2024 11:18:29 +0000 (11:18 +0000)]
correct vm_fault_gtt() merge error in rev 1.19
fixes panic when starting X on x40 (855GM gen 2)
problem with 945GM (gen 3) and G41 (gen 4) reported by semarie@
kettenis [Mon, 19 Aug 2024 09:26:58 +0000 (09:26 +0000)]
Use M_WAITOK where we can; this includes during autoconf where the only
realistic option is to panic if we're doing smallish allocations and run
out of memory.
ok deraadt@
nicm [Mon, 19 Aug 2024 08:31:36 +0000 (08:31 +0000)]
Allow REP to work with Unicode characters, GitHub issue 3687.
nicm [Mon, 19 Aug 2024 08:29:16 +0000 (08:29 +0000)]
Both terminators \007 and \033\\ leave the index pointing to the final
character of the terminator, so correct the size calculation to always
add one. GitHub issue 4082.
jsg [Mon, 19 Aug 2024 08:22:30 +0000 (08:22 +0000)]
avoid NULL deref if malloc fails
ok stsp@
jsg [Mon, 19 Aug 2024 08:07:16 +0000 (08:07 +0000)]
avoid uninitialised var use introduced in rev 1.63
found by smatch, ok bluhm@
florian [Mon, 19 Aug 2024 07:28:22 +0000 (07:28 +0000)]
Get rid of inet_aton(3).
inet_aton(3) is not a good interface to figure out if something looks
like an IP address and a reverse DNS lookup should be performed.
The modern way to do this is to chain getaddrinfo(3) with
getnameinfo(3). As a bonus this gives us reverse lookup for IPv6, too.
OK kn
jmc [Mon, 19 Aug 2024 07:28:00 +0000 (07:28 +0000)]
add missing apostrophe;
jmc [Mon, 19 Aug 2024 07:23:26 +0000 (07:23 +0000)]
robert burns: to a mouse
-The best laid schemes o' mice an' men gang aft a-gley{,}:\
+The best laid schemes o' mice an' men gang aft agley{,}:\
most sources i've checked use "best-laid", but not all, so i've erred
on the side of caution;
jmc [Mon, 19 Aug 2024 07:12:57 +0000 (07:12 +0000)]
catharine howard -> catherine howard;
jmc [Mon, 19 Aug 2024 06:54:13 +0000 (06:54 +0000)]
opration -> operation;
jmc [Mon, 19 Aug 2024 06:53:44 +0000 (06:53 +0000)]
promitto: promise, not primise
jmc [Mon, 19 Aug 2024 06:52:16 +0000 (06:52 +0000)]
fix double space;
florian [Mon, 19 Aug 2024 06:00:18 +0000 (06:00 +0000)]
Replace inet_aton / gethostbyname with getaddrinfo.
test & OK jmatthew
florian [Mon, 19 Aug 2024 05:58:41 +0000 (05:58 +0000)]
Replace too flexible inet_aton(3) with getaddrinfo(3).
0xdecafbad will no longer work as an IPv4 address, sorry.
OK bluhm
jsg [Mon, 19 Aug 2024 03:08:27 +0000 (03:08 +0000)]
test malloc return against NULL not 0
deraadt [Mon, 19 Aug 2024 01:43:23 +0000 (01:43 +0000)]
move ed/tests files to regress/bin/ed, where they are used
deraadt [Mon, 19 Aug 2024 01:04:10 +0000 (01:04 +0000)]
file not needed
deraadt [Mon, 19 Aug 2024 01:03:12 +0000 (01:03 +0000)]
spelling error, fixed by "snj", 21 years ago in some other repository
deraadt [Mon, 19 Aug 2024 00:58:09 +0000 (00:58 +0000)]
21 years ago someone called "jsm" modified another version of this which is
also being distributed, with commit message "Fix capitalisation of compass directions."
Seems sensible.
deraadt [Mon, 19 Aug 2024 00:52:04 +0000 (00:52 +0000)]
fix a spelling error found by Ceri Davis 18 years ago.
deraadt [Mon, 19 Aug 2024 00:03:12 +0000 (00:03 +0000)]
pvbus_activate does nothing except call config_activate_children
(4 possible cases). it does not need to exist. encoding NULL
into the cfattach structure does the same thing.
deraadt [Mon, 19 Aug 2024 00:01:40 +0000 (00:01 +0000)]
call activate functions of children in the correct place.
deraadt [Sun, 18 Aug 2024 22:06:40 +0000 (22:06 +0000)]
whitespaces
bluhm [Sun, 18 Aug 2024 21:04:29 +0000 (21:04 +0000)]
Use define to test bounce buffer in amd64 bus dma.
To debug bounce buffers easily on non-SEV hardware, introduce a
define FORCE_BOUNCE_BUFFER that activates them. Default is off,
no functional change.
OK miod@
deraadt [Sun, 18 Aug 2024 20:28:41 +0000 (20:28 +0000)]
oops, forgot variable
tb [Sun, 18 Aug 2024 20:24:11 +0000 (20:24 +0000)]
Use OPENSSL_config() instead of OPENSSL_load_builtin_modules()
deraadt [Sun, 18 Aug 2024 20:14:49 +0000 (20:14 +0000)]
fix comment
deraadt [Sun, 18 Aug 2024 20:08:58 +0000 (20:08 +0000)]
fix comment
deraadt [Sun, 18 Aug 2024 19:58:35 +0000 (19:58 +0000)]
whitespace
phessler [Sun, 18 Aug 2024 19:44:10 +0000 (19:44 +0000)]
unregister softraid sensors when the volumes are removed
From Sven M. Hallberg
tested and OK phessler@
OK mvs@
tb [Sun, 18 Aug 2024 17:50:10 +0000 (17:50 +0000)]
conf_def.c: shuffle things into a slightly more sensible
Reduces upcoming diffs and avoids annoying prototypes.
deraadt [Sun, 18 Aug 2024 15:50:47 +0000 (15:50 +0000)]
don't need to put config_activate_children inside cfattach, because
NULL means the same
ok kettenis
deraadt [Sun, 18 Aug 2024 15:09:49 +0000 (15:09 +0000)]
Driver was not calling the child activate functions in the correct way.
There is a child -- wsmouse, which has an activate function, so this
is another oversight...
deraadt [Sun, 18 Aug 2024 15:03:01 +0000 (15:03 +0000)]
For DVACT_RESUME, let the children know we are ready *after* calling
our own wakeup(). The wakeup() won't result in anything running now
because DVACT_RESUME is running in "cold !=0, interrupts blocked,
scheduler stopped", but it is idiomatically incorrect to inform your
children you are ready before you are ready.
phessler [Sun, 18 Aug 2024 14:58:47 +0000 (14:58 +0000)]
add qwz firmware
deraadt [Sun, 18 Aug 2024 14:42:56 +0000 (14:42 +0000)]
Most audio drivers were incorrectly (or not at all) informing their children
about suspend/resume related events, and they all have audio.c as a child,
which definately needs to know!
ok ratchov
deraadt [Sun, 18 Aug 2024 14:35:14 +0000 (14:35 +0000)]
there are azalia that will fail to attach. in the activate function for
DVACT_QUIESCE, this was handled by doing nothing. however, the other
DVACT methods were still trying to touch the device. This needs to
bail out earlier.
ok ratchov
kettenis [Sun, 18 Aug 2024 11:10:10 +0000 (11:10 +0000)]
Add Meteor Lake support.
ok jsg@
kettenis [Sun, 18 Aug 2024 11:08:47 +0000 (11:08 +0000)]
Don't short-circuit interrupt handling when the sc_dying flag is set. Just
don't forward reports to the child drivers instead. This fixes an issue
with hardware that sends an interrupt in response to a reset request when
a level-triggered interrupt is used. In that case the interrupt would
just keep triggering when we issue a reset when we resume (when sc_dying
is set) since we didn't clear the interrupt condition by reading from the
device.
ok mlarkin@, deraadt@
tb [Sun, 18 Aug 2024 11:04:55 +0000 (11:04 +0000)]
Remove documentation for X509_REQ_[gs]et_extension_nids
These functions have been disabled for a while and they will be removed
in the next major bump.
kettenis [Sun, 18 Aug 2024 10:50:22 +0000 (10:50 +0000)]
Some machines have more than one DCP, so apldcp(4) can attach multiple
times. So make the task pool private to each instance to avoid
initializing the pool again, which would panic the kernel.
ok tobhe@
tb [Sun, 18 Aug 2024 10:02:10 +0000 (10:02 +0000)]
Drop OpenSSL 3.0 interop testing infrastructure
The openssl 3.0 port was removed nearly a year ago shortly after the 7.4
release.
tb [Sun, 18 Aug 2024 09:14:17 +0000 (09:14 +0000)]
Add support for openssl32 in interop test
mpi [Sun, 18 Aug 2024 08:23:58 +0000 (08:23 +0000)]
Get rid of intermediate copy before passing events to userland.
From Christian Ludwig with some tweaks.
mpi [Sun, 18 Aug 2024 08:18:49 +0000 (08:18 +0000)]
Do not cache pages belonging to memory ranges with a `use' count.
Such pages belong to the DMA or ISA memory ranges and caching them
accelerate their exhaustion. On amd64, at least, the kernel relies
on having low pages available at any time and cannot recover from
their exhaustion.
Should prevent livelocks reported by jsg@ and tb@ on amd64.
ok deraadt@
mpi [Sun, 18 Aug 2024 08:01:03 +0000 (08:01 +0000)]
Remove outdated comment about UVM_PLA_WAITOK and the pagedaemon.
ok miod@, mlarkin@
stsp [Sun, 18 Aug 2024 07:34:45 +0000 (07:34 +0000)]
plug a memory leak in qwx(4) by freeing vifs when the interface goes down
deraadt [Sun, 18 Aug 2024 03:25:04 +0000 (03:25 +0000)]
add missing child activate handling, found due to idiom inspection
tested by phessler, input from kettenis
deraadt [Sun, 18 Aug 2024 02:59:51 +0000 (02:59 +0000)]
Upon resume, run usb_attach_roothub() in DVACT_WAKEUP rather than DVACT_RESUME.
The usb root hub is a software construct, not actual hardware, and the code
has a potential to reach sleeping points (which won't work because DVACT_RESUME
runs cold).
deraadt [Sun, 18 Aug 2024 02:53:08 +0000 (02:53 +0000)]
If FADT indicates FADT_POWER_S0_IDLE_CAPABLE, print "S0ix" instead
of "S0" on the acpi: sleep states line. (In my view, this flag-bit
announces that the hardware vendor + bios vendor + microsoft have agreed
this machine has enough "features" that S0 suspend is about as good or
better than S3, for various criteria).
ok kettenis mlarkin