krw [Wed, 24 Feb 2021 16:18:59 +0000 (16:18 +0000)]
Remove incomplete/incorrect connection with autoconf, clearing ground
for future attempts at making it more IPv6-like.
ok florian@
deraadt [Wed, 24 Feb 2021 16:12:42 +0000 (16:12 +0000)]
show AF for DNS proposal messages; ok claudio bluhm
visa [Wed, 24 Feb 2021 14:59:52 +0000 (14:59 +0000)]
kqueue: Revise filterops interface
Extend kqueue's filterops interface with new callbacks so that it
becomes easier to use with fine-grained locking. The new interface
delegates the serialization of kn_event access to event sources. Now
kqueue uses filterops callbacks to read or write kn_event. This hides
event sources' locking patterns from kqueue, and allows clean
implementation of atomic read-and-clear for EV_CLEAR, for instance.
There are so many existing filterops instances that converting all of
them in one go is tricky. This patch adds a wrapper mechanism that
kqueue uses when the new callbacks are missing.
The new filterops interface has been influenced by XNU's kqueue.
OK mpi@ semarie@
lum [Wed, 24 Feb 2021 14:17:18 +0000 (14:17 +0000)]
Various fixes from emails Joachim Nilsson sent to tech@ many moons
ago. Sorry for the delay.
- Make sure we don't deref NULL ptr in skipwhite()
- Only deref vendp if not NULL
- Strings must be at least 2 chars for terminating NUL character
lum [Wed, 24 Feb 2021 13:58:46 +0000 (13:58 +0000)]
snprintf() does indeed return an int. From an email Joachim Nilsson
sent to tech@ many moons ago. Sorry for the delay.
jmc [Wed, 24 Feb 2021 13:36:19 +0000 (13:36 +0000)]
spelling fix;
bluhm [Wed, 24 Feb 2021 13:19:48 +0000 (13:19 +0000)]
In sorflush() use m_purge() instead of handrolling it.
no objections mvs@
dlg [Wed, 24 Feb 2021 12:33:50 +0000 (12:33 +0000)]
white space tweak, no functional change
dlg [Wed, 24 Feb 2021 12:33:22 +0000 (12:33 +0000)]
fix stoeplitz_n16 and stoeplitz_h16
patrick [Wed, 24 Feb 2021 10:13:08 +0000 (10:13 +0000)]
Enumerate GCI core, which seems to contain the OTP on the Apple M1.
nicm [Wed, 24 Feb 2021 09:22:15 +0000 (09:22 +0000)]
Correct client_prefix so it returns 1 if in prefix, not 0.
dlg [Wed, 24 Feb 2021 08:23:04 +0000 (08:23 +0000)]
whitespace tweaks, no functional change.
dlg [Wed, 24 Feb 2021 06:44:54 +0000 (06:44 +0000)]
fix the length check on arp packets when handling arp filter rules.
another bridge feature i'm not convinced people actually use.
ok jmatthew@ claudio@
deraadt [Wed, 24 Feb 2021 06:17:08 +0000 (06:17 +0000)]
sync
jsg [Wed, 24 Feb 2021 04:06:45 +0000 (04:06 +0000)]
remove unused usbd_get_device_string()
ok mpi@
jsg [Wed, 24 Feb 2021 03:54:05 +0000 (03:54 +0000)]
remove unused usbdi functions
ok mpi@
dlg [Wed, 24 Feb 2021 03:20:48 +0000 (03:20 +0000)]
add support for adding and deleting mac addr entries on nvgre.
the guts of this are in the etherbridge code which i added for
veb and used in bpe. there's a bit of boilerplate to make sure that
the addresses used for the endpoints will work with the tunnel
addresses that have been configured, but it's not too bad.
again, this is hard to use because ifconfig doesnt (yet) know how
to put ethernet addresses into the "add address" ioctl.
these ioctls could be used for things like evpn via bgpd though.
not sure if that's interesting to anyone though. it would probably
be more useful on vxlan interfaces.
jsg [Wed, 24 Feb 2021 03:08:47 +0000 (03:08 +0000)]
remove unused xhci_cmd_evaluate_ctx()
ok mpi@
deraadt [Wed, 24 Feb 2021 02:43:29 +0000 (02:43 +0000)]
sync
dlg [Wed, 24 Feb 2021 02:04:03 +0000 (02:04 +0000)]
add support for adding and deleting address table entries.
the guts of this are in the etherbridge code which i just added for
veb, so this code is very minimal. it's hard to use though cos
ifconfig doesnt (yet) know how to put ethernet addresses into the
"add address" ioctl.
dlg [Wed, 24 Feb 2021 01:20:03 +0000 (01:20 +0000)]
add support for adding and deleting address table entries.
dtucker [Wed, 24 Feb 2021 01:18:08 +0000 (01:18 +0000)]
Put obsolete aliases for hostbasedalgorithms and pubkeyacceptedalgorithms
after their current names so that the config-dump mode finds and uses
the current names. Spotted by Phil Pennock.
deraadt [Tue, 23 Feb 2021 23:52:40 +0000 (23:52 +0000)]
typo
dlg [Tue, 23 Feb 2021 23:42:17 +0000 (23:42 +0000)]
handle ifconfig veb0 flush with etherbridge_flush, like bpe and nvgre
djm [Tue, 23 Feb 2021 21:55:08 +0000 (21:55 +0000)]
lots more s/key types/signature algorithms/ mostly in
HostbasedAcceptedAlgorithms and HostKeyAlgorithms;
prompted by Jakub Jelen
djm [Tue, 23 Feb 2021 21:50:18 +0000 (21:50 +0000)]
Correct reference to signature algorithms as keys; from Jakub Jelen
tb [Tue, 23 Feb 2021 20:36:16 +0000 (20:36 +0000)]
Make this test module aware so it passes with Go 1.16
tb [Tue, 23 Feb 2021 20:33:46 +0000 (20:33 +0000)]
Make this test module aware so it passes with Go 1.16
tobhe [Tue, 23 Feb 2021 19:43:54 +0000 (19:43 +0000)]
Use pool to allocate tdbs.
ok patrick@ bluhm@
lum [Tue, 23 Feb 2021 18:45:33 +0000 (18:45 +0000)]
Move -u to alphabetically correct place in options. As spotted by jmc@
kettenis [Tue, 23 Feb 2021 17:02:02 +0000 (17:02 +0000)]
aplintc(4)
kettenis [Tue, 23 Feb 2021 17:01:17 +0000 (17:01 +0000)]
Add aplintc(4), a driver for the interrupt controller found on
Apple M1 SoCs.
ok patrick@
deraadt [Tue, 23 Feb 2021 15:58:19 +0000 (15:58 +0000)]
sync
cheloha [Tue, 23 Feb 2021 15:47:53 +0000 (15:47 +0000)]
sparc64/clock.c: use ANSI-style function definitions
While here, zap a few ARGUSED linter comments.
Compile-tested by deraadt@.
ok deraadt@
mvs [Tue, 23 Feb 2021 15:13:58 +0000 (15:13 +0000)]
Wrap by netlock the whole foreach loop which calls switch_port_detach() in
switch_clone_destroy(). This fixes netlock assertion within underlay
ifpromisc(). The problem was reported by hrvoje@ [1].
"why not" by deraadt@
1. https://marc.info/?l=openbsd-bugs&m=
161338077403538&w=2
mvs [Tue, 23 Feb 2021 14:57:52 +0000 (14:57 +0000)]
Fix m_copyback(9) prototype in DESCRIPTION section.
ok millert@
deraadt [Tue, 23 Feb 2021 14:27:16 +0000 (14:27 +0000)]
previous commit mismanaged the control fd
ok claudio
claudio [Tue, 23 Feb 2021 14:25:29 +0000 (14:25 +0000)]
Adjust pledge() and unveil() calls for proc_rsync() a bit. Since the
mkdir was moved to the main process there is no need for access to .
in the rsync process.
OK job@ deraadt@
deraadt [Tue, 23 Feb 2021 14:18:59 +0000 (14:18 +0000)]
sync
jsg [Tue, 23 Feb 2021 13:50:16 +0000 (13:50 +0000)]
remove unused malloc_roundup()
bluhm [Tue, 23 Feb 2021 12:14:10 +0000 (12:14 +0000)]
As ip_insertoptions() may prepend a mbuf, "goto bad" has to free
the new chain. This fixes a potential memory leak in ip_output().
Also simplify a bunch of "goto done".
OK kn@ mvs@
aoyama [Tue, 23 Feb 2021 11:48:21 +0000 (11:48 +0000)]
Make more efficient clearing interrupts on all processors at boot time.
Without this modification, because of the volatile qualifier, the
compiler does not produce four `` = 0 '' assignments, but code
equivalent to:
*(volatile uint32_t *)INT_ST_MASK3 = 0;
*(volatile uint32_t *)INT_ST_MASK2 =
*(volatile uint32_t *)INT_ST_MASK3;
*(volatile uint32_t *)INT_ST_MASK1 =
*(volatile uint32_t *)INT_ST_MASK2;
*(volatile uint32_t *)INT_ST_MASK0 =
*(volatile uint32_t *)INT_ST_MASK1;
Anders Gavare reported to Miod Vallat, and he gave me a diff.
dlg [Tue, 23 Feb 2021 11:44:53 +0000 (11:44 +0000)]
small adjustment of the deck chairs, no functional change.
dlg [Tue, 23 Feb 2021 11:43:41 +0000 (11:43 +0000)]
fix up which link flags do what.
ipsec code is written, but is disabled, so the ipsec words here are
still commented out for now.
mvs [Tue, 23 Feb 2021 11:43:40 +0000 (11:43 +0000)]
Use NULL instead of 0 in `m_nextpkt' assignment.
ok deraadt@ dlg@
dlg [Tue, 23 Feb 2021 11:40:28 +0000 (11:40 +0000)]
make a start on transparent ipsec interception, based on bridge(4).
i found the Transparent Network Security Policy Enforcement paper
by angelos and jason was useful for understanding the background
and why you'd want to do this.
the implementation is a little bit different to the bridge one
because i've tweaked the order that pf and ipsec processing happens,
depending on which direction the packet is going over the bridge.
bridge always runs ipsec processing before pf, no matter which
direction the packet is going. packets going into veb, pf runs first
and then ipsec input processing is allowed to happen. in the outgoing
direction ipsec happens first and then pf. pf runs before ipsec in
the inbound direction so pf can apply policy to ipsec encapsulated
packets before they hit pf. this allows you to apply policy to both
the encrypted and unencrypted packets in both directions.
the code is disabled for now. this is mostly because i want veb(4)
to have a good chance at operating outside the netlock, and i'm
pretty sure the ipsec stack isn't ready for that yet. the other
reason why it's disabled is getting a test setup is effort, but i
want to sleep.
jsg [Tue, 23 Feb 2021 11:22:20 +0000 (11:22 +0000)]
remove unused uvm_mapent_bias()
ok mpi@
mpi [Tue, 23 Feb 2021 10:41:59 +0000 (10:41 +0000)]
Move `pgo_fault' handler outside of uvm_fault_lower().
Reduce differences with NetBSD and prepare for `uobj' locking.
No functionnal change. ok chris@, kettenis@
jsg [Tue, 23 Feb 2021 10:20:10 +0000 (10:20 +0000)]
remove some unused includes
dlg [Tue, 23 Feb 2021 09:51:08 +0000 (09:51 +0000)]
use the ipv6 dst addr to look up an ipsec tdb in bridge_ipsec in.
using the ipv6 next protocol header probably doesnt work. it also
probably doesnt matter cos i'm not sure anyone uses this feature in
bridge. or maybe there isn't anyone who uses ipv6. both are plausible
options.
hahaha^Wok patrick@
lum [Tue, 23 Feb 2021 08:10:51 +0000 (08:10 +0000)]
Allow the user to specify a path to the mg startup file on the command line.
dlg [Tue, 23 Feb 2021 07:29:07 +0000 (07:29 +0000)]
use link0 to allow vlans to cross the bridge.
dlg [Tue, 23 Feb 2021 05:23:02 +0000 (05:23 +0000)]
implement support for the blocknonip port flag.
dlg [Tue, 23 Feb 2021 05:01:00 +0000 (05:01 +0000)]
add support for setting and getting bridge port flags.
cheloha [Tue, 23 Feb 2021 04:44:30 +0000 (04:44 +0000)]
timecounting: use C99-style initialization for all timecounter structs
The timecounter struct is large and I think it may change in the
future. Changing it later will be easier if we use C99-style
initialization for all timecounter structs. It also makes reading the
code a bit easier.
For reasons I cannot explain, switching to C99-style initialization
sometimes changes the hash of the resulting object file, even though
the resulting struct should be the same. So there is a binary change
here, but only sometimes. No behavior should change in either case.
I can't compile-test this everywhere but I have been staring at the
diff for days now and I'm relatively confident this will not break
compilation. Fingers crossed.
ok gnezdo@
dlg [Tue, 23 Feb 2021 04:40:27 +0000 (04:40 +0000)]
filter MAC Bridge component Reserved address
im considering converting ethernet addresses into uint64_ts to make
comparisons (and masking) easier. im trialling it here, and it
doesn't seem like the worst.
dlg [Tue, 23 Feb 2021 04:13:17 +0000 (04:13 +0000)]
try and use my words to explain what veb is and does.
ok jmatthew@
dlg [Tue, 23 Feb 2021 03:30:04 +0000 (03:30 +0000)]
add veb(4), a Virtual Ethernet Bridge driver.
my intention is to replace bridge(4), but the way it works is
different enough from from bridge that a name change is justified
to distinguish them. it also makes it easier to commit it to the
tree and work on it in parallel to bridge, and allows a window of
migration.
the main difference between veb(4) and bridge(4) is how they use
interfaces as ports. veb takes over interfaces completely and only
uses them to receive and transmit ethernet packets. bridge also use
each interface as a port to the ethernet segment it's connected to,
but also tries to continue supporting the use of the interface as
a way to talk to the network stack on the local system. supporting
the use of interfaces for both external and local communication is
where most of my confusion with bridge comes from, both when i'm
trying to operate it and also understand the code. changing this
semantic is where most of the simplification in veb comes from
compared to bridge.
because veb takes over interfaces, the ethernet network set up on
a veb is isolated from the host network stack. by default veb does
not interact with pf or the ip (and mpls) stacks. to enable pf for
ip frames going over veb ports link1 on the veb interface must be
set. to have the stack interact with a veb network, vport interfaces
must be created and added as ports to a veb.
the vport interface driver is provided as part of veb, and is handled
specially by veb. veb usually prevents the use of ports by the stack
for sending an receiving packets, but that's why vports exist, so
veb has special handling for them.
veb already supports a lot of the other features that bridge has,
including bridge rules and protected domains, but i got tired of
working out of the tree and stopped implementing them. the main
outstanding features is better address table management, the
blocknonip flag on ports, transparent ipsec interception, and
spanning tree. i may not bother with spanning tree unless someone
tells me that they actually use it.
the core ethernet learning bridge functionality is provided by the
etherbridge code that was factored out of nvgre and bpe. veb is
already (a lot) faster than bridge, and is better prepared to operate
in parallel on multiple CPUs concurrently.
thanks to hrvoje popovski for testing some earlier versions of this.
discussed with many
ok patrick@ jmatthew@
deraadt [Tue, 23 Feb 2021 02:42:58 +0000 (02:42 +0000)]
sync
djm [Tue, 23 Feb 2021 00:05:31 +0000 (00:05 +0000)]
warn when the user specifies a ForwardAgent path that does not exist
and exit if ExitOnForwardFailure is set; bz3264
jsg [Tue, 23 Feb 2021 00:03:01 +0000 (00:03 +0000)]
remove unused acpiec_lock() acpiec_unlock() functions
ok kettenis@ pirofti@
jsg [Mon, 22 Feb 2021 23:43:59 +0000 (23:43 +0000)]
remove unused decode_hw_header() function
ok krw@
kettenis [Mon, 22 Feb 2021 23:17:50 +0000 (23:17 +0000)]
Terminate backtrace of secondary processors in ddb.
From miod@
kettenis [Mon, 22 Feb 2021 21:58:25 +0000 (21:58 +0000)]
Mark as arm64-specific.
tobhe [Mon, 22 Feb 2021 21:58:12 +0000 (21:58 +0000)]
Don't pass 'id' as argument to make function signature match similar
functions. config_setpfkey() is always called with id PROC_IKEV2.
kettenis [Mon, 22 Feb 2021 21:51:48 +0000 (21:51 +0000)]
Enable bge(4).
kettenis [Mon, 22 Feb 2021 21:47:47 +0000 (21:47 +0000)]
Enable apldog(4).
kettenis [Mon, 22 Feb 2021 21:42:17 +0000 (21:42 +0000)]
apldog(4)
kettenis [Mon, 22 Feb 2021 21:30:54 +0000 (21:30 +0000)]
Add apldog(4), a driver for the watchdog on Apple M1 SoCs.
This allows us to reboot the machine.
ok patrick@
mvs [Mon, 22 Feb 2021 19:14:01 +0000 (19:14 +0000)]
Move UNIX socket's garbage collector to `systqmp'. It touches nothing
which requires kernel lock to be held.
ok mpi@
patrick [Mon, 22 Feb 2021 18:55:23 +0000 (18:55 +0000)]
Disable double-data rate modes if 1.8V signalling is not possible.
ok kettenis@
patrick [Mon, 22 Feb 2021 18:53:26 +0000 (18:53 +0000)]
Slow mode is only relevant for legacy and high speed timings.
ok kettenis@
kettenis [Mon, 22 Feb 2021 18:32:02 +0000 (18:32 +0000)]
Improve support for the variant found on the Apple M1 SoC.
This mostly adjust the interrupt masking and status support since this
variant lacks the UINTM and UINTP registers.
ok patrick@
martijn [Mon, 22 Feb 2021 17:15:02 +0000 (17:15 +0000)]
Make the ober_get_* set of function to accept a NULL-pointer.
This allows us to do ber-type checking inside ober_scanf_elements, which
will allow for stricter ASN.1 parsing in the future.
Manpage feedback and OK claudio@, jmc@
OK claudio@
tb [Mon, 22 Feb 2021 16:15:49 +0000 (16:15 +0000)]
Fix bizarre punctuation and capitalization in a comment.
tb [Mon, 22 Feb 2021 16:13:31 +0000 (16:13 +0000)]
Simplify version checks in the TLSv1.3 client
Ensure that the server announced TLSv1.3 (and nothing higher) in the
supported_versions extension. In that case, the legacy_version must
be TLSv1.2 according to RFC 8446, 4.1.3 and 4.2.1.
This commit also removes some unreachable code which is a remnant of
very early TLSv1.3 code from before the legacy fallback was introduced.
Simplify a few checks and adjust some comments nearby.
ok jsing
jsing [Mon, 22 Feb 2021 15:59:10 +0000 (15:59 +0000)]
Factor out/change some of the legacy client version handling code.
This consolidates the version handling code and will make upcoming changes
easier.
ok tb@
bluhm [Mon, 22 Feb 2021 13:04:56 +0000 (13:04 +0000)]
When cutting of the head of an overlapping fragment during pf
reassembly, reinsert the fragment into the lookup table with correct
index.
Reported-by: syzbot+d043455a5346f726f1c4@syzkaller.appspotmail.com
OK claudio@
robert [Mon, 22 Feb 2021 11:49:35 +0000 (11:49 +0000)]
add 7.0 syspatch pubkey
nicm [Mon, 22 Feb 2021 11:42:50 +0000 (11:42 +0000)]
expand_paths needs the global environment to be set up, do that first.
martijn [Mon, 22 Feb 2021 11:31:09 +0000 (11:31 +0000)]
Make use of the new '$' feature of ober_scanf_elements to enforce stricter
ASN.1 verification.
OK claudio@
claudio [Mon, 22 Feb 2021 09:46:05 +0000 (09:46 +0000)]
Rename mkpath() to mkpathat() since it uses mkdirat() internally.
nicm [Mon, 22 Feb 2021 08:31:19 +0000 (08:31 +0000)]
Fix regex searching with wrapped lines, from Anindya Mukherjee; GitHub
issue 2570.
nicm [Mon, 22 Feb 2021 08:18:13 +0000 (08:18 +0000)]
Move config file path expansion much earlier, keep the list of paths
around rather than freeing later, and add a config_files format variable
containing it. Suggested by kn@ a while back.
nicm [Mon, 22 Feb 2021 07:09:06 +0000 (07:09 +0000)]
There are many format variables now so allocating all the default ones
each time a tree is created is too expensive. Instead, convert them all
into callbacks and put them in a static table so they only allocate on
demand. The tree remains for the moment for extra (non-default)
variables added by for example copy mode or popups. Also reduce
expensive calls to localtime_r/strftime. GitHub issue 2253.
nicm [Mon, 22 Feb 2021 06:53:04 +0000 (06:53 +0000)]
Move jump commands to grid reader, make them UTF-8 aware, and tidy up,
from Anindya Mukherjee.
krw [Mon, 22 Feb 2021 02:19:03 +0000 (02:19 +0000)]
Switch reboot timing to timespec, the better to handle the
default reboot interval of 1 sec. Gives the DHCP server a
fairer shot at replying before the timeout expires.
ok millert@
jmatthew [Mon, 22 Feb 2021 01:24:59 +0000 (01:24 +0000)]
Use the F_CHECK_SENT and F_CHECK_DONE flags to determine whether a
previous attempt at running a check script has finished yet, so we
can avoid building up a backlog of check requests.
ok dlg@ tb@ giovanni@
jsg [Mon, 22 Feb 2021 01:18:01 +0000 (01:18 +0000)]
regen
jsg [Mon, 22 Feb 2021 01:17:23 +0000 (01:17 +0000)]
add some AMD 500 series, 17h/71h, Navi 10 and Kingston NVMe ids
initial diff from Sven Wolf
tb [Sun, 21 Feb 2021 19:21:15 +0000 (19:21 +0000)]
PATH does not include '.' anymore. Fix the runs test for that situation.
krw [Sun, 21 Feb 2021 18:16:59 +0000 (18:16 +0000)]
Rename struct client_config fields 'timeout', 'link_timeout' and
'reboot_timeout' to 'offer_interval', 'link_interval' and
'reboot_interval' to be consistant with other '_interval' fields that
specify a number of seconds to wait.
jmc [Sun, 21 Feb 2021 17:18:01 +0000 (17:18 +0000)]
exclamation mark needs escaped too;
deraadt [Sun, 21 Feb 2021 15:56:25 +0000 (15:56 +0000)]
how about sticking to standard C.
tobhe [Sun, 21 Feb 2021 14:55:16 +0000 (14:55 +0000)]
Add cryptox(4), a driver for armv8 cryptographic extensions.
The driver currently only supports AES-CBC mode but can easily
be extended to other algorithms and modes.
The aesv8-armx.S file was generated from the CRYPTOGAMS project.
Asked to commit by and ok patrick@
krw [Sun, 21 Feb 2021 14:30:29 +0000 (14:30 +0000)]
No need for state_preboot() to double check timeout being
tracked in tick_msg() and explicitly calling tick_msg(TICK_SLEEP).
One fewer use of each of time(), ifi->startup_time and
config->link_timeout. Makes code easier to follow.
No intentional functional change.
tobhe [Sun, 21 Feb 2021 14:21:37 +0000 (14:21 +0000)]
Don't explicitly send address family in IMSG_VROUTE_ADD. The receiving
process parses af from the sockaddrs.
ok patrick@
kettenis [Sun, 21 Feb 2021 13:14:47 +0000 (13:14 +0000)]
One CPUs that implement the VHE extension and have the E2H bit set, keep
running the kernel in EL2.
ok patrick@
sthen [Sun, 21 Feb 2021 10:38:42 +0000 (10:38 +0000)]
Add ping -g, a concise display format similar to that used by other
network devices that shows one character per echo request (! for normal
response, . for timed out, D for duplicate, T for truncated) making
it easier to identify patterns of loss over periods of time.
ok remi@ kn@, feedback from deraadt@ chris@
!!!!!...!!!!!!!!!!!!!!!!!!!!!!!!!!!...!!!!!!!!!!!!!!!!!!!!!!!!!!!.........!!!!!!!!!!!!!!!!!!!!!...!!!!!!!!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!.........!!!!!!!!!!!!!!!!!!!!!...!!!!!!!!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!.........!!!!!!!!!!!!!!!!!!!!!...!!!!!!!!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!..........!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!..........!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!..........!!!!!!!!!!!!!!!!!!!!....!!!!!!!!!!!!!!!!!!!!!!!!!!.....!!!!!!!!!!!!!!
jmc [Sun, 21 Feb 2021 06:35:31 +0000 (06:35 +0000)]
zap duplicate .Nm;