jsing [Tue, 11 Apr 2017 13:14:08 +0000 (13:14 +0000)]
Revert ssl_asn1.c r1.50 - CBB and freezero(3) do not play nicely together.
Back this out while we investigate and implement a solution.
Found the hard way by sthen@
espie [Tue, 11 Apr 2017 11:01:28 +0000 (11:01 +0000)]
document more thoroughly the special status of modules gnu, imake, perl5
(for historical reasons)
okay aja@
krw [Tue, 11 Apr 2017 10:40:14 +0000 (10:40 +0000)]
Fold priv_write_file() into its only remaining user
priv_write_resolv_conf() and move the latter into kroute.c
with all its priv_ friends.
No intentional functional change.
reyk [Tue, 11 Apr 2017 09:57:19 +0000 (09:57 +0000)]
Use freezero(3) for the imsg framework in imsg_free(3) and ibuf_free(3).
In our privsep model, imsg is often used to transport sensitive
information between processes. But a process might free an imsg, and
reuse the memory for a different thing. iked uses some
explicit_bzero() to clean imsg-buffer but doing it in the library with
the freezero() is less error-prone and also benefits other daemons.
OK deraadt@ jsing@ claudio@
kettenis [Tue, 11 Apr 2017 06:52:13 +0000 (06:52 +0000)]
Revise 'struct fpreg' and dump floating-point register in core dumps. Also
reset the floating-point register state upon exec.
ok guenther@
krw [Mon, 10 Apr 2017 21:47:44 +0000 (21:47 +0000)]
Rework -L logic to use the idiom used in handling the leases file.
i.e. open FILE during program set up and use the FILE created for
the rest of the program lifetime after dropping privilege and
pledge()'ing. No need for passing messages to the priv process.
Tweak lease file handling a bit in passing.
Monitoring the -L file with external programs like sysutils/entr
still works.
Looks good to sthen@.
schwarze [Mon, 10 Apr 2017 17:45:06 +0000 (17:45 +0000)]
new X25519(3) manual page;
from Dr. Stephen Henson <steve@openssl.org>, OpenSSL commit
d218f3c3
jsing [Mon, 10 Apr 2017 17:27:33 +0000 (17:27 +0000)]
Use freezero() for the internal opaque structures, instead of the current
explicit_bzero()/free(). Less code and potentially less overhead.
jsing [Mon, 10 Apr 2017 17:25:22 +0000 (17:25 +0000)]
Use freezero() for X25519 keys - same result with more readable code.
schwarze [Mon, 10 Apr 2017 17:14:44 +0000 (17:14 +0000)]
document three additional functions;
from Emilia Kasper <emilia at openssl dot org>, OpenSSL commit
4ac139b4
jsing [Mon, 10 Apr 2017 17:12:30 +0000 (17:12 +0000)]
Rework and significantly extend TLS name verification tests to match
changes in libtls.
jsing [Mon, 10 Apr 2017 17:11:13 +0000 (17:11 +0000)]
Rework name verification code so that a match is indicated via an argument,
rather than return codes. More strictly follow RFC 6125, in particular only
check the CN if there are no SAN identifiers present in the certificate
(per section 6.4.4).
Previous behaviour questioned by Daniel Stenberg <daniel at haxx dot se>.
ok beck@ jca@
deraadt [Mon, 10 Apr 2017 17:01:06 +0000 (17:01 +0000)]
sync
jsing [Mon, 10 Apr 2017 16:48:43 +0000 (16:48 +0000)]
freezero() the key block; simpler code and less of it.
jsing [Mon, 10 Apr 2017 16:47:08 +0000 (16:47 +0000)]
Use freezero() for i2d_SSL_SESSION() - one line of code instead of three.
In this case the memory allocated can also be significant, in which case
freezero() will have less overhead than explicit_bzero() (munmap instead
of touching all of the memory to write zeros).
jca [Mon, 10 Apr 2017 16:20:31 +0000 (16:20 +0000)]
Fix tabs in example code.
schwarze [Mon, 10 Apr 2017 16:11:50 +0000 (16:11 +0000)]
fix some .Xr errors that jmc@ found with mdoclint(1)
schwarze [Mon, 10 Apr 2017 15:54:46 +0000 (15:54 +0000)]
new manual page SSL_get_server_tmp_key(3)
from Matt Caswell <matt@openssl.org>, OpenSSL commit
508fafd8
schwarze [Mon, 10 Apr 2017 15:37:55 +0000 (15:37 +0000)]
Additional SSL_SESSION documentation
from Matt Caswell <matt at openssl dot org>, OpenSSL commit
b31db505.
Improve crosslinking while here.
jmc [Mon, 10 Apr 2017 14:46:13 +0000 (14:46 +0000)]
slaacdctl -> slaacctl;
visa [Mon, 10 Apr 2017 14:35:30 +0000 (14:35 +0000)]
Use __ASSEMBLER__ instead of __LANGUAGE_ASSEMBLY.
The latter is not defined by clang.
OK guenther@, kettenis@
deraadt [Mon, 10 Apr 2017 14:32:47 +0000 (14:32 +0000)]
Found another len += snprintf...
ok mikeb
deraadt [Mon, 10 Apr 2017 14:22:03 +0000 (14:22 +0000)]
sync
schwarze [Mon, 10 Apr 2017 14:00:51 +0000 (14:00 +0000)]
for pure *_ctrl() wrapper macros, move the reference from ssl(3)
to SSL_CTX_ctrl(3) to make ssl(3) slightly more palatable
fcambus [Mon, 10 Apr 2017 13:56:16 +0000 (13:56 +0000)]
Clean up disabled declaration in the text struct.
OK deraadt@
jsg [Mon, 10 Apr 2017 13:40:36 +0000 (13:40 +0000)]
sync
kettenis [Mon, 10 Apr 2017 13:36:04 +0000 (13:36 +0000)]
Generate and install arm_neon.h on arm and arm64.
ok jsg@
florian [Mon, 10 Apr 2017 13:35:42 +0000 (13:35 +0000)]
The canonical name for ctl programs is without 'd'.
Pointed out by Brad.
OK deraadt@
schwarze [Mon, 10 Apr 2017 13:05:06 +0000 (13:05 +0000)]
new manual page SSL_CTX_set_tlsext_servername_callback(3) for SNI;
from <Jon dot Spillett at oracle dot com>
via OpenSSL commit
8c55c461
reyk [Mon, 10 Apr 2017 09:27:08 +0000 (09:27 +0000)]
Check early if the mandatory carp "interface" was configured.
This allows the new -n config check to work correctly.
OK jsg@ deraadt@
fcambus [Mon, 10 Apr 2017 08:19:12 +0000 (08:19 +0000)]
Remove always false comparison: inosused type is ino_t, which is
unsigned.
While there, fix a whitespace issue.
OK deraadt@
jmc [Mon, 10 Apr 2017 06:31:31 +0000 (06:31 +0000)]
tweak previous;
jsing [Mon, 10 Apr 2017 06:09:32 +0000 (06:09 +0000)]
Convert various client key exchange functions to freezero(3). The memory
contents needs to be made inaccessible - this is simpler and less error
prone than the current "if not NULL, explicit_bzero(); free()" dance.
deraadt [Mon, 10 Apr 2017 05:47:33 +0000 (05:47 +0000)]
sync
otto [Mon, 10 Apr 2017 05:45:02 +0000 (05:45 +0000)]
Introducing freezero(3) a version of free that guarantees the process
no longer has access to the content of a memmory object. It does
this by either clearing (if the object memory remains cached) or
by calling munmap(2). ok millert@, deraadt@, guenther@
otto [Mon, 10 Apr 2017 05:10:56 +0000 (05:10 +0000)]
monir bump for freezero
jsg [Mon, 10 Apr 2017 02:15:54 +0000 (02:15 +0000)]
Attempt to map msk(4) interrupt via MSI.
The device tree that ships with the overdrive 1000 has an interrupt-map
property that is known to be wrong. Using MSI on msk makes the builtin
Ethernet on the overdrive 1000 work.
Tested on arm64 with
"Marvell Yukon
88E8059" rev 0x00, Yukon-2 Optima (0x1)
and i386 with
"Marvell Yukon
88E8072" rev 0x10, Yukon-2 Extreme rev. B0 (0x2)
Committing this early in the release cycle to try find cases where using
MSI doesn't work.
Based on part of an earlier patch from jmatthew@
ok jmatthew@ kettenis@
schwarze [Mon, 10 Apr 2017 01:46:37 +0000 (01:46 +0000)]
pasto; from <Jon dot Spillett at oracle dot com> via OpenSSL commit
3aaa1bd0
schwarze [Mon, 10 Apr 2017 01:26:54 +0000 (01:26 +0000)]
typo fix; from <Jon dot Spillett at oracle dot com>
via OpenSSL commit
7bd27895
kettenis [Sun, 9 Apr 2017 21:47:05 +0000 (21:47 +0000)]
Add a few missing quad-precision support functions on arm64 and reorder the
list to match what's in CMakeLists.txt.
ok sthen@
guenther [Sun, 9 Apr 2017 21:32:42 +0000 (21:32 +0000)]
Sync symbol lists for trap/interrupt frame detection with what ddb(4) uses
ok deraadt@
krw [Sun, 9 Apr 2017 20:44:13 +0000 (20:44 +0000)]
Seven casts, a couple of tweaks and CFLAGS+=-Wsign-compare for the
win.
No intentional functional change.
deraadt [Sun, 9 Apr 2017 19:59:43 +0000 (19:59 +0000)]
malloc -> mallocarray; a typo
dhill [Sun, 9 Apr 2017 18:16:00 +0000 (18:16 +0000)]
Convert some malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 18:15:32 +0000 (18:15 +0000)]
Convert a malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 18:15:09 +0000 (18:15 +0000)]
Convert a malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 18:14:39 +0000 (18:14 +0000)]
Convert a malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 18:09:41 +0000 (18:09 +0000)]
Convert some malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 18:07:19 +0000 (18:07 +0000)]
Convert some malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 18:05:17 +0000 (18:05 +0000)]
Convert some malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 17:57:58 +0000 (17:57 +0000)]
Use mallocarray to allocate multicast group memberships.
ok deraadt@
deraadt [Sun, 9 Apr 2017 15:47:18 +0000 (15:47 +0000)]
Correct wakeup() dance in sensor_task_work()
Problem noticed by krw
jsing [Sun, 9 Apr 2017 15:06:20 +0000 (15:06 +0000)]
Simplify/clean up BUF_MEM_grow_clean().
ok beck@
jsing [Sun, 9 Apr 2017 15:03:54 +0000 (15:03 +0000)]
With recallocarray() BUF_MEM_grow() is essentially the same as
BUF_MEM_grow_clean() (the only difference is clearing on internal down
sizing), so make it a wrapper.
ok beck@ deraadt@
jsing [Sun, 9 Apr 2017 14:33:21 +0000 (14:33 +0000)]
Explicitly test for NULL.
ok beck@
jsing [Sun, 9 Apr 2017 14:31:44 +0000 (14:31 +0000)]
Improve unknown protocol version handling.
natano [Sun, 9 Apr 2017 09:58:53 +0000 (09:58 +0000)]
Remove unused #define's and struct.
florian [Sun, 9 Apr 2017 09:13:28 +0000 (09:13 +0000)]
image/svg+xml is a default inbuilt media type.
Pointed out by Anton Lindqvist (anton.lindqvist AT gmail), thanks!
jsg [Sun, 9 Apr 2017 02:40:24 +0000 (02:40 +0000)]
Fix multiple cases of reading past the end of a buffer in the sasyncd(8)
config parser found with afl.
feedback and ok millert@ ok deraadt@
gsoares [Sat, 8 Apr 2017 22:59:09 +0000 (22:59 +0000)]
snprintf() format string should be literal
avoid compiler silly warnings
sure deraadt@
gsoares [Sat, 8 Apr 2017 22:50:41 +0000 (22:50 +0000)]
format string is better be literal
OK deraadt
kettenis [Sat, 8 Apr 2017 22:38:17 +0000 (22:38 +0000)]
For legacy interrupt use the tag of the topmost bridge to establish the
interrupt. We already correctly swizzle the pin.
ok patrick@
kettenis [Sat, 8 Apr 2017 22:31:33 +0000 (22:31 +0000)]
Bring over the changes I made to the armv7 version of this driver such that
interrupts are correctly routed to the boot cpu if that isn't the one
connected to CPU interface zero on the interrupt controller.
ok patrick@
naddy [Sat, 8 Apr 2017 20:53:54 +0000 (20:53 +0000)]
re-enable POOL_DEBUG after the release; ok deraadt@
schwarze [Sat, 8 Apr 2017 20:36:50 +0000 (20:36 +0000)]
use .Em for emphasis, not .Pa
krw [Sat, 8 Apr 2017 20:16:04 +0000 (20:16 +0000)]
Reduce the overburden of signed vs unsigned comparisons by sprinkling
'int' -> 'unsigned int' (and visa versa) where obvious.
Steal a couple of 'unsigned' -> u_int32_t from reyk@'s dhcrelay
tweaks.
No intentional functional change.
mlarkin [Sat, 8 Apr 2017 19:08:18 +0000 (19:08 +0000)]
change a log message from "warn" to "debug" level, as the condition it is
reporting is not actually a warning.
mlarkin [Sat, 8 Apr 2017 19:06:29 +0000 (19:06 +0000)]
implement nonspecific EOI mode for the legacy PIC
ok deraadt
mlarkin [Sat, 8 Apr 2017 19:06:04 +0000 (19:06 +0000)]
implement channels 1 and 2 of the legacy PIT.
ok otto, deraadt
krw [Sat, 8 Apr 2017 18:54:52 +0000 (18:54 +0000)]
Replace another snprintf() dance with easier to read code using
strlcat(). Shorter, clearer, fewer signed vs unsigned questions.
Use an 8K static buffer for pretty_print_classless() and use it
rather scribbling intermediate values into the final destination.
No intentional functional change.
krw [Sat, 8 Apr 2017 17:00:10 +0000 (17:00 +0000)]
Replace a mess of snprintf() dances with easier to read code using
strlcat(). Shorter, clearer, fewer signed vs unsigned questions.
Shrink static buffer for the string version of an option value from
32K to 8K. Since the string version of the entire lease is constructed
in a 8K buffer, bigger option values are pointless.
Use 8K of the saved space for a static buffer for pretty_print_string()
and use it rather scribbling intermediate values into the final
destination.
No intentional functional change.
ajacoutot [Sat, 8 Apr 2017 13:29:37 +0000 (13:29 +0000)]
Document the devel/meson MODULE.
visa [Sat, 8 Apr 2017 10:53:48 +0000 (10:53 +0000)]
Make network ports work on Shasta.
rpe [Sat, 8 Apr 2017 08:33:05 +0000 (08:33 +0000)]
- localize the if, file and stat variables which also ensures that
variables are not named like commands.
- change test from [] to [[]]
OK tb@ halex@
deraadt [Sat, 8 Apr 2017 04:06:01 +0000 (04:06 +0000)]
Sensors are run as callbacks inside tasks. During suspend a sensor
could be running inside a driver that will be force-detached, or due
to tsleep end up disrupting the softstate/hardstate contract. At
suspend time, quisce all these callbacks by waiting for completion.
This issue has never been observed for real, but may be implicated in
suspend/resume failures.
ok kettenis guenther mlarkin
jmatthew [Sat, 8 Apr 2017 03:36:50 +0000 (03:36 +0000)]
Use ADDR64 opcodes to specify 64bit DMA addresses for all buffers. This
consumes two ring entries per segment, halving the effective size of the
rings, but keeps things simple. This is required for the onboard nic
on the Overdrive 1000 to work.
ok kettenis@, tested on i386 by jsg@
mlarkin [Sat, 8 Apr 2017 03:29:13 +0000 (03:29 +0000)]
Remove some #if 0 code that dates back to r1.1
Pointed out by Michael W. Bombardieri
deraadt [Sat, 8 Apr 2017 02:57:23 +0000 (02:57 +0000)]
A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.
deraadt [Sat, 8 Apr 2017 01:20:10 +0000 (01:20 +0000)]
Two prototypes for acpi_maptable; merge to one place
rpe [Fri, 7 Apr 2017 22:53:25 +0000 (22:53 +0000)]
Minimize differences in ifstart() function between netstart and
install.sub which makes it easier to spot changes in the future.
- comments and formatting
- quotes on assignments are not needed (netstart)
- remove stray space in test (netstart)
- use $file variable with while-loop (netstart)
- although valid, instead of i use $i in arithmetic test (install.sub)
OK krw@, tb@
Looks good deraadt@
rpe [Fri, 7 Apr 2017 22:15:17 +0000 (22:15 +0000)]
Align comments of ifstart() function in netstart and install.sub.
rpe [Fri, 7 Apr 2017 22:02:29 +0000 (22:02 +0000)]
Sync variable names with netstart version of stripcom().
Use $_file variable instead of $1 with the wile-loop.
rpe [Fri, 7 Apr 2017 21:44:07 +0000 (21:44 +0000)]
Align comments of stripcom() function in netstart and install.sub.
rpe [Fri, 7 Apr 2017 21:00:42 +0000 (21:00 +0000)]
Extend the information shown by diskinfo() to help to identify
disks. Extract the disk information enclosed in <> and the NAA
from the last matching dmesg line. Useful if there are multiple
identically sized disk of the same type.
Suggested by jirib at devio dot us
Discussed with deraadt@
bluhm [Fri, 7 Apr 2017 17:33:45 +0000 (17:33 +0000)]
In ssl.h TLS 1.0 is called TLSv1. Adapt name in test to make it pass.
OK jsing@
bluhm [Fri, 7 Apr 2017 15:49:46 +0000 (15:49 +0000)]
Adapt test to new syslogd's local message priority.
bluhm [Fri, 7 Apr 2017 15:36:16 +0000 (15:36 +0000)]
Incoming TCP connections from clients fill the files of a log server.
A log client reconnects at every SIGHUP. Write these accept and
close messages with debug priority, then they can be turned on in
syslog.conf. Default is off.
While there, move a debug message and set the priority of the exit
message explicitly to error.
OK mpf@ millert@
krw [Fri, 7 Apr 2017 15:03:00 +0000 (15:03 +0000)]
Simply decoding of domain search option. No intentional functional
change.
visa [Fri, 7 Apr 2017 14:17:38 +0000 (14:17 +0000)]
Add prid for CN72xx/CN73xx.
visa [Fri, 7 Apr 2017 13:30:43 +0000 (13:30 +0000)]
Make SoC version available in a simple form.
jsing [Fri, 7 Apr 2017 08:48:30 +0000 (08:48 +0000)]
Use uint8_t instead of u_int8_t - for consistency and to make things easier
for portable.
From Raphael Hittich.
guenther [Fri, 7 Apr 2017 04:48:44 +0000 (04:48 +0000)]
si_addr should be of type void *, not char *
From Andrew Aldridge (i80and(at)foxquill.com)
ok millert@ mpi@
guenther [Fri, 7 Apr 2017 04:45:24 +0000 (04:45 +0000)]
Simplify the size calculation for memset()
From Anton Lindqvist (anton.lindqvist(at)gmail.com)
krw [Thu, 6 Apr 2017 22:41:39 +0000 (22:41 +0000)]
Inspired by recent dhcrelay(8) changes add some stricter CFLAGS. No code
changes needed (yet).
reyk [Thu, 6 Apr 2017 21:35:22 +0000 (21:35 +0000)]
"kernel" got renamed to "boot" in vm.conf but I didn't commit the parse.y bits.
Found by Pontus Lundkvist
OK deraadt
tedu [Thu, 6 Apr 2017 21:16:14 +0000 (21:16 +0000)]
replace some long if/else chains with a switch
tedu [Thu, 6 Apr 2017 21:14:12 +0000 (21:14 +0000)]
a little const here and there to prevent rules from changing
tedu [Thu, 6 Apr 2017 21:12:06 +0000 (21:12 +0000)]
prepenv can take a const rule
natano [Thu, 6 Apr 2017 19:09:45 +0000 (19:09 +0000)]
Remove the CD9660MAXPATH define. It was used to construct the path for
opening the file, so PATH_MAX makes more sense here. While there change
the code to do two less allocations per file.
ok deraadt
jmc [Thu, 6 Apr 2017 18:55:42 +0000 (18:55 +0000)]
less chatty EXAMPLES; from anton lindqvist