openbsd
21 months agoput man page in the right place
deraadt [Fri, 13 Jan 2023 15:49:26 +0000 (15:49 +0000)]
put man page in the right place

21 months agoUse extended header format for .wav files.
ratchov [Fri, 13 Jan 2023 15:14:24 +0000 (15:14 +0000)]
Use extended header format for .wav files.

According to Microsoft docs, it is needed if bits > 16 or if there are
more than 2 channels, which aucat supports and is the defaut. Fixes
errors reported by audio/sox port when trying to play .wav files
generated by aucat.

Reported by John Rigg <obsd at jrigg.co.uk> and others on misc@

21 months agoPrevent 1-byte out-of-bounds read in i2c_ASN1_BIT_STRING
tb [Fri, 13 Jan 2023 14:46:08 +0000 (14:46 +0000)]
Prevent 1-byte out-of-bounds read in i2c_ASN1_BIT_STRING

If an ASN.1 BIT STRING a of length > 0 contains only zero bytes in a->data,
this old code would end up reading from a->data[-1]. This may or may not
crash. Luckily, anton observed two openssl-ruby regress test failures in
the last few days, which could eventually be traced back to this (after a
lot of painful digging due to coredumps not working properly).

ok jsing

21 months agoFix a couple of auto allocation corner cases.
krw [Fri, 13 Jan 2023 14:24:17 +0000 (14:24 +0000)]
Fix a couple of auto allocation corner cases.

Don't stop counting free partitions just because a spoofed
partition is encountered.

Always check for (end - start) underflow after rounding
start/end to cylinder boundaries.

21 months agoRetake kernel lock in error paths of vmmioctl.
dv [Fri, 13 Jan 2023 14:15:49 +0000 (14:15 +0000)]
Retake kernel lock in error paths of vmmioctl.

From Christian Ludwig.

21 months agoAdd aspa-set to openbgpd config output.
claudio [Fri, 13 Jan 2023 08:58:36 +0000 (08:58 +0000)]
Add aspa-set to openbgpd config output.

Change the way the validated ASPA tree is built since OpenBGPD config
follows more the ASPA profile and puts the optional AFI to each provider
ASnum instead of duplicated everything into an IPv4 and IPv6 tree.
The JSON output of ASPA is still the same.

The inclusion of the aspa-set can currently be disabled by the -A flag.
OK tb@

21 months agofix double phrase in previous;
jmc [Fri, 13 Jan 2023 07:13:40 +0000 (07:13 +0000)]
fix double phrase in previous;

21 months agoshutdown(8): sig_atomic_t variables should be qualified 'volatile'
cheloha [Fri, 13 Jan 2023 07:02:16 +0000 (07:02 +0000)]
shutdown(8): sig_atomic_t variables should be qualified 'volatile'

21 months agotimeout(1): sig_atomic_t variables must also be 'volatile'; ok job@
cheloha [Fri, 13 Jan 2023 06:53:04 +0000 (06:53 +0000)]
timeout(1): sig_atomic_t variables must also be 'volatile'; ok job@

21 months agoMove scp path setting to a helper function.
dtucker [Fri, 13 Jan 2023 04:47:34 +0000 (04:47 +0000)]
Move scp path setting to a helper function.
The previous commit to add scp to the test sshd's path causes the t-envpass
test to fail when the test scp is given using a fully qualified path.  Put
this in a helper function and only call it from the scp tests.

21 months agoAdd scp's path to test sshd's PATH.
dtucker [Fri, 13 Jan 2023 04:23:00 +0000 (04:23 +0000)]
Add scp's path to test sshd's PATH.
If the scp we're testing is fully qualified (eg it's not in the system
PATH) then add its path to the under-test sshd's PATH so we can find it.
Prompted by bz#3518.

21 months agosparc64: switch to clockintr
cheloha [Fri, 13 Jan 2023 03:22:18 +0000 (03:22 +0000)]
sparc64: switch to clockintr

- Remove all use of timer(4/sparc64) from sparc64/clock.c.
- Don't map interrupts in timer_match(), effectively disabling
  timer(4/sparc64).  The driver will be completely removed in a
  later commit.
- Wire up tick_intrclock, stick_intrclock, and sys_tick_intrclock.
- All sparc64 machines now have a randomized statclock; stathz = hz,
  profhz = stathz * 10.

Very special thanks to miod@, without whom this would have been impossible.

sun4v testing by kmos@, mlarkin@, and kn@.  sun4u testing (%tick and the
oddball USIIe %stick) by miod@.  With input from miod@, mlarkin@, and
kettenis@.

v1: https://marc.info/?l=openbsd-tech&m=166776418803680&w=2
v2: https://marc.info/?l=openbsd-tech&m=167287772220176&w=2
v3: https://marc.info/?l=openbsd-tech&m=167322011602530&w=2

ok mlarkin@ kettenis@ miod@

21 months agoDocument "UserKnownHostsFile none". ok djm@
dtucker [Fri, 13 Jan 2023 03:16:29 +0000 (03:16 +0000)]
Document "UserKnownHostsFile none".  ok djm@

21 months agoAdd a "Host" line to the output of ssh -G showing the original host arg.
dtucker [Fri, 13 Jan 2023 02:58:20 +0000 (02:58 +0000)]
Add a "Host" line to the output of ssh -G showing the original host arg.
Inspired by patch from vincent at bernat.ch via bz#3343, ok djm@

21 months agoavoid printf("%s", NULL) if using ssh -oUserKnownHostsFile=none
djm [Fri, 13 Jan 2023 02:44:02 +0000 (02:44 +0000)]
avoid printf("%s", NULL) if using ssh -oUserKnownHostsFile=none
and a hostkey in one of the system known hosts file changes;
ok dtucker@

21 months agodrm/i915/dsi: fix MIPI_BKLT_EN_1 native GPIO index
jsg [Fri, 13 Jan 2023 02:03:06 +0000 (02:03 +0000)]
drm/i915/dsi: fix MIPI_BKLT_EN_1 native GPIO index

From Jani Nikula
0c84b7de26588f4032992ee2a1df6c3d367be829 in linux-6.1.y/6.1.5
6217e9f05a74df48c77ee68993d587cdfdb1feb7 in mainline linux

21 months agodrm/i915/dsi: add support for ICL+ native MIPI GPIO sequence
jsg [Fri, 13 Jan 2023 02:01:14 +0000 (02:01 +0000)]
drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence

From Jani Nikula
c7229577d93d53870fd77e961143305aeec97a7b in linux-6.1.y/6.1.5
963bbdb32b47cfa67a449e715e1dcc525fbd01fc in mainline linux

21 months agodrm/amd/display: Uninitialized variables causing 4k60 UCLK to stay at DPM1 and not...
jsg [Fri, 13 Jan 2023 01:58:55 +0000 (01:58 +0000)]
drm/amd/display: Uninitialized variables causing 4k60 UCLK to stay at DPM1 and not DPM0

From Samson Tam
d179f9d27f1e31fdcf6b02c4f1658dd69985f602 in linux-6.1.y/6.1.5
f3c23bea598ab7e8e4b8c5ca66598921310f718e in mainline linux

21 months agodrm/amd/display: Add check for DET fetch latency hiding for dcn32
jsg [Fri, 13 Jan 2023 01:56:44 +0000 (01:56 +0000)]
drm/amd/display: Add check for DET fetch latency hiding for dcn32

From Dillon Varone
4ac1437d64efdd2788f8c511276243f594e946fd in linux-6.1.y/6.1.5
6d4727c80947de0e6fad58b196a9d215e3b32608 in mainline linux

21 months agodrm/i915/gvt: fix vgpu debugfs clean in remove
jsg [Fri, 13 Jan 2023 01:54:11 +0000 (01:54 +0000)]
drm/i915/gvt: fix vgpu debugfs clean in remove

From Zhenyu Wang
44c0e07e3972e3f2609d69ad873d4f342f8a68ec in linux-6.1.y/6.1.5
704f3384f322b40ba24d958473edfb1c9750c8fd in mainline linux

21 months agodrm/i915/gvt: fix gvt debugfs destroy
jsg [Fri, 13 Jan 2023 01:52:52 +0000 (01:52 +0000)]
drm/i915/gvt: fix gvt debugfs destroy

From Zhenyu Wang
fe340500baf84b6531c9fc508b167525b9bf6446 in linux-6.1.y/6.1.5
c4b850d1f448a901fbf4f7f36dec38c84009b489 in mainline linux

21 months agodrm/amdkfd: Fix kernel warning during topology setup
jsg [Fri, 13 Jan 2023 01:50:53 +0000 (01:50 +0000)]
drm/amdkfd: Fix kernel warning during topology setup

From Mukul Joshi
306888b1246bf44e703b6f1ccc746c2746c1a981 in linux-6.1.y/6.1.5
cf97eb7e47d4671084c7e114c5d88a3d0540ecbd in mainline linux

21 months agodrm/plane-helper: Add the missing declaration of drm_atomic_state
jsg [Fri, 13 Jan 2023 01:49:06 +0000 (01:49 +0000)]
drm/plane-helper: Add the missing declaration of drm_atomic_state

From Ma Jun
c7041ec41036f64db5104f33348c45a1aedcf098 in linux-6.1.y/6.1.5
4e699e34f923188175986ad8a74ab99f7034075e in mainline linux

21 months agoRevert "drm/amd/display: Enable Freesync Video Mode by default"
jsg [Fri, 13 Jan 2023 01:46:41 +0000 (01:46 +0000)]
Revert "drm/amd/display: Enable Freesync Video Mode by default"

From Michel Daenzer
d54f66bc9c371e4765d78144c8dac568a59a31dd in linux-6.1.y/6.1.5
6fe6ece398f7431784847e922a2c8c385dc58a35 in mainline linux

21 months agodrm/amd/display: Report to ACPI video if no panels were found
jsg [Fri, 13 Jan 2023 01:42:45 +0000 (01:42 +0000)]
drm/amd/display: Report to ACPI video if no panels were found

From Mario Limonciello
adaf41b56803fe7a9a4ac625c7e41615ef23591f in linux-6.1.y/6.1.5
c573e240609ff781a0246c0c8c8351abd0475287 in mainline linux

21 months agodrm/amdkfd: Fix double release compute pasid
jsg [Fri, 13 Jan 2023 01:40:51 +0000 (01:40 +0000)]
drm/amdkfd: Fix double release compute pasid

From Philip Yang
a02c07b619899179384fde06f951530438a3512d in linux-6.1.y/6.1.5
1a799c4c190ea9f0e81028e3eb3037ed0ab17ff5 in mainline linux

21 months agodrm/amdkfd: Fix kfd_process_device_init_vm error handling
jsg [Fri, 13 Jan 2023 01:38:35 +0000 (01:38 +0000)]
drm/amdkfd: Fix kfd_process_device_init_vm error handling

From Philip Yang
9d74d1f52e16d8e07f7fbe52e96d6391418a2fe9 in linux-6.1.y/6.1.5
29d48b87db64b6697ddad007548e51d032081c59 in mainline linux

21 months agodrm/amdgpu: Fix size validation for non-exclusive domains (v4)
jsg [Fri, 13 Jan 2023 01:37:01 +0000 (01:37 +0000)]
drm/amdgpu: Fix size validation for non-exclusive domains (v4)

From Luben Tuikov
8ba7c55e112f4ffd2a95b99be1cb1c891ef08ba1 in linux-6.1.y/6.1.5
7554886daa31eacc8e7fac9e15bbce67d10b8f1f in mainline linux

21 months agodrm/i915/gvt: fix double free bug in split_2MB_gtt_entry
jsg [Fri, 13 Jan 2023 01:34:34 +0000 (01:34 +0000)]
drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

From Zheng Wang
1022519da69d99d455c58ca181a6c499c562c70e in linux-6.1.y/6.1.5
4a61648af68f5ba4884f0e3b494ee1cabc4b6620 in mainline linux

21 months agodrm/i915: unpin on error in intel_vgpu_shadow_mm_pin()
jsg [Fri, 13 Jan 2023 01:32:39 +0000 (01:32 +0000)]
drm/i915: unpin on error in intel_vgpu_shadow_mm_pin()

From Dan Carpenter
20a07570c1667a48fe50fdfa59f4ece57775b69a in linux-6.1.y/6.1.5
3792fc508c095abd84b10ceae12bd773e61fdc36 in mainline linux

21 months agoadd acpi_video_report_nolcd() for 6.1.5 drm
jsg [Fri, 13 Jan 2023 01:27:41 +0000 (01:27 +0000)]
add acpi_video_report_nolcd() for 6.1.5 drm

21 months agoDisable double width and height escape sequences under SMALL_KERNEL.
nicm [Thu, 12 Jan 2023 20:39:37 +0000 (20:39 +0000)]
Disable double width and height escape sequences under SMALL_KERNEL.

ok miod

21 months agofree(NULL) has been allowed in the kernel since 5.4; remove checks.
miod [Thu, 12 Jan 2023 20:13:28 +0000 (20:13 +0000)]
free(NULL) has been allowed in the kernel since 5.4; remove checks.

21 months agoUpdate luna88k boot procedure; help & tweaks jmc@
miod [Thu, 12 Jan 2023 19:37:53 +0000 (19:37 +0000)]
Update luna88k boot procedure; help & tweaks jmc@

21 months agoHave tmux recognise pasted texts wrapped in bracket paste sequences,
nicm [Thu, 12 Jan 2023 18:49:11 +0000 (18:49 +0000)]
Have tmux recognise pasted texts wrapped in bracket paste sequences,
rather than only forwarding them to the program inside. From Andrew
Onyshchuk in GitHub issue 3431.

21 months agoSplit rde_filterstate_prep() into three functions.
claudio [Thu, 12 Jan 2023 17:35:51 +0000 (17:35 +0000)]
Split rde_filterstate_prep() into three functions.
- rde_filterstate_init(): initialize a filterstate to default values
- rde_filterstate_copy(): copy from a filterstate into a new state object
- rde_filterstate_prep(): set filtersate based on prefix passed as argument.

This makes the code a bit easier to read.
OK tb@

21 months agoOn '!', drop into a proper ksh(1) instead of a limited sh(1) lacking
kn [Thu, 12 Jan 2023 15:03:23 +0000 (15:03 +0000)]
On '!', drop into a proper ksh(1) instead of a limited sh(1) lacking
arithmetic expression `(( ... ))' and more.

OK deraadt

21 months agodiff from sobrado to use a full argument name for -s: after some discussion
jmc [Thu, 12 Jan 2023 14:08:39 +0000 (14:08 +0000)]
diff from sobrado to use a full argument name for -s: after some discussion
we used "signal", as per pkill/pgrep; also lift the descriptive text
from kill.1 to clarify that both signal name and number are accepted;

ok sobrado job

21 months agoBinding the accept socket in TCP input relies on the fact that the
bluhm [Thu, 12 Jan 2023 13:09:47 +0000 (13:09 +0000)]
Binding the accept socket in TCP input relies on the fact that the
listen port is not bound to port 0.  With a matching pf divert-to
rule this assumption is no longer true and could crash the kernel
with kassert.  In both pf and stack drop TCP packets with destination
port 0 before they can do harm.
OK sashan@ claudio@

21 months agoremove outdated "expected to be compliant"
jsg [Thu, 12 Jan 2023 12:56:07 +0000 (12:56 +0000)]
remove outdated "expected to be compliant"
ok miod@ kn@ deraadt@

21 months agoAdd CBT (cursor back tab) sequence, from Crystal Kolipe kolipe.c at
nicm [Thu, 12 Jan 2023 12:34:06 +0000 (12:34 +0000)]
Add CBT (cursor back tab) sequence, from Crystal Kolipe kolipe.c at
exoticsilicon dot com.

ok miod

21 months agoAdd aixterm bright colour sequences (SGR 90-97 and 100-107). From
nicm [Thu, 12 Jan 2023 12:28:08 +0000 (12:28 +0000)]
Add aixterm bright colour sequences (SGR 90-97 and 100-107). From
Crystal Kolipe kolipe.c at exoticsilicon dot com.

ok miod

21 months agoAdd some missing cursor movement and scrolling escape sequences that are
nicm [Thu, 12 Jan 2023 12:23:40 +0000 (12:23 +0000)]
Add some missing cursor movement and scrolling escape sequences that are
supported by xterm. From Crystal Kolipe kolipe.c at exoticsilicon dot
com.

ok miod

21 months agoUse solock() instead solock_shared() within sys_getsockopt(). Otherwise
mvs [Thu, 12 Jan 2023 10:59:36 +0000 (10:59 +0000)]
Use solock() instead solock_shared() within sys_getsockopt(). Otherwise
we acquiring kernel lock with mutex(9) held. This partially reverts
rev 1.205 of sys/kern/uipc_syscalls.c. Shared solock() is still fine for
getsockname(2) and getpeername(2).

Reported-by: syzbot+00a4824cb1b6a214c7d6@syzkaller.appspotmail.com
ok kn@ claudio@

21 months agoIn build_aspath() be more careful in the len == 0 case. For len == 0
claudio [Thu, 12 Jan 2023 08:47:07 +0000 (08:47 +0000)]
In build_aspath() be more careful in the len == 0 case. For len == 0
aspath->data should not be touched so just exit early.
While there also initalize source_as correctly in the rev case. This
does not matter here but is more correct.
Problem noticed by anton@
OK tb@

21 months agoUse proper sparc64 illtrap instruction as text sections filler, rather than
miod [Thu, 12 Jan 2023 07:25:29 +0000 (07:25 +0000)]
Use proper sparc64 illtrap instruction as text sections filler, rather than
the x86 one.

21 months agoFix trivial stack buf oflow
miod [Thu, 12 Jan 2023 07:18:25 +0000 (07:18 +0000)]
Fix trivial stack buf oflow

21 months agoCompiling kernel with witness option failed since drm update. Do
bluhm [Thu, 12 Jan 2023 00:27:26 +0000 (00:27 +0000)]
Compiling kernel with witness option failed since drm update.  Do
not define struct rwlock variable within function, witness needs
global access.
OK jsg@

21 months agoImplement X-only mappings on sun4u by not letting the dtlb miss handler
miod [Wed, 11 Jan 2023 19:57:17 +0000 (19:57 +0000)]
Implement X-only mappings on sun4u by not letting the dtlb miss handler
allow ttes with the "exec only" bit; joint work with deraadt@, unfortunately
no effect on sun4v due to the lack of software bits in ttes to fit an
"exec only" bit.

ok deraadt@ kettenis@

21 months agobe very paranoid like other architectures and force no-jump-tables
deraadt [Wed, 11 Jan 2023 17:16:33 +0000 (17:16 +0000)]
be very paranoid like other architectures and force no-jump-tables
came up in two seperate conversations with miod and kettenis

21 months agoAdd the validation state to the filterstate struct.
claudio [Wed, 11 Jan 2023 17:10:25 +0000 (17:10 +0000)]
Add the validation state to the filterstate struct.
Removes vstate argument from rde_filter().
Rename prefix_vstate() to prefix_roa_vstate().
OK tb@

21 months agoblock --execute-only on mips64 & sparc64 during the upcoming transition.
deraadt [Wed, 11 Jan 2023 17:00:20 +0000 (17:00 +0000)]
block --execute-only on mips64 & sparc64 during the upcoming transition.
a seatbelt, because libc build corruption is too painful.

21 months agobased upon inspection of obj/*.S ...
deraadt [Wed, 11 Jan 2023 16:36:44 +0000 (16:36 +0000)]
based upon inspection of obj/*.S ...
temporarily force sparc64 libcrypto to be built --no-execute-only because
perlasm is still putting tables (intended to be rodata) into text.
This will help dynamic executables, but static executables won't be
saved by this. But this is temporary because we hope the perlasm problem
is fixed soon.

21 months agoput LD_SCRIPT in the canonical location
deraadt [Wed, 11 Jan 2023 16:33:36 +0000 (16:33 +0000)]
put LD_SCRIPT in the canonical location

21 months agoAdd ld.so linker scripts on the remaining platforms.
miod [Wed, 11 Jan 2023 16:31:46 +0000 (16:31 +0000)]
Add ld.so linker scripts on the remaining platforms.

21 months agotemporarily force hppa libcrypto to be built --no-execute-only because
deraadt [Wed, 11 Jan 2023 16:25:13 +0000 (16:25 +0000)]
temporarily force hppa libcrypto to be built --no-execute-only because
perlasm is still putting tables (intended to be rodata) into text.
This will help dynamic executables, but static executables won't be
saved by this. But this is temporary because we hope the perlasm problem
is fixed soon.
ok miod

21 months agoforce-disable jump tables in ld.so building on sparc64, to ease the
deraadt [Wed, 11 Jan 2023 16:21:32 +0000 (16:21 +0000)]
force-disable jump tables in ld.so building on sparc64, to ease the
exonly transition for people building through an upcoming commit series

21 months agothe kernel on mips64 (octeon, loongson) is in good enough shape to run
deraadt [Wed, 11 Jan 2023 15:14:01 +0000 (15:14 +0000)]
the kernel on mips64 (octeon, loongson) is in good enough shape to run
--execute-only ld.so (meaning FLAGS (1) on the LOAD line for the text
segment, in the ld.script).  the linker, when using built-in linker scripts,
is not ready yet for other libraries / binaries..

21 months agodo not need --execute-only anymore, it is now the default
deraadt [Wed, 11 Jan 2023 14:38:09 +0000 (14:38 +0000)]
do not need --execute-only anymore, it is now the default

21 months agoarm64 and riscv64 can now do --execute-only by default
deraadt [Wed, 11 Jan 2023 14:33:33 +0000 (14:33 +0000)]
arm64 and riscv64 can now do --execute-only by default
ok kettenis

21 months agohppa can switch over to --execute-only by default.
deraadt [Wed, 11 Jan 2023 14:30:47 +0000 (14:30 +0000)]
hppa can switch over to --execute-only by default.
ok kettenis

21 months agoAdd a somewhat extensive unittest for ASPA validation functionality.
claudio [Wed, 11 Jan 2023 13:55:08 +0000 (13:55 +0000)]
Add a somewhat extensive unittest for ASPA validation functionality.

21 months agoAdd ASPA validation functions to the RDE.
claudio [Wed, 11 Jan 2023 13:53:17 +0000 (13:53 +0000)]
Add ASPA validation functions to the RDE.

This implements ASPA validation based on the current draft. Implementing
this showed various weaknesses in the current ASPA draft which I hope to
fix in the near future.

Unlike the algorithm specified in the draft our version validates the
AS_PATH attribute in a single path doing one or two lookups depending on
the sessions BGP role.

The code is not yet hooked up into the RDE (see the NOTYET blocks).
Missing are reload logic, bgpctl integration and the loading of the
merged ASPA set from the rtr process.

OK tb@

21 months agoRemove rasops_isgray, this is no longer used. From Crystal Kolipe
nicm [Wed, 11 Jan 2023 12:47:04 +0000 (12:47 +0000)]
Remove rasops_isgray, this is no longer used. From Crystal Kolipe
kolipe.c at exoticsilicon dot com.

ok miod

21 months agoMake sure we also remove read access in pmap_page_ro() when the new
kettenis [Wed, 11 Jan 2023 11:10:25 +0000 (11:10 +0000)]
Make sure we also remove read access in pmap_page_ro() when the new
permissions only allow execution.  Make sure we completely invalidate
the PTE if the intersection between the old and new permissions is the
empty set.

ok deraadt@, mpi@

21 months agoMake sure we also remove read access in pmap_page_ro() when the new
kettenis [Wed, 11 Jan 2023 11:09:17 +0000 (11:09 +0000)]
Make sure we also remove read access in pmap_page_ro() when the new
permissions only allow execution.  Make sure we completely invalidate
the PTE if the intersection between the old and new permissions is the
empty set.

ok drahn@, deraadt@, mpi@

21 months agomake REGRESS_CLEANUP consistent with REGRESS_CLEANUP found
sashan [Wed, 11 Jan 2023 08:11:07 +0000 (08:11 +0000)]
make REGRESS_CLEANUP consistent with REGRESS_CLEANUP found
in pf_state/Makefile.

discussed with anton@

OK anton@

21 months agoclamp the minimum buffer lengths and number of inflight requests too
djm [Wed, 11 Jan 2023 05:39:38 +0000 (05:39 +0000)]
clamp the minimum buffer lengths and number of inflight requests too

21 months agoignore bogus upload/download buffer lengths in the limits extension
djm [Wed, 11 Jan 2023 05:36:50 +0000 (05:36 +0000)]
ignore bogus upload/download buffer lengths in the limits extension

21 months agoClean up and simplify BIGNUM handling in DSA code.
jsing [Wed, 11 Jan 2023 04:39:42 +0000 (04:39 +0000)]
Clean up and simplify BIGNUM handling in DSA code.

This adds missing BN_CTX_start()/BN_CTX_end() calls, removes NULL checks
before BN_CTX_end()/BN_CTX_free() (since they're NULL safe) and calls
BN_free() instead of BN_clear_free() (which does the same thing).

Also replace stack allocated BIGNUMs with calls to BN_CTX_get(), using the
BN_CTX that is already available.

ok tb@

21 months agoSimplify BIGNUM handling in dsa_builtin_keygen().
jsing [Wed, 11 Jan 2023 04:35:26 +0000 (04:35 +0000)]
Simplify BIGNUM handling in dsa_builtin_keygen().

Rather than having complicated "attempt to reuse" dances, always allocate
priv_key/pub_key, then free and assign on success.

ok tb@

21 months agoReplace BN_lshift1()/BN_rshift1() with calls to BN_lshift()/BN_rshift().
jsing [Wed, 11 Jan 2023 04:26:24 +0000 (04:26 +0000)]
Replace BN_lshift1()/BN_rshift1() with calls to BN_lshift()/BN_rshift().

Currently, BN_lshift1() and BN_rshift1() are separate implementations
that are intended to be faster since the shift is known (and only one bit
crosses a word boundary). However, with the rewrite of BN_lshift() and
BN_rshift(), they are either slower or only minimally faster (depending
on architecture).

Avoid duplication and turn BN_lshift1()/BN_rshift1() into functions that
call inlined versions of BN_lshift()/BN_rshift(), making BN_lshift() and
BN_rshift() call the same inlined implementation. This results in a single
implementation and BN_lshift1()/BN_rshift1() that out perform the previous
versions (in part due to compiler optimisation).

Now that none of the original code exists, replace the license and
copyright for this file.

ok tb@

21 months agoUse 64-bit page table entries on octeon
visa [Wed, 11 Jan 2023 03:28:42 +0000 (03:28 +0000)]
Use 64-bit page table entries on octeon

This (over-)compensates for the frame bit reduction related to the
TLB read inhibit support. However, the memory overhead of page tables
is increased.

OK miod@

21 months agoEnable TLB read inhibit on OCTEON Plus and newer SoCs.
visa [Wed, 11 Jan 2023 03:20:52 +0000 (03:20 +0000)]
Enable TLB read inhibit on OCTEON Plus and newer SoCs.

OK deraadt@

21 months agoAdd TLB bypass for instruction emulation
visa [Wed, 11 Jan 2023 03:19:52 +0000 (03:19 +0000)]
Add TLB bypass for instruction emulation

copyinsn() fetches a userland instruction through the direct map.
This lets emulation work with execute-only virtual memory mappings.

OK deraadt@

21 months agoAdd MIPS64r2 TLB read inhibit support
visa [Wed, 11 Jan 2023 03:17:56 +0000 (03:17 +0000)]
Add MIPS64r2 TLB read inhibit support

OK deraadt@ miod@

21 months agoi386/machdep.c: revert revisions 1.659 and 1.660
cheloha [Wed, 11 Jan 2023 02:49:34 +0000 (02:49 +0000)]
i386/machdep.c: revert revisions 1.659 and 1.660

"put it back" kettenis@

21 months agoremove whitespace at EOL from code extracted from SUPERCOP
djm [Wed, 11 Jan 2023 02:13:52 +0000 (02:13 +0000)]
remove whitespace at EOL from code extracted from SUPERCOP

21 months agoAdd retguard to amd64 syscalls.
mortimer [Wed, 11 Jan 2023 01:55:17 +0000 (01:55 +0000)]
Add retguard to amd64 syscalls.

Since we got rid of padded syscalls we have enough registers to do this.

ok deraadt@ ok kettenis@

21 months agorewrite this test to use a multiplexed ssh session so we can control
djm [Wed, 11 Jan 2023 00:51:27 +0000 (00:51 +0000)]
rewrite this test to use a multiplexed ssh session so we can control
its lifecycle without risk of race conditions; fixes some of the
Github integration tests for openssh-portable

21 months agoSwitch scp from using pipes to a socketpair for communication with
millert [Tue, 10 Jan 2023 23:22:15 +0000 (23:22 +0000)]
Switch scp from using pipes to a socketpair for communication with
it's ssh sub-processes.  We no longer need to reserve two descriptors
to ensure that we don't end up using fd 0-2 unexpectedly, that is
handled by sanitise_stdfd() in main().
Based on an original diff from djm@.  OK deraadt@ djm@

21 months agoUse atomic ops on the set of used segment registers
gkoehler [Tue, 10 Jan 2023 21:27:12 +0000 (21:27 +0000)]
Use atomic ops on the set of used segment registers

Each pmap sets a bit in usedsr to claim 16 unique VSIDs for its
segment registers. Use atomic_cas_uint to set this bit (checking that
the other cpu didn't steal it) and atomic_clearbits_int to clear it.
Stop using splvm.

ok miod@

21 months agohppa ld.so works with executable-only text (non-readable)
deraadt [Tue, 10 Jan 2023 21:22:39 +0000 (21:22 +0000)]
hppa ld.so works with executable-only text (non-readable)

21 months agooops, fix a bad edit in previous;
jmc [Tue, 10 Jan 2023 21:10:37 +0000 (21:10 +0000)]
oops, fix a bad edit in previous;

21 months agoFix device name in the MIDI control section
ratchov [Tue, 10 Jan 2023 20:48:34 +0000 (20:48 +0000)]
Fix device name in the MIDI control section

For MMC to work, the MIDI sequencer must send MMC to subdevices
registered with -tslave.

From Dirk-Wilhelm Peters <peters at schwertfisch.de>, thanks.

21 months agolike hppa, sparc64 will need gcc's jump tables option disabled to
deraadt [Tue, 10 Jan 2023 18:05:59 +0000 (18:05 +0000)]
like hppa, sparc64 will need gcc's jump tables option disabled to
allow execute-only binaries
ok miod

21 months agoIn pmap_bootstrap, when importing the PROM translations into the kernel pmap,
miod [Tue, 10 Jan 2023 17:38:10 +0000 (17:38 +0000)]
In pmap_bootstrap, when importing the PROM translations into the kernel pmap,
be sure to clear all software bits from the TTEs, for these bits will have
different meanings in OpenBSD.

Tested on a large set of sun4u and sun4v systems of different eras to not
cause any regression, should be safe enough.

21 months agoSwitch the luna88k boot loader to the MI boot code, to ease future maintainence
miod [Tue, 10 Jan 2023 17:10:57 +0000 (17:10 +0000)]
Switch the luna88k boot loader to the MI boot code, to ease future maintainence
of it. Crank version to 0.8.
ok aoyama@

21 months agoEnable the fine-grained fault type computation code added in 1.117 on all
miod [Tue, 10 Jan 2023 17:04:01 +0000 (17:04 +0000)]
Enable the fine-grained fault type computation code added in 1.117 on all
mips64 processors, not only Octeon; needed to cope with xonly mappings.

21 months agoSwitch to console before suspending in DUMBFB mode. Fixes frame buffer corruption
tobhe [Tue, 10 Jan 2023 16:33:18 +0000 (16:33 +0000)]
Switch to console before suspending in DUMBFB mode. Fixes frame buffer corruption
and a few other bugs/races after wakeup on Apple Silicon laptops and Lenovo x13s.

ok kettenis@ deraadt@

21 months agoAdd short options for --foreground and --preserve-status
job [Tue, 10 Jan 2023 14:19:12 +0000 (14:19 +0000)]
Add short options for --foreground and --preserve-status

Align with upcoming POSIX spec: https://www.austingroupbugs.net/view.php?id=1586

OK jmc@

21 months agoImprove timestamp printing in filemode
job [Tue, 10 Jan 2023 13:26:34 +0000 (13:26 +0000)]
Improve timestamp printing in filemode

OK claudio@

21 months agorhe -> the from Crystal Kolipe
tb [Tue, 10 Jan 2023 12:47:19 +0000 (12:47 +0000)]
rhe -> the from Crystal Kolipe

21 months agopurge unhooked wx_syscall files
anton [Tue, 10 Jan 2023 12:19:18 +0000 (12:19 +0000)]
purge unhooked wx_syscall files

21 months agoRetire wx_syscall regress tests, they have been failing since the
anton [Tue, 10 Jan 2023 12:17:00 +0000 (12:17 +0000)]
Retire wx_syscall regress tests, they have been failing since the
introduction of mimmutable(2) and also needs to cope with xonly on some
architectures by now. There's already the syscallwx target in
regress/usr.bin/lastcomm which does the same thing but also ensures that
the expected code path is reached by looking at accounting records.

21 months agodisable jump tables by default on hppa because they are incompatible
deraadt [Tue, 10 Jan 2023 12:07:34 +0000 (12:07 +0000)]
disable jump tables by default on hppa because they are incompatible
with --execute-only in the linker
ok kettenis

21 months agocreate infrastructure so that jump tables on/off can be tweaked by an
deraadt [Tue, 10 Jan 2023 12:06:18 +0000 (12:06 +0000)]
create infrastructure so that jump tables on/off can be tweaked by an
architecture by changing JUMP_TABLES_DEFAULT
ok kettenis

21 months agoThe uvm_swap_data_lock mutex can now be taken without holding the kernel
kettenis [Tue, 10 Jan 2023 11:18:47 +0000 (11:18 +0000)]
The uvm_swap_data_lock mutex can now be taken without holding the kernel
lock.  So it needs IPL_MPFLOOR to prevent lock ordering issues.

ok jca@

21 months agoRewrite BN_lshift()
jsing [Tue, 10 Jan 2023 04:13:22 +0000 (04:13 +0000)]
Rewrite BN_lshift()

This improves readability and eliminates special handling for various
cases, making the code cleaner and closer to constant time. Basic
benchmarking shows a performance gain on modern 64 bit architectures.

ok tb@

21 months agoHide WAITPKG cpu feature from vmm(4) guests.
dv [Tue, 10 Jan 2023 01:09:14 +0000 (01:09 +0000)]
Hide WAITPKG cpu feature from vmm(4) guests.

Alder Lake and similar-era Intel platforms introduced new userland
wait instructions. Since vmm was passing this cpuid bit into guests,
some would attempt TPAUSE instructions and trigger invalid instruction
exceptions because VMX requires additional configuration to support
emulation.

This also adds WAITPKG to i386 and amd64 cpu feature identification.

Input from anton@, cheloha@, and guenther@. Tested by jmatthew@.

OK deraadt.