miod [Mon, 19 May 2014 21:18:42 +0000 (21:18 +0000)]
Format string fixes and removal of -Wno-format for sgi. Based upon an
initial diff from jasper@
jca [Mon, 19 May 2014 20:09:22 +0000 (20:09 +0000)]
X509_free() the certificate if the server hostname check fails.
No functional change. Reported by Mike Small and Maxime Villard.
miod [Mon, 19 May 2014 20:09:15 +0000 (20:09 +0000)]
Fix several bounds checks in ssl_add_clienthello_tlsext() and
ssl_add_serverhello_tlsext(), and convert all of them to the same idiom, for
easier review.
Math is hard, let's go webshopping.
Help and ok guenther@
jca [Mon, 19 May 2014 20:05:09 +0000 (20:05 +0000)]
Explicitely initialize two static variables introduced in the previous
commit, to please lteo@
jca [Mon, 19 May 2014 20:03:16 +0000 (20:03 +0000)]
HTTPS connections may see redirects, so initialize libcrypto and libssl
only once, and reuse the crafted SSL_CTX for further connections.
ok lteo@
jca [Mon, 19 May 2014 19:42:24 +0000 (19:42 +0000)]
Plug a small memory leak: if we pass checkin_init/checkin_update
a revision thru pb.newrev, it will not be freed. From Fritjof
Bornebusch, no objections from tech@
jmc [Mon, 19 May 2014 17:07:16 +0000 (17:07 +0000)]
no more -K;
tedu [Mon, 19 May 2014 15:05:13 +0000 (15:05 +0000)]
kerberos leftovers
tedu [Mon, 19 May 2014 14:30:03 +0000 (14:30 +0000)]
consistent use of uint32_t for poison values
syl [Mon, 19 May 2014 13:55:29 +0000 (13:55 +0000)]
Add some consistency in fuse error handling. We need to return ENXIO
when the fuse communication channel is broken and ENOSYS when the
libfuse callback does not exist.
Reported by Helg Bredow, thanks!
ok tedu@
tedu [Mon, 19 May 2014 13:43:30 +0000 (13:43 +0000)]
as reported by Helg, should use realpath for mounts. ok guenther syl
mpi [Mon, 19 May 2014 13:11:31 +0000 (13:11 +0000)]
There is no need to remember which usb(4) device is the child of an USB
host controller because autoconf(9) already does it.
Breakage reported by todd@
todd [Mon, 19 May 2014 12:40:53 +0000 (12:40 +0000)]
sync
jsing [Mon, 19 May 2014 12:34:53 +0000 (12:34 +0000)]
More KNF.
jsing [Mon, 19 May 2014 12:18:23 +0000 (12:18 +0000)]
More whack-a-mole^Wfips.
ok miod@
jsing [Mon, 19 May 2014 12:13:30 +0000 (12:13 +0000)]
It is perfectly valid to call free(NULL), so stop checking for non-NULL
before calling free - of some course parts of the code already did this.
krw [Mon, 19 May 2014 10:42:08 +0000 (10:42 +0000)]
Nuke some trailing whitespace that snuck in.
krw [Mon, 19 May 2014 10:37:40 +0000 (10:37 +0000)]
No point in trying to update the -L file on loss of link if no -L has
been specified. Eliminates spurious "Couldn't write ''" log messages.
Spotted while looking into Roman Gorelov's logs on another problem.
nicm [Mon, 19 May 2014 08:58:34 +0000 (08:58 +0000)]
Add a H_SAVE_FP operation to history() which lets the history be saved
to an open file pointer. From NetBSD via Eitan Adler.
ok millert
ratchov [Mon, 19 May 2014 07:00:15 +0000 (07:00 +0000)]
fix format mistakes visible if AUDIO_DEBUG is defined
jsg [Mon, 19 May 2014 06:54:34 +0000 (06:54 +0000)]
unbreak the build when DIAGNOSTIC is not defined
allows ramdisk kernels to build again
stsp [Mon, 19 May 2014 05:38:51 +0000 (05:38 +0000)]
Update run(4) firmware to version 0.33, with permission from Dennis Lee
of Mediatek to keep using the free firmware licence we've been using.
Tested by myself, rapha@, Fred Crowson, Dinar Talypov, gerhard@, matthieu@.
guenther [Mon, 19 May 2014 02:05:10 +0000 (02:05 +0000)]
Enable the 3- and 4-byte sequence tests for UTF8_getc()
Add surrogate and out-of-range tests for UTF8_putc() on the assumption
we'll make it return -2. Maybe.
guenther [Sun, 18 May 2014 22:04:14 +0000 (22:04 +0000)]
Add regression test for UTF8_{getc,putc}()
jca [Sun, 18 May 2014 21:43:11 +0000 (21:43 +0000)]
hid_start_parse can't fail - it calls malloc(M_WAITOK). ok mpi@
miod [Sun, 18 May 2014 21:18:07 +0000 (21:18 +0000)]
Correctly handle files smaller than an ELF header; reported by drahn@bitrig
mlarkin [Sun, 18 May 2014 20:16:29 +0000 (20:16 +0000)]
_PIC is an optional method, so we shouldn't be aborting the rest of the
MADT processing if it is missing. This, combined with an earlier diff
from kettenis@ to fix MADT interrupt polarity processing, should resolve
the issues reported with QEMU/KVM ACPI power button presses when using
OpenBSD guests.
ok kettenis@, pirofti@
tested by myself and kettenis for the past few weeks
miod [Sun, 18 May 2014 19:35:04 +0000 (19:35 +0000)]
If you need to allocate `a + b' bytes of memory, then don't allocate `a + b*2',
this is confusing and unnecessary.
Help (coz I got confused) and ok guenther@ beck@
miod [Sun, 18 May 2014 19:30:36 +0000 (19:30 +0000)]
Make sure UTF8_getc() is invoked with the proper buffer size.
ok beck@ guenther@
espie [Sun, 18 May 2014 17:50:11 +0000 (17:50 +0000)]
use reallocarray
okay ian@, chl@
tedu [Sun, 18 May 2014 17:49:47 +0000 (17:49 +0000)]
factor out a bit of the chunk index code and use it to make sure that a
freed chunk is actually freeable immediately. catch more errors.
hints/ok otto
mpi [Sun, 18 May 2014 17:10:27 +0000 (17:10 +0000)]
Do not pass an xfer pointer to the timeout routine checking for root hub
status changes because it might be freed when detaching the root uhub(4).
Also do not reschedule a timeout if the pipe is being aborted.
Finally do not add more code to retrieve the 'bInterval' value of the
root hub endpoint descriptor since this value is hardcoded in the uhci(4)
driver.
jsing [Sun, 18 May 2014 16:43:18 +0000 (16:43 +0000)]
Out of all the openssl apps, just one of them has code to mess around with
electric fence externs. Nuke from orbit.
ok miod@
espie [Sun, 18 May 2014 16:36:41 +0000 (16:36 +0000)]
use reallocarray
okay miod@, millert@
jsing [Sun, 18 May 2014 16:34:04 +0000 (16:34 +0000)]
W_OK comes via unistd.h - nuke several #ifndef W_OK that attempt to handle
missing defines.
jsing [Sun, 18 May 2014 16:26:02 +0000 (16:26 +0000)]
Remove unused include.
jsing [Sun, 18 May 2014 16:21:03 +0000 (16:21 +0000)]
Group and sort includes.
Currently "apps.h" needs to be included before any of the openssl headers
and there are several cases where the code depends on headers that are
included by something included by apps.h...
More untangling saved for later on.
miod [Sun, 18 May 2014 16:19:09 +0000 (16:19 +0000)]
Plug memory leaks upon error in OCSP_url_svcloc_new().
ok jsing@
miod [Sun, 18 May 2014 16:18:13 +0000 (16:18 +0000)]
In OCSP_sendreq_bio(), cope with OCSP_sendreq_new() returning NULL.
ok jsing@
miod [Sun, 18 May 2014 16:13:48 +0000 (16:13 +0000)]
In dtls1_reassemble_fragment() and dtls1_process_out_of_seq_message(), in case
of error, make sure we do not free pitem which is still linked into the
pqueue.
In the same vain, only free `frag' if we allocated it in this function.
Help and ok beck@
miod [Sun, 18 May 2014 16:10:26 +0000 (16:10 +0000)]
In ssl3_send_certificate_request(), when adding the extra payload if
NETSCAPE_HANG_BUG is defined, make sure we BUF_MEM_grow() the buffer to
accomodate for the payload size.
Issue reported by David Ramos; ok beck@
miod [Sun, 18 May 2014 16:08:37 +0000 (16:08 +0000)]
Make sure ssl3_setup_buffers() does not return upon error with a freed
pqueue still chained, by inserting it into the list only after all possible
failure conditions have been avoided.
Reported and fix proposed by David Ramos; ok beck@
stsp [Sun, 18 May 2014 15:27:28 +0000 (15:27 +0000)]
Fix tail packet check in elantech v3 touchpad code. Due to a typo this
code was masking out bits which were also tested in the same expression.
Reported by cppcheck via jsg@ (Expression '(X & 0xfc) != 0x2' is always true).
Tested with Elantech Touchpad, version 3, firmware 0x250f00.
krw [Sun, 18 May 2014 15:17:50 +0000 (15:17 +0000)]
Don't add a lease to the leases TAILQ more than once. It tends to
make writing out the leases file go into an infinite loop until
/var is full.
Reported by Roman Gorelov via bugs@
Fix tested & ok stsp@ uwe@
todd [Sun, 18 May 2014 14:06:23 +0000 (14:06 +0000)]
sync
jsing [Sun, 18 May 2014 11:36:24 +0000 (11:36 +0000)]
bio_err is initialised in main, hence there is no need to initialise it
in each application (since there is no longer a non-monolithic mode).
In typical OpenSSL fashion, the code is inconsistent and there are multiple
ways that bio_err was initialised - none of them actually checked to see if
the initialisation actually succeeded. Additionally, it is worth noting
that in at least two cases bio_err was also being used before it would have
been initialised.
ok miod@
jsing [Sun, 18 May 2014 11:28:41 +0000 (11:28 +0000)]
More KNF.
miod [Sun, 18 May 2014 11:20:08 +0000 (11:20 +0000)]
Omit -Werror if building with gcc3, for it triggers "redefinition of `pqueue'"
warnings now that pqueue.h has been removed from public scope.
stsp [Sun, 18 May 2014 10:52:16 +0000 (10:52 +0000)]
Make rtsx(4) attach to RTL8402 devices. Reported as working by Eric Huiban.
stsp [Sun, 18 May 2014 10:49:59 +0000 (10:49 +0000)]
regen
stsp [Sun, 18 May 2014 10:49:28 +0000 (10:49 +0000)]
Add PCI ID for Realtek RTL8402 card reader.
miod [Sun, 18 May 2014 09:39:18 +0000 (09:39 +0000)]
No need to check for NULL before invoking free(); use calloc() when
applicable; further simplify pqueue_find().
From Dimitris Papastamos on tech@
espie [Sun, 18 May 2014 09:29:54 +0000 (09:29 +0000)]
use reallocarray and friends. okay miod@
sthen [Sun, 18 May 2014 08:23:27 +0000 (08:23 +0000)]
sync openssl(1) with changes already made in src/lib/libssl/doc, reminded by
jmc: move from 1024 to 2048 bit key defaults; see genrsa.c 1.26 et al.
espie [Sun, 18 May 2014 08:10:00 +0000 (08:10 +0000)]
use reallocarray
okay chl@, tedu@
espie [Sun, 18 May 2014 08:08:50 +0000 (08:08 +0000)]
a bit more reallocarray (and kill ecalloc, which isn't used)
okay chl@
jsg [Sun, 18 May 2014 05:27:49 +0000 (05:27 +0000)]
There is no need to compile nginx with -O1 on vax anymore.
Since the change in rev 1.5 vax has switched to gcc3,
MAXDSIZ has increased and pcre_exec now builds with -O2.
ok miod@
chl [Sun, 18 May 2014 05:08:07 +0000 (05:08 +0000)]
replace some (type *)0 to NULL
ok krw@ millert@
miod [Sat, 17 May 2014 23:21:36 +0000 (23:21 +0000)]
One more mistake introduced in 1.65
chl [Sat, 17 May 2014 21:37:51 +0000 (21:37 +0000)]
remove unused variables
ok miod@
miod [Sat, 17 May 2014 21:32:19 +0000 (21:32 +0000)]
...and it needs a guard against NULL as well.
miod [Sat, 17 May 2014 21:21:17 +0000 (21:21 +0000)]
Fix previous commit by making sure we are not dereferencing uninitialized
pointers.
chl [Sat, 17 May 2014 20:31:07 +0000 (20:31 +0000)]
remove unused variable
ok tedu@
tedu [Sat, 17 May 2014 20:15:50 +0000 (20:15 +0000)]
does sunos not have memmove? sorry, i guess sunos will not have libressl.
ok guenther miod
chl [Sat, 17 May 2014 20:07:54 +0000 (20:07 +0000)]
add missing header needed by str* and mem* functions
ok gilles@
espie [Sat, 17 May 2014 20:05:07 +0000 (20:05 +0000)]
fix alloc idioms. watch out for emalloc that's actually a calloc in disguise
okay chl@ tedu@
miod [Sat, 17 May 2014 19:58:49 +0000 (19:58 +0000)]
unchecked malloc() return value in OCSP_sendreq_new().
miod [Sat, 17 May 2014 19:56:35 +0000 (19:56 +0000)]
KNF
chl [Sat, 17 May 2014 19:44:13 +0000 (19:44 +0000)]
add missing header needed for mem{cpy,cmp}()
ok tedu@
tedu [Sat, 17 May 2014 18:16:14 +0000 (18:16 +0000)]
correctly match size and buffer. from enh at google
tedu [Sat, 17 May 2014 17:35:04 +0000 (17:35 +0000)]
simple reallocarray to check multiplies. ok guenther
guenther [Sat, 17 May 2014 17:26:24 +0000 (17:26 +0000)]
When looking at another process, use the data from struct process
instead of peeking into the thread level
ok tedu@
tedu [Sat, 17 May 2014 15:57:52 +0000 (15:57 +0000)]
no no md2
tedu [Sat, 17 May 2014 15:48:14 +0000 (15:48 +0000)]
no no seed
tedu [Sat, 17 May 2014 15:44:28 +0000 (15:44 +0000)]
deleted seed some time ago
chl [Sat, 17 May 2014 15:19:17 +0000 (15:19 +0000)]
remove unused variable
ok tedu@
chl [Sat, 17 May 2014 15:18:06 +0000 (15:18 +0000)]
Add missing header needed by isdigit().
While there, sort headers.
ok tedu@
tedu [Sat, 17 May 2014 13:27:55 +0000 (13:27 +0000)]
refactor some of the des crypt code to use fewer globals.
ok miod
stsp [Sat, 17 May 2014 12:54:57 +0000 (12:54 +0000)]
Fix kernel build with EHCI_DEBUG by removing a non-compiling DPRINTF().
Since no DPRINTF() call remains also remove its definition (requested by mpi@).
ok mpi, and also reported by Jean-Philippe Ouellet
ratchov [Sat, 17 May 2014 12:45:53 +0000 (12:45 +0000)]
fix format mistakes visible if AZALIA_DEBUG is defined
ratchov [Sat, 17 May 2014 12:43:18 +0000 (12:43 +0000)]
fix format mistakes visible if UAUDIO_DEBUG is defined
ratchov [Sat, 17 May 2014 12:40:25 +0000 (12:40 +0000)]
fix format mistakes visible if AUICH_DEBUG is defined
ratchov [Sat, 17 May 2014 12:23:46 +0000 (12:23 +0000)]
unbreak build with AUDIO_DEBUG: use %lx for bus_addr_t
miod [Sat, 17 May 2014 12:22:09 +0000 (12:22 +0000)]
In pmap_remove_page(), do not keep wired mappings; the callers want them gone.
miod [Sat, 17 May 2014 12:20:55 +0000 (12:20 +0000)]
Remove "WARNING:" prefix from SYSFAIL and ACFAIL messages, so that, in case
of ACFAIL, what reaches the console is explicit enough.
ratchov [Sat, 17 May 2014 12:19:36 +0000 (12:19 +0000)]
unbreak build: exchange %b args order, from miod@
miod [Sat, 17 May 2014 12:13:44 +0000 (12:13 +0000)]
Lower VUPS value for delay() to behave closer to the intent.
This is temporary until vax grows code to compute a proper delay const
at runtime, but will help a bit, especially on KA46 where cd(4) end up
detected as sd(4) due to too short delays.
sthen [Sat, 17 May 2014 12:12:05 +0000 (12:12 +0000)]
switch RSA key generation default to 2048 bits (matching ssh); ok miod@
miod [Sat, 17 May 2014 12:08:37 +0000 (12:08 +0000)]
Print the rpb device type and unit values if the root device can't be found
by the kernel.
jmatthew [Sat, 17 May 2014 11:51:21 +0000 (11:51 +0000)]
When the firmware tells us a loop id is already in use, add the device
there to our port lists, then find the next available loop id and carry on
rather than restarting. This way, we're less likely to get stuck looping
when the firmware behaves inconsistently. We also don't need to treat domain
controller logins specially.
additional complications discovered by deraadt@
aoyama [Sat, 17 May 2014 10:06:43 +0000 (10:06 +0000)]
Change the return value of interrupt handler to 0 when nothing is
processed on this driver.
"This is correct" miod@
bluhm [Sat, 17 May 2014 08:12:53 +0000 (08:12 +0000)]
When parsing a numerical value for the TOS bits, make sure that it
is in a valid range.
OK henning@
jmc [Sat, 17 May 2014 06:26:44 +0000 (06:26 +0000)]
better description for -A and -a, with help from millert;
ok millert sobrado guenther
jmc [Fri, 16 May 2014 22:11:00 +0000 (22:11 +0000)]
update NAME and MLINKS for previous;
jmc [Fri, 16 May 2014 21:50:46 +0000 (21:50 +0000)]
more STANDARDS fleshing; ok sobrado millert
tedu [Fri, 16 May 2014 21:34:48 +0000 (21:34 +0000)]
document crypt_checkpass
tedu [Fri, 16 May 2014 21:28:15 +0000 (21:28 +0000)]
add prototypes for new crypt functions
todd [Fri, 16 May 2014 21:22:13 +0000 (21:22 +0000)]
sync
mpi [Fri, 16 May 2014 19:00:18 +0000 (19:00 +0000)]
Reduce the difference between HC drivers by always passing a generic
usbd_xfer pointer to the routines processing finished transfers to make
it crystal clear that the timeout and abort logic is the same everywhere.
tedu [Fri, 16 May 2014 18:35:01 +0000 (18:35 +0000)]
save up the failures for the end in the argc == 0.
help ok espie