tb [Wed, 26 Apr 2023 20:43:32 +0000 (20:43 +0000)]
Take X509_POLICY_NODE_print() behind the barn
This used to be public API but is now only used for debug code that has
certainly never been used since it was released to the public. It drags
that debug nonsense with it.
ok beck
mvs [Wed, 26 Apr 2023 19:54:35 +0000 (19:54 +0000)]
Introduce `rtlabel_mtx' mutex(9) to protect route labels storage. This
time kernel and net locks are held in various combination to protect it.
We don't want to put kernel lock to all the places. Netlock also can't
be used because rtfree(9) which calls rtlabel_unref() has unknown
netlock state within.
This new `rtlabel_mtx' mutex(9) protects `rt_labels' list and `label'
entry dereference. Since we don't export 'rt_label' structure, keep this
lock private to net/route.c. For this reason rtlabel_id2name() now
copies label string to externally passed buffer instead of returning
address of `rt_labels' list data. This is the way which rtlabel_id2sa()
already works.
ok bluhm@
beck [Wed, 26 Apr 2023 19:16:02 +0000 (19:16 +0000)]
Add the new policy code to the build.
ok tb@ jsing@
claudio [Wed, 26 Apr 2023 19:14:54 +0000 (19:14 +0000)]
Use fprintf instead of printf and pass the FILE handle in json_do_start().
OK tb@
jmc [Wed, 26 Apr 2023 19:12:48 +0000 (19:12 +0000)]
fix some Xr;
beck [Wed, 26 Apr 2023 19:11:32 +0000 (19:11 +0000)]
Make the new policy code in x509_policy.c to be selectable at compile time.
The old policy codes remains the default, with the new policy code
selectable by defining LIBRESSL_HAS_POLICY_DAG.
ok tb@ jsing@
beck [Wed, 26 Apr 2023 19:08:10 +0000 (19:08 +0000)]
Add a shim to mimic the BoringSSL sk_delete_if function.
We add this locally as a function to avoid delving into
the unholy macro madness of STACK_OF(3).
ok tb@ jsing@
job [Wed, 26 Apr 2023 19:05:37 +0000 (19:05 +0000)]
Add lookup name+function pointer table for improved diagnostics
OK tb@
beck [Wed, 26 Apr 2023 19:05:11 +0000 (19:05 +0000)]
Adapt the sk_find calls from BoringSSL's api to ours.
ok tb@ jsing@
beck [Wed, 26 Apr 2023 19:03:46 +0000 (19:03 +0000)]
Add the STACK_OF declarations we require.
ok tb@ jsing@
beck [Wed, 26 Apr 2023 19:02:25 +0000 (19:02 +0000)]
Change OPENSSL_malloc|free|memset and friends to the normal versions.
ok tb@ jsing@
beck [Wed, 26 Apr 2023 19:00:57 +0000 (19:00 +0000)]
Fix error code goop
ok tb@ jsing@
beck [Wed, 26 Apr 2023 18:59:36 +0000 (18:59 +0000)]
Use the correct headers to compile with libressl
beck [Wed, 26 Apr 2023 18:56:52 +0000 (18:56 +0000)]
Import policy.c from BoringSSL as x509_policy.c
This is an implementation of the X509 policy processing using a
DAG instead of a tree to avoid the problem of exponential expansion
of the policy tree as specified in RFC 5280
For details see:
https://boringssl-review.googlesource.com/c/boringssl/+/55762
ok tb@ jsing@
schwarze [Wed, 26 Apr 2023 18:56:16 +0000 (18:56 +0000)]
New manual page written by Ted Bullock <tbullock at comlore dot com>,
to start working on it in the tree.
job [Wed, 26 Apr 2023 18:34:40 +0000 (18:34 +0000)]
In JSON/ASPA output, only print commas up to after the pen-ultimate applicable provider
Reported by Ties de Kock
OK claudio@
tb [Wed, 26 Apr 2023 18:17:50 +0000 (18:17 +0000)]
Kill whitespace
claudio [Wed, 26 Apr 2023 18:14:28 +0000 (18:14 +0000)]
Add prototypes for geticmptypebyname() and geticmpcodebyname().
Needed for bison.
kn [Wed, 26 Apr 2023 18:04:21 +0000 (18:04 +0000)]
Fix confusing comments, no object change; with caspar
job [Wed, 26 Apr 2023 17:59:00 +0000 (17:59 +0000)]
Make -A also apply to the JSON output
OK claudio@
tb [Wed, 26 Apr 2023 17:39:20 +0000 (17:39 +0000)]
Whitespace
"please fix" json
claudio [Wed, 26 Apr 2023 16:53:58 +0000 (16:53 +0000)]
Implement dt(4) utrace support on amd64 and i386.
This adds stacktrace_save_utrace() to extract and save the userland stack
which is stubbed out on most archs. alpha and riscv64 do not even implement
dt(4) and stacktrace_save_at() so the stubs are excluded there.
Additionally add a new ioctl DTIOCGETAUXBASE which allows btrace to
fetch the AUX_BASE vallue from the AUX vector of a process.
OK mpi@ (some time ago) discussed with kettenis@
claudio [Wed, 26 Apr 2023 16:32:41 +0000 (16:32 +0000)]
Improve accounting by tracking things by repo and tal.
This fixes some wrong accounting for repositories that are referenced
from more than one TAL. It changes the ometric lable output a little bit
since there are repository metrics that no longer include the 'name' label.
OK tb@
mlarkin [Wed, 26 Apr 2023 16:13:19 +0000 (16:13 +0000)]
Reodrer some things to fix vmctl/vmd builds after the vmm MI/MD split
mlarkin [Wed, 26 Apr 2023 16:12:21 +0000 (16:12 +0000)]
Fix vmd after vmm MI/MD split
kn [Wed, 26 Apr 2023 16:09:44 +0000 (16:09 +0000)]
Remove +20y old rt_timer_init() comment
Obsolete since last year's r1.411 "Rework the rttimer code."
OK claudio
mlarkin [Wed, 26 Apr 2023 15:40:51 +0000 (15:40 +0000)]
Incorporate r1.140 and r1.141 of vmm.c:
----------------------------
revision 1.341
date: 2023/04/26 09:39:56; author: dv; state: Exp; lines: +3 -3; commitid: 1XztmVbxa8OP2xYi;
Unbreak vmm on Intel. Mistakenly enabled CET on non-CET systems.
Found by anton@ & jsg@
----------------------------
revision 1.340
date: 2023/04/24 16:53:57; author: dv; state: Exp; lines: +11 -1; commitid: q9qQ55f7h2gen8N4;
vmm(4): allow guests to enable and use supervisor IBT.
Why should hosts have all the fun? Conditionally unmask the cpuid
bits for IBT and allow r/w access to the supervisor CET msr.
Will need revisiting when we introduce usage of userland CET msr.
kn [Wed, 26 Apr 2023 15:40:33 +0000 (15:40 +0000)]
typofix rttimer comment
mlarkin [Wed, 26 Apr 2023 15:34:31 +0000 (15:34 +0000)]
Integrate r1.339 of vmm.c which I missed during the previous MI/MD split
---
revision 1.339
date: 2023/04/22 18:27:28; author: guenther; state: Exp; lines: +3 -3; commitid: ajtkYPSAhtJdB488;
Rename the XCR0_* #defines to XFEATURE_* and add the new supervisor-state
features: while all are appropriate for xsaves/xrstors, the
supervisor-state features aren't for xcr0 but rather for the new XSS_MSR,
making the current names kinda confusing.
Add #defines for masking bits for xcr0 vs XSS.
Add and report the new XSAVE_XFD xsave subfeature bit.
---
mlarkin [Wed, 26 Apr 2023 15:13:59 +0000 (15:13 +0000)]
vmm.c -> vmm_machdep.c (remove old file)
beck [Wed, 26 Apr 2023 15:13:52 +0000 (15:13 +0000)]
Fix splassert noticed by sthen
Called wrong incore when not holding bio.
ok claudio@
mlarkin [Wed, 26 Apr 2023 15:11:21 +0000 (15:11 +0000)]
Refactor MD/MI parts of vmm.
ok dv, deraadt
schwarze [Wed, 26 Apr 2023 15:03:02 +0000 (15:03 +0000)]
Document those BIO_ctrl(3) command constants
that correspond to more than one macro each.
krw [Wed, 26 Apr 2023 14:42:27 +0000 (14:42 +0000)]
Don't rely on the disklabel defaults or a disktab entry's ba#/fa#
values for the block/fragment sizes that some install media need.
Hoist the desired values into the newfs(8) invocations to make it
obvious non-default values are required and what the values are.
No functional change.
ok kn@
kettenis [Wed, 26 Apr 2023 14:39:42 +0000 (14:39 +0000)]
Fix my email address.
phessler [Wed, 26 Apr 2023 14:28:09 +0000 (14:28 +0000)]
During boot we have a protective and restrictive pf ruleset during the time
we are running netstart, and then load the pf.conf ruleset after all of the
interfaces are loaded.
Allow in and out IPv6 neighbor advertisement traffic without state during
that time.
suggestions/OK from saschan@
OK sthen@ kn@ florian@ deraadt@
tb [Wed, 26 Apr 2023 14:27:40 +0000 (14:27 +0000)]
Remove the now unused bio_pk7.c
tb [Wed, 26 Apr 2023 14:25:58 +0000 (14:25 +0000)]
Move BIO_new_PKCS7() to the the other streaming stuff in pk7_mime.c
tb [Wed, 26 Apr 2023 14:23:18 +0000 (14:23 +0000)]
KNF nit
tb [Wed, 26 Apr 2023 13:12:51 +0000 (13:12 +0000)]
Clean up ec.h a little.
The doxygen comments are either obvious or otherwise unhelpful and
generally an eye sore. Go read the manpage if the header isn't enough.
krw [Wed, 26 Apr 2023 13:01:02 +0000 (13:01 +0000)]
Nuke variable 'LBA'. Always set for ramdisk_cd, never set for
ramdisk, so just keep or remove the conditional sections.
ok kn@ miod@
kettenis [Wed, 26 Apr 2023 12:30:24 +0000 (12:30 +0000)]
Properly handle userland branch target traps.
ok deraadt@, patrick@
bluhm [Wed, 26 Apr 2023 12:25:12 +0000 (12:25 +0000)]
Backout previous commit:
Do not grab the `vmmaplk' recursively, prevent a self-deadlock.
It causes panic: uvm_map_pageable_wire: stale map
Found by regress/misc/posixtestsuite conformance/interfaces/mmap/18-1
requested by deraadt@
job [Wed, 26 Apr 2023 11:06:32 +0000 (11:06 +0000)]
Parameter names are not needed
job [Wed, 26 Apr 2023 11:04:12 +0000 (11:04 +0000)]
Remove unneeded parentheses
job [Wed, 26 Apr 2023 11:00:49 +0000 (11:00 +0000)]
No need to pass around const pointer cpder2
Suggested by tb@
job [Wed, 26 Apr 2023 10:55:58 +0000 (10:55 +0000)]
Shrink signature as cpder is only needed as local variable
Suggested by tb@
mlarkin [Wed, 26 Apr 2023 10:52:55 +0000 (10:52 +0000)]
whitespace fix
job [Wed, 26 Apr 2023 10:34:08 +0000 (10:34 +0000)]
Replace macros with functions
Requested by tb@
dv [Wed, 26 Apr 2023 10:14:21 +0000 (10:14 +0000)]
regress: remove vmd path length tests.
These add no value and we'd now that we don't artificially limit
path lengths just be updating them to check PATH_MAX.
beck [Wed, 26 Apr 2023 10:00:37 +0000 (10:00 +0000)]
Don't redeclare s, it's already there.
noticed by miod@
ok kettenis@
beck [Wed, 26 Apr 2023 09:53:55 +0000 (09:53 +0000)]
Fix missing splbio() needed in nfs
ok claudio@ kettenis@
dv [Wed, 26 Apr 2023 09:39:56 +0000 (09:39 +0000)]
Unbreak vmm on Intel. Mistakenly enabled CET on non-CET systems.
Found by anton@ & jsg@
tb [Wed, 26 Apr 2023 09:31:12 +0000 (09:31 +0000)]
Some more EC2M cleanup
bentley [Wed, 26 Apr 2023 09:19:47 +0000 (09:19 +0000)]
Rotate the console in amdgpu when there is an orientation quirk.
ok jsg@
tb [Wed, 26 Apr 2023 09:07:59 +0000 (09:07 +0000)]
Garbage collect test using the nseq command
reminded by anton
job [Wed, 26 Apr 2023 08:58:03 +0000 (08:58 +0000)]
Rename dercache regress test to x509_asn1
Requested by jsing@
bentley [Wed, 26 Apr 2023 08:38:51 +0000 (08:38 +0000)]
Fix typo in comment: default scalue values -> default scale values
tb [Wed, 26 Apr 2023 08:25:37 +0000 (08:25 +0000)]
Remove e_old.c again
Also remove nonexistent symbols #defined to other symbols that confuse
some linkers in -portable.
This commit entails no ABI change on OpenBSD.
Discussed with jsing
gnezdo [Wed, 26 Apr 2023 06:52:45 +0000 (06:52 +0000)]
Declare sendsyslog to match its man page
This simplifies syzkaller revival after the removal of __syscall.
OK bluhm, millert, deraadt
asou [Wed, 26 Apr 2023 02:38:08 +0000 (02:38 +0000)]
Add parent to nvgre in ifconfig.8.
ok david@
djm [Wed, 26 Apr 2023 01:36:03 +0000 (01:36 +0000)]
Check for ProxyJump=none in CanonicalizeHostname logic.
Previously ssh would incorrectly refuse to canonicalise the hostname
if ProxyJump was explicitly set to "none" when CanonicalizeHostname=yes
bz3567; ok dtucker
jan [Wed, 26 Apr 2023 00:14:21 +0000 (00:14 +0000)]
Also set TSO flag on vlan interfaces.
with tweaks from bluhm, claudio and dlg
I fine with it from claudio
looks good to me from dlg
ok bluhm
tb [Tue, 25 Apr 2023 23:16:31 +0000 (23:16 +0000)]
Reinstate e_old.c it is still used by -portable
bluhm [Tue, 25 Apr 2023 22:56:28 +0000 (22:56 +0000)]
Fix white space.
kettenis [Tue, 25 Apr 2023 21:58:36 +0000 (21:58 +0000)]
regen
kettenis [Tue, 25 Apr 2023 21:57:29 +0000 (21:57 +0000)]
Add RK3588.
job [Tue, 25 Apr 2023 21:51:44 +0000 (21:51 +0000)]
Add regress test for invalidation of DER cache in select X509 setter functions
tb [Tue, 25 Apr 2023 20:07:55 +0000 (20:07 +0000)]
Remove documentation of BN_BLINDING_{g,s}et_thread_id
tb [Tue, 25 Apr 2023 20:06:35 +0000 (20:06 +0000)]
e_old can also go
tb [Tue, 25 Apr 2023 19:57:59 +0000 (19:57 +0000)]
Remove the deprecated API from BN
tb [Tue, 25 Apr 2023 19:53:30 +0000 (19:53 +0000)]
GF2m bites the dust. It won't be missed.
tb [Tue, 25 Apr 2023 19:52:25 +0000 (19:52 +0000)]
ASN1_item_ndef_i2d also goes. discussed with deraadt
tb [Tue, 25 Apr 2023 19:48:24 +0000 (19:48 +0000)]
bio_asn1: adjust for more recent churn
tb [Tue, 25 Apr 2023 19:34:06 +0000 (19:34 +0000)]
Remove commented version of OPENSSL_NO_EC2M
tb [Tue, 25 Apr 2023 19:32:19 +0000 (19:32 +0000)]
Remove duplicate NID definitions
tb [Tue, 25 Apr 2023 19:29:36 +0000 (19:29 +0000)]
LIBRESSL_NEXT_API is no longer needed
tb [Tue, 25 Apr 2023 19:28:22 +0000 (19:28 +0000)]
Remove prototype of EC_GFp_nist_method()
tb [Tue, 25 Apr 2023 19:26:45 +0000 (19:26 +0000)]
Move EC_KEY_{insert,set}_key_method_data() to internal-only
tb [Tue, 25 Apr 2023 19:08:30 +0000 (19:08 +0000)]
Move low level BIO_new_NDEF API to internal-only
tb [Tue, 25 Apr 2023 19:01:01 +0000 (19:01 +0000)]
Remove proxy cert remnants
tb [Tue, 25 Apr 2023 18:57:57 +0000 (18:57 +0000)]
Remove NETSCAPE_CERT_SEQUENCE
tb [Tue, 25 Apr 2023 18:53:42 +0000 (18:53 +0000)]
Move the policy STACK_OF stuff to pcy_int.h as well
tb [Tue, 25 Apr 2023 18:49:23 +0000 (18:49 +0000)]
sync
tb [Tue, 25 Apr 2023 18:48:32 +0000 (18:48 +0000)]
Remove SXNET
Unused and no authorative information was found online in 2016
tb [Tue, 25 Apr 2023 18:39:12 +0000 (18:39 +0000)]
Move truncated sha-2 and sha3 out of #ifdef wrappers
tb [Tue, 25 Apr 2023 18:37:56 +0000 (18:37 +0000)]
Use X509_STORE_CTX_get1_{certs,crls}() instead of an alias
tb [Tue, 25 Apr 2023 18:33:50 +0000 (18:33 +0000)]
X509_STORE_get1_{certs,crls} become X509_STORE_CTX_* also in
Symbols.namespace
tb [Tue, 25 Apr 2023 18:32:42 +0000 (18:32 +0000)]
X509_STORE_get1_{certs,crls} become X509_STORE_CTX_*
This matches the OpenSSL 1.1 API a bit better.
tb [Tue, 25 Apr 2023 18:28:05 +0000 (18:28 +0000)]
Move the policy tree code to internal-only
A few hooks remain in the legacy validator, which will soon be replaced
with something better. The rest of the tentacles are now largely contained.
claudio [Tue, 25 Apr 2023 18:14:06 +0000 (18:14 +0000)]
Rename ps_refcnt to ps_threadcnt in struct process and implement
P_HASSIBLING() using this count.
OK mvs@ mpi@
tb [Tue, 25 Apr 2023 18:13:25 +0000 (18:13 +0000)]
Remove i2d_PKCS7_NDEF from the hidden version as well
tb [Tue, 25 Apr 2023 18:05:07 +0000 (18:05 +0000)]
Remove documentation for i2d_PKCS7_NDEF
tb [Tue, 25 Apr 2023 18:04:03 +0000 (18:04 +0000)]
Remove i2d_PKCS7_NDEF
tb [Tue, 25 Apr 2023 17:59:41 +0000 (17:59 +0000)]
BN_RECP_CTX moves to internal
schwarze [Tue, 25 Apr 2023 17:57:55 +0000 (17:57 +0000)]
Put ERRORS and DIAGNOSTICS information in the sections where they belong.
More details on RETURN VALUES and ERRORS.
Document all DIAGNOSTICS messages except the various malloc(3)-related
ones and except those that cannot actually occur but would merely report
violations of internal invariants. Shorten some wordings in this section.
Using feedback from jmc@ and Ted Bullock.
OK jmc@ and nicm@ on an earlier version.
tb [Tue, 25 Apr 2023 17:54:10 +0000 (17:54 +0000)]
Remove CTS mode
ok jsing
tb [Tue, 25 Apr 2023 17:52:54 +0000 (17:52 +0000)]
Remove TS_VERIFY_CTX_init()
tb [Tue, 25 Apr 2023 17:51:36 +0000 (17:51 +0000)]
Remove PEM wrappers for NETSCAPE_CERT_SEQUENCE
tb [Tue, 25 Apr 2023 17:42:07 +0000 (17:42 +0000)]
Remove the horror show that is bn_nist and ecp_nist
This code is full of problematic C and is also otherwise of questionable
quality. It is far from constant time and jsing informs me it also isn't
faster. Good riddance.