kettenis [Sat, 17 Aug 2024 10:33:56 +0000 (10:33 +0000)]
Linux doesn't consider S4 to be a suspend target state.
ok jsg@
denis [Sat, 17 Aug 2024 09:52:11 +0000 (09:52 +0000)]
Allow PPP interface to run in an rdomain and get a default route installed in the same routing domain
Input and OK claudio@
phessler [Sat, 17 Aug 2024 09:48:31 +0000 (09:48 +0000)]
effectively revert revision 1.7.
The original reason was some corner cases around COPY relocations, which
caused problems for miniperl which directly modified environ and accessed
environ via libc functions.
This causes duplicate symbols for environ/__progname in some (poorly written)
apps, but is allowed on most other architectures.
Since the time this was added other arm architecture changes mean that we
don't need it, so remove it.
debugged with kettenis@ and jca@
tested and OK guenther@
tb [Sat, 17 Aug 2024 09:19:04 +0000 (09:19 +0000)]
Zap a trailing comma to appease mandoc -Tlint
tb [Sat, 17 Aug 2024 09:17:27 +0000 (09:17 +0000)]
sync
tb [Sat, 17 Aug 2024 09:16:37 +0000 (09:16 +0000)]
Remove docs of various X509_TRUST "functionality" that no longer exists
Some macros are still exposed, but apart from the loss of a very nice way
of saying "this is completely misdesigned, overengineered and not properly
thought through" the only thing we would have learned from it is that this
stuff is "probably useless".
florian [Sat, 17 Aug 2024 09:07:33 +0000 (09:07 +0000)]
Since we are not using a pid file the manuals render a bit strange.
Pointed out by tb
miod [Sat, 17 Aug 2024 08:45:22 +0000 (08:45 +0000)]
Checkpoint of work-in-progress attempt to support the FireGL-UX board. This
particular sti(4) device relies upon undocumented callbacks from the kernel,
and will default to iodc code otherwise.
The device now initializes correctly, but writes to the frame buffer memory
freeze the system due to bad interaction with the ROM even though it is
disabled at the PCI level - unfortunately I'm currently out of hair to pull
at the moment to make any progress on this.
No functional change intended for other sti(4) devices.
miod [Sat, 17 Aug 2024 08:41:25 +0000 (08:41 +0000)]
Correct capitalization of FXe and use decimal version numbering for
rom features, to match what dmesg reports.
djm [Sat, 17 Aug 2024 08:35:04 +0000 (08:35 +0000)]
mention that
ed25519 is the default key type generated and
clarify that rsa-sha2-512 is the default signature scheme when RSA
is in use. Based on GHPR505 from SebastianRzk
djm [Sat, 17 Aug 2024 08:23:04 +0000 (08:23 +0000)]
fix minor memory leak in Subsystem option parsing;
from Antonio Larrosa via GHPR515
stsp [Sat, 17 Aug 2024 08:12:46 +0000 (08:12 +0000)]
enable qwx(4) ext irqs earlier for suspend/resume
Enable ext IRQs like the Linux driver does it, not later. I did this
differently due to problems in early development that have since
been fixed.
Fixes an interrupt storm during resume which prevents things like
key installation from working, leaving the network link dead.
djm [Sat, 17 Aug 2024 08:09:50 +0000 (08:09 +0000)]
fix swapping of source and destination addresses in some sshd log messages
jsg [Sat, 17 Aug 2024 07:02:13 +0000 (07:02 +0000)]
avoid uninitialised var use in nfs_serv.c error paths
some functions have a nfsmout label with code that assumes NDINIT has
been called
nfsrv_rename has two NDINIT calls, the nfsmout code assumes both are
setup but is only jumped to when none/one is setup
found with llvm scan-build
checked by deraadt@ beck@, ok miod@
yasuoka [Sat, 17 Aug 2024 03:28:22 +0000 (03:28 +0000)]
Fix some memory leaks in the RADIUS part.
ok tobhe
deraadt [Sat, 17 Aug 2024 02:35:00 +0000 (02:35 +0000)]
whitespace
deraadt [Sat, 17 Aug 2024 02:31:15 +0000 (02:31 +0000)]
perusing drivers on other systems, there appears to be some cynism about
how this chip comes out of D3 and when the RESET register is touched.
Some systems were still wasn't resuming reliabily, but adding these
delays has eliminated resume-hangs.
ok kettenis mlarkin
deraadt [Sat, 17 Aug 2024 02:28:45 +0000 (02:28 +0000)]
The dwiic_init() routine is used at startup to read various chip
registers, make some decisions, and then program other registers. After
a resume, it is pointless, and potentially incorrect to read such registers
again, which a BIOS or something may not have initialized, and we are
better off using the remembered soft-state to init cleanly. So craft a
custom block of chip restoration, and do it while the chip is stopped hard.
ok kettenis mlarkin
deraadt [Sat, 17 Aug 2024 02:24:03 +0000 (02:24 +0000)]
dwiic_activate did not inform sub-devices with config_activate_children()
calls from the correct places, so their DVACT_QUIESCE and DVACT_WAKEUP
were incorrect, and led to those sub-drivers (ihidev and imt) racing
against dwiic hardware re-initialization.
ok kettenis mlarkin
deraadt [Sat, 17 Aug 2024 02:14:20 +0000 (02:14 +0000)]
dwiic resume is almost exclusively a "hardware state restore", and
not a "restart transaction", so the job should get done at DVACT_RESUME
time.
ok kettenis mlarkin
jsg [Sat, 17 Aug 2024 01:55:03 +0000 (01:55 +0000)]
skip Controller Save State (CSS) and Controller Restore State (CRS)
on AMD 17h/1xh xHCI
avoids problem with resume after CRS was introduced in xhci.c rev 1.133
uhub0: device problem, disabling port 2
uhub1: device problem, disabling port 1
reported by brynet@ and reproduced on t495, ok kettenis@
guenther [Fri, 16 Aug 2024 23:09:25 +0000 (23:09 +0000)]
Cast to unsigned char after or'ing in the meta bit, so the compiler
doesn't complain when it's implicitly converted to plain char in an
assignment, and to make sure it's not negative when used as an array index.
ok miod@
guenther [Fri, 16 Aug 2024 22:58:54 +0000 (22:58 +0000)]
Delete duplicated x{m,re}alloc() declarations and add argument types
to a function pointer definition.
ok miod@
guenther [Fri, 16 Aug 2024 22:57:44 +0000 (22:57 +0000)]
Delete bogus test of array being NULL
ok miod@
guenther [Fri, 16 Aug 2024 22:57:03 +0000 (22:57 +0000)]
strn?casecmp() config bits were incomplete. We have them so
just delete the bogus declarations. Also, getopt() is in <unistd.h>
so pull that in during the remapping of it.
ok miod@
guenther [Fri, 16 Aug 2024 22:53:32 +0000 (22:53 +0000)]
Fix precedence lossage reported by clang that results in
bad buffer size.
ok miod@
deraadt [Fri, 16 Aug 2024 16:57:02 +0000 (16:57 +0000)]
sync
mpi [Fri, 16 Aug 2024 16:19:03 +0000 (16:19 +0000)]
Atomically modify `nthreads' and move proc_free() out of KERNEL_LOCK().
ok jca@
florian [Fri, 16 Aug 2024 16:11:06 +0000 (16:11 +0000)]
Remove reference to telnet(1).
telnet(1) doesn't have anything to do with login(1), maybe telnetd(8)
did, but that was taken behind the barn nearly 20 years ago.
Earlier version OK miod
Input dtucker
OK jmc, sthen, deraadt
florian [Fri, 16 Aug 2024 16:10:27 +0000 (16:10 +0000)]
telnet(1) is not a good example for logging in over the network.
OK jmc, sthen, deraadt
florian [Fri, 16 Aug 2024 16:00:30 +0000 (16:00 +0000)]
Add pledge & unveil.
The rpc library needs read access to the rpc database in
/etc/rpc. Other than that rpcinfo only uses AF_INET sockets.
With -b, rpcinfo(8) uses gethostbyaddr(3) to report hosts that
responded, so add "dns" pledge as well.
OK bluhm, miod
deraadt [Fri, 16 Aug 2024 15:27:11 +0000 (15:27 +0000)]
whitespace
jan [Fri, 16 Aug 2024 13:02:44 +0000 (13:02 +0000)]
vio(4): Don't set IPv4 checksum OK flag for rx packets.
The virtio specification just address TCP/UDP checksum offloading.
Thus, we have to check the IPv4 checksum in our stack.
ok sf@
miod [Fri, 16 Aug 2024 12:22:17 +0000 (12:22 +0000)]
Fix bounds checking in wsmux_getmux().
kettenis [Fri, 16 Aug 2024 10:49:57 +0000 (10:49 +0000)]
Set CONFIG_AMD_PMC. We don't have the corresponding driver just yet, but
it seems that Linux is just overcautious in disabling S0 suspend when the
driver isn't included in the kernel config. And we plan to implement the
driver soon anyway.
ok jsg@
kettenis [Fri, 16 Aug 2024 10:46:46 +0000 (10:46 +0000)]
Hook up a few more bits of suspend/resume power management code. This
fixes S3 suspend/resume on the Lenovo ThinCentre M715q with:
amdgpu0: RAVEN GC 9.1.0 8 CU rev 0x01
and also fixes S0 suspend/resume on various laptops with AMD graphics
provided we disable a few checks (which will be done in a separate
commit).
ok jsg@
kettenis [Fri, 16 Aug 2024 10:26:20 +0000 (10:26 +0000)]
drm/amd: Stop evicting resources on APUs in suspend
From Mario Limonciello
3a9626c816db901def438dc2513622e281186d39 in mainline linux
yasuoka [Fri, 16 Aug 2024 09:54:21 +0000 (09:54 +0000)]
Make sure that the uptime field is always updated. Previously it was
used before initialized when the database has a session.
yasuoka [Fri, 16 Aug 2024 09:52:16 +0000 (09:52 +0000)]
Free memory as much as possible. Also, fix a use-after-free when exiting.
yasuoka [Fri, 16 Aug 2024 09:50:09 +0000 (09:50 +0000)]
Send a reply to the control client when DAE is timed out instead of
silence. Also, fix a broken error string.
yasuoka [Fri, 16 Aug 2024 09:45:52 +0000 (09:45 +0000)]
Delete req_modified. Which is not used.
mvs [Fri, 16 Aug 2024 09:20:34 +0000 (09:20 +0000)]
Introduce PR_MPSYSCTL flag to mark mp-safe (*pr_sysctl)() handlers and
unlock both divert_sysctl() and divert6_sysctl(). Unlock them together,
because they are identical and pretty simple:
- DIVERTCTL_RECVSPACE and DIVERTCTL_SENDSPACE - atomically accessed
integers;
- DIVERTCTL_STATS - per-CPU counters;
ok bluhm
robert [Fri, 16 Aug 2024 06:42:21 +0000 (06:42 +0000)]
add 7.7 syspatch pubkey
deraadt [Fri, 16 Aug 2024 04:14:27 +0000 (04:14 +0000)]
delete disabled ACPI-related code in here, this power management is
done at a different level, and nothing needs to be done here
ok kettenis
patrick [Fri, 16 Aug 2024 00:26:54 +0000 (00:26 +0000)]
Align more register addresses and data structures with ath12k.
patrick [Thu, 15 Aug 2024 23:23:06 +0000 (23:23 +0000)]
Further minor cleanup for improved readability, with the major change that
FW now seems to come up after providing regdb parsed out of the board file.
patrick [Thu, 15 Aug 2024 22:01:37 +0000 (22:01 +0000)]
Initial patchset on top of the qwx(4) to adjust for ath12k. Still not
working yet, but it's better to continue polishing this in-tree.
deraadt [Thu, 15 Aug 2024 17:30:40 +0000 (17:30 +0000)]
whitespace
kettenis [Thu, 15 Aug 2024 17:17:05 +0000 (17:17 +0000)]
Upon resume, restore the saved state. Newer Intel xHCI controller (e.g.
those on Meteor Lake) need this, otherwise the ports are dead after
resume.
ok mglocker@, deraadt@
deraadt [Thu, 15 Aug 2024 16:55:06 +0000 (16:55 +0000)]
sync
deraadt [Thu, 15 Aug 2024 14:43:28 +0000 (14:43 +0000)]
sync
claudio [Thu, 15 Aug 2024 13:26:16 +0000 (13:26 +0000)]
Regen some OK files since the bgpctl rib header changed.
Friendly reminder by anton@
dlg [Thu, 15 Aug 2024 12:20:20 +0000 (12:20 +0000)]
add BIOCSETFNR, which is like BIOCSETF but doesnt reset the buffer or stats.
from Matthew Luckie <mjl@luckie.org.nz> via tech@
deraadt@ likes it.
job [Thu, 15 Aug 2024 11:30:43 +0000 (11:30 +0000)]
Ensure synchronization jobs are stopped when the timeout is reached
OK tb@ claudio@
patrick [Thu, 15 Aug 2024 11:26:03 +0000 (11:26 +0000)]
sync
patrick [Thu, 15 Aug 2024 11:25:37 +0000 (11:25 +0000)]
Add Qualcomm WCN7850
sthen [Thu, 15 Aug 2024 10:25:25 +0000 (10:25 +0000)]
add 77-fw pubkey
tb [Thu, 15 Aug 2024 09:46:39 +0000 (09:46 +0000)]
bsd.port.mk: typo dbp -> dpb
tb [Thu, 15 Aug 2024 09:29:12 +0000 (09:29 +0000)]
Document DWZ and fix a few mandoc lints
from espie
claudio [Thu, 15 Aug 2024 09:22:12 +0000 (09:22 +0000)]
Call repo_check_timeout() before colleting the POLLOUT fds. Since
repo_abort() called by repo_check_timeout() will add messages to
be sent out.
OK tb@
claudio [Thu, 15 Aug 2024 09:13:13 +0000 (09:13 +0000)]
Add filtered support to bgplgd.
OK tb@
yasuoka [Thu, 15 Aug 2024 07:24:28 +0000 (07:24 +0000)]
Accept empty lines for authopts to fix the parser to accept the old
syntax. It was broken by parse.y 1.18. Found by Mike at mgm51.com.
guenther [Thu, 15 Aug 2024 06:27:24 +0000 (06:27 +0000)]
unifdef for S_I{FLNK,FIFO,FSOCK}. For the operations where we use
access() (-r, -w, -x, -e) do them without requiring stat() to succeed first.
ok tb@ deraadt@
jsg [Thu, 15 Aug 2024 03:24:29 +0000 (03:24 +0000)]
drm/radeon: Remove __counted_by from StateArray.states[]
From Bill Wendling
ea12dbf570ef1cbbf857dfa80fbdd66cc0e4612b in linux-6.6.y/6.6.46
2bac084468847cfe5bbc7166082b2a208514bb1c in mainline linux
jsg [Thu, 15 Aug 2024 03:22:41 +0000 (03:22 +0000)]
drm/dp_mst: Skip CSN if topology probing is not done yet
From Wayne Lin
28c060cd370d2718345452f4182cba115b7367e8 in linux-6.6.y/6.6.46
ddf983488c3e8d30d5c2e2b315ae7d9cd87096ed in mainline linux
jsg [Thu, 15 Aug 2024 03:20:40 +0000 (03:20 +0000)]
drm/client: fix null pointer dereference in drm_client_modeset_probe
From Ma Ke
d64fc94f7bb24fc2be0d6bd5df8df926da461a6d in linux-6.6.y/6.6.46
113fd6372a5bb3689aba8ef5b8a265ed1529a78f in mainline linux
jsg [Thu, 15 Aug 2024 03:18:56 +0000 (03:18 +0000)]
drm/i915/gem: Adjust vma offset for framebuffer mmap offset
From Andi Shyti
d73de3c6447644c65ed0e9a368328713dc28fb18 in linux-6.6.y/6.6.46
1ac5167b3a90c9820daa64cc65e319b2d958d686 in mainline linux
jsg [Thu, 15 Aug 2024 03:15:06 +0000 (03:15 +0000)]
drm/amdgpu: Forward soft recovery errors to userspace
From Joshua Ashton
0da0b06165d83a8ecbb6582d9d5a135f9d38a52a in linux-6.6.y/6.6.46
829798c789f567ef6ba4b084c15b7b5f3bd98d51 in mainline linux
jsg [Thu, 15 Aug 2024 03:12:41 +0000 (03:12 +0000)]
drm/amd/display: Skip Recompute DSC Params if no Stream on Link
From Fangzhi Zuo
718d83f66fb07b2cab89a1fc984613a00e3db18f in linux-6.6.y/6.6.46
50e376f1fe3bf571d0645ddf48ad37eb58323919 in mainline linux
jsg [Thu, 15 Aug 2024 03:10:37 +0000 (03:10 +0000)]
drm/i915/gem: Fix Virtual Memory mapping boundaries calculation
From Andi Shyti
4b09513ce93b3dcb590baaaff2ce96f2d098312d in linux-6.6.y/6.6.46
8bdd9ef7e9b1b2a73e394712b72b22055e0e26c3 in mainline linux
jsg [Thu, 15 Aug 2024 03:08:00 +0000 (03:08 +0000)]
drm/amd/display: Add null checker before passing variables
From Alex Hung
4cc2a94d96caeb3c975acdae7351c2f997c32175 in linux-6.6.y/6.6.46
8092aa3ab8f7b737a34b71f91492c676a843043a in mainline linux
jsg [Thu, 15 Aug 2024 03:06:09 +0000 (03:06 +0000)]
drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr
From Bob Zhou
2e538944996d0dd497faf8ee81f8bfcd3aca7d80 in linux-6.6.y/6.6.46
50151b7f1c79a09117837eb95b76c2de76841dab in mainline linux
jsg [Thu, 15 Aug 2024 03:04:18 +0000 (03:04 +0000)]
drm/amdgpu: Add lock around VF RLCG interface
From Victor Skvortsov
1adb5ebe205e96af77a93512e2d5b8c437548787 in linux-6.6.y/6.6.46
e864180ee49b4d30e640fd1e1d852b86411420c9 in mainline linux
jsg [Thu, 15 Aug 2024 03:01:36 +0000 (03:01 +0000)]
drm/admgpu: fix dereferencing null pointer context
From Jesse Zhang
641dac64178ccdb9e45c92b67120316896294d05 in linux-6.6.y/6.6.46
030ffd4d43b433bc6671d9ec34fc12c59220b95d in mainline linux
jsg [Thu, 15 Aug 2024 02:59:50 +0000 (02:59 +0000)]
drm/amdgpu/pm: Fix the null pointer dereference in apply_state_adjust_rules
From Ma Jun
3a01bf2ca9f860fdc88c358567b8fa3033efcf30 in linux-6.6.y/6.6.46
d19fb10085a49b77578314f69fff21562f7cd054 in mainline linux
jsg [Thu, 15 Aug 2024 02:58:13 +0000 (02:58 +0000)]
drm/amdgpu: Fix the null pointer dereference to ras_manager
From Ma Jun
b89616333979114bb0da5fa40fb6e4a2f5294ca2 in linux-6.6.y/6.6.46
4c11d30c95576937c6c35e6f29884761f2dddb43 in mainline linux
jsg [Thu, 15 Aug 2024 02:56:22 +0000 (02:56 +0000)]
drm/amdgpu/pm: Fix the null pointer dereference for smu7
From Ma Jun
09544cd95c688d3041328a4253bd7514972399bb in linux-6.6.y/6.6.46
c02c1960c93eede587576625a1221205a68a904f in mainline linux
jsg [Thu, 15 Aug 2024 02:53:57 +0000 (02:53 +0000)]
drm/amdgpu/pm: Fix the param type of set_power_profile_mode
From Ma Jun
837ab17ceef90a85ddfc918935ed1f19ff60d09b in linux-6.6.y/6.6.46
f683f24093dd94a831085fe0ea8e9dc4c6c1a2d1 in mainline linux
jsg [Thu, 15 Aug 2024 02:51:35 +0000 (02:51 +0000)]
drm/amdgpu: fix potential resource leak warning
From Tim Huang
bc93cfde69b7c786fcdc70463e153fdf633caff9 in linux-6.6.y/6.6.46
22a5daaec0660dd19740c4c6608b78f38760d1e6 in mainline linux
jsg [Thu, 15 Aug 2024 02:49:48 +0000 (02:49 +0000)]
drm/amd/display: Add delay to improve LTTPR UHBR interop
From Michael Strauss
479ccc2132171f7e711f8154408ec6106f6e1df3 in linux-6.6.y/6.6.46
10839ee6a977ed1f7d0f4deb29f2d7e5d1f2a9dd in mainline linux
guenther [Thu, 15 Aug 2024 01:32:59 +0000 (01:32 +0000)]
t_recvmmsg and t_sendmmsg were enabled in 2022
guenther [Thu, 15 Aug 2024 01:25:13 +0000 (01:25 +0000)]
Support describing ABI changes for static libraries too.
Try the -S option
djm [Thu, 15 Aug 2024 00:52:23 +0000 (00:52 +0000)]
adapt to EVP_PKEY conversion
djm [Thu, 15 Aug 2024 00:51:51 +0000 (00:51 +0000)]
Convert RSA and ECDSA key to the libcrypto EVP_PKEY API. DSA remains
unconverted as it will be removed within six months.
Based on patches originally from Dmitry Belyavskiy, but significantly
reworked based on feedback from Bob Beck, Joel Sing and especially
Theo Buehler (apologies to anyone I've missed).
ok tb@
guenther [Thu, 15 Aug 2024 00:47:44 +0000 (00:47 +0000)]
'newercnt' no longer does anything that 'refcnt' doesn't; eliminate
the former in favor of the latter.
ok millert@
claudio [Wed, 14 Aug 2024 19:10:51 +0000 (19:10 +0000)]
Add 'bgpctl show rib filtered' support.
OK tb@
claudio [Wed, 14 Aug 2024 19:09:51 +0000 (19:09 +0000)]
Introduce 'rde rib Loc-RIB include filtered' a feature that includes
filtered prefixes in the Loc-RIB
This includes filtered prefixes into the Loc-RIB but they are marked
ineligible so nothing will select them but it is possible to show them
in bgpctl. So 'bppctl show rib filtered' will return all prefixes filtered
out by the input filters.
OK tb@
bluhm [Wed, 14 Aug 2024 18:31:33 +0000 (18:31 +0000)]
Implement bounce buffering for AMD SEV in amd64 bus dma.
When running as SEV guest, as indicated by variable cpu_sev_guestmode,
allocate additional pages for each segment on dma map creation.
These pages are mapped with the PMAP_NOCRYPT attribute, i.e. the
crypt bit is not set in the PTE. Thus, these pages are shared with
the hypervisor.
When the map is loaded with actual pages, the address in the
descriptor is replaced by the corresponding bounce buffer. Using
bus_dmamap_sync(), data is copied from the encrypted pages used by
guest drivers to the unencrypted bounce buffers shared with the
hypervisor, and vice versa.
If the kernel is not running in SEV guest mode, which means as
normal host or non-SEV guest, no bounce buffers are used.
from hshoexer@; based on ancient code of mickey@; OK kettenis@
mvs [Wed, 14 Aug 2024 17:52:47 +0000 (17:52 +0000)]
Push kernel lock down to net_sysctl().
All except PF_MPLS paths are mp-safe:
- net_link_sysctl() and following net_ifiq_sysctl() only return
EOPNOTSUPP;
- uipc_sysctl() - mp-safe atomic access to integers;
- bpf_sysctl() - mp-safe atomic access to integers;
- pflow_sysctl() - returns statistics from per-CPU counters;
- pipex_sysctl() - mp-safe atomic access to integer;
Push kernel lock down to mpls_sysctl(). sysctl_int_bounded() do copying
with local variable, so context switch is safe. No need to wire memory
or take `sysctl_lock' rwlock(9).
Keep protocols locked as they was include pages wiring. Copying will not
sleep - no network slowdown while doing it with net lock held.
ok bluhm
florian [Wed, 14 Aug 2024 17:38:57 +0000 (17:38 +0000)]
resdebug and no_tld_query are unused
florian [Wed, 14 Aug 2024 17:37:40 +0000 (17:37 +0000)]
sortlist is unused
florian [Wed, 14 Aug 2024 17:36:48 +0000 (17:36 +0000)]
lwserver is unused, whatever that is / was.
tobias [Wed, 14 Aug 2024 15:42:18 +0000 (15:42 +0000)]
Reorder calloc arguments
The first argument should be the amount, the second argument should be the
element size. Fixing this also silences some gcc compiler warnings for
portable.
Spotted with Benny Baumann (BenBE at geshi dot org).
ok djm@
tobias [Wed, 14 Aug 2024 15:40:30 +0000 (15:40 +0000)]
Extend sshbuf validation
Multiple sshbuf structs can be linked through a parent/child relationship.
Make sure that a single sshbuf cannot be its own parent. If this would ever
happen, it would result in reference counting issues.
This is a cheap way of testing this with very little overhead. It does not
detect A->B->A linkages though for performance reason and the fact that it
takes a programming error for this to occur anyway.
Authored with Benny Baumann (BenBE at geshi dot org).
ok djm@
tobias [Wed, 14 Aug 2024 15:37:11 +0000 (15:37 +0000)]
Use freezero for better readability
It has the same meaning as the current pair of calling explicit_bzero
and free. Spotted with Benny Baumann (BenBE at geshi dot org).
ok djm@
tobias [Wed, 14 Aug 2024 15:35:23 +0000 (15:35 +0000)]
Fix typo in comment
Spotted with Benny Baumann (BenBE at geshi dot org).
ok djm@
jsg [Wed, 14 Aug 2024 15:34:39 +0000 (15:34 +0000)]
mention apple machines needing activation after erase
ok patrick@ kettenis@ krw@
patrick [Wed, 14 Aug 2024 14:40:45 +0000 (14:40 +0000)]
Introduce qwz(4), a work-in-progress port of the Linux ath12k driver.
This driver is not working yet, it's a copy of qwx(4) which bit-by-bit will be
adjusted to work on the newer generation of chips. Even though this is only a
minor bump over the previous generation, the changes are large enough that
bringup, debugging and long-term maintenance would suffer trying to squash them
into a single driver. This can be reconsidered once we have reached a stable
state.
mvs [Wed, 14 Aug 2024 13:54:08 +0000 (13:54 +0000)]
Make sysctl_int() and sysctl_int_lower() mp-safe and unlock KERN_HOSTID.
The only difference between sysctl_int() and sysctl_int_bounded()
is the range check, so sysctl_int() is just sysctl_int_bounded(...,
INT_MIN, INT_MAX). sysctl_int() is not the fast path, so this useless
check is not significant.
Mp-safe sysctl_int() is meaningless for sysctl_int_lower(), so rework it
in the sysctl_int_bounded() style. This time all affected paths are
kernel locked, but this doesn't make sysctl_int_lower() worse.
Change `hostid' type to the type of int. It only stored but never used
within kernel, userland accesses it through sysctl_int(). Nothing
changes, but variable becomes consistent with sysctl_int().
ok bluhm
mglocker [Wed, 14 Aug 2024 10:54:58 +0000 (10:54 +0000)]
In a qcspmi_cmd_read() error case, the register is only returning the error
bit, not SPMI_STATUS_DONE. Therefore, catch the error at the right place,
and print the specific error type.
ok patrick@