openbsd
7 months agoFix merge issues, remove excess files - match perl-5.38.2 dist
afresh1 [Tue, 14 May 2024 19:38:53 +0000 (19:38 +0000)]
Fix merge issues, remove excess files - match perl-5.38.2 dist

ok gkoehler@
Commit and we'll fix fallout bluhm@
Right away, please deraadt@

7 months agoImport perl-5.38.2
afresh1 [Tue, 14 May 2024 19:36:00 +0000 (19:36 +0000)]
Import perl-5.38.2

ok gkoehler@
Commit and we'll fix fallout bluhm@
Right away, please deraadt@

7 months agoThe makewhatis(8) program already provided a "-T utf8" option
schwarze [Tue, 14 May 2024 18:38:13 +0000 (18:38 +0000)]
The makewhatis(8) program already provided a "-T utf8" option
to put UTF-8 strings into the database, but that only worked
for input files containing the manually written, mnemonic roff(7)
character escape sequences documented in mandoc_char(7).
Even though mandoc(1), man(1), and man.cgi(8) have been able to
properly handle UTF-8 and ISO-Latin-1 encoded input files for many
years, makewhatis(8) unconditionally replaced all non-ASCII bytes
in all input files with ASCII question marks ("?").

Improve this by changing two aspects of non-ASCII character handling
in makewhatis(8) at the same time.

1. In the makewhatis(8) main program, when configuring the roff(7) parser,
enable UTF-8 and ISO-Latin-1 autorecognition and translation
to \[uXXXX] roff(7) Unicode character escape sequences.
The man(1) and man.cgi(8) programs prove that this option has
been working very reliably for many years, so there is no risk.

2. In the makewhatis(8) string rendering code, if "-T utf8" was
requested, translate these escape sequences to UTF-8 strings,
just like makewhatis(8) already did it for ESCAPE_SPECIAL sequences.
Otherwise, i.e. if an ASCII-only database is desired, replace
all character escape sequences by ASCII transliterations, again
like it was already done for ESCAPE_SPECIAL sequences.

With this change, giving UTF-8 command line arguments to apropos(1)
allows searching in UTF-8 and ISO-Latin-1 encoded manual pages if the
respective mandoc.db(5) has been built with makewhatis(8) -T utf8.

Issue found while investigating a question from
Valid-Amirali-Averiva at rambler dot ru, who is using mandoc
on FreeBSD to process documents containing cyrillic letters.

7 months agooops, fix previous. wrong patch committed. was lacking the final \n
op [Tue, 14 May 2024 13:38:54 +0000 (13:38 +0000)]
oops, fix previous.  wrong patch committed.  was lacking the final \n

7 months agoinclude the filter protocol version in the handshake
op [Tue, 14 May 2024 13:34:05 +0000 (13:34 +0000)]
include the filter protocol version in the handshake

This adds "config|protocol|0.7" during the filters handshake, like
was done for the tables too, so that the filters can know the version
of the protocol right from the start.

ok gilles@

7 months agosync smtpd and protocol version in smtpd-filters(7) examples; ok gilles@
op [Tue, 14 May 2024 13:32:09 +0000 (13:32 +0000)]
sync smtpd and protocol version in smtpd-filters(7) examples; ok gilles@

7 months agoremove no-op methods from table_getpwnam; ok gilles@
op [Tue, 14 May 2024 13:30:37 +0000 (13:30 +0000)]
remove no-op methods from table_getpwnam; ok gilles@

7 months agouse C99 syntax for filling the table_backend structs; ok gilles@
op [Tue, 14 May 2024 13:28:08 +0000 (13:28 +0000)]
use C99 syntax for filling the table_backend structs; ok gilles@

7 months agoAdd missing time.h to tty.c (from Ismail Donmez), also remove some stray
nicm [Tue, 14 May 2024 10:11:09 +0000 (10:11 +0000)]
Add missing time.h to tty.c (from Ismail Donmez), also remove some stray
spaces.

7 months agoSanity check for TSO payload length in TCP chopper.
bluhm [Tue, 14 May 2024 09:39:02 +0000 (09:39 +0000)]
Sanity check for TSO payload length in TCP chopper.

Although it should not happen, check that ph_mss is not 0 in
tcp_chopper().  This could catch errors in the LRO path of network
drivers.  Better count bad packet and drop it rather than ending
in an endless loop.  The new logic is analog to a recent change in
the hardware TSO path in the drivers.

OK jan@

7 months agoRevert part of the change for GitHub issue 3675 because it does not work
nicm [Tue, 14 May 2024 09:32:37 +0000 (09:32 +0000)]
Revert part of the change for GitHub issue 3675 because it does not work
correctly, it was intended to skip lines that are already being searched
as part of a previous wrapped line but in fact is skipping all lines
except the last in wrapped lines.

Also revert the search-wrapped-lines option (I didn't realize it was
intended to work around this).

7 months agoremove prototypes with no matching function
jsg [Tue, 14 May 2024 08:26:13 +0000 (08:26 +0000)]
remove prototypes with no matching function

7 months agoAdd a command-error hook when a command fails, from Hugh Davenport in
nicm [Tue, 14 May 2024 07:52:19 +0000 (07:52 +0000)]
Add a command-error hook when a command fails, from Hugh Davenport in
GitHub issue 3973.

7 months agoAdd an option to disable unwrapping lines for searching, from
nicm [Tue, 14 May 2024 07:40:39 +0000 (07:40 +0000)]
Add an option to disable unwrapping lines for searching, from
meanderingprogrammer at gmail dot com, GitHub issue 3975.

7 months agox509_ext.c: remove unnecessary includes
tb [Tue, 14 May 2024 07:39:43 +0000 (07:39 +0000)]
x509_ext.c: remove unnecessary includes

7 months agox509_ext.c: remove lots of extraneous parentheses
tb [Tue, 14 May 2024 07:35:23 +0000 (07:35 +0000)]
x509_ext.c: remove lots of extraneous parentheses

No change in the generated assembly

7 months agoRestore previous behaviour or writing to stdout if available.
nicm [Tue, 14 May 2024 07:33:01 +0000 (07:33 +0000)]
Restore previous behaviour or writing to stdout if available.

7 months agoFix last sentence of CAVEATS which I got the wrong way around
tb [Tue, 14 May 2024 06:57:10 +0000 (06:57 +0000)]
Fix last sentence of CAVEATS which I got the wrong way around

7 months agoremove unneeded nfs_getreq() prototype
jsg [Tue, 14 May 2024 06:26:05 +0000 (06:26 +0000)]
remove unneeded nfs_getreq() prototype

nfs_getreq() is in nfs_socket.c and not called from nfs_vnops.c

7 months agomake amdgpu_activate() return early when called during hibernate resume
jsg [Tue, 14 May 2024 04:55:42 +0000 (04:55 +0000)]
make amdgpu_activate() return early when called during hibernate resume

Hibernate does DVACT_QUIESCE/DVACT_SUSPEND from hibernate_resume(),
before config_process_deferred_mountroot() calls amdgpu_attachhook().

Without this change the amdgpu_device_prepare() call ends up faulting in
ttm_resource_manager_evict_all() after the
'drm/amd: Evict resources during PM ops prepare() callback'
commit from April.

earlier diff from and ok stsp@
report and bisection from florian@

7 months agoDelete the declaration of cpu_feature which has been unused since
guenther [Tue, 14 May 2024 01:46:24 +0000 (01:46 +0000)]
Delete the declaration of cpu_feature which has been unused since
rev 1.17 (2017-5-27) when tlbflushg() stopped using it

7 months agoInstead of enabling use of PCLMUL and AESNI iff cpu0 supports them
guenther [Tue, 14 May 2024 01:42:07 +0000 (01:42 +0000)]
Instead of enabling use of PCLMUL and AESNI iff cpu0 supports them
via two global variables, make cpu_ecxfeature the intersection of
cpuid(1).ecx on all CPUs and switch cpu_configure() to directly
check that for the requisite flags.

ok kettenis@

7 months agofix a char signedness bug such that this testing code becomes able
schwarze [Tue, 14 May 2024 00:31:48 +0000 (00:31 +0000)]
fix a char signedness bug such that this testing code becomes able
to display the contents of databases containing UTF-8 strings
on signed char architectures:
for example on i386 and amd64, UTF-8 bytes are negative...

7 months agoIgnore button events in the first 10 seconds after resume. On some ACPI
kettenis [Mon, 13 May 2024 19:56:37 +0000 (19:56 +0000)]
Ignore button events in the first 10 seconds after resume.  On some ACPI
implementations pressing the power button to wake up a machine will cause
a power button notification to happen for that button press   This would
initiate a power down, which isn't the user's intent.

Based on earlier diffs from deraadt@ and James Cook.

ok mlarkin@, "I'm not opposed" cheloha@

7 months agoFix memory leak, from Fadi Afani.
nicm [Mon, 13 May 2024 11:45:05 +0000 (11:45 +0000)]
Fix memory leak, from Fadi Afani.

7 months agoAdd bio(4) support to nvme(4). Provide information on controller and configured
krw [Mon, 13 May 2024 11:41:52 +0000 (11:41 +0000)]
Add bio(4) support to nvme(4). Provide information on controller and configured
namespaces via bioctl(8)'s BIOCINQ, BIOCVOL, BIOCDISK requests.

Based on work with dlg@ at h2k23 and many subsequent improvements and tests by
jmatthew@.

ok jmatthew@

7 months agovfs: VOP_REMOVE: move vnode unlocking and ref dropping to FS-indep part
semarie [Mon, 13 May 2024 11:17:40 +0000 (11:17 +0000)]
vfs: VOP_REMOVE: move vnode unlocking and ref dropping to FS-indep part

while here, ensure all vop_remove field are set, and always call the function.

the change is very conservative: it only adds vnode ref drop/unlock where it was
absent because it should be unreachable (and if it wasn't, it should fix
things).

ok miod@

7 months agoImplement hardware masking for MSI and MSI-X on amd64. Note that masking
kettenis [Mon, 13 May 2024 10:01:53 +0000 (10:01 +0000)]
Implement hardware masking for MSI and MSI-X on amd64.  Note that masking
MSIs can only be done for PCI devices that implement per-vector masking,
which a lot of hardware doesn't implement.

ok mlarkin@

7 months agofix some leaks; ok op@
jsg [Mon, 13 May 2024 06:48:26 +0000 (06:48 +0000)]
fix some leaks; ok op@

7 months agoremove unneeded extern and struct; ok patrick@
jsg [Mon, 13 May 2024 01:22:47 +0000 (01:22 +0000)]
remove unneeded extern and struct; ok patrick@

7 months agoremove prototypes with no matching function
jsg [Mon, 13 May 2024 01:15:50 +0000 (01:15 +0000)]
remove prototypes with no matching function
ok mpi@

7 months agoremove some unused defines and externs
jsg [Mon, 13 May 2024 00:16:09 +0000 (00:16 +0000)]
remove some unused defines and externs

isaphysmem and isaphysmempgs were removed in 1998
ok kettenis@

7 months agoAdd support for using the power button function of the RK809.
kettenis [Sun, 12 May 2024 20:02:13 +0000 (20:02 +0000)]
Add support for using the power button function of the RK809.
This initiates a graceful powerdown when the powerbutton is pressed
and makes it work as a wakeup from suspend.

ok patrick@

7 months agoRerun installboot(8) after fw_update(8) to pick up Apple boot firmware
kn [Sun, 12 May 2024 19:47:14 +0000 (19:47 +0000)]
Rerun installboot(8) after fw_update(8) to pick up Apple boot firmware

Firmware is fetched after bootstraps are installed, i.e. on fresh installs
apple-boot is not there yet when installboot ought to place it onto the EFI
System Partition.

Rerun --only on Apple silicon-- to replace Asahi u-boot and boot straight
into ours, nicely visible my different logo.

Input sthen deraadt

7 months agoBe more specific about X509V3_ADD_APPEND and X509V3_ADD_DELETE
tb [Sun, 12 May 2024 17:44:11 +0000 (17:44 +0000)]
Be more specific about X509V3_ADD_APPEND and X509V3_ADD_DELETE

7 months agovfs: reorder tmpfs_fifovops: isolate fifo_vops block
semarie [Sun, 12 May 2024 16:54:56 +0000 (16:54 +0000)]
vfs: reorder tmpfs_fifovops: isolate fifo_vops block

separate the local part from the fifo_vops part, and add a comment to keep in
sync.

ok miod@

7 months agovfs: struct vops: show all members, even if NULL
semarie [Sun, 12 May 2024 16:51:05 +0000 (16:51 +0000)]
vfs: struct vops: show all members, even if NULL

In order to help code maintenance, explicitly add all `struct vops` members with
the current value (if not present, it is NULL), still using the C99 notation.

ok miod@

7 months agoDelete the cpu_perf_e[abd]x and cpu_apmi_edx globals and move the
guenther [Sun, 12 May 2024 16:49:38 +0000 (16:49 +0000)]
Delete the cpu_perf_e[abd]x and cpu_apmi_edx globals and move the
cpuid uses into identifycpu(), as they aren't needed anywhere else.

ok kettenis@

7 months agoTweak wording
tb [Sun, 12 May 2024 15:26:46 +0000 (15:26 +0000)]
Tweak wording

7 months agoRemove a 'built-in' that was left in by accident
tb [Sun, 12 May 2024 15:24:21 +0000 (15:24 +0000)]
Remove a 'built-in' that was left in by accident

7 months agoIntroduce debugging levels, to make debugging a bit more useful.
mglocker [Sun, 12 May 2024 12:20:36 +0000 (12:20 +0000)]
Introduce debugging levels, to make debugging a bit more useful.

7 months agosync
tb [Sun, 12 May 2024 11:52:04 +0000 (11:52 +0000)]
sync

7 months agoInstall X509V3_EXT_get_nid.3
tb [Sun, 12 May 2024 11:50:36 +0000 (11:50 +0000)]
Install X509V3_EXT_get_nid.3

7 months agoAdd minimal manpage documenting the misnamed X509V3_EXT_get_nid()
tb [Sun, 12 May 2024 11:49:47 +0000 (11:49 +0000)]
Add minimal manpage documenting the misnamed X509V3_EXT_get_nid()

This avoids a dangling reference in i2s_ASN1_ENUMERATED_TABLE.
To complete this manual, someone will need to document X509V3_EXT_METHOD,
but that's for a much more rainy day than today.

7 months agovm_page_zero_enable was removed in 2015
jsg [Sun, 12 May 2024 09:41:09 +0000 (09:41 +0000)]
vm_page_zero_enable was removed in 2015

7 months agoremove uvm_swprekeyprint extern for var we never had
jsg [Sun, 12 May 2024 09:27:13 +0000 (09:27 +0000)]
remove uvm_swprekeyprint extern for var we never had

7 months agoremove ufs_hashlock extern for var we never had
jsg [Sun, 12 May 2024 09:19:54 +0000 (09:19 +0000)]
remove ufs_hashlock extern for var we never had

7 months agonfs_procids was removed in 1996
jsg [Sun, 12 May 2024 09:09:39 +0000 (09:09 +0000)]
nfs_procids was removed in 1996

7 months agopcic_isa_intr_list and npcic_isa_intr_list were removed in 1999
jsg [Sun, 12 May 2024 08:49:26 +0000 (08:49 +0000)]
pcic_isa_intr_list and npcic_isa_intr_list were removed in 1999

7 months agortw_host_rfio was removed in 2007
jsg [Sun, 12 May 2024 08:44:09 +0000 (08:44 +0000)]
rtw_host_rfio was removed in 2007

7 months agocomsiraddr was removed in 2016
jsg [Sun, 12 May 2024 08:42:13 +0000 (08:42 +0000)]
comsiraddr was removed in 2016

7 months agosync_ifp and ticket_pabuf don't exist, remove externs
jsg [Sun, 12 May 2024 08:31:05 +0000 (08:31 +0000)]
sync_ifp and ticket_pabuf don't exist, remove externs

7 months agottybuf[] was removed in 2001, ttydefaults in 1988
jsg [Sun, 12 May 2024 08:21:56 +0000 (08:21 +0000)]
ttybuf[] was removed in 2001, ttydefaults in 1988

7 months agodefaul -> default; ok jmc@ ratchov@
jsg [Sun, 12 May 2024 06:24:44 +0000 (06:24 +0000)]
defaul -> default; ok jmc@ ratchov@

7 months agoAvoid .Xr to no longer public X509_LOOKUP_by_subject(3)
tb [Sun, 12 May 2024 05:08:59 +0000 (05:08 +0000)]
Avoid .Xr to no longer public X509_LOOKUP_by_subject(3)

looks good to jmc

7 months agosync the cpu(4) pages for i386/amd64:
jmc [Sat, 11 May 2024 20:35:13 +0000 (20:35 +0000)]
sync the cpu(4) pages for i386/amd64:

- remove section headers. in a document little over one screenful in size,
three section headers within DESCRIPTION seems greedy
- mark up sysctl names
- use the more general hw.sensors sysctl name to show cpu temp. the previously
suggested hw.sensors.cpu*.temp0 is no longer universal

7 months agoUse %b to format cpu flag info in dmesg, so we have the raw values
guenther [Sat, 11 May 2024 19:21:47 +0000 (19:21 +0000)]
Use %b to format cpu flag info in dmesg, so we have the raw values
too.  This is also much more space efficient.
Reduce the cpu flag noise in dmesg by suppressing lines and registers
that are identical with the previous CPU and show -/+ info if there
are any differences.

particular feedback from deraadt@, kettenis@, jsg@, and dv@
ok deraadt@

7 months agoMove X509V3_add_standard_extensions out of the way
tb [Sat, 11 May 2024 18:59:39 +0000 (18:59 +0000)]
Move X509V3_add_standard_extensions out of the way

This function is only used by OpenLDAP and it's been a noop since
forever. It has no business to be squeezed in between a number of
other, quite unrelated functions. It's distracting.

7 months agoMake two NULL checks more explicit
tb [Sat, 11 May 2024 18:52:52 +0000 (18:52 +0000)]
Make two NULL checks more explicit

7 months agoUnwrap a line
tb [Sat, 11 May 2024 18:48:47 +0000 (18:48 +0000)]
Unwrap a line

7 months agofix prototype; iosf_i2c_relese -> iosf_i2c_release
jsg [Sat, 11 May 2024 14:49:56 +0000 (14:49 +0000)]
fix prototype; iosf_i2c_relese -> iosf_i2c_release

7 months agoSync DSA_METHOD documentation with reality
tb [Sat, 11 May 2024 06:53:19 +0000 (06:53 +0000)]
Sync DSA_METHOD documentation with reality

It is dubious whether this opaque struct's internals should be documented
in the first place. This also has been incomplete since forever. For now
zap the stuff that no longer exists and make an attempt at matching KNF a
bit more closely.

7 months agoRemove unused DSA methods
tb [Sat, 11 May 2024 06:43:50 +0000 (06:43 +0000)]
Remove unused DSA methods

There are no accessors to set them, so this has been involved in a bunch
of dead logic ever since we made DSA opaque a few years ago.

ok jsing

7 months agoRemove unused PEM_USER and PEM_CTX
tb [Sat, 11 May 2024 05:41:28 +0000 (05:41 +0000)]
Remove unused PEM_USER and PEM_CTX

I could not find any use of this in all of OpenSSL's git history since
SSLeay 0.8.1b.

ok jsing

7 months agoRevert r1.108. An Intel 11th Gen i5 Framework laptop with a SanDisk SN850 disk
krw [Fri, 10 May 2024 21:23:32 +0000 (21:23 +0000)]
Revert r1.108. An Intel 11th Gen i5 Framework laptop with a SanDisk SN850 disk
found a way to prevent the kernel from enabling the nvme controller while
resuming.

Fixes resuming on the Framework13.

Problem reported and reversion tested by ian@

7 months agopax: make list file handle line-buffered unless it is stderr.
millert [Fri, 10 May 2024 20:28:31 +0000 (20:28 +0000)]
pax: make list file handle line-buffered unless it is stderr.
This fixes a problem where the file list output was fully-buffered
when used as part of a pipeline.  With this change, files are listed
as they are extracted in verbose mode.  OK deraadt@ guenther@

7 months agoKeep probing upstream servers.
florian [Fri, 10 May 2024 15:02:26 +0000 (15:02 +0000)]
Keep probing upstream servers.

(lib)unbound might mark many servers down in case of a network issue.
This is something that can easily happen for unwind(8).

Problem pointed out by Kirill A. Korinsky in unbound(8).
https://github.com/NLnetLabs/unbound/issues/362

OK sthen

7 months agoMake the kernel compile also when turning on debugging.
mglocker [Fri, 10 May 2024 10:49:10 +0000 (10:49 +0000)]
Make the kernel compile also when turning on debugging.

ok mpi@

7 months agoRegen
claudio [Fri, 10 May 2024 09:21:41 +0000 (09:21 +0000)]
Regen

7 months agoThe ptsignal() race against p_sigmask changes by dosigsuspend() are fixed.
claudio [Fri, 10 May 2024 09:21:01 +0000 (09:21 +0000)]
The ptsignal() race against p_sigmask changes by dosigsuspend() are fixed.
Unlock sigsuspend() and __thrsigdivert() again.

7 months agoCorrect display the details of COMMAND using the ps command from the kernel
asou [Fri, 10 May 2024 06:46:14 +0000 (06:46 +0000)]
Correct display the details of COMMAND using the ps command from the kernel
crash dump.

OK millert@

7 months agoFix broken debugging.
mglocker [Fri, 10 May 2024 06:14:10 +0000 (06:14 +0000)]
Fix broken debugging.

7 months agoAdd missing EC_KEY_free()
tb [Fri, 10 May 2024 05:12:03 +0000 (05:12 +0000)]
Add missing EC_KEY_free()

While eckey_from_explicit_params() frees *out_eckey, eckey_from_object()
and eckey_from_params() do not. These functions are currently all callled
with a NULL *out_eckey, but the latter two would leak if that should ever
change.

ok jsing

7 months agoRemove fixed nonce length information from algorithm2
tb [Fri, 10 May 2024 05:08:05 +0000 (05:08 +0000)]
Remove fixed nonce length information from algorithm2

This information has been part of tls12_key_block_generate() for a while
now. It remained in this table because at that point SSL_CIPHER was still
public. Nothing can access algorithm2 anymore from the outside, so this is
dead weight.

ok jsing

7 months agoInline dsa_builtin_keygen() in DSA_generate_key()
tb [Fri, 10 May 2024 04:53:55 +0000 (04:53 +0000)]
Inline dsa_builtin_keygen() in DSA_generate_key()

ok djm

7 months agomake pf_match_rule() prototype match the function
jsg [Fri, 10 May 2024 03:50:12 +0000 (03:50 +0000)]
make pf_match_rule() prototype match the function

7 months agoMake the openssl_dsa_meth static const
tb [Thu, 9 May 2024 20:57:49 +0000 (20:57 +0000)]
Make the openssl_dsa_meth static const

7 months agoMove openssl_dsa_meth below the methods it uses
tb [Thu, 9 May 2024 20:56:52 +0000 (20:56 +0000)]
Move openssl_dsa_meth below the methods it uses

no functional change

7 months agoMake the DH_METHOD static const
tb [Thu, 9 May 2024 20:43:36 +0000 (20:43 +0000)]
Make the DH_METHOD static const

7 months agoMove public API and DH_METHOD to the bottom of the file
tb [Thu, 9 May 2024 20:40:42 +0000 (20:40 +0000)]
Move public API and DH_METHOD to the bottom of the file

no functional change

7 months agosync the SSL text; ok tb
jmc [Thu, 9 May 2024 17:57:36 +0000 (17:57 +0000)]
sync the SSL text; ok tb

7 months ago- drop ref to non-installed g++(1) page
jmc [Thu, 9 May 2024 17:22:20 +0000 (17:22 +0000)]
- drop ref to non-installed g++(1) page
- drop ref to clang that isn;t particularly helpful and only relevant
to some platforms, as suggested by kettenis

7 months agoEnable ufshci(4) on amd64.
mglocker [Thu, 9 May 2024 17:05:22 +0000 (17:05 +0000)]
Enable ufshci(4) on amd64.

ok kettenis@ deraadt@

7 months agoTiny style tweaks in X509_REQ_add_extension_nid()
tb [Thu, 9 May 2024 14:29:08 +0000 (14:29 +0000)]
Tiny style tweaks in X509_REQ_add_extension_nid()

Test & assign and use ret instead of rv.

ok jsing

7 months agoStreamline X509_REQ_check_private_key() a bit
tb [Thu, 9 May 2024 14:27:21 +0000 (14:27 +0000)]
Streamline X509_REQ_check_private_key() a bit

Use better variable names, split the success from the error path and
return directly rather than using an ok variable.

ok jsing

7 months agoZap some extra parentheses in X509_REQ_get_pubkey()
tb [Thu, 9 May 2024 14:22:16 +0000 (14:22 +0000)]
Zap some extra parentheses in X509_REQ_get_pubkey()

ok jsing

7 months agoClean up X509_to_X509_REQ()
tb [Thu, 9 May 2024 14:20:57 +0000 (14:20 +0000)]
Clean up X509_to_X509_REQ()

Use better variable names. X509_REQ_new() sets the version to the only
specified version, so there is no point to set it. Extract the subject
name, then assign to make it more obvious that we error happens if the
cert has a missing subject. Switch to X509_get0_pubkey() to avoid some
strange dance with a strangely named variable to adjust the refcount.

ok jsing

7 months agoFurther simplify X509_REQ_get_extensions()
tb [Thu, 9 May 2024 14:00:52 +0000 (14:00 +0000)]
Further simplify X509_REQ_get_extensions()

Instead of inlining a poor version of ASN1_TYPE_unpack_sequence() with
missing error checks, just call the real thing. It's safer and simpler.

ok jsing

7 months agosimplify exit message handling, which was more complicated than
djm [Thu, 9 May 2024 09:46:47 +0000 (09:46 +0000)]
simplify exit message handling, which was more complicated than
it needed to be because of unexpunged ssh1 remnants. ok markus@

7 months agoctime(3) and ctime_r(3) can fail when timestamps are way off.
florian [Thu, 9 May 2024 08:35:40 +0000 (08:35 +0000)]
ctime(3) and ctime_r(3) can fail when timestamps are way off.
Add missing error checks to all calls under sbin/

Input kettenis, millert
OK millert

7 months agoctime(3) and ctime_r(3) can fail when timestamps are way off.
florian [Thu, 9 May 2024 08:35:03 +0000 (08:35 +0000)]
ctime(3) and ctime_r(3) can fail when timestamps are way off.
Add missing error checks to all calls under libexec/

Input kettenis, millert
OK millert

7 months agoBack then I faced intermittent file-system corruptions for which setting
mglocker [Thu, 9 May 2024 08:24:09 +0000 (08:24 +0000)]
Back then I faced intermittent file-system corruptions for which setting
FUA (Force Unit Access) did help.  In the meantime it turned out that
those file-system corruptions were most likely caused by the slot issues.
Now that we fixed the slot management and limited to one slot for now,
remove FUA again, which increases the write performance significantly.

7 months agoSprinkle some more DPRINTFs.
mglocker [Thu, 9 May 2024 08:21:52 +0000 (08:21 +0000)]
Sprinkle some more DPRINTFs.

7 months agoPack hardware descriptor structures.
mglocker [Thu, 9 May 2024 08:20:22 +0000 (08:20 +0000)]
Pack hardware descriptor structures.

7 months agoParse the OCS response value for completed commands, and set error on
mglocker [Thu, 9 May 2024 08:18:20 +0000 (08:18 +0000)]
Parse the OCS response value for completed commands, and set error on
failure.

7 months agoPerform bus DMA synchronization to update the command descriptors.
mglocker [Thu, 9 May 2024 08:16:32 +0000 (08:16 +0000)]
Perform bus DMA synchronization to update the command descriptors.

7 months agoUse 1U for bit operations on 32-bit registers.
mglocker [Thu, 9 May 2024 08:13:57 +0000 (08:13 +0000)]
Use 1U for bit operations on 32-bit registers.

Proposed by dlg@

7 months agoDon't do math on KVA to get the required slot offset since that could
mglocker [Thu, 9 May 2024 08:12:22 +0000 (08:12 +0000)]
Don't do math on KVA to get the required slot offset since that could
cause invalid pointers depending on the compiler interpretation of
(void *).  Instead work with the structure pointer itself.

Proposed by dlg@

7 months agoDon't use the task id for UPIU commands. We don't use task management
mglocker [Thu, 9 May 2024 08:09:17 +0000 (08:09 +0000)]
Don't use the task id for UPIU commands.  We don't use task management
commands yet.

7 months agoDon't schedule interrupt aggregation when commands are still in-progress.
mglocker [Thu, 9 May 2024 08:06:42 +0000 (08:06 +0000)]
Don't schedule interrupt aggregation when commands are still in-progress.
As of the documentation:

"NOTE Write operations to IACTH and IATOVAL are only allowed when no
commands are outstanding."

Instead we only schedule interrupt aggregation at the start of the
SCSI command call, when all commands have completed.