openbsd
15 months agoMove KDF handling to ECDH_compute_key()
tb [Fri, 28 Jul 2023 09:28:37 +0000 (09:28 +0000)]
Move KDF handling to ECDH_compute_key()

In OpenSSL e2285d87, the KDF handling was moved from the compute_key()
method into the public API. A consequence of this change is that the
ECDH_compute_key() API no longer returns -1 for some errors. Existing
checks for <= 0 are safe as are those checking for the exact length as
return value, which is all what the ecosystem seems to be doing.

ok jsing

15 months agoMerge ecdh.h into ec.h
tb [Fri, 28 Jul 2023 09:25:12 +0000 (09:25 +0000)]
Merge ecdh.h into ec.h

The remaining two ECDH interfaces are relocated into ec.h. ecdh.h
remains. It does nothing but include ec.h.

ok jsing

15 months agoExcise ECDH_METHOD
tb [Fri, 28 Jul 2023 09:22:26 +0000 (09:22 +0000)]
Excise ECDH_METHOD

Unlike ECDSA_METHOD, this has been unused forever but kind of needed to
stay for symmetry with ECDSA_METHOD. Now we can finally take it behind
the barn and remove its tendrils into ENGINE.

ok jsing

15 months agoRemove ECDH errors
tb [Fri, 28 Jul 2023 09:19:58 +0000 (09:19 +0000)]
Remove ECDH errors

Much like the ECDSA errors, the ECDH errors have been unused for a
while. Garbage collect them.

ok jsing

15 months agoRemove some unneeded includes from ecdsa.h
tb [Fri, 28 Jul 2023 09:18:10 +0000 (09:18 +0000)]
Remove some unneeded includes from ecdsa.h

15 months agoMerge ecdsa.h into ec.h
tb [Fri, 28 Jul 2023 09:16:17 +0000 (09:16 +0000)]
Merge ecdsa.h into ec.h

Move the remaining ECDSA API into ec.h to match OpenSSL 1.1's interface
better.  In particular, the EC_KEY sign and verify method accessors are
moved to the right header. Whether the rest of the ECDSA stuff belongs
there is debatable, but that was upstream's choice.

ok jsing

15 months agoRemove ECDSA_METHOD
tb [Fri, 28 Jul 2023 09:08:31 +0000 (09:08 +0000)]
Remove ECDSA_METHOD

After smtpd (in base) and libtls finally switched from ECDSA_METHOD to
EC_KEY_METHOD, much of the ECDSA_METHOD code was neutered. Remove the
remaining public API as well as numerous tentacles into ENGINE.

ok jsing

15 months agoRemove ecs_err.c
tb [Fri, 28 Jul 2023 09:01:25 +0000 (09:01 +0000)]
Remove ecs_err.c

These error codes have been unused for a while, so the public API loading
them is pointless.

ok jsing

15 months agoPlace public ECDSA API next to the internal methods
tb [Fri, 28 Jul 2023 08:57:46 +0000 (08:57 +0000)]
Place public ECDSA API next to the internal methods

It is hard to remember that ECDSA_do_{sign,verify}() call ecdsa_sign_sig().
Especially since the distinction to ECDSA_{sign,verify}() isn't clear from
the names. To add to the confusion, the public API is ordered differently
than the methods they call. So in this case it seems tidier to place the
public API next to the methods.

ok jsing

15 months agoRemove ECDSA_{do_,}sign_ex()
tb [Fri, 28 Jul 2023 08:54:41 +0000 (08:54 +0000)]
Remove ECDSA_{do_,}sign_ex()

There is no reason to keep these. It is cleaner to keep ECDSA_sign_setup()
but remove the logic for passed-in kinv and r.

Refuse to cooperate as far as possible. Someone could still implement
their own versions of ECDSA_{do_,}_sign_ex() and ECDSA_sign_setup() by
leveraging EC_KEY_METHOD_get_sign() and building their own wrappers.
We can't make such an implementation of ECDSA_sign_setup() fail, but we
make the actual signing fail since we no longer "do the right thing".

ok jsing

15 months agoMake extended ECDSA signing routines internal
tb [Fri, 28 Jul 2023 08:49:43 +0000 (08:49 +0000)]
Make extended ECDSA signing routines internal

ECDSA_sign_setup() permits precomputing the values of the inverse of the
random k and the corresponding r. These can then be fed into the signing
routines ECDSA_{do_,}sign_ex() multiple times if needed. This is not a
great idea and the interface adds a lot of unwanted complexity.

Not to mention that nothing ever used this correctly - if s works out to
0, a special error code is thrown requesting that the caller provide new
kinv and r values. Unsurprisingly, nobody ever checked for that special
error code.

ok jsing

This commit marks the start of a libcrypto major bump. Do not build the
tree until I bumped the shlib_version and synced file sets (in about 35
commits).

15 months agoUse ibuf_data() instead of accessing the ibuf buf pointer directly.
claudio [Fri, 28 Jul 2023 07:31:38 +0000 (07:31 +0000)]
Use ibuf_data() instead of accessing the ibuf buf pointer directly.
Also convert some ibuf_add(() calls to ibuf_add_buf() where appropriate.
OK tobhe@ tb@

15 months agoRevert "drm/amd/display: edp do not add non-edid timings"
jsg [Fri, 28 Jul 2023 07:10:26 +0000 (07:10 +0000)]
Revert "drm/amd/display: edp do not add non-edid timings"

From Hersen Wu
1d4607f2a50c749e47a4b80030733cbf77c5570a in linux-6.1.y/6.1.42
d6149086b45e150c170beaa4546495fd1880724c in mainline linux

15 months agodrm/amd/display: Add polling method to handle MST reply packet
jsg [Fri, 28 Jul 2023 07:08:10 +0000 (07:08 +0000)]
drm/amd/display: Add polling method to handle MST reply packet

From Wayne Lin
2f2ba3c16230e1de649a877e5819673c849ca0f2 in linux-6.1.y/6.1.42
4f6d9e38c4d244ad106eb9ebd8c0e1215e866f35 in mainline linux

15 months agodrm/amd/display: fix linux dp link lost handled only one time
jsg [Fri, 28 Jul 2023 07:05:07 +0000 (07:05 +0000)]
drm/amd/display: fix linux dp link lost handled only one time

From Hersen Wu
78ea2ed76ce94f090d2a9c36b1b58f79ce3b93b8 in linux-6.1.y/6.1.42
e322843e5e33e72ff218d661f3d15ff9c9f2f1b5 in mainline linux

15 months agodrm/amd/display: Clean up errors & warnings in amdgpu_dm.c
jsg [Fri, 28 Jul 2023 07:02:47 +0000 (07:02 +0000)]
drm/amd/display: Clean up errors & warnings in amdgpu_dm.c

From Srinivasan Shanmugam
b31143b0fbbd7bae05905f838bb7f8c07eb86662 in linux-6.1.y/6.1.42
87279fdf5ee0ad1360765ef70389d1c4d0f81bb6 in mainline linux

15 months agodrm/amd/display: force connector state when bpc changes during compliance
jsg [Fri, 28 Jul 2023 07:00:27 +0000 (07:00 +0000)]
drm/amd/display: force connector state when bpc changes during compliance

From Qingqing Zhuo
c14702daf1f5969e1dead51eff596f776007434d in linux-6.1.y/6.1.42
028c4ccfb8127255d60f8d9edde96cacf2958082 in mainline linux

15 months agodrm/dp_mst: Clear MSG_RDY flag before sending new message
jsg [Fri, 28 Jul 2023 06:56:32 +0000 (06:56 +0000)]
drm/dp_mst: Clear MSG_RDY flag before sending new message

From Wayne Lin
00f68f5c1be12828a6f0b1e0f1017e1399b23a73 in linux-6.1.y/6.1.42
72f1de49ffb90b29748284f27f1d6b829ab1de95 in mainline linux

15 months agodrm/amd/display: fix some coding style issues
jsg [Fri, 28 Jul 2023 06:52:04 +0000 (06:52 +0000)]
drm/amd/display: fix some coding style issues

From Srinivasan Shanmugam
c085ffaf67db1ba48b733bc7fe4d7f5be9b77e2b in linux-6.1.y/6.1.42
ae67558be712237109100fd14f12378adcf24356 in mainline linux

15 months agodrm/amd/display: use max_dsc_bpp in amdgpu_dm
jsg [Fri, 28 Jul 2023 06:50:28 +0000 (06:50 +0000)]
drm/amd/display: use max_dsc_bpp in amdgpu_dm

From Hamza Mahfooz
374735cbe2f17dd80829adba5d0b764e9246341a in linux-6.1.y/6.1.42
6e5abe94c6eb9b281398e39819217e8fdd1c336f in mainline linux

15 months agodrm/ttm: fix bulk_move corruption when adding a entry
jsg [Fri, 28 Jul 2023 06:48:41 +0000 (06:48 +0000)]
drm/ttm: fix bulk_move corruption when adding a entry

From Yunxiang Li
70a3015683b007a0db4a1e858791b69afd45fc83 in linux-6.1.y/6.1.42
4481913607e58196c48a4fef5e6f45350684ec3c in mainline linux

15 months agodrm/radeon: Fix integer overflow in radeon_cs_parser_init
jsg [Fri, 28 Jul 2023 06:47:10 +0000 (06:47 +0000)]
drm/radeon: Fix integer overflow in radeon_cs_parser_init

From hackyzh002
2e1be420b86980c25a75325e90dfc3fc73126f61 in linux-6.1.y/6.1.42
f828b681d0cd566f86351c0b913e6cb6ed8c7b9c in mainline linux

15 months agodrm/amd/display: Keep PHY active for DP displays on DCN31
jsg [Fri, 28 Jul 2023 06:45:27 +0000 (06:45 +0000)]
drm/amd/display: Keep PHY active for DP displays on DCN31

From Nicholas Kazlauskas
b9741ba942f3f2c36de96241dfaf2dbbd3b5c826 in linux-6.1.y/6.1.42
2387ccf43e3c6cb5dbd757c5ef410cca9f14b971 in mainline linux

15 months agodrm/amd/display: check TG is non-null before checking if enabled
jsg [Fri, 28 Jul 2023 06:43:33 +0000 (06:43 +0000)]
drm/amd/display: check TG is non-null before checking if enabled

From Taimur Hassan
889bac5fd7969b745c0554155852ce1e3c140497 in linux-6.1.y/6.1.42
5a25cefc0920088bb9afafeb80ad3dcd84fe278b in mainline linux

15 months agodrm/amd/display: Disable MPC split by default on special asic
jsg [Fri, 28 Jul 2023 06:41:36 +0000 (06:41 +0000)]
drm/amd/display: Disable MPC split by default on special asic

From Zhikai Zhai
9f28e8c2be1e1a8077f139121b01d139cb60b4b5 in linux-6.1.y/6.1.42
a460beefe77d780ac48f19d39333852a7f93ffc1 in mainline linux

15 months agodrm/amd/display: only accept async flips for fast updates
jsg [Fri, 28 Jul 2023 06:39:54 +0000 (06:39 +0000)]
drm/amd/display: only accept async flips for fast updates

From Simon Ser
4385420741743247a7bdedb5c0b1eb5efe9a9edd in linux-6.1.y/6.1.42
1ca67aba8d11c2849d395013e1fdce02918d5657 in mainline linux

15 months agodrm/client: Fix memory leak in drm_client_modeset_probe
jsg [Fri, 28 Jul 2023 06:37:37 +0000 (06:37 +0000)]
drm/client: Fix memory leak in drm_client_modeset_probe

From Jocelyn Falempe
917bef37cfaca07781c6fbaf6cd9404d27e64e6f in linux-6.1.y/6.1.42
2329cc7a101af1a844fbf706c0724c0baea38365 in mainline linux

15 months agoInclude a newline in a DPRINTF()
guenther [Fri, 28 Jul 2023 06:36:16 +0000 (06:36 +0000)]
Include a newline in a DPRINTF()

15 months agodrm/client: Fix memory leak in drm_client_target_cloned
jsg [Fri, 28 Jul 2023 06:35:45 +0000 (06:35 +0000)]
drm/client: Fix memory leak in drm_client_target_cloned

From Jocelyn Falempe
b5359d7a5087ac398fc429da6833133b4784c268 in linux-6.1.y/6.1.42
c2a88e8bdf5f6239948d75283d0ae7e0c7945b03 in mainline linux

15 months agodrm/amdgpu/pm: make mclk consistent for smu 13.0.7
jsg [Fri, 28 Jul 2023 06:33:27 +0000 (06:33 +0000)]
drm/amdgpu/pm: make mclk consistent for smu 13.0.7

From Alex Deucher
91bd7acf89cbc118e8d5e01947e59f7928e26893 in linux-6.1.y/6.1.42
068c8bb10f37bb84824625dbbda053a3a3e0d6e1 in mainline linux

15 months agodrm/amdgpu/pm: make gfxclock consistent for sienna cichlid
jsg [Fri, 28 Jul 2023 06:32:14 +0000 (06:32 +0000)]
drm/amdgpu/pm: make gfxclock consistent for sienna cichlid

From Alex Deucher
0b4f3d9a5c8a21486f806fa6583a6a21e3922bab in linux-6.1.y/6.1.42
a4eb11824170d742531998f4ebd1c6a18b63db47 in mainline linux

15 months agodma-buf/dma-resv: Stop leaking on krealloc() failure
jsg [Fri, 28 Jul 2023 06:30:13 +0000 (06:30 +0000)]
dma-buf/dma-resv: Stop leaking on krealloc() failure

From Ville Syrjala
19e7b9f1f7e1cb92a4cc53b4c064f7fb4b1f1983 in linux-6.1.y/6.1.42
05abb3be91d8788328231ee02973ab3d47f5e3d2 in mainline linux

15 months agoAdd CODEPATCH_CODE() macro to simplify defining a symbol for a chunk
guenther [Fri, 28 Jul 2023 06:18:35 +0000 (06:18 +0000)]
Add CODEPATCH_CODE() macro to simplify defining a symbol for a chunk
of code to use in codepatching.  Use that for all the existing
codepatching snippets.

Similarly, add CODEPATCH_CODE_LEN() which is CODEPATCH_CODE() but also
provides a short variable holding the length of the codepatch snippet.
Use that for some snippets that will be used for retpoline replacement.

ok kettenis@ deraadt@

15 months agoRemove ASN1_BIT_STRING_set doco
tb [Fri, 28 Jul 2023 05:53:10 +0000 (05:53 +0000)]
Remove ASN1_BIT_STRING_set doco

15 months agoRemove stale .Xr missed in previous
tb [Fri, 28 Jul 2023 05:49:53 +0000 (05:49 +0000)]
Remove stale .Xr missed in previous

15 months agosync
tb [Fri, 28 Jul 2023 05:48:54 +0000 (05:48 +0000)]
sync

15 months agoRemove ASN1_BIT_STRING_num_asc.3
tb [Fri, 28 Jul 2023 05:48:33 +0000 (05:48 +0000)]
Remove ASN1_BIT_STRING_num_asc.3

15 months ago%C is a callable macro in mdoc(7) so, as we do for %D, escape it;
jmc [Fri, 28 Jul 2023 05:42:36 +0000 (05:42 +0000)]
%C is a callable macro in mdoc(7) so, as we do for %D, escape it;

15 months agodon't need to start a command here; use ssh -N instead.
djm [Fri, 28 Jul 2023 05:33:15 +0000 (05:33 +0000)]
don't need to start a command here; use ssh -N instead.
Fixes failure on cygwin spotted by Darren

15 months agoFix off-by-one: SEFF0ECX_WAITPKG is bit 5, not bit 4.
jsg [Fri, 28 Jul 2023 03:06:46 +0000 (03:06 +0000)]
Fix off-by-one: SEFF0ECX_WAITPKG is bit 5, not bit 4.

from guenther@ in amd64

15 months agodon't incorrectly truncate logged strings retrieved from PKCS#11
djm [Thu, 27 Jul 2023 22:26:49 +0000 (22:26 +0000)]
don't incorrectly truncate logged strings retrieved from PKCS#11
modules; based on GHPR406 by Jakub Jelen; ok markus

15 months agomake sshd_config AuthorizedPrincipalsCommand and AuthorizedKeysCommand
djm [Thu, 27 Jul 2023 22:25:17 +0000 (22:25 +0000)]
make sshd_config AuthorizedPrincipalsCommand and AuthorizedKeysCommand
accept the %D (routing domain) and a new %C (connection address/port
4-tuple) as expansion sequences; ok markus

15 months agoincrease default KDF work-factor for OpenSSH format private keys from
djm [Thu, 27 Jul 2023 22:23:05 +0000 (22:23 +0000)]
increase default KDF work-factor for OpenSSH format private keys from
16 to 24; { feedback ok } x { deraadt markus }

15 months agoFix routing message size check in route_output(). `rtm_hdrlen' type is
mvs [Thu, 27 Jul 2023 22:20:51 +0000 (22:20 +0000)]
Fix routing message size check in route_output(). `rtm_hdrlen' type is
u_short, so add sizeof(rtm->rtm_hdrlen) instead of 1 to its offset
within rt_msghdr structure.

ok claudio

15 months agoFix inline vlan-tag handling of forwarded LRO packets from ix(4)
jan [Thu, 27 Jul 2023 20:21:25 +0000 (20:21 +0000)]
Fix inline vlan-tag handling of forwarded LRO packets from ix(4)

Implement vlan-tag parsing ether_extract_header() to use this information
to adjust the MSS calculation of LRO packets.

pointed out by mbuhl and bluhm

with tweaks from bluhm

ok bluhm@

15 months agoMake _eprol (and _etext) hidden. Fixes "cc -pg" on arm64 where the
kettenis [Thu, 27 Jul 2023 18:17:14 +0000 (18:17 +0000)]
Make _eprol (and _etext) hidden.  Fixes "cc -pg" on arm64 where the
current code which has a local _eprol label in the inline asm and a
global _eprol declaration results in an incorrect relocation.  This
also removes an unnecessary relocation on hppa (and possible on
other architectures as well).

ok guenther@

15 months agosched_init_cpu: move profclock staggering to clockintr_cpu_init()
cheloha [Thu, 27 Jul 2023 17:52:53 +0000 (17:52 +0000)]
sched_init_cpu: move profclock staggering to clockintr_cpu_init()

initclocks() runs after sched_init_cpu() is called for secondary CPUs,
so profclock_period is still zero and the clockintr_stagger() call for
spc_profclock is useless.  For now, just stagger spc_profclock during
clockintr_cpu_init() along with everything else.

15 months agoFix off-by-one: SEFF0ECX_WAITPKG is bit 5, not bit 4.
guenther [Thu, 27 Jul 2023 16:33:56 +0000 (16:33 +0000)]
Fix off-by-one: SEFF0ECX_WAITPKG is bit 5, not bit 4.

ok mlarkin@ kettenis@ deraadt@

15 months agovmd(8): fix verbose logging in child processes.
dv [Thu, 27 Jul 2023 09:27:43 +0000 (09:27 +0000)]
vmd(8): fix verbose logging in child processes.

The introduction of exec for vm's and fork+exec for virtio block
and network devices missed passing the log verbosity in argv. Add
the "-v" arguments based on current vverbosity at time of exec.

ok brynet@, mlarkin@

15 months agoPrepare the ssltest for the upcoming bump
tb [Thu, 27 Jul 2023 07:08:09 +0000 (07:08 +0000)]
Prepare the ssltest for the upcoming bump

This is a hack. The test is in rather poor shape and it is hard to tell
whether it still does what it is supposed to be doing. Hopefully somemone
will rewrite this in a style that doesn't make me squeal on opening this
file...

15 months agoRemove antiquated options output
tb [Thu, 27 Jul 2023 07:01:50 +0000 (07:01 +0000)]
Remove antiquated options output

This is uninteresting and rather meaningless except for the implementer.
No need to have several hundred lines of code backing half a dozen symbols
in the public API for this.

ok jsing

15 months agoAnnotate bogus output as incorrect
tb [Thu, 27 Jul 2023 06:41:39 +0000 (06:41 +0000)]
Annotate bogus output as incorrect

Some people already have way too many simple and not too important diffs in
their inbox. This isn't worth kicking something more important out of the
queue.

15 months agoFix two mandoc -Tlint warnings left in previous
tb [Thu, 27 Jul 2023 06:20:45 +0000 (06:20 +0000)]
Fix two mandoc -Tlint warnings left in previous

15 months agoFix typo
tb [Thu, 27 Jul 2023 05:31:28 +0000 (05:31 +0000)]
Fix typo

15 months agoReport speculation control bits in dmesg cpu lines.
guenther [Thu, 27 Jul 2023 01:51:35 +0000 (01:51 +0000)]
Report speculation control bits in dmesg cpu lines.

ok mlarkin@

15 months agoThe interrupt resume (Xdoreti) and recurse (Xspllower) paths are
guenther [Thu, 27 Jul 2023 00:30:07 +0000 (00:30 +0000)]
The interrupt resume (Xdoreti) and recurse (Xspllower) paths are
invoked using indirect branches and should have endbr64's.

ok deraadt@

15 months agoFollow the lead of mips64 and make cpu_idle_cycle() just call the
guenther [Thu, 27 Jul 2023 00:28:24 +0000 (00:28 +0000)]
Follow the lead of mips64 and make cpu_idle_cycle() just call the
indirect pointer itself and provide an initializer for that going
to the default "just enable interrupts and halt" path.

ok kettenis@

15 months agomake ssh -f (fork after authentication) work properly in multiplexed
djm [Wed, 26 Jul 2023 23:06:00 +0000 (23:06 +0000)]
make ssh -f (fork after authentication) work properly in multiplexed
cases (inc. ControlPersist). bz3589 bz3589
Based on patches by Peter Chubb; ok dtucker@

15 months agoPrepare this test for the upcoming bump
tb [Wed, 26 Jul 2023 22:51:01 +0000 (22:51 +0000)]
Prepare this test for the upcoming bump

15 months agoRemove comment containing an outdated path
tb [Wed, 26 Jul 2023 22:46:06 +0000 (22:46 +0000)]
Remove comment containing an outdated path

15 months agorevert previous: dlg tells me it's incorrect
jmc [Wed, 26 Jul 2023 20:23:22 +0000 (20:23 +0000)]
revert previous: dlg tells me it's incorrect

15 months agoRemove ERR_get_{err_state,string}_table documentation
tb [Wed, 26 Jul 2023 20:15:51 +0000 (20:15 +0000)]
Remove ERR_get_{err_state,string}_table documentation

15 months agoRemove BUF_reverse and BUF_strdup documentation
tb [Wed, 26 Jul 2023 20:12:45 +0000 (20:12 +0000)]
Remove BUF_reverse and BUF_strdup documentation

15 months agosync
tb [Wed, 26 Jul 2023 20:09:25 +0000 (20:09 +0000)]
sync

15 months agoBN_BLINDING will be made internal-only. Remove its documentation
tb [Wed, 26 Jul 2023 20:08:59 +0000 (20:08 +0000)]
BN_BLINDING will be made internal-only. Remove its documentation

15 months agosync
tb [Wed, 26 Jul 2023 20:01:51 +0000 (20:01 +0000)]
sync

15 months agoBIO_f_asn1 and the prefix/suffix API will be removed
tb [Wed, 26 Jul 2023 20:01:04 +0000 (20:01 +0000)]
BIO_f_asn1 and the prefix/suffix API will be removed

Remove their documentation and mark some associated constants as
intentionally undocumented until they will be removed from public
headers.

15 months agoDocument CMS_SignerInfos_get_version and CMS_get_version which will
tb [Wed, 26 Jul 2023 19:30:43 +0000 (19:30 +0000)]
Document CMS_SignerInfos_get_version and CMS_get_version which will
be added in the upcoming bump.

15 months agoTweak EC_GROUP_check_discriminant()
tb [Wed, 26 Jul 2023 17:15:25 +0000 (17:15 +0000)]
Tweak EC_GROUP_check_discriminant()

Make the logic and control flow a bit more explicit and use a single
extra variable for computing the discriminant. Call it discriminant,
not tmp, tmp_1 or tmp_2.

ok jsing

15 months agoUnindent a big block in EC_GROUP_get_affine_coordinates()
tb [Wed, 26 Jul 2023 12:26:48 +0000 (12:26 +0000)]
Unindent a big block in EC_GROUP_get_affine_coordinates()

15 months agoIntroduce and use ec_encode_scalar()
tb [Wed, 26 Jul 2023 12:24:28 +0000 (12:24 +0000)]
Introduce and use ec_encode_scalar()

This introduces two "inverses" of the ec_decode_scalar() function that take
a BIGNUM, reduce it modulo p and then encodes it into the curve's field
representation. For setting projective coordinates, we need a specialized
helper that deals with the Z_is_one optimization that is used to optimize
for calculations in standard affine coordinates of the projective plane.
This is used for simplifying EC_POINT_set_Jprojective_coordinates() and
for cleaning up and streamlining EC_GROUP_set_curve().

ok jsing

15 months agoGarbage collect the unused order in check_discriminant()
tb [Wed, 26 Jul 2023 12:16:55 +0000 (12:16 +0000)]
Garbage collect the unused order in check_discriminant()

ok jsing

15 months agoStreamline check_discriminant()
tb [Wed, 26 Jul 2023 12:16:13 +0000 (12:16 +0000)]
Streamline check_discriminant()

Instead of inlining EC_GROUP_get_curve(), we can simply call it...

ok jsing

15 months agoIntroduce ec_decode_scalar()
tb [Wed, 26 Jul 2023 12:12:13 +0000 (12:12 +0000)]
Introduce ec_decode_scalar()

This is a helper that decodes a scalar from field-internal representation
to a representation as a BIGNUM in the interval [0, p). This simplifies
EC_GROUP_get_curve() and EC_POINT_get_Jprojective_coordinates() to a few
obvious lines and prepares cleanup in EC_POINT_get_affine_coordinates().

ok jsing

15 months agoUse EC_POINT_set_to_infinity() rather than inlining it
tb [Wed, 26 Jul 2023 11:58:34 +0000 (11:58 +0000)]
Use EC_POINT_set_to_infinity() rather than inlining it

15 months agoShutd down the power domains suring suspend.
kettenis [Wed, 26 Jul 2023 11:09:24 +0000 (11:09 +0000)]
Shutd down the power domains suring suspend.

ok patrick@, tobhe@

15 months agodrm/atomic: Fix potential use-after-free in nonblocking commits
jsg [Wed, 26 Jul 2023 11:06:51 +0000 (11:06 +0000)]
drm/atomic: Fix potential use-after-free in nonblocking commits

From Daniel Vetter
e4a0e09b79bd2c0895c508cdc5e0265a083cc05d in linux-6.1.y/6.1.40
4e076c73e4f6e90816b30fcd4a0d7ab365087255 in mainline linux

15 months agocall kref_init() in drm_attach() matching the call in drm_dev_init()
jsg [Wed, 26 Jul 2023 11:04:07 +0000 (11:04 +0000)]
call kref_init() in drm_attach() matching the call in drm_dev_init()

15 months agoRemove constructor attribute for OPENSSL_cpuid_setup() on arm/aarch64.
jsing [Wed, 26 Jul 2023 09:57:34 +0000 (09:57 +0000)]
Remove constructor attribute for OPENSSL_cpuid_setup() on arm/aarch64.

OPENSSL_cpuid_setup() is invoked via OPENSSL_init_crypto(), whihc is
triggered by various entry points to the library. As such, we do not need
to invoke it as a constructor.

ok tb@

15 months agodrm/amd/pm: conditionally disable pcie lane/speed switching for SMU13
jsg [Wed, 26 Jul 2023 06:45:30 +0000 (06:45 +0000)]
drm/amd/pm: conditionally disable pcie lane/speed switching for SMU13

From Mario Limonciello
bd8cd38d3ac6b6410ac4e7401ef3dca057a9b285 in linux-6.1.y/6.1.40
31c7a3b378a136adc63296a2ff17645896fcf303 in mainline linux

15 months agodrm/amd/pm: share the code around SMU13 pcie parameters update
jsg [Wed, 26 Jul 2023 06:43:00 +0000 (06:43 +0000)]
drm/amd/pm: share the code around SMU13 pcie parameters update

From Evan Quan
11dc77a645b78b2fa8e730232f530778af4f710d in linux-6.1.y/6.1.40
dcb489bae65d92cfd26da22c7a0d6665b06ecc63 in mainline linux

15 months agodrm/ttm: Don't leak a resource on swapout move error
jsg [Wed, 26 Jul 2023 06:40:47 +0000 (06:40 +0000)]
drm/ttm: Don't leak a resource on swapout move error

From Thomas Hellstrom
f037f6038736bd038ddb9c72de979a08cc1ee3b5 in linux-6.1.y/6.1.40
a590f03d8de7c4cb7ce4916dc7f2fd10711faabe in mainline linux

15 months agodrm/amdgpu: avoid restore process run into dead loop.
jsg [Wed, 26 Jul 2023 06:39:07 +0000 (06:39 +0000)]
drm/amdgpu: avoid restore process run into dead loop.

From gaba
fe26d0fa9408896e821d1c8dd2ab52171da03ed9 in linux-6.1.y/6.1.40
8a774fe912ff09e39c2d3a3589c729330113f388 in mainline linux

15 months agodrm/amd/display: Add monitor specific edid quirk
jsg [Wed, 26 Jul 2023 06:37:05 +0000 (06:37 +0000)]
drm/amd/display: Add monitor specific edid quirk

From Aurabindo Pillai
8404d0e274ac1f780e29fa6380ad4e2f9c4bd3da in linux-6.1.y/6.1.40
613a7956deb3b1ffa2810c6d4c90ee9c3d743dbb in mainline linux

15 months agodrm/amd/display: Correct `DMUB_FW_VERSION` macro
jsg [Wed, 26 Jul 2023 06:35:39 +0000 (06:35 +0000)]
drm/amd/display: Correct `DMUB_FW_VERSION` macro

From Mario Limonciello
7ad40467fdfb57bdd8540a4a08cbb448f323c275 in linux-6.1.y/6.1.40
274d205cb59f43815542e04b42a9e6d0b9b95eff in mainline linux

15 months agodrm/amd/display: add a NULL pointer check
jsg [Wed, 26 Jul 2023 06:33:09 +0000 (06:33 +0000)]
drm/amd/display: add a NULL pointer check

From Sung-huai Wang
ad85fc99d6389bde08dc1dec55a2443514feba6e in linux-6.1.y/6.1.40
0f48a4b83610cb0e4e0bc487800ab69f51b4aca6 in mainline linux

15 months agodrm/amdgpu: fix clearing mappings for BOs that are always valid in VM
jsg [Wed, 26 Jul 2023 06:31:05 +0000 (06:31 +0000)]
drm/amdgpu: fix clearing mappings for BOs that are always valid in VM

From Samuel Pitoiset
91e69e67d401eb67178ce5992ddc9b1046b39ee7 in linux-6.1.y/6.1.40
ea2c3c08554601b051d91403a241266e1cf490a5 in mainline linux

15 months agodrm/amd/display: disable seamless boot if force_odm_combine is enabled
jsg [Wed, 26 Jul 2023 06:29:09 +0000 (06:29 +0000)]
drm/amd/display: disable seamless boot if force_odm_combine is enabled

From Leo Chen
3546f76c7ad87d0ade575a5c4acad5e4704d927c in linux-6.1.y/6.1.40
26518b39181876064850209ecdab48c0ee5924b1 in mainline linux

15 months agodrm/amd/display: Remove Phantom Pipe Check When Calculating K1 and K2
jsg [Wed, 26 Jul 2023 06:27:30 +0000 (06:27 +0000)]
drm/amd/display: Remove Phantom Pipe Check When Calculating K1 and K2

From Austin Zheng
a2ef3163c3604788abdc060cab74c95ed44fec1a in linux-6.1.y/6.1.40
1966bbfdfe476d271b338336254854c5edd5a907 in mainline linux

15 months agodrm/amd/display: edp do not add non-edid timings
jsg [Wed, 26 Jul 2023 06:26:05 +0000 (06:26 +0000)]
drm/amd/display: edp do not add non-edid timings

From Hersen Wu
c4629c757528f87ee22ea8fe16c645e471b9cbf6 in linux-6.1.y/6.1.40
7a0e005c7957931689a327b2a4e7333a19f13f95 in mainline linux

15 months agodrm/amd/display: fix seamless odm transitions
jsg [Wed, 26 Jul 2023 06:24:24 +0000 (06:24 +0000)]
drm/amd/display: fix seamless odm transitions

From Dmytro Laktyushkin
31fb25ecbba6ebe11dc497952310b986e05dd3a0 in linux-6.1.y/6.1.40
75c2b7ed080d7421157c03064be82275364136e7 in mainline linux

15 months agodrm/atomic: Allow vblank-enabled + self-refresh "disable"
jsg [Wed, 26 Jul 2023 06:22:43 +0000 (06:22 +0000)]
drm/atomic: Allow vblank-enabled + self-refresh "disable"

From Brian Norris
db0a9a29912cdc1834214fe35101a4917f8b9907 in linux-6.1.y/6.1.40
9d0e3cac3517942a6e00eeecfe583a98715edb16 in mainline linux

15 months agodrm/amd/pm: add abnormal fan detection for smu 13.0.0
jsg [Wed, 26 Jul 2023 06:20:51 +0000 (06:20 +0000)]
drm/amd/pm: add abnormal fan detection for smu 13.0.0

From Kenneth Feng
13e8af958cfa97d93d9824b863208c0bb0977361 in linux-6.1.y/6.1.40
2da0036ea99bccb27f7fe3cf2aa2900860e9be46 in mainline linux

15 months agodrm/amdgpu: Fix minmax warning
jsg [Wed, 26 Jul 2023 06:19:33 +0000 (06:19 +0000)]
drm/amdgpu: Fix minmax warning

From Luben Tuikov
e8b6b7b8132500ecb241f7f685398028017ec0d3 in linux-6.1.y/6.1.40
abd51738fe754a684ec44b7a9eca1981e1704ad9 in mainline linux

15 months agodrm/amdgpu: add the fan abnormal detection feature
jsg [Wed, 26 Jul 2023 06:17:53 +0000 (06:17 +0000)]
drm/amdgpu: add the fan abnormal detection feature

From lyndonli
d7d53c669da90181827e42583582192646a4d933 in linux-6.1.y/6.1.40
ef5fca9f7294509ee5013af9e879edc5837c1d6c in mainline linux

15 months agodrm/amd/pm: revise the ASPM settings for thunderbolt attached scenario
jsg [Wed, 26 Jul 2023 06:16:19 +0000 (06:16 +0000)]
drm/amd/pm: revise the ASPM settings for thunderbolt attached scenario

From Evan Quan
c8c703befd2fb2ebbcc9cedbdc98953b52453a35 in linux-6.1.y/6.1.40
fd21987274463a439c074b8f3c93d3b132e4c031 in mainline linux

15 months agodrm/amdgpu/sdma4: set align mask to 255
jsg [Wed, 26 Jul 2023 06:14:40 +0000 (06:14 +0000)]
drm/amdgpu/sdma4: set align mask to 255

From Alex Deucher
4596c812916a582e16aedfb243aaee8d010c6220 in linux-6.1.y/6.1.40
e5df16d9428f5c6d2d0b1eff244d6c330ba9ef3a in mainline linux

15 months agodrm/client: Send hotplug event after registering a client
jsg [Wed, 26 Jul 2023 06:13:01 +0000 (06:13 +0000)]
drm/client: Send hotplug event after registering a client

From Thomas Zimmermann
7c880188c71066449a76de71de772198a0c30a7c in linux-6.1.y/6.1.40
27655b9bb9f0d9c32b8de8bec649b676898c52d5 in mainline linux

15 months agodrm/i915: Fix one wrong caching mode enum usage
jsg [Wed, 26 Jul 2023 06:10:51 +0000 (06:10 +0000)]
drm/i915: Fix one wrong caching mode enum usage

From Tvrtko Ursulin
5a9aecb6651c6e1ef8198c162340ebe172b7a551 in linux-6.1.y/6.1.40
113899c2669dff148b2a5bea4780123811aecc13 in mainline linux

15 months agodrm/i915: Don't preserve dpll_hw_state for slave crtc in Bigjoiner
jsg [Wed, 26 Jul 2023 06:09:12 +0000 (06:09 +0000)]
drm/i915: Don't preserve dpll_hw_state for slave crtc in Bigjoiner

From Stanislav Lisovskiy
f1e746aedd7dfbdea84b690c56154a11b68dc4de in linux-6.1.y/6.1.40
5c413188c68da0e4bffc93de1c80257e20741e69 in mainline linux