openbsd
10 years agoi suck at math. b - 8 = 3, not 4. detected by Antoine Pitrou. thanks.
tedu [Wed, 30 Apr 2014 01:05:50 +0000 (01:05 +0000)]
i suck at math. b - 8 = 3, not 4. detected by Antoine Pitrou. thanks.

10 years agosync
deraadt [Wed, 30 Apr 2014 00:20:28 +0000 (00:20 +0000)]
sync

10 years agominor++ because of AI_ADDRCONFIG
sperreault [Wed, 30 Apr 2014 00:16:47 +0000 (00:16 +0000)]
minor++ because of AI_ADDRCONFIG

prodded by naddy, confirmed by Mark Kettenis

10 years agofcntl.h is still needed here.
nicm [Tue, 29 Apr 2014 22:31:22 +0000 (22:31 +0000)]
fcntl.h is still needed here.

10 years agoGet rid of the per-softc freelist of transfer descriptors and use a
mpi [Tue, 29 Apr 2014 21:51:18 +0000 (21:51 +0000)]
Get rid of the per-softc freelist of transfer descriptors and use a
per-driver pool(9) instead.

10 years agotedu ~/.klogin
dcoppa [Tue, 29 Apr 2014 21:30:20 +0000 (21:30 +0000)]
tedu ~/.klogin

ok henning@ deraadt@

10 years agoFor RSA private key privsep, only ever load the keys after forking the
reyk [Tue, 29 Apr 2014 21:04:17 +0000 (21:04 +0000)]
For RSA private key privsep, only ever load the keys after forking the
separated process.  This improves the previous because we don't trust
the PEM and BIO routines to cleanup the keys correctly.

ok gilles@

10 years agoDon't attempt to append a nul quote char to the filename. Should prevent
dtucker [Tue, 29 Apr 2014 20:36:51 +0000 (20:36 +0000)]
Don't attempt to append a nul quote char to the filename.  Should prevent
fatal'ing with "el_insertstr failed" when there's a single quote char
somewhere in the string.  bz#2238, ok markus@

10 years agoMove nulling of variable next to where it's freed. ok markus@
dtucker [Tue, 29 Apr 2014 19:58:50 +0000 (19:58 +0000)]
Move nulling of variable next to where it's freed.  ok markus@

10 years agoImplement RSA privilege separation for OpenSMTPD, based on my previous
reyk [Tue, 29 Apr 2014 19:13:13 +0000 (19:13 +0000)]
Implement RSA privilege separation for OpenSMTPD, based on my previous
implementation for relayd(8).  The smtpd(8) pony processes (mta
client, smtp server) don't keep the private keys in memory but send
their private key operations as imsgs to the "lookup"/mta process.
It's worth mentioning that this prevents acidental private key leakage
as it could have been caused by "Heartbleed".

ok gilles@

10 years agomake compiling against OpenSSL optional (make OPENSSL=no);
markus [Tue, 29 Apr 2014 18:01:49 +0000 (18:01 +0000)]
make compiling against OpenSSL optional (make OPENSSL=no);
reduces algorithms to curve25519, aes-ctr, chacha, ed25519;
allows us to explore further options; with and ok djm

10 years agoa bit more merge for traceroute6 stuff, and some consistency fixes;
jmc [Tue, 29 Apr 2014 17:35:29 +0000 (17:35 +0000)]
a bit more merge for traceroute6 stuff, and some consistency fixes;
help/ok florian

10 years agowhen a session fails due to a TLS error in a smtp+tls:// connection, try
gilles [Tue, 29 Apr 2014 17:32:42 +0000 (17:32 +0000)]
when a session fails due to a TLS error in a smtp+tls:// connection, try
plain before giving up

ok eric@

10 years agoConstrain bytes read/written to positive values.
beck [Tue, 29 Apr 2014 15:46:54 +0000 (15:46 +0000)]
Constrain bytes read/written to positive values.
ok miod@ tedu@

10 years agore-add our own aesctr implementation; ok djm@
markus [Tue, 29 Apr 2014 15:39:33 +0000 (15:39 +0000)]
re-add our own aesctr implementation; ok djm@

10 years agoMove traceroute6 to the attic, fully merged into traceroute.
florian [Tue, 29 Apr 2014 15:03:07 +0000 (15:03 +0000)]
Move traceroute6 to the attic, fully merged into traceroute.

10 years agoFinally plug the public xfer leak #1 in our USB stack.
mpi [Tue, 29 Apr 2014 14:11:23 +0000 (14:11 +0000)]
Finally plug the public xfer leak #1 in our USB stack.

Every call to usbd_abort_pipe() on an interrupt pipe would simply
reset the intrxfer pointer, which would prevent usbd_close_pipe()
to free it.  Since we abort pipes in a lot of situations: when a
device is detached, when a USB-to-serial adapter is closed, when
an error occurs, when the machine is suspended, etc, this would
result in hundreds of leaked xfers in most of my machines.

xhci(4) is not affected, but you can't enable it right now since
the stack is not ready :)

While here put a KASSERT() to make sure drivers are only calling
the interrupt abort method for intrxfer, if that's not the case,
please let met know.

10 years agonginx dudes unrolled SSL_OP_ALL by hand so we also have to delete
tedu [Tue, 29 Apr 2014 14:10:07 +0000 (14:10 +0000)]
nginx dudes unrolled SSL_OP_ALL by hand so we also have to delete
SSL_OP_DONT_INSERT_EMPTY_FRAGMENTS from here to benefit. ok miod

10 years agoregen
mcbride [Tue, 29 Apr 2014 13:49:19 +0000 (13:49 +0000)]
regen

10 years agosmtpd is the default mailer now;
jmc [Tue, 29 Apr 2014 13:48:18 +0000 (13:48 +0000)]
smtpd is the default mailer now;
From: Jan Stary

ok gilles

10 years agoAdd Microsoft Wireless Mobile Mouse 3500 and Wireless Arc Mouse.
mcbride [Tue, 29 Apr 2014 13:46:55 +0000 (13:46 +0000)]
Add Microsoft Wireless Mobile Mouse 3500 and Wireless Arc Mouse.

ok mpi

10 years agobz#1818 - don't send channel success/failre replies on channels that
djm [Tue, 29 Apr 2014 13:10:30 +0000 (13:10 +0000)]
bz#1818 - don't send channel success/failre replies on channels that
have sent a close already; analysis and patch from Simon Tatham;
ok markus@

10 years agoMake sure to call uhidev_close() upon detach, plug another xfer leak.
mpi [Tue, 29 Apr 2014 12:53:33 +0000 (12:53 +0000)]
Make sure to call uhidev_close() upon detach, plug another xfer leak.

10 years agoPlug an xfer leak.
mpi [Tue, 29 Apr 2014 12:47:33 +0000 (12:47 +0000)]
Plug an xfer leak.

10 years agoGet rid of the per-softc freelist of transfer descriptors and use a
mpi [Tue, 29 Apr 2014 12:45:29 +0000 (12:45 +0000)]
Get rid of the per-softc freelist of transfer descriptors and use a
per-driver pool(9) instead.

With inputs from mikeb@

10 years agoRemove unused arguments from ssl_smtp_init()
reyk [Tue, 29 Apr 2014 12:18:27 +0000 (12:18 +0000)]
Remove unused arguments from ssl_smtp_init()

ok gilles@

10 years agoRemove support for the obsolete (non-POSIX) "more -d" prompt.
millert [Tue, 29 Apr 2014 12:11:25 +0000 (12:11 +0000)]
Remove support for the obsolete (non-POSIX) "more -d" prompt.
This was a local change that was only enabled when the LESS_IS_MORE
environment variable was set and not when invoked as "more".
OK shadchin@ jmc@

10 years agoIf you plan to write an obfuscated-by-design kernel / userland
mpi [Tue, 29 Apr 2014 11:58:29 +0000 (11:58 +0000)]
If you plan to write an obfuscated-by-design kernel / userland
interface, I suggest you have a look at the link-layer sockaddr
interface:

  /*
   * A Link-Level Sockaddr may specify the interface in one of two
   * ways: either by means of a system-provided index number (computed
   * anew and possibly differently on every reboot), or by a human-readable
   * string such as "il0" (for managerial convenience).
   [...]
   */

ifa_ifwithnet() was not only checking for the sdl_index in order
to get the corresponding ifp for AF_LINK sockaddr, it was also
iterating over all the addresses on your system!  But in this
case, the `address' field of "struct sockaddr_dl" is an interface
name set by link_addr(3).

How can this work?  Well because the kernel allocates an empty
`netmask' field for each interface's lladdr, so that you can
abuse a network comparison function to reimplement strcmp(3)...

So when the userland does not specify an interface index, try
harder to see if it passed an ifp name, but at least be explicit
and use ifunit().

Found the hard way by/ok sthen@

10 years agomake sure the state machine only advances if the AUTH payload has
markus [Tue, 29 Apr 2014 11:51:13 +0000 (11:51 +0000)]
make sure the state machine only advances if the AUTH payload has
been verified; with & ok mikeb@

10 years agouse explicit_bzero() instead of memset() to clear out sensitive data.
reyk [Tue, 29 Apr 2014 10:18:06 +0000 (10:18 +0000)]
use explicit_bzero() instead of memset() to clear out sensitive data.

ok gilles@

10 years agoIt is only required to load the keys and certs into the same SSL
reyk [Tue, 29 Apr 2014 10:08:55 +0000 (10:08 +0000)]
It is only required to load the keys and certs into the same SSL
context once.  Simplify the code path by moving the loading from three
different places into ssl_ctx_create():

ok gilles@

10 years agoReplace 1 << PAGE_SHIFT with PAGE_SIZE.
kettenis [Tue, 29 Apr 2014 09:55:28 +0000 (09:55 +0000)]
Replace 1 << PAGE_SHIFT with PAGE_SIZE.

ok beck@, miod@

10 years agoFix typo: d_addrt -> daddr_t
dcoppa [Tue, 29 Apr 2014 07:52:06 +0000 (07:52 +0000)]
Fix typo: d_addrt -> daddr_t

ok bmercer@

10 years agofix a test for invalid timezones
jsg [Tue, 29 Apr 2014 07:44:19 +0000 (07:44 +0000)]
fix a test for invalid timezones
oks from a bunch of people

10 years agoRemove device white-listing as matching method, relies on on usage id
andre [Tue, 29 Apr 2014 07:23:40 +0000 (07:23 +0000)]
Remove device white-listing as matching method, relies on on usage id
versus supported sensors table filtering.

discussed with and ok mpi@

10 years agoImplement AI_ADDRCONFIG
sperreault [Mon, 28 Apr 2014 21:38:59 +0000 (21:38 +0000)]
Implement AI_ADDRCONFIG

This is a getaddrinfo() flag that is defined thusly in RFC 3493:

   If the AI_ADDRCONFIG flag is specified, IPv4 addresses shall be
   returned only if an IPv4 address is configured on the local system,
   and IPv6 addresses shall be returned only if an IPv6 address is
   configured on the local system.  The loopback address is not
   considered for this case as valid as a configured address.

      For example, when using the DNS, a query for AAAA records should
      occur only if the node has at least one IPv6 address configured
      (other than IPv6 loopback) and a query for A records should occur
      only if the node has at least one IPv4 address configured (other
      than the IPv4 loopback).

The flag is set by default when hints is NULL.

ok Eric Faurot, Jason McIntyre

10 years agoRemove WIN32, WIN64 and MINGW32 tentacles.
miod [Mon, 28 Apr 2014 21:14:50 +0000 (21:14 +0000)]
Remove WIN32, WIN64 and MINGW32 tentacles.
Also check for _LP64 rather than __arch64__ (the former being more reliable
than __LP64__ or __arch64__) to tell 64-bit int platforms apart from 32-bit
int platforms.

Loosely based upon a diff from Martijn van Duren on tech@

10 years agoRemove bogus semicolon.
brad [Mon, 28 Apr 2014 21:01:51 +0000 (21:01 +0000)]
Remove bogus semicolon.

Pointed out by LLVM.

fd.c:1378:29: error: if statement has empty body [-Werror,-Wempty-body]

ok miod@

10 years agouse the correct algorithm mask. reported by satish lvr via
tedu [Mon, 28 Apr 2014 20:10:55 +0000 (20:10 +0000)]
use the correct algorithm mask. reported by satish lvr via
http://marc.info/?l=openssl-dev&m=139779977532459&w=2
ok miod

10 years agoSSL_OP_ALL is supposed to be all options and workarounds that are safe,
tedu [Mon, 28 Apr 2014 20:05:21 +0000 (20:05 +0000)]
SSL_OP_ALL is supposed to be all options and workarounds that are safe,
but disabling attack mitigations is not safe. 0.9.6d contained a
workaround for an attack against CBC modes. 0.9.6e disabled it by default
because "some" implementations couldn't handle empty fragments. 12 years
have passed. Does anybody still care? Let's find out.
ok miod

10 years agoRemove ending cplusplus guard followed by starting cplusplus guard; from
miod [Mon, 28 Apr 2014 19:06:19 +0000 (19:06 +0000)]
Remove ending cplusplus guard followed by starting cplusplus guard; from
Gebruiker Schoot.

10 years agoLeftover includes and local declarations; from Gebruiker Schoot
miod [Mon, 28 Apr 2014 19:04:59 +0000 (19:04 +0000)]
Leftover includes and local declarations; from Gebruiker Schoot

10 years agoIgnore IRIX6-compatible archive map on mips64 platform, since the mips64
miod [Mon, 28 Apr 2014 18:49:28 +0000 (18:49 +0000)]
Ignore IRIX6-compatible archive map on mips64 platform, since the mips64
toolchain creates them. This lets nm -w correctly return 0 for valid archives.

ok jasper@ deraadt@

10 years agore-add _ppp for npppd here as well; ok ajacoutot
okan [Mon, 28 Apr 2014 17:03:48 +0000 (17:03 +0000)]
re-add _ppp for npppd here as well; ok ajacoutot

10 years agomacro fixes for previous; ok reyk
jmc [Mon, 28 Apr 2014 16:23:19 +0000 (16:23 +0000)]
macro fixes for previous; ok reyk

10 years agosync bzero => memset that was done for ip_divert.c before.
reyk [Mon, 28 Apr 2014 15:43:04 +0000 (15:43 +0000)]
sync bzero => memset that was done for ip_divert.c before.

ok tedu@

10 years agoDo not sleep after poll returning an error. Blindly copied over from
florian [Mon, 28 Apr 2014 15:25:34 +0000 (15:25 +0000)]
Do not sleep after poll returning an error. Blindly copied over from
ping6 to ping by me without thinking clearly.
pointed out by deraadt@
OK jca@

10 years agoAdd support for 255 character file names in fuse.
syl [Mon, 28 Apr 2014 13:08:34 +0000 (13:08 +0000)]
Add support for 255 character file names in fuse.

from Helg Bredow, thanks!
input/OK reyk@

10 years agofix memory leak
blambert [Mon, 28 Apr 2014 12:48:36 +0000 (12:48 +0000)]
fix memory leak

ok reyk@

10 years agocheck for integer overflows in custom allocs, okay jca@
espie [Mon, 28 Apr 2014 12:34:11 +0000 (12:34 +0000)]
check for integer overflows in custom allocs, okay jca@

10 years agoAdd support for exporting ARP table via ipNetToMediaTable OID.
mikeb [Mon, 28 Apr 2014 12:03:32 +0000 (12:03 +0000)]
Add support for exporting ARP table via ipNetToMediaTable OID.
With help from blambert@ and sthen@, tested by sthen@, benno@
and myself;  ok blambert

10 years agospacing
reyk [Mon, 28 Apr 2014 11:19:22 +0000 (11:19 +0000)]
spacing

10 years agobump copyright
reyk [Mon, 28 Apr 2014 11:17:15 +0000 (11:17 +0000)]
bump copyright

10 years agoAdd missing documentation for ipcomp(4) support and the configuration
reyk [Mon, 28 Apr 2014 11:16:18 +0000 (11:16 +0000)]
Add missing documentation for ipcomp(4) support and the configuration
payloads.

ok sthen@ krw@

10 years agoIt's about time to remove the infamous CAVEATS section in iked(8).
reyk [Mon, 28 Apr 2014 11:05:59 +0000 (11:05 +0000)]
It's about time to remove the infamous CAVEATS section in iked(8).
Software is never "finished" but the implementation has matured enough
to drop the disclaimer about using it in production networks.

Thanks to markus@, mikeb@ and Hans-Joerg Hoexer for their significant
and ongoing work on improving iked(8).

Removal prompted by sthen@ and many others.

10 years agoMove an opening brace so a loop that delays while waiting
jsg [Mon, 28 Apr 2014 10:06:37 +0000 (10:06 +0000)]
Move an opening brace so a loop that delays while waiting
for hardware to set a ready bit actually delays.

ok krw@ deraadt@ 'sounds correct' miod@

10 years agowhitespace cleanup while reading result of florian's recent (very nice) work
deraadt [Mon, 28 Apr 2014 09:45:30 +0000 (09:45 +0000)]
whitespace cleanup while reading result of florian's recent (very nice) work

10 years agobetter proc id name (it handles traps, not alerts) for the
blambert [Mon, 28 Apr 2014 08:25:05 +0000 (08:25 +0000)]
better proc id name (it handles traps, not alerts) for the
snmp trap handler

10 years agobuffer_get_string_ptr's return should be const to remind
djm [Mon, 28 Apr 2014 03:09:18 +0000 (03:09 +0000)]
buffer_get_string_ptr's return should be const to remind
callers that futzing with it will futz with the actual buffer
contents

10 years agoImprove error handling in dbopen(). If PRAGMA SQL statements fail,
schwarze [Sun, 27 Apr 2014 23:03:52 +0000 (23:03 +0000)]
Improve error handling in dbopen().  If PRAGMA SQL statements fail,
report the error, close the database, and return failure from dbopen(),
such that the main program can recover and rebuild the database.

As noticed by stsp@, this can happen when database files are
accessible, but corrupt or in the wrong format, which will now
automatically be repaired.

Besides, use a safer idiom after sqlite3_open*() failure that also
handles out-of-memory situations correctly, and do not forget to
close the database after CREATE TABLE failure.

10 years agoFor LUNA88K, make sure the architecture name shown to the user
schwarze [Sun, 27 Apr 2014 22:41:39 +0000 (22:41 +0000)]
For LUNA88K, make sure the architecture name shown to the user
matches the architecture name required for man -S and apropos -S.
Adjust the case of LUNA68K to match the case of LUNA88K.
ok aoyama@

10 years agoRegress for access()
guenther [Sun, 27 Apr 2014 22:18:25 +0000 (22:18 +0000)]
Regress for access()

10 years agotypo in comment
miod [Sun, 27 Apr 2014 20:38:39 +0000 (20:38 +0000)]
typo in comment

10 years agoRemove orphaned l2n6 and n2l6 macros.
miod [Sun, 27 Apr 2014 20:34:33 +0000 (20:34 +0000)]
Remove orphaned l2n6 and n2l6 macros.

10 years agoUse C99 initializers for the various FOO_METHOD structs. More readable, and
miod [Sun, 27 Apr 2014 20:26:46 +0000 (20:26 +0000)]
Use C99 initializers for the various FOO_METHOD structs. More readable, and
avoid unreadable/unmaintainable constructs like that:

const EVP_PKEY_ASN1_METHOD cmac_asn1_meth =
        {
        EVP_PKEY_CMAC,
        EVP_PKEY_CMAC,
        0,

        "CMAC",
        "OpenSSL CMAC method",

        0,0,0,0,

        0,0,0,

        cmac_size,
        0,
        0,0,0,0,0,0,0,

        cmac_key_free,
        0,
        0,0
        };

ok matthew@ deraadt@

10 years agostatic const char * = "" -> static const char[] = "", to produce shorter code.
miod [Sun, 27 Apr 2014 20:24:52 +0000 (20:24 +0000)]
static const char * = "" -> static const char[] = "", to produce shorter code.
No functional change.

10 years agoUnifdef -U OPENSSL_BUILD_SHLIBCRYPTO, since all it causes under Unix is to
miod [Sun, 27 Apr 2014 20:22:30 +0000 (20:22 +0000)]
Unifdef -U OPENSSL_BUILD_SHLIBCRYPTO, since all it causes under Unix is to
redefine OPENSSL_EXTERN from `extern' to `extern'.

10 years agoPut explicit (void) in function declarations and shuffle keywords in some
miod [Sun, 27 Apr 2014 20:20:57 +0000 (20:20 +0000)]
Put explicit (void) in function declarations and shuffle keywords in some
declaration to pass -Wextra, should we want to add it to CFLAGS.
No binary change.

10 years agoFix library search order in our libtool.
zhuk [Sun, 27 Apr 2014 18:08:35 +0000 (18:08 +0000)]
Fix library search order in our libtool.

Before, libtool first searched all directories for .la files, and if
search failed, switched to actual libraries (.so/.a). But the correct way
is to check each directory first for .la, then for .so/.a.

The problem was reported by ajacoutot@ who verified that the patch fixes
his case and okay'ed the initial diff. And jasper@'s bulk uncovered a bug
which is fixed now (verified by another bulk).

10 years agozap trailing whitespace;
jmc [Sun, 27 Apr 2014 16:58:08 +0000 (16:58 +0000)]
zap trailing whitespace;

10 years agosort the ip6 sysctls;
jmc [Sun, 27 Apr 2014 16:56:51 +0000 (16:56 +0000)]
sort the ip6 sysctls;

10 years agoWe do not need a separate file for two compatibility wrapper functions.
jsing [Sun, 27 Apr 2014 16:19:04 +0000 (16:19 +0000)]
We do not need a separate file for two compatibility wrapper functions.

ok miod@

10 years agoFix leak last commit introduced. Spotted by Sebastian Kapfer.
beck [Sun, 27 Apr 2014 15:59:25 +0000 (15:59 +0000)]
Fix leak last commit introduced. Spotted by Sebastian Kapfer.

10 years agoDocument net.inet6.ip6.dad_pending.
logan [Sun, 27 Apr 2014 15:55:16 +0000 (15:55 +0000)]
Document net.inet6.ip6.dad_pending.

OK from jmc@, and thanks to sthen@ for pointing out my mistake in the first
version of the diff.

10 years agozap a ton of silly Tn, and uppercase TTL; a few other minor tweaks along the
jmc [Sun, 27 Apr 2014 15:30:16 +0000 (15:30 +0000)]
zap a ton of silly Tn, and uppercase TTL; a few other minor tweaks along the
way;

10 years agoAdd PME_STATUS and PME_EN bitmasks for the PCI PMCSR register.
stsp [Sun, 27 Apr 2014 14:55:09 +0000 (14:55 +0000)]
Add PME_STATUS and PME_EN bitmasks for the PCI PMCSR register.
ok kettenis@

10 years agoStart de-obfuscating the HC drivers.
mpi [Sun, 27 Apr 2014 14:48:10 +0000 (14:48 +0000)]
Start de-obfuscating the HC drivers.

Since pipe methods have an xfer argument, always use it to get acces to
various data structure (pipe, bus, device) instead of having a different
way to get a pointer to these descriptors in every function.

Also kill the {E,U}XFER() macro and use a consistent name accross all the
methods for {e,u}hci_xfer.

10 years agoDon't zap disklabel (and next 6 blocks) when installing boot block on
krw [Sun, 27 Apr 2014 13:41:50 +0000 (13:41 +0000)]
Don't zap disklabel (and next 6 blocks) when installing boot block on
4k-sector disk drives.

Noted and fix tested by David Vasek via misc@

tweaks & ok jsing@

10 years agoDo not let the bluetooth HID device, present in Apple machines with USB,
mpi [Sun, 27 Apr 2014 13:32:04 +0000 (13:32 +0000)]
Do not let the bluetooth HID device, present in Apple machines with USB,
grab the console.

This makes ddb(4) usable with any simple wired USB keyboard on G3/G4
machines that do not have adb(4) input devices, on G5s and certainly on
some MacBooks too.

ok andre@, miod@

10 years agoGet back "_ppp" user and "_ppp" group. From now they will be solely
yasuoka [Sun, 27 Apr 2014 10:07:29 +0000 (10:07 +0000)]
Get back "_ppp" user and "_ppp" group.  From now they will be solely
used by npppd.

ok deraadt

10 years agotransplant hotplug code over from qle(4)
jmatthew [Sun, 27 Apr 2014 08:40:13 +0000 (08:40 +0000)]
transplant hotplug code over from qle(4)

10 years agosync
todd [Sun, 27 Apr 2014 06:43:39 +0000 (06:43 +0000)]
sync

10 years agoWhen the firmware has already allocated the handle we want to use to log in
jmatthew [Sun, 27 Apr 2014 05:23:35 +0000 (05:23 +0000)]
When the firmware has already allocated the handle we want to use to log in
to a port, restart the update process to keep things in sync.  Domain
controller logins get special handling here because they don't show up in the
list of logged in ports.

10 years agoAppease gcc3 -Wuninitialized.
miod [Sat, 26 Apr 2014 22:54:54 +0000 (22:54 +0000)]
Appease gcc3 -Wuninitialized.

10 years agoGet rid of duplication of the global lock code. Allow recursion in all
kettenis [Sat, 26 Apr 2014 21:45:50 +0000 (21:45 +0000)]
Get rid of duplication of the global lock code.  Allow recursion in all
code paths.

ok pirofti@

10 years agoReplace all use of ERR_add_error_data with ERR_asprintf_error_data.
beck [Sat, 26 Apr 2014 18:56:37 +0000 (18:56 +0000)]
Replace all use of ERR_add_error_data with ERR_asprintf_error_data.
This avoids a lot of ugly gymnastics to do snprintfs before sending the
bag of strings to ERR, and eliminates at least one place in dso_dlfctn.c
where it was being called with the incorrect number of arguments and
using random things off the stack as addresses of strings.
ok krw@, jsing@

10 years agosync
todd [Sat, 26 Apr 2014 15:45:53 +0000 (15:45 +0000)]
sync

10 years agoDo not pass a NULL argument to OF_getprop(), even if it's fine for the
mpi [Sat, 26 Apr 2014 14:26:48 +0000 (14:26 +0000)]
Do not pass a NULL argument to OF_getprop(), even if it's fine for the
moment since we use an intermediate buffer and we specify a length of 0,
there's no need for an exception here.

Noticied while playing with the virtual-mode client interface of firmware.

10 years agoAllow to compile with DEBUG_PMAP defined.
mpi [Sat, 26 Apr 2014 14:19:04 +0000 (14:19 +0000)]
Allow to compile with DEBUG_PMAP defined.

10 years agoMore KNF.
jsing [Sat, 26 Apr 2014 13:07:16 +0000 (13:07 +0000)]
More KNF.

10 years agoKNF.
jsing [Sat, 26 Apr 2014 13:04:24 +0000 (13:04 +0000)]
KNF.

10 years agoKill the link to /usr/bin/page. OK henning@ jmc@ miod@ schwarze@
millert [Sat, 26 Apr 2014 11:53:05 +0000 (11:53 +0000)]
Kill the link to /usr/bin/page.  OK henning@ jmc@ miod@ schwarze@

10 years agofix whitespace
sthen [Sat, 26 Apr 2014 11:28:49 +0000 (11:28 +0000)]
fix whitespace

10 years agoOnly remove queues from the TAILQ when the ticket changes; fixes PPS/BPS
sthen [Sat, 26 Apr 2014 11:27:23 +0000 (11:27 +0000)]
Only remove queues from the TAILQ when the ticket changes; fixes PPS/BPS
displays for queues in "systat q". From Arto Jonsson.

10 years agoThis is not FreeBSD.
jsing [Sat, 26 Apr 2014 11:08:59 +0000 (11:08 +0000)]
This is not FreeBSD.

ok miod@

10 years agoDo you really want to build OpenSSL for 16-bit Windows? Well, we don't.
jsing [Sat, 26 Apr 2014 11:08:10 +0000 (11:08 +0000)]
Do you really want to build OpenSSL for 16-bit Windows? Well, we don't.

ok miod@

10 years agoLink traceroute6 to traceroute, thus completing the merge.
florian [Sat, 26 Apr 2014 11:02:45 +0000 (11:02 +0000)]
Link traceroute6 to traceroute, thus completing the merge.
I was originally sent on this little errand by deraadt@.
OK sthen@, benno@
(Committing from a bus somewhere in germany on its way to berlin.)

10 years agoremove a duplicate break statement
jsg [Sat, 26 Apr 2014 06:17:26 +0000 (06:17 +0000)]
remove a duplicate break statement

10 years agoRevert 1.11. That patch is not only not necessary, it is quite harmful now.
shadchin [Sat, 26 Apr 2014 05:58:43 +0000 (05:58 +0000)]
Revert 1.11. That patch is not only not necessary, it is quite harmful now.

ok schwarze@

10 years agoPerform MAXPHYS-sized reads for the chunktable instead of PAGE_SIZE-sized
mlarkin [Sat, 26 Apr 2014 05:43:00 +0000 (05:43 +0000)]
Perform MAXPHYS-sized reads for the chunktable instead of PAGE_SIZE-sized
reads.

Also fix a VA leak in the chunktable read error path.