openbsd
13 months agoOn second thoughts, do check DA2 for DECFRA and DECSLRM since that will
nicm [Fri, 8 Sep 2023 07:05:06 +0000 (07:05 +0000)]
On second thoughts, do check DA2 for DECFRA and DECSLRM since that will
catch terminals that say they are VT520 even if we can't use DA1
(because of VTE).

13 months agoUse DECSLRM and DECFRA only at level 4 rather than checking the terminal
nicm [Fri, 8 Sep 2023 06:52:31 +0000 (06:52 +0000)]
Use DECSLRM and DECFRA only at level 4 rather than checking the terminal
id.

13 months agofix sizeof(*ptr) instead sizeof(ptr) in realloc (pointer here is
djm [Fri, 8 Sep 2023 06:34:24 +0000 (06:34 +0000)]
fix sizeof(*ptr) instead sizeof(ptr) in realloc (pointer here is
char**, so harmless); spotted in CID 416964

13 months agoregress test recursive remote-remote directories copies where the
djm [Fri, 8 Sep 2023 06:10:57 +0000 (06:10 +0000)]
regress test recursive remote-remote directories copies where the
directory contains a symlink to another directory.

also remove errant `set -x` that snuck in at some point

13 months agofix recursive remote-remote copies of directories that contain symlinks
djm [Fri, 8 Sep 2023 06:10:02 +0000 (06:10 +0000)]
fix recursive remote-remote copies of directories that contain symlinks
to other directories (similar to bz3611)

13 months agoAdd request or response decoration feature which is used through the
yasuoka [Fri, 8 Sep 2023 05:56:22 +0000 (05:56 +0000)]
Add request or response decoration feature which is used through the
radiusd module interface.  This makes additional modules can modify
RADIUS request or response messages.  Also add new "radius_standard"
module which uses this new feature, provides some generic features
like "strip-atmark-realm" which removes the realm part from the
User-Name attribute.  from IIJ.

13 months agothe sftp code was one of my first contributions to OpenSSH and it
djm [Fri, 8 Sep 2023 05:56:13 +0000 (05:56 +0000)]
the sftp code was one of my first contributions to OpenSSH and it
shows - the function names are terrible.

Rename do_blah() to sftp_blah() to make them less so.

Completely mechanical except for sftp_stat() and sftp_lstat() which
change from returning a pointer to a static variable (error-prone) to
taking a pointer to a caller-provided receiver.

13 months agoregress test for recursive copies of directories containing symlinks
djm [Fri, 8 Sep 2023 05:50:57 +0000 (05:50 +0000)]
regress test for recursive copies of directories containing symlinks
to other directories. bz3611, ok dtucker@

13 months agofix scp in SFTP mode recursive upload and download of directories
djm [Fri, 8 Sep 2023 05:50:12 +0000 (05:50 +0000)]
fix scp in SFTP mode recursive upload and download of directories
that contain symlinks to other directories. In scp mode, the links
would be followed, but in SFTP mode they were not. bz3611, ok dtucker@

13 months agoblast from the past... be gone!
espie [Thu, 7 Sep 2023 23:32:56 +0000 (23:32 +0000)]
blast from the past... be gone!

13 months agosync
tb [Thu, 7 Sep 2023 21:31:00 +0000 (21:31 +0000)]
sync

13 months agoBelow RETURN VALUES,
schwarze [Thu, 7 Sep 2023 19:59:58 +0000 (19:59 +0000)]
Below RETURN VALUES,
* mention that EVP_MD_CTX_md(3) also returns NULL
if no message digest is configured yet; and
* omplete the list of functions returning const EVP_MD *,
also making the wording more precise.

Delete EVP_MAX_MD_SIZE from the NAME, SYNOPSIS, and HISTORY sections
because we do not usually document preprocessor macro constants in
this way.  There is nothing special about this constant justifying
an exception.

13 months agoadd the missing entries for EVP_MD_CTX_pkey_ctx(3) and EVP_MD_CTX_md_data(3)
schwarze [Thu, 7 Sep 2023 19:28:37 +0000 (19:28 +0000)]
add the missing entries for EVP_MD_CTX_pkey_ctx(3) and EVP_MD_CTX_md_data(3)
to the RETURN VALUES section

13 months agoalways say "the sqlports package"
espie [Thu, 7 Sep 2023 17:26:14 +0000 (17:26 +0000)]
always say "the sqlports package"

13 months agobe more direct about SUPDISTFILES
espie [Thu, 7 Sep 2023 17:24:39 +0000 (17:24 +0000)]
be more direct about SUPDISTFILES

13 months agoWe prefer SITES.sufx (lowercase)
espie [Thu, 7 Sep 2023 17:21:10 +0000 (17:21 +0000)]
We prefer SITES.sufx (lowercase)

13 months agoMASTER_SITES -> SITES
espie [Thu, 7 Sep 2023 17:19:19 +0000 (17:19 +0000)]
MASTER_SITES -> SITES

13 months agomention that SITE_BACKUP won't work transparently until we completely
espie [Thu, 7 Sep 2023 17:17:43 +0000 (17:17 +0000)]
mention that SITE_BACKUP won't work transparently until we completely
get rid of MASTER_SITES.

13 months agobeyond libtool
espie [Thu, 7 Sep 2023 17:15:29 +0000 (17:15 +0000)]
beyond libtool

13 months agodocument EVP_MD_nid(3) and EVP_MD_name(3)
schwarze [Thu, 7 Sep 2023 16:32:41 +0000 (16:32 +0000)]
document EVP_MD_nid(3) and EVP_MD_name(3)

13 months agoimprove the descriptions of most functions
schwarze [Thu, 7 Sep 2023 15:57:04 +0000 (15:57 +0000)]
improve the descriptions of most functions

13 months agodefault value for PORTHOME (todo: add it as diagnostic)
espie [Thu, 7 Sep 2023 15:28:48 +0000 (15:28 +0000)]
default value for PORTHOME (todo: add it as diagnostic)

13 months agodon't share patches lightly
espie [Thu, 7 Sep 2023 15:23:00 +0000 (15:23 +0000)]
don't share patches lightly

13 months agoeven though it's annotated, users don't see .Cm, so note we're talking
espie [Thu, 7 Sep 2023 15:12:38 +0000 (15:12 +0000)]
even though it's annotated, users don't see .Cm, so note we're talking
about the target since 'package' is used all over the place.

13 months agoSplit two new manual pages EVP_MD_nid(3) and EVP_MD_CTX_ctrl(3)
schwarze [Thu, 7 Sep 2023 14:22:11 +0000 (14:22 +0000)]
Split two new manual pages EVP_MD_nid(3) and EVP_MD_CTX_ctrl(3)
out of the large EVP_DigestInit(3).  No text change.

13 months agoTreat consecutive paragraph indicators as different paragraphs
tobhe [Thu, 7 Sep 2023 11:17:32 +0000 (11:17 +0000)]
Treat consecutive paragraph indicators as different paragraphs
Consecutive empty lines count toward the same state, so there're
2x states (to get in and out). ^L and .PP are counted as text,
hitting those in the text should be treated as getting out of a
paragraph and then getting in.

From Walter Alejandro Iglesias and Zhihao Yuan in nvi2
ok bluhm@

13 months agoUse DECSLRM and DECFRA on terminals pretending to be VT520 or VT525 as
nicm [Thu, 7 Sep 2023 10:21:46 +0000 (10:21 +0000)]
Use DECSLRM and DECFRA on terminals pretending to be VT520 or VT525 as
well as VT420.

13 months agopf(4) ignores 'keep state' and 'nat-to' actions for unsolicited
sashan [Thu, 7 Sep 2023 09:59:43 +0000 (09:59 +0000)]
pf(4) ignores 'keep state' and 'nat-to' actions for unsolicited
icmp error responses. Fix tightens rule matching logic so icmp
error responses no longer match 'keep state' rule. In typical
scenarios icmp errors (if solicited) should match existing state.
The change is going to bite firewalls which deal with asymmetric
routes. In those cases the 'keep state' action should be relaxed
to sloppy or new 'no state' rule to explicitly match icmp
errors should be added.

The issue has been reported by Peter J. Philip (pjp _at_ delphinusdns.org).

Discussed with bluhm@ and florian@

OK bluhm@

14 months agoAccept 65 for VT525 as well.
nicm [Thu, 7 Sep 2023 07:19:21 +0000 (07:19 +0000)]
Accept 65 for VT525 as well.

14 months agoconvert to ansi function decl
jsg [Thu, 7 Sep 2023 06:32:24 +0000 (06:32 +0000)]
convert to ansi function decl

14 months agoregen
daniel [Thu, 7 Sep 2023 02:12:07 +0000 (02:12 +0000)]
regen

14 months agoadd Realtek 8852AE
daniel [Thu, 7 Sep 2023 02:11:26 +0000 (02:11 +0000)]
add Realtek 8852AE

ok kevlo@

14 months agomention ConnectX-6 Dx and ConnectX-6 Lx
jsg [Thu, 7 Sep 2023 01:45:53 +0000 (01:45 +0000)]
mention ConnectX-6 Dx and ConnectX-6 Lx

14 months agomatch on Mellanox ConnectX-6 Lx
jsg [Thu, 7 Sep 2023 01:43:46 +0000 (01:43 +0000)]
match on Mellanox ConnectX-6 Lx
from and tested by Olivier Croquin
ok dlg@

14 months agoregen
jsg [Thu, 7 Sep 2023 01:41:42 +0000 (01:41 +0000)]
regen

14 months agoadd Mellanox ConnectX-6 Lx
jsg [Thu, 7 Sep 2023 01:41:09 +0000 (01:41 +0000)]
add Mellanox ConnectX-6 Lx
from Olivier Croquin

14 months agoFix missing function declarations to let mkhybrid build with clang-16
jca [Thu, 7 Sep 2023 01:08:36 +0000 (01:08 +0000)]
Fix missing function declarations to let mkhybrid build with clang-16

ok millert@

14 months agoregen
jsg [Wed, 6 Sep 2023 23:47:51 +0000 (23:47 +0000)]
regen

14 months agoadd a Navi 32 device id
jsg [Wed, 6 Sep 2023 23:47:14 +0000 (23:47 +0000)]
add a Navi 32 device id

747e rev c8 is Radeon RX 7800 XT
747e rev ff is Radeon RX 7700 XT
found in AMD Software: Adrenalin Edition 23.9.1

14 months agoregression test for override of subsystem in match blocks
djm [Wed, 6 Sep 2023 23:36:09 +0000 (23:36 +0000)]
regression test for override of subsystem in match blocks

14 months agoallow override of Sybsystem directives in sshd Match blocks
djm [Wed, 6 Sep 2023 23:35:35 +0000 (23:35 +0000)]
allow override of Sybsystem directives in sshd Match blocks

14 months agoallocate the subsystems array as necessary and remove the fixed limit of
djm [Wed, 6 Sep 2023 23:26:37 +0000 (23:26 +0000)]
allocate the subsystems array as necessary and remove the fixed limit of
subsystems. Saves a few kb of memory in the server and makes it more like
the other options.

14 months agopreserve quoting of Subsystem commands and arguments. This may change
djm [Wed, 6 Sep 2023 23:23:53 +0000 (23:23 +0000)]
preserve quoting of Subsystem commands and arguments. This may change
behaviour of exotic configurations, but the most common subsystem
configuration (sftp-server) is unlikely to be affected.

14 months agodowngrade duplicate Subsystem directives from being a fatal error
djm [Wed, 6 Sep 2023 23:21:36 +0000 (23:21 +0000)]
downgrade duplicate Subsystem directives from being a fatal error
to being a debug message to match behaviour with just about all other
directives.

14 months agohandle cr+lf (instead of just cr) in sshsig signature files
djm [Wed, 6 Sep 2023 23:18:15 +0000 (23:18 +0000)]
handle cr+lf (instead of just cr) in sshsig signature files

14 months agopoint GH_* to DIST_TUPLE for complicated stuff
espie [Wed, 6 Sep 2023 22:28:50 +0000 (22:28 +0000)]
point GH_* to DIST_TUPLE for complicated stuff
remove description of MTREE_FILE that was removed a few years ago

14 months agoROACH_URL and ROACH_SITES, to help portroach figure out the new things.
espie [Wed, 6 Sep 2023 21:14:43 +0000 (21:14 +0000)]
ROACH_URL and ROACH_SITES, to help portroach figure out the new things.

14 months agoCorrect error message: vionet -> vioblk. No functional change.
dv [Wed, 6 Sep 2023 19:27:54 +0000 (19:27 +0000)]
Correct error message: vionet -> vioblk. No functional change.

14 months agovmd(8): clean up struct ioinfo.
dv [Wed, 6 Sep 2023 19:26:39 +0000 (19:26 +0000)]
vmd(8): clean up struct ioinfo.

In prep for fixing some vioblk device issues, simplify the ioinfo
struct by dropping members that aren't needed.

ok mlarkin@

14 months agoMark EVP_CIPHER_set_asn1_iv() and EVP_CIPHER_get_asn1_iv() as intentionally
schwarze [Wed, 6 Sep 2023 16:26:49 +0000 (16:26 +0000)]
Mark EVP_CIPHER_set_asn1_iv() and EVP_CIPHER_get_asn1_iv() as intentionally
undocumented because they are unused outside libcrypto according
to codesearch.debian.net and should probably not be public: they seem
hardly useful even for implementing custom EVP_CIPHER algorithms.

tb@ came to similar conclusions regarding these two functions.

14 months agominimal linting, no output change: .Ed with an argument;
schwarze [Wed, 6 Sep 2023 16:03:29 +0000 (16:03 +0000)]
minimal linting, no output change: .Ed with an argument;
stray .Pp before .It; new sentence, new line; trailing whitespace

14 months agoInitialize afi & safi to zero
job [Wed, 6 Sep 2023 15:53:07 +0000 (15:53 +0000)]
Initialize afi & safi to zero

OK tb@

14 months agoAvoid use-of-uninitialized in i2r_IPAddrBlocks()
tb [Wed, 6 Sep 2023 15:32:54 +0000 (15:32 +0000)]
Avoid use-of-uninitialized in i2r_IPAddrBlocks()

Reported by Viktor Szakats in
https://github.com/libressl/portable/issues/910

ok job

14 months agoreflect new reality
espie [Wed, 6 Sep 2023 15:02:51 +0000 (15:02 +0000)]
reflect new reality

14 months agoUse casts to force two function pointers assignements and fix build with clang-16
jca [Wed, 6 Sep 2023 15:02:32 +0000 (15:02 +0000)]
Use casts to force two function pointers assignements and fix build with clang-16

"looks fine to me" robert@, ok kettenis@

14 months agobsd.port.mk.5: fix markup of NO_ARCH variable
caspar [Wed, 6 Sep 2023 13:33:46 +0000 (13:33 +0000)]
bsd.port.mk.5: fix markup of NO_ARCH variable

OK kn@ schwarze@

14 months agoexplicitly cast ULLONG_MAX to double when comparing to a double
robert [Wed, 6 Sep 2023 12:45:19 +0000 (12:45 +0000)]
explicitly cast ULLONG_MAX to double when comparing to a double

ok krw@

14 months agoCorrect the RETURN VALUES of OBJ_add_object(3).
schwarze [Wed, 6 Sep 2023 12:26:59 +0000 (12:26 +0000)]
Correct the RETURN VALUES of OBJ_add_object(3).
The text was misleading before and after the improvement
in obj_dat.c rev. 1.61.  The way i'm fixing the documentation
here takes that improvement into account.

Also add a CAVEATS section about adding incomplete objects.

14 months agoUse -std=gnu89 to fix the build with clang-16
jca [Wed, 6 Sep 2023 12:15:30 +0000 (12:15 +0000)]
Use -std=gnu89 to fix the build with clang-16

This is ancient GNU software that tends to break whenever clang adds
more warnings about deprecated features in new languages versions or
turns them into errors.  Using -std=gnu89 (the defaults for base-gcc)
for those packages means we'll probably avoid most new warnings, errors,
and possible miscompilations when updating clang.

ok robert@

14 months agoregen
jsg [Wed, 6 Sep 2023 12:08:54 +0000 (12:08 +0000)]
regen

14 months agobe more specific in describing the magic behind EXTRACT_CASES
espie [Wed, 6 Sep 2023 12:08:31 +0000 (12:08 +0000)]
be more specific in describing the magic behind EXTRACT_CASES

14 months agoadd Intel Optane SSD P1600X
jsg [Wed, 6 Sep 2023 12:07:54 +0000 (12:07 +0000)]
add Intel Optane SSD P1600X
from Andreas Bartelt

14 months agoremove uneeded function decls
jsg [Wed, 6 Sep 2023 11:53:56 +0000 (11:53 +0000)]
remove uneeded function decls
ok tb@

14 months agoBuild with -std=gnu89 to fix the build with clang-16
jca [Wed, 6 Sep 2023 11:49:11 +0000 (11:49 +0000)]
Build with -std=gnu89 to fix the build with clang-16

This is ancient GNU software that tends to break whenever clang adds
more warnings about deprecated features in new languages versions or
turns them into errors.  Using -std=gnu89 (the defaults for base-gcc)
for those packages means we'll probably avoid most new warnings, errors,
and possible miscompilations when updating clang.

This fixes the build of libiberty and texinfo with clang-16.

ok robert@

14 months agonits
espie [Wed, 6 Sep 2023 11:47:36 +0000 (11:47 +0000)]
nits

14 months agoUse shared net lock for ip_send() and ip6_send().
bluhm [Wed, 6 Sep 2023 11:09:43 +0000 (11:09 +0000)]
Use shared net lock for ip_send() and ip6_send().

When called with NULL options, ip_output() and ip6_output() are MP
safe.  Convert exclusive to shared net lock in send dispatch.

OK mpi@

14 months agouse ansi function decls
jsg [Wed, 6 Sep 2023 11:08:00 +0000 (11:08 +0000)]
use ansi function decls

14 months agouse ansi function decls
jsg [Wed, 6 Sep 2023 11:03:30 +0000 (11:03 +0000)]
use ansi function decls

14 months agoAdd missing <sys/time.h> include for timespecsub()
claudio [Wed, 6 Sep 2023 09:52:26 +0000 (09:52 +0000)]
Add missing <sys/time.h> include for timespecsub()

14 months agodocument ERRORS better
espie [Wed, 6 Sep 2023 09:50:45 +0000 (09:50 +0000)]
document ERRORS better

14 months agoRemove -mabi=elfv2 option. This is the default for OpenBSD and clang 16
kettenis [Wed, 6 Sep 2023 09:12:49 +0000 (09:12 +0000)]
Remove -mabi=elfv2 option.  This is the default for OpenBSD and clang 16
generates a (spurious) error about it in certain contexts.  This is fixed
in later versions (see https://reviews.llvm.org/D156351) but it is easier
to just drop the option.

ok miod@, jsg@

14 months agoremove doubled entry in config.h.in
sthen [Wed, 6 Sep 2023 09:09:57 +0000 (09:09 +0000)]
remove doubled entry in config.h.in

14 months agoregen
sthen [Wed, 6 Sep 2023 09:08:58 +0000 (09:08 +0000)]
regen

14 months agoremove extra blank line to reduce changes to upstream in a locally-patched file
sthen [Wed, 6 Sep 2023 09:08:30 +0000 (09:08 +0000)]
remove extra blank line to reduce changes to upstream in a locally-patched file

14 months agowhitespace fixes, problem with util/tube.c pointed out by jsg (probably
sthen [Wed, 6 Sep 2023 09:08:04 +0000 (09:08 +0000)]
whitespace fixes, problem with util/tube.c pointed out by jsg (probably
introduced by the diff/patch process I use to avoid stomping on the local
changes in updates)

14 months agouse ansi function decls
jsg [Wed, 6 Sep 2023 05:54:07 +0000 (05:54 +0000)]
use ansi function decls

14 months agoremove unused variable
jsg [Wed, 6 Sep 2023 05:04:07 +0000 (05:04 +0000)]
remove unused variable

14 months agoremove unused variable
jsg [Wed, 6 Sep 2023 05:00:37 +0000 (05:00 +0000)]
remove unused variable

14 months agoadd void to function decls with no args
jsg [Wed, 6 Sep 2023 04:57:28 +0000 (04:57 +0000)]
add void to function decls with no args

14 months agoremove unused variable
jsg [Wed, 6 Sep 2023 03:51:20 +0000 (03:51 +0000)]
remove unused variable

14 months agovmm(4)/vmd(8): include pending interrupt in vm_run_parmams.
dv [Wed, 6 Sep 2023 03:35:57 +0000 (03:35 +0000)]
vmm(4)/vmd(8): include pending interrupt in vm_run_parmams.

To remove an ioctl(2) from the vcpu thread hotpath in vmd(8), add
a flag in the vm_run_params structure to indicate if there's another
interrupt pending. This reduces latency in vcpu work related to
i/o as we save a trip into the kernel just to flip the interrupt
pending flag on or off.

Tested by phessler@, mbuhl@, stsp@, and Mischa Peters.

ok mlarkin@

14 months agoremove unused variable
jsg [Wed, 6 Sep 2023 03:17:32 +0000 (03:17 +0000)]
remove unused variable

14 months agoclockintr: replace u_int with standard types
cheloha [Wed, 6 Sep 2023 02:33:18 +0000 (02:33 +0000)]
clockintr: replace u_int with standard types

The clockintr code already uses uint64_t everywhere, so we may as well
be consistent: replace u_int with uint32_t everywhere it is trivial to
do so; leave the sysctl(2) hook and ddb(4) code alone for now.

Suggested by mpi@.

ok mpi@

14 months agoclockintr: clockintr_establish: change first argument to a cpu_info pointer
cheloha [Wed, 6 Sep 2023 02:09:58 +0000 (02:09 +0000)]
clockintr: clockintr_establish: change first argument to a cpu_info pointer

All CPUs control a single clockintr_queue.  clockintr_establish()
callers don't need to know about the underlying clockintr_queue.
Accepting a cpu_info pointer as argument simplifies the API.

From mpi@.

ok mpi@

14 months agorevert disabling warnings for zlib on clang >= 15
jsg [Wed, 6 Sep 2023 01:47:36 +0000 (01:47 +0000)]
revert disabling warnings for zlib on clang >= 15
no longer needed with zlib 1.3
ok tb@

14 months agoDISNAME -> DISTNAME
jsg [Tue, 5 Sep 2023 23:45:53 +0000 (23:45 +0000)]
DISNAME -> DISTNAME

14 months agoAccording to the C11 standard, char32_t and char16_t are not part
schwarze [Tue, 5 Sep 2023 23:16:01 +0000 (23:16 +0000)]
According to the C11 standard, char32_t and char16_t are not part
of the C language but are part of the C library and have to be
declared in <uchar.h> - see paragraph 7.28.2.

In stark contrast, according to the C++11 standard, char32_t and char16_t
are part of the C++ language, namely, keywords - see paragraph 2.12.1.
Consequently, they must not be declared in a header file.

To resolve this vile contradiction, use the predefined macro __cplusplus
to find out which language is in use for the current compilation unit -
see C11 paragraph 6.10.8.3 and C++11 paragraph 16.8.1.

Reminded of the problem by naddy@.
OK naddy@ who tested in make build / make release.
Looks reasonable to millert@.

14 months agoclockintr: remove clockintr_expiration()
cheloha [Tue, 5 Sep 2023 22:41:14 +0000 (22:41 +0000)]
clockintr: remove clockintr_expiration()

With the introduction of clockintr_advance_random(), this interface is
now unused.  Remove it.

Suggested by mpi@.

Thread: https://marc.info/?l=openbsd-tech&m=169392340028978&w=2

ok mpi@ mlarkin@

14 months agoclockintr: remove clockintr_nsecuptime()
cheloha [Tue, 5 Sep 2023 22:29:28 +0000 (22:29 +0000)]
clockintr: remove clockintr_nsecuptime()

With the introduction of clockintr_advance_random(), this interface is
now unused.  Remove it.

Suggested by mpi@.

Thread: https://marc.info/?l=openbsd-tech&m=169392340028978&w=2

ok mpi@ mlarkin@

14 months agoclockintr: add clockintr_advance_random()
cheloha [Tue, 5 Sep 2023 22:25:41 +0000 (22:25 +0000)]
clockintr: add clockintr_advance_random()

Add clockintr_advance_random().  Its sole purpose is to simplify the
implementation of statclock's pseudorandom period.

Ideally, nothing else will use it and we will get rid of it and the
pseudorandom statclock period at some point in the near future.

Suggested by mpi@.

Thread: https://marc.info/?l=openbsd-tech&m=169392340028978&w=2

ok mpi@ mlarkin@

14 months agogithub.io is https
espie [Tue, 5 Sep 2023 16:20:30 +0000 (16:20 +0000)]
github.io is https
zap the dot so that dumb cut&paste works

14 months agoLog a dummy "<unknown>" IP address in the unlikely event that genameinfo(3) fails
jca [Tue, 5 Sep 2023 16:01:58 +0000 (16:01 +0000)]
Log a dummy "<unknown>" IP address in the unlikely event that genameinfo(3) fails

clang-16 warning reported by robert@, ok tb@ millert@

14 months agoFix indentation, found with -Wmisleading-indentation.
florian [Tue, 5 Sep 2023 15:46:22 +0000 (15:46 +0000)]
Fix indentation, found with -Wmisleading-indentation.

Already commited upstream.

14 months agoPrevent warnings from -Wmissing-prototypes
florian [Tue, 5 Sep 2023 15:45:51 +0000 (15:45 +0000)]
Prevent warnings from -Wmissing-prototypes

https://github.com/NLnetLabs/unbound/pull/931

14 months agoFix built.
florian [Tue, 5 Sep 2023 15:44:39 +0000 (15:44 +0000)]
Fix built.

The api changed to handle cookies and extended error codes.

Passing in NULL for config_file disables cookie handling so we do not
need to pass a valid comm_reply, NULL will do.

14 months agosync to unbound 1.18.0; heavy lifting by sthen
florian [Tue, 5 Sep 2023 15:44:01 +0000 (15:44 +0000)]
sync to unbound 1.18.0; heavy lifting by sthen

14 months agofix mismatching declaration of argument with mismatched bounds
robert [Tue, 5 Sep 2023 15:37:07 +0000 (15:37 +0000)]
fix mismatching declaration of argument with mismatched bounds

ok tb@

14 months agofunction definitions without prototypes are deprecated, so shut clang16 up
robert [Tue, 5 Sep 2023 15:33:40 +0000 (15:33 +0000)]
function definitions without prototypes are deprecated, so shut clang16 up

ok kettenis@

14 months agoadd a BUGS section warning about the creation of incomplete objects
schwarze [Tue, 5 Sep 2023 15:01:39 +0000 (15:01 +0000)]
add a BUGS section warning about the creation of incomplete objects

14 months agoImprove error handling in OBJ_add_object()
tb [Tue, 5 Sep 2023 14:59:00 +0000 (14:59 +0000)]
Improve error handling in OBJ_add_object()

There is no need for a helper function to obfuscate lh_ADDED_OBJ_new().
Just call the real thing directly.

Adding an object with a NID of NID_undef basically amounts to disabling
a built-in OID. It does so in an incoherent fashion and the caller can't
easily tell success from failure of the operation. Arguably the result is
a corrupted objects table.

Let's not allow adding such an object in an attempt at keeping things
slightly more coherent.

Issue noted and initial diff by schwarze while writing documentation

ok schwarze