openbsd
19 months agoMan page for ngbe(4).
kevlo [Fri, 31 Mar 2023 08:20:58 +0000 (08:20 +0000)]
Man page for ngbe(4).

ok miod@

19 months agongbe(4), a driver for Wangxun WX1860 series Gigabit Ethernet devices.
kevlo [Fri, 31 Mar 2023 08:19:41 +0000 (08:19 +0000)]
ngbe(4), a driver for Wangxun WX1860 series Gigabit Ethernet devices.
Written based on the vendor driver for Linux.
Thanks to WangXun for relicensing their vendor driver to ISC.

Special thanks to miod@ for reviewing and providing valuable input.

ok miod@

19 months agoregen
kevlo [Fri, 31 Mar 2023 08:17:00 +0000 (08:17 +0000)]
regen

19 months agoAdd "Beijing WangXun Technology" vendor and WX1860 series NICs.
kevlo [Fri, 31 Mar 2023 08:16:30 +0000 (08:16 +0000)]
Add "Beijing WangXun Technology" vendor and WX1860 series NICs.

ok miod@

19 months agoGuard use of GROUP_EC2N with #ifndef OPENSSL_NO_EC2M
tb [Fri, 31 Mar 2023 07:28:46 +0000 (07:28 +0000)]
Guard use of GROUP_EC2N with #ifndef OPENSSL_NO_EC2M

This allows compiling isakmpd with a libcrypto that has binary field
support removed. Leave the enum value itself unguarded on claudio's
request.

ok beck claudio jsing

19 months agoAdd a regress for the recent BIO_new_NDEF() write after free
tb [Fri, 31 Mar 2023 06:07:44 +0000 (06:07 +0000)]
Add a regress for the recent BIO_new_NDEF() write after free

This is a simple reproducer for a write after free that avoids all the
mess with CMS, PKCS7 and SMIME. This now mostly allows ASAN to check
that the memory handling in this marvellous function is correct.

19 months agoExplicitly ignore return from waitpid here too.
dtucker [Fri, 31 Mar 2023 05:56:36 +0000 (05:56 +0000)]
Explicitly ignore return from waitpid here too.

19 months agoExplictly ignore return codes where we don't check them. From Dmitry
dtucker [Fri, 31 Mar 2023 04:45:08 +0000 (04:45 +0000)]
Explictly ignore return codes where we don't check them.  From Dmitry
Belyavskiy via github PR#238, ok djm@

19 months agoReturn immediately from get_sock_port if sock <0 so we don't call
dtucker [Fri, 31 Mar 2023 04:42:29 +0000 (04:42 +0000)]
Return immediately from get_sock_port if sock <0 so we don't call
getsockname on a negative FD.  From Coverity CID 291840, ok djm@

19 months agodon't leak arg2 on parse_pubkey_algos error path; ok dtucker@
djm [Fri, 31 Mar 2023 04:23:02 +0000 (04:23 +0000)]
don't leak arg2 on parse_pubkey_algos error path; ok dtucker@

19 months agoclamp max number of GSSAPI mechanisms to 2048; ok dtucker
djm [Fri, 31 Mar 2023 04:22:27 +0000 (04:22 +0000)]
clamp max number of GSSAPI mechanisms to 2048; ok dtucker

19 months agodon't print key if printing hostname failed; with/ok dtucker@
djm [Fri, 31 Mar 2023 04:21:56 +0000 (04:21 +0000)]
don't print key if printing hostname failed; with/ok dtucker@

19 months agoremove redundant test
djm [Fri, 31 Mar 2023 04:04:15 +0000 (04:04 +0000)]
remove redundant test

19 months agodon't attempt to decode a ridiculous number of attributes;
djm [Fri, 31 Mar 2023 04:00:37 +0000 (04:00 +0000)]
don't attempt to decode a ridiculous number of attributes;
harmless because of bounds elsewhere, but better to be explicit

19 months agoOnly send the used portion of struct idm_req in imsgs from the ldapclient
jmatthew [Fri, 31 Mar 2023 03:38:26 +0000 (03:38 +0000)]
Only send the used portion of struct idm_req in imsgs from the ldapclient
process to the main process. This significantly reduces memory usage when
updating larger directories.

ok aisha@

19 months agoremove unused variable; prompted by Coverity CID 291879
djm [Fri, 31 Mar 2023 03:22:49 +0000 (03:22 +0000)]
remove unused variable; prompted by Coverity CID 291879

19 months agoDocument i226.
kevlo [Fri, 31 Mar 2023 02:20:21 +0000 (02:20 +0000)]
Document i226.

From Brad.

19 months agodrm/amdkfd: Fix the memory overrun
jsg [Fri, 31 Mar 2023 02:16:10 +0000 (02:16 +0000)]
drm/amdkfd: Fix the memory overrun

From Ma Jun
8c31b663edc1cc5eb5c82282ab6ca99c69d1d942 in linux-6.1.y/6.1.22
4cc16d64b6cdb179a26fb389cae9dce788e88f5d in mainline linux

19 months agodrm/amdkfd: add GC 11.0.4 KFD support
jsg [Fri, 31 Mar 2023 02:14:03 +0000 (02:14 +0000)]
drm/amdkfd: add GC 11.0.4 KFD support

From Yifan Zhang
132f1d39439142547d9d5e45d7744d375dd21fdc in linux-6.1.y/6.1.22
88c21c2b56aa21dd34290d43ada74033dc3bfe35 in mainline linux

19 months agodrm/amdkfd: Fix the warning of array-index-out-of-bounds
jsg [Fri, 31 Mar 2023 02:12:21 +0000 (02:12 +0000)]
drm/amdkfd: Fix the warning of array-index-out-of-bounds

From Ma Jun
0ac954ec7f6c6dd6b7e94340599ba4b788d056d5 in linux-6.1.y/6.1.22
c0cc999f3c32e65a7c88fb323893ddf897b24488 in mainline linux

19 months agodrm/amdkfd: introduce dummy cache info for property asic
jsg [Fri, 31 Mar 2023 02:09:05 +0000 (02:09 +0000)]
drm/amdkfd: introduce dummy cache info for property asic

From Prike Liang
a5528973c676dad09a1af25cd49e4312238d1428 in linux-6.1.y/6.1.22
fd72e2cb2f9dd2734e8013b3e185a21f0d605d3e in mainline linux

19 months agodrm/amdgpu: reposition the gpu reset checking for reuse
jsg [Fri, 31 Mar 2023 02:07:08 +0000 (02:07 +0000)]
drm/amdgpu: reposition the gpu reset checking for reuse

From Tim Huang
75e10d7fb97906ddb641c7b09773a91693570f63 in linux-6.1.y/6.1.22
aaee0ce460b954e08b6e630d7e54b2abb672feb8 in mainline linux

19 months agodrm/amdgpu: skip ASIC reset for APUs when go to S4
jsg [Fri, 31 Mar 2023 02:04:27 +0000 (02:04 +0000)]
drm/amdgpu: skip ASIC reset for APUs when go to S4

From Tim Huang
9f7e1dd835ec834fb147a7725419497f0b0d83a7 in linux-6.1.y/6.1.22
b589626674de94d977e81c99bf7905872b991197 in mainline linux

19 months agodrm/i915: Preserve crtc_state->inherited during state clearing
jsg [Fri, 31 Mar 2023 02:02:47 +0000 (02:02 +0000)]
drm/i915: Preserve crtc_state->inherited during state clearing

From Ville Syrjala
220da3bf1fc335ae25b181d6bedcfc63efef6ccc in linux-6.1.y/6.1.22
3a84f2c6c9558c554a90ec26ad25df92fc5e05b7 in mainline linux

19 months agodrm/i915/active: Fix missing debug object activation
jsg [Fri, 31 Mar 2023 02:01:00 +0000 (02:01 +0000)]
drm/i915/active: Fix missing debug object activation

From Nirmoy Das
c355945957ef5e9bb05e0554fe4a6f92b0fcaf36 in linux-6.1.y/6.1.22
e92eb246feb9019b0b137706c934b8891cdfe3c2 in mainline linux

19 months agodrm/amdgpu/nv: Apply ASPM quirk on Intel ADL + AMD Navi
jsg [Fri, 31 Mar 2023 01:59:24 +0000 (01:59 +0000)]
drm/amdgpu/nv: Apply ASPM quirk on Intel ADL + AMD Navi

From Kai-Heng Feng
ed6364fb7c407ca53447d8b0723a61d320bcbae9 in linux-6.1.y/6.1.22
2b072442f4962231a8516485012bb2d2551ef2fe in mainline linux

19 months agodrm/amd/display: fix wrong index used in dccg32_set_dpstreamclk
jsg [Fri, 31 Mar 2023 01:56:10 +0000 (01:56 +0000)]
drm/amd/display: fix wrong index used in dccg32_set_dpstreamclk

From Hersen Wu
c590fce42c2117693bd0ee6646b3fc16a8f842ae in linux-6.1.y/6.1.22
4c94e57c258cb7800aa5f3a9d9597d91291407a9 in mainline linux

19 months agodrm/amd: Fix initialization mistake for NBIO 7.3.0
jsg [Fri, 31 Mar 2023 01:54:30 +0000 (01:54 +0000)]
drm/amd: Fix initialization mistake for NBIO 7.3.0

From Mario Limonciello
a0e39cdddc155926fc3c0395636b7c80e55e66a1 in linux-6.1.y/6.1.22
1717cc5f2962a4652c76ed3858b499ccae6c277c in mainline linux

19 months agodrm/amdgpu: Fix call trace warning and hang when removing amdgpu device
jsg [Fri, 31 Mar 2023 01:53:07 +0000 (01:53 +0000)]
drm/amdgpu: Fix call trace warning and hang when removing amdgpu device

From lyndonli
f06b902511ea05526f405ee64da54a8313d91831 in linux-6.1.y/6.1.22
93bb18d2a873d2fa9625c8ea927723660a868b95 in mainline linux

19 months agodrm/amd/display: Update clock table to include highest clock setting
jsg [Fri, 31 Mar 2023 01:51:13 +0000 (01:51 +0000)]
drm/amd/display: Update clock table to include highest clock setting

From Swapnil Patel
b66804fc7e21587431360af1dbcc1d9145237b7a in linux-6.1.y/6.1.22
2d99a7ec25cf456cd3680eb314d6454138e5aa64 in mainline linux

19 months agodrm/amd/display: Set dcn32 caps.seamless_odm
jsg [Fri, 31 Mar 2023 01:49:17 +0000 (01:49 +0000)]
drm/amd/display: Set dcn32 caps.seamless_odm

From Hersen Wu
612cf2495ec6cf5834e8b4a70f599190c35cf8c8 in linux-6.1.y/6.1.22
f9537b1fa7fb51c2162bc15ce469cbbf1ca0fbfe in mainline linux

19 months agodrm/i915/gt: perform uc late init after probe error injection
jsg [Fri, 31 Mar 2023 01:47:06 +0000 (01:47 +0000)]
drm/i915/gt: perform uc late init after probe error injection

From Andrzej Hajda
6e516595e88670baf275701893fd43e0a454f7d0 in linux-6.1.y/6.1.22
150784f9285e656373cf3953ef4a7663f1e1a0f2 in mainline linux

19 months agodrm/i915/guc: Fix missing ecodes
jsg [Fri, 31 Mar 2023 01:44:03 +0000 (01:44 +0000)]
drm/i915/guc: Fix missing ecodes

From John Harrison
be8c6ad6b16e6181510e35c53928381f0f39640a in linux-6.1.y/6.1.22
8df23e4c4f72f4e201c28e6fb0a67e2dbf30628a in mainline linux

19 months agodrm/i915/guc: Rename GuC register state capture node to be more obvious
jsg [Fri, 31 Mar 2023 01:42:14 +0000 (01:42 +0000)]
drm/i915/guc: Rename GuC register state capture node to be more obvious

From John Harrison
d2b9357d3da3f8054a47eef04c8ef361608b243e in linux-6.1.y/6.1.22
583ebae783b8241a30581c084ad6226051b594c5 in mainline linux

19 months agodrm/i915/fbdev: lock the fbdev obj before vma pin
jsg [Fri, 31 Mar 2023 01:39:50 +0000 (01:39 +0000)]
drm/i915/fbdev: lock the fbdev obj before vma pin

From Tejas Upadhyay
9595d71b2a274fe365240b53ce5d03c071c3e6e0 in linux-6.1.y/6.1.22
ed00eba03474adbf525ff03d69705d8c78b76456 in mainline linux

19 months agodrm/i915: Print return value on error
jsg [Fri, 31 Mar 2023 01:38:10 +0000 (01:38 +0000)]
drm/i915: Print return value on error

From Nirmoy Das
b6375c5ecd8c790e381ee3f9baeda8c9e5da4a45 in linux-6.1.y/6.1.22
20c68127e8e9d7899001c47465d0b79581f5fdc1 in mainline linux

19 months agodrm/amd/display: Fix DP MST sinks removal issue
jsg [Fri, 31 Mar 2023 01:36:11 +0000 (01:36 +0000)]
drm/amd/display: Fix DP MST sinks removal issue

From Cruise Hung
ee9caccc5e5cc1092baf6fb645525bba668b01c1 in linux-6.1.y/6.1.22
cbd6c1b17d3b42b7935526a86ad5f66838767d03 in mainline linux

19 months agodrm/amd/display: Remove OTG DIV register write for Virtual signals.
jsg [Fri, 31 Mar 2023 01:34:21 +0000 (01:34 +0000)]
drm/amd/display: Remove OTG DIV register write for Virtual signals.

From Saaem Rizvi
75eb69023ba30076dba2df6a3e0f9f51095a237b in linux-6.1.y/6.1.22
709671ffb15dcd1b4f6afe2a9d8c67c7c4ead4a1 in mainline linux

19 months agodrm/amd/display: fix k1 k2 divider programming for phantom streams
jsg [Fri, 31 Mar 2023 01:32:38 +0000 (01:32 +0000)]
drm/amd/display: fix k1 k2 divider programming for phantom streams

From Aurabindo Pillai
0ac86f7dda2b1f895304919ee9035c170a6af419 in linux-6.1.y/6.1.22
3b214bb7185d8284d7d4c53e15127f69a375abf6 in mainline linux

19 months agodrm/amd/display: Include virtual signal to set k1 and k2 values
jsg [Fri, 31 Mar 2023 01:30:52 +0000 (01:30 +0000)]
drm/amd/display: Include virtual signal to set k1 and k2 values

From Eric Bernstein
4a36da161b7a467c884e00219bb62b645bbe74f1 in linux-6.1.y/6.1.22
368307cef69ccd9bf5511f25e58e3a103be169fb in mainline linux

19 months agoCheck fd against >=0 instead of >0 in error path. The dup could
dtucker [Fri, 31 Mar 2023 00:44:29 +0000 (00:44 +0000)]
Check fd against >=0 instead of >0 in error path.  The dup could
in theory return fd 0 although currently it doesn't in practice.
From Dmitry Belyavskiy vi github PR#238.

19 months agodrop unnecessary copy of fname; ok tb@
op [Thu, 30 Mar 2023 22:56:47 +0000 (22:56 +0000)]
drop unnecessary copy of fname; ok tb@

19 months agoUse 'char * const' instead of #define for repeated
krw [Thu, 30 Mar 2023 22:53:39 +0000 (22:53 +0000)]
Use 'char * const' instead of #define for repeated
GUID strings. Consistently use strcasecmp() when comparing
GUID's, allowing use of simple 'char *' for gt_guid.

No intentional functional change.

19 months agokeep match strings sorted
kn [Thu, 30 Mar 2023 20:07:49 +0000 (20:07 +0000)]
keep match strings sorted

19 months agoAttach Baikal-M PCIe
kn [Thu, 30 Mar 2023 20:03:32 +0000 (20:03 +0000)]
Attach Baikal-M PCIe

https://github.com/Elpitech/baikal-m-linux-kernel/search?q=bm1000-pcie
Tested on ET-101-MB

Initial diff from Slava Voronzoff
Feedback OK kettenis patrick

19 months agotabify two lines
op [Thu, 30 Mar 2023 19:01:25 +0000 (19:01 +0000)]
tabify two lines

19 months agodon't access(conffile)
op [Thu, 30 Mar 2023 19:00:02 +0000 (19:00 +0000)]
don't access(conffile)

This removes a few access(2) calls in the configuration file handling.
startupfile() now opens and return the file and to avoid surprises it
also uses a caller-provided buffer to store the filename.  This also
removes the extra adjustpath() that load() did: it has been moved to
evalfile() only.

with help, fixes and ok tb@

19 months agoi2d_ECDSA_SIG() may return a negative value in case of error.
bluhm [Thu, 30 Mar 2023 17:20:53 +0000 (17:20 +0000)]
i2d_ECDSA_SIG() may return a negative value in case of error.
Do no use this as length in iked(8) _dsa_verify_prepare().
OK tobhe@ tb@

19 months agoescape "An" in a %T call, so groff does not flag it as an error;
jmc [Thu, 30 Mar 2023 16:16:32 +0000 (16:16 +0000)]
escape "An" in a %T call, so groff does not flag it as an error;

19 months agoadjust markup of one of the builtin kill usage
op [Thu, 30 Mar 2023 16:00:47 +0000 (16:00 +0000)]
adjust markup of one of the builtin kill usage

The Op on its own line becomes part of the item body instead of the list
item itself.

OK millert@

19 months agoi2d_ECDSA_SIG() may return a negative value in case of error. Handle
bluhm [Thu, 30 Mar 2023 15:51:09 +0000 (15:51 +0000)]
i2d_ECDSA_SIG() may return a negative value in case of error.  Handle
this in ossl_ecdsa_sign() and propagate the return code.
OK jsing@ tb@

19 months agoAdd the protocol used to sync the repository to the open-metric output.
claudio [Thu, 30 Mar 2023 15:29:15 +0000 (15:29 +0000)]
Add the protocol used to sync the repository to the open-metric output.
OK tb@

19 months agoMap device tree read/write to unbreak root on softraid
kn [Thu, 30 Mar 2023 15:09:01 +0000 (15:09 +0000)]
Map device tree read/write to unbreak root on softraid

Since r1.76 "Get rid of pmap_map_early()" the FDT was mapped read-only,
but CRYPTO softraid code writes it to zero out the key.

Found and tested by me;  explanation and fix from kettenis.
OK kettenis

19 months agoRefactor extract_prefix() to first do the length checks and only then
claudio [Thu, 30 Mar 2023 14:47:25 +0000 (14:47 +0000)]
Refactor extract_prefix() to first do the length checks and only then
copy the data out.
OK tb@

19 months agoRemove needless memset() call, 'entries' variable and
krw [Thu, 30 Mar 2023 14:38:26 +0000 (14:38 +0000)]
Remove needless memset() call, 'entries' variable and
limit check in PRT_menuid_to_guid().

No functional change.

19 months agoCall bn_copy() unconditionally in BN_mul() and BN_sqr()
tb [Thu, 30 Mar 2023 14:28:56 +0000 (14:28 +0000)]
Call bn_copy() unconditionally in BN_mul() and BN_sqr()

bn_copy() does the right thing if source and target are the same, so
there is no need for an additional check.

Requested by jsing

19 months agobio_ndef: add an empty line before return
tb [Thu, 30 Mar 2023 14:23:50 +0000 (14:23 +0000)]
bio_ndef: add an empty line before return

19 months agoRework BN_exp() a bit
tb [Thu, 30 Mar 2023 14:21:10 +0000 (14:21 +0000)]
Rework BN_exp() a bit

This mostly only cleans up the mess that it was - which doesn't stand out
because of the horror that lurks in the rest of this file. It avoids
copying the partial calculation out on error and does away with some
other weirdness.

with/ok jsing

19 months agoExtra space in struct field definitions. NFC
claudio [Thu, 30 Mar 2023 13:25:23 +0000 (13:25 +0000)]
Extra space in struct field definitions. NFC

19 months agoPut the size of the pt_entry object into the struct itself.
claudio [Thu, 30 Mar 2023 12:11:18 +0000 (12:11 +0000)]
Put the size of the pt_entry object into the struct itself.

Increase the refcnt to a 32bit int and while there reorder the vpn
specific structs a bit so the IPv4 and IPv6 types are more equal.

OK tb@

19 months agoUpdate comment: RTL8139 -> TNETE2101
kevlo [Thu, 30 Mar 2023 09:24:22 +0000 (09:24 +0000)]
Update comment: RTL8139 -> TNETE2101

ok mpi@

19 months agotrailing whitespaces
op [Thu, 30 Mar 2023 08:07:07 +0000 (08:07 +0000)]
trailing whitespaces

19 months agostrncpy -> strlcpy to properly NUL-terminate the copy of the path
op [Thu, 30 Mar 2023 07:26:15 +0000 (07:26 +0000)]
strncpy -> strlcpy to properly NUL-terminate the copy of the path

otherwise paths longer than NFILEN (1024) given with -u won't
NUL-terminate `file'.

19 months agoIgnore return value from muxclient(). It normally loops without returning,
dtucker [Thu, 30 Mar 2023 07:19:50 +0000 (07:19 +0000)]
Ignore return value from muxclient().  It normally loops without returning,
but it if returns on failure we immediately exit.  Coverity CID 405050.

19 months agoreturn SSH_ERR_KEY_NOT_FOUND if the allowed_signers file is empty,
djm [Thu, 30 Mar 2023 03:05:01 +0000 (03:05 +0000)]
return SSH_ERR_KEY_NOT_FOUND if the allowed_signers file is empty,
not SSH_ERR_INTERNAL_ERROR. Also remove some dead code spotted by
Coverity; with/ok dtucker@

19 months agoRemove dead code from inside if block. The only way the if statement can
dtucker [Thu, 30 Mar 2023 00:49:37 +0000 (00:49 +0000)]
Remove dead code from inside if block.  The only way the if statement can
be true is if both dup()s fail, and in that case the tmp2 can never be set.
Coverity CID 291805, ok djm@

19 months agoChange 'type' to 'menuid' in various struct's, functions and
krw [Wed, 29 Mar 2023 19:34:49 +0000 (19:34 +0000)]
Change 'type' to 'menuid' in various struct's, functions and
variables related to gpt partitions. Makes it clear that there is
no required tie between mbr partition types and gpt partition
types.

No functional change.

19 months agoplug leak of tagpos in poptag() if loadbuffer() fails
op [Wed, 29 Mar 2023 19:09:04 +0000 (19:09 +0000)]
plug leak of tagpos in poptag() if loadbuffer() fails

19 months agoQuote possible 'none' answer as part of help text after question
kn [Wed, 29 Mar 2023 17:40:24 +0000 (17:40 +0000)]
Quote possible 'none' answer as part of help text after question

'Default IPv4 route?' takes an IP or this word, not no IP at all.
All other questions already quote their 'none', 'done', etc. answers.

No behaviour change for autoinstall(8) files, questions end after the
qestion mark and potential answers/help in parentheses comes after that.

19 months agoInstead of storing the short TAL name as repouri use the first TAL URI
claudio [Wed, 29 Mar 2023 17:03:29 +0000 (17:03 +0000)]
Instead of storing the short TAL name as repouri use the first TAL URI
for that. This is more in line with the other uses of repouri.
OK tb@

19 months agoAdd missing semicolon to properly end switch case
kn [Wed, 29 Mar 2023 16:20:17 +0000 (16:20 +0000)]
Add missing semicolon to properly end switch case

There since introduction, lucked out since it is the last case.
No functional change.

19 months agoNo need to assume a nil GUID can be found at gpt_types[0]. Just
krw [Wed, 29 Mar 2023 15:55:34 +0000 (15:55 +0000)]
No need to assume a nil GUID can be found at gpt_types[0]. Just
use uuid_create_nil().

No functional change.

19 months agoMark the struct aid name as const char * since it points to static memory.
claudio [Wed, 29 Mar 2023 14:35:38 +0000 (14:35 +0000)]
Mark the struct aid name as const char * since it points to static memory.

19 months agoSimplify code by having PRT_uuid_to_type() return -1 when
krw [Wed, 29 Mar 2023 14:20:50 +0000 (14:20 +0000)]
Simplify code by having PRT_uuid_to_type() return -1 when
no type can be found. 0 is a valid type!

No functional change.

19 months agoSwitch prefix_adjout_get and new prefix_adjout_first to use a pt_entry
claudio [Wed, 29 Mar 2023 10:46:11 +0000 (10:46 +0000)]
Switch prefix_adjout_get and new prefix_adjout_first to use a pt_entry
as argument instead of the bgpd_addr + prefixlen.

Do the same with prefix_adjout_update but leave prefix_adjout_lookup
and prefix_adjout_match since those are used by bgpctl code that does
not use pt_entry structs.

With this most of the update code no longer needs struct bgpd_addr and
pt_getaddr().
OK tb@

19 months agodrop needless global tagsfn path
op [Wed, 29 Mar 2023 10:42:34 +0000 (10:42 +0000)]
drop needless global tagsfn path

mg kept the path to the last loaded tag file in tagsfn which was used
for both the lazy loading (now removed) and as a flag to know if any
tags are currently loaded.  It's redundant and complicates the code:
just check if the tree is empty instead.

ok tb@

19 months agoRework test failure printing
tb [Wed, 29 Mar 2023 10:36:14 +0000 (10:36 +0000)]
Rework test failure printing

Make sure it's always printed to stderr. Use a wrapper for printing a
BIGNUM rather than repeating the same ugly pattern over and over again.

19 months agoDedup print functions on test failure
tb [Wed, 29 Mar 2023 07:46:40 +0000 (07:46 +0000)]
Dedup print functions on test failure

19 months agoFix printfs that escaped defensive grepping
tb [Wed, 29 Mar 2023 07:38:16 +0000 (07:38 +0000)]
Fix printfs that escaped defensive grepping

19 months agochange tagvisit (aka visit-tag-table) to immediately load the tag file
op [Wed, 29 Mar 2023 07:29:17 +0000 (07:29 +0000)]
change tagvisit (aka visit-tag-table) to immediately load the tag file

before it used to only record the path to the tag file which was loaded
on demand upon find-tag (M-.).  tagvisit did to do a stat + access dance
to know if the path was pointing to a regular, readable file and
loadtags (called lazily by find-tag) trusted those checks...

Instead, just load the tags in tagvisit and drop the lazy mechanics.

ok tb@

19 months agoDedup generate_test_triple() and generate_test_quintuple()
tb [Wed, 29 Mar 2023 07:29:11 +0000 (07:29 +0000)]
Dedup generate_test_triple() and generate_test_quintuple()

19 months agoUse more consistent names for the main test functions
tb [Wed, 29 Mar 2023 06:53:49 +0000 (06:53 +0000)]
Use more consistent names for the main test functions

19 months agoRemove one of those ugly function tables
tb [Wed, 29 Mar 2023 06:50:51 +0000 (06:50 +0000)]
Remove one of those ugly function tables

The only reason there were two of them was to avoid some pointless
comparisons. The gain is not worth the price.

19 months agoRename a few variables for readability
tb [Wed, 29 Mar 2023 06:32:53 +0000 (06:32 +0000)]
Rename a few variables for readability

19 months agoMore whitespace fixes.
jsing [Wed, 29 Mar 2023 05:34:01 +0000 (05:34 +0000)]
More whitespace fixes.

Another set of mechnical replacements for "a,b" with "a, b".

No change in generated assembly.

19 months agoWhitespace fixes.
jsing [Wed, 29 Mar 2023 05:31:43 +0000 (05:31 +0000)]
Whitespace fixes.

Mechanically replace "a,b" with "a, b".

No change to generated assembly.

19 months agoWhitespace fixes.
jsing [Wed, 29 Mar 2023 05:27:02 +0000 (05:27 +0000)]
Whitespace fixes.

Mechanically replace "a,b" with "a, b", followed with some manual
indentation clean up.

No change in generated assembly.

19 months agoUse multiple statements instead of a statement with multiple expressions.
jsing [Wed, 29 Mar 2023 05:11:37 +0000 (05:11 +0000)]
Use multiple statements instead of a statement with multiple expressions.

No change in generated assembly.

19 months agoMop up MD32_XARRAY from SHA1.
jsing [Wed, 29 Mar 2023 05:03:34 +0000 (05:03 +0000)]
Mop up MD32_XARRAY from SHA1.

MD32_XARRAY (formerly SHA_XARRAY) was added as a workaround for a broken
HP C compiler (circa 1999). Clean it up to simplify the code.

No change in generated assembly.

ok miod@ tb@

19 months agoInline initial hash data values for SHA1.
jsing [Wed, 29 Mar 2023 04:24:08 +0000 (04:24 +0000)]
Inline initial hash data values for SHA1.

This follows what is done for other SHA implementations.

ok miod@ tb@

19 months agoExplicitly ignore return value from sshpkt_disconnect since we set our
dtucker [Wed, 29 Mar 2023 01:07:48 +0000 (01:07 +0000)]
Explicitly ignore return value from sshpkt_disconnect since we set our
own return value for the function.  Coverity CID 291797, ok djm@

19 months agoPlug another potential mem leak in process_put. It allocates abs_dst
dtucker [Wed, 29 Mar 2023 00:59:08 +0000 (00:59 +0000)]
Plug another potential mem leak in process_put.  It allocates abs_dst
inside a loop but only frees it on exit, so free inside the loop if
necessary.  Coverity CID 291837, ok djm@

19 months agoUse character not block devices with dd(1) like the rest
kn [Wed, 29 Mar 2023 00:25:47 +0000 (00:25 +0000)]
Use character not block devices with dd(1) like the rest

All other dd invocations in installer code, INSTALL.* instructions and
dd(1) EXAMPLES use the disk's "raw device".

19 months agofix memory leak; Coverity CID 291848, with/ok dtucker@
djm [Wed, 29 Mar 2023 00:18:35 +0000 (00:18 +0000)]
fix memory leak; Coverity CID 291848, with/ok dtucker@

19 months agoUnify variable usage in arm64 and armv7 md_installboot() with the rest
kn [Wed, 29 Mar 2023 00:16:14 +0000 (00:16 +0000)]
Unify variable usage in arm64 and armv7 md_installboot() with the rest

`_disk' (and related variables) hold disk names as "sd0" so that all else
can be constructed from it.

Fix the only two offenders across distrib/ which put start the variable
with "/dev/";  no functional change.

19 months agoProperly disable informational dd(1) messages, retain errors
kn [Tue, 28 Mar 2023 23:09:08 +0000 (23:09 +0000)]
Properly disable informational dd(1) messages, retain errors

Same as done for arm64 already

19 months agoApply changes from tzdata2023c.
millert [Tue, 28 Mar 2023 23:07:46 +0000 (23:07 +0000)]
Apply changes from tzdata2023c.
This reverts the controversial Lebanon DST change which led to a
partly-sectarian divide within the country.

19 months agomg: fix parsing of tag files with duplicate entries
tb [Tue, 28 Mar 2023 21:33:21 +0000 (21:33 +0000)]
mg: fix parsing of tag files with duplicate entries

Instead of erroring out ignore duplicates. Fixes using /var/db/libc.tags
again.

ok op

19 months agoIn pt_fill set the refcnt to its maximum value to trigger an error
claudio [Tue, 28 Mar 2023 17:47:29 +0000 (17:47 +0000)]
In pt_fill set the refcnt to its maximum value to trigger an error
if pt_ref is called on such a pt_entry. Set refcnt to 0 in pt_alloc
since the value from pt_fill is copied over.
OK tb@

19 months agoAvoid double free in isakmpd
tb [Tue, 28 Mar 2023 16:32:42 +0000 (16:32 +0000)]
Avoid double free in isakmpd

In the unlikely event that EC_KEY_check_key() in ec_init() fails,
group->ec would be freed first in ec_init() then in group_free().

Same problem was fixed in iked/dh.c r1.31 (where it originally came
from).

ok jsg mbuhl