eric [Fri, 7 Dec 2018 08:05:59 +0000 (08:05 +0000)]
Refactor certificate initialization and verification.
Factorize code duplicated in smtp_session.c and mta_session.c
Implement a simple callback interface, with proper request management
and simplified imsg protocol.
Only add the necessary parts for now.
Exisiting code path will be adapted later.
input from gilles@ sunil@
ok gilles@
tb [Fri, 7 Dec 2018 07:22:09 +0000 (07:22 +0000)]
Remove an ugly hack in the client certificate verification code that works
around broken GOST implementations. It looks like client certificates with
GOST have been completely broken since reimport of the GOST code, so no-one
is using LibreSSL this way. The client side was fixed only last week for
TLSv1.0 and TLSv1.1. This workaround is now in the way of much needed
simplifcation and cleanup, so it is time for it to go.
suggested by and ok jsing
dtucker [Fri, 7 Dec 2018 04:36:09 +0000 (04:36 +0000)]
Fix calculation of initial bandwidth limits.
Account for written bytes before the initial timer check so that the first
buffer written is accounted. Set the threshold after which the timer is
checked such that the limit starts being computed as soon as possible, ie
after the second buffer is written. This prevents an initial burst of
traffic and provides a more accurate bandwidth limit. bz#2927, ok djm.
djm [Fri, 7 Dec 2018 03:39:40 +0000 (03:39 +0000)]
only consider the ext-info-c extension during the initial KEX. It shouldn't
be sent in subsequent ones, but if it is present we should ignore it.
This prevents sshd from sending a SSH_MSG_EXT_INFO for REKEX for buggy
these clients. Reported by Jakub Jelen via bz2929; ok dtucker@
djm [Fri, 7 Dec 2018 03:33:18 +0000 (03:33 +0000)]
fix option letter pasto in previous
djm [Fri, 7 Dec 2018 03:32:26 +0000 (03:32 +0000)]
mention that the ssh-keygen -F (find host in authorized_keys) and -R
(remove host from authorized_keys) options may accept either a bare
hostname or a [hostname]:port combo. bz#2935
djm [Fri, 7 Dec 2018 02:31:20 +0000 (02:31 +0000)]
no need to allocate channels_pre/channels_post in channel_init_channels()
as we do it anyway in channel_handler_init() that we call at the end of
the function. Fix from Markus Schmidt via bz#2938
kevlo [Fri, 7 Dec 2018 01:53:20 +0000 (01:53 +0000)]
Handle 2 Tx chains in the computation of transmit power for the RTL8192EU.
While here sort vendors.
Tested by jmatthew@
ok stsp@, jmatthew@
martijn [Thu, 6 Dec 2018 20:16:04 +0000 (20:16 +0000)]
Add support for "-" as an input file for stdin as per POSIX.
Simplify the code by allowing usage of stdin with the -i flag by pushing
the result to stdout, so filters and in place editing can be combined.
OK millert@
guenther [Thu, 6 Dec 2018 18:59:31 +0000 (18:59 +0000)]
Core files with >65535 sections have to use PN_XNUM and a section header
to pass the real count, with a minimal .shstrtab segment for consistency.
Also, add support for PN_XNUM to readelf.
problem reported and testing by claudio@
ok kettenis@
tedu [Thu, 6 Dec 2018 17:45:14 +0000 (17:45 +0000)]
add -not as a sh friendly alias for !.
ok millert
tedu [Thu, 6 Dec 2018 17:43:30 +0000 (17:43 +0000)]
log more info about errors
tedu [Thu, 6 Dec 2018 16:51:19 +0000 (16:51 +0000)]
add very experimental support for dns over https. (RFC 8484)
performance may be less than great.
ok anton
gilles [Thu, 6 Dec 2018 16:05:04 +0000 (16:05 +0000)]
link-connect event report had an empty fcrdns field, but now that eric@ has
plugged fcrdns in the smtp_session we can fill the field with a value
gilles [Thu, 6 Dec 2018 15:32:06 +0000 (15:32 +0000)]
introduce tx-mail and tx-rcpt report events
gilles [Thu, 6 Dec 2018 13:57:06 +0000 (13:57 +0000)]
allow passing data lines to proc filters
ok eric@
claudio [Thu, 6 Dec 2018 13:04:40 +0000 (13:04 +0000)]
Be more strict when converting a netmask to prefixlen in mask2prefixlen6.
Make sure we never return a value bigger than 128.
OK remi@
claudio [Thu, 6 Dec 2018 12:38:00 +0000 (12:38 +0000)]
Implement a simple ruleset optimizer. All it does is merge filter rules that
only differ in the filter sets. Since this is still rather common it is able
to reduce the number of rules by 5% on an autogenerated config.
OK job@
gilles [Thu, 6 Dec 2018 12:32:11 +0000 (12:32 +0000)]
in mda variables expansions, do not consider empty strings as errors since
an empty %{sender} is really a mailer-daemon and not an error
reported and initial diff by Lauri Tirkkonen <lotheac@iki.fi>
commit is a revised version of the diff based on a discussion with eric@
gilles [Thu, 6 Dec 2018 12:09:50 +0000 (12:09 +0000)]
bring the first bits of DATA filtering plumbing but bypass it for now
ok eric@
claudio [Thu, 6 Dec 2018 09:23:15 +0000 (09:23 +0000)]
Add a new argument -B device to vmctl start. It allows to set the boot device.
At the moment only 'net' is supported and all other values are silently ignored.
This allows to kick of an OpenBSD autoinstall by using:
vmctl start "installer" -Lc -B net -b bsd.rd -d disk.img
OK ccardenas@
claudio [Thu, 6 Dec 2018 09:20:06 +0000 (09:20 +0000)]
Make it possible to define the bootdevice in vmd. This information is used
currently only when booting a OpenBSD kernel. If VMBOOTDEV_NET is used the
internal dhcp server will pass "auto_install" as boot file to the client and
the boot loader passes the MAC of the first interface to the kernel to indicate
PXE booting. Adding boot order support to SeaBIOS is not yet implemented.
Ok ccardenas@
claudio [Thu, 6 Dec 2018 08:11:52 +0000 (08:11 +0000)]
When building ND packets use m_align() to pack the mbuf as optimal as
possible. Because of an optional payload maxlen bytes are used on the
m_align so that there is always enough space.
OK florian@
stsp [Thu, 6 Dec 2018 07:50:38 +0000 (07:50 +0000)]
Avoid unnecessary dynamic memory allocation in athn_usb_newauth().
Patch by Benjamin Baier
ok ratchov@ mpi@
bru [Wed, 5 Dec 2018 19:49:47 +0000 (19:49 +0000)]
Use a time-based method for tracking motion states of touches.
ok mpi@
reyk [Wed, 5 Dec 2018 18:02:51 +0000 (18:02 +0000)]
Correctly disable pvclock(4) on old hardware that lack a stable clock
I falsely assumed that the KVM_FEATURE_CLOCKSOURCE_STABLE_BIT
indicates that the actual clock values are stable, but it turned out
that this isn't always the case. To detect if the clock value is
stable, we now read it once in pvclock_attach() and check for the
PVCLOCK_FLAG_TSC_STABLE flag. This needs further investigation.
Reported and fix tested by johnw.mail at gmail.com
OK chris@ phessler@
gerhard [Wed, 5 Dec 2018 17:41:23 +0000 (17:41 +0000)]
usb_block_allocmem() won't sleep.
ok mpi@
schwarze [Wed, 5 Dec 2018 17:11:59 +0000 (17:11 +0000)]
remove a stray line accidentally left behind in rev. 1.120;
patch from Hiltjo Posthuma <hiltjo at codemadness dot org>
mpi [Wed, 5 Dec 2018 15:54:58 +0000 (15:54 +0000)]
Do not call usbd_delay_ms() from interrupt context.
From Nils Frohberg.
mpi [Wed, 5 Dec 2018 15:44:22 +0000 (15:44 +0000)]
free(9) sizes for softcs.
ok tedu@
mpi [Wed, 5 Dec 2018 15:42:45 +0000 (15:42 +0000)]
free(9) size for temporary buffer.
ok ratchov@
schwarze [Wed, 5 Dec 2018 15:34:52 +0000 (15:34 +0000)]
fix incorrect usage of the .Bx macro;
one case reported by Fabio Scotoni <fabio at esse dot ch>,
the rest found with regress/usr.bin/mandoc/db/dbm_dump
jsg [Wed, 5 Dec 2018 10:28:21 +0000 (10:28 +0000)]
Include srp.h where struct cpu_info uses srp to avoid erroring out when
including cpu.h machine/intr.h etc without first including param.h when
MULTIPROCESSOR is defined.
ok visa@
denis [Wed, 5 Dec 2018 06:53:52 +0000 (06:53 +0000)]
Set the routing table when adding a network
OK claudio@
claudio [Wed, 5 Dec 2018 06:44:09 +0000 (06:44 +0000)]
key.data is a void *, on gcc archs doing a %s printf with such a pointer
results in a warning. Use either the original string value or use a cast.
This makes both clang and gcc happy.
OK guenther@
yasuoka [Wed, 5 Dec 2018 05:04:12 +0000 (05:04 +0000)]
Unbreak "savecore -c". Also add missing unveil(2) for the raw device.
ok mestre
guenther [Wed, 5 Dec 2018 04:28:32 +0000 (04:28 +0000)]
Delete an unused struct member that has hid out here for 17 years
bluhm [Tue, 4 Dec 2018 22:28:23 +0000 (22:28 +0000)]
Run each test as a single entry in REGRESS_TARGETS to get a better
overview if something went wrong. This makes debugging easier.
OK benno@ claudio@
schwarze [Tue, 4 Dec 2018 18:29:18 +0000 (18:29 +0000)]
HTML syntax audit: render \p as <br/>, not as <div>.
It can occur anywhere, in particular in phrasing context.
florian [Tue, 4 Dec 2018 18:12:08 +0000 (18:12 +0000)]
Check maxrequestbody when we found the right server / location.
Very patiently pointed out repeatedly by Tracey Emery ( tracey AT
traceyemery.net ), thanks!
OK benno
tedu [Tue, 4 Dec 2018 18:00:57 +0000 (18:00 +0000)]
redo the debug logging to be more like everything else.
ok kn
visa [Tue, 4 Dec 2018 16:24:13 +0000 (16:24 +0000)]
Add processor IDs for several OCTEON II and III SoCs.
claudio [Tue, 4 Dec 2018 14:45:29 +0000 (14:45 +0000)]
The common autolayout with all partitions needs not at least 10GB to be
selected. Adjust documentation.
OK krw@
claudio [Tue, 4 Dec 2018 14:13:40 +0000 (14:13 +0000)]
Since a while announcements added by bgpctl will overwrite the ones from
the config and no longer live next to each other. Because of this step 13
in the decision process is no longer needed.
OK benno@
kevlo [Tue, 4 Dec 2018 13:51:54 +0000 (13:51 +0000)]
Mention D-Link DWA-131 rev E1.
claudio [Tue, 4 Dec 2018 12:39:54 +0000 (12:39 +0000)]
Use m_align() and while there reorder the pkthdr initalisation a bit.
This also makes the IPv4 and IPv6 code more similar.
OK phessler@
sthen [Tue, 4 Dec 2018 12:05:06 +0000 (12:05 +0000)]
merge unbound 1.8.2
sthen [Tue, 4 Dec 2018 12:04:14 +0000 (12:04 +0000)]
import unbound 1.8.2
kettenis [Tue, 4 Dec 2018 11:25:48 +0000 (11:25 +0000)]
Unify messaged printed when we can't estiblish an interrupt.
Pointed out by Artturi Alm.
jmatthew [Tue, 4 Dec 2018 10:50:08 +0000 (10:50 +0000)]
mention RTL8192EU support
jmatthew [Tue, 4 Dec 2018 10:47:32 +0000 (10:47 +0000)]
Add support for RTL8192EU adapters, partly taken from netbsd.
These show up with a variety of vendor/product ids, but the driver will
only match those we've tested so far.
help and testing from kevlo@
ok stsp@ kevlo@
claudio [Tue, 4 Dec 2018 08:17:17 +0000 (08:17 +0000)]
Add 'vmctl wait <VM>' a command that waits until the specified VM is
stopped/terminates. Useful in scripts when waiting until a vm has finished
its work.
Ok ccardenas@, reyk@
claudio [Tue, 4 Dec 2018 08:15:09 +0000 (08:15 +0000)]
Introduce IMSG_VMDOP_WAIT_VM_REQUEST a control message that registers a
vmctl peerid that should be informed when the VM is stopped (like when the
guest does a shutdown). Uses the same logic as using the VMOP_WAIT flag on
IMSG_VMDOP_TERMINATE_VM_REQUEST.
Ok ccardenas@, reyk@
claudio [Tue, 4 Dec 2018 08:06:22 +0000 (08:06 +0000)]
Update bgpd result files after the community change. Forgot this bit of
the commit.
Reminded by bluhm@
schwarze [Tue, 4 Dec 2018 06:11:44 +0000 (06:11 +0000)]
Restrict "vertical-align: middle;" to <td> descendants of class="tbl"
elements, we don't want that for other tables.
schwarze [Tue, 4 Dec 2018 05:20:14 +0000 (05:20 +0000)]
Make sure all borders in a table are drawn in the same color.
Required because browsers tend to have inconsistent defaults:
For example, Firefox 62.0.2 sets border-color for tbody, but not for table,
and Pali Rohar reports that Chrome set it for td, but not for tr or tbody.
The td part is from Pali Rohar, the tbody and tr parts from me.
schwarze [Tue, 4 Dec 2018 03:28:54 +0000 (03:28 +0000)]
During validation, drop .br before a text line starting with a
blank, rather than teaching each formatter individually to ignore
the .br in such situations. That's simpler and also results in
better diagnostics.
Mark Harris <mark dot hsj at gmail dot com> reported
that -T html got confused in particular.
schwarze [Tue, 4 Dec 2018 02:53:45 +0000 (02:53 +0000)]
Clean up the validation of .Pp, .PP, .sp, and .br. Make sure all
combinations are handled, and are handled in a systematic manner.
This resolves some erratic duplicate handling, handles a number of
missing cases, and improves diagnostics in various respects.
Move validation of .br and .sp to the roff validation module
rather than doing that twice in the mdoc and man validation modules.
Move the node relinking function to the roff library where it belongs.
In validation functions, only look at the node itself, at previous
nodes, and at descendants, not at following nodes or ancestors,
such that only nodes are inspected which are already validated.
bluhm [Mon, 3 Dec 2018 22:41:00 +0000 (22:41 +0000)]
Port p5-Crypt-Random has been removed, replace it with p5-BSD-arc4random.
bluhm [Mon, 3 Dec 2018 22:30:04 +0000 (22:30 +0000)]
If a regress uses REGRESS_SKIP_TARGETS to skip part of its tests,
print SKIPPED. This helps to detect such incomplete tests.
OK anton@
eric [Mon, 3 Dec 2018 21:19:10 +0000 (21:19 +0000)]
Perform forward-confirmed reverse DNS verification on incoming connections.
Only flag the session for now.
input from and ok gilles@ sunil@
schwarze [Mon, 3 Dec 2018 21:00:06 +0000 (21:00 +0000)]
In the validators, translate obsolete macro aliases (Lp, Ot, LP, P)
to the standard forms (Pp, Ft, PP) up front, such that later code
does not need to look for the obsolete versions.
This reduces the risk of incomplete handling.
schwarze [Mon, 3 Dec 2018 19:13:14 +0000 (19:13 +0000)]
adapt to the change in mansearch.c rev. 1.62;
reminded by bluhm@, thanks!
bluhm [Mon, 3 Dec 2018 18:39:42 +0000 (18:39 +0000)]
The field dom_rtkeylen has been removed from struct domain. Convert
to designated initializers and adapt the test. Fix white space.
claudio [Mon, 3 Dec 2018 17:25:22 +0000 (17:25 +0000)]
Convert more MH_ALIGN() to m_align(). Also switch from m_gethdr/M_GETHDR
calls to m_get/M_GET calls because M_MOVE_PKTHDR() is initialising
the pkthdr and so it is not needed when allocation the header.
OK bluhm@
tb [Mon, 3 Dec 2018 17:16:12 +0000 (17:16 +0000)]
Send SSL_AD_DECODE alerts in the case of a bad hello request or an
invalid change cipher spec. Found due to dead assignment warnings
by the Clang static analyzer.
ok inoguchi (previous version), jsing
tb [Mon, 3 Dec 2018 17:05:51 +0000 (17:05 +0000)]
sync
schwarze [Mon, 3 Dec 2018 16:17:58 +0000 (16:17 +0000)]
Render .br as <br/>, not as an empty <div>.
The element <br/> was already employed for many other purposes,
so there is nothing wrong with using it.
Also, it is safer because <br/> is permitted in phrasing content,
whereas <div> is only allowed in flow content.
This is the first part of the HTML syntax audit which i wanted
to do for a long time. Reminded by a loosely related bug report
from Mark Harris <mark dot hsj at gmail dot com>.
Examples of where this caused HTML nesting syntax errors:
* in man(7) code between .nf and .fi
* in mdoc(7) code between .Bd -unfilled and .Ed
* in mdoc(7) code between .Ql Xo and .Xc
* in mdoc(7) code between .Rs and .Re
visa [Mon, 3 Dec 2018 13:50:02 +0000 (13:50 +0000)]
Do not process the top 32 bits of the 64 bit interrupt mask register
on the O2. The CRIME interrupt controller only has 32 interrupt sources.
From miod@
visa [Mon, 3 Dec 2018 13:46:30 +0000 (13:46 +0000)]
Remove the unused interrupt type (edge/level) from the mace interrupt
handler registration. The code is inherited from isa(4), but on the O2,
although some interrupt sources on CRIME are edge-triggered, all
the MACE interrupts are level-triggered.
From miod@
claudio [Mon, 3 Dec 2018 10:10:49 +0000 (10:10 +0000)]
In PRU_DISCONNECT don't fall through into PRU_ABORT since the latter frees
the inpcb apart from the disconnect. Just call soisdisconnected() and
clear the inp->inp_faddr since the socket is still valid after a disconnect.
Problem found by syzkaller via Greg Steuck
OK visa@
Fixes:
Reported-by: syzbot+2cd350dfe5c96f6469f2@syzkaller.appspotmail.com
Reported-by: syzbot+139ac2d7d3d60162334b@syzkaller.appspotmail.com
Reported-by: syzbot+02168317bd0156c13b69@syzkaller.appspotmail.com
Reported-by: syzbot+de8d2459ecf4cdc576a1@syzkaller.appspotmail.com
guenther [Mon, 3 Dec 2018 05:29:56 +0000 (05:29 +0000)]
DT_MIPS_RLD_MAP is an offset, so relocate it when present.
This fixes handling of lld-linked executables on mips64.
problem reported by visa@ and worked out with him
guenther [Mon, 3 Dec 2018 02:59:51 +0000 (02:59 +0000)]
Merge post-2.17 but pre-GPLv3 diffs that add support for DT_GNU_HASH
to ld and improve the readelf support:
https://sourceware.org/ml/binutils/2006-07/msg00129.html
https://sourceware.org/ml/binutils/2006-07/msg00181.html
Disable the ld support on mips64, as its ABI requires a symbol
ordering that conflicts with the requirements of DT_GNU_HASH.
Tested on macppc, alpha, and sparc64 to verify operation with all
three ELF word size combos
testing help miod@
ok kettenis@
jsg [Mon, 3 Dec 2018 01:51:17 +0000 (01:51 +0000)]
Avoid uint32_t in _lock.h so users of rwlock.h mutex.h etc don't have to
include sys/types.h first.
ok guenther@ deraadt@
kettenis [Sun, 2 Dec 2018 21:30:21 +0000 (21:30 +0000)]
Include "com.h" to fix using a puc(4) based serial port as serial console
which was broken by the previous commit.
ok jsg@, mpi@
fcambus [Sun, 2 Dec 2018 14:47:23 +0000 (14:47 +0000)]
Remove artefacts from 'C', 'c' and 'F' characters, to match the other
sizes.
OK patrick@
fcambus [Sun, 2 Dec 2018 14:44:33 +0000 (14:44 +0000)]
Add Spleen 8x16, 12x24, 16x32, and 32x64 variants to wsfont.
Together with the already imported Spleen 5x8, it will allow using the
same font family across a wide range of screen resolutions, from small
OLED displays to 4K monitors.
The fonts are 2-Clause BSD licensed and are my original creation.
OK jcs@, brynet@, bcallah@, kettenis@
anton [Sun, 2 Dec 2018 11:46:31 +0000 (11:46 +0000)]
mention REGRESS_SKIP_TARGETS; ok bluhm@
gilles [Sun, 2 Dec 2018 11:34:21 +0000 (11:34 +0000)]
err -> errx
diff from Lauri Tirkkonen <lotheac@iki.fi>
kn [Sat, 1 Dec 2018 23:35:59 +0000 (23:35 +0000)]
Use strtonum(3) for -t seconds, improve errors on invalid number input
Base 10 suffices, negative numbers should be invalid (not converted) and
zero not treated specially.
This also unifies error messages and removes unnecessary EINVAL from them
since strtonum()'s errstr is explicit enough already.
Feedback and OK martjin, tb
jmc [Sat, 1 Dec 2018 07:11:28 +0000 (07:11 +0000)]
update currency exchange rates;
mlarkin [Fri, 30 Nov 2018 19:19:06 +0000 (19:19 +0000)]
regen
mlarkin [Fri, 30 Nov 2018 19:18:31 +0000 (19:18 +0000)]
Add another Xeon E3-1200 v6/7 host device.
Add nVidia Quadro M1200
from Peter Ezetta, thanks.
danj [Fri, 30 Nov 2018 18:40:57 +0000 (18:40 +0000)]
Remove erroneous quote added in previous
Spotted by jmc, thanks!
mpi [Fri, 30 Nov 2018 18:19:12 +0000 (18:19 +0000)]
Fix a typo and remove broken example.
From Edgar Pettijohn.
tedu [Fri, 30 Nov 2018 18:05:31 +0000 (18:05 +0000)]
log current power status going into and out of suspend, since it may be
interesting to review.
it seems the battery status is sometimes stale, but that's another bug.
ok kn phessler
gilles [Fri, 30 Nov 2018 15:41:15 +0000 (15:41 +0000)]
on link-connect report events, add an fc-rdns field, currently empty
gilles [Fri, 30 Nov 2018 15:33:40 +0000 (15:33 +0000)]
prepare for smtp-out reporting and while at it, make a few changes to the
report format
danj [Fri, 30 Nov 2018 15:06:47 +0000 (15:06 +0000)]
/usr/local/ -> ${LOCALBASE}
ok espie@
danj [Fri, 30 Nov 2018 15:06:25 +0000 (15:06 +0000)]
Update after INDEX change
ok espie@
claudio [Fri, 30 Nov 2018 11:58:47 +0000 (11:58 +0000)]
Document m_align().
With and OK bluhm@, jmc@
claudio [Fri, 30 Nov 2018 09:28:34 +0000 (09:28 +0000)]
MH_ALIGN -> m_align
OK bluhm@
claudio [Fri, 30 Nov 2018 09:27:56 +0000 (09:27 +0000)]
MH_ALIGN -> m_align. In revarprequest() set the ph_rtableid so that
the function is doing the same initialisation as arprequest().
OK bluhm@
claudio [Fri, 30 Nov 2018 09:26:06 +0000 (09:26 +0000)]
MH_ALIGN -> m_align and make the spacing look the same in all three places.
OK bluhm@
claudio [Fri, 30 Nov 2018 09:24:57 +0000 (09:24 +0000)]
Switch MH_ALIGN to m_align which is the same.
OK bluhm@
claudio [Fri, 30 Nov 2018 09:23:31 +0000 (09:23 +0000)]
Trivial MH_ALIGN/M_ALIGN to m_align conversions.
OK bluhm@
solene [Fri, 30 Nov 2018 08:55:57 +0000 (08:55 +0000)]
in getopts, when a option is followed by a colon the parameter is mandatory
ok guenther@ deraadt@
nicm [Fri, 30 Nov 2018 08:44:40 +0000 (08:44 +0000)]
Clear PANE_EXITED flag when starting new child process in case the pane
has been respawned.
jmc [Fri, 30 Nov 2018 08:00:43 +0000 (08:00 +0000)]
tweak previous;
ratchov [Fri, 30 Nov 2018 07:10:12 +0000 (07:10 +0000)]
sync