openbsd
3 years agoFix formatting of multi-line license comment per style(9).
jsing [Sun, 16 May 2021 10:58:27 +0000 (10:58 +0000)]
Fix formatting of multi-line license comment per style(9).

3 years agoAvoid pulling ssl_sigalgs.h in via ssl_locl.h.
jsing [Sun, 16 May 2021 10:55:17 +0000 (10:55 +0000)]
Avoid pulling ssl_sigalgs.h in via ssl_locl.h.

Forward declare struct sigalg in ssl_locl.h and avoid including
ssl_sigalgs.h. Explicitly include ssl_sigalgs.h where it is needed.

3 years agoremove unneeded includes
jsg [Sun, 16 May 2021 10:40:24 +0000 (10:40 +0000)]
remove unneeded includes

3 years agoremove unneeded includes
jsg [Sun, 16 May 2021 10:39:22 +0000 (10:39 +0000)]
remove unneeded includes

3 years agoSync memreg_add() implementation with arm64 and powerpc64.
kettenis [Sun, 16 May 2021 10:38:53 +0000 (10:38 +0000)]
Sync memreg_add() implementation with arm64 and powerpc64.

3 years agoCapabilities are only supported on a session when both sides announce
claudio [Sun, 16 May 2021 09:09:11 +0000 (09:09 +0000)]
Capabilities are only supported on a session when both sides announce
that capability. Change capa_neg_calc() to check always both the
ann(ounce) and peer capa struct to figure out what was negotiated.
This change affects route refersh and graceful restart (where before
setting the capability in the config to 'no' would not fully disable
the feature).
Also ignore and warn about unexpected route refresh messages.
OK benno@

3 years agocorrect prototype of acpi gpio intr_establish functions
jsg [Sun, 16 May 2021 08:50:59 +0000 (08:50 +0000)]
correct prototype of acpi gpio intr_establish functions

ok kettenis@

3 years agoRemove unnecessary includes from the bytestring APIs.
jsing [Sun, 16 May 2021 08:32:49 +0000 (08:32 +0000)]
Remove unnecessary includes from the bytestring APIs.

The bytestring APIs are self contained, hence including openssl headers
here is unnecessary.

3 years agoExplicitly include <openssl/opensslconf.h> in files using OPENSSL_NO_*
jsing [Sun, 16 May 2021 08:24:21 +0000 (08:24 +0000)]
Explicitly include <openssl/opensslconf.h> in files using OPENSSL_NO_*

Where a file references to OPENSSL_NO_* conditions, ensure that we
explicitly include <openssl/opensslconf.h> before any references, rather
than relying on another header to pull this in.

3 years agomention apmd(8) in afterboot(8)
paco [Sun, 16 May 2021 06:46:57 +0000 (06:46 +0000)]
mention apmd(8) in afterboot(8)

input and ok jmc@

3 years agob_saveaddr has a type of void * use NULL not 0
jsg [Sun, 16 May 2021 06:20:28 +0000 (06:20 +0000)]
b_saveaddr has a type of void * use NULL not 0

3 years agoansi
jsg [Sun, 16 May 2021 04:51:00 +0000 (04:51 +0000)]
ansi

3 years agoderegister
jsg [Sun, 16 May 2021 04:45:58 +0000 (04:45 +0000)]
deregister

3 years agoansi
jsg [Sun, 16 May 2021 04:34:47 +0000 (04:34 +0000)]
ansi

3 years agoremove prototype for cpu_adjust_tsc_freq()
jsg [Sun, 16 May 2021 04:33:05 +0000 (04:33 +0000)]
remove prototype for cpu_adjust_tsc_freq()
a matching function was never committed

3 years agoansi
jsg [Sun, 16 May 2021 03:39:27 +0000 (03:39 +0000)]
ansi

3 years agoansi
jsg [Sun, 16 May 2021 03:30:33 +0000 (03:30 +0000)]
ansi

3 years agoansi
jsg [Sun, 16 May 2021 03:29:35 +0000 (03:29 +0000)]
ansi

3 years agoadd riscv asm for these two security-feature checking regress tests
deraadt [Sun, 16 May 2021 03:23:48 +0000 (03:23 +0000)]
add riscv asm for these two security-feature checking regress tests
with drahn

3 years agoremove unused pre efiboot targets
jsg [Sun, 16 May 2021 02:01:33 +0000 (02:01 +0000)]
remove unused pre efiboot targets

3 years agoNuke some Capt. Obvious and soon to be obsolete comments in
krw [Sat, 15 May 2021 22:06:43 +0000 (22:06 +0000)]
Nuke some Capt. Obvious and soon to be obsolete comments in
GPT_write().

Add local variables prigh and prigp, mirroring altgh and altp, to
GPT_write(), eliminating some magic numbers to make clear the
relationship between the various primary and alternative GPT lba
fields.

No intentional functional change.

3 years agoAdd back -mno-relax for now. Retain the -target option but put it on
kettenis [Sat, 15 May 2021 20:51:12 +0000 (20:51 +0000)]
Add back -mno-relax for now.  Retain the -target option but put it on
a line of its own to improve diffability with other architectures.

ok drahn@

3 years agoin kdata_abort, error must be initialized to 0 (like arm64)
deraadt [Sat, 15 May 2021 20:20:35 +0000 (20:20 +0000)]
in kdata_abort, error must be initialized to 0 (like arm64)
spotted by drahn

3 years agoIn all the copyin family functions, must compare end-address against
deraadt [Sat, 15 May 2021 20:14:05 +0000 (20:14 +0000)]
In all the copyin family functions, must compare end-address against
VM_MAXUSER_ADDRESS with bgtu, signed comparison is incorrect.  Now passes
regress/sys/copy
ok drahn kettenis

3 years agoReorganize kernel & user fault handling into seperate functions like on
deraadt [Sat, 15 May 2021 20:12:24 +0000 (20:12 +0000)]
Reorganize kernel & user fault handling into seperate functions like on
other architectures.  During refactoring, found missing calls to important
functions and incorrect parameter passing...
ok kettenis drahn

3 years agocopyinout.S is not used
deraadt [Sat, 15 May 2021 20:05:05 +0000 (20:05 +0000)]
copyinout.S is not used

3 years agoKeep internal representation of DOSPTYP_EFI partition sizes correct.
krw [Sat, 15 May 2021 19:44:15 +0000 (19:44 +0000)]
Keep internal representation of DOSPTYP_EFI partition sizes correct.
Translate to/from UINT32_MAX as required when translating between
on-disk MBR format and internal format.

No intentional functional change.

3 years agoWhen looking for the last layout row used, we need to look at the layout
schwarze [Sat, 15 May 2021 17:16:38 +0000 (17:16 +0000)]
When looking for the last layout row used, we need to look at the layout
row used for the previous data line containing data, not at the previous
data line outright, which might be a horizontal ruler.  If it is, do not
restart from the first layout row but still proceed to the next data row,
which may have been just read from T&.

Bug originally reported by Oliver dot Corff at email dot de
on groff at gnu dot org:
https://lists.gnu.org/archive/html/groff/2021-03/msg00003.html
and forwarded to me by bentley@.

Patch OK'ed by bentley@ back in April.

3 years agoAdd missing MBR_protective_mbr() check when writing edited GPT.
krw [Sat, 15 May 2021 15:59:15 +0000 (15:59 +0000)]
Add missing MBR_protective_mbr() check when writing edited GPT.

No intentional functional change.

3 years agoShuffle USER_print_disk() code into a more rational, clearer
krw [Sat, 15 May 2021 15:20:17 +0000 (15:20 +0000)]
Shuffle USER_print_disk() code into a more rational, clearer
structure.

No intentional functional change.

3 years agoRemove outdated comment. We got all httpd headers from the fcgi server
florian [Sat, 15 May 2021 15:08:31 +0000 (15:08 +0000)]
Remove outdated comment. We got all httpd headers from the fcgi server
at this point.

3 years agoRemove OUTPUT_FORMAT and OUTPUT_ARCH from linker script. These are
kettenis [Sat, 15 May 2021 14:20:11 +0000 (14:20 +0000)]
Remove OUTPUT_FORMAT and OUTPUT_ARCH from linker script.  These are
no-ops for ld.lld.

ok deraadt@

3 years agopmap_fault_fixup() does not need "int user"
deraadt [Sat, 15 May 2021 14:05:35 +0000 (14:05 +0000)]
pmap_fault_fixup() does not need "int user"
ok kettenis

3 years agoimprove comment regarding child_return() clearing errno-indicating flag
deraadt [Sat, 15 May 2021 13:56:56 +0000 (13:56 +0000)]
improve comment regarding child_return() clearing errno-indicating flag

3 years agoAdd pledge for ftpd's user processes.
jan [Sat, 15 May 2021 13:37:43 +0000 (13:37 +0000)]
Add pledge for ftpd's user processes.

OK tobhe@

3 years agoUse intr_enable()/int_disable()/intr_restore() instead of
kettenis [Sat, 15 May 2021 11:30:27 +0000 (11:30 +0000)]
Use intr_enable()/int_disable()/intr_restore() instead of
enable_interrupts()/disable_interrupts()/restore_interrupts() and remove
the latter interfaces.

While there move a few malloc(9) and free(9) calls to run with interrupts
enabled.

ok patrick@

3 years agoFix IPsec NAT-T to work with pipex(4). Introduce a new packet tag
yasuoka [Sat, 15 May 2021 08:07:20 +0000 (08:07 +0000)]
Fix IPsec NAT-T to work with pipex(4).  Introduce a new packet tag
PACKET_TAG_IPSEC_FLOWINFO to specify the IPsec flow.

ok mvs

3 years agoLoad the fault handler into the correct register.
drahn [Sat, 15 May 2021 00:04:32 +0000 (00:04 +0000)]
Load the fault handler into the correct register.
Having the onfault dance in a macro makes this almost unreadable.
Initial failure found by deraadt, cause finally found.

3 years agoShuffle GPT_read() code into a nice switch{}, eliminating
krw [Sat, 15 May 2021 00:01:21 +0000 (00:01 +0000)]
Shuffle GPT_read() code into a nice switch{}, eliminating
unnecesary read of primary GPT when only the secondary GPT
is requested.

No intentional functional change.

3 years agoWhitespace tweaks and a couple of stray u_int* in gpt_chk_mbr().
krw [Fri, 14 May 2021 21:11:15 +0000 (21:11 +0000)]
Whitespace tweaks and a couple of stray u_int* in gpt_chk_mbr().

No intentional functional change.

3 years agowhitespace/KNF
tb [Fri, 14 May 2021 18:03:42 +0000 (18:03 +0000)]
whitespace/KNF

3 years agoamd64: specialreg.h: add MSR_TSC_ADJUST
cheloha [Fri, 14 May 2021 16:44:38 +0000 (16:44 +0000)]
amd64: specialreg.h: add MSR_TSC_ADJUST

Where available, the IA32_TSC_ADJUST MSR may be used to make race-free
relative adjustments to a logical CPU's TSC.  The value in the
register is interpreted as a signed 64-bit offset and added to the
"real" value of the TSC whenever the TSC MSR is read.  That is:

RDTSC = REAL_TSC + TSC_ADJUST

and:

RDMSR TSC = REAL_TSC + TSC_ADJUST

For example, if REAL_TSC=1 and TSC_ADJUST=1, then RDTSC would yield 2.
Or if REAL_TSC=10 and TSC_ADJUST=-5, then RDTSC would yield 5.

Writing TSC_ADJUST does not change the "real" underlying value of the
TSC.  Said another way setting TSC_ADJUST to zero will always undo any
prior adjustment.  This property may be useful in fixing desynchronized
TSCs.  In particular, buggy firmware may erroneously desynchronize a
normally synchronized TSC.  If this happens, in theory we can do:

wrmsr(MSR_TSC_ADJUST, 0);

and fix any desynchronization during boot/resume with no fuss.

ok mlarkin@

3 years agoTweak the two copies of gpt_chk_mbr() to return the index of the MBR
krw [Fri, 14 May 2021 15:31:01 +0000 (15:31 +0000)]
Tweak the two copies of gpt_chk_mbr() to return the index of the MBR
0xEE (DOSPTYP_EFI) partition, or -1 no usable such partition is found.

Adopt a consistent idiom to capture the index for future use.

Clean up the gpt_chk_mbr() logic to make it clearer what constraints
are being applied when looking for the DOSTYP_EFI partition.

No intentional functional change.

3 years agoProperly refer to ioctl(2)
kn [Fri, 14 May 2021 13:10:20 +0000 (13:10 +0000)]
Properly refer to ioctl(2)

From Caspar Schutijser, thanks.

3 years agoImprove libcrypto obj_xref.h generator
inoguchi [Fri, 14 May 2021 10:50:55 +0000 (10:50 +0000)]
Improve libcrypto obj_xref.h generator

Modify objxref.pl to output $OpenBSD$ header and
__BEGIN_HIDDEN_DECLS / __END_HIDDEN_DECLS .

ok and comment from tb@

3 years agoremove comment describing GENERIC
jsg [Fri, 14 May 2021 08:10:39 +0000 (08:10 +0000)]
remove comment describing GENERIC

3 years agoadd dwge(4) to RAMDISK as well
jsg [Fri, 14 May 2021 06:55:19 +0000 (06:55 +0000)]
add dwge(4) to RAMDISK as well

3 years agoremove uneeded includes
jsg [Fri, 14 May 2021 06:48:52 +0000 (06:48 +0000)]
remove uneeded includes

3 years agomove some files to match other archs
jsg [Fri, 14 May 2021 05:21:00 +0000 (05:21 +0000)]
move some files to match other archs

ok deraadt@ drahn@

3 years agofix previous: test saved no_shell_flag, not the one that just got
djm [Fri, 14 May 2021 05:20:32 +0000 (05:20 +0000)]
fix previous: test saved no_shell_flag, not the one that just got
clobbered

3 years agoRiscv64 sets. Initial attempt.
drahn [Fri, 14 May 2021 03:49:18 +0000 (03:49 +0000)]
Riscv64 sets. Initial attempt.

3 years agoFix ssh started with ControlPersist incorrectly executing a shell
djm [Fri, 14 May 2021 03:09:48 +0000 (03:09 +0000)]
Fix ssh started with ControlPersist incorrectly executing a shell
when the -N (no shell) option was specified. bz3290 reported by
Richard Schwab; patch from markus@ ok me

3 years agoEnable riscv64 native kernel builds.
drahn [Fri, 14 May 2021 03:01:24 +0000 (03:01 +0000)]
Enable riscv64 native kernel builds.
remove extra targets

3 years agoOn riscv64, dynamically linked clang binary fails with:
drahn [Fri, 14 May 2021 02:29:00 +0000 (02:29 +0000)]
On riscv64, dynamically linked clang binary fails with:
libc++abi: Pure virtual function called!

By statically linking clang (and *-tblgen) this problem is worked around
at least for now.

3 years agoFix bootloader name and riscv64 doesn't have bsd.mp yet.
drahn [Fri, 14 May 2021 02:21:34 +0000 (02:21 +0000)]
Fix bootloader name and riscv64 doesn't have bsd.mp yet.

3 years agoAdjust ramdisk generation for self hosting, remove cross bits.
drahn [Fri, 14 May 2021 01:18:52 +0000 (01:18 +0000)]
Adjust ramdisk generation for self hosting, remove cross bits.

3 years agoInitial enablment of EMULTLS on RiscV
drahn [Fri, 14 May 2021 01:15:54 +0000 (01:15 +0000)]
Initial enablment of EMULTLS on RiscV
Uncertain if this is 100% correct, however this enables self hosting
using clang.

3 years agoFix regression for _setjmp, fucntion does not use stack and adjusting
drahn [Fri, 14 May 2021 00:57:03 +0000 (00:57 +0000)]
Fix regression for _setjmp, fucntion does not use stack and adjusting
it causes restored stack to be incorrect.

3 years agoImprove mereg_add() like I did on arm64.
kettenis [Thu, 13 May 2021 22:42:14 +0000 (22:42 +0000)]
Improve mereg_add() like I did on arm64.

3 years agoDo `so_rcv' cleanup with sblock() held.
mvs [Thu, 13 May 2021 19:43:11 +0000 (19:43 +0000)]
Do `so_rcv' cleanup with sblock() held.

solock() should be taken before sblock(). soreceive() grabs solock() and
then locks `so_rcv'. But later it releases solock() before call uimove(9).
So concurrent thread which performs soshutdown() could break sorecive()
loop. But `so_rcv' is still locked by sblock() so this soshutdown()
thread will sleep in sorflush() at sblock() call. soshutdown() thread
doesn't release solock() after sblock() call so it has no matter where to
release `so_rcv' - is will be locked until the solock() release.

That's why this strange looking code works fine. This sbunlock() movement
just after `so_rcv' cleanup  affects nothing but makes the code
consistent and clean to understand.

ok mpi@

3 years agoUse intr_enable()/int_disable()/intr_restore() instead of
kettenis [Thu, 13 May 2021 19:26:25 +0000 (19:26 +0000)]
Use intr_enable()/int_disable()/intr_restore() instead of
enable_interrupts()/disable_interrupts()/restore_interrupts() and remove
the latter interfaces.

ok mlarkin@, drahn@

3 years agoUse NULL instead of 0 for mbuf(9) pointers.
mvs [Thu, 13 May 2021 18:06:54 +0000 (18:06 +0000)]
Use NULL instead of 0 for mbuf(9) pointers.

ok millert@

3 years agoAssign NULL instead of 0 to `control' within sendit(). It's mbuf(9)
mvs [Thu, 13 May 2021 17:31:59 +0000 (17:31 +0000)]
Assign NULL instead of 0 to `control' within sendit(). It's mbuf(9)
pointer.

ok deraadt@

3 years agoMove ktrfds() below fdpunlock(). This fixes lock order issue between
mvs [Thu, 13 May 2021 17:02:31 +0000 (17:02 +0000)]
Move ktrfds() below fdpunlock(). This fixes lock order issue between
vn_lock(9) and fdplock().

Reported-by: syzbot+2300a1bedc425f6f851e@syzkaller.appspotmail.com
ok visa@

3 years agoMake memreg_add() a bit smarter and have it merge adjacent regions.
kettenis [Thu, 13 May 2021 16:08:16 +0000 (16:08 +0000)]
Make memreg_add() a bit smarter and have it merge adjacent regions.
This should reduce the number of physical memory segments that we pass
to uvm reducing the chance that we run out of physical memory segments
and should make physical memory allocation a bit more efficient.

ok patrick@

3 years agoRefactor iked process shutdown and cleanup. Remember configured
tobhe [Thu, 13 May 2021 15:20:48 +0000 (15:20 +0000)]
Refactor iked process shutdown and cleanup. Remember configured
addresses and routes in iked_vroute_sc to not depend on ikev2
process for cleanup.

This makes sure that all flows, routes and addresses are deleted
no matter which process is killed first.

ok patrick@

3 years agoUse field independent versions of {get,set}_coordinates()
tb [Thu, 13 May 2021 14:28:03 +0000 (14:28 +0000)]
Use field independent versions of {get,set}_coordinates()

ok tobhe

3 years agoUse field independent version of {get,set}_affine_coordinates.
tb [Thu, 13 May 2021 14:01:35 +0000 (14:01 +0000)]
Use field independent version of {get,set}_affine_coordinates.

ok tobhe

3 years agoRFC 4861 4.1 allows router solicitations from the unspecified address
florian [Thu, 13 May 2021 11:22:15 +0000 (11:22 +0000)]
RFC 4861 4.1 allows router solicitations from the unspecified address
(::). A short survey suggests that some systems respond with a
multicast router advertisement and other don't.

Andrew Forgue pointed out a usecase for this, booting a UEFI system
over http in an IPv6 network only. ("IPv6 support for UEFI IPv6
booting" on bugs@ a long time ago)

There is also no downside in allowing this, any host on the layer 2
network can solicit a router advertisement.

OK phessler

3 years agoRun handlers with interrupts enabled.
kettenis [Thu, 13 May 2021 09:32:00 +0000 (09:32 +0000)]
Run handlers with interrupts enabled.

ok jsg@

3 years agochange sig_atomic_t from long to int matching all the other archs
jsg [Thu, 13 May 2021 08:44:18 +0000 (08:44 +0000)]
change sig_atomic_t from long to int matching all the other archs

ok kettenis@

3 years agoacme-client: use EC_POINT_{get,set}_affine_cooordinates()
tb [Thu, 13 May 2021 07:10:57 +0000 (07:10 +0000)]
acme-client: use EC_POINT_{get,set}_affine_cooordinates()

The versions with _GFp() suffix only exist for historical reasons.
Now that we have EC_POINT_{get,set}_affine_coordinates(), we should
stop using the old ones as they provide no benefit.

ok florian

3 years agoNo need to disable interrupts before returning to userland.
kettenis [Thu, 13 May 2021 06:45:23 +0000 (06:45 +0000)]
No need to disable interrupts before returning to userland.
The AST processing code will take care of doing that for us.

ok jsg@

3 years agoWhen doing AST processing:
kettenis [Thu, 13 May 2021 06:44:11 +0000 (06:44 +0000)]
When doing AST processing:
1) block interrupts, then check for ASTs
2) if no ASTs, return with interrupts blocked, so they can be re-enabled
   ATOMICALLY in the return to userspace
3) if an AST happened, then re-enable interrupts, call ast(), then goto 1

ok jsg@

3 years agoAdd missing .Pp in HISTORY section.
tb [Thu, 13 May 2021 06:00:53 +0000 (06:00 +0000)]
Add missing .Pp in HISTORY section.

3 years agoAdd missing .Pp
tb [Thu, 13 May 2021 05:52:28 +0000 (05:52 +0000)]
Add missing .Pp

3 years agoWhitespace fix for unintentional unindenting event in r1.260.
krw [Thu, 13 May 2021 02:22:33 +0000 (02:22 +0000)]
Whitespace fix for unintentional unindenting event in r1.260.

Reported by Ashton Fagg via tech@. Thanks!

3 years agoRemove about PACKET_TAG_PIPEX, it was replaced by ph_cookie.
yasuoka [Wed, 12 May 2021 23:17:30 +0000 (23:17 +0000)]
Remove about PACKET_TAG_PIPEX, it was replaced by ph_cookie.

3 years agoprint a newline after each instruction
deraadt [Wed, 12 May 2021 23:08:19 +0000 (23:08 +0000)]
print a newline after each instruction
ok kettenis

3 years agovmctl(8): remove unveil from disk image creation routines
dv [Wed, 12 May 2021 20:13:00 +0000 (20:13 +0000)]
vmctl(8): remove unveil from disk image creation routines

James Cook reported an issue creating images from qcow2 disks that
contained base images. Initial approach suggested was to replace the
use of realpath(3), but since this is common code used in vmd(8) the
better option is to just remove the use of unveil(1) in vmctl. (It was
added very early in vmctl's development before support for disk
conversion was added.)

This does not change existing unveil usage in vmctl for things like the
control socket or the serial console. There's no change to vmd either.

Discussed with and OK from mlarkin@

3 years agoBuild a list of memory regions and call yvm_physload(9) on those like
kettenis [Wed, 12 May 2021 17:43:26 +0000 (17:43 +0000)]
Build a list of memory regions and call yvm_physload(9) on those like
we do on riscv64.

ok patrick@

3 years agoMerge documentation for SSL_CIPHER_find(3) from OpenSSL 1.1.1.
tb [Wed, 12 May 2021 15:12:35 +0000 (15:12 +0000)]
Merge documentation for SSL_CIPHER_find(3) from OpenSSL 1.1.1.

3 years agoregen
mpi [Wed, 12 May 2021 15:05:09 +0000 (15:05 +0000)]
regen

3 years agoRevert unlock of connect(2), bind(2), listen(2) and shutdown(2).
mpi [Wed, 12 May 2021 15:04:48 +0000 (15:04 +0000)]
Revert unlock of connect(2), bind(2), listen(2) and shutdown(2).

At least one of them cause a deadlock involving `unplock' and mbuf allocations
('mbufpl') as reported by millert@.

3 years agosync
tb [Wed, 12 May 2021 14:19:30 +0000 (14:19 +0000)]
sync

3 years agoInstall SSL_SESSION_get0_cipher.3
tb [Wed, 12 May 2021 14:17:27 +0000 (14:17 +0000)]
Install SSL_SESSION_get0_cipher.3

3 years agoDocument SSL_SESSION_get0_cipher(3)
tb [Wed, 12 May 2021 14:16:25 +0000 (14:16 +0000)]
Document SSL_SESSION_get0_cipher(3)

Based on the OpenSSL 1.1.1 manual written by Rich Salz with a healthy
dose of improvements by schwarze.

ok schwarze

3 years agoClarify language about moduli. While both ends of the connection do need
dtucker [Wed, 12 May 2021 11:34:30 +0000 (11:34 +0000)]
Clarify language about moduli.  While both ends of the connection do need
to use the same parameters (ie groups), the DH-GEX protocol takes care
of that and both ends do not need the same contents in the moduli file,
which is what the previous text suggested.  ok djm@ jmc@

3 years agoCount the number of arguments in each expression as we initially go
lum [Wed, 12 May 2021 11:13:23 +0000 (11:13 +0000)]
Count the number of arguments in each expression as we initially go
through the expression. To be used in checking function parameter
profiles later.

3 years agofix broken escape; ok schwarze
jmc [Wed, 12 May 2021 10:59:43 +0000 (10:59 +0000)]
fix broken escape; ok schwarze

3 years agoModify cms test in appstest.sh to work with ec cert/key
inoguchi [Wed, 12 May 2021 10:39:13 +0000 (10:39 +0000)]
Modify cms test in appstest.sh to work with ec cert/key

3 years agoAdd obj_xref for ECDH schemes in RFC 5753
inoguchi [Wed, 12 May 2021 10:24:39 +0000 (10:24 +0000)]
Add obj_xref for ECDH schemes in RFC 5753

Found missing sigoid_srt record in crypto/objects/obj_xref.h, and
this causes error while executing openssl cms -encrypt with EC key/cert.
Added required definitions to obj_xref.txt and obj_xref.h.

Issue reported by Theodore Wynnychenko (tmw <at> uchicago.edu) on misc.

ok tb@

3 years agoFix several issues introduced with iwm(4) Tx aggregation support.
stsp [Wed, 12 May 2021 10:05:57 +0000 (10:05 +0000)]
Fix several issues introduced with iwm(4) Tx aggregation support.

Keep station queues marked as enabled until the device gets reset.
The firmware becomes unhappy if it finds some queues enabled but missing
from the station's queue mask, even across removals and re-additions of the
station which occur during re-associations and while roaming between APs.
Fixes "could not add sta (error 35)" fatal firmware errors.

When stopping a BA session, properly set the bit corresponding to the
session's TID in the node's tid_disable_ampu bitmask.

During dis- and re-associations all Tx block ack sessions are torn down,
so clear the bitmask which identifies queues with active Tx BA sessions.

Don't byte-swap values written to host-side variables.

Problems reported and fixes tested by Matthias Schmidt and kettenis@.
Additional testing by phessler@, mlarkin@, and Mikolaj Kucharski.

3 years agoUse local copy of `ps_rtableid' in ip{,6}_ctloutput() and mark
mvs [Wed, 12 May 2021 08:09:33 +0000 (08:09 +0000)]
Use local copy of `ps_rtableid' in ip{,6}_ctloutput() and mark
`ps_rtableid' as atomic. This allows us to unlock setrtable(2).

ok claudio@ mpi@

3 years agoThe official service name of tcp/465 is "submissions"
jca [Wed, 12 May 2021 06:50:33 +0000 (06:50 +0000)]
The official service name of tcp/465 is "submissions"

Keep "smtps" as an alias.
https://datatracker.ietf.org/doc/html/rfc8314#section-7.3

ok sthen@ florian@ kmos@

3 years agoDrop swat (tcp/901)
jca [Wed, 12 May 2021 06:45:30 +0000 (06:45 +0000)]
Drop swat (tcp/901)

The Samba Web Administration Tool has been dropped by the samba project and
TCP port 901 is not registered at IANA.  ok sthen@ florian@ kmos@

3 years agoKNF
mlarkin [Wed, 12 May 2021 04:00:46 +0000 (04:00 +0000)]
KNF

3 years agoCorrect defines for fenv rounding modes and change fenv_t and fexcept_t
jsg [Wed, 12 May 2021 02:28:25 +0000 (02:28 +0000)]
Correct defines for fenv rounding modes and change fenv_t and fexcept_t
from unsigned long long to unsigned int.

ok kettenis@

3 years agovmd(8): omit a possibly uninitialized var in a log_warnx
mlarkin [Wed, 12 May 2021 02:24:56 +0000 (02:24 +0000)]
vmd(8): omit a possibly uninitialized var in a log_warnx

Don't print 'base' since it might not be initialized in all code paths.

From James Cook

3 years agoadd a comment describing how this was created
jsg [Wed, 12 May 2021 01:24:32 +0000 (01:24 +0000)]
add a comment describing how this was created

ok deraadt@