openbsd
10 years agoMore KNF.
jsing [Fri, 18 Apr 2014 05:37:44 +0000 (05:37 +0000)]
More KNF.

10 years agoImplement qle_fabric_plogo and let qle_fabric_plogi look at the response that
jmatthew [Fri, 18 Apr 2014 05:08:15 +0000 (05:08 +0000)]
Implement qle_fabric_plogo and let qle_fabric_plogi look at the response that
comes back, so later on we can work out what to do when logins fail

10 years agowhitespace normalization
tedu [Fri, 18 Apr 2014 04:33:09 +0000 (04:33 +0000)]
whitespace normalization

10 years agorepair whitespace. this is what happens when functions take 20 params.
tedu [Fri, 18 Apr 2014 04:23:53 +0000 (04:23 +0000)]
repair whitespace. this is what happens when functions take 20 params.

10 years agoRemove MAIN and PROG defines now that we do not compile non-monolithic.
jsing [Fri, 18 Apr 2014 04:17:16 +0000 (04:17 +0000)]
Remove MAIN and PROG defines now that we do not compile non-monolithic.

ok tedu@

10 years agoigetest.c moved to regress we don't need another copy
jsg [Fri, 18 Apr 2014 03:37:43 +0000 (03:37 +0000)]
igetest.c moved to regress we don't need another copy
ok miod@

10 years agofix another potential double free
jsg [Fri, 18 Apr 2014 03:28:12 +0000 (03:28 +0000)]
fix another potential double free
ok miod@ lteo@ jca@

10 years ago-netware
tedu [Fri, 18 Apr 2014 02:56:48 +0000 (02:56 +0000)]
-netware

10 years agoundef NETWARE_CLIB and NETWARE_LIBC
tedu [Fri, 18 Apr 2014 02:48:58 +0000 (02:48 +0000)]
undef NETWARE_CLIB and NETWARE_LIBC

10 years agounterminated comment
tedu [Fri, 18 Apr 2014 02:45:58 +0000 (02:45 +0000)]
unterminated comment

10 years agoKaboomNF
tedu [Fri, 18 Apr 2014 02:45:26 +0000 (02:45 +0000)]
KaboomNF

10 years agospelling fix from Micha Borrmann on openssl-dev
tedu [Fri, 18 Apr 2014 02:35:57 +0000 (02:35 +0000)]
spelling fix from Micha Borrmann on openssl-dev

10 years agoblunt force knf
tedu [Fri, 18 Apr 2014 01:59:00 +0000 (01:59 +0000)]
blunt force knf

10 years agoRework the command polling loop so it can handle multiple responses in a single
jmatthew [Fri, 18 Apr 2014 01:11:23 +0000 (01:11 +0000)]
Rework the command polling loop so it can handle multiple responses in a single
interrupt, as done in qla(4).

10 years agoRemove support for unwanted operating systems.
jsing [Fri, 18 Apr 2014 01:07:13 +0000 (01:07 +0000)]
Remove support for unwanted operating systems.

ok miod@

10 years agoUnifdef OPENSSL_FIPS.
jsing [Fri, 18 Apr 2014 01:04:53 +0000 (01:04 +0000)]
Unifdef OPENSSL_FIPS.

ok miod@

10 years agolob a few more knf grenades in here to soften things up.
tedu [Fri, 18 Apr 2014 00:58:49 +0000 (00:58 +0000)]
lob a few more knf grenades in here to soften things up.

10 years agoputting most of the braces in the right column is the very least we can do.
tedu [Fri, 18 Apr 2014 00:10:08 +0000 (00:10 +0000)]
putting most of the braces in the right column is the very least we can do.

10 years agoWhen iterating through fabric ports, start at our own port ID, so we can
jmatthew [Thu, 17 Apr 2014 23:53:49 +0000 (23:53 +0000)]
When iterating through fabric ports, start at our own port ID, so we can
reliably tell when we've been through the whole list.

10 years agowhack a bunch of disabled code. ok beck lteo
tedu [Thu, 17 Apr 2014 23:35:40 +0000 (23:35 +0000)]
whack a bunch of disabled code. ok beck lteo

10 years agoCopy out all mbox registers after a mailbox operation completes.
jmatthew [Thu, 17 Apr 2014 23:17:18 +0000 (23:17 +0000)]
Copy out all mbox registers after a mailbox operation completes.
Simplifies things a bit and makes pre- and post- attach operations work
the same.

10 years agoMake MONOLITH the default and only option
matthew [Thu, 17 Apr 2014 22:44:34 +0000 (22:44 +0000)]
Make MONOLITH the default and only option

ok deraadt

10 years agostab at indentation
tedu [Thu, 17 Apr 2014 22:37:59 +0000 (22:37 +0000)]
stab at indentation

10 years agodon't fake up SSIZE_MAX
tedu [Thu, 17 Apr 2014 22:23:27 +0000 (22:23 +0000)]
don't fake up SSIZE_MAX

10 years agomore windows/netware leftovers
tedu [Thu, 17 Apr 2014 22:22:28 +0000 (22:22 +0000)]
more windows/netware leftovers

10 years agodelete if 0 code
tedu [Thu, 17 Apr 2014 22:19:56 +0000 (22:19 +0000)]
delete if 0 code

10 years agomore spring VMS cleanup
giovanni [Thu, 17 Apr 2014 22:09:37 +0000 (22:09 +0000)]
more spring VMS cleanup
ok miod@ lteo@

10 years agono need for a variable which is hardcoded and only used in an snprintf,
sthen [Thu, 17 Apr 2014 22:08:45 +0000 (22:08 +0000)]
no need for a variable which is hardcoded and only used in an snprintf,
ok giovanni@. tidy comments nearby while there.

10 years agoUse !defined() rather than empty().
miod [Thu, 17 Apr 2014 22:06:19 +0000 (22:06 +0000)]
Use !defined() rather than empty().

10 years agooops, exit vs return; spotted by matthew
deraadt [Thu, 17 Apr 2014 21:55:07 +0000 (21:55 +0000)]
oops, exit vs return; spotted by matthew

10 years agounistd.h exposed after -Wall after e_os.h stops doing so; spotted by matthew
deraadt [Thu, 17 Apr 2014 21:45:45 +0000 (21:45 +0000)]
unistd.h exposed after -Wall after e_os.h stops doing so; spotted by matthew

10 years agono longer need to fool emacs indentation and other if (0) oddities.
tedu [Thu, 17 Apr 2014 21:41:12 +0000 (21:41 +0000)]
no longer need to fool emacs indentation and other if (0) oddities.

10 years agoalways build in RSA and DSA. ok deraadt miod
tedu [Thu, 17 Apr 2014 21:37:37 +0000 (21:37 +0000)]
always build in RSA and DSA. ok deraadt miod

10 years agokill REF_PRINT/REF_CHECK debugging framework noone would use
deraadt [Thu, 17 Apr 2014 21:32:37 +0000 (21:32 +0000)]
kill REF_PRINT/REF_CHECK debugging framework noone would use
ok miod

10 years agoSome VMS and WIN32 cleanup
giovanni [Thu, 17 Apr 2014 21:31:27 +0000 (21:31 +0000)]
Some VMS and WIN32 cleanup
ok miod@ lteo@

10 years agoGet rid of MS Visual C compiler and Intel C compiler specific defines.
miod [Thu, 17 Apr 2014 21:17:11 +0000 (21:17 +0000)]
Get rid of MS Visual C compiler and Intel C compiler specific defines.

10 years agoSHA and AES (and sadly MD5) can't be considered optional. ok beck miod
tedu [Thu, 17 Apr 2014 21:15:37 +0000 (21:15 +0000)]
SHA and AES (and sadly MD5) can't be considered optional. ok beck miod

10 years agoOpenBSD isn't NetWare or Windows, and it has SIGPIPE.
matthew [Thu, 17 Apr 2014 21:11:28 +0000 (21:11 +0000)]
OpenBSD isn't NetWare or Windows, and it has SIGPIPE.

ok lteo miod

10 years agoThere are no plans to ever build this with the Metrojerks compiler.
miod [Thu, 17 Apr 2014 21:10:59 +0000 (21:10 +0000)]
There are no plans to ever build this with the Metrojerks compiler.

10 years agoRemove support for big-endian i386 and amd64.
miod [Thu, 17 Apr 2014 21:07:04 +0000 (21:07 +0000)]
Remove support for big-endian i386 and amd64.

Before someone suggests the OpenSSL people are junkies, here is what they
mention about this:
/* Most will argue that x86_64 is always little-endian. Well,
 * yes, but then we have stratus.com who has modified gcc to
 * "emulate" big-endian on x86. Is there evidence that they
 * [or somebody else] won't do same for x86_64? Naturally no.
 * And this line is waiting ready for that brave soul:-) */

So, yes, they are on drugs. But they are not alone, the stratus.com people are,
too.

10 years agosince we're replacing LIST_SEPARATOR_CHAR with ':', no point using %c
sthen [Thu, 17 Apr 2014 21:04:32 +0000 (21:04 +0000)]
since we're replacing LIST_SEPARATOR_CHAR with ':', no point using %c
in the help printf

10 years agoMostly gut e_os.h:
deraadt [Thu, 17 Apr 2014 20:58:07 +0000 (20:58 +0000)]
Mostly gut e_os.h:
USE_SOCKETS is unrelated to using sockets, but just pulls in .h files.  It
makes every file buy a kitchen sink, because 11 files forgot to.
EXIT() is really exit(), a gentle surprise
but... OPENSSL_EXIT() is really just return(), because noone compiles the
openssl command non-monolithic anymore

10 years agomalloc + memset 0 -> calloc
miod [Thu, 17 Apr 2014 20:57:05 +0000 (20:57 +0000)]
malloc + memset 0 -> calloc
(not that it matters much as this is in disabled code, for we don't build with
zlib support)

10 years agodead code
tedu [Thu, 17 Apr 2014 20:47:22 +0000 (20:47 +0000)]
dead code

10 years agounused variable
tedu [Thu, 17 Apr 2014 20:44:45 +0000 (20:44 +0000)]
unused variable

10 years ago-Wall
tedu [Thu, 17 Apr 2014 20:43:42 +0000 (20:43 +0000)]
-Wall

10 years agoa little less obfuscation
tedu [Thu, 17 Apr 2014 20:42:18 +0000 (20:42 +0000)]
a little less obfuscation

10 years agofold prototypes into o_str.c. miod
tedu [Thu, 17 Apr 2014 20:40:24 +0000 (20:40 +0000)]
fold prototypes into o_str.c. miod

10 years agoquick pass at removing ability to disable sha256 and sha512. ok miod
tedu [Thu, 17 Apr 2014 20:34:24 +0000 (20:34 +0000)]
quick pass at removing ability to disable sha256 and sha512. ok miod

10 years agoAren't you glad to have this file tell you that ``C2.pl works''? Bonus point
miod [Thu, 17 Apr 2014 20:30:46 +0000 (20:30 +0000)]
Aren't you glad to have this file tell you that ``C2.pl works''? Bonus point
if you can spot C2.pl.

10 years agoNuke BN_DEBUG_LEVITTE
miod [Thu, 17 Apr 2014 20:29:19 +0000 (20:29 +0000)]
Nuke BN_DEBUG_LEVITTE

10 years agoNo need to consider being compiled by NASM anymore.
miod [Thu, 17 Apr 2014 20:18:57 +0000 (20:18 +0000)]
No need to consider being compiled by NASM anymore.

10 years agoStop paying lip service to non-AT&T syntax assemblers in the x86 world.
miod [Thu, 17 Apr 2014 20:17:45 +0000 (20:17 +0000)]
Stop paying lip service to non-AT&T syntax assemblers in the x86 world.

10 years agotodo: do not leave 15 year old todo lists in the tree.
miod [Thu, 17 Apr 2014 20:06:48 +0000 (20:06 +0000)]
todo: do not leave 15 year old todo lists in the tree.

10 years agofix BIO_snprintf usage in here.
beck [Thu, 17 Apr 2014 20:03:03 +0000 (20:03 +0000)]
fix BIO_snprintf usage in here.
ok tedu@

10 years agoUse of OPENSSL_SYS_xxx defines in public header files considered harmful.
miod [Thu, 17 Apr 2014 19:59:12 +0000 (19:59 +0000)]
Use of OPENSSL_SYS_xxx defines in public header files considered harmful.

10 years agoBob O.D.'ed on the o_dir code so high he forgot to rm the `test' after
miod [Thu, 17 Apr 2014 19:53:32 +0000 (19:53 +0000)]
Bob O.D.'ed on the o_dir code so high he forgot to rm the `test' after
rewriting the code.

10 years agosprintf: bad.
miod [Thu, 17 Apr 2014 19:33:42 +0000 (19:33 +0000)]
sprintf: bad.
snprintf: good.
snprintf with a correct size: better!
(harmless in this case)

10 years agoI'm just trying to improve the code...
tedu [Thu, 17 Apr 2014 19:28:08 +0000 (19:28 +0000)]
I'm just trying to improve the code...

10 years agoRemove utils that we don't use
afresh1 [Thu, 17 Apr 2014 19:22:31 +0000 (19:22 +0000)]
Remove utils that we don't use

opensslwrap.sh and shlib_wrap.sh are used by tests that are getting replaced,
x86asm.sh is obsoleted by our Makefile machinery

ok miod

10 years agoRemove unused ssl utils
afresh1 [Thu, 17 Apr 2014 19:20:52 +0000 (19:20 +0000)]
Remove unused ssl utils

This code is the reason perl has a name as a write only language.

ok deraadt miod

10 years agoGarbage collect one pair of needless parentheses in SQL code generation;
schwarze [Thu, 17 Apr 2014 19:19:54 +0000 (19:19 +0000)]
Garbage collect one pair of needless parentheses in SQL code generation;
note this doesn't affect performance, SQLite generates the same byte code.
While here, make the calls to exprspec() easier to understand.

10 years agoexpunge more of the old build system
afresh1 [Thu, 17 Apr 2014 19:19:14 +0000 (19:19 +0000)]
expunge more of the old build system

ok deraadt miod

10 years agowhitespace
otto [Thu, 17 Apr 2014 19:07:14 +0000 (19:07 +0000)]
whitespace

10 years agorm redundant declaration; from Xin Li
otto [Thu, 17 Apr 2014 19:06:04 +0000 (19:06 +0000)]
rm redundant declaration; from Xin Li

10 years agoRemove oh-so-important-from-a-security-pov OpenSSL_rtdsc() function.
miod [Thu, 17 Apr 2014 18:49:35 +0000 (18:49 +0000)]
Remove oh-so-important-from-a-security-pov OpenSSL_rtdsc() function.

10 years agofix some more leaks, mostly suggestions from miod
jsg [Thu, 17 Apr 2014 18:38:53 +0000 (18:38 +0000)]
fix some more leaks, mostly suggestions from miod
ok miod@

10 years agoRemove the benchmark part of the selftest. It uses the undocumented
miod [Thu, 17 Apr 2014 18:37:48 +0000 (18:37 +0000)]
Remove the benchmark part of the selftest. It uses the undocumented
OPENSSL_rdtsc() routine to get a high-precision timestamp, and (although
this is the only user of this routine in libcrypto) forces every platform
willing to provide fast assembly versions of some routines, to also
provide OPENSSL_rdtsc().

10 years agocrypto/modes/gcm128.c can be used as its own selftest. Add it to regress,
miod [Thu, 17 Apr 2014 18:33:21 +0000 (18:33 +0000)]
crypto/modes/gcm128.c can be used as its own selftest. Add it to regress,
conveniently leaving the benchmark code not compiled in the test.

10 years agoOk, there was a need for OPENSSL_cleanse() instead of bzero() to prevent
miod [Thu, 17 Apr 2014 18:16:45 +0000 (18:16 +0000)]
Ok, there was a need for OPENSSL_cleanse() instead of bzero() to prevent
supposedly smart compilers from optimizing memory cleanups away. Understood.

Ok, in case of an hypothetically super smart compiler, OPENSSL_cleanse() had
to be convoluted enough for the compiler not to recognize that this was
actually bzero() in disguise. Understood.

But then why there had been optimized assembler versions of OPENSSL_cleanse()
is beyond me. Did someone not trust the C obfuscation?

10 years agospidey senses
sthen [Thu, 17 Apr 2014 18:13:26 +0000 (18:13 +0000)]
spidey senses

10 years agoMove the machine-specific parts of the libcrypto Makefile to per-arch makefile
miod [Thu, 17 Apr 2014 18:11:46 +0000 (18:11 +0000)]
Move the machine-specific parts of the libcrypto Makefile to per-arch makefile
fragments, to ease maintainance, and see through the fog of bugs.

"looks good" deraadt@

10 years agosome KNF cleanup following the script
deraadt [Thu, 17 Apr 2014 17:50:44 +0000 (17:50 +0000)]
some KNF cleanup following the script

10 years agoInvoke OPENSSL_add_all_algorithms_noconf() to enforce OPENSSL_cpuid_setup()
miod [Thu, 17 Apr 2014 17:49:36 +0000 (17:49 +0000)]
Invoke OPENSSL_add_all_algorithms_noconf() to enforce OPENSSL_cpuid_setup()
has been called, for, depending how libcrypto, it might be a hidden symbol.
Reported by jsg@

10 years agofix some of the leaks
jsg [Thu, 17 Apr 2014 17:30:22 +0000 (17:30 +0000)]
fix some of the leaks
ok miod@ looks good deraadt@

10 years agofix a potential double free
jsg [Thu, 17 Apr 2014 17:11:10 +0000 (17:11 +0000)]
fix a potential double free
ok miod@

10 years agoremove OPENSSL_realloc_clean usage here - replace with intrinsics to make
beck [Thu, 17 Apr 2014 16:30:59 +0000 (16:30 +0000)]
remove OPENSSL_realloc_clean usage here - replace with intrinsics to make
it obvious what should happen.
ok tedu@

10 years agoFully kill FIPS API. Forcible certification conflicts with the goals of a
tedu [Thu, 17 Apr 2014 16:17:41 +0000 (16:17 +0000)]
Fully kill FIPS API. Forcible certification conflicts with the goals of a
free software project. ok beck deraadt

Ports calling FIPS_mode_set(1): mongodb

10 years agoInitial KNF.
jsing [Thu, 17 Apr 2014 16:14:15 +0000 (16:14 +0000)]
Initial KNF.

10 years ago#nnT went away a while ago, remove a leftover from the manpage.
nicm [Thu, 17 Apr 2014 15:48:02 +0000 (15:48 +0000)]
#nnT went away a while ago, remove a leftover from the manpage.

10 years agoInitial KNF.
jsing [Thu, 17 Apr 2014 15:43:33 +0000 (15:43 +0000)]
Initial KNF.

10 years agoAdd some UTF-8 utility functions and use them to prevent the width limit
nicm [Thu, 17 Apr 2014 15:37:55 +0000 (15:37 +0000)]
Add some UTF-8 utility functions and use them to prevent the width limit
on formats from splitting UTF-8 characters improperly.

10 years agoSync show.c with the route version. Make the two files more similar but
claudio [Thu, 17 Apr 2014 15:36:53 +0000 (15:36 +0000)]
Sync show.c with the route version. Make the two files more similar but
still not identical. OK sthen@ mpi@ jca@

10 years agoSync show.c to what we have in netstat.c (at least steal some good idioms
claudio [Thu, 17 Apr 2014 15:35:35 +0000 (15:35 +0000)]
Sync show.c to what we have in netstat.c (at least steal some good idioms
from there). OK sthen@ mpi@ jca@

10 years agoInitial KNF.
jsing [Thu, 17 Apr 2014 15:30:56 +0000 (15:30 +0000)]
Initial KNF.

10 years agoDon't default enable the debug functionality with its unprotected getenv().
guenther [Thu, 17 Apr 2014 15:28:26 +0000 (15:28 +0000)]
Don't default enable the debug functionality with its unprotected getenv().

ok eric@ sthen@ deraadt@

10 years agoMore KNF.
jsing [Thu, 17 Apr 2014 15:17:22 +0000 (15:17 +0000)]
More KNF.

10 years agoMore KNF.
jsing [Thu, 17 Apr 2014 15:12:00 +0000 (15:12 +0000)]
More KNF.

10 years agoMake sure the original thread is blocked until any other threads are
guenther [Thu, 17 Apr 2014 14:52:50 +0000 (14:52 +0000)]
Make sure the original thread is blocked until any other threads are
completely detached from the process before letting it exit, so that
sleeping in systrace_exit() doesn't reorder them and lead to a panic.

Panic reported by Fabian Raetz (fabian.raetz (at) gmail.com)
ok tedu@

10 years agoremove special case for uucp entries.
okan [Thu, 17 Apr 2014 14:49:11 +0000 (14:49 +0000)]
remove special case for uucp entries.

ok guenther

10 years agoSome more long lines.
nicm [Thu, 17 Apr 2014 14:45:49 +0000 (14:45 +0000)]
Some more long lines.

10 years agoInitial KNF.
jsing [Thu, 17 Apr 2014 14:43:34 +0000 (14:43 +0000)]
Initial KNF.

10 years agoI've replaced everything in this file. ISC liscense it with my copyright
beck [Thu, 17 Apr 2014 14:28:44 +0000 (14:28 +0000)]
I've replaced everything in this file. ISC liscense it with my copyright

10 years agoInitial KNF.
jsing [Thu, 17 Apr 2014 14:24:41 +0000 (14:24 +0000)]
Initial KNF.

10 years agoOnly scroll by one line at a time in choose mode, lists are generally
nicm [Thu, 17 Apr 2014 14:13:59 +0000 (14:13 +0000)]
Only scroll by one line at a time in choose mode, lists are generally
pretty small.

10 years agoRemove defines for unwanted OS support...
jsing [Thu, 17 Apr 2014 14:09:44 +0000 (14:09 +0000)]
Remove defines for unwanted OS support...

ok miod@

10 years agoremove some code that is now unused after guenther's changes in 1.20.
jsg [Thu, 17 Apr 2014 14:08:57 +0000 (14:08 +0000)]
remove some code that is now unused after guenther's changes in 1.20.

10 years agoKNF.
jsing [Thu, 17 Apr 2014 13:58:39 +0000 (13:58 +0000)]
KNF.

10 years agoInitial KNF.
jsing [Thu, 17 Apr 2014 13:58:24 +0000 (13:58 +0000)]
Initial KNF.

10 years agoOops. INADDR_ANY != INADDR_BROADCAST. Fixes DHCPDISCOVERY and
krw [Thu, 17 Apr 2014 13:46:48 +0000 (13:46 +0000)]
Oops. INADDR_ANY != INADDR_BROADCAST. Fixes DHCPDISCOVERY and
DHCPDECLINE.

noted by sthen@