jsing [Fri, 18 Apr 2014 05:37:44 +0000 (05:37 +0000)]
More KNF.
jmatthew [Fri, 18 Apr 2014 05:08:15 +0000 (05:08 +0000)]
Implement qle_fabric_plogo and let qle_fabric_plogi look at the response that
comes back, so later on we can work out what to do when logins fail
tedu [Fri, 18 Apr 2014 04:33:09 +0000 (04:33 +0000)]
whitespace normalization
tedu [Fri, 18 Apr 2014 04:23:53 +0000 (04:23 +0000)]
repair whitespace. this is what happens when functions take 20 params.
jsing [Fri, 18 Apr 2014 04:17:16 +0000 (04:17 +0000)]
Remove MAIN and PROG defines now that we do not compile non-monolithic.
ok tedu@
jsg [Fri, 18 Apr 2014 03:37:43 +0000 (03:37 +0000)]
igetest.c moved to regress we don't need another copy
ok miod@
jsg [Fri, 18 Apr 2014 03:28:12 +0000 (03:28 +0000)]
fix another potential double free
ok miod@ lteo@ jca@
tedu [Fri, 18 Apr 2014 02:56:48 +0000 (02:56 +0000)]
-netware
tedu [Fri, 18 Apr 2014 02:48:58 +0000 (02:48 +0000)]
undef NETWARE_CLIB and NETWARE_LIBC
tedu [Fri, 18 Apr 2014 02:45:58 +0000 (02:45 +0000)]
unterminated comment
tedu [Fri, 18 Apr 2014 02:45:26 +0000 (02:45 +0000)]
KaboomNF
tedu [Fri, 18 Apr 2014 02:35:57 +0000 (02:35 +0000)]
spelling fix from Micha Borrmann on openssl-dev
tedu [Fri, 18 Apr 2014 01:59:00 +0000 (01:59 +0000)]
blunt force knf
jmatthew [Fri, 18 Apr 2014 01:11:23 +0000 (01:11 +0000)]
Rework the command polling loop so it can handle multiple responses in a single
interrupt, as done in qla(4).
jsing [Fri, 18 Apr 2014 01:07:13 +0000 (01:07 +0000)]
Remove support for unwanted operating systems.
ok miod@
jsing [Fri, 18 Apr 2014 01:04:53 +0000 (01:04 +0000)]
Unifdef OPENSSL_FIPS.
ok miod@
tedu [Fri, 18 Apr 2014 00:58:49 +0000 (00:58 +0000)]
lob a few more knf grenades in here to soften things up.
tedu [Fri, 18 Apr 2014 00:10:08 +0000 (00:10 +0000)]
putting most of the braces in the right column is the very least we can do.
jmatthew [Thu, 17 Apr 2014 23:53:49 +0000 (23:53 +0000)]
When iterating through fabric ports, start at our own port ID, so we can
reliably tell when we've been through the whole list.
tedu [Thu, 17 Apr 2014 23:35:40 +0000 (23:35 +0000)]
whack a bunch of disabled code. ok beck lteo
jmatthew [Thu, 17 Apr 2014 23:17:18 +0000 (23:17 +0000)]
Copy out all mbox registers after a mailbox operation completes.
Simplifies things a bit and makes pre- and post- attach operations work
the same.
matthew [Thu, 17 Apr 2014 22:44:34 +0000 (22:44 +0000)]
Make MONOLITH the default and only option
ok deraadt
tedu [Thu, 17 Apr 2014 22:37:59 +0000 (22:37 +0000)]
stab at indentation
tedu [Thu, 17 Apr 2014 22:23:27 +0000 (22:23 +0000)]
don't fake up SSIZE_MAX
tedu [Thu, 17 Apr 2014 22:22:28 +0000 (22:22 +0000)]
more windows/netware leftovers
tedu [Thu, 17 Apr 2014 22:19:56 +0000 (22:19 +0000)]
delete if 0 code
giovanni [Thu, 17 Apr 2014 22:09:37 +0000 (22:09 +0000)]
more spring VMS cleanup
ok miod@ lteo@
sthen [Thu, 17 Apr 2014 22:08:45 +0000 (22:08 +0000)]
no need for a variable which is hardcoded and only used in an snprintf,
ok giovanni@. tidy comments nearby while there.
miod [Thu, 17 Apr 2014 22:06:19 +0000 (22:06 +0000)]
Use !defined() rather than empty().
deraadt [Thu, 17 Apr 2014 21:55:07 +0000 (21:55 +0000)]
oops, exit vs return; spotted by matthew
deraadt [Thu, 17 Apr 2014 21:45:45 +0000 (21:45 +0000)]
unistd.h exposed after -Wall after e_os.h stops doing so; spotted by matthew
tedu [Thu, 17 Apr 2014 21:41:12 +0000 (21:41 +0000)]
no longer need to fool emacs indentation and other if (0) oddities.
tedu [Thu, 17 Apr 2014 21:37:37 +0000 (21:37 +0000)]
always build in RSA and DSA. ok deraadt miod
deraadt [Thu, 17 Apr 2014 21:32:37 +0000 (21:32 +0000)]
kill REF_PRINT/REF_CHECK debugging framework noone would use
ok miod
giovanni [Thu, 17 Apr 2014 21:31:27 +0000 (21:31 +0000)]
Some VMS and WIN32 cleanup
ok miod@ lteo@
miod [Thu, 17 Apr 2014 21:17:11 +0000 (21:17 +0000)]
Get rid of MS Visual C compiler and Intel C compiler specific defines.
tedu [Thu, 17 Apr 2014 21:15:37 +0000 (21:15 +0000)]
SHA and AES (and sadly MD5) can't be considered optional. ok beck miod
matthew [Thu, 17 Apr 2014 21:11:28 +0000 (21:11 +0000)]
OpenBSD isn't NetWare or Windows, and it has SIGPIPE.
ok lteo miod
miod [Thu, 17 Apr 2014 21:10:59 +0000 (21:10 +0000)]
There are no plans to ever build this with the Metrojerks compiler.
miod [Thu, 17 Apr 2014 21:07:04 +0000 (21:07 +0000)]
Remove support for big-endian i386 and amd64.
Before someone suggests the OpenSSL people are junkies, here is what they
mention about this:
/* Most will argue that x86_64 is always little-endian. Well,
* yes, but then we have stratus.com who has modified gcc to
* "emulate" big-endian on x86. Is there evidence that they
* [or somebody else] won't do same for x86_64? Naturally no.
* And this line is waiting ready for that brave soul:-) */
So, yes, they are on drugs. But they are not alone, the stratus.com people are,
too.
sthen [Thu, 17 Apr 2014 21:04:32 +0000 (21:04 +0000)]
since we're replacing LIST_SEPARATOR_CHAR with ':', no point using %c
in the help printf
deraadt [Thu, 17 Apr 2014 20:58:07 +0000 (20:58 +0000)]
Mostly gut e_os.h:
USE_SOCKETS is unrelated to using sockets, but just pulls in .h files. It
makes every file buy a kitchen sink, because 11 files forgot to.
EXIT() is really exit(), a gentle surprise
but... OPENSSL_EXIT() is really just return(), because noone compiles the
openssl command non-monolithic anymore
miod [Thu, 17 Apr 2014 20:57:05 +0000 (20:57 +0000)]
malloc + memset 0 -> calloc
(not that it matters much as this is in disabled code, for we don't build with
zlib support)
tedu [Thu, 17 Apr 2014 20:47:22 +0000 (20:47 +0000)]
dead code
tedu [Thu, 17 Apr 2014 20:44:45 +0000 (20:44 +0000)]
unused variable
tedu [Thu, 17 Apr 2014 20:43:42 +0000 (20:43 +0000)]
-Wall
tedu [Thu, 17 Apr 2014 20:42:18 +0000 (20:42 +0000)]
a little less obfuscation
tedu [Thu, 17 Apr 2014 20:40:24 +0000 (20:40 +0000)]
fold prototypes into o_str.c. miod
tedu [Thu, 17 Apr 2014 20:34:24 +0000 (20:34 +0000)]
quick pass at removing ability to disable sha256 and sha512. ok miod
miod [Thu, 17 Apr 2014 20:30:46 +0000 (20:30 +0000)]
Aren't you glad to have this file tell you that ``C2.pl works''? Bonus point
if you can spot C2.pl.
miod [Thu, 17 Apr 2014 20:29:19 +0000 (20:29 +0000)]
Nuke BN_DEBUG_LEVITTE
miod [Thu, 17 Apr 2014 20:18:57 +0000 (20:18 +0000)]
No need to consider being compiled by NASM anymore.
miod [Thu, 17 Apr 2014 20:17:45 +0000 (20:17 +0000)]
Stop paying lip service to non-AT&T syntax assemblers in the x86 world.
miod [Thu, 17 Apr 2014 20:06:48 +0000 (20:06 +0000)]
todo: do not leave 15 year old todo lists in the tree.
beck [Thu, 17 Apr 2014 20:03:03 +0000 (20:03 +0000)]
fix BIO_snprintf usage in here.
ok tedu@
miod [Thu, 17 Apr 2014 19:59:12 +0000 (19:59 +0000)]
Use of OPENSSL_SYS_xxx defines in public header files considered harmful.
miod [Thu, 17 Apr 2014 19:53:32 +0000 (19:53 +0000)]
Bob O.D.'ed on the o_dir code so high he forgot to rm the `test' after
rewriting the code.
miod [Thu, 17 Apr 2014 19:33:42 +0000 (19:33 +0000)]
sprintf: bad.
snprintf: good.
snprintf with a correct size: better!
(harmless in this case)
tedu [Thu, 17 Apr 2014 19:28:08 +0000 (19:28 +0000)]
I'm just trying to improve the code...
afresh1 [Thu, 17 Apr 2014 19:22:31 +0000 (19:22 +0000)]
Remove utils that we don't use
opensslwrap.sh and shlib_wrap.sh are used by tests that are getting replaced,
x86asm.sh is obsoleted by our Makefile machinery
ok miod
afresh1 [Thu, 17 Apr 2014 19:20:52 +0000 (19:20 +0000)]
Remove unused ssl utils
This code is the reason perl has a name as a write only language.
ok deraadt miod
schwarze [Thu, 17 Apr 2014 19:19:54 +0000 (19:19 +0000)]
Garbage collect one pair of needless parentheses in SQL code generation;
note this doesn't affect performance, SQLite generates the same byte code.
While here, make the calls to exprspec() easier to understand.
afresh1 [Thu, 17 Apr 2014 19:19:14 +0000 (19:19 +0000)]
expunge more of the old build system
ok deraadt miod
otto [Thu, 17 Apr 2014 19:07:14 +0000 (19:07 +0000)]
whitespace
otto [Thu, 17 Apr 2014 19:06:04 +0000 (19:06 +0000)]
rm redundant declaration; from Xin Li
miod [Thu, 17 Apr 2014 18:49:35 +0000 (18:49 +0000)]
Remove oh-so-important-from-a-security-pov OpenSSL_rtdsc() function.
jsg [Thu, 17 Apr 2014 18:38:53 +0000 (18:38 +0000)]
fix some more leaks, mostly suggestions from miod
ok miod@
miod [Thu, 17 Apr 2014 18:37:48 +0000 (18:37 +0000)]
Remove the benchmark part of the selftest. It uses the undocumented
OPENSSL_rdtsc() routine to get a high-precision timestamp, and (although
this is the only user of this routine in libcrypto) forces every platform
willing to provide fast assembly versions of some routines, to also
provide OPENSSL_rdtsc().
miod [Thu, 17 Apr 2014 18:33:21 +0000 (18:33 +0000)]
crypto/modes/gcm128.c can be used as its own selftest. Add it to regress,
conveniently leaving the benchmark code not compiled in the test.
miod [Thu, 17 Apr 2014 18:16:45 +0000 (18:16 +0000)]
Ok, there was a need for OPENSSL_cleanse() instead of bzero() to prevent
supposedly smart compilers from optimizing memory cleanups away. Understood.
Ok, in case of an hypothetically super smart compiler, OPENSSL_cleanse() had
to be convoluted enough for the compiler not to recognize that this was
actually bzero() in disguise. Understood.
But then why there had been optimized assembler versions of OPENSSL_cleanse()
is beyond me. Did someone not trust the C obfuscation?
sthen [Thu, 17 Apr 2014 18:13:26 +0000 (18:13 +0000)]
spidey senses
miod [Thu, 17 Apr 2014 18:11:46 +0000 (18:11 +0000)]
Move the machine-specific parts of the libcrypto Makefile to per-arch makefile
fragments, to ease maintainance, and see through the fog of bugs.
"looks good" deraadt@
deraadt [Thu, 17 Apr 2014 17:50:44 +0000 (17:50 +0000)]
some KNF cleanup following the script
miod [Thu, 17 Apr 2014 17:49:36 +0000 (17:49 +0000)]
Invoke OPENSSL_add_all_algorithms_noconf() to enforce OPENSSL_cpuid_setup()
has been called, for, depending how libcrypto, it might be a hidden symbol.
Reported by jsg@
jsg [Thu, 17 Apr 2014 17:30:22 +0000 (17:30 +0000)]
fix some of the leaks
ok miod@ looks good deraadt@
jsg [Thu, 17 Apr 2014 17:11:10 +0000 (17:11 +0000)]
fix a potential double free
ok miod@
beck [Thu, 17 Apr 2014 16:30:59 +0000 (16:30 +0000)]
remove OPENSSL_realloc_clean usage here - replace with intrinsics to make
it obvious what should happen.
ok tedu@
tedu [Thu, 17 Apr 2014 16:17:41 +0000 (16:17 +0000)]
Fully kill FIPS API. Forcible certification conflicts with the goals of a
free software project. ok beck deraadt
Ports calling FIPS_mode_set(1): mongodb
jsing [Thu, 17 Apr 2014 16:14:15 +0000 (16:14 +0000)]
Initial KNF.
nicm [Thu, 17 Apr 2014 15:48:02 +0000 (15:48 +0000)]
#nnT went away a while ago, remove a leftover from the manpage.
jsing [Thu, 17 Apr 2014 15:43:33 +0000 (15:43 +0000)]
Initial KNF.
nicm [Thu, 17 Apr 2014 15:37:55 +0000 (15:37 +0000)]
Add some UTF-8 utility functions and use them to prevent the width limit
on formats from splitting UTF-8 characters improperly.
claudio [Thu, 17 Apr 2014 15:36:53 +0000 (15:36 +0000)]
Sync show.c with the route version. Make the two files more similar but
still not identical. OK sthen@ mpi@ jca@
claudio [Thu, 17 Apr 2014 15:35:35 +0000 (15:35 +0000)]
Sync show.c to what we have in netstat.c (at least steal some good idioms
from there). OK sthen@ mpi@ jca@
jsing [Thu, 17 Apr 2014 15:30:56 +0000 (15:30 +0000)]
Initial KNF.
guenther [Thu, 17 Apr 2014 15:28:26 +0000 (15:28 +0000)]
Don't default enable the debug functionality with its unprotected getenv().
ok eric@ sthen@ deraadt@
jsing [Thu, 17 Apr 2014 15:17:22 +0000 (15:17 +0000)]
More KNF.
jsing [Thu, 17 Apr 2014 15:12:00 +0000 (15:12 +0000)]
More KNF.
guenther [Thu, 17 Apr 2014 14:52:50 +0000 (14:52 +0000)]
Make sure the original thread is blocked until any other threads are
completely detached from the process before letting it exit, so that
sleeping in systrace_exit() doesn't reorder them and lead to a panic.
Panic reported by Fabian Raetz (fabian.raetz (at) gmail.com)
ok tedu@
okan [Thu, 17 Apr 2014 14:49:11 +0000 (14:49 +0000)]
remove special case for uucp entries.
ok guenther
nicm [Thu, 17 Apr 2014 14:45:49 +0000 (14:45 +0000)]
Some more long lines.
jsing [Thu, 17 Apr 2014 14:43:34 +0000 (14:43 +0000)]
Initial KNF.
beck [Thu, 17 Apr 2014 14:28:44 +0000 (14:28 +0000)]
I've replaced everything in this file. ISC liscense it with my copyright
jsing [Thu, 17 Apr 2014 14:24:41 +0000 (14:24 +0000)]
Initial KNF.
nicm [Thu, 17 Apr 2014 14:13:59 +0000 (14:13 +0000)]
Only scroll by one line at a time in choose mode, lists are generally
pretty small.
jsing [Thu, 17 Apr 2014 14:09:44 +0000 (14:09 +0000)]
Remove defines for unwanted OS support...
ok miod@
jsg [Thu, 17 Apr 2014 14:08:57 +0000 (14:08 +0000)]
remove some code that is now unused after guenther's changes in 1.20.
jsing [Thu, 17 Apr 2014 13:58:39 +0000 (13:58 +0000)]
KNF.
jsing [Thu, 17 Apr 2014 13:58:24 +0000 (13:58 +0000)]
Initial KNF.
krw [Thu, 17 Apr 2014 13:46:48 +0000 (13:46 +0000)]
Oops. INADDR_ANY != INADDR_BROADCAST. Fixes DHCPDISCOVERY and
DHCPDECLINE.
noted by sthen@