deraadt [Tue, 22 Feb 2022 03:35:36 +0000 (03:35 +0000)]
The include of sys/ktrace.h will require sys/types.h, so document this.
deraadt [Tue, 22 Feb 2022 03:34:51 +0000 (03:34 +0000)]
The FILL_KPROC() macro should be useable in situations where sys/param.h
hasn't been included, so the use of MIN() is not legit, and a local
version is required.
deraadt [Tue, 22 Feb 2022 03:33:12 +0000 (03:33 +0000)]
need a local nitems() definition
deraadt [Tue, 22 Feb 2022 03:31:50 +0000 (03:31 +0000)]
need a local nitems() definition
guenther [Tue, 22 Feb 2022 01:35:40 +0000 (01:35 +0000)]
Delete unnecessary #includes of <netinet6/ip6protosw.h>: some never
needed it and some no longer need it after moving the externs from
there to <sys/protosw.h>
ok jsg@
guenther [Tue, 22 Feb 2022 01:15:01 +0000 (01:15 +0000)]
Delete unnecessary #includes of <sys/domain.h> and/or <sys/protosw.h>
net/if_pppx.c pointed out by jsg@
ok gnezdo@ deraadt@ jsg@ mpi@ millert@
guenther [Tue, 22 Feb 2022 01:02:57 +0000 (01:02 +0000)]
Move declarations of ip6_protox[] and inet6sw[] to <sys/protosw.h>
where the IPv4 versions have been forever
ok gnezdo@ deraadt@ jsg@ mpi@ millert@
guenther [Tue, 22 Feb 2022 01:01:02 +0000 (01:01 +0000)]
pfctlinput() is already declared in <sys/protosw.h>, which is
more specific and appropriate, so delete it here
ok gnezdo@ deraadt@ jsg@ mpi@ millert@
mestre [Mon, 21 Feb 2022 19:49:46 +0000 (19:49 +0000)]
unveil(2) "/dev" read-only instead of using chroot(2)/chdir(2). after calling
the latter the program then also calls stat(2) and therefore it never actually
worked correctly since they were added almost 20 years now.
while here remove an implementation detail from the manpage which covered the
chroot part.
pointed out by and ok deraadt@
kettenis [Mon, 21 Feb 2022 19:22:21 +0000 (19:22 +0000)]
Convert KVA allocation to km_alloc(9).
ok mpi@
kettenis [Mon, 21 Feb 2022 19:18:52 +0000 (19:18 +0000)]
Convert KVA allocation to km_alloc(9).
ok mpi@
kettenis [Mon, 21 Feb 2022 19:17:51 +0000 (19:17 +0000)]
Convert KVA allocation to km_alloc(9).
ok gkoehler@
kettenis [Mon, 21 Feb 2022 19:15:58 +0000 (19:15 +0000)]
Convert KVA allocation to km_alloc(9).
ok mpi@
jsing [Mon, 21 Feb 2022 18:22:20 +0000 (18:22 +0000)]
Factor out alert handing code in the legacy stack.
Pull out the code that processes incoming alerts - a chunk of the
complexity is due to the fact that in TLSv1.2 and earlier, alerts can be
fragmented across multiple records or multiple alerts can be delivered
in a single record.
In DTLS there is no way that we can reassemble fragmented alerts (although
the RFC is silent on this), however we could have multiple alerts in the
same record. This change means that we will handle this situation more
appropriately and if we encounter a fragmented alert we will now treat this
as a decode error (instead of silently ignoring it).
ok beck@ tb@
kn [Mon, 21 Feb 2022 16:08:36 +0000 (16:08 +0000)]
Grab vmobjlocks with RW_DUPOK in vm_obj_wire() to silence WITNESS
The drm subsystem implements graphics buffers as uvm objects backed by
anonymous memory, thus drm locks and aobj locks share the same "vmobjlock"
type.
uvm_obj_wire() is only called from sys/dev/pci/drm/, so instead of changing
drm's lock init/alloc routines to mark allow duplicate locks in general,
enter uvm's vmobjlock with RW_DUPOK in this function to allow duplicate
lock types per thread in this specific call path alone.
Fixes the following WITNESS report when booting/starting X (as seen already
in other unrelated bugs@ reports):
wsdisplay0: screen 1-5 added (std, vt100 emulation)
witness: acquiring duplicate lock of same type: "&uobj->vmobjlock"
1st uobjlk
2nd uobjlk
Starting stack trace...
witness_checkorder(
fffffd83b625f9b0,9,0) at witness_checkorder+0x8ac
rw_enter(
fffffd83b625f9a0,1) at rw_enter+0x68
uvm_obj_wire(
fffffd843c39e948,0,40000,
ffff800033b70428) at uvm_obj_wire+0x46
shmem_get_pages(
ffff800008008500) at shmem_get_pages+0xb8
__i915_gem_object_get_pages(
ffff800008008500) at __i915_gem_object_get_pages+0x6d
i915_gem_fault(
ffff800008008500,
ffff800033b707c0,
10009b000,
a43d6b1c000,
ffff800033b70740,1,
35ba896911df1241,
ffff8000000aa078,
ffff8000000aa178) at i915_gem_fault+0x203
drm_fault(
ffff800033b707c0,
a43d6b1c000,
ffff800033b70740,1,0,0,
7eca45006f70ee0,
ffff800033b707c0) at drm_fault+0x156
uvm_fault(
fffffd843a7cf480,
a43d6b1c000,0,2) at uvm_fault+0x179
upageflttrap(
ffff800033b70920,
a43d6b1c000) at upageflttrap+0x62
usertrap(
ffff800033b70920) at usertrap+0x129
recall_trap() at recall_trap+0x8
end of kernel
end trace frame: 0x7f7ffffdc7c0, count: 246
End of stack trace.
Input kettenis
OK mpi
jsg [Mon, 21 Feb 2022 14:26:19 +0000 (14:26 +0000)]
aligend -> aligned
jsg [Mon, 21 Feb 2022 14:21:58 +0000 (14:21 +0000)]
ambigus -> ambiguous
jsg [Mon, 21 Feb 2022 14:16:49 +0000 (14:16 +0000)]
anscestors -> ancestors
jsg [Mon, 21 Feb 2022 13:51:04 +0000 (13:51 +0000)]
consisitent -> consistent
jsg [Mon, 21 Feb 2022 13:32:45 +0000 (13:32 +0000)]
cululative -> cumulative
jsg [Mon, 21 Feb 2022 12:53:39 +0000 (12:53 +0000)]
differenent -> different
jsg [Mon, 21 Feb 2022 12:46:59 +0000 (12:46 +0000)]
disatcher -> dispatcher
jsg [Mon, 21 Feb 2022 12:41:39 +0000 (12:41 +0000)]
diviedr -> divider
jsg [Mon, 21 Feb 2022 12:36:21 +0000 (12:36 +0000)]
dmammem -> dmamem
jsg [Mon, 21 Feb 2022 12:22:21 +0000 (12:22 +0000)]
enries -> entries
jsg [Mon, 21 Feb 2022 12:18:54 +0000 (12:18 +0000)]
entried -> entries
jsg [Mon, 21 Feb 2022 12:16:55 +0000 (12:16 +0000)]
entris -> entries
jsg [Mon, 21 Feb 2022 12:09:15 +0000 (12:09 +0000)]
expliclitly -> explicitly
jsg [Mon, 21 Feb 2022 11:43:02 +0000 (11:43 +0000)]
futther -> further
jsg [Mon, 21 Feb 2022 11:20:34 +0000 (11:20 +0000)]
ignorint -> ignoring
jsg [Mon, 21 Feb 2022 11:15:09 +0000 (11:15 +0000)]
implenent -> implement
jsg [Mon, 21 Feb 2022 11:09:52 +0000 (11:09 +0000)]
independednt -> independent, let's -> lets
mpi [Mon, 21 Feb 2022 11:03:39 +0000 (11:03 +0000)]
Constify struct cfattach.
jsg [Mon, 21 Feb 2022 10:57:58 +0000 (10:57 +0000)]
initializion -> initialization
jsg [Mon, 21 Feb 2022 10:51:36 +0000 (10:51 +0000)]
initiailze -> initialize
jsg [Mon, 21 Feb 2022 10:44:58 +0000 (10:44 +0000)]
instructinos -> instructions
jsg [Mon, 21 Feb 2022 10:38:50 +0000 (10:38 +0000)]
interrunts -> interrupts
jsg [Mon, 21 Feb 2022 10:26:20 +0000 (10:26 +0000)]
interting -> inserting
mpi [Mon, 21 Feb 2022 10:24:28 +0000 (10:24 +0000)]
Constify struct cfattach.
jsg [Mon, 21 Feb 2022 10:20:51 +0000 (10:20 +0000)]
iommmu -> iommu
jsg [Mon, 21 Feb 2022 10:06:35 +0000 (10:06 +0000)]
lenghy -> lengthy
jsg [Mon, 21 Feb 2022 09:57:18 +0000 (09:57 +0000)]
mappiing -> mapping
jsg [Mon, 21 Feb 2022 08:50:18 +0000 (08:50 +0000)]
splitted -> split, necesssary -> necessary
jsg [Mon, 21 Feb 2022 08:27:51 +0000 (08:27 +0000)]
onbard -> onboard
jsg [Mon, 21 Feb 2022 08:16:08 +0000 (08:16 +0000)]
opearting -> operating
jsg [Mon, 21 Feb 2022 07:15:42 +0000 (07:15 +0000)]
receice -> receive
robert [Mon, 21 Feb 2022 06:38:57 +0000 (06:38 +0000)]
cap the daemon login class' datasize at either 1G or 4G depending on
the architecture and set the bgpd class' datasize to either 16G or 1G
ok sthen@ and discussed with many
jsg [Mon, 21 Feb 2022 05:54:35 +0000 (05:54 +0000)]
tempterature -> temperature
dlg [Mon, 21 Feb 2022 05:19:07 +0000 (05:19 +0000)]
in input, clear the address union before putting an ipv4 address in it.
the whole vxlan address is used for lookups in the RB tree, so any
garbage on the stack where the address sits could confuse the lookup.
it looks like i was lucky before, but if you receive vxlan over
ipsec you are less lucky.
found by and fix tested by jason tubnor.
jmatthew [Mon, 21 Feb 2022 03:50:46 +0000 (03:50 +0000)]
If the signature on an icmp echo reply doesn't match, don't count it as
a reply we've received, and print out the source address and sequence number
as that might help the user understand what's going on.
ok florian@ dlg@
deraadt [Mon, 21 Feb 2022 00:56:06 +0000 (00:56 +0000)]
sync
kn [Mon, 21 Feb 2022 00:37:47 +0000 (00:37 +0000)]
USE_CCACHE does not add a dependency
OK jca sthen
dlg [Mon, 21 Feb 2022 00:36:22 +0000 (00:36 +0000)]
vxlan sending to a mcast group needs an interface specified for that group
ok anton@
jsg [Mon, 21 Feb 2022 00:22:03 +0000 (00:22 +0000)]
mutibyte -> multibyte
jsg [Sun, 20 Feb 2022 23:14:36 +0000 (23:14 +0000)]
dmameme -> dmamem
dlg [Sun, 20 Feb 2022 23:11:01 +0000 (23:11 +0000)]
i missed a word.
some other tweaks for readability or brevity while here
deraadt [Sun, 20 Feb 2022 22:50:49 +0000 (22:50 +0000)]
sync
afresh1 [Sun, 20 Feb 2022 21:53:04 +0000 (21:53 +0000)]
Only use /snapshots dir when -current
Not during release, -stable, or -beta.
This diverges from how packages work and how things were done in the past
where -beta also looked in /snapshots.
Discussed in icb.
OK deraadt@
sthen [Sun, 20 Feb 2022 20:54:29 +0000 (20:54 +0000)]
we should be 7.1-beta not 7.1-current
naddy [Sun, 20 Feb 2022 20:28:57 +0000 (20:28 +0000)]
7.2 packages key
jmc [Sun, 20 Feb 2022 20:01:04 +0000 (20:01 +0000)]
space required between macro argument and punctuation;
tb [Sun, 20 Feb 2022 19:59:29 +0000 (19:59 +0000)]
Add missing newlines in two DPRINTFs (from Matthew Martin)
Tweak capitalization (from jmc)
tb [Sun, 20 Feb 2022 19:45:51 +0000 (19:45 +0000)]
Fix vi recovery mode.
From trondd, tested by various
ok afresh1
kettenis [Sun, 20 Feb 2022 19:33:48 +0000 (19:33 +0000)]
aplcpu(4)
kettenis [Sun, 20 Feb 2022 19:25:57 +0000 (19:25 +0000)]
Add aplcpu(4), a driver to control the CPU performance levels on Apple SoCs.
ok gnezdo@
afresh1 [Sun, 20 Feb 2022 19:24:19 +0000 (19:24 +0000)]
Remove downloaded SHA256.sig if signature validation fails
Without the "noclobber" setting we would have overwitten with an empty
file and best not to leave a failed file around.
Noticed by florian@
florian [Sun, 20 Feb 2022 19:18:16 +0000 (19:18 +0000)]
Nameservers in router advertisements are struct in6_addr, not
struct sockaddr_in6. Copy the right amount of data so that we don't
overflow the destination and potentially crash when we receive more
than 7 nameservers.
This is going to be 7.0 errata 014.
OK deraadt
tb [Sun, 20 Feb 2022 19:16:34 +0000 (19:16 +0000)]
Fix a buffer overread in OAEP padding removal
This only occurs on very small payloads and tightly allocated buffers
that don't usually occur in practice.
This is OpenSSL
f61c6804
ok inoguchi jsing
deraadt [Sun, 20 Feb 2022 18:23:28 +0000 (18:23 +0000)]
sync
afresh1 [Sun, 20 Feb 2022 18:06:05 +0000 (18:06 +0000)]
Show summary even if no firmware are detected or installed
OK florian@
deraadt [Sun, 20 Feb 2022 17:21:56 +0000 (17:21 +0000)]
7.2 base key
deraadt [Sun, 20 Feb 2022 17:11:05 +0000 (17:11 +0000)]
move to 7.1-beta
jsg [Sun, 20 Feb 2022 15:39:55 +0000 (15:39 +0000)]
audo -> audio
jsg [Sun, 20 Feb 2022 15:21:15 +0000 (15:21 +0000)]
John P. Wittkowski -> John P. Wittkoski
matches adb.c and adb(4)
jsg [Sun, 20 Feb 2022 15:01:03 +0000 (15:01 +0000)]
Wildire -> Wildfire
jsing [Sun, 20 Feb 2022 13:47:53 +0000 (13:47 +0000)]
Test OBJ_obj2txt() with NULL and short buffers.
dtucker [Sun, 20 Feb 2022 03:47:26 +0000 (03:47 +0000)]
Aproximate realpath on the expected output by deduping leading slashes.
Fixes test failure when user's home dir is / which is possible in some
portable configurations.
deraadt [Sun, 20 Feb 2022 00:09:29 +0000 (00:09 +0000)]
sys/proc.h requires sys/signal.h (will become visible when sys/param.h
is removed)
deraadt [Sat, 19 Feb 2022 23:57:09 +0000 (23:57 +0000)]
The suspend/resume code sleeps-not-allowed phases are protected with
cold=2. Use the same strategy in a a similar phase during hibernate.
deraadt [Sat, 19 Feb 2022 23:56:18 +0000 (23:56 +0000)]
tsleep() prints a stack trace when cold==2. The suspend/resume code has
phases where sleeps are not allowed, and this used to discover it.
msleep() needs the same check.
jsg [Sat, 19 Feb 2022 23:45:51 +0000 (23:45 +0000)]
don't refer to disks as daughter devices
ok jmc@
krw [Sat, 19 Feb 2022 22:08:27 +0000 (22:08 +0000)]
The 'e' command of the simple editor has not provided editing of
'interleave' or 'rpm' since the disklabel fields d_interleave and
d_rpm were 'recycled' to make room for duid's in April, 2010.
jsing [Sat, 19 Feb 2022 16:00:57 +0000 (16:00 +0000)]
Add memory BIO small I/O tests.
jsing [Sat, 19 Feb 2022 16:00:14 +0000 (16:00 +0000)]
Remove references to performance issues caused by frequent memmove().
ok inoguchi@ tb@
jsing [Sat, 19 Feb 2022 15:59:12 +0000 (15:59 +0000)]
Reduce memmoves in memory BIOs.
Currently, a read/write memory BIO pulls up the data via memmove() on each
read. This becomes very expensive when a lot of small reads are performed,
especially if there is a reasonable amount of data stored in the memory
BIO.
Instead, store a read offset into the buffer and only perform a memmove()
to pull up the data on a write, if we have read more than 4096 bytes. This
way we only perform memmove() when the space saving will potentially be of
benefit, while avoiding frequent memmove() in the case of small interleaved
reads and writes.
Should address oss-fuzz #19881.
ok inoguchi@ tb@
jsg [Sat, 19 Feb 2022 13:09:36 +0000 (13:09 +0000)]
certificiate -> certificate
jsg [Sat, 19 Feb 2022 12:23:45 +0000 (12:23 +0000)]
mininumu -> minimum
jsg [Sat, 19 Feb 2022 10:17:39 +0000 (10:17 +0000)]
remove outdated contact details for ActivCard and CRYPTOCard
jsg [Sat, 19 Feb 2022 09:12:09 +0000 (09:12 +0000)]
remove redundant swap encryption text
visa [Sat, 19 Feb 2022 08:33:28 +0000 (08:33 +0000)]
Use installboot(8) in install.md of armv7.
OK kettenis@ deraadt@
jsing [Sat, 19 Feb 2022 08:11:16 +0000 (08:11 +0000)]
Provide a struct bio_mem for memory BIO specific data.
In order to fix and improve the memory BIO, we need to be able to track
more than just a single BUF_MEM *. Provide a struct bio_mem (which
currently only contains a BUF_MEM *) and rework the internals to use this
struct.
ok inoguchi@ tb@
afresh1 [Sat, 19 Feb 2022 02:19:42 +0000 (02:19 +0000)]
Ignore sitelib in perl snippet
All base tools should be doing that and I forgot.
While here remove the no longer necessary TERM handler,
it was only needed so a TERM signal would still trigger the END block.
jsg [Fri, 18 Feb 2022 23:17:13 +0000 (23:17 +0000)]
Avoid gendered language in man pages when not referring to a specific
person. Rewrite or use singular they.
ok thfr@ sthen@ daniel@ ian@ job@ kmos@ jcs@ ratchov@ phessler@ and
others I'm likely missing on an earlier version.
feedback tj@, feedback and ok jmc@
deraadt [Fri, 18 Feb 2022 22:54:13 +0000 (22:54 +0000)]
apmd should replace /etc/random.seed for hibernate-resumes (and also
chmod 600 the file to remove the t-bit that the bootblocks set when
the file is used)
comments from naddy
deraadt [Fri, 18 Feb 2022 20:20:23 +0000 (20:20 +0000)]
sync
krw [Fri, 18 Feb 2022 19:26:40 +0000 (19:26 +0000)]
writelabel() only needs one prototype.
krw [Fri, 18 Feb 2022 17:45:43 +0000 (17:45 +0000)]
Move prototypes for checklabel(), readlabel() and parselabel()
into disklabel.c since editor.c and dkcksum.c have no need to
know.
jsing [Fri, 18 Feb 2022 17:30:13 +0000 (17:30 +0000)]
Clean up and simplify memory BIO code.
This is a first pass that uses sensible and consistent names for variables.
Call the BIO 'bio' (instead of 'a', 'b', 'bp', or 'h'), drop a bunch of
unnecessary casts, simplify some logic and add additional error checking.
With input from and ok tb@
millert [Fri, 18 Feb 2022 17:02:06 +0000 (17:02 +0000)]
Enable TLS verify by default for outbound "smtps://" and "smtp+tls://".
This restores the documented behavior that was broken by the fix
for opportunistic TLS. OK semarie@.
millert [Fri, 18 Feb 2022 16:57:36 +0000 (16:57 +0000)]
Revert changes to use the new libtls signer api
There are bugs in the new libtls signer that can lead to a crash.
OK tb@ jsing@