jsg [Wed, 12 Apr 2023 09:55:22 +0000 (09:55 +0000)]
remove duplicate lines
claudio [Wed, 12 Apr 2023 09:09:41 +0000 (09:09 +0000)]
Add test for multiprotocol announce statements
jsg [Wed, 12 Apr 2023 09:07:42 +0000 (09:07 +0000)]
remove duplicate lines
jsg [Wed, 12 Apr 2023 08:53:54 +0000 (08:53 +0000)]
fix double words
ok dtucker@
claudio [Wed, 12 Apr 2023 08:32:27 +0000 (08:32 +0000)]
Fix 24bit maximum/mask in manpage. Noticed by wangqr on github.
jsing [Wed, 12 Apr 2023 05:16:08 +0000 (05:16 +0000)]
Remove now unused sha_local.h.
jsing [Wed, 12 Apr 2023 04:54:15 +0000 (04:54 +0000)]
Provide and use crypto_ro{l,r}_u{32,64}().
Various code in libcrypto needs bitwise rotation - rather than defining
different versions across the code base, provide a common set that can
be reused. Any sensible compiler optimises these to a single instruction
where the architecture supports it, which means we can ditch the inline
assembly.
On the chance that we need to provide a platform specific versions, this
follows the approach used in BN where a MD crypto_arch.h header could be
added in the future, which would then provide more specific versions of
these functions.
ok tb@
jsing [Wed, 12 Apr 2023 04:40:39 +0000 (04:40 +0000)]
Provide and use crypto_store_htobe64().
It is common to need to store data in a specific endianness - rather than
handrolling and deduplicating code to do this, provide a
crypto_store_htobe64() function that converts from host endian to big
endian, before storing the data to a location with unknown alignment.
ok tb@
job [Wed, 12 Apr 2023 03:53:40 +0000 (03:53 +0000)]
Align printing of geofeed records in filemode
jsg [Wed, 12 Apr 2023 02:20:07 +0000 (02:20 +0000)]
remove unused buffer selection code
ok visa@
krw [Tue, 11 Apr 2023 21:14:19 +0000 (21:14 +0000)]
Abstract find_[gpt|mbr]_menuitem() to simplify code and
prepare for future uses.
No functional change.
jsing [Tue, 11 Apr 2023 18:58:20 +0000 (18:58 +0000)]
Handle BN_CTX at the EC API boundary.
The EC API allows callers to optionally pass in a BN_CTX, which means that
any code needing a BN_CTX has to check if one was provided, allocate one if
not, then free it again. Rather than doing this dance throughout the EC
code, handle the BN_CTX existance at the EC API boundary. This means that
lower level implementation code can simply assume that the BN_CTX is
available.
ok tb@
jsing [Tue, 11 Apr 2023 18:53:20 +0000 (18:53 +0000)]
Clean up unused BIGNUM.
krw [Tue, 11 Apr 2023 17:26:59 +0000 (17:26 +0000)]
Simplify code by passing pointers to the appropriate type to
find_gpt_desc() and find_mbr_desc().
No functional change.
schwarze [Tue, 11 Apr 2023 16:58:43 +0000 (16:58 +0000)]
Document the RETURN VALUES of BIO_method_type(3) and BIO_method_name(3)
for the various BIO types.
krw [Tue, 11 Apr 2023 16:34:51 +0000 (16:34 +0000)]
Shuffle mbr and gpt function prototypes and declarations together.
No functional change.
tb [Tue, 11 Apr 2023 15:38:55 +0000 (15:38 +0000)]
Recommit jsing's r1.27 - portable is ready
Use htobe64() instead of testing BYTE_ORDER and then handrolling htobe64().
Thanks to tobhe for providing most of the fix via openiked-portable
schwarze [Tue, 11 Apr 2023 15:35:31 +0000 (15:35 +0000)]
While all the BIO_TYPE_* constants are part of the API, most of their
values are only part of the ABI and not of the API, so delete them
from the SYNOPSIS: application programmers must not rely on the
specific values.
Instead of listing the specific values, properly describe the meaning
of all these constants.
However, the values of BIO_TYPE_NONE and BIO_TYPE_START are hard-coded
into the API and application programmers need to be aware of their
values, so those remain in the SYNOPSIS.
espie [Tue, 11 Apr 2023 15:02:56 +0000 (15:02 +0000)]
be more forceful in pointing people to bulk(8) and proot(1).
tb [Tue, 11 Apr 2023 13:03:03 +0000 (13:03 +0000)]
Back out r1.27 using htobe64() - apparently some OS don't have it.
ok jsing
espie [Tue, 11 Apr 2023 11:23:09 +0000 (11:23 +0000)]
give people a chance to find bulk(8) from proot(1)
jsing [Tue, 11 Apr 2023 10:41:10 +0000 (10:41 +0000)]
Consolidate sha1 into a single file.
jsing [Tue, 11 Apr 2023 10:39:50 +0000 (10:39 +0000)]
Consolidate sha1 into a single file.
jsing [Tue, 11 Apr 2023 10:35:21 +0000 (10:35 +0000)]
Simplify handling of big vs little endian.
Rather than sprinkling BYTE_ORDER checks throughout the implementation,
always define PULL64 - on big endian platforms it just becomes a no-op.
ok tb@
jsing [Tue, 11 Apr 2023 10:32:21 +0000 (10:32 +0000)]
Use htobe64() instead of testing BYTE_ORDER and then handrolling htobe64().
ok tb@
jsing [Tue, 11 Apr 2023 10:26:29 +0000 (10:26 +0000)]
Omit sha512_block_data_order() prototype when assembly is not being used.
In the case that the pure C implementation of SHA512 is being used, the
prototype is unnecessary as the function is declared static and exists
in dependency order. Simply omit the prototype rather than using #ifndef
to toggle the static prefix.
ok tb@
jsing [Tue, 11 Apr 2023 10:21:02 +0000 (10:21 +0000)]
Remove less than useful implementation notes.
ok tb@
tb [Tue, 11 Apr 2023 10:10:52 +0000 (10:10 +0000)]
bn_mod_sqrt: remove no longer necessary complications due to the
non-deterministic nature of the old implementation.
tb [Tue, 11 Apr 2023 10:08:44 +0000 (10:08 +0000)]
Add a new implementation of BN_mod_sqrt()
This is a reimplementation from scratch of the Tonelli-Shanks algorithm
based on Henri Cohen "A Course in Computational Algebraic Number Theory",
Springer GTM 138, section 1.5.1. It is API compatible with the previous
implementation, so no documentation change is required.
Contrary to the old implementation, this does not have any infinite loops
and has various additional sanity checks to prevent misbehavior in case
the input modulus is not a prime. It contains extensive comments and the
individual parts of the algorithm are split into digestible chunks instead
of having one huge function.
One difference of note is that it BN_mod_sqrt() now always returns the
smaller of the two possible answers. In other words, while its core is
non-deterministic, its answer is not.
ok jsing
jsing [Tue, 11 Apr 2023 05:53:53 +0000 (05:53 +0000)]
Correct benchmark result computation on 32 bit platforms.
mglocker [Tue, 11 Apr 2023 04:45:11 +0000 (04:45 +0000)]
Nuke unused function prototype.
Only acknowledge interrupts when one was active.
ok kettenis@
jsg [Tue, 11 Apr 2023 00:45:06 +0000 (00:45 +0000)]
fix double words in comments
feedback and ok jmc@ miod, ok millert@
jsg [Mon, 10 Apr 2023 23:18:08 +0000 (23:18 +0000)]
add missing write of SAB_DAFO
ok miod@ who tested on Ultra 5
tb [Mon, 10 Apr 2023 21:00:16 +0000 (21:00 +0000)]
Some more cleanup in bn_to_string
tb [Mon, 10 Apr 2023 20:59:33 +0000 (20:59 +0000)]
Drop BN_NO_DEPRECATED dance from bn_test
krw [Mon, 10 Apr 2023 19:44:43 +0000 (19:44 +0000)]
Make GPT display of menu hex octet the same as the MBR display.
i.e. two digits.
jsing [Mon, 10 Apr 2023 19:02:30 +0000 (19:02 +0000)]
Provide benchmarks for BN_copy()
tb [Mon, 10 Apr 2023 16:46:00 +0000 (16:46 +0000)]
Fix indentation of structs and unions in x509v3.h
No change according to diff -w
tobhe [Mon, 10 Apr 2023 15:14:04 +0000 (15:14 +0000)]
Enable caps lock LED on modern Apple laptop keyboards.
ok kettenis@ patrick@
tb [Mon, 10 Apr 2023 14:10:26 +0000 (14:10 +0000)]
Make bn_to_string() static
This function is no longer used directly by regress, so it can now be local
to this file.
tb [Mon, 10 Apr 2023 13:57:57 +0000 (13:57 +0000)]
bn_to_string no longer needs to be linked statically
tb [Mon, 10 Apr 2023 13:57:32 +0000 (13:57 +0000)]
Rework the bn_to_string() to use public API
We can use the undocumented functions {i2s,s2i}_ASN1_INTEGER(3) to
exercise bn_to_string(). This way we use public API and remove the
need of linking statically.
schwarze [Mon, 10 Apr 2023 13:40:16 +0000 (13:40 +0000)]
Various wording tweaks for clarity and precision, and a few for conciseness.
OK jmc@ and Ted Bullock
schwarze [Mon, 10 Apr 2023 13:32:29 +0000 (13:32 +0000)]
More deduplication: talk about environment variable in one place, not two.
Clarify that the variables only affect the event_base structure currently
being created. They do not disable "library support" as a whole.
Sort the variables alphabetically.
OK jmc@ and Ted Bullock
jsg [Mon, 10 Apr 2023 12:57:15 +0000 (12:57 +0000)]
fix 'in in'
jsg [Mon, 10 Apr 2023 12:11:22 +0000 (12:11 +0000)]
fix setting parity bits
ok mglocker@
jsg [Mon, 10 Apr 2023 04:21:19 +0000 (04:21 +0000)]
spelling
gnezdo [Sun, 9 Apr 2023 23:41:47 +0000 (23:41 +0000)]
Treat symlinks better in $ORIGIN determination in ld.so
Now symlinking an executable away from the rest of its installation
tree no longer prevents it from finding the libraries. This matches
the behavior of other OS linkers. Prompted by a behavior change in
lang/ghc test suite.
Swapped the order of dirname/realpath in _dl_origin_path.
Added some regress tests that pass and then bin3 that fails without
this change and reflects the behavior needd for lang/ghc.
Suggestion by semarie@, OK deraadt@
kettenis [Sun, 9 Apr 2023 19:48:37 +0000 (19:48 +0000)]
So clang 13 miscompiles dev/usb/umass_scsi.c with the combination if -Oz
and -mbranch-protection=bti. So turn off the BTI protection in ramdisk
kernels for now.
ok deraadt@, miod@, phessler@
tb [Sun, 9 Apr 2023 19:10:23 +0000 (19:10 +0000)]
Move a few functions out of OPENSSL_NO_DEPRECATED
Geoff Thorpe added OPENSSL_NO_DEPRECATED nearly two decades ago. The hope
was that at some point some functions can be dropped. Most of the functions
marked deprecated are actually unused nowadays but unfortunately some of
them are still used in the ecosystem. Move them out of OPENSSL_NO_DEPRECATED
so we can define it without breaking the consumers in the next bump.
ERR_remove_state() is still used by a dozen or so ports. This isn't a big
deal since it is just a stupid wrapper for the not quite as deprecated
ERR_remove_thread_state(). It's not worth patching these ports.
Annoyingly, {DH,DSA}_generate_parameters() and RSA_generate_key() are still
used. They "make use" of the old-style BN_GENCB callback, which is therefore
more difficult to remove - in case you don't know know: that's the thing
responsible for printing pretty '.', '+' and '*' when you generate keys.
Most annoyingly, DH_generate_parameters() was added to rust-openssl in 2020
for "advanced DH support". This is very unfortunate since cargo bundles a
rust-openssl and updates it only every few years or so. As a consequence
we're going to be stuck with this nonsense for a good while.
ok beck jsing
tb [Sun, 9 Apr 2023 18:38:59 +0000 (18:38 +0000)]
Remove some doubled empty lines
tb [Sun, 9 Apr 2023 18:33:26 +0000 (18:33 +0000)]
Remove X9.31 support from openssl(1)
The X9.31 standard has long been retired and deprecated and libcrypto will
drop support for it soon. This prepares userland.
ok jsing
tb [Sun, 9 Apr 2023 18:26:26 +0000 (18:26 +0000)]
Drop X9.31 support from libtls
The TLS signer isn't exposed in public API (we should finally fix it...)
and it supports X9.31, a standard that has been retired and deprecated for
a very long time. libcrypto will stop supporting it soon, this step is
needed to prepare userland.
ok jsing
jcs [Sun, 9 Apr 2023 17:50:02 +0000 (17:50 +0000)]
don't attach temperature sensors for which there is no TMP# node in
the DSDT, and verify the result of the fetch when updating it later.
ok kn
tb [Sun, 9 Apr 2023 17:28:52 +0000 (17:28 +0000)]
Minor code cleanup
Unwrap a few awkwardly wrapped lines, drop redundant parentheses and
add empty lines after some variable declarations. No change in the
generated assembly.
krw [Sun, 9 Apr 2023 17:19:59 +0000 (17:19 +0000)]
Refactor and simplify GPT menu selection logic.
No intentional functional change.
jsing [Sun, 9 Apr 2023 15:47:41 +0000 (15:47 +0000)]
Provide and use sha{224,384}_{update,final} functions.
Improve readability and consistency by providing and using functions named
for the specific hash, rather than reusing the sha256/sha512 update and
final functions.
No functional change.
ok tb@
jsing [Sun, 9 Apr 2023 15:40:09 +0000 (15:40 +0000)]
Rename SHA functions to have sha{1,224,256,384,512}_ prefix.
Also remove some unnecessary parentheses.
No functional change.
ok tb@
schwarze [Sun, 9 Apr 2023 14:43:51 +0000 (14:43 +0000)]
Trim some redundant and a bit of misleading text:
1. The values of #define'd constants are part of the ABI, but not of the API.
Programmers need not worry about them and must not rely on them.
Consequently, do not list these values in the SYNOPSIS.
2. libevent can be used for any event loop, not only for the main loop
of a program.
3. No need to state numbers of arguments, they are obvious from the SYNOPSIS.
4. If a function is documented to require a pointer to a specific kind of
object as an argument, there is no need to say passing NULL is undefined.
OK jmc@ and Ted Bullock
schwarze [Sun, 9 Apr 2023 14:30:24 +0000 (14:30 +0000)]
Explain what it means that an API function "requires event_init(3)"
in one place, not in two places, reducing duplication of text.
Joint work with Ted Bullock. OK jmc@.
jsg [Sun, 9 Apr 2023 06:27:52 +0000 (06:27 +0000)]
fix double words
kn [Sat, 8 Apr 2023 18:12:08 +0000 (18:12 +0000)]
Return -1 on actual failure
MI boot.c's "a-x" fchmod on bsd.upgrade is the only caller that checks the
return value and that call can fail on, e.g. softraid volumes.
Stop clobbering the actual fchmod return value and get that warning printed.
OK deraadt
tb [Sat, 8 Apr 2023 17:43:30 +0000 (17:43 +0000)]
bn_test: two minor style tweaks
schwarze [Sat, 8 Apr 2023 16:21:22 +0000 (16:21 +0000)]
New manual page written by Ted Bullock <tbullock at comlore dot com>,
providing more information and in a more systematic way
than the current event(3) manual page.
Not yet linked to the tree.
Using input from nicm@ and jmc@.
krw [Sat, 8 Apr 2023 15:25:47 +0000 (15:25 +0000)]
A bit more guid vs uuid naming consistency.
No functional change.
mvs [Sat, 8 Apr 2023 13:50:22 +0000 (13:50 +0000)]
Do not reload `inp' in gre_send(). The pointer to PCB of raw socket is
immutable, we don't need to reload it again.
ok bluhm@
mvs [Sat, 8 Apr 2023 13:49:38 +0000 (13:49 +0000)]
Move rtm_ifannounce(IFAN_DEPARTURE) outside netlock within if_detach().
This is the mbuf(9) allocation and broadcast transmission for PF_ROUTE
sockets, netlock is not required here.
ok bluhm@
jsg [Sat, 8 Apr 2023 05:40:54 +0000 (05:40 +0000)]
add missing write to XENON_EMMC_PHY_PAD_CONTROL2
ok patrick@
jsg [Sat, 8 Apr 2023 05:38:25 +0000 (05:38 +0000)]
correct write to MV_XLG_PORT_MAC_CTRL4_REG
tested by matthieu@ ok patrick@
dlg [Sat, 8 Apr 2023 02:32:38 +0000 (02:32 +0000)]
try and cope with not having the firmware/boot loader init the hardware.
more specifically, spin up the clocks and phy, and if the device
tree has a "ports-implemented" property use it to initialise the
AHCI_REG_PI register.
this gets sata working on a banana pi bpi-r2 pro.
help from jared mcneill
ok jmatthew@ kettenis@
tb [Fri, 7 Apr 2023 23:03:32 +0000 (23:03 +0000)]
bn_mont: fix typo in comment divisable -> divisible
dlg [Fri, 7 Apr 2023 22:55:26 +0000 (22:55 +0000)]
print which gmac the dwqe driver is attaching to.
there's no guarantee that dwqe0 in the kernel will attach to gmac0
in the device tree, so print it to make it explicit what's going
where.
ok patrick@ kettenis@
tb [Fri, 7 Apr 2023 22:36:38 +0000 (22:36 +0000)]
bn_test: rename rc into ret as per usual
tb [Fri, 7 Apr 2023 22:32:59 +0000 (22:32 +0000)]
bn_test: pass BN_CTX into all functions
There is a BN_CTX at program scope. Pass it into all test functions.
This simplifies memory management at the end of the functions quite a bit.
tb [Fri, 7 Apr 2023 22:30:31 +0000 (22:30 +0000)]
bn_test: drop a few braces that are now unnecessary
tb [Fri, 7 Apr 2023 22:29:33 +0000 (22:29 +0000)]
bn_test: move rc initialization to its own line
tb [Fri, 7 Apr 2023 22:28:21 +0000 (22:28 +0000)]
bn_test: keep the error stack clean
Make message() print and clear the error stack. This way we can know
what test errored. To make this work also clear the error stack after
a handful of xfail tests.
tb [Fri, 7 Apr 2023 22:25:09 +0000 (22:25 +0000)]
bn_test: use bn_copy() instead of BN_free/BN_dup
This is not only simpler but also required by an upcoming change.
tb [Fri, 7 Apr 2023 22:23:31 +0000 (22:23 +0000)]
bn_test: a few early return would leak. goto err instead
tb [Fri, 7 Apr 2023 22:22:10 +0000 (22:22 +0000)]
bn_test: rand_neg() is not only one of the most stupidly named functions
in the entire code base it also has a few parentheses too many
tb [Fri, 7 Apr 2023 22:18:42 +0000 (22:18 +0000)]
bn_test: handle rc consistently
Various test functions had bugs due to the fact that the return code
would be set to 1 at the top so that each error would have to set rc = 0.
This is silly. Fail closed instead by setting rc = 0 at the top and only
flipping to 1 before the err label
tb [Fri, 7 Apr 2023 22:14:20 +0000 (22:14 +0000)]
bn_test: inline the only use of lst[]
lst[] can be converted from a bit string to a hex string. Use BN_hex2bn()
isntead of BN_bin2bn(). Handle this inside test_lshift() rather than doing
artistic ownership dances.
bluhm [Fri, 7 Apr 2023 22:02:58 +0000 (22:02 +0000)]
Remove kernel locks from the ARP input path. Caller if_netisr()
grabs the exclusive netlock and that is sufficent for in_arpinput()
and arpcache().
with kn@; OK mvs@; tested by Hrvoje Popovski
tb [Fri, 7 Apr 2023 17:09:54 +0000 (17:09 +0000)]
Improve some test failure reporting
krw [Fri, 7 Apr 2023 16:34:41 +0000 (16:34 +0000)]
Oops. Missed files in last commit.
schwarze [Fri, 7 Apr 2023 15:43:18 +0000 (15:43 +0000)]
Ignore ten getter and setter control macros related to proxy BIOs.
Those are not useful because such a BIO type neither exists
in LibreSSL nor in OpenSSL 1.1.1.
Not adding the deprecation notice to some manual page
because there is no manual page that is even vaguely related.
schwarze [Fri, 7 Apr 2023 15:39:18 +0000 (15:39 +0000)]
Two minor tweaks that are useful for processing bio.h, among other headers:
* ignore lines defining "__bounded__()"
* ignore whitespace between "#" and "include"
schwarze [Fri, 7 Apr 2023 14:47:37 +0000 (14:47 +0000)]
Mark BIO_CB_return(), BIO_cb_pre(), and BIO_cb_post() as intentionally
undocumented because they are unused according to codesearch.debian.net
and would cause nothing but obfuscation if they were used.
krw [Fri, 7 Apr 2023 14:42:51 +0000 (14:42 +0000)]
Add helper functions find_mbr_desc() and find_gpt_desc() to allow
checking mbr_type[N].mt_desc and gpt_type[N].gt_desc before using
name on menu when printing out partition tables.
Tweak logic in find_mbr_type() and find_gpt_type() to be a bit
more paranoid.
Tweak function/variable names to be more in line to usage.
No functional change as all mt_desc and gt_desc are currently
NULL.
claudio [Fri, 7 Apr 2023 13:49:03 +0000 (13:49 +0000)]
Pass a pt_entry pointer to rib_get() and rib_add().
Add rib_get_addr() to behave like rib_get() did before.
OK tb@
kn [Fri, 7 Apr 2023 13:48:42 +0000 (13:48 +0000)]
Default 'Is the disk partition alrady mounted?' to 'no' on install
For installation, no partitions whatsoever are mounted, so 'yes' is always
wrong unless the user manually mounted stuff before that question.
No change for upgrade, where partitions on the root disk are mounted.
Idea from naddy, diff from Mikhail (mp39590 AT gmail)
Tweaks from me
OK op afresh1
tb [Fri, 7 Apr 2023 09:43:38 +0000 (09:43 +0000)]
Fix whitespace on two lines
kn [Fri, 7 Apr 2023 09:40:18 +0000 (09:40 +0000)]
Nail the root disk default in the guided disk encryption case
Save the softraid volume's device and make it root disk default, being the
only legit choice in this case; this gets it always right on systems with
multiple physical disks.
All other install/upgrade cases keep picking the first available [sw]d* disk
as root disk default.
OK afresh1
dlg [Fri, 7 Apr 2023 09:33:51 +0000 (09:33 +0000)]
register a mapping of dwqe interfaces to ofw nodes/phandles.
i forgot to commit this as part of src/sys/dev/fdt/if_dwqe_fdt.c r1.7
found by mglocker@
jsg [Fri, 7 Apr 2023 09:31:59 +0000 (09:31 +0000)]
avoid use of uninitialised memory
ok miod@ kettenis@
kettenis [Fri, 7 Apr 2023 08:53:03 +0000 (08:53 +0000)]
Determine PHY mode and pass the appropriate flags down to the PHY when we
attach it.
ok dlg@
dlg [Fri, 7 Apr 2023 06:33:49 +0000 (06:33 +0000)]
register a mapping of dwqe interfaces to ofw nodes/phandles.
ok kettenis@
dlg [Fri, 7 Apr 2023 06:18:26 +0000 (06:18 +0000)]
fixed regulators could have a "gpios" or "gpio" property.
we only handled "gpio" before. figuring this out has wasted many
days of my life recently.
ok patrick@ kettenis@
jsg [Fri, 7 Apr 2023 04:11:42 +0000 (04:11 +0000)]
drm/amdkfd: Get prange->offset after svm_range_vram_node_new
From Xiaogang Chen
d0386bd84e6d81990ef22e10657d5a5d9c209763 in linux-6.1.y/6.1.23
8eeddc0d4200762063e1c66b9cc63afa7b24ebf0 in mainline linux
jsg [Fri, 7 Apr 2023 04:09:51 +0000 (04:09 +0000)]
drm/i915: Move CSC load back into .color_commit_arm() when PSR is enabled on skl/glk
From Ville Syrjala
fcf712b4e5d0aacbc193e71962bdaa4d4afe3335 in linux-6.1.y/6.1.23
a8e03e00b62073b494886dbff32f8b5338066c8b in mainline linux