cheloha [Sun, 17 Sep 2023 15:05:44 +0000 (15:05 +0000)]
struct clockintr_queue: rename "cq_est" to "cq_all"
"cq_all" is a more obvious name than "cq_est". It's the list of all
established clockintrs. Duh.
cheloha [Sun, 17 Sep 2023 14:50:50 +0000 (14:50 +0000)]
clockintr: remove clockintr_init(), clockintr_flags
All the state initialization once done in clockintr_init() has been
moved to other parts of the kernel. It's a dead function. Remove it.
Likewise, the clockintr_flags variable no longer sports any meaningful
flags. Remove it. This frees up the CL_* flag namespace, which might
be useful to the clockintr frontend if we ever need to add behavior
flags to any of those functions.
millert [Sun, 17 Sep 2023 14:49:44 +0000 (14:49 +0000)]
Update to the One True Awk, 2nd edition (Sep 12, 2023).
This corresponds to the 2nd edition of "The AWK Programming Language"
and adds support for UTF-8 and comma-separated value inputs.
cheloha [Sun, 17 Sep 2023 13:02:24 +0000 (13:02 +0000)]
scheduler_start: move static timeout structs into callback functions
Move the schedcpu() and update_loadavg() timeout structs from
scheduler_start() into their respective callback functions and
statically initialize them with TIMEOUT_INITIALIZER(9).
The structs are already hidden from the global namespace and the
timeouts are already self-managing, so we may as well fully
consolidate things.
Thread: https://marc.info/?l=openbsd-tech&m=
169488184019047&w=2
"Sure." claudio@
jmatthew [Sat, 16 Sep 2023 23:25:16 +0000 (23:25 +0000)]
Skip non-MSI interrupt controllers when looking for one matching the ITS id
given in the IORT node. Using a non-MSI interrupt controller here will
crash as ic->ic_establish_msi will be NULL.
tested by phessler@
ok phessler@ patrick@
deraadt [Sat, 16 Sep 2023 19:59:32 +0000 (19:59 +0000)]
sync
robert [Sat, 16 Sep 2023 18:06:26 +0000 (18:06 +0000)]
add 7.5 syspatch key
nicm [Sat, 16 Sep 2023 16:18:29 +0000 (16:18 +0000)]
Remove next- and previous-prompt added in error. GitHub issue 3696.
naddy [Sat, 16 Sep 2023 13:28:39 +0000 (13:28 +0000)]
7.5 packages key
sthen [Sat, 16 Sep 2023 11:45:03 +0000 (11:45 +0000)]
add 7.5 firmware key
mpi [Sat, 16 Sep 2023 09:33:27 +0000 (09:33 +0000)]
Allow counters_read(9) to take an optional scratch buffer.
Using a scratch buffer makes it possible to take a consistent snapshot of
per-CPU counters without having to allocate memory.
Makes ddb(4) show uvmexp command work in OOM situations.
ok kn@, mvs@, cheloha@
espie [Sat, 16 Sep 2023 09:33:13 +0000 (09:33 +0000)]
forgot to kill that
op [Sat, 16 Sep 2023 08:01:31 +0000 (08:01 +0000)]
remove empty line in PORTHOME description
op [Sat, 16 Sep 2023 07:59:44 +0000 (07:59 +0000)]
document CHECK_LIB_DEPENDS_ARGS
nicm [Fri, 15 Sep 2023 15:49:05 +0000 (15:49 +0000)]
Change UTF-8 combining to inspect the previous character at the cursor
position rather than keeping the last character from the input stream,
this is how most terminals work and fixes problems with displaying these
characters in vim. GitHub issue 3600.
jsg [Fri, 15 Sep 2023 15:07:08 +0000 (15:07 +0000)]
update awk book reference for the second edition
it will be published in 2023 with a copyright date of 2024
ok jmc@ millert@
deraadt [Fri, 15 Sep 2023 11:48:48 +0000 (11:48 +0000)]
work around cpu.h not coming into early scope on all arch
claudio [Fri, 15 Sep 2023 10:59:02 +0000 (10:59 +0000)]
Also update usage() to include [-p file].
claudio [Fri, 15 Sep 2023 10:56:46 +0000 (10:56 +0000)]
Even if support for utsack is very limited, document the option needed.
OK mpi@
tb [Fri, 15 Sep 2023 07:13:35 +0000 (07:13 +0000)]
Default REGRESS_FAIL_EARLY to yes
The current fail open behavior may be desirable in some circumstances,
but it is an unexpected and dangerous default since one expects some
kind of feedback when running a test suite. Currently failing tests are
only visible on inspecting the log, which led to unsuspecting people
missing failures several times in the past. Flip the default to fail
closed. For those that want to have the old behavior, it is easy enough
to set the variable to no.
Positive feedback job and schwarze
ok kn
nicm [Fri, 15 Sep 2023 06:31:49 +0000 (06:31 +0000)]
Add -t to source-file, GitHub issue 3473.
nicm [Fri, 15 Sep 2023 06:28:15 +0000 (06:28 +0000)]
Add some more WINOPS and a placeholder for SMGRAPHICS.
florian [Fri, 15 Sep 2023 05:32:00 +0000 (05:32 +0000)]
Improve handling of ENOBUFS by not running in a tight loop forever.
This cherry-picks upstream git commit
0ee44ef384593ed0382d1ce6048d5a9c9440b45c.
Issue reported by landry@, which could be traced back to a buggy WiFi
driver that would constantly return ENOBUFS. This in turn lead
unwind(8) enter a tight loop through poll / sendto without making any
progress and burning 100% cpu.
OK sthen
I missed to commit this file when commiting to unbound.
Pointed out by tb, thanks!
deraadt [Thu, 14 Sep 2023 23:42:56 +0000 (23:42 +0000)]
satisfy non-c99 compilers
deraadt [Thu, 14 Sep 2023 22:42:48 +0000 (22:42 +0000)]
satisfy non-c99 compilers
cheloha [Thu, 14 Sep 2023 22:27:09 +0000 (22:27 +0000)]
clockintr: move hz(9)-based initialization out to initclocks()
To separate the hardclock from the clock interrupt subsystem we'll
need to move all related state out first.
hz(9) is set when we return from cpu_initclocks(), so it's safe to
move hardclock_period and roundrobin_period initialization out into
initclocks(). Move hardclock_period itself out into kern_clock.c
alongside the statclock variables.
cheloha [Thu, 14 Sep 2023 22:07:11 +0000 (22:07 +0000)]
clockintr, scheduler: move statclock handle from clockintr_queue to schedstate_percpu
Move the statclock handle from clockintr_queue.cq_statclock to
schedstate_percpu.spc_statclock. Establish spc_statclock during
sched_init_cpu() alongside the other scheduler clock interrupts.
Thread: https://marc.info/?l=openbsd-tech&m=
169428749720476&w=2
cheloha [Thu, 14 Sep 2023 20:58:51 +0000 (20:58 +0000)]
clockintr, statclock: eliminate clockintr_statclock() wrapper
- Move remaining statclock variables from kern_clockintr.c to
kern_clock.c. Move statclock variable initialization from
clockintr_init() into initclocks().
- Change statclock() prototype to make it a legal clockintr
callback function and establish the handle with statclock()
instead clockintr_statclock().
- Merge the contents of clockintr_statclock() into statclock().
statclock() can now reschedule itself and handles multiple
expirations transparently.
- Make statclock_avg visible from sys/systm.h so that clockintr_cpu_init()
can use it to advance the statclock across suspend/hibernate.
Thread: https://marc.info/?l=openbsd-tech&m=
169428749720476&w=2
jmc [Thu, 14 Sep 2023 19:59:12 +0000 (19:59 +0000)]
use Fn notation instead of Nm, as the rest of the page does;
from josiah frentsos
cheloha [Thu, 14 Sep 2023 19:51:17 +0000 (19:51 +0000)]
clockintr: move clockintr_advance_random() prototype into sys/clockintr.h
statclock() is going to need this. Move the prototype into the public API.
Thread: https://marc.info/?l=openbsd-tech&m=
169428749720476&w=2
cheloha [Thu, 14 Sep 2023 19:39:47 +0000 (19:39 +0000)]
clockintr: replace CL_RNDSTAT with global variable statclock_is_randomized
In order to separate the statclock from the clock interrupt subsystem
we need to move all statclock state out into the broader kernel.
Start by replacing the CL_RNDSTAT flag with a new global variable,
"statclock_is_randomized", in kern_clock.c. Update all clockintr_init()
callers to set the boolean instead of passing the flag.
Thread: https://marc.info/?l=openbsd-tech&m=
169428749720476&w=2
cheloha [Thu, 14 Sep 2023 18:32:03 +0000 (18:32 +0000)]
sh(1), ksh(1): reimplement p_tv() with p_ts()
p_tv() is identical to p_ts(). Better to not have two copies: in
p_tv(), convert the timeval to a timespec and pass it to p_ts().
With input from tb@ and millert@.
Thread: https://marc.info/?l=openbsd-tech&m=
169448818503541&w=2
ok tb@ millert@
jca [Thu, 14 Sep 2023 16:39:00 +0000 (16:39 +0000)]
Instead of ld -dc use ld -d, supported by both ld.bfd and ld.lld >= 15
Upstream LLVM decided to drop the -dc flag and keep its -d alias for
some time:
https://github.com/llvm/llvm-project/commit/
0688b00fc39fe87ec6dd3d37a732d067ff487f16
So this is only a workaround to let us update llvm to a recent release.
We'll probably need another fix not so distant future. Another approach
would be to just drop -dc from the linker invocation, and use
cc -fno-common when building instbin with base-gcc (already the default
with base-clang). But this approach needs more testing than I can
provide, as deraadt@ feared it would break in subtle ways.
ld -d compat alias pointed out by robert@, ok robert@
dv [Thu, 14 Sep 2023 15:25:43 +0000 (15:25 +0000)]
vmd(8)/vioblk: use zero-copy approach & vectored io.
The original version of the virtio block device dynamically allocated
buffers to hold intermediate data when reading or writing to the
underlying disk fd(s). Since vioblk drivers may chain multiple
segments together, this leads to overly complex logic and on
read(2)/write(2) call per data segment.
Additionally, the virtio block logic in vmd didn't handle segments
that weren't block aligned (e.g. 512 bytes). If a guest provided
unaligned segments, garbage will be read or written.
Since virtio descriptors mimic iovec structures, this changes vmd's
device emulation to use that model. (This is how other hypervisors
emulate virtio devices.) This allows for zero-copy semantics using
iovec's, reducing memcpy and multiple read/write syscalls per io
transaction.
Testing by phessler@ and mlarkin@. OK mlarkin@.
sthen [Thu, 14 Sep 2023 14:06:13 +0000 (14:06 +0000)]
document print-plist-libs
nicm [Thu, 14 Sep 2023 13:01:35 +0000 (13:01 +0000)]
Reset combine flag only if text is actually processed.
yasuoka [Thu, 14 Sep 2023 09:55:28 +0000 (09:55 +0000)]
Clarify the interval after 30sec.
yasuoka [Thu, 14 Sep 2023 09:54:31 +0000 (09:54 +0000)]
Revert the previous. It was committed by my mistake.
yasuoka [Thu, 14 Sep 2023 09:51:14 +0000 (09:51 +0000)]
Clarify the interval after 30sec.
bentley [Thu, 14 Sep 2023 03:53:26 +0000 (03:53 +0000)]
Update to reflect FONT_DISTSUBDIR removal.
jsg [Thu, 14 Sep 2023 00:29:35 +0000 (00:29 +0000)]
revert previous, it doesn't help
reporter had radeondrm disabled when testing
schwarze [Wed, 13 Sep 2023 14:57:21 +0000 (14:57 +0000)]
replace the outdated statement that everything uses SHA-1
by a table showing the supported algorithms
schwarze [Wed, 13 Sep 2023 14:39:54 +0000 (14:39 +0000)]
Document the special meaning of NID_undef in this context.
From Matt Caswell <matt at openssl dot org>
via OpenSSL commit
1212818e (Sep 11, 2018)
from the OpenSSL 1.1 branch, which is still under a free license.
Wording slightly tweaked by me.
claudio [Wed, 13 Sep 2023 14:25:49 +0000 (14:25 +0000)]
Revert commitid: yfAefyNWibUyjkU2, ESyyH5EKxtrXGkS6 and itscfpFvJLOj8mHB;
The change to the single thread API results in crashes inside exit1()
as found by Syzkaller. There seems to be a race in the exit codepath.
What exactly fails is not really clear therefor revert for now.
This should fix the following Syzkaller reports:
Reported-by: syzbot+38efb425eada701ca8bb@syzkaller.appspotmail.com
Reported-by: syzbot+ecc0e8628b3db39b5b17@syzkaller.appspotmail.com
and maybe more.
Reverted commits:
----------------------------
Protect ps_single, ps_singlecnt and ps_threadcnt by the process mutex.
The single thread API needs to lock the process to enter single thread
mode and does not need to stop the scheduler.
This code changes ps_singlecount from a count down to zero to ps_singlecnt
which counts up until equal to ps_threadcnt (in which case all threads
are properly asleep).
Tested by phessler@, OK mpi@ cheloha@
----------------------------
Change how ps_threads and p_thr_link are locked away from using SCHED_LOCK.
The per process thread list can be traversed (read) by holding either
the KERNEL_LOCK or the per process ps_mtx (instead of SCHED_LOCK).
Abusing the SCHED_LOCK for this makes it impossible to split up the
scheduler lock into something more fine grained.
Tested by phessler@, ok mpi@
----------------------------
Fix SCHED_LOCK() leak in single_thread_set()
In the (q->p_flag & P_WEXIT) branch is a continue that did not release
the SCHED_LOCK. Refactor the code a bit to simplify the places SCHED_LOCK
is grabbed and released.
Reported-by: syzbot+ea26d351acfad3bb3f15@syzkaller.appspotmail.com
OK kettenis@
mvs [Wed, 13 Sep 2023 14:24:37 +0000 (14:24 +0000)]
Replace sys/selinfo.h header with sys/event.h. drm_device.h has no
selinfo stuff, but the `note' member of 'drm_device' structure with type
of klist.
ok jsg
schwarze [Wed, 13 Sep 2023 14:18:21 +0000 (14:18 +0000)]
Various improvements:
* Document the ASN1_PKEY_CTRL_DEFAULT_MD_NID control operation.
* Mention that EVP_PKEY_asn1_new(3) sets ASN1_PKEY_DYNAMIC.
* Fix the description of EVP_PKEY_asn1_copy(3), which was totally wrong.
* Warn about the crazy ASN1_PKEY_DYNAMIC handling in EVP_PKEY_asn1_free(3).
* Be more precise about EVP_PKEY_asn1_new(3) RETURN VALUES.
schwarze [Wed, 13 Sep 2023 13:55:50 +0000 (13:55 +0000)]
document the EVP_PKEY_ASN1_METHOD flags
ASN1_PKEY_ALIAS, ASN1_PKEY_DYNAMIC, and ASN1_PKEY_SIGPARAM_NULL
mpi [Wed, 13 Sep 2023 13:47:58 +0000 (13:47 +0000)]
Properly evaluate variables when inserting them into a map.
Somehow missed in previous, regression reported by anton@.
schwarze [Wed, 13 Sep 2023 13:46:52 +0000 (13:46 +0000)]
minor markup fixes: add one missing .Dv and one missing .Vt macro
schwarze [Wed, 13 Sep 2023 13:32:01 +0000 (13:32 +0000)]
document the EVP_PKEY_CTRL_MD and EVP_PKEY_CTRL_GET_MD command constants
jsg [Wed, 13 Sep 2023 13:07:29 +0000 (13:07 +0000)]
drm/amd/display: Add smu write msg id fail retry process
From Fudong Wang
b23c96589ff7f25ad2232524f6c74e0067be2369 in linux-6.1.y/6.1.53
72105dcfa3d12b5af49311f857e3490baa225135 in mainline linux
jsg [Wed, 13 Sep 2023 13:04:19 +0000 (13:04 +0000)]
drm/amd/display: register edp_backlight_control() for DCN301
From Hamza Mahfooz
9a9b8596c3dce99a0bac3951ed257e87f30d0445 in linux-6.1.y/6.1.53
1611917f39bee1abfc01501238db8ac19649042d in mainline linux
jsg [Wed, 13 Sep 2023 13:01:54 +0000 (13:01 +0000)]
drm/radeon: Use RMW accessors for changing LNKCTL
From Ilpo Jarvinen
433330fb1296119d74cc5c8f1e05b5829ddc52f9 in linux-6.1.y/6.1.53
7189576e8a829130192b33c5b64e8a475369c776 in mainline linux
jsg [Wed, 13 Sep 2023 12:59:27 +0000 (12:59 +0000)]
drm/amdgpu: Use RMW accessors for changing LNKCTL
From Ilpo Jarvinen
a0f0daf60bc1d3d78afded5931a56a015f2a17e8 in linux-6.1.y/6.1.53
ce7d88110b9ed5f33fe79ea6d4ed049fb0e57bce in mainline linux
jsg [Wed, 13 Sep 2023 12:55:18 +0000 (12:55 +0000)]
drm/amd/pm: fix variable dereferenced issue in amdgpu_device_attr_create()
From Yang Wang
f27dff881f0b8f1a5bc64d48a19802dd520bc482 in linux-6.1.y/6.1.53
25e6373a5b8efc623443f2699d2b929bf3067d76 in mainline linux
jsg [Wed, 13 Sep 2023 12:53:38 +0000 (12:53 +0000)]
drm/amdgpu: Update min() to min_t() in 'amdgpu_info_ioctl'
From Srinivasan Shanmugam
8dcc23191a6d2181855422741d73a96d91526c87 in linux-6.1.y/6.1.53
a0cc8e1512ad72c9f97cdcb76d42715730adaf62 in mainline linux
jsg [Wed, 13 Sep 2023 12:51:49 +0000 (12:51 +0000)]
drm/amdgpu: avoid integer overflow warning in amdgpu_device_resize_fb_bar()
From Arnd Bergmann
fd28ce30b525bccba4504499de625085a6def1c6 in linux-6.1.y/6.1.53
822130b5e8834ab30ad410cf19a582e5014b9a85 in mainline linux
jsg [Wed, 13 Sep 2023 12:50:04 +0000 (12:50 +0000)]
drm/amd/display: ensure async flips are only accepted for fast updates
From Hamza Mahfooz
7ac1467f9472af5e7bee1ce923569677fc84fe5b in linux-6.1.y/6.1.53
a7c0cad0dc060bb77e9c9d235d68441b0fc69507 in mainline linux
jsg [Wed, 13 Sep 2023 12:48:02 +0000 (12:48 +0000)]
drm/amdgpu: Match against exact bootloader status
From Lijo Lazar
5251c835324bee81894fdad1a844d15a79e54883 in linux-6.1.y/6.1.53
d3de41ee5febe5c2d9989fe9810bce2bb54a3a8e in mainline linux
jsg [Wed, 13 Sep 2023 12:46:32 +0000 (12:46 +0000)]
drm/amd/display: Exit idle optimizations before attempt to access PHY
From Leo Chen
ae1cb9656ef4c7aa366d1201d366866bc0989df7 in linux-6.1.y/6.1.53
de612738e9771bd66aeb20044486c457c512f684 in mainline linux
jsg [Wed, 13 Sep 2023 12:44:35 +0000 (12:44 +0000)]
drm/amd/display: Guard DCN31 PHYD32CLK logic against chip family
From George Shen
faa77cf5f28f4bbfbbb00f7e0caa2c8561f7dfe0 in linux-6.1.y/6.1.53
25b054c3c89cb6a7106a7982f0f70e83d0797dab in mainline linux
jsg [Wed, 13 Sep 2023 12:42:17 +0000 (12:42 +0000)]
drm/amd/smu: use AverageGfxclkFrequency* to replace previous GFX Curr Clock
From Jane Jian
d7b1aa3e209841834965541988154c296196a808 in linux-6.1.y/6.1.53
4a37c55b859a69f429bfa7fab4fc43ee470b60ed in mainline linux
jsg [Wed, 13 Sep 2023 12:40:30 +0000 (12:40 +0000)]
Revert "Revert drm/amd/display: Enable Freesync Video Mode by default"
From Aurabindo Pillai
7f483ce4699ac4158879833d08a86b57697b05b3 in linux-6.1.y/6.1.53
11b92df8a2f7f4605ccc764ce6ae4a72760674df in mainline linux
jsg [Wed, 13 Sep 2023 12:38:25 +0000 (12:38 +0000)]
Partially revert "drm/amd/display: Fix possible underflow for displays with large vblank"
From Daniel Miess
9fc3adc6d0fe96e79e21990faebc252814ee18a4 in linux-6.1.y/6.1.53
a99a4ff6ef205d125002fc7e0857074e4e6597b6 in mainline linux
jsg [Wed, 13 Sep 2023 12:31:49 +0000 (12:31 +0000)]
add pcie_capability_set_word() pcie_capability_clear_and_set_word()
needed for 6.1.53 drm
jsg [Wed, 13 Sep 2023 02:22:44 +0000 (02:22 +0000)]
use the eMac PowerMac4,4 connector table on eMac PowerMac6,4
avoids black screen on boot
patch from Alex Deucher in
https://gitlab.freedesktop.org/drm/amd/-/issues/2844
reported and tested by Nuno Vasconcellos
schwarze [Tue, 12 Sep 2023 17:21:05 +0000 (17:21 +0000)]
minor mandoc -T lint fixes, no content change
schwarze [Tue, 12 Sep 2023 16:26:30 +0000 (16:26 +0000)]
fix typo
schwarze [Tue, 12 Sep 2023 16:15:23 +0000 (16:15 +0000)]
document the four EVP_PKEY_OP_TYPE_* mask constants
tb [Tue, 12 Sep 2023 15:38:32 +0000 (15:38 +0000)]
Revert accidentally committed debugging code
confirmed by florian
schwarze [Tue, 12 Sep 2023 15:29:03 +0000 (15:29 +0000)]
document sizes for
ED25519 and X25519,
including the constants ED25519_KEYLEN and X25519_KEYLEN
schwarze [Tue, 12 Sep 2023 13:58:06 +0000 (13:58 +0000)]
document the constant EVP_CHACHAPOLY_TLS_TAG_LEN
schwarze [Tue, 12 Sep 2023 13:29:38 +0000 (13:29 +0000)]
Document EVP_AEAD_DEFAULT_TAG_LENGTH and EVP_AEAD_MAX_TAG_LENGTH,
making some adjacent wordings slightly more precise.
schwarze [Tue, 12 Sep 2023 12:11:05 +0000 (12:11 +0000)]
fix the vague and misleading description of the EVP_MD_FLAG_* constants
job [Tue, 12 Sep 2023 09:33:30 +0000 (09:33 +0000)]
Ensure the X.509 Subject only contains commonName and optionally serialNumber
OK tb@
jsg [Tue, 12 Sep 2023 09:01:04 +0000 (09:01 +0000)]
is is -> is
jsg [Tue, 12 Sep 2023 08:54:04 +0000 (08:54 +0000)]
is is -> it is
jsg [Tue, 12 Sep 2023 08:33:37 +0000 (08:33 +0000)]
since since -> since
jmatthew [Tue, 12 Sep 2023 08:32:58 +0000 (08:32 +0000)]
Use IORT ITS nodes to find the right ITS instance to use when establishing
interrupts. This makes MSI/MSI-X work on platforms like the Ampere Altra
which have an ITS instance for each PCI domain.
also tested by cheloha@
ok kettenis@ patrick@
jmatthew [Tue, 12 Sep 2023 08:29:28 +0000 (08:29 +0000)]
Store ITS ID in struct interrupt_controller so it can be used to look up
the right ITS to use when establishing interrupts.
ok kettenis@ patrick@
jmatthew [Tue, 12 Sep 2023 08:22:07 +0000 (08:22 +0000)]
Add an "openbsd,gic-its-id" property to gic-its nodes containing the ITS ID.
ok kettenis@ patrick@
jeremy [Mon, 11 Sep 2023 20:02:38 +0000 (20:02 +0000)]
Update to reflect changes in ruby.port.mk
This now documents all variables in ruby.port.mk except the internal
ones prefixed with an underscore, and reflects the removal of support
for building JRuby ports. Documenting the purpose of each variable
will come in a future update.
mpi [Mon, 11 Sep 2023 19:03:53 +0000 (19:03 +0000)]
Regressions for tuples and evaluating variables.
mpi [Mon, 11 Sep 2023 19:01:26 +0000 (19:01 +0000)]
Implement tuples, needed to export per-CPU scheduling data.
It is now possible to save and print immutable arrays as below:
..$t = (1, 42, "something");
..printf("%d %s\n", $t.1, $t.2);
Also add support for evaluating builtin in order to save them in variables
(required by tuples)
mvs [Mon, 11 Sep 2023 12:10:47 +0000 (12:10 +0000)]
Remove unnecessary <sys/selinfo.h> includes.
ok jsg
tb [Mon, 11 Sep 2023 09:29:30 +0000 (09:29 +0000)]
Small cleanups in cms_sd_asn1_ctrl():
Compare explicitly against NULL and use ret instead of i.
tb [Mon, 11 Sep 2023 09:24:14 +0000 (09:24 +0000)]
Rewrite CMS_SignerInfo_{sign,verify}()
Convert to using one-shot signing and verification. This is simpler than
doing Init/Update/Final and necessary for
Ed25519 support (RFC 8419). Use
a single exit idiom, don't reuse the same buffer for decoding and signing
and simplify a few other things.
ok jsing
mvs [Mon, 11 Sep 2023 08:41:26 +0000 (08:41 +0000)]
Remove unnecessary <sys/selinfo.h> includes.
ok jsg
mvs [Mon, 11 Sep 2023 08:40:25 +0000 (08:40 +0000)]
Kill unused `aac_select'. Build test performed with uncommented aac(4)
in GENERIC.
ok jsg
yasuoka [Mon, 11 Sep 2023 07:33:07 +0000 (07:33 +0000)]
Check if the avp->length is not broken. Also make sure that
avp_enum() checks if avp->length is valid.
ok mvp
florian [Mon, 11 Sep 2023 06:00:23 +0000 (06:00 +0000)]
Improve handling of ENOBUFS by not running in a tight loop forever.
This cherry-picks upstream git commit
0ee44ef384593ed0382d1ce6048d5a9c9440b45c.
Issue reported by landry@, which could be traced back to a buggy WiFi
driver that would constantly return ENOBUFS. This in turn lead
unwind(8) enter a tight loop through poll / sendto without making any
progress and burning 100% cpu.
OK sthen
jsg [Mon, 11 Sep 2023 05:07:34 +0000 (05:07 +0000)]
Neomagic -> NeoMagic
jsg [Mon, 11 Sep 2023 04:56:31 +0000 (04:56 +0000)]
StarLan -> StarLAN
jsg [Mon, 11 Sep 2023 04:51:24 +0000 (04:51 +0000)]
remove unused rkdrm_ports tailq
ok kettenis@
jsg [Mon, 11 Sep 2023 04:21:30 +0000 (04:21 +0000)]
NVME -> NVMe
jsg [Mon, 11 Sep 2023 04:00:40 +0000 (04:00 +0000)]
spelling
job [Mon, 11 Sep 2023 00:50:47 +0000 (00:50 +0000)]
Back out superfluous initialization
requested by jsing@
djm [Sun, 10 Sep 2023 23:12:32 +0000 (23:12 +0000)]
rename remote_glob() -> sftp_glob() to match other API
tb [Sun, 10 Sep 2023 17:32:17 +0000 (17:32 +0000)]
Make EVP_PKEY_get1_$TYPE a wrapper of EVP_PKEY_get0_$TYPE
Avoids a bit of code duplication and reduces the probability of a fix being
applied to only one of get0 and get1 (which happend in p_lib.c r1.35).
ok jsing
tb [Sun, 10 Sep 2023 16:53:56 +0000 (16:53 +0000)]
EVP_CipherInit(): use EVP_CIPHER_CTX_cleanup()
Before EVP_CIPHER_CTX was opaque, callers could pass an uninitialized
ctx into EVP_CipherInit() and calling EVP_CIPHER_CTX_cleanup() on such
a ctx would end in tears.
The only way to initialize a ctx is by way of EVP_CIPHER_CTX_new(), on
which we can call EVP_CIPHER_CTX_cleanup() and avoid silly leaks on ctx
reuse. This also allows some simplifications in the documentation.
There are more changes of this kind that should be done all over libcrypto.
They will be tackled in subsequent commits.
"makes a lot of sense" schwarze
ok jsing