millert [Thu, 27 Apr 2017 15:35:36 +0000 (15:35 +0000)]
Remove useless check for ks_env_table being NULL. Since ks_env_table
is an array embedded in struct keynote_session it can never be NULL.
Quiets a clang warning.
jsg [Thu, 27 Apr 2017 13:40:05 +0000 (13:40 +0000)]
remove a static array unused since rev 1.306 spotted by clang
ok djm@
mikeb [Thu, 27 Apr 2017 13:30:54 +0000 (13:30 +0000)]
Don't send multiple error messages in response to a single command
While a few commands (such as HELP and NOOP) are allowed in between
USER and PASS, most of the others are not. However if such command
is issued, ftpd should abort the command evaluation early and reply
with "530 Please login with USER and PASS."
From form@, with input from deraadt@ and OK millert@
millert [Thu, 27 Apr 2017 11:53:12 +0000 (11:53 +0000)]
Avoid potential signed int overflow when parsing the file size.
Use strtoul() instead of parsing manually. OK djm@
mpi [Thu, 27 Apr 2017 11:48:08 +0000 (11:48 +0000)]
Unifdef KADB.
ok deraadt@
kettenis [Thu, 27 Apr 2017 10:57:05 +0000 (10:57 +0000)]
Use (32-bit) word-sized access in the a4x bus space routine even if only
a byte or a half-word is needed. Certain implementations of the Synopsis
Designware copy-and-paste logic blocks don't respond to transactions that
are smaller than a word.
Fixes the serial console on boards with a Rockchip RK3288.
kettenis [Thu, 27 Apr 2017 10:23:19 +0000 (10:23 +0000)]
Add code to identify the CPUs on arm64 systems. The primary CPU is attached
and identified early on. For the secondary CPUs this happens late, such that
the drivers we need to spin up CPUs, such as psci(4), will be available.
This also fixes some code in simplebus(4) where the return value of
OF_getprop() was not properly checked.
Heavily based on an earlier diff from drahn@.
ok drahn@, jsg@
mlarkin [Thu, 27 Apr 2017 07:15:35 +0000 (07:15 +0000)]
rename a struct that was denoted as "VMX only" to make it more clear
that it can be used in SVM and VMX.
no functional change
mlarkin [Thu, 27 Apr 2017 06:49:05 +0000 (06:49 +0000)]
use a more descriptive value from the VEI_DIR_xxx enum instead of a
hardcoded number. no functional change
jmc [Thu, 27 Apr 2017 06:22:11 +0000 (06:22 +0000)]
spelling;
mlarkin [Thu, 27 Apr 2017 06:16:39 +0000 (06:16 +0000)]
vmm(4): proper save/restore of FPU context during entry/exit.
tested by reyk, dcoppa, and a few others.
ok kettenis@ on the fpu bits
ok deraadt@ on the vmm bits
stsp [Thu, 27 Apr 2017 06:14:23 +0000 (06:14 +0000)]
Restore if_iwm.c r1.173 (mira retry change) which got incarcerated by
the backout police even though it wasn't responsible for anything.
pointed out by tb@
stsp [Thu, 27 Apr 2017 05:49:32 +0000 (05:49 +0000)]
iwm(4) monitor mode support was backed out for now.
stsp [Thu, 27 Apr 2017 05:46:51 +0000 (05:46 +0000)]
Revert if_iwm.c to the state of r1.170 because ETOOMANYDRAGONSATONCE.
Performance regression reported by deraadt@ and uvm_fault reported by fcambus@.
I will be poking further at this out of tree.
dlg [Thu, 27 Apr 2017 00:02:03 +0000 (00:02 +0000)]
add support for -msave-args in gcc on amd64
i got sick of not having arguments in ddb stack traces on amd64,
which is because amd64 passes arguments in registers, and it's
impossible to figure out where they go without dwarf info, and when
you have dwarf info it is complicated.
solaris has a simple solution for this. they tweaked their compilers
to accept an -msave-args option which makes functions store their
arguments on the stack, while maintaining compatability with the
System V AMD64 ABI. tools (eg, ddb) can then look at the stack to
get access to function arguments in traces.
this ports their changes to gcc 3 to our gcc.
ok deraadt@
naddy [Wed, 26 Apr 2017 21:25:43 +0000 (21:25 +0000)]
silence clang warnings: add an extra pair of parentheses and stop
passing empty format strings to printf-family functions; ok millert@
millert [Wed, 26 Apr 2017 21:10:42 +0000 (21:10 +0000)]
In -C mode, process all checksums that match the specified file(s),
not just the first one that matches. OK deraadt@
jmc [Wed, 26 Apr 2017 21:07:21 +0000 (21:07 +0000)]
remove some repetitive text chunks; ok krw
mikeb [Wed, 26 Apr 2017 15:50:59 +0000 (15:50 +0000)]
Perform H-FSC root queue allocation in the kernel
Since only leaf queues can have packets assigned to them,
H-FSC requires the user specified root queue to have a
parent. To simplify userland tools and the configuration
interface, the kernel can be leveraged to set it up.
ok henning
sthen [Wed, 26 Apr 2017 14:53:11 +0000 (14:53 +0000)]
Install arm64 manpages: eeprom(8), MAKEDEV(8). ok phessler kettenis
millert [Wed, 26 Apr 2017 13:14:28 +0000 (13:14 +0000)]
Remove extraneous ", NULL" in the assignment of msgstr which was
leftover from when msg_cat() was removed. From Anton Lindqvist
henning [Wed, 26 Apr 2017 10:42:38 +0000 (10:42 +0000)]
cope with IP address changes. before, we were trying to resend the msg
with the no-longer-available address over and over and over, requiring
iked to be restarted eventually. instead, on EADDRNOTAVAIL, schedule
SA deletion so a new one is set up shortly thereafter. ok reyk mikeb
mlarkin [Wed, 26 Apr 2017 09:53:28 +0000 (09:53 +0000)]
Convert some hardcoded function names in printfs into %s / __func__.
Some of these pointed out by Michael W. Bombardieri, I went through
the file and fixed the rest.
No functional change.
stsp [Wed, 26 Apr 2017 09:19:56 +0000 (09:19 +0000)]
Get rid of convoluted macros in iwm's receive code path.
Since we now sync the entire Rx DMA buffer the SYNC_RESP_STRUCT() macro which
was used to sync just parts of the buffer can be replaced by assignments.
The SYNC_RESP_PTR() macro was already unused so just remove it.
The ADVANCE_RXQ() macro was used just once so expand it in place.
stsp [Wed, 26 Apr 2017 08:19:09 +0000 (08:19 +0000)]
Remove the size argument of iwm_rx_addbuf() and use a constant internally.
All callers were passing the same constant IWM_RBUF_SIZE, which is derived
from the smallest RX buffer the hardware supports (4k). Smaller sizes don't
make sense anyway and larger sizes are not on our horizon for now.
mlarkin [Wed, 26 Apr 2017 08:02:14 +0000 (08:02 +0000)]
Convert some hardcoded function names in printfs into %s / __func__.
Some of these pointed out by Michael W. Bombardieri, I went through
the file and fixed the rest.
No functional change.
stsp [Wed, 26 Apr 2017 07:53:17 +0000 (07:53 +0000)]
Tell MiRA about the actual number of retries instead of pretending that
a frame which was retried N times was retried just once.
This punishes retry-heavy data rates even more and should reduce latency.
It does not seem to have a noticable effect on net throughput in my testing.
If this change causes throughput problems for anyone, let me know.
ok tb@ mlarkin@
mlarkin [Wed, 26 Apr 2017 07:05:24 +0000 (07:05 +0000)]
Fix a typo relating to savefpu alignment
ok kettenis
jmc [Wed, 26 Apr 2017 05:55:27 +0000 (05:55 +0000)]
tweak previous;
beck [Wed, 26 Apr 2017 02:43:34 +0000 (02:43 +0000)]
We are men of action. Lies do not become us.
sthen [Tue, 25 Apr 2017 21:13:15 +0000 (21:13 +0000)]
Have libtool ignore 'static-libtool-libs'. Previously it was unsupported and
passed straight through to the compiler, which gcc doesn't mind, but clang is
unhappy about. Suggestion/ok aja@
rpe [Tue, 25 Apr 2017 19:24:05 +0000 (19:24 +0000)]
Unbreak multiple interface configurations like trunk or carp. Ensure
that the noglob option is disabled at the end of parse_hn_line()
and ifstart().
rpe [Tue, 25 Apr 2017 19:17:33 +0000 (19:17 +0000)]
Unbreak netstart for multiple inteface configurations like trunk
or carp. Ensure that the noglob option is disabled at the end of
parse_hn_line() and ifstart().
Reported by Christer Solskogen and Stefan Wollny, thanks!
nicm [Tue, 25 Apr 2017 18:30:29 +0000 (18:30 +0000)]
Make full width panes try to play more nicely with terminal copy and
paste by avoiding explicit line wraps if we think the terminal will wrap
anyway.
nicm [Tue, 25 Apr 2017 18:20:51 +0000 (18:20 +0000)]
When we write out the grid including escape sequences, an SGR 0 needs to
cause the colours to be written again. Also treat colours separately
from attributes so that RGB colours will work.
bluhm [Tue, 25 Apr 2017 17:49:11 +0000 (17:49 +0000)]
Test listening on multiple syslog over TLS sockets.
bluhm [Tue, 25 Apr 2017 17:45:50 +0000 (17:45 +0000)]
Allow syslogd(8) to listen on multiple addresses for incomming TLS
connections. This expands the feature from UDP and TCP to syslog
over TLS.
input jmc@; OK millert@
tb [Tue, 25 Apr 2017 17:33:16 +0000 (17:33 +0000)]
Use strtonum instead of strto{,u}ll for simpler and better overflow
checking, make somaxconn and sominconn unsigned.
Issue reported by orge on freenode, thanks!
Input, patient explanations and ok deraadt, millert.
reyk [Tue, 25 Apr 2017 16:38:23 +0000 (16:38 +0000)]
Generate randomized MAC addresses earlier to keep them across reboots.
OK deraadt@
nicm [Tue, 25 Apr 2017 15:35:10 +0000 (15:35 +0000)]
Do not update TERM into config file parsing has finished.
nicm [Tue, 25 Apr 2017 14:46:23 +0000 (14:46 +0000)]
Block the initial client if there is one until the configuration file
has finished loading.
jmc [Tue, 25 Apr 2017 13:52:08 +0000 (13:52 +0000)]
some ip6 setup notes; help/ok bluhm
nicm [Tue, 25 Apr 2017 11:49:35 +0000 (11:49 +0000)]
if-shell doesn't need to queue its error message into a callback, and in
fact it can't do so because the item it was working with will have been
freed. Reported by Daniel Hahler.
reyk [Tue, 25 Apr 2017 06:44:35 +0000 (06:44 +0000)]
spacing
schwarze [Mon, 24 Apr 2017 23:06:09 +0000 (23:06 +0000)]
Continue parser unification:
* Make enum rofft an internal interface as enum roff_tok in "roff.h".
* Represent mdoc and man macros in enum roff_tok.
* Make TOKEN_NONE a proper enum value and use it throughout.
* Put the prologue macros first in the macro tables.
* Unify mdoc_macroname[] and man_macroname[] into roff_name[].
rpe [Mon, 24 Apr 2017 20:50:42 +0000 (20:50 +0000)]
'rtsol' has been removed from hostname.if(5) recently.
OK jmc@
rpe [Mon, 24 Apr 2017 20:44:24 +0000 (20:44 +0000)]
Replace 'rtsol' with 'autoconf' to reflect the change in the installer.
benno [Mon, 24 Apr 2017 20:35:35 +0000 (20:35 +0000)]
Print bgp administrative shutdown messages (draft-ietf-idr-shutdown)
From Job Snijders <job -AT instituut -DOT- net>, thanks!
ok canacar@, deraadt@
rpe [Mon, 24 Apr 2017 20:31:48 +0000 (20:31 +0000)]
Introduce a new function parse_hn_line() that replaces the existing
hostname.if(5) parsing code in ifstart().
Add a -n option to netstart to only print the interface configuration
commands instead of executing them.
Add a HN_DIR variable, that points to the directory of the hostname.if
files (default /etc) that allows for future regression tests.
- add new parse_hn_line() function
- change ifstart()
- rename $if to $_if
- don't ifconfig or ifconfig create if -n option is used
- replace hostname.if(5) parsing code with new parse_hn_line()
- just print configuration commands if -n option is used
- autoconf now happens in ifstart(), remove ifv6autoconf()
- introduce HN_DIR variable for the hostname.if file location
- add handling of the -n option to only print config commands
- ensure -n is only used if interfaces are specified as parameters
Discussed with and positive feedback from many
'commit' deraadt@
OK sthen@
rpe [Mon, 24 Apr 2017 20:27:59 +0000 (20:27 +0000)]
Introduce a new function parse_hn_line() that replaces the existing
hostname.if(5) parsing code in ifstart().
- change v6_config()
- replace rtsol with autoconf in "IPv6 addres for <if>" question
- write 'inet6 autoconf" to hostname.if file instead of rtsol
- add parse_hn_line() function with installer specific changes
- skip shell command and bridge config lines
- skip inet6 config (incl. dest lines) if there's no inet6 support
- skip dhcp config if there's no dhclient
- change ifstart() to use parse_hn_line()
Discussed with and positive feedback from many
'commit' deraadt@
conditional OK sthen@ (untested)
kettenis [Mon, 24 Apr 2017 18:15:16 +0000 (18:15 +0000)]
Add support for Cortex-A12. Even though ARM rebranded these as Cortex-A17
they have a different ID from "real" Cortex-A17 cores.
ok phessler@, patrick@
jmc [Mon, 24 Apr 2017 18:05:52 +0000 (18:05 +0000)]
a little more consistent text for previous; ok krw
krw [Mon, 24 Apr 2017 14:58:36 +0000 (14:58 +0000)]
Add 'echo-client-id' statment, so that RFC 6842 behaviour can be
turned off for those clients and networks that find it impossible to
move past RFC 2131. Modelled on the same statement in recent ISC
versions, though we default to 'on' (a.k.a. RFC 6842) rather that
'off' (a.k.a. RFC 2131).
Problems reported by Bastien Durel (Xerox Phaser 6022 printer) and
Bryan Vyhmeister (Hon Hai Precision router) via misc@. Thanks!
visa [Mon, 24 Apr 2017 14:10:19 +0000 (14:10 +0000)]
Process fdt before iobus devices. Needed later when interrupt and
MDIO controller drivers are attached using fdt.
jmc [Mon, 24 Apr 2017 13:58:39 +0000 (13:58 +0000)]
update for the llvm libs; help/ok kettenis
visa [Mon, 24 Apr 2017 13:54:28 +0000 (13:54 +0000)]
Add an fdt blob for octeon systems whose firmware does not provide
a device-tree. It will be needed later when more device drivers
are attached using fdt.
OK kettenis@
jsg [Mon, 24 Apr 2017 13:20:46 +0000 (13:20 +0000)]
Since rev 1.1 ix has attempted to require a 64 bit BAR, the test for
this was wrong and was corrected at the end of last year in rev 1.140.
Before then a 64 bit BAR was not enforced as the test was wrong.
It turns out there exist 82598 parts which have a 32 bit BAR so change
the test to only require a memory BAR and not a 64 bit memory BAR.
Problem reported by Robert Blacquiere. ok mikeb@
stsp [Mon, 24 Apr 2017 09:53:43 +0000 (09:53 +0000)]
Document support for 3168 and 8265 devices in iwm(4).
stsp [Mon, 24 Apr 2017 09:50:04 +0000 (09:50 +0000)]
Document monitor mode support in iwm(4).
stsp [Mon, 24 Apr 2017 09:48:42 +0000 (09:48 +0000)]
Implement monitor mode support for iwm(4).
The magic commands to capture raw 802.11 frames on e.g. channel 1 are:
ifconfig iwm0 mediaopt monitor chan 1
tcpdump -n -i iwm0 -y IEEE802_11_RADIO -s 4096 -w /tmp/iwm.pcap
ifconfig iwm0 -mediaopt monitor -chan
stsp [Mon, 24 Apr 2017 09:31:31 +0000 (09:31 +0000)]
Implement support for multiple packets per receive DMA buffer in iwm(4).
We can now clear SINGLE_FRAME_MSK in the receive configuration register.
Linux has not set this bit in years, and Dragonfly stopped setting it
in commit
b5eb43f0280bbcfd26af51cf5a4b8e8ff3590b67.
This is a prerequisite for monitor mode since the firmware seems to ignore
the SINGLE_FRAME_MSK bit while running in monitor mode and sends us garbage.
Tested on 7260, 7265, and 8260 devices.
kettenis [Mon, 24 Apr 2017 08:09:13 +0000 (08:09 +0000)]
Stop dumping registers on "normal" segmentation faults. Do print the contents
of the esr_el1 register for unhandled userland exceptions (and continue to
dump the registers in that case).
Handle breakpoint traps and make sure we call refreshcreds() on userland traps.
ok jsg@
reyk [Mon, 24 Apr 2017 07:14:27 +0000 (07:14 +0000)]
Don't overflow the allocated DHCP response buffer.
When copying the DHCP/BOOTP response into the allocated buffer, use
the calculated response length instead of the maximum size of a DHCP
packet. The response length was verified correctly but the very last
step missed to use it.
Found by Caspar Schutijser and malloc.conf(5) "S"
OK deraadt@
reyk [Mon, 24 Apr 2017 07:07:25 +0000 (07:07 +0000)]
Fix configuration of ASN1_DN IDs.
Public key authentication uses public key files that are stored in the
/etc/iked/pubkeys/ directory where the IKE IDs are encoded as filenames.
This does not simply work with ASN1_DNs where the IDs include slashes
and other special characters. Instead of breaking and failing when an
ASN1_DN is configured, simply skip the public key lookup but allow
to use it with certificates or PSKs.
Reported and fix tested by Igor V. Gubenko - Thanks.
ratchov [Mon, 24 Apr 2017 06:47:41 +0000 (06:47 +0000)]
Fix typos. From Michael W. Bombardieri <mb at ii.net>. Thanks!
ratchov [Mon, 24 Apr 2017 06:45:56 +0000 (06:45 +0000)]
Print usage on stderr as do other programs. From Michael
Bombardieri <mb at ii.net>, thanks.
stsp [Sun, 23 Apr 2017 21:04:55 +0000 (21:04 +0000)]
Handle unequal numbers of Tx and Rx streams in MiRA.
Problem reported by Colton Lewis on misc@
ok tb@
nicm [Sun, 23 Apr 2017 18:13:24 +0000 (18:13 +0000)]
Only use ED for clear screen if at the bottom, same as earlier fix to
clear end of screen.
sthen [Sun, 23 Apr 2017 11:37:11 +0000 (11:37 +0000)]
Some of the LOG_NOTICE messages from PF were seen in normal operations
with certain rulesets and excessively noisy; move them to LOG_INFO (which was
previously unused). ok benno@
jmc [Sun, 23 Apr 2017 07:41:25 +0000 (07:41 +0000)]
oops, this was meant to be committed with the pfctl.8 change:
sync usage() with SYNOPSIS;
jmc [Sun, 23 Apr 2017 07:40:34 +0000 (07:40 +0000)]
trim the documentation for -k: make it more consistent,
and do not try to do all the documenting in SYNOPSIS/usage();
ok deraadt
otto [Sun, 23 Apr 2017 06:36:36 +0000 (06:36 +0000)]
Rearrange text a bit to make it clear what "discarded" means; ok jmc@ deraadt@
deraadt [Sat, 22 Apr 2017 17:47:21 +0000 (17:47 +0000)]
sync
visa [Sat, 22 Apr 2017 15:43:35 +0000 (15:43 +0000)]
Recognize Loongson 3A2000/3B2000 processors.
visa [Sat, 22 Apr 2017 15:37:39 +0000 (15:37 +0000)]
Fix an early boot failure on Loongson 3A2000.
Reported and patch tested by wen heping
ajacoutot [Sat, 22 Apr 2017 14:00:30 +0000 (14:00 +0000)]
The gnome module supports cmake now.
robert [Sat, 22 Apr 2017 13:42:05 +0000 (13:42 +0000)]
do not leave temp files after the diffing is done
robert [Sat, 22 Apr 2017 13:41:02 +0000 (13:41 +0000)]
Add a small shell script to be used by syspatch to diff the fake root
directories for changes due to the fact that we have to do some "magic"
to figure out if things have really changed.
robert [Sat, 22 Apr 2017 13:39:00 +0000 (13:39 +0000)]
rework the syspatch makefile and do complete builds for each errata
and diff those instead of doing partial builds of affected directories
nicm [Sat, 22 Apr 2017 12:55:06 +0000 (12:55 +0000)]
Memory leak from David CARLIER.
visa [Sat, 22 Apr 2017 12:34:44 +0000 (12:34 +0000)]
Reindent with tabs and add missing braces.
nicm [Sat, 22 Apr 2017 12:08:41 +0000 (12:08 +0000)]
Do not need getopt.h.
visa [Sat, 22 Apr 2017 11:12:04 +0000 (11:12 +0000)]
Xr mutex(9) and rwlock(9)
visa [Sat, 22 Apr 2017 11:05:04 +0000 (11:05 +0000)]
Shuffle bits into their proper files.
Prompted by jmc@
nicm [Sat, 22 Apr 2017 10:30:56 +0000 (10:30 +0000)]
Can't collect UTF-8 characters of more than one byte at the moment.
nicm [Sat, 22 Apr 2017 10:26:44 +0000 (10:26 +0000)]
new -A should use the session name.
nicm [Sat, 22 Apr 2017 10:22:39 +0000 (10:22 +0000)]
Get rid of the extra layer of flags and cmd_prepare() and just store the
CMD_FIND_* flags in the cmd_entry and call it for the command. Commands
with special requirements call it themselves and update the target for
hooks to use.
otto [Sat, 22 Apr 2017 09:12:49 +0000 (09:12 +0000)]
For small allocations (chunk) freezero only validates the given
size if canaries are enabled. In that case we have the exact requested
size of the allocation. But we can at least check the given size
against the chunk size if C is not enabled. Plus add some braces
so my brain doesn't have to scan for dangling else problems when I
see this code.
nicm [Sat, 22 Apr 2017 08:56:24 +0000 (08:56 +0000)]
Mouse bindings and hooks set up an initial current state when running a
command. This is used for the session, window and pane for all commands
in the command sequence if there is no -t or -s.
However, using it for all commands in the command sequence means that if
the active pane or current session is changed, subsequent commands still
use the previous state. So make commands which explicitly change the
current state (such as neww and selectp) update it themselves for later
commands. Commands which may invalidate the state (like killp) are
already OK because an invalid state will be ignored.
Also fill in the current state for all key bindings rather than just the
mouse, so that any omissions are easier to spot.
nicm [Sat, 22 Apr 2017 08:33:28 +0000 (08:33 +0000)]
We need to collect UTF-8 characters so that width != 1 characters are
correctly flushed.
nicm [Sat, 22 Apr 2017 06:27:15 +0000 (06:27 +0000)]
Fix if-shell without a client (so in the config file). Reported by Theo
Buehler.
nicm [Sat, 22 Apr 2017 06:15:22 +0000 (06:15 +0000)]
Typo in example.
nicm [Sat, 22 Apr 2017 06:13:30 +0000 (06:13 +0000)]
Memory leaks, from David CARLIER.
visa [Sat, 22 Apr 2017 04:00:21 +0000 (04:00 +0000)]
Manual page for witness(4). Adapted from FreeBSD.
yasuoka [Fri, 21 Apr 2017 23:22:49 +0000 (23:22 +0000)]
Add "key" modifier for -k to make pfctl can kill a state by specifying
the key of the state.
ok sasha
yasuoka [Fri, 21 Apr 2017 23:21:02 +0000 (23:21 +0000)]
Speed up DIOCKILLSTATES by using the RB tree index if all fields used
by the tree of given state key are filled.
ok sasha
nicm [Fri, 21 Apr 2017 22:23:24 +0000 (22:23 +0000)]
Log error properly when no current state, and some other minor tweaks.
nicm [Fri, 21 Apr 2017 22:00:06 +0000 (22:00 +0000)]
Make sure cmd_find_from_* clear the state if they fail.
nicm [Fri, 21 Apr 2017 21:02:26 +0000 (21:02 +0000)]
Rename a variable.
nicm [Fri, 21 Apr 2017 20:34:05 +0000 (20:34 +0000)]
Clear shared state if not filling it in.