openbsd
2 years agoFix off-by-one in MAX_MANIFEST_ENTRIES check
tb [Wed, 1 Jun 2022 10:58:34 +0000 (10:58 +0000)]
Fix off-by-one in MAX_MANIFEST_ENTRIES check

ok claudio job

2 years agoshrink dmesg output by printing the ethernet address on the attach line.
dlg [Wed, 1 Jun 2022 08:19:15 +0000 (08:19 +0000)]
shrink dmesg output by printing the ethernet address on the attach line.

2 years agomark the mvneta interrupt handler as mpsafe.
dlg [Wed, 1 Jun 2022 06:33:46 +0000 (06:33 +0000)]
mark the mvneta interrupt handler as mpsafe.

link state changes still take the kernel lock, but packet processing
is unlocked now.

2 years agorework the rx ring processing.
dlg [Wed, 1 Jun 2022 04:31:08 +0000 (04:31 +0000)]
rework the rx ring processing.

this is another big step toward making the code mpsafe, and makes
a bunch of ring operations such as dmamap syncs and register updates
get done once for the ring rather than for every packet.

2 years agomark mvneta_start mpsafe.
dlg [Wed, 1 Jun 2022 03:51:19 +0000 (03:51 +0000)]
mark mvneta_start mpsafe.

the interrupt handler is still under kernel lock, but at least you
can queue packets from another cpu concurrently.

2 years agodont have to say Ethernet address in dmesg, address is fine
dlg [Wed, 1 Jun 2022 03:39:57 +0000 (03:39 +0000)]
dont have to say Ethernet address in dmesg, address is fine

2 years agotrim some white space
dlg [Wed, 1 Jun 2022 03:37:41 +0000 (03:37 +0000)]
trim some white space

2 years agorework tx start and completion.
dlg [Wed, 1 Jun 2022 03:34:21 +0000 (03:34 +0000)]
rework tx start and completion.

this is a big step toward making the code mpsafe, and makes a bunch
of ring operations such as dmamap syncs and register updates per
start/completion call rather than per packet.

2 years agoMake sure we error on parse failure.
tb [Tue, 31 May 2022 21:35:46 +0000 (21:35 +0000)]
Make sure we error on parse failure.

ok claudio

2 years agoRudimentary implementation of the \A escape sequence, following groff
schwarze [Tue, 31 May 2022 20:21:40 +0000 (20:21 +0000)]
Rudimentary implementation of the \A escape sequence, following groff
semantics (test identifier for syntactical validity), not at all
following the completely unrelated Heirloom semantics (define
hyperlink target position).

The main motivation for providing this implementation is to get \A
into the parsing class ESCAPE_EXPAND that corresponds to groff parsing
behaviour, which is quite similar to the \B escape sequence (test
numerical expression for syntactical validity).  This is likely
to improve parsing of nested escape sequences in the future.

Validation isn't perfect yet.  In particular, this implementation
rejects \A arguments containing some escape sequences that groff
allows to slip through.  But that is unlikely to cause trouble even
in documents using \A for non-trivial purposes.  Rejecting the nested
escapes in question might even improve robustnest because the rejected
names are unlikely to really be usable for practical purposes - no
matter that groff dubiously considers them syntactically valid.

2 years agofix spacing;
jmc [Tue, 31 May 2022 20:12:24 +0000 (20:12 +0000)]
fix spacing;

2 years agoFix typo: argv[1] -> argv[i]
tb [Tue, 31 May 2022 19:37:02 +0000 (19:37 +0000)]
Fix typo: argv[1] -> argv[i]

2 years agoRemove old checklists and add a couple of new ones.
tb [Tue, 31 May 2022 19:14:15 +0000 (19:14 +0000)]
Remove old checklists and add a couple of new ones.

2 years agoThe pflow regression test could fail due to a race where the close(2)
mbuhl [Tue, 31 May 2022 19:01:46 +0000 (19:01 +0000)]
The pflow regression test could fail due to a race where the close(2)
call of the receiver was called before the FIN on the sender was
processed.

OK bluhm@
OK anton@

2 years agoI made non-trivial contributions to these files.
tb [Tue, 31 May 2022 18:51:35 +0000 (18:51 +0000)]
I made non-trivial contributions to these files.

2 years agoShuffle two helper functions down.
tb [Tue, 31 May 2022 18:45:14 +0000 (18:45 +0000)]
Shuffle two helper functions down.

This way the helper functions appear in the order they are used in
rsc_parse_econtent().

2 years agoUpdate reference to RSC draft 08
tb [Tue, 31 May 2022 18:42:26 +0000 (18:42 +0000)]
Update reference to RSC draft 08

ok claudio job

2 years agoRemove now unused ASN1_frame() and cms_econtent_version()
tb [Tue, 31 May 2022 18:41:43 +0000 (18:41 +0000)]
Remove now unused ASN1_frame() and cms_econtent_version()

ok claudio job

2 years agoRewrite rsc.c using ASN.1 templates
tb [Tue, 31 May 2022 18:40:15 +0000 (18:40 +0000)]
Rewrite rsc.c using ASN.1 templates

This implements the constrained versions of the RFC 3779 structures
since OpenSSL's 3779 API doesn't expose IPAddrBlocks. This way we can
also avoid extra checks after walking the structs. Use the previously
exposed sbgp_as_{id,range}() and sbgp_addr{,_range}() to remove a lot
of copy-pasted code.

While parsing ConstrainedASIdentifiers allocate only once and for
ConstrainedIPAddrBlocks allocate once per address family instead of
doing a reallocation for each asid or prefix.

This removes the last explicit use of ASN1_TYPE and ASN1_SEQUENCE_ANY
from rpki-client.

ok claudio job

2 years agoPrepare rewrite of rsc.c with templated ASN.1
tb [Tue, 31 May 2022 18:33:16 +0000 (18:33 +0000)]
Prepare rewrite of rsc.c with templated ASN.1

Change signatures of various functions to avoid using struct parse and
expose sbgp_as_{id,range}() and sbgp_addr{,_range}() so they can be used
from rsc.c. This is a mostly mechanical diff.

ok claudio job

2 years agoTrivial patch to put the roff(7) \g (interpolate format of register)
schwarze [Tue, 31 May 2022 18:08:02 +0000 (18:08 +0000)]
Trivial patch to put the roff(7) \g (interpolate format of register)
escape sequence into the correct parsing class, ESCAPE_EXPAND.
Expansion of \g is supposed to work exactly like the expansion
of the related escape sequence \n (interpolate register value),
but since we ignore the .af (assign output format) request,
we just interpolate an empty string to replace the \g sequence.

Surprising as it may seem, this actually makes a formatting difference
for deviate input like ".O\gNx" which used to raise bogus "escaped
character not allowed in a name" and "skipping unknown macro" errors
and printed nothing, whereas now it correctly prints "OpenBSD".

2 years agoAdd a missing space.
nicm [Tue, 31 May 2022 16:13:43 +0000 (16:13 +0000)]
Add a missing space.

2 years agossh-keygen: implement "verify-required" certificate option
naddy [Tue, 31 May 2022 14:05:12 +0000 (14:05 +0000)]
ssh-keygen: implement "verify-required" certificate option

This was already documented when support for user-verified FIDO
keys was added, but the ssh-keygen(1) code was missing.

ok djm@

2 years agoTrim menu item text correctly, GitHub issue 3197.
nicm [Tue, 31 May 2022 10:22:42 +0000 (10:22 +0000)]
Trim menu item text correctly, GitHub issue 3197.

2 years agoIntroduce a integration test for max-communities
claudio [Tue, 31 May 2022 09:50:26 +0000 (09:50 +0000)]
Introduce a integration test for max-communities

2 years agoExtend community unit test to also check community_count()
claudio [Tue, 31 May 2022 09:46:54 +0000 (09:46 +0000)]
Extend community unit test to also check community_count()

2 years agoImplement a max communities filter match
claudio [Tue, 31 May 2022 09:45:33 +0000 (09:45 +0000)]
Implement a max communities filter match

When max-communities X is set on a filterrule the filter will match when
more than X communities are present in the path. In other words
max-communities 0 means no communities are allowed and max-communities 3
limits it up to 3 communities.
There is max-communities, max-ext-communities and max-large-communities
for each of the 3 community attributes. These three max checks can be used
together.
OK tb@ job@

2 years agosync
deraadt [Mon, 30 May 2022 23:31:45 +0000 (23:31 +0000)]
sync

2 years agoDummy implementation of the roff(7) \V (interpolate environment variable)
schwarze [Mon, 30 May 2022 22:50:40 +0000 (22:50 +0000)]
Dummy implementation of the roff(7) \V (interpolate environment variable)
escape sequence.  This is needed to get \V into the correct parsing
class, ESCAPE_EXPAND.

It is intentional that mandoc(1) output is *not* influenced by environment
variables, so interpolate the name of the variable with some decorating
punctuation rather than interpolating its value.

2 years agoknf; fix whitespace in structs
dv [Mon, 30 May 2022 17:58:20 +0000 (17:58 +0000)]
knf; fix whitespace in structs

2 years agosfgpio(4)
kettenis [Mon, 30 May 2022 17:44:10 +0000 (17:44 +0000)]
sfgpio(4)

2 years agoAdd sfgpio(4), a driver for the GPIO controller found on the
kettenis [Mon, 30 May 2022 17:39:09 +0000 (17:39 +0000)]
Add sfgpio(4), a driver for the GPIO controller found on the
SiFive FU740 SoC.

ok jca@

2 years agogrep(1): print full context when using match count
dv [Mon, 30 May 2022 16:07:28 +0000 (16:07 +0000)]
grep(1): print full context when using match count

When using the match count flag (-m), grep was not printing the
context after the match if the -A or -C flags were provided.

This changes the logic to continue printing lines after hitting the
match count.

ok op@, millert@

2 years agoReplace selwakeup() with KNOTE() in pipe event activation.
visa [Mon, 30 May 2022 14:06:16 +0000 (14:06 +0000)]
Replace selwakeup() with KNOTE() in pipe event activation.

Recommit the reverted change selectively so that only pipes are
affected. Leave sockets untouched for now.

2 years agoRemove duplicates from completion list, GitHub issue 3178.
nicm [Mon, 30 May 2022 13:07:46 +0000 (13:07 +0000)]
Remove duplicates from completion list, GitHub issue 3178.

2 years agoAdd pane_start_path to match start_command.
nicm [Mon, 30 May 2022 13:07:06 +0000 (13:07 +0000)]
Add pane_start_path to match start_command.

2 years agoSet PWD so shells have a hint about the real path (this was done before
nicm [Mon, 30 May 2022 13:06:41 +0000 (13:06 +0000)]
Set PWD so shells have a hint about the real path (this was done before
but lost in a merge). GitHub issue 3186.

2 years agoFix property name from Sergei Dyshel, and a typo from imcusg at gmail
nicm [Mon, 30 May 2022 13:06:10 +0000 (13:06 +0000)]
Fix property name from Sergei Dyshel, and a typo from imcusg at gmail
dot com.

2 years agoCheck if args_strtonum argument is NULL or not a string, from Anindya
nicm [Mon, 30 May 2022 13:04:24 +0000 (13:04 +0000)]
Check if args_strtonum argument is NULL or not a string, from Anindya
Mukherjee.

2 years agoDo not allow pipe-pane on dead panes, from Anindya Mukherjee, GitHub
nicm [Mon, 30 May 2022 13:03:46 +0000 (13:03 +0000)]
Do not allow pipe-pane on dead panes, from Anindya Mukherjee, GitHub
issue 3174.

2 years agoIf a mouse position was above the maximum supported by the normal mouse
nicm [Mon, 30 May 2022 13:02:55 +0000 (13:02 +0000)]
If a mouse position was above the maximum supported by the normal mouse
protocol (223), tmux was allowing it to wrap around. However, since tmux
was not correctly handling this on input, other programs also do not
handle it correctly, and the alternative SGR mouse mode is now
widespread, this seems unnecessary, so remove this feature. Also define
some constants to make it clearer what the numbers mean. Mostly from
Leonid S Usov in GitHub issue 3165.

2 years agoAdd a way for lines added to copy mode to be passed through the parser
nicm [Mon, 30 May 2022 13:00:18 +0000 (13:00 +0000)]
Add a way for lines added to copy mode to be passed through the parser
to handle escape sequences and use it for run-shell, GitHub issue 3156.

2 years agoiTerm2 has OSC 7, from Gregory Anders.
nicm [Mon, 30 May 2022 12:57:31 +0000 (12:57 +0000)]
iTerm2 has OSC 7, from Gregory Anders.

2 years agoSpacing/style nits.
nicm [Mon, 30 May 2022 12:55:25 +0000 (12:55 +0000)]
Spacing/style nits.

2 years agoEmit window-layout-changed on swap-pane, from George Nachman.
nicm [Mon, 30 May 2022 12:54:09 +0000 (12:54 +0000)]
Emit window-layout-changed on swap-pane, from George Nachman.

2 years agoBetter error reporting when applying custom layouts.
nicm [Mon, 30 May 2022 12:52:02 +0000 (12:52 +0000)]
Better error reporting when applying custom layouts.

2 years agoDo not send focus sequences when focus is enabled or disabled by the
nicm [Mon, 30 May 2022 12:51:27 +0000 (12:51 +0000)]
Do not send focus sequences when focus is enabled or disabled by the
application if it is turned off. GitHub issue 3142.

2 years agoAdd an ACL list for users connecting to the tmux socket. Users may be
nicm [Mon, 30 May 2022 12:48:57 +0000 (12:48 +0000)]
Add an ACL list for users connecting to the tmux socket. Users may be
forbidden from attaching, forced to attach read-only, or allowed to
attach read-write. A new command, server-access, configures the list.
tmux gets the user using getpeereid(3) of the client socket. Users must
still configure file system permissions manually. From Dallas Lyons and
others.

2 years agomove bufsz description after appbufsz as per struct fields order
op [Mon, 30 May 2022 10:31:59 +0000 (10:31 +0000)]
move bufsz description after appbufsz as per struct fields order

ok ratchov@

2 years agomake a first pass at providing kstats from the hardware counters.
dlg [Mon, 30 May 2022 10:30:33 +0000 (10:30 +0000)]
make a first pass at providing kstats from the hardware counters.

mvneta counters are read to clear, so we accumulate them over time.
they are also mostly 32bit, except for 2 of them, so this handles
all the 32bit counters in a loop and deals with the 64bit ones as
exceptions.

i can see rx drops now, but not the rx rx counters yet. i'll figure
it out.

this is mostly inspired by em(4).

2 years agotell the compiler about the tx/rx desc alignment.
dlg [Mon, 30 May 2022 09:37:46 +0000 (09:37 +0000)]
tell the compiler about the tx/rx desc alignment.

this leads to better (and shorter) code.

ok patrick@

2 years agotweak the display a bit: have "hashing/tieing" be progress messages
espie [Mon, 30 May 2022 09:30:40 +0000 (09:30 +0000)]
tweak the display a bit: have "hashing/tieing" be progress messages
(they probably won't mean a lot to most users but then they only
appear fleetingly apart from stuff like texlive)

2 years agopwr_action isn't used in this file, zap pointless decl.
jca [Sun, 29 May 2022 22:03:44 +0000 (22:03 +0000)]
pwr_action isn't used in this file, zap pointless decl.

2 years agoDevice tree bindings for this device are official now.
kettenis [Sun, 29 May 2022 16:19:08 +0000 (16:19 +0000)]
Device tree bindings for this device are official now.

2 years agoMore precision regarding a few minor points:
schwarze [Sun, 29 May 2022 12:46:28 +0000 (12:46 +0000)]
More precision regarding a few minor points:
* Say what happens when no pkg-name is given.
* Say "show the names and one-line comments" rather than just "information".
* Say which options cannot be combined with pkg-name arguments.
* Say which options are already the default in some circumstances.
OK espie@

2 years agodocument the meaning of the -Q option argument;
schwarze [Sun, 29 May 2022 10:58:03 +0000 (10:58 +0000)]
document the meaning of the -Q option argument;
OK espie@

2 years agofinal part of caching for always-update: the new annotation doesn't need
espie [Sun, 29 May 2022 10:48:41 +0000 (10:48 +0000)]
final part of caching for always-update: the new annotation doesn't need
any specific handling.

2 years agoEOF does not result in an error code, as spotted by stsp@
espie [Sat, 28 May 2022 23:20:28 +0000 (23:20 +0000)]
EOF does not result in an error code, as spotted by stsp@

2 years agoSince 'sa' can be freed inside the loop, RB_FOREACH_SAFE is required.
gerhard [Sat, 28 May 2022 18:51:16 +0000 (18:51 +0000)]
Since 'sa' can be freed inside the loop, RB_FOREACH_SAFE is required.

ok tobhe@

2 years ago*** empty log message ***
mbuhl [Sat, 28 May 2022 18:39:39 +0000 (18:39 +0000)]
*** empty log message ***

2 years agorework the power status changes text;
jmc [Sat, 28 May 2022 16:07:54 +0000 (16:07 +0000)]
rework the power status changes text;
original diff from jan stary, adjusted according to sthen

2 years agohave pkg_create generate the hash for always-update
espie [Sat, 28 May 2022 07:46:27 +0000 (07:46 +0000)]
have pkg_create generate the hash for always-update

2 years agokeywords ref ssh_config.5;
jmc [Sat, 28 May 2022 05:57:56 +0000 (05:57 +0000)]
keywords ref ssh_config.5;
from caspar schutijser

2 years agooops, wrong value in previous commit
deraadt [Sat, 28 May 2022 03:47:43 +0000 (03:47 +0000)]
oops, wrong value in previous commit

2 years ago64K of locked memory should be enough for anyone (until we hear a good
deraadt [Sat, 28 May 2022 03:21:17 +0000 (03:21 +0000)]
64K of locked memory should be enough for anyone (until we hear a good
reason why)
discussed with many, ok millert

2 years agoclear cur_membag so that pcap can be used more than once
deraadt [Sat, 28 May 2022 03:20:33 +0000 (03:20 +0000)]
clear cur_membag so that pcap can be used more than once

2 years agoDo not walk off the end of the array performing frees
deraadt [Sat, 28 May 2022 03:20:14 +0000 (03:20 +0000)]
Do not walk off the end of the array performing frees
crash found by daharmasterkor

2 years agoConvert KVA allocation to km_alloc(9).
kettenis [Fri, 27 May 2022 18:55:30 +0000 (18:55 +0000)]
Convert KVA allocation to km_alloc(9).

ok deraadt@, mpi@

2 years agorework the text on mtu and mss, according to some notes from sthen;
jmc [Fri, 27 May 2022 15:45:02 +0000 (15:45 +0000)]
rework the text on mtu and mss, according to some notes from sthen;
ok sthen

2 years agoNormalise markup.
ajacoutot [Fri, 27 May 2022 12:27:39 +0000 (12:27 +0000)]
Normalise markup.

from Raf Czlonka

2 years agoCall uvm_vnp_uncache() before VOP_RENAME().
mpi [Fri, 27 May 2022 11:10:54 +0000 (11:10 +0000)]
Call uvm_vnp_uncache() before VOP_RENAME().

ok kettenis@

2 years agosplit the low-level file handling functions out from auth2-pubkey.c
djm [Fri, 27 May 2022 05:02:46 +0000 (05:02 +0000)]
split the low-level file handling functions out from auth2-pubkey.c

Put them in a new auth2-pubkeyfile.c to make it easier to refer to them
(e.g. in unit/fuzz tests) without having to refer to everything else
pubkey auth brings in.

ok dtucker@

2 years agorefactor authorized_keys/principals handling
djm [Fri, 27 May 2022 05:01:25 +0000 (05:01 +0000)]
refactor authorized_keys/principals handling

remove "struct ssh *" from arguments - this was only used to pass the
remote host/address. These can be passed in instead and the resulting
code is less tightly coupled to ssh_api.[ch]

ok dtucker@

2 years agof sshpkt functions fail, then password is not cleared with freezero.
dtucker [Fri, 27 May 2022 04:29:40 +0000 (04:29 +0000)]
f sshpkt functions fail, then password is not cleared with freezero.
Unconditionally call freezero to guarantee that password is removed
from RAM.

From tobias@ and c3h2_ctf via github PR#286, ok djm@

2 years agoAvoid kill with -1 argument.
dtucker [Fri, 27 May 2022 04:27:49 +0000 (04:27 +0000)]
Avoid kill with -1 argument.
The out_ctx label can be reached before fork has been called. If this
happens, then kill -1 would be called, sending SIGTERM to all processes
reachable by the current process.

From tobias@ and c3h2_ctf via github PR#286, ok djm@

2 years agoNote that ProxyJump also accepts the same tokens as ProxyCommand.
dtucker [Fri, 27 May 2022 04:13:24 +0000 (04:13 +0000)]
Note that ProxyJump also accepts the same tokens as ProxyCommand.
From pallxk via github PR#305.

2 years agoAdjust compatible string to match what has been submitted to mainline Linux.
kettenis [Thu, 26 May 2022 23:32:18 +0000 (23:32 +0000)]
Adjust compatible string to match what has been submitted to mainline Linux.
Keep supporting the old compatible string for a bit longer.
Add frequency sensors that reflect the actual frequencies the CPU clusters
are running at as reported by the hardware.

ok patrick@

2 years agoI'm a doofus, of course I need to use "write_without_variation" for that
espie [Thu, 26 May 2022 21:08:52 +0000 (21:08 +0000)]
I'm a doofus, of course I need to use "write_without_variation" for that

2 years agorecognise Cortex-X1C
jsg [Thu, 26 May 2022 13:54:38 +0000 (13:54 +0000)]
recognise Cortex-X1C

2 years agoIntroduce a new daemon_execdir variable for changing to a specified directory
ajacoutot [Thu, 26 May 2022 11:27:03 +0000 (11:27 +0000)]
Introduce a new daemon_execdir variable for changing to a specified directory
before running rc_rcexec.

Based on an proposal from openbsd.tech at aisha.cc
ok robert@ abieber@

2 years agofirst step in simplifying the always-update case:
espie [Thu, 26 May 2022 06:53:38 +0000 (06:53 +0000)]
first step in simplifying the always-update case:
tweak @option always-update to allow parsing
@option always-update <hash_value_for_the_whole_plist>

once this is safely in snapshots, we can generate it
directly within PkgCreate.pm, compare it directly in
Signature.pm and get rid of the whole special case
of having to keep the whole plist around

2 years agodrm/i915/adl-n: Add stepping info
jsg [Thu, 26 May 2022 06:20:59 +0000 (06:20 +0000)]
drm/i915/adl-n: Add stepping info

From Tejas Upadhyay
8d80cceecdd98de6d2281d39d6571a1fe08e5af9 in mainline linux

2 years agodrm/i915/rpl-s: Add stepping info
jsg [Thu, 26 May 2022 06:13:24 +0000 (06:13 +0000)]
drm/i915/rpl-s: Add stepping info

From Anusha Srivatsa
8295524a2d5550b56e800ac779a183b7f4d8c33c in mainline linux

2 years agodrm/i915/rpl-s: Enable guc submission by default
jsg [Thu, 26 May 2022 05:11:51 +0000 (05:11 +0000)]
drm/i915/rpl-s: Enable guc submission by default

From Anusha Srivatsa
c9ee950a2ca55ea0f63d0893f796b2eb089e7900 in mainline linux

2 years agodrm/i915/adl-n: Add PCH Support for Alder Lake N
jsg [Thu, 26 May 2022 04:57:00 +0000 (04:57 +0000)]
drm/i915/adl-n: Add PCH Support for Alder Lake N

From Tejas Upadhyay
02ed904261481460e6084769416e7ca31bbb92eb in mainline linux

2 years agodrm/i915/rpl-s: Add PCH Support for Raptor Lake S
jsg [Thu, 26 May 2022 04:52:50 +0000 (04:52 +0000)]
drm/i915/rpl-s: Add PCH Support for Raptor Lake S

From Anusha Srivatsa
4a75f32fc783128d0c42ef73fa62a20379a66828 in mainline linux

2 years agoregen
jsg [Thu, 26 May 2022 01:47:30 +0000 (01:47 +0000)]
regen

2 years agoadd more Intel RPL-S graphics ids
jsg [Thu, 26 May 2022 01:47:02 +0000 (01:47 +0000)]
add more Intel RPL-S graphics ids

2 years agodrm/i915/rpl-p: Add PCI IDs
jsg [Thu, 26 May 2022 01:41:16 +0000 (01:41 +0000)]
drm/i915/rpl-p: Add PCI IDs

From Matt Atwood
72c3c8d6e5275b19fd2d32ec787e8135a421c7ec in mainline linux

2 years agodrm/i915: Add RPL-S PCI IDs
jsg [Thu, 26 May 2022 01:36:02 +0000 (01:36 +0000)]
drm/i915: Add RPL-S PCI IDs

From Tejas Upadhyay
756b807f6a3e01d238c346925006cdfd6a59e341 in mainline linux

2 years agoCall if_put(9) after we finish with `ia' within ip_getmoptions().
mvs [Wed, 25 May 2022 19:48:46 +0000 (19:48 +0000)]
Call if_put(9) after we finish with `ia' within ip_getmoptions().

if_put(9) call means we finish work with `ifp' and it could be destroyed.
`ia' is the pointer to 'in_ifaddr' data belongs to `ifp', so we need to
release corresponding `ifp' after we finish deal with `ia'.

`if_addrlist' list destruction and ip_getmoptions() are serialized with
kernel and net locks so this is not critical, but looks inconsistent.

ok bluhm@

2 years agoRevert the .rodata.cst4 change: results in incorrect value read
guenther [Wed, 25 May 2022 17:32:36 +0000 (17:32 +0000)]
Revert the .rodata.cst4 change: results in incorrect value read

2 years agoRemove an unnecessary XXX comment. The suggested check is part of
tb [Wed, 25 May 2022 17:10:30 +0000 (17:10 +0000)]
Remove an unnecessary XXX comment. The suggested check is part of
extract_min_max().

2 years agoAdjust code after adding an extra argument to community_ext_add
claudio [Wed, 25 May 2022 16:56:04 +0000 (16:56 +0000)]
Adjust code after adding an extra argument to community_ext_add

2 years agoPrint ASnumbers in asplain format and stop using the old asdot format.
claudio [Wed, 25 May 2022 16:21:11 +0000 (16:21 +0000)]
Print ASnumbers in asplain format and stop using the old asdot format.
While there clean up some draft comments with their RFC number.
The detection for 4-byte ASPATH attributes is a bit sloppy but since
all resonable BGP versions use 4-byte ASnumbers now we default to them
unless we know it is a 2-byte encoding.
Kill it with fire. deraadt@ & job@ OK sthen@

2 years agoFix non-transitive extended community handling.
claudio [Wed, 25 May 2022 16:03:34 +0000 (16:03 +0000)]
Fix non-transitive extended community handling.
First of all the detection logic was totally wrong. Then filter out
non-transitive extended communities when received from an ebgp peer.
Also cleanup the type handling of ext-communities. Mainly to not have
to handle the transitive vs non-transitive versions the type is masked
with EXT_COMMUNITY_VALUE before doing the switch case for the various
types.
With this my test using ext-communities works.
OK tb@

2 years agoAdd RFC 9234 "BGP Role" support
job [Wed, 25 May 2022 14:26:27 +0000 (14:26 +0000)]
Add RFC 9234 "BGP Role" support

With and OK claudio@

2 years agodrm/dp/mst: fix a possible memory leak in fetch_monitor_name()
jsg [Wed, 25 May 2022 12:37:23 +0000 (12:37 +0000)]
drm/dp/mst: fix a possible memory leak in fetch_monitor_name()

From Hangyu Hua
deec86168170d085d4f91445c1f72a900ed02372 in linux 5.15.y/5.15.42
6e03b13cc7d9427c2c77feed1549191015615202 in mainline linux

2 years agodrm/i915/dmc: Add MMIO range restrictions
jsg [Wed, 25 May 2022 12:33:48 +0000 (12:33 +0000)]
drm/i915/dmc: Add MMIO range restrictions

From Anusha Srivatsa
aaf0f01d074d6fd39ec1b01477f69cd688bf6c9d in linux 5.15.y/5.15.42
54395a33718af1c04b5098203335b25382291a16 in mainline linux

2 years agodrm/amd: Don't reset dGPUs if the system is going to s2idle
jsg [Wed, 25 May 2022 12:29:12 +0000 (12:29 +0000)]
drm/amd: Don't reset dGPUs if the system is going to s2idle

From Mario Limonciello
9d3ec4e5bf032f53137e11075846cec9c474ce4b in linux 5.15.y/5.15.42
7123d39dc24dcd21ff23d75f46f926b15269b9da in mainline linux