openbsd
2 months agosync
deraadt [Fri, 16 Aug 2024 16:57:02 +0000 (16:57 +0000)]
sync

2 months agoAtomically modify `nthreads' and move proc_free() out of KERNEL_LOCK().
mpi [Fri, 16 Aug 2024 16:19:03 +0000 (16:19 +0000)]
Atomically modify `nthreads' and move proc_free() out of KERNEL_LOCK().

ok jca@

2 months agoRemove reference to telnet(1).
florian [Fri, 16 Aug 2024 16:11:06 +0000 (16:11 +0000)]
Remove reference to telnet(1).

telnet(1) doesn't have anything to do with login(1), maybe telnetd(8)
did, but that was taken behind the barn nearly 20 years ago.

Earlier version OK miod
Input dtucker
OK jmc, sthen, deraadt

2 months agotelnet(1) is not a good example for logging in over the network.
florian [Fri, 16 Aug 2024 16:10:27 +0000 (16:10 +0000)]
telnet(1) is not a good example for logging in over the network.

OK jmc, sthen, deraadt

2 months agoAdd pledge & unveil.
florian [Fri, 16 Aug 2024 16:00:30 +0000 (16:00 +0000)]
Add pledge & unveil.

The rpc library needs read access to the rpc database in
/etc/rpc. Other than that rpcinfo only uses AF_INET sockets.

With -b, rpcinfo(8) uses gethostbyaddr(3) to report hosts that
responded, so add "dns" pledge as well.

OK bluhm, miod

2 months agowhitespace
deraadt [Fri, 16 Aug 2024 15:27:11 +0000 (15:27 +0000)]
whitespace

2 months agovio(4): Don't set IPv4 checksum OK flag for rx packets.
jan [Fri, 16 Aug 2024 13:02:44 +0000 (13:02 +0000)]
vio(4): Don't set IPv4 checksum OK flag for rx packets.

The virtio specification just address TCP/UDP checksum offloading.
Thus, we have to check the IPv4 checksum in our stack.

ok sf@

2 months agoFix bounds checking in wsmux_getmux().
miod [Fri, 16 Aug 2024 12:22:17 +0000 (12:22 +0000)]
Fix bounds checking in wsmux_getmux().

2 months agoSet CONFIG_AMD_PMC. We don't have the corresponding driver just yet, but
kettenis [Fri, 16 Aug 2024 10:49:57 +0000 (10:49 +0000)]
Set CONFIG_AMD_PMC.  We don't have the corresponding driver just yet, but
it seems that Linux is just overcautious in disabling S0 suspend when the
driver isn't included in the kernel config.  And we plan to implement the
driver soon anyway.

ok jsg@

2 months agoHook up a few more bits of suspend/resume power management code. This
kettenis [Fri, 16 Aug 2024 10:46:46 +0000 (10:46 +0000)]
Hook up a few more bits of suspend/resume power management code.  This
fixes S3 suspend/resume on the Lenovo ThinCentre M715q with:

  amdgpu0: RAVEN GC 9.1.0 8 CU rev 0x01

and also fixes S0 suspend/resume on various laptops with AMD graphics
provided we disable a few checks (which will be done in a separate
commit).

ok jsg@

2 months agodrm/amd: Stop evicting resources on APUs in suspend
kettenis [Fri, 16 Aug 2024 10:26:20 +0000 (10:26 +0000)]
drm/amd: Stop evicting resources on APUs in suspend

From Mario Limonciello
3a9626c816db901def438dc2513622e281186d39 in mainline linux

2 months agoMake sure that the uptime field is always updated. Previously it was
yasuoka [Fri, 16 Aug 2024 09:54:21 +0000 (09:54 +0000)]
Make sure that the uptime field is always updated.  Previously it was
used before initialized when the database has a session.

2 months agoFree memory as much as possible. Also, fix a use-after-free when exiting.
yasuoka [Fri, 16 Aug 2024 09:52:16 +0000 (09:52 +0000)]
Free memory as much as possible.  Also, fix a use-after-free when exiting.

2 months agoSend a reply to the control client when DAE is timed out instead of
yasuoka [Fri, 16 Aug 2024 09:50:09 +0000 (09:50 +0000)]
Send a reply to the control client when DAE is timed out instead of
silence.  Also, fix a broken error string.

2 months agoDelete req_modified. Which is not used.
yasuoka [Fri, 16 Aug 2024 09:45:52 +0000 (09:45 +0000)]
Delete req_modified.  Which is not used.

2 months agoIntroduce PR_MPSYSCTL flag to mark mp-safe (*pr_sysctl)() handlers and
mvs [Fri, 16 Aug 2024 09:20:34 +0000 (09:20 +0000)]
Introduce PR_MPSYSCTL flag to mark mp-safe (*pr_sysctl)() handlers and
unlock both divert_sysctl() and divert6_sysctl(). Unlock them together,
because they are identical and pretty simple:

- DIVERTCTL_RECVSPACE and DIVERTCTL_SENDSPACE - atomically accessed
  integers;
- DIVERTCTL_STATS - per-CPU counters;

ok bluhm

2 months agoadd 7.7 syspatch pubkey
robert [Fri, 16 Aug 2024 06:42:21 +0000 (06:42 +0000)]
add 7.7 syspatch pubkey

2 months agodelete disabled ACPI-related code in here, this power management is
deraadt [Fri, 16 Aug 2024 04:14:27 +0000 (04:14 +0000)]
delete disabled ACPI-related code in here, this power management is
done at a different level, and nothing needs to be done here
ok kettenis

2 months agoAlign more register addresses and data structures with ath12k.
patrick [Fri, 16 Aug 2024 00:26:54 +0000 (00:26 +0000)]
Align more register addresses and  data structures with ath12k.

2 months agoFurther minor cleanup for improved readability, with the major change that
patrick [Thu, 15 Aug 2024 23:23:06 +0000 (23:23 +0000)]
Further minor cleanup for improved readability, with the major change that
FW now seems to come up after providing regdb parsed out of the board file.

2 months agoInitial patchset on top of the qwx(4) to adjust for ath12k. Still not
patrick [Thu, 15 Aug 2024 22:01:37 +0000 (22:01 +0000)]
Initial patchset on top of the qwx(4) to adjust for ath12k.  Still not
working yet, but it's better to continue polishing this in-tree.

2 months agowhitespace
deraadt [Thu, 15 Aug 2024 17:30:40 +0000 (17:30 +0000)]
whitespace

2 months agoUpon resume, restore the saved state. Newer Intel xHCI controller (e.g.
kettenis [Thu, 15 Aug 2024 17:17:05 +0000 (17:17 +0000)]
Upon resume, restore the saved state.  Newer Intel xHCI controller (e.g.
those on Meteor Lake) need this, otherwise the ports are dead after
resume.

ok mglocker@, deraadt@

2 months agosync
deraadt [Thu, 15 Aug 2024 16:55:06 +0000 (16:55 +0000)]
sync

2 months agosync
deraadt [Thu, 15 Aug 2024 14:43:28 +0000 (14:43 +0000)]
sync

2 months agoRegen some OK files since the bgpctl rib header changed.
claudio [Thu, 15 Aug 2024 13:26:16 +0000 (13:26 +0000)]
Regen some OK files since the bgpctl rib header changed.
Friendly reminder by anton@

2 months agoadd BIOCSETFNR, which is like BIOCSETF but doesnt reset the buffer or stats.
dlg [Thu, 15 Aug 2024 12:20:20 +0000 (12:20 +0000)]
add BIOCSETFNR, which is like BIOCSETF but doesnt reset the buffer or stats.

from Matthew Luckie <mjl@luckie.org.nz> via tech@
deraadt@ likes it.

2 months agoEnsure synchronization jobs are stopped when the timeout is reached
job [Thu, 15 Aug 2024 11:30:43 +0000 (11:30 +0000)]
Ensure synchronization jobs are stopped when the timeout is reached

OK tb@ claudio@

2 months agosync
patrick [Thu, 15 Aug 2024 11:26:03 +0000 (11:26 +0000)]
sync

2 months agoAdd Qualcomm WCN7850
patrick [Thu, 15 Aug 2024 11:25:37 +0000 (11:25 +0000)]
Add Qualcomm WCN7850

2 months agoadd 77-fw pubkey
sthen [Thu, 15 Aug 2024 10:25:25 +0000 (10:25 +0000)]
add 77-fw pubkey

2 months agobsd.port.mk: typo dbp -> dpb
tb [Thu, 15 Aug 2024 09:46:39 +0000 (09:46 +0000)]
bsd.port.mk: typo dbp -> dpb

2 months agoDocument DWZ and fix a few mandoc lints
tb [Thu, 15 Aug 2024 09:29:12 +0000 (09:29 +0000)]
Document DWZ and fix a few mandoc lints

from espie

2 months agoCall repo_check_timeout() before colleting the POLLOUT fds. Since
claudio [Thu, 15 Aug 2024 09:22:12 +0000 (09:22 +0000)]
Call repo_check_timeout() before colleting the POLLOUT fds. Since
repo_abort() called by repo_check_timeout() will add messages to
be sent out.
OK tb@

2 months agoAdd filtered support to bgplgd.
claudio [Thu, 15 Aug 2024 09:13:13 +0000 (09:13 +0000)]
Add filtered support to bgplgd.
OK tb@

2 months agoAccept empty lines for authopts to fix the parser to accept the old
yasuoka [Thu, 15 Aug 2024 07:24:28 +0000 (07:24 +0000)]
Accept empty lines for authopts to fix the parser to accept the old
syntax.  It was broken by parse.y 1.18.  Found by Mike at mgm51.com.

2 months agounifdef for S_I{FLNK,FIFO,FSOCK}. For the operations where we use
guenther [Thu, 15 Aug 2024 06:27:24 +0000 (06:27 +0000)]
unifdef for S_I{FLNK,FIFO,FSOCK}.  For the operations where we use
access() (-r, -w, -x, -e) do them without requiring stat() to succeed first.

ok tb@ deraadt@

2 months agodrm/radeon: Remove __counted_by from StateArray.states[]
jsg [Thu, 15 Aug 2024 03:24:29 +0000 (03:24 +0000)]
drm/radeon: Remove __counted_by from StateArray.states[]

From Bill Wendling
ea12dbf570ef1cbbf857dfa80fbdd66cc0e4612b in linux-6.6.y/6.6.46
2bac084468847cfe5bbc7166082b2a208514bb1c in mainline linux

2 months agodrm/dp_mst: Skip CSN if topology probing is not done yet
jsg [Thu, 15 Aug 2024 03:22:41 +0000 (03:22 +0000)]
drm/dp_mst: Skip CSN if topology probing is not done yet

From Wayne Lin
28c060cd370d2718345452f4182cba115b7367e8 in linux-6.6.y/6.6.46
ddf983488c3e8d30d5c2e2b315ae7d9cd87096ed in mainline linux

2 months agodrm/client: fix null pointer dereference in drm_client_modeset_probe
jsg [Thu, 15 Aug 2024 03:20:40 +0000 (03:20 +0000)]
drm/client: fix null pointer dereference in drm_client_modeset_probe

From Ma Ke
d64fc94f7bb24fc2be0d6bd5df8df926da461a6d in linux-6.6.y/6.6.46
113fd6372a5bb3689aba8ef5b8a265ed1529a78f in mainline linux

2 months agodrm/i915/gem: Adjust vma offset for framebuffer mmap offset
jsg [Thu, 15 Aug 2024 03:18:56 +0000 (03:18 +0000)]
drm/i915/gem: Adjust vma offset for framebuffer mmap offset

From Andi Shyti
d73de3c6447644c65ed0e9a368328713dc28fb18 in linux-6.6.y/6.6.46
1ac5167b3a90c9820daa64cc65e319b2d958d686 in mainline linux

2 months agodrm/amdgpu: Forward soft recovery errors to userspace
jsg [Thu, 15 Aug 2024 03:15:06 +0000 (03:15 +0000)]
drm/amdgpu: Forward soft recovery errors to userspace

From Joshua Ashton
0da0b06165d83a8ecbb6582d9d5a135f9d38a52a in linux-6.6.y/6.6.46
829798c789f567ef6ba4b084c15b7b5f3bd98d51 in mainline linux

2 months agodrm/amd/display: Skip Recompute DSC Params if no Stream on Link
jsg [Thu, 15 Aug 2024 03:12:41 +0000 (03:12 +0000)]
drm/amd/display: Skip Recompute DSC Params if no Stream on Link

From Fangzhi Zuo
718d83f66fb07b2cab89a1fc984613a00e3db18f in linux-6.6.y/6.6.46
50e376f1fe3bf571d0645ddf48ad37eb58323919 in mainline linux

2 months agodrm/i915/gem: Fix Virtual Memory mapping boundaries calculation
jsg [Thu, 15 Aug 2024 03:10:37 +0000 (03:10 +0000)]
drm/i915/gem: Fix Virtual Memory mapping boundaries calculation

From Andi Shyti
4b09513ce93b3dcb590baaaff2ce96f2d098312d in linux-6.6.y/6.6.46
8bdd9ef7e9b1b2a73e394712b72b22055e0e26c3 in mainline linux

2 months agodrm/amd/display: Add null checker before passing variables
jsg [Thu, 15 Aug 2024 03:08:00 +0000 (03:08 +0000)]
drm/amd/display: Add null checker before passing variables

From Alex Hung
4cc2a94d96caeb3c975acdae7351c2f997c32175 in linux-6.6.y/6.6.46
8092aa3ab8f7b737a34b71f91492c676a843043a in mainline linux

2 months agodrm/amd/pm: Fix the null pointer dereference for vega10_hwmgr
jsg [Thu, 15 Aug 2024 03:06:09 +0000 (03:06 +0000)]
drm/amd/pm: Fix the null pointer dereference for vega10_hwmgr

From Bob Zhou
2e538944996d0dd497faf8ee81f8bfcd3aca7d80 in linux-6.6.y/6.6.46
50151b7f1c79a09117837eb95b76c2de76841dab in mainline linux

2 months agodrm/amdgpu: Add lock around VF RLCG interface
jsg [Thu, 15 Aug 2024 03:04:18 +0000 (03:04 +0000)]
drm/amdgpu: Add lock around VF RLCG interface

From Victor Skvortsov
1adb5ebe205e96af77a93512e2d5b8c437548787 in linux-6.6.y/6.6.46
e864180ee49b4d30e640fd1e1d852b86411420c9 in mainline linux

2 months agodrm/admgpu: fix dereferencing null pointer context
jsg [Thu, 15 Aug 2024 03:01:36 +0000 (03:01 +0000)]
drm/admgpu: fix dereferencing null pointer context

From Jesse Zhang
641dac64178ccdb9e45c92b67120316896294d05 in linux-6.6.y/6.6.46
030ffd4d43b433bc6671d9ec34fc12c59220b95d in mainline linux

2 months agodrm/amdgpu/pm: Fix the null pointer dereference in apply_state_adjust_rules
jsg [Thu, 15 Aug 2024 02:59:50 +0000 (02:59 +0000)]
drm/amdgpu/pm: Fix the null pointer dereference in apply_state_adjust_rules

From Ma Jun
3a01bf2ca9f860fdc88c358567b8fa3033efcf30 in linux-6.6.y/6.6.46
d19fb10085a49b77578314f69fff21562f7cd054 in mainline linux

2 months agodrm/amdgpu: Fix the null pointer dereference to ras_manager
jsg [Thu, 15 Aug 2024 02:58:13 +0000 (02:58 +0000)]
drm/amdgpu: Fix the null pointer dereference to ras_manager

From Ma Jun
b89616333979114bb0da5fa40fb6e4a2f5294ca2 in linux-6.6.y/6.6.46
4c11d30c95576937c6c35e6f29884761f2dddb43 in mainline linux

2 months agodrm/amdgpu/pm: Fix the null pointer dereference for smu7
jsg [Thu, 15 Aug 2024 02:56:22 +0000 (02:56 +0000)]
drm/amdgpu/pm: Fix the null pointer dereference for smu7

From Ma Jun
09544cd95c688d3041328a4253bd7514972399bb in linux-6.6.y/6.6.46
c02c1960c93eede587576625a1221205a68a904f in mainline linux

2 months agodrm/amdgpu/pm: Fix the param type of set_power_profile_mode
jsg [Thu, 15 Aug 2024 02:53:57 +0000 (02:53 +0000)]
drm/amdgpu/pm: Fix the param type of set_power_profile_mode

From Ma Jun
837ab17ceef90a85ddfc918935ed1f19ff60d09b in linux-6.6.y/6.6.46
f683f24093dd94a831085fe0ea8e9dc4c6c1a2d1 in mainline linux

2 months agodrm/amdgpu: fix potential resource leak warning
jsg [Thu, 15 Aug 2024 02:51:35 +0000 (02:51 +0000)]
drm/amdgpu: fix potential resource leak warning

From Tim Huang
bc93cfde69b7c786fcdc70463e153fdf633caff9 in linux-6.6.y/6.6.46
22a5daaec0660dd19740c4c6608b78f38760d1e6 in mainline linux

2 months agodrm/amd/display: Add delay to improve LTTPR UHBR interop
jsg [Thu, 15 Aug 2024 02:49:48 +0000 (02:49 +0000)]
drm/amd/display: Add delay to improve LTTPR UHBR interop

From Michael Strauss
479ccc2132171f7e711f8154408ec6106f6e1df3 in linux-6.6.y/6.6.46
10839ee6a977ed1f7d0f4deb29f2d7e5d1f2a9dd in mainline linux

2 months agot_recvmmsg and t_sendmmsg were enabled in 2022
guenther [Thu, 15 Aug 2024 01:32:59 +0000 (01:32 +0000)]
t_recvmmsg and t_sendmmsg were enabled in 2022

2 months agoSupport describing ABI changes for static libraries too.
guenther [Thu, 15 Aug 2024 01:25:13 +0000 (01:25 +0000)]
Support describing ABI changes for static libraries too.
Try the -S option

2 months agoadapt to EVP_PKEY conversion
djm [Thu, 15 Aug 2024 00:52:23 +0000 (00:52 +0000)]
adapt to EVP_PKEY conversion

2 months agoConvert RSA and ECDSA key to the libcrypto EVP_PKEY API. DSA remains
djm [Thu, 15 Aug 2024 00:51:51 +0000 (00:51 +0000)]
Convert RSA and ECDSA key to the libcrypto EVP_PKEY API. DSA remains
unconverted as it will be removed within six months.

Based on patches originally from Dmitry Belyavskiy, but significantly
reworked based on feedback from Bob Beck, Joel Sing and especially
Theo Buehler (apologies to anyone I've missed).

ok tb@

2 months ago'newercnt' no longer does anything that 'refcnt' doesn't; eliminate
guenther [Thu, 15 Aug 2024 00:47:44 +0000 (00:47 +0000)]
'newercnt' no longer does anything that 'refcnt' doesn't; eliminate
the former in favor of the latter.

ok millert@

2 months agoAdd 'bgpctl show rib filtered' support.
claudio [Wed, 14 Aug 2024 19:10:51 +0000 (19:10 +0000)]
Add 'bgpctl show rib filtered' support.
OK tb@

2 months agoIntroduce 'rde rib Loc-RIB include filtered' a feature that includes
claudio [Wed, 14 Aug 2024 19:09:51 +0000 (19:09 +0000)]
Introduce 'rde rib Loc-RIB include filtered' a feature that includes
filtered prefixes in the Loc-RIB

This includes filtered prefixes into the Loc-RIB but they are marked
ineligible so nothing will select them but it is possible to show them
in bgpctl. So 'bppctl show rib filtered' will return all prefixes filtered
out by the input filters.

OK tb@

2 months agoImplement bounce buffering for AMD SEV in amd64 bus dma.
bluhm [Wed, 14 Aug 2024 18:31:33 +0000 (18:31 +0000)]
Implement bounce buffering for AMD SEV in amd64 bus dma.

When running as SEV guest, as indicated by variable cpu_sev_guestmode,
allocate additional pages for each segment on dma map creation.
These pages are mapped with the PMAP_NOCRYPT attribute, i.e. the
crypt bit is not set in the PTE.  Thus, these pages are shared with
the hypervisor.
When the map is loaded with actual pages, the address in the
descriptor is replaced by the corresponding bounce buffer.  Using
bus_dmamap_sync(), data is copied from the encrypted pages used by
guest drivers to the unencrypted bounce buffers shared with the
hypervisor, and vice versa.
If the kernel is not running in SEV guest mode, which means as
normal host or non-SEV guest, no bounce buffers are used.

from hshoexer@; based on ancient code of mickey@; OK kettenis@

2 months agoPush kernel lock down to net_sysctl().
mvs [Wed, 14 Aug 2024 17:52:47 +0000 (17:52 +0000)]
Push kernel lock down to net_sysctl().

All except PF_MPLS paths are mp-safe:
- net_link_sysctl() and following net_ifiq_sysctl() only return
  EOPNOTSUPP;
- uipc_sysctl() - mp-safe atomic access to integers;
- bpf_sysctl() - mp-safe atomic access to integers;
- pflow_sysctl() - returns statistics from per-CPU counters;
- pipex_sysctl() - mp-safe atomic access to integer;

Push kernel lock down to mpls_sysctl(). sysctl_int_bounded() do copying
with local variable, so context switch is safe. No need to wire memory
or take `sysctl_lock' rwlock(9).

Keep protocols locked as they was include pages wiring. Copying will not
sleep - no network slowdown while doing it with net lock held.

ok bluhm

2 months agoresdebug and no_tld_query are unused
florian [Wed, 14 Aug 2024 17:38:57 +0000 (17:38 +0000)]
resdebug and no_tld_query are unused

2 months agosortlist is unused
florian [Wed, 14 Aug 2024 17:37:40 +0000 (17:37 +0000)]
sortlist is unused

2 months agolwserver is unused, whatever that is / was.
florian [Wed, 14 Aug 2024 17:36:48 +0000 (17:36 +0000)]
lwserver is unused, whatever that is / was.

2 months agoReorder calloc arguments
tobias [Wed, 14 Aug 2024 15:42:18 +0000 (15:42 +0000)]
Reorder calloc arguments

The first argument should be the amount, the second argument should be the
element size. Fixing this also silences some gcc compiler warnings for
portable.

Spotted with Benny Baumann (BenBE at geshi dot org).

ok djm@

2 months agoExtend sshbuf validation
tobias [Wed, 14 Aug 2024 15:40:30 +0000 (15:40 +0000)]
Extend sshbuf validation

Multiple sshbuf structs can be linked through a parent/child relationship.
Make sure that a single sshbuf cannot be its own parent. If this would ever
happen, it would result in reference counting issues.

This is a cheap way of testing this with very little overhead. It does not
detect A->B->A linkages though for performance reason and the fact that it
takes a programming error for this to occur anyway.

Authored with Benny Baumann (BenBE at geshi dot org).

ok djm@

2 months agoUse freezero for better readability
tobias [Wed, 14 Aug 2024 15:37:11 +0000 (15:37 +0000)]
Use freezero for better readability

It has the same meaning as the current pair of calling explicit_bzero
and free. Spotted with Benny Baumann (BenBE at geshi dot org).

ok djm@

2 months agoFix typo in comment
tobias [Wed, 14 Aug 2024 15:35:23 +0000 (15:35 +0000)]
Fix typo in comment

Spotted with Benny Baumann (BenBE at geshi dot org).

ok djm@

2 months agomention apple machines needing activation after erase
jsg [Wed, 14 Aug 2024 15:34:39 +0000 (15:34 +0000)]
mention apple machines needing activation after erase
ok patrick@ kettenis@ krw@

2 months agoIntroduce qwz(4), a work-in-progress port of the Linux ath12k driver.
patrick [Wed, 14 Aug 2024 14:40:45 +0000 (14:40 +0000)]
Introduce qwz(4), a work-in-progress port of the Linux ath12k driver.

This driver is not working yet, it's a copy of qwx(4) which bit-by-bit will be
adjusted to work on the newer generation of chips.  Even though this is only a
minor bump over the previous generation, the changes are large enough that
bringup, debugging and long-term maintenance would suffer trying to squash them
into a single driver.  This can be reconsidered once we have reached a stable
state.

2 months agoMake sysctl_int() and sysctl_int_lower() mp-safe and unlock KERN_HOSTID.
mvs [Wed, 14 Aug 2024 13:54:08 +0000 (13:54 +0000)]
Make sysctl_int() and sysctl_int_lower() mp-safe and unlock KERN_HOSTID.

The only difference between sysctl_int() and sysctl_int_bounded()
is the range check, so sysctl_int() is just sysctl_int_bounded(...,
INT_MIN, INT_MAX). sysctl_int() is not the fast path, so this useless
check is not significant.

Mp-safe sysctl_int() is meaningless for sysctl_int_lower(), so rework it
in the sysctl_int_bounded() style. This time all affected paths are
kernel locked, but this doesn't make sysctl_int_lower() worse.

Change `hostid' type to the type of int. It only stored but never used
within kernel, userland accesses it through sysctl_int(). Nothing
changes, but variable becomes consistent with sysctl_int().

ok bluhm

2 months agoIn a qcspmi_cmd_read() error case, the register is only returning the error
mglocker [Wed, 14 Aug 2024 10:54:58 +0000 (10:54 +0000)]
In a qcspmi_cmd_read() error case, the register is only returning the error
bit, not SPMI_STATUS_DONE.  Therefore, catch the error at the right place,
and print the specific error type.

ok patrick@

2 months agominiroot now works with USB Type-A ports on Apple machines
jsg [Wed, 14 Aug 2024 10:50:20 +0000 (10:50 +0000)]
miniroot now works with USB Type-A ports on Apple machines
discussed with kettenis@ and confirmed on M1 Mac mini

2 months agoMessages from modules were leaked. Call imsg_free() for them.
yasuoka [Wed, 14 Aug 2024 07:06:50 +0000 (07:06 +0000)]
Messages from modules were leaked.  Call imsg_free() for them.

2 months agoDon't abort the query when it is requesting to the next module.
yasuoka [Wed, 14 Aug 2024 07:04:54 +0000 (07:04 +0000)]
Don't abort the query when it is requesting to the next module.

2 months agotimingsafe_bcmp() is better than timingsafe_memcmp() for the purpose.
yasuoka [Wed, 14 Aug 2024 04:50:31 +0000 (04:50 +0000)]
timingsafe_bcmp() is better than timingsafe_memcmp() for the purpose.

2 months agoInitialize dae objects properly.
yasuoka [Wed, 14 Aug 2024 04:47:08 +0000 (04:47 +0000)]
Initialize dae objects properly.

2 months agoDon't abort the query when a duplicated query is received. Also tweak
yasuoka [Wed, 14 Aug 2024 04:44:07 +0000 (04:44 +0000)]
Don't abort the query when a duplicated query is received.  Also tweak
the log message.

2 months agoBe more aggressive about disabling interrupts in both DVACT_QUIESCE and
deraadt [Tue, 13 Aug 2024 22:32:58 +0000 (22:32 +0000)]
Be more aggressive about disabling interrupts in both DVACT_QUIESCE and
DVACT_SUSPEND, because we are seeing false interrupts during S0 resume.
Other problems remain, and ratchov has some clues he'll dig into in the
coming weeks.  For now, this is a good enough improvement.
ok ratchov

2 months agouse ACPI _WAK upon resume. Such a huge oversight it is surprising that
deraadt [Tue, 13 Aug 2024 22:31:16 +0000 (22:31 +0000)]
use ACPI _WAK upon resume.  Such a huge oversight it is surprising that
we've never noticed it before, maybe systems which depend on _WAK are rare.
Still, this may improve S3 resume on some rare machines.
ok kettenis

2 months agoFor AMD SEV use correct command mask in ccp(4) driver.
bluhm [Tue, 13 Aug 2024 20:48:00 +0000 (20:48 +0000)]
For AMD SEV use correct command mask in ccp(4) driver.

According to AMD SEV API specification, the mask for command ID is
supposed to be of length 10 (Bits [25:16]), rather than length 6.
This ensures that all commands are properly processed by the PSP.

from Aaron Debebe; OK hshoexer@

2 months agoFix a bug in .Ql handling that has been present since the beginning (2017).
schwarze [Tue, 13 Aug 2024 12:43:55 +0000 (12:43 +0000)]
Fix a bug in .Ql handling that has been present since the beginning (2017).

Since the .Ql macro action uses an output prefix of "'`" and an output
suffix of "`'", md_post_raw() would decrement the code_blocks state variable
even though md_pre_raw() had earlier neglected to increment it, hence
leaving the variable in an invalid negative state.  That in turn could
result in corrupt output in a variety of ways.

Fix this by checking in md_pre_raw() whether the prefix *contains* a
backtick rather than only checking whether it *starts* with a backtick.
For consistency, apply the same change to md_post_raw() even though
there was no bug in that function: all *suffixes* containing a backtick
actually contain it in the leading position.

Thanks to job@ for reporting this bug.  He noticed a particularly nasty
kind of output corruption: having .Ql in an input file would result
in ASCII_NBRSP (0x31) sneaking through into the output stream if later,
unrelated parts of the same input file directly or indirectly used
the \~ escape sequence, for example by using the .Ex macro.

2 months agoSync full virtqueue on device reset
sf [Tue, 13 Aug 2024 08:47:28 +0000 (08:47 +0000)]
Sync full virtqueue on device reset

We initialize the whole virtqueue and must make sure that the device
sees this even for the areas that are normally only written by the
device. Otherwise there may be an assertion fail during ifconfig up, as
found by bluhm@ with hshoexer@'s bounce buffer diff.

OK bluhm@

2 months agozap extra word;
jmc [Tue, 13 Aug 2024 05:52:09 +0000 (05:52 +0000)]
zap extra word;

2 months agodrm/i915/pxp/mtl: Update pxp-firmware packet size
jsg [Tue, 13 Aug 2024 05:13:34 +0000 (05:13 +0000)]
drm/i915/pxp/mtl: Update pxp-firmware packet size

From Alan Previn
c14d446e25fe00a9fd29d317b07bd221fd6f49db in mainline linux

2 months agodrm/i915/mtl: Wake GT before sending H2G message
jsg [Tue, 13 Aug 2024 04:04:53 +0000 (04:04 +0000)]
drm/i915/mtl: Wake GT before sending H2G message

From Vinay Belgaumkar
6d46d09a0d7dd412c5b76f74f89fe4448ba2117e in mainline linux

2 months agodrm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3
jsg [Tue, 13 Aug 2024 03:58:13 +0000 (03:58 +0000)]
drm/i915/mtl: Don't set PIPE_CONTROL_FLUSH_L3

From Vinay Belgaumkar
5fde104ea8587c547732a06d9d6473f6e7e4ac1c in mainline linux

2 months agodrm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()
jsg [Tue, 13 Aug 2024 02:19:41 +0000 (02:19 +0000)]
drm/i915: Fix possible int overflow in skl_ddi_calculate_wrpll()

From Nikita Zhandarovich
6c0473c9ac502df8d580c15f20188efe708e8394 in linux-6.6.y/6.6.45
5b511572660190db1dc8ba412efd0be0d3781ab6 in mainline linux

2 months agodrm/i915/hdcp: Fix HDCP2_STREAM_STATUS macro
jsg [Tue, 13 Aug 2024 02:16:08 +0000 (02:16 +0000)]
drm/i915/hdcp: Fix HDCP2_STREAM_STATUS macro

From Suraj Kandpal
9541f99b2651adaeb1425474096999e689a60497 in linux-6.6.y/6.6.45
555069117390a5d581863bc797fb546bb4417c31 in mainline linux

2 months agoi915/perf: Remove code to update PWR_CLK_STATE for gen12
jsg [Tue, 13 Aug 2024 02:14:36 +0000 (02:14 +0000)]
i915/perf: Remove code to update PWR_CLK_STATE for gen12

From Umesh Nerlige Ramappa
582b6c7dd019c49a239db5f721146139130251c4 in linux-6.6.y/6.6.45
4bc14b9cfaa2149d41baef2f2620e9f82d9847d7 in mainline linux

2 months agodrm/i915: Prevent potential null-ptr-deref in engine_init_common
jsg [Tue, 13 Aug 2024 00:58:47 +0000 (00:58 +0000)]
drm/i915: Prevent potential null-ptr-deref in engine_init_common

From Nirmoy Das
f1cdb599ce0ef909343d6c8e7d372defbaa382b9 in mainline linux

2 months agosync
jsg [Tue, 13 Aug 2024 00:41:22 +0000 (00:41 +0000)]
sync

2 months agodrm/i915/mtl: Remove the 'force_probe' requirement for Meteor Lake
jsg [Tue, 13 Aug 2024 00:39:26 +0000 (00:39 +0000)]
drm/i915/mtl: Remove the 'force_probe' requirement for Meteor Lake

From Radhakrishna Sripada
213c43676beb5f5a63cb27a0c8e8e71035b08445 in mainline linux

2 months agoforce primary and console on Meteor Lake
jsg [Tue, 13 Aug 2024 00:36:32 +0000 (00:36 +0000)]
force primary and console on Meteor Lake

The GOP framebuffer doesn't match the PCI BAR ranges efifb tests.
discussed with kettenis@

2 months agodrm/i915: Annotate more of the BIOS fb takeover failure paths
jsg [Tue, 13 Aug 2024 00:29:51 +0000 (00:29 +0000)]
drm/i915: Annotate more of the BIOS fb takeover failure paths

From Ville Syrjala
074146f4578388b1b7f7832368d1581fceb1441e in mainline linux

2 months agodrm/i915: Try to relocate the BIOS fb to the start of ggtt
jsg [Tue, 13 Aug 2024 00:28:09 +0000 (00:28 +0000)]
drm/i915: Try to relocate the BIOS fb to the start of ggtt

From Ville Syrjala
a8153627520a2d468680bb7686fd404c222b13ca in mainline linux

2 months agodrm/i915: Tweak BIOS fb reuse check
jsg [Tue, 13 Aug 2024 00:25:13 +0000 (00:25 +0000)]
drm/i915: Tweak BIOS fb reuse check

From Ville Syrjala
ea5e150ac2cf88f586299c06244d5a4d473c041e in mainline linux

2 months agodrm/i915/fbdev: Fix smem_start for LMEMBAR stolen objects
jsg [Tue, 13 Aug 2024 00:23:25 +0000 (00:23 +0000)]
drm/i915/fbdev: Fix smem_start for LMEMBAR stolen objects

From Ville Syrjala
f1ee98cff3d86271491b08315fcdfa4c3f097e1e in mainline linux