kettenis [Sat, 10 May 2014 18:41:55 +0000 (18:41 +0000)]
Sidestep format string issue by sanitizing a bit of debug code.
ok deraadt@
deraadt [Sat, 10 May 2014 18:15:31 +0000 (18:15 +0000)]
please, if there is any chance you've ever encountered the same command
during install time, be more careful here.
otto [Sat, 10 May 2014 18:14:55 +0000 (18:14 +0000)]
fix MALLOC_STATS code that was broken in rev 1.159, not compiled in by default
chris [Sat, 10 May 2014 17:48:09 +0000 (17:48 +0000)]
Allow nginx to chroot to a directory other than /var/www
ok henning@
rpe [Sat, 10 May 2014 17:25:21 +0000 (17:25 +0000)]
Fix v6_defroute() for automatic installation.
OK krw@ halex@
deraadt [Sat, 10 May 2014 16:56:23 +0000 (16:56 +0000)]
bring things syscall_mi.h needs into scope earlier
deraadt [Sat, 10 May 2014 16:48:36 +0000 (16:48 +0000)]
bring things syscall_mi.h needs into scope earlier
ok guenther
schwarze [Sat, 10 May 2014 16:45:23 +0000 (16:45 +0000)]
Give more(1) its own help file, shorter than the one for less(1).
The helpfile itself was prepared by jmc@, the glue by me.
OK millert@ jmc@
kettenis [Sat, 10 May 2014 12:36:22 +0000 (12:36 +0000)]
Fix formwat string. Cast pointer to long and print it using %lx since %p
prefixes the address with 0x which we want to avoid here.
claudio [Sat, 10 May 2014 12:30:27 +0000 (12:30 +0000)]
Fix a few bad indents
kettenis [Sat, 10 May 2014 12:29:58 +0000 (12:29 +0000)]
A few more straightforward format string fixes.
kettenis [Sat, 10 May 2014 12:20:38 +0000 (12:20 +0000)]
Format string fixes for bus_addr_t and bus_size_t, which are u_long everywhere.
kettenis [Sat, 10 May 2014 12:18:38 +0000 (12:18 +0000)]
Schizo registers are all 64-bit, so use u_int64_t to store them and print them
using %llx/%llb.
kettenis [Sat, 10 May 2014 12:15:19 +0000 (12:15 +0000)]
Format string fixes for printing interrupt vectors.
kettenis [Sat, 10 May 2014 11:49:31 +0000 (11:49 +0000)]
Some straightforward format string fixes. Also, print both the tx and rx
interrupt vector numbers instead of printing rx; pointed out by florian@
claudio [Sat, 10 May 2014 11:30:47 +0000 (11:30 +0000)]
Extend the connection and session FSMs so that connection failure is
handled more gracefully. Losing the TCP connection no longer results
in an unrecoverable stop requiring a restart of iscsid.
claudio [Sat, 10 May 2014 11:28:02 +0000 (11:28 +0000)]
Move the task cleanup from the task fail callback to taskq_cleanup.
This makes the one failure callback a lot simpler.
guenther [Sat, 10 May 2014 05:33:00 +0000 (05:33 +0000)]
Factor out the common ast bits into mi_ast()
ok deraadt@
djm [Sat, 10 May 2014 01:38:10 +0000 (01:38 +0000)]
__bounded => __attribute__((__bounded__
schwarze [Fri, 9 May 2014 23:56:26 +0000 (23:56 +0000)]
Various cleanup in incard():
* get_line() always returns the same non-NULL pointer,
so testing the return value is useless.
* Garbage collect the unused variable *line.
* Check for end-of-buffer before parsing the next word instead of after it.
* Skip strlen() when the length has been measured three lines before anyway.
* Do not initialize local variables over and over again.
feedback and ok pjanzen@
schwarze [Fri, 9 May 2014 23:39:10 +0000 (23:39 +0000)]
Fix a mini-bug reported by pjanzen@:
When entering card names, you can use multiple words (like KING OF SPADES).
If you entered more than one consecutive blank character between words,
the function incard() took that as end-of-string and ignored the rest.
Fix this by dropping duplicate blanks up front, in get_line().
Patch simplified by me, ok pjanzen@.
While here, use beep(3) in an adjacent line instead of manually fiddling
with control characters, suggested by pjanzen@.
miod [Fri, 9 May 2014 22:29:20 +0000 (22:29 +0000)]
Typo in C99 field initializer introduced in r1.3;
reported by Steven Chamberlain
deraadt [Fri, 9 May 2014 22:15:44 +0000 (22:15 +0000)]
wording improvements; David Vasek
jmc [Fri, 9 May 2014 21:53:42 +0000 (21:53 +0000)]
pjanzen pointed out that case is irrelevant, so document it; while here,
zap an old workaround needed to insert a space - it's now useless (was
actually generating a second space);
original diff from pjanzen
jmc [Fri, 9 May 2014 21:51:50 +0000 (21:51 +0000)]
zap the commented out stuff from this file: it mainly pertains to other
systems, and our page is sufficiently far away from upstream to justify it;
ok millert
tedu [Fri, 9 May 2014 21:30:11 +0000 (21:30 +0000)]
stop casting sizeof to int
rpe [Fri, 9 May 2014 21:15:17 +0000 (21:15 +0000)]
Tweak response file example:
- "Server?" -> "HTTP Server?"
- Use more appropriate public ssh key type
OK deraadt@ krw@
sthen [Fri, 9 May 2014 21:03:43 +0000 (21:03 +0000)]
print interface name with queues in "systat q"; ok henning
matthew [Fri, 9 May 2014 20:45:49 +0000 (20:45 +0000)]
Replace Apache v2 license with ISC license.
Thanks to Google for agreeing to offer the code under more agreeable
licensing terms!
miod [Fri, 9 May 2014 20:15:06 +0000 (20:15 +0000)]
format string fixes and removal of -Wno-format for sparc kernels.
miod [Fri, 9 May 2014 20:14:18 +0000 (20:14 +0000)]
Make sure to override PIE_DEFAULT when building a cross-gcc4
miod [Fri, 9 May 2014 18:16:15 +0000 (18:16 +0000)]
Format string fixes and removal of -Wno-format for *ppc kernels.
jmc [Fri, 9 May 2014 17:30:34 +0000 (17:30 +0000)]
move some remnants of more behaviour to the compat section, and use Xr for
refs to more instead of Nm;
sf [Fri, 9 May 2014 14:44:56 +0000 (14:44 +0000)]
add note about qemu bug
krw [Fri, 9 May 2014 13:56:33 +0000 (13:56 +0000)]
Modernize spelling. 'Mimick' -> 'Mimic' in comment.
krw [Fri, 9 May 2014 13:19:34 +0000 (13:19 +0000)]
Fix '-b' option to work with the superblock locations output by newfs
on 4096-byte sector disks. No-op on 512-byte sector disks.
Adhering to the bedrock idea that ffs will *never* use anything but
512-byte block disk addressing (a.k.a. daddr_t), and believing that
the 'fake' bread()/bwrite() functions should always be using 512-btye
block numbers like their kernel big brothers, nuke the computed
dev_bsize and use DEV_BSIZE for conversions to/from byte offsets.
Spotted and various fixes tested by David Vasek.
Still to fix: scanning for superblocks on 4K disks.
ok otto@
andre [Fri, 9 May 2014 11:53:28 +0000 (11:53 +0000)]
Adds a couple tests for relayd parser, specially recent modifications reyk@ did
to the grammar.
ok reyk
andre [Fri, 9 May 2014 11:49:26 +0000 (11:49 +0000)]
Adds $relayd->{dummyrun} and $client->{noclient} flags to relayd tests
framework. These flags can be set from test file which eases performing
dry-runs of relayd long enough to do relayd.conf parsing, thus enabling the
grammar/parser-only tests. While here, fix and improves args-http-mark.pl to a
correct use-case.
ok reyk
mpi [Fri, 9 May 2014 11:01:06 +0000 (11:01 +0000)]
Plug an xfer leak when detaching root hubs.
This leak is similar to the public xfer leak #1 that was affecting
device interrupt pipes except that root hubs are rarely detached.
Note that this xfer is never associated to any TD and is just used
to indicate that some of the HC ports has changed status, so there
is no need to flag it as "done" before completing it.
mpi [Fri, 9 May 2014 09:23:56 +0000 (09:23 +0000)]
We should use the highest possible priority for routes to local addresses.
Requested by claudio@
nicm [Fri, 9 May 2014 09:11:24 +0000 (09:11 +0000)]
Just use char ** for argv like normal people, not char *const *.
guenther [Fri, 9 May 2014 06:38:27 +0000 (06:38 +0000)]
Add a bit more detail about dot notation from the old inet(3) manpage.
ok jmc@
jmc [Fri, 9 May 2014 06:37:38 +0000 (06:37 +0000)]
my previous attempt to fix the renaming of the inet(3) pages was wrong;
this fixes those by referencing the correct page, and cleans up the netintro/
inet entries;
all this on the advice (and ok) of guenther!
markus [Fri, 9 May 2014 06:37:24 +0000 (06:37 +0000)]
get rid of redundant {csa,flow}_{src,dst}id pointers, so we don't need
to update it on rekey (fixes use-after-free); ok mikeb@
markus [Fri, 9 May 2014 06:29:46 +0000 (06:29 +0000)]
replace iked_transform pointer with xform id, since target of pointer
might be freed (e.g. on ike sa rekey); ok mikeb@
deraadt [Fri, 9 May 2014 05:14:17 +0000 (05:14 +0000)]
when demonstrating the correct "double-check" idiom, provide a
reminder that the return value is int...
tedu [Fri, 9 May 2014 03:54:28 +0000 (03:54 +0000)]
stop using B_AGE, it was effectively retired some time ago.
tedu [Fri, 9 May 2014 03:48:58 +0000 (03:48 +0000)]
disable IO_NOCACHE B_NOCACHE conversion until it works.
schwarze [Fri, 9 May 2014 03:13:24 +0000 (03:13 +0000)]
KNF: unify style and reduce indentation in get_line(), no binary change
ok cmp(1)
schwarze [Fri, 9 May 2014 02:47:25 +0000 (02:47 +0000)]
After entering an invalid three-letter card name, one letter card names
stopped working because the third letter remained in the buffer,
incard() skipped the NUL and used the old garbage.
Fix this bug reported by pjanzen@, but in a simpler way than he
suggested, by just clearing any trailing garbage from the buffer.
ok pjanzen@
schwarze [Fri, 9 May 2014 00:03:41 +0000 (00:03 +0000)]
Various cleanup:
1. Style: Don't use variables as format strings.
NetBSD rev. 1.26 (May 23, 2011) joerg@NetBSD via maintainer pjanzen@.
2. Style: Avoid needless pointer arithmetics.
NetBSD rev. 1.27 (Oct 13, 2012) dholland@NetBSD via pjanzen@,
who also applied some KNF to the indentation while here.
3. End curses before printing fatal error messages; from pjanzen@.
schwarze [Thu, 8 May 2014 23:12:40 +0000 (23:12 +0000)]
Do not read from index -1 of an array.
NetBSD rev. 1.16 (Oct 13, 2012) by dholland@NetBSD via maintainer pjanzen@.
miod [Thu, 8 May 2014 22:17:33 +0000 (22:17 +0000)]
Format string fixes for m88k; remove -Wno-format from the m88k kernels.
deraadt [Thu, 8 May 2014 21:43:49 +0000 (21:43 +0000)]
move reallocarray() to a seperate file so that -portable applications
can avoid reinventing the wheel
ok guenther schwarze
miod [Thu, 8 May 2014 21:43:04 +0000 (21:43 +0000)]
Format string fixes and removal of -Wno-format for landisk kernels
miod [Thu, 8 May 2014 21:32:45 +0000 (21:32 +0000)]
Format string fixes and removal of -Wno-format for hppa kernels.
miod [Thu, 8 May 2014 21:31:56 +0000 (21:31 +0000)]
Update #include list after not-so-recent uvm includes cleanups.
miod [Thu, 8 May 2014 21:17:00 +0000 (21:17 +0000)]
Format string fixes and removal of -Wno-format for arm kernels.
miod [Thu, 8 May 2014 20:46:49 +0000 (20:46 +0000)]
Format string fixes for alpha kernels, and remove -Wno-format
kettenis [Thu, 8 May 2014 20:08:50 +0000 (20:08 +0000)]
Fix some potential integer overflows caused by converting a page number into
an offset/size/address by shifting by PAGE_SHIFT. Make uvm_objwrire/unwire
use voff_t instead of off_t. The former is the right type here even if it is
equivalent to the latter.
Inspired by a somewhat similar changes in Bitrig.
ok deraadt@, guenther@
miod [Thu, 8 May 2014 19:59:19 +0000 (19:59 +0000)]
Replace hand-crafted STRICT_ALIGNMENT with system provided __STRICT_ALIGNMENT.
Forgotten during yesterday's STRICT_ALIGNMENT cleanup commit.
miod [Thu, 8 May 2014 19:06:35 +0000 (19:06 +0000)]
No longer build vax kernels with -Wno-format.
miod [Thu, 8 May 2014 19:06:07 +0000 (19:06 +0000)]
Format string fixes.
miod [Thu, 8 May 2014 18:58:47 +0000 (18:58 +0000)]
Recognize `t' as a valid format modifier for kprintf-style format strings.
sf [Thu, 8 May 2014 18:09:22 +0000 (18:09 +0000)]
Format string fix in disabled code. Format bus_space_handle_t with %xl,
cast bus_space_tag_t to (u_long)
sf [Thu, 8 May 2014 17:59:28 +0000 (17:59 +0000)]
Enable -Wno-format in the kernel on i386 & amd64
ok jsg@
"go for it" kettenis@
miod [Thu, 8 May 2014 17:38:40 +0000 (17:38 +0000)]
regen
miod [Thu, 8 May 2014 17:38:12 +0000 (17:38 +0000)]
Remove irrelevant devices from the ramdisk target; spotted by deraadt
krw [Thu, 8 May 2014 16:46:47 +0000 (16:46 +0000)]
"Server?" -> "HTTP Server?" to allow unambiguous auto-install
handling.
Confusion with "NTP Server?" reported by Xavier Claude via misc@.
ok rpe@ halex@
reyk [Thu, 8 May 2014 16:11:06 +0000 (16:11 +0000)]
fail for unsupported node action/type combinations. Also fail for the
unsupported mark/marked combination in a single rule.
ok andre@
jsing [Thu, 8 May 2014 16:05:38 +0000 (16:05 +0000)]
More KNF.
jsing [Thu, 8 May 2014 16:01:06 +0000 (16:01 +0000)]
KNF.
andre [Thu, 8 May 2014 15:55:32 +0000 (15:55 +0000)]
Adjust this test contents from path keytype to url keytype to match the name of
the test file.
ok reyk
tedu [Thu, 8 May 2014 15:48:41 +0000 (15:48 +0000)]
protip: "It's largely bad style to do (int)sizeof"
amusingly, theo phrased this with considerably more restraint than i did.
jsing [Thu, 8 May 2014 15:46:24 +0000 (15:46 +0000)]
Remove KSSL debug code.
"fire bomb" tedu@
jsing [Thu, 8 May 2014 15:42:26 +0000 (15:42 +0000)]
KNF.
jsing [Thu, 8 May 2014 15:29:00 +0000 (15:29 +0000)]
Nuke OPENSSL_FIPS - having #ifdefs inside a #ifndef for the same thing
is amusing.
ok deraadt@
blambert [Thu, 8 May 2014 15:28:57 +0000 (15:28 +0000)]
remove debug prints that snuck in; found by reyk@
jsing [Thu, 8 May 2014 15:13:06 +0000 (15:13 +0000)]
KNF.
mikeb [Thu, 8 May 2014 14:48:31 +0000 (14:48 +0000)]
Pretty print MIB_ipNetToMediaPhysAddress'es; ok blambert
mpi [Thu, 8 May 2014 14:00:52 +0000 (14:00 +0000)]
Plug one more xfer leak.
Now that aborting interrupt pipes does not prevent us from freeing
the associated xfer, make sure to flag this xfer as "done" even if
there's no need to abort it in hardware.
jsing [Thu, 8 May 2014 13:48:36 +0000 (13:48 +0000)]
knfectomie.
aoyama [Thu, 8 May 2014 13:31:00 +0000 (13:31 +0000)]
The pcexmem(4) and pcexio(4) should be attached on LUNA-88K2 only.
Actually, there seems to be no PC-9801 extension board slot on
'original' LUNA-88K.
ok miod@
jsing [Thu, 8 May 2014 13:20:49 +0000 (13:20 +0000)]
Emergency knfectomie requested by tedu@.
blambert [Thu, 8 May 2014 13:11:16 +0000 (13:11 +0000)]
match iked proc.c infrastructure with proc.c
ok reyk@
blambert [Thu, 8 May 2014 13:08:48 +0000 (13:08 +0000)]
match relayd proc.c infrastructure with snmpd
okay reyk@
jmc [Thu, 8 May 2014 13:08:43 +0000 (13:08 +0000)]
inet(3) -> inet_net(3);
blambert [Thu, 8 May 2014 13:04:28 +0000 (13:04 +0000)]
Bring back restricted sockets, inadvertantly removed in
previous proc.c update
ok reyk@
giovanni [Thu, 8 May 2014 12:59:17 +0000 (12:59 +0000)]
kill some more VMS ifdefs
ok miod@
mpi [Thu, 8 May 2014 09:30:48 +0000 (09:30 +0000)]
Sync flags with route.h
mpi [Thu, 8 May 2014 09:28:08 +0000 (09:28 +0000)]
Introduce two new route flags: RTF_LOCAL and RTF_BROADCAST.
Nothing use them for the moment, but here is the plan:
Since a route lookup is always necessary to output a packet it makes
sense to store all the information regarding how the packet should be
sent in the routing entry. This will save us some expensive lookups
on address lists.
But once we have all the information about our addresses in the routing
table, we can even use it in the input path with the hope that the number
of lookups in the forwarding case can be reduce to one.
ok henning@, chris@
nicm [Thu, 8 May 2014 07:59:16 +0000 (07:59 +0000)]
Send up and down keys for mouse wheel in alternate screen mode (when it
normally does nothing), from Marcel Partap.
nicm [Thu, 8 May 2014 07:54:47 +0000 (07:54 +0000)]
Instead of forcing mouse scroll to 1 in choose mode, scale it down
instead. Means modifier keys still increase the line count, just not as
much. Based on a diff from Marcel Partap.
jmc [Thu, 8 May 2014 06:50:50 +0000 (06:50 +0000)]
whack some useless verbiage from DESCRIPTION, and merge some of it into
the env vars section; tidy up the env vars section and remove the commented
out stuff which relataes mainly to less on other systems;
jmc [Thu, 8 May 2014 06:24:14 +0000 (06:24 +0000)]
- update DESCRIPTION and COMPATIBILITY WITH MORE
- Xr more 1
ok millert schwarze
jmc [Thu, 8 May 2014 06:22:07 +0000 (06:22 +0000)]
+.Xr less 1 ,
nicm [Thu, 8 May 2014 06:06:07 +0000 (06:06 +0000)]
Plug a memory leak, from J Raynor.
nicm [Thu, 8 May 2014 06:03:30 +0000 (06:03 +0000)]
Both the two previous ways of navigating panes by direction have
irritating flaws:
a) The old way of always using the top or left if the choice is
ambiguous is annoying when the layout is unbalanced.
b) The new way of remembering the last used pane is annoying if the
layout is balanced and the leftmost is obvious to the user (because
clearly if we go right from the top-left in a tiled set of four we want
to end up in top-right, even if we were last using the bottom-right).
So instead, use a combination of both: if there is only one possible
pane alongside the current pane, move to it, otherwise choose the most
recently used of the choice.
nicm [Thu, 8 May 2014 05:53:29 +0000 (05:53 +0000)]
Handle colour 8 properly in the 256 colour palette, from Timothy Allen.
miod [Wed, 7 May 2014 22:05:48 +0000 (22:05 +0000)]
Get __STRICT_ALIGNMENT from <machine/endian.h> and decide upon it, rather
than defining it for not (i386 and amd64 (and sometimes s390)) only.
Compile-time tests remain compile-time tests, and runtime-test remain
runtime-test instead of being converted to compile-time tests, per matthew@'s
explicit demand (rationale: this makes sure the compiler checks your code even
if you won't run it).
No functional change except on s390 (which we don't run on) and vax (which we
run on, but noone cares about)
ok matthew@