espie [Sun, 9 Jul 2017 15:28:00 +0000 (15:28 +0000)]
there's no need to fork/exec to execute comments
okay millert@
espie [Sun, 9 Jul 2017 14:04:50 +0000 (14:04 +0000)]
have bsd.prog.mk/bsd.lib.mk generate .y -> .c/.h rules without intermediate
files. This fixes up parallel builds in the default case.
FreeBSD does something similar.
okay millert@
krw [Sun, 9 Jul 2017 12:38:47 +0000 (12:38 +0000)]
Whitespace tweaks to assuage auto-indent.
florian [Sun, 9 Jul 2017 09:00:56 +0000 (09:00 +0000)]
Ignore prefixes with a pltime < ND6_PRIV_MAX_DESYNC_FACTOR seconds
(512 in our case) for privacy addresses as per RFC 4941.
florian [Sun, 9 Jul 2017 08:41:47 +0000 (08:41 +0000)]
If we lower the pltime for privacy addresses skew it by
ND6_PRIV_MAX_DESYNC_FACTOR like RFC 4941 tells us to.
Toss in a arc4random_uniform for good measure like the kernel always
did.
tb [Sun, 9 Jul 2017 08:33:11 +0000 (08:33 +0000)]
Remove old junk. From Matthew Martin
ok bentley
pd [Sun, 9 Jul 2017 00:51:40 +0000 (00:51 +0000)]
vmd/vmctl: Add ability to pause / unpause vms
With help from Ashwin Agrawal
ok reyk@ mlarkin@
tedu [Sat, 8 Jul 2017 22:27:17 +0000 (22:27 +0000)]
this program was infected with lint era casts. i think we're past that now.
tedu [Sat, 8 Jul 2017 22:22:04 +0000 (22:22 +0000)]
remove ARGSUSED, from Scott Cheloha.
and while we're cleaning, switch __progname to getprogname.
tedu [Sat, 8 Jul 2017 22:19:23 +0000 (22:19 +0000)]
use crypt_newhash to protect the password. from Scott Cheloha
tedu [Sat, 8 Jul 2017 22:14:48 +0000 (22:14 +0000)]
clean up some unused variables. also, making a variable global isn't the
best way to zero initialize it if that's all you need.
tedu [Sat, 8 Jul 2017 22:07:39 +0000 (22:07 +0000)]
instead of using time(), refer to getitimer to find out how long the
timeout is.
from Scott Cheloha
tedu [Sat, 8 Jul 2017 22:01:09 +0000 (22:01 +0000)]
can just continue after readpassphrase returns null, the sighandler will
have already printed a message.
from Scott Cheloha
tedu [Sat, 8 Jul 2017 21:45:35 +0000 (21:45 +0000)]
update the little endian processor list to give it a chance of matching
what the reader is using.
krw [Sat, 8 Jul 2017 20:40:42 +0000 (20:40 +0000)]
Unhook tables.c from Makefile.
krw [Sat, 8 Jul 2017 20:38:31 +0000 (20:38 +0000)]
Fold tables.c into options.c and stop exporting the one
table (dhcp_options) involved. Provide functions
code_to_name(), name_to_code(), code_to_format() and
replace direct access to dhcp_options with them. Eliminate
unneeded 'struct option'.
Unhook tables.c from Makefile.
kettenis [Sat, 8 Jul 2017 19:36:58 +0000 (19:36 +0000)]
Remove duplicate typedesf that are now provided by linux_types.h.
jmc [Sat, 8 Jul 2017 18:32:54 +0000 (18:32 +0000)]
slightly rework previous, to avoid an article issue;
tedu [Sat, 8 Jul 2017 17:52:44 +0000 (17:52 +0000)]
spelling fix from Hiltjo Posthuma
schwarze [Sat, 8 Jul 2017 17:52:42 +0000 (17:52 +0000)]
Simplify by creating struct roff_node syntax tree nodes for tbl(7)
right from roff_parseln() rather than delegating to read.c,
similar to what i just did for eqn(7).
The interface function roff_span() becomes obsolete and is deleted,
the former interface function roff_addtbl() becomes static,
the interface functions tbl_read() and tbl_cdata() become void,
and minus twelve linus of code.
No functional change.
florian [Sat, 8 Jul 2017 16:22:29 +0000 (16:22 +0000)]
Consistently use if ((option & F_FOO) && (option & F_BAR)) instead of
if (option & F_FOO && option & F_BAR).
Prompted by a reverse diff from Klemens Nanni. Both forms are
equivalent due to operator precedence, I consider the later to be
easier on the eyes.
florian [Sat, 8 Jul 2017 16:21:51 +0000 (16:21 +0000)]
Consistently use if (option & F_FOO); from Klemens Nanni, thanks!
florian [Sat, 8 Jul 2017 15:45:11 +0000 (15:45 +0000)]
Enable slaacd on the installer and temporarily neuter router
advertisement processing and solicitation sending like we already did
for the non-install kernels.
Next step will be to tedu all that code from the kernel.
OK rpe@ for the installer bits
move forward deraadt@
florian [Sat, 8 Jul 2017 15:42:46 +0000 (15:42 +0000)]
hook up slaacd to the installer on media where we have INET6
florian [Sat, 8 Jul 2017 15:41:25 +0000 (15:41 +0000)]
_slaacd user/group for installer
move forward deraadt@
florian [Sat, 8 Jul 2017 15:40:29 +0000 (15:40 +0000)]
slaacd needs libevent on the ramdisk
move forward deraadt@
florian [Sat, 8 Jul 2017 15:39:11 +0000 (15:39 +0000)]
Increase size to make slaacd fit.
Size problem noted by me, correct fix from deraadt@
schwarze [Sat, 8 Jul 2017 15:28:05 +0000 (15:28 +0000)]
fix an assertion failure triggered by .ce in next-line scope;
found by jsg@ with afl(1)
krw [Sat, 8 Jul 2017 15:26:27 +0000 (15:26 +0000)]
Always use strcasecmp() when comparing user input to option
names, not just 2 out of 3.
schwarze [Sat, 8 Jul 2017 14:51:01 +0000 (14:51 +0000)]
1. Eliminate struct eqn, instead use the existing members
of struct roff_node which is allocated for each equation anyway.
2. Do not keep a list of equation parsers, one parser is enough.
Minus fifty lines of code, no functional change.
kevlo [Sat, 8 Jul 2017 14:26:23 +0000 (14:26 +0000)]
- For RTL8188CUS/RTL8192CU, we have to force 8051 reset/enable before waiting
for firmware to get ready. It fixes "urtwn0: could not load firmware page"
while running stsp@'s script: dhclient urtwn0; ifconfig urtwn0 down;
ifconfig urtwn0 scan in a loop.
- Minor cleanup for rtwn_read_rom()/rtwn_get_txpower(); no need to use
callbacks.
Tested by stsp@ and me.
ok stsp@
schwarze [Sat, 8 Jul 2017 13:43:09 +0000 (13:43 +0000)]
Correctly handle horizontal spans at the beginning of rows,
fixing an assertion failure found by jsg@ with afl(1).
While here, also drop printing of whitespace in tbl_data()
which makes no difference because column positioning code
in term_tbl() already takes care of that.
tb [Sat, 8 Jul 2017 13:37:23 +0000 (13:37 +0000)]
fix typo in comment
from Hiltjo Posthuma
mpi [Sat, 8 Jul 2017 09:19:02 +0000 (09:19 +0000)]
Revert grabbing the socket lock in kqueue filters.
It is unsafe to sleep while iterating the list of pending events in
kqueue_scan().
Reported by abieber@ and juanfra@
tedu [Sat, 8 Jul 2017 02:13:36 +0000 (02:13 +0000)]
add a hint about subjectAltName. this isn't great, but i'm not sure how
to improve it without muddying up the whole page, and at a minimum it
gives the reader a clue about some concepts to search the web for.
if you can do better, make it so. :)
krw [Sat, 8 Jul 2017 00:36:10 +0000 (00:36 +0000)]
Always use uintNN_t instead of sometimes u_intNN_t
and sometimes uintNN_t.
bluhm [Sat, 8 Jul 2017 00:08:26 +0000 (00:08 +0000)]
Run malloc0test with all possible malloc options.
bluhm [Fri, 7 Jul 2017 23:55:21 +0000 (23:55 +0000)]
Remove all references to "make depend" from regress.
bluhm [Fri, 7 Jul 2017 23:15:27 +0000 (23:15 +0000)]
Remove useless make depend targets.
schwarze [Fri, 7 Jul 2017 19:39:17 +0000 (19:39 +0000)]
garbage collect unused enum member EQN_ROOT
otto [Fri, 7 Jul 2017 19:14:46 +0000 (19:14 +0000)]
Only access offset if canaries are enabled *and* size > 0, otherwise offset
is not initialized. Problem spotted by Carlin Bingham; ok phessler@ tedu@
schwarze [Fri, 7 Jul 2017 19:06:15 +0000 (19:06 +0000)]
add parentheses to the output where required for disambiguation
kettenis [Fri, 7 Jul 2017 18:06:51 +0000 (18:06 +0000)]
You win some, you los some. The Linux 4.4 code is still sub-standard but
triggers different warnings now.
ok naddy@
reyk [Fri, 7 Jul 2017 17:25:09 +0000 (17:25 +0000)]
Handle carp(4) as HTYPE_ETHER.
This fixes "dhcrelay -i carpX" that used to work when dhcrelay didn't care.
Reported and tested by Kapetanakis Giannis bilias at edu.physics.uoc.gr
schwarze [Fri, 7 Jul 2017 17:15:21 +0000 (17:15 +0000)]
simplify the eqn_box_makebinary() function by removing the trivial pos
parameter; also minus two lines of code; no functional change
krw [Fri, 7 Jul 2017 16:58:45 +0000 (16:58 +0000)]
Replace the many occurances of '256' with a new #define
DHO_COUNT.
bluhm [Fri, 7 Jul 2017 16:31:37 +0000 (16:31 +0000)]
Disable tests that fail due to known make bugs, fix the others.
schwarze [Fri, 7 Jul 2017 16:30:06 +0000 (16:30 +0000)]
clarify which httpd we are talking about;
from Raf Czlonka <rczlonka at gmail dot com>
nicm [Fri, 7 Jul 2017 16:27:26 +0000 (16:27 +0000)]
Fix size of rightmost preview section.
tb [Fri, 7 Jul 2017 16:21:34 +0000 (16:21 +0000)]
Replace a doubled period and add a blank space in front of a bracket.
From Klemens Nanni
ok rpe
schwarze [Fri, 7 Jul 2017 16:19:30 +0000 (16:19 +0000)]
Radically simplify the definitions what the message levels ERROR
and WARNING mean: minus 20 lines of mdoc source. OK jmc@.
krw [Fri, 7 Jul 2017 15:39:30 +0000 (15:39 +0000)]
dispatch_imsg() only needs to know name and rdomain.
No more struct interface_info knowledge in privsep.[ch]
krw [Fri, 7 Jul 2017 15:14:47 +0000 (15:14 +0000)]
assemble_eh_header() needs only to know about hw_addr.
No more struct interface_info knowledge in packet.c
krw [Fri, 7 Jul 2017 14:53:06 +0000 (14:53 +0000)]
Rename cons_options() to pack_options(), and do_packet() to
unpack_options(). Store the unpacked options in a static
variable. Move remaining raw packet processing from unpack_options()
to packethandler().
No more struct interface_info knowledge in options.c
visa [Fri, 7 Jul 2017 14:49:04 +0000 (14:49 +0000)]
Add logic for running SD commands. Tested with a few different makes
of MMC/SD memory.
nicm [Fri, 7 Jul 2017 14:39:45 +0000 (14:39 +0000)]
Add a pane_pipe format to show if pipe-pane is active, GitHub issue 990.
espie [Fri, 7 Jul 2017 14:12:43 +0000 (14:12 +0000)]
trigger default .l.o rule and check the produced file has the right name
espie [Fri, 7 Jul 2017 14:11:07 +0000 (14:11 +0000)]
COMPILE.c already does -c, so no need to double it.
no functional change
espie [Fri, 7 Jul 2017 13:44:45 +0000 (13:44 +0000)]
unbreak
this specific rule is only triggered twice in the whole ports tree
(sysutils/xjobs and print/l2a)
This fixes them
espie [Fri, 7 Jul 2017 12:41:59 +0000 (12:41 +0000)]
we're not shooting yacception
okay millert@
bluhm [Fri, 7 Jul 2017 10:56:13 +0000 (10:56 +0000)]
Make libtool regress tests pass:
- There are no NOPIC architectures anymore.
- Add DISABLED targets for tests failing intensionally without
touching the real targets.
- In execute mode libtool command line must use ./p2 as . is not
in my PATH.
OK mpi@ espie@
bluhm [Fri, 7 Jul 2017 10:49:12 +0000 (10:49 +0000)]
Make mmap_hint.c compile on i386 by adding includes. Unfortunately
test is still failing.
visa [Fri, 7 Jul 2017 10:04:43 +0000 (10:04 +0000)]
Fix function name in panic message.
fcambus [Fri, 7 Jul 2017 09:15:59 +0000 (09:15 +0000)]
Make configuration lines match GENERIC files.
This adds amd64 and splits up alpha and i386.
OK deraadt@
fcambus [Fri, 7 Jul 2017 09:14:26 +0000 (09:14 +0000)]
Remove unnecessary #ifdefs in telnet. No binary change.
OK deraadt@, tedu@
nicm [Fri, 7 Jul 2017 07:13:14 +0000 (07:13 +0000)]
When working out the current client (for example for switch-client with
no target), prefer clients attached to the current session if there is
one. GitHub issue 995 from Jan Larres.
djm [Fri, 7 Jul 2017 03:53:12 +0000 (03:53 +0000)]
When generating all hostkeys (ssh-keygen -A), clobber existing keys
if they exist but are zero length. zero-length keys could previously
be made if ssh-keygen failed part way through generating them, so avoid
that case too. bz#2561 reported by Krzysztof Cieplucha; ok dtucker@
djm [Fri, 7 Jul 2017 00:10:15 +0000 (00:10 +0000)]
allow fetching lists from https:// URLs too
djm [Fri, 7 Jul 2017 00:09:14 +0000 (00:09 +0000)]
switch user to _spamd before executing ftp(1) to fetch lists.
sprinkle in some closefrom(2); ok deraadt@ beck@
schwarze [Thu, 6 Jul 2017 22:58:44 +0000 (22:58 +0000)]
Now that we have the -Wstyle message level, downgrade six warnings
that are not syntax mistakes and that do not cause wrong formatting
or content to style suggestions.
Also upgrade two warnings that may cause information loss to errors.
tb [Thu, 6 Jul 2017 22:19:23 +0000 (22:19 +0000)]
sync
bluhm [Thu, 6 Jul 2017 21:41:59 +0000 (21:41 +0000)]
REGRESS_TARGET has been renamed to TEST_TARGET.
spotted by anton@
bluhm [Thu, 6 Jul 2017 21:33:45 +0000 (21:33 +0000)]
Delete variable REGRESS_TARGET, missing plural S is a typo and it
is not used. Convert tests into a common style.
OK anton@
bluhm [Thu, 6 Jul 2017 19:40:18 +0000 (19:40 +0000)]
anton@ has fixed the test script so that it can run as root. Remove
my workaround that switched to build user.
schwarze [Thu, 6 Jul 2017 19:27:37 +0000 (19:27 +0000)]
Fix display of overlong lines containing non-ASCII bytes.
Also fixes a crash reported by Hiltjo Posthuma <hiltjo at codemadness
dot org>, though in a different way than with the patch he sent.
OK florian@ bcallah@
schwarze [Thu, 6 Jul 2017 19:20:21 +0000 (19:20 +0000)]
revert previous, requested by jmc@; he says the broken .Xr is intentional
schwarze [Thu, 6 Jul 2017 17:39:45 +0000 (17:39 +0000)]
Our website says that socppc was discontinued after 5.8 (thanks to
tobiasu@ for pointing that out), but the manual pages are still
installed. I have no idea how to properly tedu an architecture, so
deleting the dead .Xr to boot_socppc(8) is all i'm doing in this respect.
jsing [Thu, 6 Jul 2017 17:27:19 +0000 (17:27 +0000)]
Document tls_config_set_crl_file() and tls_config_set_crl_mem().
Based on a diff from Jack Burton <jack at saosce dot com dot au>, thanks!
schwarze [Thu, 6 Jul 2017 17:24:49 +0000 (17:24 +0000)]
Delete cross references to boot_landisk(8).
According to tobiasu@, landisk is moribund and writing new manual
pages for it would be a waste of time.
jsing [Thu, 6 Jul 2017 17:12:44 +0000 (17:12 +0000)]
Bump minor due to symbol addition.
jsing [Thu, 6 Jul 2017 17:12:22 +0000 (17:12 +0000)]
Add support for providing CRLs to libtls - once a CRL is provided we
enable CRL checking for the full certificate chain.
Based on a diff from Jack Burton <jack at saosce dot com dot au>, thanks!
Discussed with beck@
schwarze [Thu, 6 Jul 2017 16:58:34 +0000 (16:58 +0000)]
fix RCS Id; found with mandoc -Tlint
krw [Thu, 6 Jul 2017 16:56:52 +0000 (16:56 +0000)]
cons_options() only needs to know a buffer and a length to
pack options into. Not all the gory details of interface_info.
Move some of the raw packet processing out of options.c's
do_packet() and into the more obvious dispatch.c's
packethandler().
Mention that RFC791 is why we use 576-byte UDP packets.
schwarze [Thu, 6 Jul 2017 16:52:32 +0000 (16:52 +0000)]
delete duplicate RCS ID and lots of .Tn
schwarze [Thu, 6 Jul 2017 16:50:58 +0000 (16:50 +0000)]
delete duplicate RCS IDs; found with mandoc -Tlint
anton [Thu, 6 Jul 2017 16:34:28 +0000 (16:34 +0000)]
Do not suppress what's going on.
millert [Thu, 6 Jul 2017 16:23:11 +0000 (16:23 +0000)]
The 0x (or 0X) prefix in base 16 is optional so only skip over the
prefix if the character following it is a valid hex char. The C99
standard is clear that given the string "0xy" zero should be returned
and endptr set to point to the "x". OK deraadt@ espie@
schwarze [Thu, 6 Jul 2017 15:42:04 +0000 (15:42 +0000)]
fix broken cross references; found with mandoc -Tlint
florian [Thu, 6 Jul 2017 15:05:28 +0000 (15:05 +0000)]
installer version of slaacd, not hooked up to the build yet
florian [Thu, 6 Jul 2017 15:02:53 +0000 (15:02 +0000)]
Sprinkel in some #ifndef SMALL to make slaacd smaller for the
installer.
This removes the control socket handling which is useless because we
won't have slaacctl in the installer.
Also deraadt@ pointed out that this would be the first use of log.c in
the installer where we don't have syslogd running so it's rather
pointless. So this completely neuters logging.
The log.h change doesn't interfere with benno@'s efforts of unifying
log.c
The installer version of slaacd won't even compile control.c and log.c
florian [Thu, 6 Jul 2017 14:57:29 +0000 (14:57 +0000)]
reorder imsg_type enum so that we can #ifndef SMALL all the control
related imsg types
florian [Thu, 6 Jul 2017 14:56:39 +0000 (14:56 +0000)]
move rpref enum definition up so that we can #ifndef SMALL a big block
bluhm [Thu, 6 Jul 2017 14:17:11 +0000 (14:17 +0000)]
Disable new tests until sed has been adapted.
Discussed with otto@
deraadt [Thu, 6 Jul 2017 14:15:14 +0000 (14:15 +0000)]
sync
bluhm [Thu, 6 Jul 2017 13:20:54 +0000 (13:20 +0000)]
Initialize the return value and do not use garbage as exit status.
Then the test passes.
bluhm [Thu, 6 Jul 2017 13:11:15 +0000 (13:11 +0000)]
Link the runtests programs statically and explain why.
bluhm [Thu, 6 Jul 2017 13:06:34 +0000 (13:06 +0000)]
Add ULL suffix to 64 bit constants. This avoids compiler warnings
on i386 and allows to compile the C++ test. Upstream dropped the
ULL in an insufficient attempt to make the siphash code C89 compatible.
Their fix will be more complicated.
No binary change.
espie [Thu, 6 Jul 2017 12:15:23 +0000 (12:15 +0000)]
/tmp/cvsa9y4jm
mlarkin [Thu, 6 Jul 2017 11:27:56 +0000 (11:27 +0000)]
Remove bogus arguments from a printf in the bootloader.
ok tom@
bluhm [Thu, 6 Jul 2017 11:17:58 +0000 (11:17 +0000)]
Compile libexpat with -fvisibility=hidden. This restricts the
exported symbols to the indended API. We do not need a Symbols.map
anymore. Major library bump is necessary as some internal functions
vanish from the ABI.
Discussed upstream with Sebastian Pipping; ports bulk build ajacoutot@;
OK deraadt@