openbsd
3 years agoChange API of acpiiort(4). It was written as a hook before, taking the
patrick [Mon, 15 Mar 2021 22:48:57 +0000 (22:48 +0000)]
Change API of acpiiort(4).  It was written as a hook before, taking the
PCI attach args and replacing the DMA tag inside.  Our other IOMMU API
though takes a DMA tag and returns the old one or a new one.  To have
acpiiort(4) integrate better with non-PCI ACPI devices, change the API
so that it is more similar to the other API.  This also makes the code
easier to understand.

ok kettenis@

3 years agoAdd acpi_iommu_device_map(), which replaces the DMA tag with one that
patrick [Mon, 15 Mar 2021 22:44:57 +0000 (22:44 +0000)]
Add acpi_iommu_device_map(), which replaces the DMA tag with one that
is blessed with IOMMU magic, if available.  This is mainly for arm64,
since on amd64 and i386 the IOMMU only captures PCIe devices, as far
as I know, which uses the pci_probe_device_hook().  This though is for
non-PCI devices attached through ACPI.

ok kettenis@

3 years agoAdd the IORT structure for named components. These give us the stream ids
patrick [Mon, 15 Mar 2021 22:40:23 +0000 (22:40 +0000)]
Add the IORT structure for named components.  These give us the stream ids
used towards an smmu(4) for non-PCI devices.  The references are provided
as ASCII printable paths.

ok kettenis@

3 years agoWe makes sure that a dh group is required if the local proposal
tobhe [Mon, 15 Mar 2021 22:32:44 +0000 (22:32 +0000)]
We makes sure that a dh group is required if the local proposal
contains an explicit group transform. Override requiredh if one
of the local options is 'none' so that a proposal with no DH
group and on with explicit group 'none' result in a match.

ok patrick@

3 years agoIgnore msg_ke in CREATE_CHILD_SA if DH negotiation results in group
tobhe [Mon, 15 Mar 2021 22:29:17 +0000 (22:29 +0000)]
Ignore msg_ke in CREATE_CHILD_SA if DH negotiation results in group
'none' (disabling PFS).  Fixes a bug when the initiator sends a KE
payload but the negotiation results in DH group "none".
For other DH group mismatches we send an INVALID_KE notify, for 'none'
we can just ignore the KE payload.

ok patrick@

3 years agoClear AUTOCONF6TEMP flag when we detach inet6.
florian [Mon, 15 Mar 2021 17:28:45 +0000 (17:28 +0000)]
Clear AUTOCONF6TEMP flag when we detach inet6.

3 years agoDon't put an extern variable (ppc_kvm_stolen) into vmparam.h, other instances
deraadt [Mon, 15 Mar 2021 15:49:20 +0000 (15:49 +0000)]
Don't put an extern variable (ppc_kvm_stolen) into vmparam.h, other instances
of this file are only doing cpp #define

3 years agoDo not crash if there is no item to show command error, from Anindya
nicm [Mon, 15 Mar 2021 13:06:33 +0000 (13:06 +0000)]
Do not crash if there is no item to show command error, from Anindya
Mukherjee.

3 years agotweaks to system version handling:
espie [Mon, 15 Mar 2021 09:32:04 +0000 (09:32 +0000)]
tweaks to system version handling:
- create an element that accumulates version values  for when we have
several
- actually use compare on version values instead of hardcoding the
difference

no functional change

3 years agospelling
jsg [Mon, 15 Mar 2021 09:29:51 +0000 (09:29 +0000)]
spelling

3 years agoadd a check for system-version, since I tend to reverse comparisons
espie [Mon, 15 Mar 2021 09:26:29 +0000 (09:26 +0000)]
add a check for system-version, since I tend to reverse comparisons

3 years agoAllocate the repo structs individually linked by a SLIST instead of using
claudio [Mon, 15 Mar 2021 08:56:31 +0000 (08:56 +0000)]
Allocate the repo structs individually linked by a SLIST instead of using
an array that is reallocated during runtime. With this the entityq can
move back into struct repo.
OK tb@

3 years agoLog errors with log level info and SPI.
tobhe [Sun, 14 Mar 2021 20:23:43 +0000 (20:23 +0000)]
Log errors with log level info and SPI.

3 years agoSince we are doing getifaddrs() anyway we can get the rdomain out of
florian [Sun, 14 Mar 2021 16:05:50 +0000 (16:05 +0000)]
Since we are doing getifaddrs() anyway we can get the rdomain out of
AF_LINK and skip one ioctl.
OK benno

3 years agomsi-map-mask is a pasto and should be iommu-map-mask.
patrick [Sun, 14 Mar 2021 14:46:52 +0000 (14:46 +0000)]
msi-map-mask is a pasto and should be iommu-map-mask.

From Jared McNeill at NetBSD
ok kettenis@

3 years agoadd HISTORY; from maxim vuets
jmc [Sun, 14 Mar 2021 10:08:38 +0000 (10:08 +0000)]
add HISTORY; from maxim vuets

3 years agoregen
jan [Sun, 14 Mar 2021 01:10:35 +0000 (01:10 +0000)]
regen

3 years agoAdd ID for Intel SSD DC
jan [Sun, 14 Mar 2021 01:09:29 +0000 (01:09 +0000)]
Add ID for Intel SSD DC

ok jsg@

3 years agoUse EXFLAG_INVALID to handle out of memory and parse errors in
tobhe [Sat, 13 Mar 2021 23:01:49 +0000 (23:01 +0000)]
Use EXFLAG_INVALID to handle out of memory and parse errors in
x509v3_cache_extensions().

ok tb@

3 years agoRemove "deletetunnel" (deprecated with 6.4)
kn [Sat, 13 Mar 2021 21:23:29 +0000 (21:23 +0000)]
Remove "deletetunnel" (deprecated with 6.4)

OK deraadt

3 years agoMove all rdomain bits under SMALL
kn [Sat, 13 Mar 2021 21:21:36 +0000 (21:21 +0000)]
Move all rdomain bits under SMALL

"[-]rdomain" commands are ignored under SMALL but their prototypes,
the global and therefore dead print logic are still in.

OK deraadt

3 years agoMove MPLS related function prototypes under SMALL
kn [Sat, 13 Mar 2021 21:14:15 +0000 (21:14 +0000)]
Move MPLS related function prototypes under SMALL

OK deraadt

3 years agobecause the kernel has been replaced after last boot, run kvm_mkdb
deraadt [Sat, 13 Mar 2021 21:11:56 +0000 (21:11 +0000)]
because the kernel has been replaced after last boot, run kvm_mkdb
before the first consumer of kvm_bsd.db

3 years agosync usb_device_info with usb.h, spotted by Enrik Berkhan, and millert@
sthen [Sat, 13 Mar 2021 16:41:47 +0000 (16:41 +0000)]
sync usb_device_info with usb.h, spotted by Enrik Berkhan, and millert@
noticed another change

3 years agoAdvertise 30-bit color support.
kettenis [Sat, 13 Mar 2021 14:02:02 +0000 (14:02 +0000)]
Advertise 30-bit color support.

ok matthieu@, jsg@

3 years agoonly try to set timestamps on files; avoids error with ftp -o /dev/null
sthen [Sat, 13 Mar 2021 11:36:31 +0000 (11:36 +0000)]
only try to set timestamps on files; avoids error with ftp -o /dev/null
ok jca robert

3 years agoWe can use memory marked as EfiBootServicesCode or EfiBootServicesData
kettenis [Sat, 13 Mar 2021 10:09:40 +0000 (10:09 +0000)]
We can use memory marked as EfiBootServicesCode or EfiBootServicesData
as well.

ok drahn@, kn@

3 years agoAdd TEST_SSH_MODULI_FILE variable to allow overriding of the moduli file
dtucker [Sat, 13 Mar 2021 01:52:16 +0000 (01:52 +0000)]
Add TEST_SSH_MODULI_FILE variable to allow overriding of the moduli file
used during the test run.

3 years agoAdd WSDISPLAYIO_DEPTH_30 in order to support 30-bit color support.
kettenis [Fri, 12 Mar 2021 23:42:50 +0000 (23:42 +0000)]
Add WSDISPLAYIO_DEPTH_30 in order to support 30-bit color support.

ok jsg@

3 years agosync
deraadt [Fri, 12 Mar 2021 19:58:47 +0000 (19:58 +0000)]
sync

3 years agomerge unbound-1.13.1
sthen [Fri, 12 Mar 2021 19:45:27 +0000 (19:45 +0000)]
merge unbound-1.13.1

3 years agoupdate to unbound-1.13.1, tested by gnezdo@
sthen [Fri, 12 Mar 2021 19:44:11 +0000 (19:44 +0000)]
update to unbound-1.13.1, tested by gnezdo@

3 years agoINET6_NOPRIVACY is called AUTOCONF6TEMP now, missed during rename.
florian [Fri, 12 Mar 2021 19:35:43 +0000 (19:35 +0000)]
INET6_NOPRIVACY is called AUTOCONF6TEMP now, missed during rename.

3 years agoIn ipw(4), ensure that net80211 is in ASSOC state while we are expecting
stsp [Fri, 12 Mar 2021 17:54:50 +0000 (17:54 +0000)]
In ipw(4), ensure that net80211 is in ASSOC state while we are expecting
an assoc response from the AP during the association sequence. Otherwise
net80211 would ignore the auth response, resulting in a state mismatch
between firmware and net80211. A symptom of this was that WPA didn't work.

Problem reported and fix tested by Ricardo Mottola

3 years agoAdd deprecation warning for autoconfprivacy.
florian [Fri, 12 Mar 2021 17:25:02 +0000 (17:25 +0000)]
Add deprecation warning for autoconfprivacy.
While here check address family for 'temporary' option, only inet6 is
allowed.
OK kn

3 years agoUse RA instead of MiRA in iwn(4).
stsp [Fri, 12 Mar 2021 16:27:27 +0000 (16:27 +0000)]
Use RA instead of MiRA in iwn(4).

Tested by:
iwn 6200: stsp
iwn 6205: cwen, Jeremy O'Brien
iwn 6300: okan

3 years agoUse RA instead of MiRA in iwm(4).
stsp [Fri, 12 Mar 2021 16:27:10 +0000 (16:27 +0000)]
Use RA instead of MiRA in iwm(4).

Tested by:
iwm 7260: florian
iwm 7265: TronDD, Aaron Miller, stsp
iwm 8260: bket
iwm 8265: matthieu, tracey, naddy, Dave Voutila, jcs, Mathieu Kerjouan,
          Matthias Schmidt, stsp
iwm 9260: matthieu, phessler, Darren VanBuren
iwm 9560: Uwe Werler

3 years agoAdd RA, a new 11n Tx rate adaptation module for net80211.
stsp [Fri, 12 Mar 2021 16:26:27 +0000 (16:26 +0000)]
Add RA, a new 11n Tx rate adaptation module for net80211.

Written by Christian Ehrhardt and myself, based on ieee80211_mira.c
but with significant changes.

The main difference is that RA does not attempt to precisely measure
actual throughput but simply deducts a loss percentage from the
theoretical throughput which can be achieved by a given MCS.

Unlike MiRa, RA does not use timeouts to trigger probing.
Probing is triggered only by changes in measured throughput.

Unlike MiRA, RA doesn't care whether a frame was part of an A-MPDU.
RA simply collects statistics for individual subframes. This makes reporting
very easy for drivers and seems to work well enough in practice.

Another difference is that drivers can report multi-rate retries properly
via ieee80211_ra_add_stats_ht(mcs, total, fail) which can be called
several times before ieee80211_ra_choose() selects a new Tx rate.

There is no reason any issues could not be fixed in ieee8011_mira.c but
I felt it was a good moment to burn the house down and start over.
And since this code diverges from how MiRA is described in the research
paper applying the "MiRA" label becomes inappropriate.

3 years agoZap a useless variable.
tb [Fri, 12 Mar 2021 15:57:30 +0000 (15:57 +0000)]
Zap a useless variable.

suggested by jsing

3 years agoMissing void in function definition
tb [Fri, 12 Mar 2021 15:55:26 +0000 (15:55 +0000)]
Missing void in function definition

ok jsing

3 years agoFix checks of memory caps of constraints names
tb [Fri, 12 Mar 2021 15:53:38 +0000 (15:53 +0000)]
Fix checks of memory caps of constraints names

x509_internal.h defines caps on the number of name constraints and
other names (such as subjectAltNames) that we want to allocate per
cert chain. These limits are checked too late.  In a particularly
silly cert that jan found on ugos.ugm.ac.id 443, we ended up
allocating six times 2048 x509_constraint_name structures before
deciding that these are more than 512.

Fix this by adding a names_max member to x509_constraints_names which
is set on allocation against which each addition of a name is checked.

cluebat/ok jsing
ok inoguchi on earlier version

3 years agoUpdate Spleen kernel fonts to version 1.9.0, bringing the following
fcambus [Fri, 12 Mar 2021 14:39:37 +0000 (14:39 +0000)]
Update Spleen kernel fonts to version 1.9.0, bringing the following
improvements:

- Enlarge vertical line for consistency with other small sizes (5x8 version)
- Add full support for the Latin-1 Supplement Unicode block (6x12 version)

3 years agospelling
jsg [Fri, 12 Mar 2021 14:15:49 +0000 (14:15 +0000)]
spelling

ok mpi@

3 years agoEmulate "[inet] autoconf" hostname.if(5) lines with "dhcp"
kn [Fri, 12 Mar 2021 11:32:03 +0000 (11:32 +0000)]
Emulate "[inet] autoconf" hostname.if(5) lines with "dhcp"

With dhcpleased(8) in base, netstart(8) and ifconfig(8) understand both
"autoconf" and "inet autoconf" lines in hostname.if(5) files to signal the
new daemon.

The installer however currently has only dhclient(8), hence manual upgrades
with "[inet] autoconf" instead of "dhcp" in hostname.if files would fail to
establish IPv4 connectivity.

Make install.sub's netstart clone treat autoconf lines like old fashioned
dhcp lines such users^Wearly testers of the new approach don't get stuck in
nyetwork land.

Note that this is only relevant for manual upgrades;  installation always
creates working hostname.if files and automated upgrades with sysupgrade(8)
do not care about network/hostname.if files.

Idea from deraadt
OK deraadt krw ajacoutot

3 years agospelling
jsg [Fri, 12 Mar 2021 10:22:46 +0000 (10:22 +0000)]
spelling

3 years agoKill SINGLE_PTRACE and use SINGLE_SUSPEND which has almost the same semantic
mpi [Fri, 12 Mar 2021 10:13:28 +0000 (10:13 +0000)]
Kill SINGLE_PTRACE and use SINGLE_SUSPEND which has almost the same semantic

single_thread_set() is modified to explicitly indicated when waiting until
sibling threads are parked is required.  This is obviously not required if
a traced thread is switching away from a CPU after handling a STOP signal.

ok claudio@

3 years agoFix so tmux correctly sends the cvvis (cursor very visible) capability
nicm [Fri, 12 Mar 2021 08:39:17 +0000 (08:39 +0000)]
Fix so tmux correctly sends the cvvis (cursor very visible) capability
rather than sending it and then immediately undoing it with cnorm. Also
turn it off when the cursor shape is changed like xterm.

3 years agofix previous
jsg [Fri, 12 Mar 2021 07:24:49 +0000 (07:24 +0000)]
fix previous

3 years agospelling: refenece -> reference
jmc [Fri, 12 Mar 2021 07:05:35 +0000 (07:05 +0000)]
spelling: refenece -> reference

3 years agospelling
jsg [Fri, 12 Mar 2021 05:18:00 +0000 (05:18 +0000)]
spelling

3 years agoAdd ModuliFile keyword to sshd_config to specify the location of the
dtucker [Fri, 12 Mar 2021 04:08:19 +0000 (04:08 +0000)]
Add ModuliFile keyword to sshd_config to specify the location of the
"moduli" file containing the groups for DH-GEX.  This will allow us to
run tests against arbitrary moduli files without having to install them.
ok djm@

3 years agopwcopy() struct passwd that we're going to reuse across a bunch of
djm [Fri, 12 Mar 2021 03:43:40 +0000 (03:43 +0000)]
pwcopy() struct passwd that we're going to reuse across a bunch of
library calls; bz3273 ok dtucker@

3 years agoProvide definition of CTRL in vi.c like we do for emacs.c.
millert [Fri, 12 Mar 2021 02:10:25 +0000 (02:10 +0000)]
Provide definition of CTRL in vi.c like we do for emacs.c.
Fixes a portability issue.  From Benjamin Baier

3 years agoquiz: handle line continuation in data files correctly, switch to getline(3)
naddy [Thu, 11 Mar 2021 21:18:25 +0000 (21:18 +0000)]
quiz: handle line continuation in data files correctly, switch to getline(3)

Specifically, the following quiz.db line

foo:\
bar

was parsed into "foo:bar\n", which made it impossible to answer correctly.

Bug reported and inital fix from Alex Karle, partially reworked by
yours truly, further input from millert@

3 years agofix a double space and a macro error;
jmc [Thu, 11 Mar 2021 21:07:16 +0000 (21:07 +0000)]
fix a double space and a macro error;

3 years agoWhen RFC 8981 obsoleted RFC 4941 the terminology changed from
florian [Thu, 11 Mar 2021 19:53:39 +0000 (19:53 +0000)]
When RFC 8981 obsoleted RFC 4941 the terminology changed from
"privacy extensions" to "temporary address extensions"

Change ifconfig(8) to output temporary after temporary addresses and
add "temporary" option which is an alias for autoconfprivacy for now.

Also make AUTOCONF6TEMP a positiv flag that is set by default.
Previously the negative flag "INET6_NOPRIVACY" was set when privacy
addresses were disabled. This makes the flags output less ugly and
will allow us to disable autoconf addresses while having temporary
addresses enabled in the future.

More work is needed in slaacd.

input benno, jmc, deraadt
previous verison OK benno
OK jmc, kn

3 years agoUse unveil(2)
kn [Thu, 11 Mar 2021 18:12:41 +0000 (18:12 +0000)]
Use unveil(2)

Pledge is not possible due to the ioctls, but as apmd hoists both the
control socket and apm device early at startup and only ever possibly
executes scripts under /etc/apm/, hiding the rest of the filesystem
becomes easy.

Technically, only "x" is required to traverse the directory and run
scripts, but apmd carefully access(2) each script, which requires
the read bit regardless of the permission bits being tested.

OK mestre

3 years agoRemove ssl_downgrade_max_version().
jsing [Thu, 11 Mar 2021 17:14:46 +0000 (17:14 +0000)]
Remove ssl_downgrade_max_version().

Now that we store our maximum TLS version at the start of the handshake,
we can check against that directly.

ok inoguchi@ tb@

3 years agoThere is no need to try to attach IPv6 to an interface when the
florian [Thu, 11 Mar 2021 16:48:47 +0000 (16:48 +0000)]
There is no need to try to attach IPv6 to an interface when the
AUTOCONF6 flag is already set.
This is likely a leftover from when we sent router solicitations from
the kernel. This was a way to trigger sending a solicitation from
userland.
OK kn

3 years agoIf the AUTOCONF4 or AUTOCONF6 flags get enabled, force the interface up.
deraadt [Thu, 11 Mar 2021 15:56:27 +0000 (15:56 +0000)]
If the AUTOCONF4 or AUTOCONF6 flags get enabled, force the interface up.
ok florian claudio

3 years agoUse timespec timers to determine when select-timeout and timeout intervals
krw [Thu, 11 Mar 2021 15:30:49 +0000 (15:30 +0000)]
Use timespec timers to determine when select-timeout and timeout intervals
are exceeded.

Feedback from otto@, cheloha@

3 years agospelling
jsg [Thu, 11 Mar 2021 13:31:35 +0000 (13:31 +0000)]
spelling

3 years agoRevert rev 1.116
claudio [Thu, 11 Mar 2021 11:57:45 +0000 (11:57 +0000)]
Revert rev 1.116
The repo structs are reallocated during runtime and so the back pointers to
the head element of the TAILQ get corrupted.
Noticed by tb@

3 years agoCheck for the existence of p5-IO-Socket-SSL by checking for its SSL.pm
tb [Thu, 11 Mar 2021 11:57:33 +0000 (11:57 +0000)]
Check for the existence of p5-IO-Socket-SSL by checking for its SSL.pm
instead of running pkg_add which may block due to its locking mechanism.

Precise file to check for suggested by sthen
ok kn deraadt on previous version

3 years agospelling
jsg [Thu, 11 Mar 2021 11:16:54 +0000 (11:16 +0000)]
spelling

3 years agoAdd SMP support.
kettenis [Thu, 11 Mar 2021 10:40:22 +0000 (10:40 +0000)]
Add SMP support.

ok patrick@

3 years agoRemove unhelpful sentence from TPMR
kn [Thu, 11 Mar 2021 10:12:51 +0000 (10:12 +0000)]
Remove unhelpful sentence from TPMR

with dlg

3 years agoDocument veb(4)
kn [Thu, 11 Mar 2021 10:09:48 +0000 (10:09 +0000)]
Document veb(4)

All text is copied from other already existing sections, i.e. link flag
handling from TPMR and the rest from BIDGE.

Contrary to BRIDGE, add a synopsis for VEB such that there's a simple
overwiew, especially since veb(4) currently does not explain *how* to use
the described features.

NB: While TPMR and VEB use the same wording for link flags, their semantics
are different, i.e. both different flags and swapped polarity for those
flags.

Feedback jmc dlg
OK dlg

3 years agoLink to sh(1) and use the same wording and markup for EXTRACT_CASES code
kn [Thu, 11 Mar 2021 09:57:39 +0000 (09:57 +0000)]
Link to sh(1) and use the same wording and markup for EXTRACT_CASES code

"good idea" sthen

3 years agoThere is no need to revisit a file in the repo, so if the RB_INSERT fails
claudio [Thu, 11 Mar 2021 09:21:16 +0000 (09:21 +0000)]
There is no need to revisit a file in the repo, so if the RB_INSERT fails
just drop the entity queue element.
OK benno@ tb@

3 years agoThere is no need for a global enity queue, instead use per repo queues.
claudio [Thu, 11 Mar 2021 09:19:16 +0000 (09:19 +0000)]
There is no need for a global enity queue, instead use per repo queues.
Simplifies the code a fair bit.
OK tb@

3 years agoMake sure to skip attaching disabled I2C devices. This can happen on
patrick [Thu, 11 Mar 2021 09:15:25 +0000 (09:15 +0000)]
Make sure to skip attaching disabled I2C devices.  This can happen on
hardware which include a common parent block in their device trees and
only enable the components that were actually implemented, as seen on
e.g. the NanoPi R4S.

3 years agoMake sure to skip attaching disabled I2C devices. This can happen on
patrick [Thu, 11 Mar 2021 08:55:59 +0000 (08:55 +0000)]
Make sure to skip attaching disabled I2C devices.  This can happen on
hardware which include a common parent block in their device trees and
only enable the components that were actually implemented, as seen on
e.g. the NanoPi R4S.

ok kettenis@

3 years agogrow media a little
deraadt [Thu, 11 Mar 2021 07:57:18 +0000 (07:57 +0000)]
grow media a little

3 years agothat 0 should be NULL
deraadt [Thu, 11 Mar 2021 07:43:34 +0000 (07:43 +0000)]
that 0 should be NULL

3 years agoTidy old jobs every hour instead of every 30 seconds.
nicm [Thu, 11 Mar 2021 07:08:18 +0000 (07:08 +0000)]
Tidy old jobs every hour instead of every 30 seconds.

3 years agogroff complains about the word "An" in an Rs/Re block, believing it a macro,
jmc [Thu, 11 Mar 2021 07:04:12 +0000 (07:04 +0000)]
groff complains about the word "An" in an Rs/Re block, believing it a macro,
so escape it;

3 years agoAdd an "absolute-centre" alignment to use the centre of the total space
nicm [Thu, 11 Mar 2021 06:41:04 +0000 (06:41 +0000)]
Add an "absolute-centre" alignment to use the centre of the total space
instead of only the available space. From Magnus Gross in GitHub issue 2578.

3 years agoAdd split-window -Z to start the pane zoomed, GitHub issue 2591.
nicm [Thu, 11 Mar 2021 06:31:05 +0000 (06:31 +0000)]
Add split-window -Z to start the pane zoomed, GitHub issue 2591.

3 years agoBuild install media with -fno-asynchronous-unwind-tables to further
jsg [Wed, 10 Mar 2021 22:52:28 +0000 (22:52 +0000)]
Build install media with -fno-asynchronous-unwind-tables to further
reduce size.  Allows a clang 11 amd64 release to complete without
overflowing the floppy image.

ok kettenis@ deraadt@

3 years agoHandle named references in acpi_getdevlist(). Fixes a regression in acpitz
tobhe [Wed, 10 Mar 2021 22:20:44 +0000 (22:20 +0000)]
Handle named references in acpi_getdevlist(). Fixes a regression in acpitz
caused by the reference handling change from December.

ok kettenis@ patrick@

3 years agozlib functions take a gzFile not gzFile * (gzFile is already a pointer).
millert [Wed, 10 Mar 2021 21:55:22 +0000 (21:55 +0000)]
zlib functions take a gzFile not gzFile * (gzFile is already a pointer).
From Josh Rickmar.

3 years agoOur ACPI namerefs are pointers to the byte structures for ACPI names.
patrick [Wed, 10 Mar 2021 21:49:55 +0000 (21:49 +0000)]
Our ACPI namerefs are pointers to the byte structures for ACPI names.
These are not in a printable format, hence printing them as string is
wrong.  Additionally, aml_searchrel()/aml_searchname() expect the name
to be passed in a printable format as well.  Passing a nameref can lead
to an out-of-bounds read, and the comparison can fail.  Hence make sure
that namerefs are passed to aml_getname() first, which returns printable
strings.  Note that aml_getname() uses a static buffer, so there are a
few restrictions how the string can be used.

ok kettenis@

3 years agoAdd support for ^R (redraw) in insert mode too.
millert [Wed, 10 Mar 2021 20:17:33 +0000 (20:17 +0000)]
Add support for ^R (redraw) in insert mode too.
From gotroyb127, OK tb@

3 years agoDon't return ERR if resize didn't change size
millert [Wed, 10 Mar 2021 20:16:08 +0000 (20:16 +0000)]
Don't return ERR if resize didn't change size
This is a backport of the ncurses 5.9 20120707 patch.
Previously, getch() would return ERR if SIGWINCH was received but
the window didn't actually change size.  This can happen, for
example, when the xterm font is changed.  OK tb@

3 years agoFix redrawing of a multiline PS1 prompt in vi mode.
millert [Wed, 10 Mar 2021 20:06:04 +0000 (20:06 +0000)]
Fix redrawing of a multiline PS1 prompt in vi mode.
From gotroyb127 OK tb@

3 years agoTypofix previous
kn [Wed, 10 Mar 2021 19:19:04 +0000 (19:19 +0000)]
Typofix previous

3 years agoGuard TLS1_get_{client_,}version() macros with #ifndef LIBRESSL_INTERNAL.
jsing [Wed, 10 Mar 2021 18:32:38 +0000 (18:32 +0000)]
Guard TLS1_get_{client_,}version() macros with #ifndef LIBRESSL_INTERNAL.

These are no longer used (and should not be used) internally.

3 years agoRevise TLS extension regress to match version handling changes.
jsing [Wed, 10 Mar 2021 18:28:01 +0000 (18:28 +0000)]
Revise TLS extension regress to match version handling changes.

3 years agoImprove internal version handling.
jsing [Wed, 10 Mar 2021 18:27:01 +0000 (18:27 +0000)]
Improve internal version handling.

Add handshake fields for our minimum TLS version, our maximum TLS version
and the TLS version negotiated during the handshake. Initialise our min/max
versions at the start of the handshake and leave these unchanged. The
negotiated TLS version is set in the client once we receive the ServerHello
and in the server at the point we select the highest shared version.

Provide an ssl_effective_version() function that returns the negotiated TLS
version if known, otherwise our maximum TLS version - this is effectively
what is stored in s->version currently.

Convert most of the internal code to use one of these three version fields,
which greatly simplifies code (especially in the TLS extension handling
code).

ok tb@

3 years agodo not request client certificate unless required
eric [Wed, 10 Mar 2021 17:25:59 +0000 (17:25 +0000)]
do not request client certificate unless required

issue hit by florian@
diff by jsing@

ok tb@

3 years agoThe ktrace record for recvmsg/recvfrom could contain extract bits in
deraadt [Wed, 10 Mar 2021 17:03:58 +0000 (17:03 +0000)]
The ktrace record for recvmsg/recvfrom could contain extract bits in
msg_flags (they get set internally).  Correct the record to only contain
what the caller requested.

3 years agocleanup the 3 ways (2 for ipv4, 1 for ipv6) of doing dynamic address
deraadt [Wed, 10 Mar 2021 17:00:16 +0000 (17:00 +0000)]
cleanup the 3 ways (2 for ipv4, 1 for ipv6) of doing dynamic address
allocation. not the perfect text yet, but it is better.
discussed with florian and jmc

3 years agoLet MAIR comment catch up with reality.
kettenis [Wed, 10 Mar 2021 15:56:06 +0000 (15:56 +0000)]
Let MAIR comment catch up with reality.

3 years agoFix typo for ATS attribute member in IORT root complex struct.
patrick [Wed, 10 Mar 2021 12:49:24 +0000 (12:49 +0000)]
Fix typo for ATS attribute member in IORT root complex struct.

3 years agoExpand the maximum length for CHAP challenge to 96 octets. npppd
yasuoka [Wed, 10 Mar 2021 10:51:10 +0000 (10:51 +0000)]
Expand the maximum length for CHAP challenge to 96 octets.  npppd
couldn't handle ICCN message which has a ProxyAuthenChallenge AVP
longer than 24 octets.  Juniper actually send such challenges.
Reported and tested by Ryan Freeman.

3 years agoFix "phone number" spelling.
patrick [Wed, 10 Mar 2021 10:29:26 +0000 (10:29 +0000)]
Fix "phone number" spelling.

ok yasuoka@

3 years agospelling
jsg [Wed, 10 Mar 2021 10:21:47 +0000 (10:21 +0000)]
spelling

ok gnezdo@ semarie@ mpi@

3 years agosndiod: When a slot structure is recycled allocate new control
ratchov [Wed, 10 Mar 2021 08:22:25 +0000 (08:22 +0000)]
sndiod: When a slot structure is recycled allocate new control

Trying to rename the program level control is not needed anymore.
When a slot is given to another program, the new ctl_{new,del}()
functions can be used to delete the control of the old program and
create a new one for the new program. Cleaner, simpler.

3 years agosndiod: Style tweak: swap if/else code blocks in slot_new()
ratchov [Wed, 10 Mar 2021 08:21:27 +0000 (08:21 +0000)]
sndiod: Style tweak: swap if/else code blocks in slot_new()