kettenis [Sun, 9 Apr 2017 21:47:05 +0000 (21:47 +0000)]
Add a few missing quad-precision support functions on arm64 and reorder the
list to match what's in CMakeLists.txt.
ok sthen@
guenther [Sun, 9 Apr 2017 21:32:42 +0000 (21:32 +0000)]
Sync symbol lists for trap/interrupt frame detection with what ddb(4) uses
ok deraadt@
krw [Sun, 9 Apr 2017 20:44:13 +0000 (20:44 +0000)]
Seven casts, a couple of tweaks and CFLAGS+=-Wsign-compare for the
win.
No intentional functional change.
deraadt [Sun, 9 Apr 2017 19:59:43 +0000 (19:59 +0000)]
malloc -> mallocarray; a typo
dhill [Sun, 9 Apr 2017 18:16:00 +0000 (18:16 +0000)]
Convert some malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 18:15:32 +0000 (18:15 +0000)]
Convert a malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 18:15:09 +0000 (18:15 +0000)]
Convert a malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 18:14:39 +0000 (18:14 +0000)]
Convert a malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 18:09:41 +0000 (18:09 +0000)]
Convert some malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 18:07:19 +0000 (18:07 +0000)]
Convert some malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 18:05:17 +0000 (18:05 +0000)]
Convert some malloc(9) to mallocarray(9)
ok deraadt@
dhill [Sun, 9 Apr 2017 17:57:58 +0000 (17:57 +0000)]
Use mallocarray to allocate multicast group memberships.
ok deraadt@
deraadt [Sun, 9 Apr 2017 15:47:18 +0000 (15:47 +0000)]
Correct wakeup() dance in sensor_task_work()
Problem noticed by krw
jsing [Sun, 9 Apr 2017 15:06:20 +0000 (15:06 +0000)]
Simplify/clean up BUF_MEM_grow_clean().
ok beck@
jsing [Sun, 9 Apr 2017 15:03:54 +0000 (15:03 +0000)]
With recallocarray() BUF_MEM_grow() is essentially the same as
BUF_MEM_grow_clean() (the only difference is clearing on internal down
sizing), so make it a wrapper.
ok beck@ deraadt@
jsing [Sun, 9 Apr 2017 14:33:21 +0000 (14:33 +0000)]
Explicitly test for NULL.
ok beck@
jsing [Sun, 9 Apr 2017 14:31:44 +0000 (14:31 +0000)]
Improve unknown protocol version handling.
natano [Sun, 9 Apr 2017 09:58:53 +0000 (09:58 +0000)]
Remove unused #define's and struct.
florian [Sun, 9 Apr 2017 09:13:28 +0000 (09:13 +0000)]
image/svg+xml is a default inbuilt media type.
Pointed out by Anton Lindqvist (anton.lindqvist AT gmail), thanks!
jsg [Sun, 9 Apr 2017 02:40:24 +0000 (02:40 +0000)]
Fix multiple cases of reading past the end of a buffer in the sasyncd(8)
config parser found with afl.
feedback and ok millert@ ok deraadt@
gsoares [Sat, 8 Apr 2017 22:59:09 +0000 (22:59 +0000)]
snprintf() format string should be literal
avoid compiler silly warnings
sure deraadt@
gsoares [Sat, 8 Apr 2017 22:50:41 +0000 (22:50 +0000)]
format string is better be literal
OK deraadt
kettenis [Sat, 8 Apr 2017 22:38:17 +0000 (22:38 +0000)]
For legacy interrupt use the tag of the topmost bridge to establish the
interrupt. We already correctly swizzle the pin.
ok patrick@
kettenis [Sat, 8 Apr 2017 22:31:33 +0000 (22:31 +0000)]
Bring over the changes I made to the armv7 version of this driver such that
interrupts are correctly routed to the boot cpu if that isn't the one
connected to CPU interface zero on the interrupt controller.
ok patrick@
naddy [Sat, 8 Apr 2017 20:53:54 +0000 (20:53 +0000)]
re-enable POOL_DEBUG after the release; ok deraadt@
schwarze [Sat, 8 Apr 2017 20:36:50 +0000 (20:36 +0000)]
use .Em for emphasis, not .Pa
krw [Sat, 8 Apr 2017 20:16:04 +0000 (20:16 +0000)]
Reduce the overburden of signed vs unsigned comparisons by sprinkling
'int' -> 'unsigned int' (and visa versa) where obvious.
Steal a couple of 'unsigned' -> u_int32_t from reyk@'s dhcrelay
tweaks.
No intentional functional change.
mlarkin [Sat, 8 Apr 2017 19:08:18 +0000 (19:08 +0000)]
change a log message from "warn" to "debug" level, as the condition it is
reporting is not actually a warning.
mlarkin [Sat, 8 Apr 2017 19:06:29 +0000 (19:06 +0000)]
implement nonspecific EOI mode for the legacy PIC
ok deraadt
mlarkin [Sat, 8 Apr 2017 19:06:04 +0000 (19:06 +0000)]
implement channels 1 and 2 of the legacy PIT.
ok otto, deraadt
krw [Sat, 8 Apr 2017 18:54:52 +0000 (18:54 +0000)]
Replace another snprintf() dance with easier to read code using
strlcat(). Shorter, clearer, fewer signed vs unsigned questions.
Use an 8K static buffer for pretty_print_classless() and use it
rather scribbling intermediate values into the final destination.
No intentional functional change.
krw [Sat, 8 Apr 2017 17:00:10 +0000 (17:00 +0000)]
Replace a mess of snprintf() dances with easier to read code using
strlcat(). Shorter, clearer, fewer signed vs unsigned questions.
Shrink static buffer for the string version of an option value from
32K to 8K. Since the string version of the entire lease is constructed
in a 8K buffer, bigger option values are pointless.
Use 8K of the saved space for a static buffer for pretty_print_string()
and use it rather scribbling intermediate values into the final
destination.
No intentional functional change.
ajacoutot [Sat, 8 Apr 2017 13:29:37 +0000 (13:29 +0000)]
Document the devel/meson MODULE.
visa [Sat, 8 Apr 2017 10:53:48 +0000 (10:53 +0000)]
Make network ports work on Shasta.
rpe [Sat, 8 Apr 2017 08:33:05 +0000 (08:33 +0000)]
- localize the if, file and stat variables which also ensures that
variables are not named like commands.
- change test from [] to [[]]
OK tb@ halex@
deraadt [Sat, 8 Apr 2017 04:06:01 +0000 (04:06 +0000)]
Sensors are run as callbacks inside tasks. During suspend a sensor
could be running inside a driver that will be force-detached, or due
to tsleep end up disrupting the softstate/hardstate contract. At
suspend time, quisce all these callbacks by waiting for completion.
This issue has never been observed for real, but may be implicated in
suspend/resume failures.
ok kettenis guenther mlarkin
jmatthew [Sat, 8 Apr 2017 03:36:50 +0000 (03:36 +0000)]
Use ADDR64 opcodes to specify 64bit DMA addresses for all buffers. This
consumes two ring entries per segment, halving the effective size of the
rings, but keeps things simple. This is required for the onboard nic
on the Overdrive 1000 to work.
ok kettenis@, tested on i386 by jsg@
mlarkin [Sat, 8 Apr 2017 03:29:13 +0000 (03:29 +0000)]
Remove some #if 0 code that dates back to r1.1
Pointed out by Michael W. Bombardieri
deraadt [Sat, 8 Apr 2017 02:57:23 +0000 (02:57 +0000)]
A pile of sizes to free(9). In test for a few days in snapshots.
Errors will result in nice clean panic messages so we know what's wrong.
Reviewed by dhill visa natano jsg.
deraadt [Sat, 8 Apr 2017 01:20:10 +0000 (01:20 +0000)]
Two prototypes for acpi_maptable; merge to one place
rpe [Fri, 7 Apr 2017 22:53:25 +0000 (22:53 +0000)]
Minimize differences in ifstart() function between netstart and
install.sub which makes it easier to spot changes in the future.
- comments and formatting
- quotes on assignments are not needed (netstart)
- remove stray space in test (netstart)
- use $file variable with while-loop (netstart)
- although valid, instead of i use $i in arithmetic test (install.sub)
OK krw@, tb@
Looks good deraadt@
rpe [Fri, 7 Apr 2017 22:15:17 +0000 (22:15 +0000)]
Align comments of ifstart() function in netstart and install.sub.
rpe [Fri, 7 Apr 2017 22:02:29 +0000 (22:02 +0000)]
Sync variable names with netstart version of stripcom().
Use $_file variable instead of $1 with the wile-loop.
rpe [Fri, 7 Apr 2017 21:44:07 +0000 (21:44 +0000)]
Align comments of stripcom() function in netstart and install.sub.
rpe [Fri, 7 Apr 2017 21:00:42 +0000 (21:00 +0000)]
Extend the information shown by diskinfo() to help to identify
disks. Extract the disk information enclosed in <> and the NAA
from the last matching dmesg line. Useful if there are multiple
identically sized disk of the same type.
Suggested by jirib at devio dot us
Discussed with deraadt@
bluhm [Fri, 7 Apr 2017 17:33:45 +0000 (17:33 +0000)]
In ssl.h TLS 1.0 is called TLSv1. Adapt name in test to make it pass.
OK jsing@
bluhm [Fri, 7 Apr 2017 15:49:46 +0000 (15:49 +0000)]
Adapt test to new syslogd's local message priority.
bluhm [Fri, 7 Apr 2017 15:36:16 +0000 (15:36 +0000)]
Incoming TCP connections from clients fill the files of a log server.
A log client reconnects at every SIGHUP. Write these accept and
close messages with debug priority, then they can be turned on in
syslog.conf. Default is off.
While there, move a debug message and set the priority of the exit
message explicitly to error.
OK mpf@ millert@
krw [Fri, 7 Apr 2017 15:03:00 +0000 (15:03 +0000)]
Simply decoding of domain search option. No intentional functional
change.
visa [Fri, 7 Apr 2017 14:17:38 +0000 (14:17 +0000)]
Add prid for CN72xx/CN73xx.
visa [Fri, 7 Apr 2017 13:30:43 +0000 (13:30 +0000)]
Make SoC version available in a simple form.
jsing [Fri, 7 Apr 2017 08:48:30 +0000 (08:48 +0000)]
Use uint8_t instead of u_int8_t - for consistency and to make things easier
for portable.
From Raphael Hittich.
guenther [Fri, 7 Apr 2017 04:48:44 +0000 (04:48 +0000)]
si_addr should be of type void *, not char *
From Andrew Aldridge (i80and(at)foxquill.com)
ok millert@ mpi@
guenther [Fri, 7 Apr 2017 04:45:24 +0000 (04:45 +0000)]
Simplify the size calculation for memset()
From Anton Lindqvist (anton.lindqvist(at)gmail.com)
krw [Thu, 6 Apr 2017 22:41:39 +0000 (22:41 +0000)]
Inspired by recent dhcrelay(8) changes add some stricter CFLAGS. No code
changes needed (yet).
reyk [Thu, 6 Apr 2017 21:35:22 +0000 (21:35 +0000)]
"kernel" got renamed to "boot" in vm.conf but I didn't commit the parse.y bits.
Found by Pontus Lundkvist
OK deraadt
tedu [Thu, 6 Apr 2017 21:16:14 +0000 (21:16 +0000)]
replace some long if/else chains with a switch
tedu [Thu, 6 Apr 2017 21:14:12 +0000 (21:14 +0000)]
a little const here and there to prevent rules from changing
tedu [Thu, 6 Apr 2017 21:12:06 +0000 (21:12 +0000)]
prepenv can take a const rule
natano [Thu, 6 Apr 2017 19:09:45 +0000 (19:09 +0000)]
Remove the CD9660MAXPATH define. It was used to construct the path for
opening the file, so PATH_MAX makes more sense here. While there change
the code to do two less allocations per file.
ok deraadt
jmc [Thu, 6 Apr 2017 18:55:42 +0000 (18:55 +0000)]
less chatty EXAMPLES; from anton lindqvist
deraadt [Thu, 6 Apr 2017 18:25:38 +0000 (18:25 +0000)]
trailing ; on end of macro definition is wrong; ok guenther
reyk [Thu, 6 Apr 2017 18:07:13 +0000 (18:07 +0000)]
Do not expose vmm(4) VM IDs to the user, use vmd(8)'s IDs instead.
Each VM has two IDs: one from the kernel (vmm) and a different one
from userland (vmd). The vmm ID is not consistent and incremented on
every boot during runtimg of the host system. The vmd ID remains the
same during the lifetime of a configured VM, even after reboots.
Configured VMs will even get and keep their IDs when the configuration
is loaded. This is more what users expect.
Pointed out and tested by otto@
OK deraadt@
dhill [Thu, 6 Apr 2017 17:36:18 +0000 (17:36 +0000)]
Convert bcopy to memcpy where the memory does not overlap, otherwise,
use memmove. While here, change some previous conversions to a simple
assignment.
ok deraadt@
jmc [Thu, 6 Apr 2017 17:36:00 +0000 (17:36 +0000)]
shuffle for a saner read; help/ok bluhm
jmc [Thu, 6 Apr 2017 17:33:39 +0000 (17:33 +0000)]
document -=; while here, simplify things so that we don;t add a separate
usage every time we think of a new way to use this;
-= bits from anton lindqvist
ok tb tom
deraadt [Thu, 6 Apr 2017 17:00:53 +0000 (17:00 +0000)]
Sizes for the remaining free() calls, and use mallocarray()
ok visa
otto [Thu, 6 Apr 2017 17:00:52 +0000 (17:00 +0000)]
Consistentcy between nmembers and size order. From Christopher Hettrick;
ok deraadt@
bluhm [Thu, 6 Apr 2017 16:56:44 +0000 (16:56 +0000)]
Check that local syslog messages have the the expected priority.
beck [Thu, 6 Apr 2017 15:30:12 +0000 (15:30 +0000)]
fix missing \ on \n, spotted by Edgar Pettijohn
visa [Thu, 6 Apr 2017 15:29:47 +0000 (15:29 +0000)]
Use the correct interrupt disestablish routine.
visa [Thu, 6 Apr 2017 15:25:24 +0000 (15:25 +0000)]
Extend the fdt interrupt API a little.
bluhm [Thu, 6 Apr 2017 14:55:43 +0000 (14:55 +0000)]
Add the LOG_SYSLOG facility to local messages.
OK millert@
dhill [Thu, 6 Apr 2017 14:25:18 +0000 (14:25 +0000)]
Replace bcopy with a simple assignment where both variables are
properly aligned and sockaddr_union fields, or with memcpy when
the memory doesn't overlap.
OK bluhm@
gsoares [Thu, 6 Apr 2017 12:22:32 +0000 (12:22 +0000)]
use memset() instead of bzero()
OK jmatthew
gsoares [Thu, 6 Apr 2017 12:20:48 +0000 (12:20 +0000)]
fix format string found by clang -Wformat-security
OK deraadt millert
bcook [Thu, 6 Apr 2017 10:38:24 +0000 (10:38 +0000)]
bump version for new development branch
kettenis [Thu, 6 Apr 2017 09:28:29 +0000 (09:28 +0000)]
Compile C code with -funwind-tables. Fixes exception handling on architectures
that don't generate .eh_frame info by default such as arm64.
ok jsg@
otto [Thu, 6 Apr 2017 08:39:47 +0000 (08:39 +0000)]
first print size in meta-data then supplied arg size when an inconsistency is
detected wrt recallocarray()
jsg [Thu, 6 Apr 2017 07:07:28 +0000 (07:07 +0000)]
remove stray character in previous that broke the build
deraadt [Thu, 6 Apr 2017 04:48:54 +0000 (04:48 +0000)]
Unify a few attach-time patterns between usb *com drivers, and remove
extra zero'ing of variables not needed because softc is pre-zero'd.
ok jsg
deraadt [Thu, 6 Apr 2017 03:15:29 +0000 (03:15 +0000)]
add sizes to free() calls
ok dhill
dhill [Thu, 6 Apr 2017 02:11:08 +0000 (02:11 +0000)]
Convert bcopy to memcpy as the memory does not overlap.
ok deraadt@
deraadt [Wed, 5 Apr 2017 22:45:21 +0000 (22:45 +0000)]
3 more mallocarray() uses
bluhm [Wed, 5 Apr 2017 22:32:14 +0000 (22:32 +0000)]
Syslogd's debug and error messages have changed a bit, adapt test.
dhill [Wed, 5 Apr 2017 22:27:03 +0000 (22:27 +0000)]
Replace 2 bcopy()'s with a simple assignment as both variables are
properly aligned malloc(9)d data and sockaddr_union fields. While here,
convert the remaining bcopy() to memmove().
with and ok @bluhm
bluhm [Wed, 5 Apr 2017 22:15:35 +0000 (22:15 +0000)]
The global variable Startup is not used anymore and can be deleted.
The functionality has moved into log_setdebug().
OK millert@
bluhm [Wed, 5 Apr 2017 21:55:31 +0000 (21:55 +0000)]
As we did not have nice log functions before, ttymsg() had to return
the error string. Log the message when the error happens and make
the function void.
OK millert@
bluhm [Wed, 5 Apr 2017 21:30:04 +0000 (21:30 +0000)]
The function logmsg() was used to generate local messages and to
process incoming messages. Split this functionality into log_info()
and logline(). Sort the parameters like they appear in the syslog
line.
OK millert@
bluhm [Wed, 5 Apr 2017 19:34:49 +0000 (19:34 +0000)]
Replace logerror() functions with generic log_warn() from log.c.
Make messages a bit more consistent. Note that the new function
supports format strings. Replace some log_debug() with log_warn().
OK millert@
krw [Wed, 5 Apr 2017 18:22:30 +0000 (18:22 +0000)]
Shuffle sendhup() into dispatch.c, the only place it is used.
millert [Wed, 5 Apr 2017 18:15:43 +0000 (18:15 +0000)]
Not all devices support mmap, document EINVAL in this case too.
OK deraadt@
deraadt [Wed, 5 Apr 2017 15:57:11 +0000 (15:57 +0000)]
Clamp size to length if snprintf ever indicates overflow
w/ millert
bluhm [Wed, 5 Apr 2017 15:16:12 +0000 (15:16 +0000)]
Replace all combinations of logerror() and die() with log.c fatal().
Internally syslogd's fatal() calls die() to do cleanup if necessary.
Also replace all err(3) after log_init() with fatal().
OK millert@
jca [Wed, 5 Apr 2017 14:50:05 +0000 (14:50 +0000)]
Unify variables used for recvmsg/sendmsg
ok millert@ deraadt@
jca [Wed, 5 Apr 2017 14:48:48 +0000 (14:48 +0000)]
sendmsg returns a signed value, fix error check
ok millert@ deraadt@
reyk [Wed, 5 Apr 2017 14:43:14 +0000 (14:43 +0000)]
We can enable many -W compiler warnings now.
OK rzalamena@
reyk [Wed, 5 Apr 2017 14:40:56 +0000 (14:40 +0000)]
Rework the packet.c code for decoding and assembling DHCP messages.
This code suffered from many years of incremental improvements, fix it to:
- verify available buffer space in all cases and don't just trust the caller
- have an API where you always pass the full buffer length and absolute offset
- use consistent types for lengths and buffer offsets (int vs. size_t, ssize_t)
- don't just ignore errors, return and fail when something is wrong
OK rzalamena@
jca [Wed, 5 Apr 2017 13:38:18 +0000 (13:38 +0000)]
Don't rely on asprintf setting pointer to NULL on failure.
ok millert@ deraadt@ tom@
deraadt [Wed, 5 Apr 2017 13:35:18 +0000 (13:35 +0000)]
When building counter memory in preparation to copy to userland, always
zero the buffers first. All the current objects appear to be safe,
however future changes might introduce structure pads.
Discussed with guenther, ok bluhm