schwarze [Sun, 18 Jul 2021 11:25:47 +0000 (11:25 +0000)]
Let the mandoc.db(5) test suite work with parallel make (make -j),
by making sure that different tests use different directory names
for their work such that they do not collide.
As a side benefit, this allows keeping the complete working directories
of the tests until "make cleandir" is run, which may occasionally
help debugging when something breaks.
The failure with make -j was detected and reported by anton@,
who also reviewed, tested, and OK'ed this somewhat lengthy patch.
kn [Sun, 18 Jul 2021 11:18:38 +0000 (11:18 +0000)]
Document dhcpleased(8) and slaacd(8) besides dhclient(8) as DNS source
Zap the obsolete dhclient.conf(5) supersede quirk while here.
Feedback OK florian
kn [Sun, 18 Jul 2021 11:08:34 +0000 (11:08 +0000)]
Follow dhclient -> dhcpleased switch, reduce supported DHCP statements
dhcpleased(8) does not support every statement dhclient(8) does, so reflect
the status quo simplify things to the smaller set of statements that still
suffice to use autoinstall(8).
While here, speak of dhcp-options(5) and "DHCP lease" instead of
dhcpd.conf statements and the installer's specific DHCP client/parser.
OK florian
jsg [Sun, 18 Jul 2021 10:20:06 +0000 (10:20 +0000)]
make the printf on skipping reset with gen7/gen8 debug only
With the 5.10 drm on vlv/ivb/hsw/bdw inteldrm has been known to reset
the chip when a gpu hang is falsely detected. This appears to be
related to the workarounds for cleaning up after switching hardware
contexts.
intel_gt_reset *NOTICE* [drm] Resetting chip for context closure in glsl-uniform-int<99177>
mark_guilty *NOTICE* [drm] glsl-uniform-int[97885] context reset due to GPU hang
A local change skips the reset (which kills Xorg) on gen7/gen8.
The printf is in that path.
stsp [Sun, 18 Jul 2021 09:37:49 +0000 (09:37 +0000)]
Update the list of firmware files used by iwm(4).
jsg [Sun, 18 Jul 2021 05:02:37 +0000 (05:02 +0000)]
regen
jsg [Sun, 18 Jul 2021 05:02:08 +0000 (05:02 +0000)]
add devices from ASUS ROG Strix G513QY and Alienware Aurora R10
krw [Sat, 17 Jul 2021 21:47:56 +0000 (21:47 +0000)]
The first think MBR_init() does is memset(0) the gpt header and gpt
partition array. So no need to memset(0) the gpt header before each
MBR_init() invocation.
No functional change.
kn [Sat, 17 Jul 2021 20:46:02 +0000 (20:46 +0000)]
Remove setpassent(3) leftovers
Those should have gone with the switch to uid_from_user(3) in r1.95;
OK millert
deraadt [Sat, 17 Jul 2021 17:14:29 +0000 (17:14 +0000)]
Don't document systems which rewrite/change resolv.conf. Those systems can
document their actions in their own manual pages.
ok kn
kn [Sat, 17 Jul 2021 15:28:31 +0000 (15:28 +0000)]
Follow up on dhclient(8) to dhcpleased(8)/resolvd(8) switch
hostname.if(5)'s "dhcp" no longer triggers dhclient in any way, so suggest
the simple "inet autoconf" instead while mentioning "dhcp" as an alias for
that.
Add markup to changed sentences while here.
There is more room for improvemen in this manual.
Feedback deraadt, "go ahead"
schwarze [Sat, 17 Jul 2021 14:23:02 +0000 (14:23 +0000)]
Make the mandoc.db(5) tests work with BSDOBJDIR set,
by stripping initial parts of paths the do not matter
for the features being tested from man(1) output.
Problem found and reported by, solution developed together with, and
OK anton@
krw [Sat, 17 Jul 2021 14:16:34 +0000 (14:16 +0000)]
Nuke a bunch of Capt. Obvious or misleading comments.
No functional change.
krw [Sat, 17 Jul 2021 13:37:01 +0000 (13:37 +0000)]
Change edit/gedit/setpid/gsetpid to return 0/-1 to indicate success or failure
as all other helpers do.
Makes it clear that X* functions are in charge of deciding which CMD_* value
they return to main edting loop. Reduces unnecessary copying/restoring of
original partition information.
No intentional functional change.
kn [Sat, 17 Jul 2021 03:31:31 +0000 (03:31 +0000)]
Ignore unwind socket with kevent(2) under SMALL
All other unwind related bits are under #ifndef SMALL already,
so complete that.
OK florian
djm [Sat, 17 Jul 2021 00:38:11 +0000 (00:38 +0000)]
wrap some long lines
djm [Sat, 17 Jul 2021 00:36:53 +0000 (00:36 +0000)]
fix sftp on ControlPersist connections, broken by recent SessionType
change; spotted by sthen@
jsg [Sat, 17 Jul 2021 00:02:58 +0000 (00:02 +0000)]
sync
jsg [Fri, 16 Jul 2021 23:51:38 +0000 (23:51 +0000)]
drm/amdgpu: add another Renoir DID
From Jinzhou Su
775da83005cb61d4c213c636df9337da05714ff1 in mainline linux
jsg [Fri, 16 Jul 2021 23:47:58 +0000 (23:47 +0000)]
amdgpu: Add Missing Sienna Cichlid DID
From Ori Messinger
d26bbbcc160f6d9feabed73dca62b9e8b86671b4 in mainline linux
krw [Fri, 16 Jul 2021 22:50:43 +0000 (22:50 +0000)]
Change PRT_protected_guid() to take native order uuid's instead of little endian
uuid's. This brings it into line with all the other PRT_ functions taking uuid
parameters.
While adapting gsetid(), introduce separate partition type and partition guid
variables to make the logic clearer.
No intentional functional change.
dv [Fri, 16 Jul 2021 16:21:22 +0000 (16:21 +0000)]
vmd(8): simplify vcpu logic, removing uart & vionet reads
Remove legacy state handling on the ns8250 and virtio network devices
originally put in place before using libevent for async device
events. The vcpu thread doesn't need to process device data as it is
handled by the libevent thread.
This has the benefit of simplifying some of the message passing
between threads introduced to the ns8250 uart since both the vcpu
and libevent threads were processing read events.
No functional change intended. Tested by many, including abieber@,
weerd@, Mischa Peters, and Matthias Schmidt. (Thanks.)
OK mlarkin@
deraadt [Fri, 16 Jul 2021 15:26:24 +0000 (15:26 +0000)]
this media can also use dhcpleased now
florian [Fri, 16 Jul 2021 15:25:31 +0000 (15:25 +0000)]
Switch from dhclient to dhcpleased in the installer.
More cleanup is needed from a real ksh hacker, but looks already
pretty good to kn.
OK deraadt
florian [Fri, 16 Jul 2021 15:24:44 +0000 (15:24 +0000)]
Create working directories earlier so that resolvd can write
resolv.conf.shadow and start dhcpleased/resolvd.
OK deraadt
florian [Fri, 16 Jul 2021 15:24:08 +0000 (15:24 +0000)]
Replace dhclient with dhcpleased/resolvd on the ramdisk.
OK deraadt who also helped making some space.
florian [Fri, 16 Jul 2021 15:22:43 +0000 (15:22 +0000)]
create lease directory for dhcpleased in the ramdisk
OK deraadt
florian [Fri, 16 Jul 2021 15:22:12 +0000 (15:22 +0000)]
The installer plays weird tricks with /etc/resolv.conf and symlinks it
from /tmp/i. Work around this in resolvd so that it can correctly
update the file until this is fixed in install.sub.
probably grudgingly OK deraadt
florian [Fri, 16 Jul 2021 15:21:41 +0000 (15:21 +0000)]
switch to dhcpleased/resolvd in base
OK deraadt
bluhm [Fri, 16 Jul 2021 15:08:39 +0000 (15:08 +0000)]
Improve comments in IPsec replay window calculation.
OK tobhe@
sthen [Fri, 16 Jul 2021 15:05:58 +0000 (15:05 +0000)]
Update the default block size in the manual, in sndiod.c r1.37 it was
reduced to 480 frames. ok ratchov@
mestre [Fri, 16 Jul 2021 14:36:09 +0000 (14:36 +0000)]
main proc doesn't speak with sockets during the main loop and setpriority plus
chroot (and privdrop) in the child procs at this point are all set and done so
pledge("inet id") promises are not required anymore.
analysis and OK @kn
mestre [Fri, 16 Jul 2021 14:34:37 +0000 (14:34 +0000)]
/etc/ssl/cert.pem is loaded into mem with tls_load_file(3) on local function
priv_constraint_child() which is called before we reach pledge(2), therefore we
we don't need to unveil(2) that file nor having pledge("rpath") since it was
only required to read that same file.
OK kn@
kn [Fri, 16 Jul 2021 13:59:10 +0000 (13:59 +0000)]
Remove unneeded call to tls_init(3)
As per the manual and lib/libtls/tls.c revision 1.79 from 2018
"Automatically handle library initialisation for libtls." initialisation
is handled automatically by other tls_*(3) functions.
Remove the tls_init() call to not give the impression of it being needed.
Feedback tb
OK Tests mestre
krw [Fri, 16 Jul 2021 13:29:49 +0000 (13:29 +0000)]
Compare pointer to NULL, not 0.
krw [Fri, 16 Jul 2021 13:26:04 +0000 (13:26 +0000)]
Be consistent and always return -1 to indicate failure.
DISK_printgeometry() return value was always 0 and never
checked so just make it void.
No functional change.
jsg [Fri, 16 Jul 2021 13:09:18 +0000 (13:09 +0000)]
regen
jsg [Fri, 16 Jul 2021 13:08:24 +0000 (13:08 +0000)]
add some x570 ppbs and another navi 23
jsg [Fri, 16 Jul 2021 09:14:17 +0000 (09:14 +0000)]
recognise more pci capabilities
from PCI Code and ID Assignment Specification
djm [Fri, 16 Jul 2021 09:00:23 +0000 (09:00 +0000)]
Explicitly check for and start time-based rekeying in the client
and server mainloops.
Previously the rekey timeout could expire but rekeying would not start
until a packet was sent or received. This could cause us to spin in
select() on the rekey timeout if the connection was quiet.
ok markus@
claudio [Fri, 16 Jul 2021 07:59:38 +0000 (07:59 +0000)]
Remove the unveil current directory pointer from struct process. Instead
pass in the vnode to unveil_start_relative() like it is done for *at()
syscalls. This fixes an issue with fchdir() that actually did not correctly
reset this pointer when changing the working directory.
OK beck@
krw [Thu, 15 Jul 2021 23:25:46 +0000 (23:25 +0000)]
Nuke unused variable.
krw [Thu, 15 Jul 2021 21:58:02 +0000 (21:58 +0000)]
No need for separate b_sectors, b_offset and b_type variables. We have struct
prt to hold this info in one place.
Construct a struct prt to hold the boot partition information and stash it in
the struct disk for both MBR and GPT to access as needed.
Move the blocks to sectors conversions into DISK_open() with all of its
geometry friends.
No intentional functional change.
krw [Thu, 15 Jul 2021 21:23:54 +0000 (21:23 +0000)]
Consolidate disk geometry fiddling, turning -l/-c/-h/-s values into MBR
partition geometry info, into DISK_open(). Resulting in clearer logic.
No intentional functional change.
deraadt [Thu, 15 Jul 2021 15:37:55 +0000 (15:37 +0000)]
more space savings
deraadt [Thu, 15 Jul 2021 15:33:47 +0000 (15:33 +0000)]
space savings on install kernels. (restore and ralink drivers+firmware go
away)
inoguchi [Thu, 15 Jul 2021 12:41:49 +0000 (12:41 +0000)]
Wrap over 80 long lines in ca.c
inoguchi [Thu, 15 Jul 2021 11:43:27 +0000 (11:43 +0000)]
Explicitly check pointer variable if it is NULL or not in ca.c
job [Thu, 15 Jul 2021 11:07:33 +0000 (11:07 +0000)]
Fix regress for rpki-client
spotted by bluhm
inoguchi [Thu, 15 Jul 2021 10:26:43 +0000 (10:26 +0000)]
Remove space between '*' and pointer variable in ca.c
inoguchi [Thu, 15 Jul 2021 10:15:22 +0000 (10:15 +0000)]
Use 'serial' rather than 'ser' in ca.c
input from jsing@
inoguchi [Thu, 15 Jul 2021 09:56:32 +0000 (09:56 +0000)]
Convert openssl(1) ca option handling
New option handling for openssl(1) ca.
This diff is just replacing with new option handling, no functional change.
I'm using the word DN or RDN in description as manual uses them, rather than
replacing with "Distinguished Name" or "Relative Distinguished Name".
I would like to add another fixes below by follow-up diffs.
- remove space between '*' and pointer variable
- wrap 80+ long lines
- explicitly check pointer variable if it is NULL or not
comments and ok from jsing@
claudio [Thu, 15 Jul 2021 06:57:02 +0000 (06:57 +0000)]
UNVEIL_INSPECT is no longer needed, adjust code accordingly.
OK semarie@
jsg [Thu, 15 Jul 2021 01:24:07 +0000 (01:24 +0000)]
drm/amd/dc: Fix a missing check bug in dm_dp_mst_detect()
From Yingjie Wang
5885fce7b43919406b32d1c942c9b496aac3abbc in linux 5.10.y/5.10.50
655c0ed19772d92c9665ed08bdc5202acc096dda in mainline linux
jsg [Thu, 15 Jul 2021 01:20:28 +0000 (01:20 +0000)]
drm/bridge: Fix the stop condition of drm_bridge_chain_pre_enable()
From Douglas Anderson
0cd39c96574d19e234cee971868c82c3769c2ee6 in linux 5.10.y/5.10.50
bab5cca7e609952b069a550e39fe4893149fb658 in mainline linux
tobhe [Wed, 14 Jul 2021 22:39:26 +0000 (22:39 +0000)]
Export SA replay counters via pfkey and print with ipsecctl.
This is useful for debugging replay window issues with 64 bit
sequence numbers in IPsec.
ok bluhm@
bluhm [Wed, 14 Jul 2021 22:09:24 +0000 (22:09 +0000)]
After VFS shutdown, init(8) cannot map a missing page that contains
the signal handler code. Traditionally a process would spin in
such a case, but we changed the logic in revision 1.167 trapsignal()
to receive a fatal signal. If that happens to init(8), the kernel
panics. In case of reboot, jump between init signal handler and
page fault trap until the kernel resets the machine.
reported and tested weerd@; OK deraadt@
bluhm [Wed, 14 Jul 2021 21:07:36 +0000 (21:07 +0000)]
Resend the TCP packet only if the MTU locked flag appears at the
route and was not there before. This should prevent a recursion
in path MTU discovery with TCP over IPsec.
reported and tested Matthias Schmidt; tested and OK tobhe@
bluhm [Wed, 14 Jul 2021 18:23:11 +0000 (18:23 +0000)]
Shrink cluster size for FAT32 to fullfil the new minimum cluster
limit of newfs_msdos for our small 64 MB vnd disk image.
suggested by jsg@
bluhm [Wed, 14 Jul 2021 17:58:51 +0000 (17:58 +0000)]
LibreSSL error message has changed, adapt test.
kn [Wed, 14 Jul 2021 13:33:57 +0000 (13:33 +0000)]
Remove unneeded calls to tls_init(3)
As per the manual and lib/libtls/tls.c revision 1.79 from 2018
"Automatically handle library initialisation for libtls." initialisation
is handled automatically by other tls_*(3) functions.
Remove explicit tls_init() calls from base to not give the impression of
it being needed.
Feedback tb
OK Tests mestre
claudio [Wed, 14 Jul 2021 11:14:27 +0000 (11:14 +0000)]
Restructure the getopt_long options. Sort them mostly by name with the
exception of no-xyz options that are grouped with the coresponding xyz
option. Fix --no-motd to use the internal flag setting of getopt_long.
Also use some defines instead of numbers for pure long options that
need special handling.
OK benno@
jsg [Wed, 14 Jul 2021 09:56:17 +0000 (09:56 +0000)]
timeout_add() always sets a new expiry time unrelated to the previous
one and requeues as needed so no need to call timeout_del() before
timeout_add()
spotted by kettenis@
nicm [Wed, 14 Jul 2021 08:56:00 +0000 (08:56 +0000)]
Move default value for TERM into tmux.h.
jmc [Wed, 14 Jul 2021 06:46:38 +0000 (06:46 +0000)]
reorder SessionType; ok djm
jsg [Wed, 14 Jul 2021 05:42:47 +0000 (05:42 +0000)]
When mod_timer() is called with a value less than or equal to the
current number of jiffies delete the timeout and reschedule for the next
tick. Avoids timeout_add() failing the ticks >= 0 assertion when
mod_timer() is called from i915_utils.c set_timer_ms().
Reported and earlier version tested by Tom Murphy on Kaby Lake R.
anton [Wed, 14 Jul 2021 05:04:08 +0000 (05:04 +0000)]
Adjust expected certificate error message. Caused by recent work to support
partial chains in libcrypto.
ok bluhm@
daniel [Wed, 14 Jul 2021 01:11:13 +0000 (01:11 +0000)]
fix "logically dead code" flagged by coverity
It looks like twe was refactored in 2011 and one error check was missed.
While the device may no longer be widely used, this helps reduce the
coverity alert count.
CID
1453371
ok krw@
djm [Tue, 13 Jul 2021 23:48:36 +0000 (23:48 +0000)]
add a SessionType directive to ssh_config, allowing the configuration
file to offer equivalent control to the -N (no session) and -s
(subsystem) command-line flags.
Part of GHPR#231 by Volker Diels-Grabsch with some minor tweaks;
feedback and ok dtucker@
krw [Tue, 13 Jul 2021 22:10:20 +0000 (22:10 +0000)]
No need to manually reinvent nitems() 5 times to scan part_types.
No functional change.
nicm [Tue, 13 Jul 2021 22:09:29 +0000 (22:09 +0000)]
Give #() commands a one second grace period where the output is empty
before telling the user they aren't doing anything. GitHub issue 2774.
patrick [Tue, 13 Jul 2021 22:08:50 +0000 (22:08 +0000)]
Ensure that we don't overrun the TX FIFO for longer transfers. Check
the limit after every character, and wait for the FIFO to empty before
sending out more bytes. With this I can now use ipmitool(1) to change
IPMI passwords on the Ampere eMAG.
ok kettenis@
tb [Tue, 13 Jul 2021 19:28:05 +0000 (19:28 +0000)]
Beauharnios -> Beauharnois
job [Tue, 13 Jul 2021 18:39:39 +0000 (18:39 +0000)]
Add more checks for eContent 'version' fields.
Input from deraadt@, tb@, claudio@
OK deraadt@ claudio@ tb@
mvs [Tue, 13 Jul 2021 17:50:19 +0000 (17:50 +0000)]
Fix TIMEOUT_INITIALIZER_{FLAGS,KCLOCK}() macro.
ok cheloha@
deraadt [Tue, 13 Jul 2021 16:49:32 +0000 (16:49 +0000)]
modernize province abbreviations
deraadt [Tue, 13 Jul 2021 15:32:59 +0000 (15:32 +0000)]
update canadian area codes according to cnac.ca
krw [Tue, 13 Jul 2021 15:03:34 +0000 (15:03 +0000)]
Disk sector addresses are normally stored/provided in uint64_t
variables/parameters, not off_t.
Adjust various parameters and variables accordingly. A few missed const's
and verbiage tweaks in passing.
No functional change.
deraadt [Tue, 13 Jul 2021 13:18:03 +0000 (13:18 +0000)]
sync
krw [Tue, 13 Jul 2021 11:18:25 +0000 (11:18 +0000)]
Replace a stray use of letoh64() on gh_part_num and
gh_part_size, which are uint32_t fields, with letoh32().
nicm [Tue, 13 Jul 2021 10:38:57 +0000 (10:38 +0000)]
Only use client for sizing when not detached, GitHub issue 2772.
claudio [Tue, 13 Jul 2021 08:44:18 +0000 (08:44 +0000)]
Order the MRT table dump versions by preference also the text refers
to the latter two (table-mp and table) to be only available for
compatibility. People should really only use table-v2 since it is
the only method which will properly dump everything.
mvs [Tue, 13 Jul 2021 08:16:17 +0000 (08:16 +0000)]
Remove unused `PolicyHead' from 'sockaddr_encap' structure.
ok tobhe@
visa [Tue, 13 Jul 2021 07:37:50 +0000 (07:37 +0000)]
Add f_modify and f_process callbacks to FIFO filterops.
OK millert@ mpi@
krw [Mon, 12 Jul 2021 22:18:54 +0000 (22:18 +0000)]
Toss 'const' in anywhere the compiler doesn't complain about, thus identifying
places that *should* be const but currently aren't and preventing the rot from
spreading further while those issues are dealt with.
No functional change.
matthieu [Mon, 12 Jul 2021 19:11:42 +0000 (19:11 +0000)]
Add uaudio(4) and umidi(4). ok kettenis@, mlarkin@
krw [Mon, 12 Jul 2021 18:31:53 +0000 (18:31 +0000)]
Final batch of struct field name tweaks. 'cmd_' for cmd, ut_' for
unit_types, 'pt_' for part_type, 'pg_' for protected_guid.
No functional change.
schwarze [Mon, 12 Jul 2021 15:56:54 +0000 (15:56 +0000)]
new manual page X509_print_ex(3)
beck [Mon, 12 Jul 2021 15:12:38 +0000 (15:12 +0000)]
Use the x509_verify_cert_cache_extensions fuction instead of manually
calling the OpenSSL legacy cache extensions goo.
Requested by tb@
ok tb@
beck [Mon, 12 Jul 2021 15:09:18 +0000 (15:09 +0000)]
Change the error reporting pattern throughout the tree when unveil
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.
Work done and verified by Ashton Fagg <ashton@fagg.id.au>
ok deraadt@ semarie@ claudio@
schwarze [Mon, 12 Jul 2021 14:54:00 +0000 (14:54 +0000)]
document X509V3_extensions_print(3)
krw [Mon, 12 Jul 2021 14:06:19 +0000 (14:06 +0000)]
Add 'dk_' prefix to struct disk field names.
No functional change.
daniel [Mon, 12 Jul 2021 12:24:41 +0000 (12:24 +0000)]
fix "evaluation order violation" flagged by coverity
Coverity flagged the self-assignment introduced in the previous commit.
This is CID
1505120.
ok kevlo@
schwarze [Mon, 12 Jul 2021 11:47:01 +0000 (11:47 +0000)]
document X509V3_EXT_print(3)
visa [Mon, 12 Jul 2021 09:32:37 +0000 (09:32 +0000)]
Remember to set CPUF_RUNNING on secondary CPUs.
visa [Mon, 12 Jul 2021 09:29:18 +0000 (09:29 +0000)]
Make hw_cpu_hatch() more similar on loongson and octeon.
dtucker [Mon, 12 Jul 2021 06:22:57 +0000 (06:22 +0000)]
Make limit for time_t test unconditional in the format_absolute_time
fix for bz#3329 that allows printing of timestamps past INT_MAX.
This was incorrectly included with the previous commit. Based on
discussion with djm@.
dtucker [Mon, 12 Jul 2021 06:08:57 +0000 (06:08 +0000)]
Use existing format_absolute_time() function when printing cert validity
instead of doing it inline. Part of bz#3329.
jsg [Mon, 12 Jul 2021 06:07:33 +0000 (06:07 +0000)]
wrap a long line
djm [Mon, 12 Jul 2021 02:12:22 +0000 (02:12 +0000)]
fix some broken tests; clean up output