claudio [Mon, 16 Jul 2018 07:56:04 +0000 (07:56 +0000)]
rtadvd is only interested in IPv6 so limit route socket to AF_INET6.
OK florian@
mpi [Mon, 16 Jul 2018 07:49:31 +0000 (07:49 +0000)]
Fix for uninitialized variables.
Found by and ok jsg@, ok markus@
mpi [Mon, 16 Jul 2018 07:48:17 +0000 (07:48 +0000)]
typos, from Michael W. Bombardieri.
djm [Mon, 16 Jul 2018 07:06:50 +0000 (07:06 +0000)]
keep options.identity_file_userprovided array in sync when we load
keys, fixing some spurious error messages; ok markus
djm [Mon, 16 Jul 2018 03:09:59 +0000 (03:09 +0000)]
memleak in unittest; found by valgrind
djm [Mon, 16 Jul 2018 03:09:13 +0000 (03:09 +0000)]
memleaks; found by valgrind
ccardenas [Sun, 15 Jul 2018 20:25:52 +0000 (20:25 +0000)]
vioscsi driver has been stable enough so we can move a good portion of these
log_debug messages to be DPRINTF (compile time).
Prompted by reyk@.
Ok reyk@.
tb [Sun, 15 Jul 2018 18:22:57 +0000 (18:22 +0000)]
re-commit the removal of the EC_POINTs_mul() regression tests with num > 1
fcambus [Sun, 15 Jul 2018 18:04:37 +0000 (18:04 +0000)]
Document xcrypt in the amd64 version of cpu.4.
Bits taken from the i386 version.
OK jmc@
tb [Sun, 15 Jul 2018 16:27:39 +0000 (16:27 +0000)]
recommit label indentation part of the backout; clearly unrelated to the
breakage.
reyk [Sun, 15 Jul 2018 14:42:04 +0000 (14:42 +0000)]
Revert unrelated change to vioscsi.c
(I had this in my tree to silence vioscsi.c log_debug, but Carlos
already has a better diff for that)
reyk [Sun, 15 Jul 2018 14:36:54 +0000 (14:36 +0000)]
Track resources and enforce cpu/memory/interface limits for non-root users.
The limits are currently hard-coded and undocumented (4 CPUs/VMs, 2G
memory, 8 interfaces) but will be configurable in an upcoming diff.
These limits are tracked in total usage; for example, a user will be
able to run up to 4 VMs with 512M of memory or a single VM with 2G.
OK ccardenas@ mlarkin@
beck [Sun, 15 Jul 2018 12:44:09 +0000 (12:44 +0000)]
Restore correct behaviour to pledge for access and stat, which was broken
by the unveil diff. Noticed at, and diff from semarie@
jmc [Sun, 15 Jul 2018 11:35:57 +0000 (11:35 +0000)]
tweak previous;
phessler [Sun, 15 Jul 2018 10:46:48 +0000 (10:46 +0000)]
adjust the example hostname.if to show "wpakey" on the same line as "nwid",
and provide an IPv6 autoconf example.
while here, split interface settings from IP assignment.
OK jmc@
phessler [Sun, 15 Jul 2018 10:44:49 +0000 (10:44 +0000)]
adjust hostname.if examples to show "wpakey" on the same line as "nwid"
OK jmc@
florian [Sun, 15 Jul 2018 09:28:21 +0000 (09:28 +0000)]
Implement RFC 8106: IPv6 Router Advertisement Options for DNS
Configuration.
florian [Sun, 15 Jul 2018 09:27:02 +0000 (09:27 +0000)]
mark up managed / other configuration
florian [Sun, 15 Jul 2018 09:26:26 +0000 (09:26 +0000)]
It's a packet, not package.
florian [Sun, 15 Jul 2018 09:25:41 +0000 (09:25 +0000)]
nuke newd leftover
gilles [Sun, 15 Jul 2018 08:49:12 +0000 (08:49 +0000)]
remove unused variable
nicm [Sun, 15 Jul 2018 06:57:13 +0000 (06:57 +0000)]
Fix new-window -k, GitHub issue 1403.
tb [Sun, 15 Jul 2018 06:03:31 +0000 (06:03 +0000)]
$OpenBSD$
tb [Sun, 15 Jul 2018 06:02:42 +0000 (06:02 +0000)]
Also revert regression tests so that EC_POINTs_mul() with longer vectors
gets exercised again.
jsg [Sun, 15 Jul 2018 05:38:48 +0000 (05:38 +0000)]
back out ecc constant time changes
after the constant time commits various regress tests started failing
on sparc64 ssh t9, libcrypto ec ecdh ecdsa and trying to ssh out
resulted in 'invalid elliptic curve value'
ok tb@
joris [Sat, 14 Jul 2018 21:28:02 +0000 (21:28 +0000)]
don't run cvs_client_sendfile() if its file_type is CVS_DIR, but do not
depend on it being CVS_FILE explicitly.
unbreaks remote operations on removed files.
benno [Sat, 14 Jul 2018 13:38:48 +0000 (13:38 +0000)]
Document that route monitor also takes -T rtable as an argument.
benno [Sat, 14 Jul 2018 13:37:44 +0000 (13:37 +0000)]
Make route monitor display changes in all routing domains by forcing
the route filter to set RTABLE_ANY. Previously only the routing
table/rdomain of the route process was displayed (that being the
kernel default).
ok kn@ claudio@ and henning@
benno [Sat, 14 Jul 2018 12:32:35 +0000 (12:32 +0000)]
get rid of two more implicit ktable_get with rdomain 0.
should not change anything when run in rdomain 0.
ok henning@ phessler@ claudio@
jsg [Sat, 14 Jul 2018 10:21:48 +0000 (10:21 +0000)]
Don't pass an uninitialised size value to free(9). Pointer argument is
NULL in this path so free will return early without accessing it.
ok jca@ tb@
kn [Sat, 14 Jul 2018 10:02:24 +0000 (10:02 +0000)]
Remove mention of old man directory
OK espie
jsg [Sat, 14 Jul 2018 09:07:27 +0000 (09:07 +0000)]
sync
jmc [Sat, 14 Jul 2018 07:40:17 +0000 (07:40 +0000)]
.El should have been zapped too;
espie [Sat, 14 Jul 2018 07:07:26 +0000 (07:07 +0000)]
zap network configuration section, it's a level of tinkering that's
not really supported.
add another ref to PORTS_PRIVSEP here, as it is really a good idea.
bentley [Fri, 13 Jul 2018 20:06:10 +0000 (20:06 +0000)]
Remove cscope leftover and a stray comma.
From "kshe" on tech@.
cheloha [Fri, 13 Jul 2018 18:36:56 +0000 (18:36 +0000)]
openssl app timers: TM_START -> TM_RESET, TM_STOP -> TM_GET
Much more apt than the current operation names.
Names suggested by jca@ ages ago.
ok jca, jsing
jmc [Fri, 13 Jul 2018 17:48:30 +0000 (17:48 +0000)]
tweak previous; ok reyk
mestre [Fri, 13 Jul 2018 17:18:34 +0000 (17:18 +0000)]
Correct some typos and also ran it through mandoc -Tlint
OK millert@ deraadt@ and jmc@ who also gave me a cluebat stick
cheloha [Fri, 13 Jul 2018 16:59:46 +0000 (16:59 +0000)]
Add & update author credits for Mary Ann Horton.
Add credits for leave(1) and w(1); update credit for script(1).
Supported by the Spinellis repo and CSRG SCCS logs.
ok brynet millert jca jmc schwarze
anton [Fri, 13 Jul 2018 15:18:59 +0000 (15:18 +0000)]
network -> interface; ok reyk@
jsg [Fri, 13 Jul 2018 15:02:40 +0000 (15:02 +0000)]
explicitly link libm for sqrt()/fmax() calls added in bgpctl.c rev 1.204
jsg [Fri, 13 Jul 2018 13:47:41 +0000 (13:47 +0000)]
unbreak gcc4 build
reyk [Fri, 13 Jul 2018 10:26:57 +0000 (10:26 +0000)]
Check the disk/kernel/cdrom file permissions after openening the fd.
This prevents time of TOCTOU attacks for instances.
OK mlarkin@
beck [Fri, 13 Jul 2018 09:36:00 +0000 (09:36 +0000)]
Make the default failure for unveil while disabled return success
so that people don't get screwed when playing with it on their
machines
deraadt [Fri, 13 Jul 2018 09:28:07 +0000 (09:28 +0000)]
sync
beck [Fri, 13 Jul 2018 09:27:07 +0000 (09:27 +0000)]
Crank minor for unveil
ok deraadt@
beck [Fri, 13 Jul 2018 09:25:22 +0000 (09:25 +0000)]
Unveiling unveil(2).
This brings unveil into the tree, disabled by default - Currently
this will return EPERM on all attempts to use it until we are
fully certain it is ready for people to start using, but this
now allows for others to do more tweaking and experimentation.
Still needs to send the unveil's across forks and execs before
fully enabling.
Many thanks to robert@ and deraadt@ for extensive testing.
ok deraadt@
schwarze [Fri, 13 Jul 2018 09:19:42 +0000 (09:19 +0000)]
no longer interpret 0.192.168.4 in hosts(5) as 192.168.4/24
OK phessler@ claudio@ benno@ kn@
"steh' nicht rum, committe das" henning@
florian [Fri, 13 Jul 2018 09:16:50 +0000 (09:16 +0000)]
Monitor the route socket and regenerate the list of interfaces and
messages to send when an interface shows up or disappears or
and address shows up or disappears.
florian [Fri, 13 Jul 2018 09:16:15 +0000 (09:16 +0000)]
add missing IMSG_STARTUP; unclear why this ever worked
kn [Fri, 13 Jul 2018 09:06:58 +0000 (09:06 +0000)]
Use "rtable" not "tableid" as argument name for rtable
Make rtable(4) usage documentation consistent with other programs.
This is to have `man -k ar~rtable' show the full list without having to
look for other variations of the same argument type.
OK bluhm
krw [Fri, 13 Jul 2018 09:03:44 +0000 (09:03 +0000)]
Unused variables.
ok henning@
krw [Fri, 13 Jul 2018 09:02:07 +0000 (09:02 +0000)]
Unused variable.
ok martijn@ henning@
beck [Fri, 13 Jul 2018 08:59:02 +0000 (08:59 +0000)]
tests for next steps in unveil
bluhm [Fri, 13 Jul 2018 08:51:15 +0000 (08:51 +0000)]
Some USB network interfaces like rum(4) report ENXIO from their
ioctl function after the device has been pulled out. Also accept
this error code in bpf_detachd() to prevent a kernel panic. tcpdump(8)
may run while the interface is detached.
from Moritz Buhl; OK stsp@
krw [Fri, 13 Jul 2018 08:51:14 +0000 (08:51 +0000)]
Unused variables.
ok halex@
rob [Fri, 13 Jul 2018 08:50:38 +0000 (08:50 +0000)]
Fix some comments referencing sockets which are not used by the ber api. The
api uses read and write buffers (byte streams) that are utilized by calling
applications which may or may not use sockets.
ok claudio@
buffer byte streams that applications then use for
kettenis [Fri, 13 Jul 2018 08:46:07 +0000 (08:46 +0000)]
When we nack a domain service because we don't support the requested major
version, provide a major version that we do support.
tb [Fri, 13 Jul 2018 08:43:31 +0000 (08:43 +0000)]
Eliminate the weird condition in the BN_swap_ct() API that at most one bit
be set in condition. This makes the constant time bit-twiddling a bit
trickier, but it's not too bad. Thanks to halex for an extensive rubber
ducking session over a non-spicy spicy tabouleh falafel..
ok jsing, kn
reyk [Fri, 13 Jul 2018 08:42:49 +0000 (08:42 +0000)]
Add "allow instance" option.
This allows users to create VM instances and change desired options,
for example a user can be allowed to run a VM with all the
pre-configured options but specify an own disk image.
(mlarkin@ was fine with iterating over it)
OK ccardenas@
krw [Fri, 13 Jul 2018 08:41:32 +0000 (08:41 +0000)]
Unused variables.
ok henning@ phessler@
kn [Fri, 13 Jul 2018 08:41:15 +0000 (08:41 +0000)]
Fix regression on child queue definitions
I comitted the wrong diff in 1.680 which turned `queue cq parent pq ...'
into invalid syntax by changing `interface' to `ON if_item'.
Found by bket, thanks!
krw [Fri, 13 Jul 2018 08:39:33 +0000 (08:39 +0000)]
Unused variable.
ok deraadt@
florian [Fri, 13 Jul 2018 08:32:10 +0000 (08:32 +0000)]
pass control socket in from main
florian [Fri, 13 Jul 2018 08:31:34 +0000 (08:31 +0000)]
pass in route socket from main; stub out handling for now
sf [Fri, 13 Jul 2018 08:30:34 +0000 (08:30 +0000)]
Disable codepatching infrastructure after boot
This way, it is not available for use in ROP attacks. This diff puts the
codepatching code into a separate section and unmaps that section after boot.
In the future, the memory could potentially be reused but that would require
larger changes.
ok pguenther@
rob [Fri, 13 Jul 2018 08:30:10 +0000 (08:30 +0000)]
Fix loop condition in ber.c. Discussed with claudio.
ok claudio@, jca@
claudio [Fri, 13 Jul 2018 08:18:11 +0000 (08:18 +0000)]
Move aspath_verify() and aspath_inflate() into util.c so bgpctl can use them.
With this it gets a bit easier to parse MRT update messages in bgpctl.
OK benno@ phessler@
deraadt [Fri, 13 Jul 2018 08:10:56 +0000 (08:10 +0000)]
repair inconsistancies
deraadt [Fri, 13 Jul 2018 08:10:45 +0000 (08:10 +0000)]
repair inconsistancies
espie [Fri, 13 Jul 2018 08:09:34 +0000 (08:09 +0000)]
byebye MASTER_SITE_OVERRIDE, we won't miss you
florian [Fri, 13 Jul 2018 08:08:11 +0000 (08:08 +0000)]
Explain what the example is doing.
Prompted by, tweak & OK jmc
kettenis [Fri, 13 Jul 2018 07:29:08 +0000 (07:29 +0000)]
Check protocol version number before sending an ack indicating that we
support a domain services protocol.
phessler [Fri, 13 Jul 2018 07:22:55 +0000 (07:22 +0000)]
Some more checks before auto-join switches networks.
Make sure all of the crypto options the AP announces matches what we
would configure. While here, don't switch if the user has specified
a specific BSSID, and the new AP does not match.
OK stsp@
florian [Fri, 13 Jul 2018 06:56:59 +0000 (06:56 +0000)]
add rad.conf; from semarie; tweak & OK tb
guenther [Fri, 13 Jul 2018 05:56:57 +0000 (05:56 +0000)]
Use _ALIGN_TRAPS instead of _ALIGN_TEXT where nops aren't needed.
ok deraadt@
jmc [Fri, 13 Jul 2018 05:25:29 +0000 (05:25 +0000)]
various tweaks; ok florian
tb [Fri, 13 Jul 2018 05:25:24 +0000 (05:25 +0000)]
zap some garbage that snuck in.
spotted by kevlo
jmc [Fri, 13 Jul 2018 05:22:34 +0000 (05:22 +0000)]
- differentiate between join and nwid
- remove some duplication between them
- document -join
- sort
ok phessler
djm [Fri, 13 Jul 2018 02:13:50 +0000 (02:13 +0000)]
make this use ssh_proxy rather than starting/stopping a daemon for
each testcase
djm [Fri, 13 Jul 2018 02:13:19 +0000 (02:13 +0000)]
fix leaks in unit test; with this, all unit tests are leak free
(as far as valgrind can spot anyway)
deraadt [Thu, 12 Jul 2018 22:09:04 +0000 (22:09 +0000)]
we will be toggling witness on/off a few times. when it is on, it raises
awareness of problems. when it is off, development cycles are faster.
let's do the faster cycle for a little while.
discussion with naddy
deraadt [Thu, 12 Jul 2018 22:07:57 +0000 (22:07 +0000)]
sync
benno [Thu, 12 Jul 2018 21:45:37 +0000 (21:45 +0000)]
store and print the rdomain of the interfaces we see.
ok phessler@ henning@
henning [Thu, 12 Jul 2018 19:31:05 +0000 (19:31 +0000)]
if we couldn't update the clock for ~1h due to lack of data from peers and
sensors, mark us unsynced again. ok reyk krw, pt out / discussion / help naddy
jmc [Thu, 12 Jul 2018 18:45:13 +0000 (18:45 +0000)]
missing .Ek;
krw [Thu, 12 Jul 2018 16:59:59 +0000 (16:59 +0000)]
Cleanup and clarify getuint64() by using the
same functions as auto-allocation. parse_sizespec()
and apply_unit(). No intentional functional
change.
Looked good to tb@
krw [Thu, 12 Jul 2018 16:53:09 +0000 (16:53 +0000)]
Cleanup and clarify the has_overlap() logic so it can be read by
normal people and is more efficient to boot.
The only intentional functional change was to use mergesort()
instead of heapsort() so that partitions with the same offset
retain their order in the emitted verbiage.
Looked good to tb@, ok kn@
florian [Thu, 12 Jul 2018 16:08:02 +0000 (16:08 +0000)]
RTM_CHGADDRATTR for route monitor
OK phessler, benno, claudio
florian [Thu, 12 Jul 2018 16:07:35 +0000 (16:07 +0000)]
Introduce RTM_CHGADDRATTR to inform userland on the route socket when
an attribute of an address is changed.
For now it's used when IPv6 duplicate address detection finishes.
With this slaacd(8) can find out if a configured address is not
duplicated without the need to poll.
OK phessler, benno, claudio
mpi [Thu, 12 Jul 2018 15:51:50 +0000 (15:51 +0000)]
Introduce ipsec_output_cb() to merge duplicate code and account for
dropped packets in the output path.
While here fix a memory leak when compression is not needed w/ IPcomp.
ok markus@
mlarkin [Thu, 12 Jul 2018 15:48:02 +0000 (15:48 +0000)]
unbreak i386 build, thanks to pd@ for noticing. Same diff as I committed
earlier for amd64
mlarkin [Thu, 12 Jul 2018 15:13:33 +0000 (15:13 +0000)]
zap an extra newline
reyk [Thu, 12 Jul 2018 14:53:37 +0000 (14:53 +0000)]
The vmctl start -I option was changed to -t.
I committed the manpage but accidentally forgot the main.c part.
OK ccardenas@
kettenis [Thu, 12 Jul 2018 14:46:45 +0000 (14:46 +0000)]
Add a function to delete all nodes with a specific name.
Add a function to determine the size of a machine description.
sashan [Thu, 12 Jul 2018 14:28:07 +0000 (14:28 +0000)]
trade few 'goto unlock: for 'break' in pf_test()
OK mpi@, OK henning@, OK jca@
guenther [Thu, 12 Jul 2018 14:24:54 +0000 (14:24 +0000)]
Unbreak the nmi handler (again): I placed INTR_CLEAR_GPRS in the wrong
place and GS.base was horked on return. Also, the frame passed to ddb
didn't have the %rbp<-->tf_err swap, which would have confused backtraces.
Now if we can just come up with a way to automate testing the NMI handler
with qemu...
sashan [Thu, 12 Jul 2018 14:22:54 +0000 (14:22 +0000)]
- introducing _Q_INVALID to sys/queue.h
OK @bluhm, OK @otto, OK @guenther
guenther [Thu, 12 Jul 2018 14:11:11 +0000 (14:11 +0000)]
Reorganize the Meltdown entry and exit trampolines for syscall and
traps so that the "mov %rax,%cr3" is followed by an infinite loop
which is avoided because the mapping of the code being executed is
changed. This means the sysretq/iretq isn't even present in that
flow of instructions in the kernel mapping, so userspace code can't
be speculatively reached on the kernel mapping and totally eliminates
the conditional jump over the the %cr3 change that supported CPUs
without the Meltdown vulnerability. The return paths were probably
vulnerable to Spectre v1 (and v1.1/1.2) style attacks, speculatively
executing user code post-system-call with the kernel mappings, thus
creating cache/TLB/etc side-effects.
Would like to apply this technique to the interrupt stubs too, but
I'm hitting a bug in clang's assembler which misaligns the code and
symbols.
While here, when on a CPU not vulnerable to Meltdown, codepatch out
the unnecessary bits in cpu_switchto().
Inspiration from sf@, refined over dinner with theo
ok mlarkin@ deraadt@
schwarze [Thu, 12 Jul 2018 14:06:39 +0000 (14:06 +0000)]
fix Test 7.1 after main.c rev. 1.37;
breaking the output lines earlier with the 'l' command is intentional