tb [Sat, 1 Apr 2023 05:27:44 +0000 (05:27 +0000)]
horrible whitespace, mostly on non-code lines. no object change
dlg [Sat, 1 Apr 2023 00:04:40 +0000 (00:04 +0000)]
follow quectel guidance on which usb interfaces umsm should match.
the Quectel LTE&5G Linux USB Driver User Guide V2.0 says umsm should
only attach to usb interfaces 0 to 3 using the interface class
UICLASS_VENDOR. their doco uses magic numbers, but this is what
they mean.
interfaces 4 and above provide network (not serial) via qmi, ecm,
or mbim. preventing umsm from attaching to the high interfaces
allows the appropriate network driver to use it instead. eg, umb
is now able to attach to the network interface because it presents
a standard mbim class.
discussed with and tested by kevlo@
ok patric@ sthen@ kevlo@
dlg [Fri, 31 Mar 2023 23:55:45 +0000 (23:55 +0000)]
shuffle the code in umsm_match a bit.
if umsm_lookup doesnt return anything, return early and leave the
rest of umsm_match to handling specific devices.
no functional change.
dlg [Fri, 31 Mar 2023 23:53:49 +0000 (23:53 +0000)]
dont match quectel ec25 by vendor+product id
quectel seem to provide a sane and consistent set of functionality
built on top of the qualcomm qmi stuff. their linux drivers guide
says quectel modems provide a set of umsm usb interfaces and a
network interface that can be in qmi, ecm, or mbim mode.
if the modem is in mbim mode, it will present the mbim classes which
umb should be able to attach to without this explicit vendor+product
match (assuming umsm doesn't claim the interface first).
based on info in the Quectel LTE&5G Linux USB Driver User Guide V2.0
discussed with and tested by kevlo@
ok patrick@ sthen@ kevlo@
kn [Fri, 31 Mar 2023 20:31:35 +0000 (20:31 +0000)]
regen after "BE-M1000" addition
kn [Fri, 31 Mar 2023 20:28:48 +0000 (20:28 +0000)]
Add "Baikal Electronics" and their "BE-M1000" SoC
OK kettenis
tb [Fri, 31 Mar 2023 20:16:55 +0000 (20:16 +0000)]
Add missing NULL check after group_get()
Otherwise dh_getlen() will dereference ie->group and crash.
looks correct to hshoexer
mglocker [Fri, 31 Mar 2023 19:50:45 +0000 (19:50 +0000)]
Enable ufshci(4).
ok kettenis@
bluhm [Fri, 31 Mar 2023 19:43:32 +0000 (19:43 +0000)]
Fix white space.
tb [Fri, 31 Mar 2023 19:40:08 +0000 (19:40 +0000)]
Add regress coverage for the new behavior of BN_copy() with respect to
flags.
tb [Fri, 31 Mar 2023 19:39:15 +0000 (19:39 +0000)]
Copy BN_FLG flags in BN_copy()
BN_copy() forgot to copy the flags from the source to the target. Fix
this by copying the flags. In fact, only copy BN_FLG_CONSTTIME since
propagating BN_FLG_MALLOCED and BN_FLG_STATIC_DATA is wrong. Ignore the
BN_FLG_FREE flag "used for debugging" which of course means "unused"
like a lot of other debug code that somehow ended up in public headers.
Also: make BN_FLG_CONSTTIME sticky on the target, i.e., don't clear the
flag when copying from a non-constant time BIGNUM to a constant time one
for the following reason: if a is constant time, BN_sqr(a, a, ctx) would
use a BIGNUM without the flag internally, then copy the result to a in
which process a would lose its constant time flag.
Fixing this would be a lot of pointless work since someone had the good
sense of not relying on a fragile flag for something this important.
Rather, libcrypto always uses the constant time paths instead of the
faster, cryptographically inadequate paths.
Before this was changed, this was a pretty bad bug. The RSA code uses the
horrible BN_with_flags() function to create local versions of the private
moduli and set BN_FLG_CONSTTIME on them. If the RSA_FLAG_CACHE_PRIVATE for
caching moduli is set on the RSA, which it is by default, it attempts to
set these constant time versions on the RSA's internal Montgomery contexts.
Since it is called BN_MONT_CTX_set(), the setter doesn't set a BIGNUM on
the BN_MONT_CTX, rather it copies it over, losing the BN_FLG_CONSTTIME flag
in the process and make all the horrible leaky RSA code leak some more.
Good job.
This is all harmless and is mostly a cosmetic fix. BN_FLG_CONSTTIME should
be removed internally. It will be kept since various language bindings of
course picked it up and expose it.
ok beck jsing
krw [Fri, 31 Mar 2023 19:12:32 +0000 (19:12 +0000)]
Refactor partition type menu code, disentangling mbr and gpt
partition types from menu building and display.
Some GPT partition names change to match their MBR bretheren.
No intentional functional change.
kettenis [Fri, 31 Mar 2023 18:49:43 +0000 (18:49 +0000)]
Since all arm64 assembly code in libc uses the ENTRY* macros from
<machine/asm.h> they are already get the necessary "bti c" instructions.
Passi the -mmark-bti-property option to mark the corresponding object
files as having BTI support.
ok deraadt@
kettenis [Fri, 31 Mar 2023 18:46:24 +0000 (18:46 +0000)]
Add "bti c" where needed for BTI control flow integrety checks.
ok deraadt@
kettenis [Fri, 31 Mar 2023 18:45:05 +0000 (18:45 +0000)]
Call entry point of the executable through register x17. This allows it
to be a normal C function that starts with "bti c" when BTI contro flow
integretry enforcement is in place. Add "bti c" to _dl_bind_start().
Remove unused _rtld_tlsdesc() function to avoid having to add "bti c" to it.
ok deraadt@
tb [Fri, 31 Mar 2023 17:47:39 +0000 (17:47 +0000)]
Inline only use of TS_VERIFY_CTX_init()
Since TS_VERIFY_CTX is now opaque, the only thing TS_VERIFY_CTX_init()
is good for outside the library is memory leaks. Inside the library it's
also useless, since as a much more familiar name is memset(). It will soon
be able to join all the other nonsense that should never have leaked out of
this library.
krw [Fri, 31 Mar 2023 14:41:08 +0000 (14:41 +0000)]
Oops. Missed eliminating unneeded double quotes in previous.
jmc [Fri, 31 Mar 2023 13:48:34 +0000 (13:48 +0000)]
remove the whitespace in weird " / " constructs;
jmc [Fri, 31 Mar 2023 13:45:13 +0000 (13:45 +0000)]
remove some unneccessary words and whitespace;
kettenis [Fri, 31 Mar 2023 13:37:41 +0000 (13:37 +0000)]
regen
kettenis [Fri, 31 Mar 2023 13:37:02 +0000 (13:37 +0000)]
Add RTL8211F-VD, a new RTL8211F variant.
ok jsg@, dlg@
krw [Fri, 31 Mar 2023 13:11:40 +0000 (13:11 +0000)]
Be more consistent in function naming. Functions taking or
returning struct uuid's use 'uuid' in their names.
Lengthen a pointlessly short line.
No functional change.
jsg [Fri, 31 Mar 2023 12:35:24 +0000 (12:35 +0000)]
remove unused unp_lock
ok kn@ mvs@
kn [Fri, 31 Mar 2023 12:07:54 +0000 (12:07 +0000)]
Flip label separators to fix previous
-gpiokeys0 at mainbus0, "PWR Button"
+gpiokeys0 at mainbus0: "PWR Button"
OK patrick
claudio [Fri, 31 Mar 2023 09:55:39 +0000 (09:55 +0000)]
When the slowcgi timeout fires but no process what yet started terminate
the session with a HTTP 408 error.
OK tb@
kevlo [Fri, 31 Mar 2023 08:22:09 +0000 (08:22 +0000)]
Enable ngbe(4).
ok miod@
kevlo [Fri, 31 Mar 2023 08:20:58 +0000 (08:20 +0000)]
Man page for ngbe(4).
ok miod@
kevlo [Fri, 31 Mar 2023 08:19:41 +0000 (08:19 +0000)]
ngbe(4), a driver for Wangxun WX1860 series Gigabit Ethernet devices.
Written based on the vendor driver for Linux.
Thanks to WangXun for relicensing their vendor driver to ISC.
Special thanks to miod@ for reviewing and providing valuable input.
ok miod@
kevlo [Fri, 31 Mar 2023 08:17:00 +0000 (08:17 +0000)]
regen
kevlo [Fri, 31 Mar 2023 08:16:30 +0000 (08:16 +0000)]
Add "Beijing WangXun Technology" vendor and WX1860 series NICs.
ok miod@
tb [Fri, 31 Mar 2023 07:28:46 +0000 (07:28 +0000)]
Guard use of GROUP_EC2N with #ifndef OPENSSL_NO_EC2M
This allows compiling isakmpd with a libcrypto that has binary field
support removed. Leave the enum value itself unguarded on claudio's
request.
ok beck claudio jsing
tb [Fri, 31 Mar 2023 06:07:44 +0000 (06:07 +0000)]
Add a regress for the recent BIO_new_NDEF() write after free
This is a simple reproducer for a write after free that avoids all the
mess with CMS, PKCS7 and SMIME. This now mostly allows ASAN to check
that the memory handling in this marvellous function is correct.
dtucker [Fri, 31 Mar 2023 05:56:36 +0000 (05:56 +0000)]
Explicitly ignore return from waitpid here too.
dtucker [Fri, 31 Mar 2023 04:45:08 +0000 (04:45 +0000)]
Explictly ignore return codes where we don't check them. From Dmitry
Belyavskiy via github PR#238, ok djm@
dtucker [Fri, 31 Mar 2023 04:42:29 +0000 (04:42 +0000)]
Return immediately from get_sock_port if sock <0 so we don't call
getsockname on a negative FD. From Coverity CID 291840, ok djm@
djm [Fri, 31 Mar 2023 04:23:02 +0000 (04:23 +0000)]
don't leak arg2 on parse_pubkey_algos error path; ok dtucker@
djm [Fri, 31 Mar 2023 04:22:27 +0000 (04:22 +0000)]
clamp max number of GSSAPI mechanisms to 2048; ok dtucker
djm [Fri, 31 Mar 2023 04:21:56 +0000 (04:21 +0000)]
don't print key if printing hostname failed; with/ok dtucker@
djm [Fri, 31 Mar 2023 04:04:15 +0000 (04:04 +0000)]
remove redundant test
djm [Fri, 31 Mar 2023 04:00:37 +0000 (04:00 +0000)]
don't attempt to decode a ridiculous number of attributes;
harmless because of bounds elsewhere, but better to be explicit
jmatthew [Fri, 31 Mar 2023 03:38:26 +0000 (03:38 +0000)]
Only send the used portion of struct idm_req in imsgs from the ldapclient
process to the main process. This significantly reduces memory usage when
updating larger directories.
ok aisha@
djm [Fri, 31 Mar 2023 03:22:49 +0000 (03:22 +0000)]
remove unused variable; prompted by Coverity CID 291879
kevlo [Fri, 31 Mar 2023 02:20:21 +0000 (02:20 +0000)]
Document i226.
From Brad.
jsg [Fri, 31 Mar 2023 02:16:10 +0000 (02:16 +0000)]
drm/amdkfd: Fix the memory overrun
From Ma Jun
8c31b663edc1cc5eb5c82282ab6ca99c69d1d942 in linux-6.1.y/6.1.22
4cc16d64b6cdb179a26fb389cae9dce788e88f5d in mainline linux
jsg [Fri, 31 Mar 2023 02:14:03 +0000 (02:14 +0000)]
drm/amdkfd: add GC 11.0.4 KFD support
From Yifan Zhang
132f1d39439142547d9d5e45d7744d375dd21fdc in linux-6.1.y/6.1.22
88c21c2b56aa21dd34290d43ada74033dc3bfe35 in mainline linux
jsg [Fri, 31 Mar 2023 02:12:21 +0000 (02:12 +0000)]
drm/amdkfd: Fix the warning of array-index-out-of-bounds
From Ma Jun
0ac954ec7f6c6dd6b7e94340599ba4b788d056d5 in linux-6.1.y/6.1.22
c0cc999f3c32e65a7c88fb323893ddf897b24488 in mainline linux
jsg [Fri, 31 Mar 2023 02:09:05 +0000 (02:09 +0000)]
drm/amdkfd: introduce dummy cache info for property asic
From Prike Liang
a5528973c676dad09a1af25cd49e4312238d1428 in linux-6.1.y/6.1.22
fd72e2cb2f9dd2734e8013b3e185a21f0d605d3e in mainline linux
jsg [Fri, 31 Mar 2023 02:07:08 +0000 (02:07 +0000)]
drm/amdgpu: reposition the gpu reset checking for reuse
From Tim Huang
75e10d7fb97906ddb641c7b09773a91693570f63 in linux-6.1.y/6.1.22
aaee0ce460b954e08b6e630d7e54b2abb672feb8 in mainline linux
jsg [Fri, 31 Mar 2023 02:04:27 +0000 (02:04 +0000)]
drm/amdgpu: skip ASIC reset for APUs when go to S4
From Tim Huang
9f7e1dd835ec834fb147a7725419497f0b0d83a7 in linux-6.1.y/6.1.22
b589626674de94d977e81c99bf7905872b991197 in mainline linux
jsg [Fri, 31 Mar 2023 02:02:47 +0000 (02:02 +0000)]
drm/i915: Preserve crtc_state->inherited during state clearing
From Ville Syrjala
220da3bf1fc335ae25b181d6bedcfc63efef6ccc in linux-6.1.y/6.1.22
3a84f2c6c9558c554a90ec26ad25df92fc5e05b7 in mainline linux
jsg [Fri, 31 Mar 2023 02:01:00 +0000 (02:01 +0000)]
drm/i915/active: Fix missing debug object activation
From Nirmoy Das
c355945957ef5e9bb05e0554fe4a6f92b0fcaf36 in linux-6.1.y/6.1.22
e92eb246feb9019b0b137706c934b8891cdfe3c2 in mainline linux
jsg [Fri, 31 Mar 2023 01:59:24 +0000 (01:59 +0000)]
drm/amdgpu/nv: Apply ASPM quirk on Intel ADL + AMD Navi
From Kai-Heng Feng
ed6364fb7c407ca53447d8b0723a61d320bcbae9 in linux-6.1.y/6.1.22
2b072442f4962231a8516485012bb2d2551ef2fe in mainline linux
jsg [Fri, 31 Mar 2023 01:56:10 +0000 (01:56 +0000)]
drm/amd/display: fix wrong index used in dccg32_set_dpstreamclk
From Hersen Wu
c590fce42c2117693bd0ee6646b3fc16a8f842ae in linux-6.1.y/6.1.22
4c94e57c258cb7800aa5f3a9d9597d91291407a9 in mainline linux
jsg [Fri, 31 Mar 2023 01:54:30 +0000 (01:54 +0000)]
drm/amd: Fix initialization mistake for NBIO 7.3.0
From Mario Limonciello
a0e39cdddc155926fc3c0395636b7c80e55e66a1 in linux-6.1.y/6.1.22
1717cc5f2962a4652c76ed3858b499ccae6c277c in mainline linux
jsg [Fri, 31 Mar 2023 01:53:07 +0000 (01:53 +0000)]
drm/amdgpu: Fix call trace warning and hang when removing amdgpu device
From lyndonli
f06b902511ea05526f405ee64da54a8313d91831 in linux-6.1.y/6.1.22
93bb18d2a873d2fa9625c8ea927723660a868b95 in mainline linux
jsg [Fri, 31 Mar 2023 01:51:13 +0000 (01:51 +0000)]
drm/amd/display: Update clock table to include highest clock setting
From Swapnil Patel
b66804fc7e21587431360af1dbcc1d9145237b7a in linux-6.1.y/6.1.22
2d99a7ec25cf456cd3680eb314d6454138e5aa64 in mainline linux
jsg [Fri, 31 Mar 2023 01:49:17 +0000 (01:49 +0000)]
drm/amd/display: Set dcn32 caps.seamless_odm
From Hersen Wu
612cf2495ec6cf5834e8b4a70f599190c35cf8c8 in linux-6.1.y/6.1.22
f9537b1fa7fb51c2162bc15ce469cbbf1ca0fbfe in mainline linux
jsg [Fri, 31 Mar 2023 01:47:06 +0000 (01:47 +0000)]
drm/i915/gt: perform uc late init after probe error injection
From Andrzej Hajda
6e516595e88670baf275701893fd43e0a454f7d0 in linux-6.1.y/6.1.22
150784f9285e656373cf3953ef4a7663f1e1a0f2 in mainline linux
jsg [Fri, 31 Mar 2023 01:44:03 +0000 (01:44 +0000)]
drm/i915/guc: Fix missing ecodes
From John Harrison
be8c6ad6b16e6181510e35c53928381f0f39640a in linux-6.1.y/6.1.22
8df23e4c4f72f4e201c28e6fb0a67e2dbf30628a in mainline linux
jsg [Fri, 31 Mar 2023 01:42:14 +0000 (01:42 +0000)]
drm/i915/guc: Rename GuC register state capture node to be more obvious
From John Harrison
d2b9357d3da3f8054a47eef04c8ef361608b243e in linux-6.1.y/6.1.22
583ebae783b8241a30581c084ad6226051b594c5 in mainline linux
jsg [Fri, 31 Mar 2023 01:39:50 +0000 (01:39 +0000)]
drm/i915/fbdev: lock the fbdev obj before vma pin
From Tejas Upadhyay
9595d71b2a274fe365240b53ce5d03c071c3e6e0 in linux-6.1.y/6.1.22
ed00eba03474adbf525ff03d69705d8c78b76456 in mainline linux
jsg [Fri, 31 Mar 2023 01:38:10 +0000 (01:38 +0000)]
drm/i915: Print return value on error
From Nirmoy Das
b6375c5ecd8c790e381ee3f9baeda8c9e5da4a45 in linux-6.1.y/6.1.22
20c68127e8e9d7899001c47465d0b79581f5fdc1 in mainline linux
jsg [Fri, 31 Mar 2023 01:36:11 +0000 (01:36 +0000)]
drm/amd/display: Fix DP MST sinks removal issue
From Cruise Hung
ee9caccc5e5cc1092baf6fb645525bba668b01c1 in linux-6.1.y/6.1.22
cbd6c1b17d3b42b7935526a86ad5f66838767d03 in mainline linux
jsg [Fri, 31 Mar 2023 01:34:21 +0000 (01:34 +0000)]
drm/amd/display: Remove OTG DIV register write for Virtual signals.
From Saaem Rizvi
75eb69023ba30076dba2df6a3e0f9f51095a237b in linux-6.1.y/6.1.22
709671ffb15dcd1b4f6afe2a9d8c67c7c4ead4a1 in mainline linux
jsg [Fri, 31 Mar 2023 01:32:38 +0000 (01:32 +0000)]
drm/amd/display: fix k1 k2 divider programming for phantom streams
From Aurabindo Pillai
0ac86f7dda2b1f895304919ee9035c170a6af419 in linux-6.1.y/6.1.22
3b214bb7185d8284d7d4c53e15127f69a375abf6 in mainline linux
jsg [Fri, 31 Mar 2023 01:30:52 +0000 (01:30 +0000)]
drm/amd/display: Include virtual signal to set k1 and k2 values
From Eric Bernstein
4a36da161b7a467c884e00219bb62b645bbe74f1 in linux-6.1.y/6.1.22
368307cef69ccd9bf5511f25e58e3a103be169fb in mainline linux
dtucker [Fri, 31 Mar 2023 00:44:29 +0000 (00:44 +0000)]
Check fd against >=0 instead of >0 in error path. The dup could
in theory return fd 0 although currently it doesn't in practice.
From Dmitry Belyavskiy vi github PR#238.
op [Thu, 30 Mar 2023 22:56:47 +0000 (22:56 +0000)]
drop unnecessary copy of fname; ok tb@
krw [Thu, 30 Mar 2023 22:53:39 +0000 (22:53 +0000)]
Use 'char * const' instead of #define for repeated
GUID strings. Consistently use strcasecmp() when comparing
GUID's, allowing use of simple 'char *' for gt_guid.
No intentional functional change.
kn [Thu, 30 Mar 2023 20:07:49 +0000 (20:07 +0000)]
keep match strings sorted
kn [Thu, 30 Mar 2023 20:03:32 +0000 (20:03 +0000)]
Attach Baikal-M PCIe
https://github.com/Elpitech/baikal-m-linux-kernel/search?q=bm1000-pcie
Tested on ET-101-MB
Initial diff from Slava Voronzoff
Feedback OK kettenis patrick
op [Thu, 30 Mar 2023 19:01:25 +0000 (19:01 +0000)]
tabify two lines
op [Thu, 30 Mar 2023 19:00:02 +0000 (19:00 +0000)]
don't access(conffile)
This removes a few access(2) calls in the configuration file handling.
startupfile() now opens and return the file and to avoid surprises it
also uses a caller-provided buffer to store the filename. This also
removes the extra adjustpath() that load() did: it has been moved to
evalfile() only.
with help, fixes and ok tb@
bluhm [Thu, 30 Mar 2023 17:20:53 +0000 (17:20 +0000)]
i2d_ECDSA_SIG() may return a negative value in case of error.
Do no use this as length in iked(8) _dsa_verify_prepare().
OK tobhe@ tb@
jmc [Thu, 30 Mar 2023 16:16:32 +0000 (16:16 +0000)]
escape "An" in a %T call, so groff does not flag it as an error;
op [Thu, 30 Mar 2023 16:00:47 +0000 (16:00 +0000)]
adjust markup of one of the builtin kill usage
The Op on its own line becomes part of the item body instead of the list
item itself.
OK millert@
bluhm [Thu, 30 Mar 2023 15:51:09 +0000 (15:51 +0000)]
i2d_ECDSA_SIG() may return a negative value in case of error. Handle
this in ossl_ecdsa_sign() and propagate the return code.
OK jsing@ tb@
claudio [Thu, 30 Mar 2023 15:29:15 +0000 (15:29 +0000)]
Add the protocol used to sync the repository to the open-metric output.
OK tb@
kn [Thu, 30 Mar 2023 15:09:01 +0000 (15:09 +0000)]
Map device tree read/write to unbreak root on softraid
Since r1.76 "Get rid of pmap_map_early()" the FDT was mapped read-only,
but CRYPTO softraid code writes it to zero out the key.
Found and tested by me; explanation and fix from kettenis.
OK kettenis
claudio [Thu, 30 Mar 2023 14:47:25 +0000 (14:47 +0000)]
Refactor extract_prefix() to first do the length checks and only then
copy the data out.
OK tb@
krw [Thu, 30 Mar 2023 14:38:26 +0000 (14:38 +0000)]
Remove needless memset() call, 'entries' variable and
limit check in PRT_menuid_to_guid().
No functional change.
tb [Thu, 30 Mar 2023 14:28:56 +0000 (14:28 +0000)]
Call bn_copy() unconditionally in BN_mul() and BN_sqr()
bn_copy() does the right thing if source and target are the same, so
there is no need for an additional check.
Requested by jsing
tb [Thu, 30 Mar 2023 14:23:50 +0000 (14:23 +0000)]
bio_ndef: add an empty line before return
tb [Thu, 30 Mar 2023 14:21:10 +0000 (14:21 +0000)]
Rework BN_exp() a bit
This mostly only cleans up the mess that it was - which doesn't stand out
because of the horror that lurks in the rest of this file. It avoids
copying the partial calculation out on error and does away with some
other weirdness.
with/ok jsing
claudio [Thu, 30 Mar 2023 13:25:23 +0000 (13:25 +0000)]
Extra space in struct field definitions. NFC
claudio [Thu, 30 Mar 2023 12:11:18 +0000 (12:11 +0000)]
Put the size of the pt_entry object into the struct itself.
Increase the refcnt to a 32bit int and while there reorder the vpn
specific structs a bit so the IPv4 and IPv6 types are more equal.
OK tb@
kevlo [Thu, 30 Mar 2023 09:24:22 +0000 (09:24 +0000)]
Update comment: RTL8139 -> TNETE2101
ok mpi@
op [Thu, 30 Mar 2023 08:07:07 +0000 (08:07 +0000)]
trailing whitespaces
op [Thu, 30 Mar 2023 07:26:15 +0000 (07:26 +0000)]
strncpy -> strlcpy to properly NUL-terminate the copy of the path
otherwise paths longer than NFILEN (1024) given with -u won't
NUL-terminate `file'.
dtucker [Thu, 30 Mar 2023 07:19:50 +0000 (07:19 +0000)]
Ignore return value from muxclient(). It normally loops without returning,
but it if returns on failure we immediately exit. Coverity CID 405050.
djm [Thu, 30 Mar 2023 03:05:01 +0000 (03:05 +0000)]
return SSH_ERR_KEY_NOT_FOUND if the allowed_signers file is empty,
not SSH_ERR_INTERNAL_ERROR. Also remove some dead code spotted by
Coverity; with/ok dtucker@
dtucker [Thu, 30 Mar 2023 00:49:37 +0000 (00:49 +0000)]
Remove dead code from inside if block. The only way the if statement can
be true is if both dup()s fail, and in that case the tmp2 can never be set.
Coverity CID 291805, ok djm@
krw [Wed, 29 Mar 2023 19:34:49 +0000 (19:34 +0000)]
Change 'type' to 'menuid' in various struct's, functions and
variables related to gpt partitions. Makes it clear that there is
no required tie between mbr partition types and gpt partition
types.
No functional change.
op [Wed, 29 Mar 2023 19:09:04 +0000 (19:09 +0000)]
plug leak of tagpos in poptag() if loadbuffer() fails
kn [Wed, 29 Mar 2023 17:40:24 +0000 (17:40 +0000)]
Quote possible 'none' answer as part of help text after question
'Default IPv4 route?' takes an IP or this word, not no IP at all.
All other questions already quote their 'none', 'done', etc. answers.
No behaviour change for autoinstall(8) files, questions end after the
qestion mark and potential answers/help in parentheses comes after that.
claudio [Wed, 29 Mar 2023 17:03:29 +0000 (17:03 +0000)]
Instead of storing the short TAL name as repouri use the first TAL URI
for that. This is more in line with the other uses of repouri.
OK tb@
kn [Wed, 29 Mar 2023 16:20:17 +0000 (16:20 +0000)]
Add missing semicolon to properly end switch case
There since introduction, lucked out since it is the last case.
No functional change.
krw [Wed, 29 Mar 2023 15:55:34 +0000 (15:55 +0000)]
No need to assume a nil GUID can be found at gpt_types[0]. Just
use uuid_create_nil().
No functional change.
claudio [Wed, 29 Mar 2023 14:35:38 +0000 (14:35 +0000)]
Mark the struct aid name as const char * since it points to static memory.
krw [Wed, 29 Mar 2023 14:20:50 +0000 (14:20 +0000)]
Simplify code by having PRT_uuid_to_type() return -1 when
no type can be found. 0 is a valid type!
No functional change.