sthen [Tue, 19 Jul 2016 08:28:03 +0000 (08:28 +0000)]
In rcctl ls, skip all files with a '.' in the name, not just rc.subr;
pkg_add renames files in this way when the checksums don't match at update
or removal time. [[ ]] suggestion from guenther@ to avoid the messy "case"
that I had in my first diff. Other feedback/suggestions from halex aja
millert, ok halex@ aja@.
mpi [Tue, 19 Jul 2016 08:13:45 +0000 (08:13 +0000)]
Use a flag to indicate that a packet has been received on an IPv6
anycast address.
This will allow us to split ip6_input() in two parts using a queue
in the middle.
ok jca@, florian@, bluhm@
benno [Tue, 19 Jul 2016 08:04:53 +0000 (08:04 +0000)]
remove bogus attributes from ifstated, spooted by guenther@
mpi [Tue, 19 Jul 2016 08:03:01 +0000 (08:03 +0000)]
Do not consider tap(4) a special interface and start if before other
pseudo-interfaces.
This unbreak vlan(4) on top of tap(4) since the refactoring to turn it
MP-safe.
ok claudio@, deraadt@
benno [Tue, 19 Jul 2016 07:58:51 +0000 (07:58 +0000)]
remove bogus attributes on fatal* spotted by guenther@
deraadt [Tue, 19 Jul 2016 06:43:27 +0000 (06:43 +0000)]
Cleanup close(open idioms.
ok krw
tedu [Tue, 19 Jul 2016 05:30:48 +0000 (05:30 +0000)]
instead of messing about with pointer arithmetic, add an empty array
to the end of the defer structure. solves sizing and alignment concerns.
sf [Tue, 19 Jul 2016 02:51:09 +0000 (02:51 +0000)]
virtio_pci: Always allow MSI/MSI-X
For virtio devices, ignore the black/white-listing depending on the PCI
bridge. This enables MSI-X with qemu's old "82441FX" pci-bridge.
Suggested by kettenis@
tom [Tue, 19 Jul 2016 02:26:15 +0000 (02:26 +0000)]
Remove what appears to be a copy-paste error setting cur_ttb
in pmap_free_l1().
from aalm@ - thanks
ok patrick@
benno [Mon, 18 Jul 2016 21:22:09 +0000 (21:22 +0000)]
add format attributes to log functions and fix some errors
ok claudio@ florian@
benno [Mon, 18 Jul 2016 21:20:31 +0000 (21:20 +0000)]
add format attributes to log functions
ok florian@ claudio@
benno [Mon, 18 Jul 2016 21:18:48 +0000 (21:18 +0000)]
add format attributes to log functions
ok claudio@
benno [Mon, 18 Jul 2016 21:17:32 +0000 (21:17 +0000)]
add format attributes to log functions
ok stsp@ claudio@ florian@
benno [Mon, 18 Jul 2016 21:14:30 +0000 (21:14 +0000)]
add format attributes to log functions and fix two errors
ok renato@
benno [Mon, 18 Jul 2016 21:10:37 +0000 (21:10 +0000)]
add format attributes to log functions and fix am error when using
log_warnx()
ok renato@ claudio@
bluhm [Mon, 18 Jul 2016 19:50:49 +0000 (19:50 +0000)]
Kill the rtableid variable in ip6_input(). It does not make sense
to store a field in an extra variable that is only accessed twice.
OK mpi@
kettenis [Mon, 18 Jul 2016 19:22:45 +0000 (19:22 +0000)]
Apparently we need to explicitly stop the timers before reloading them. At
least this is what Linux does and it fixes a hang on the Olimex A10s boards.
While there, also preserve the clock selection when reloading the timer.
ok patrick@, jsg@, tom@
henning [Mon, 18 Jul 2016 19:11:18 +0000 (19:11 +0000)]
no more cbq_opts - CBQ is gone, ok mpi phessler benno
guenther [Mon, 18 Jul 2016 19:05:22 +0000 (19:05 +0000)]
We have __weak_alias() everywhere; remove obsolete #ifdef's
ok deraadt@
jmc [Mon, 18 Jul 2016 18:24:21 +0000 (18:24 +0000)]
rework the first sentence of this page;
with help from otto
zhuk [Mon, 18 Jul 2016 16:46:30 +0000 (16:46 +0000)]
The string with path to shell could be taken directly from struct passwd.
At some point later the data it points to is overridden by getpwuid() call,
resulting in garbage. The problem could be easily demonstreated by double
doas call:
$ doas doas -su _sndio
doas: mpty: command not found
The fix is easy: just strdup() the pw_shell field value.
okay tedu@, tweaks from & okay natano@
henning [Mon, 18 Jul 2016 15:21:33 +0000 (15:21 +0000)]
g/c unused (global!) var: oqueues isn't used any more. ALTQ leftover; not
noticed since struct node_queue stayed. ok claudio benno gcc
jsg [Mon, 18 Jul 2016 15:03:01 +0000 (15:03 +0000)]
Add additional i2c and mmc prcm module enum values for devices that
didn't attach previously on OMAP4 with the static device configuration
and now do with the fdt. Like most of the other OMAP4 prcm cases
these don't do anything, hopefully we'll properly configure clocks with
data from the fdt at some point in the future.
Tested by abieber@ on PandaBoard-ES.
tom [Mon, 18 Jul 2016 13:38:11 +0000 (13:38 +0000)]
Don't need a separate flags variable in armv7 pmap_clean_page() -
just use the pv_flags. ('Twas a copy-paste from arm's pmap_clean_page(),
which did need it.)
Also remove even less used flags variable from pmap_page_remove().
First part from a diff from aalm@ - thanks
ok kettenis@ "looks good" patrick@
bluhm [Mon, 18 Jul 2016 13:17:44 +0000 (13:17 +0000)]
Hide pf internals by moving code from in_ouraddr() to pf_ouraddr().
OK mpi@ sashan@
stsp [Mon, 18 Jul 2016 13:10:35 +0000 (13:10 +0000)]
Explicitly set iwm(4) firmware Tx aggregation limit to one (which disables
Tx aggregation), instead of the maximum (63 frames). Tx aggregation should
already be disabled, so this change should be a no-op. It just avoids any
side effects in case the firmware happens to interpret the limit we set here.
ok mpi@
stsp [Mon, 18 Jul 2016 13:09:58 +0000 (13:09 +0000)]
Fix inverted logic in iwm_tx(). The PROT_REQUIRE flag in should be set for
data frames above a certain length, but we were setting it for !data frames
above a certain length, which makes no sense at all. Found while comparing
our driver's Tx code to iwlwifi.
ok mpi@
stsp [Mon, 18 Jul 2016 13:09:08 +0000 (13:09 +0000)]
Make iwm(4) retry Tx of management frames less often. We now retry management
frames the same number of times as Linux iwlwifi does.
patrick [Mon, 18 Jul 2016 11:53:32 +0000 (11:53 +0000)]
Some SoCs have a ranges property set in their device trees. This can
be used to translate one memory address to another. Currently we just
pass the child's memory address to bus space map. If one of the parent
busses implements a ranges property, the child's address property is
not the real address. This change hooks up a bus space map function
that is aware of the ranges property and translates the addresses if
needed.
ok kettenis@
looks fine jsg@
guenther [Mon, 18 Jul 2016 11:48:55 +0000 (11:48 +0000)]
Fix VFLAG formatting
ok bluhm@
markus [Mon, 18 Jul 2016 11:35:33 +0000 (11:35 +0000)]
Reduce timing attack against obsolete CBC modes by always computing
the MAC over a fixed size of data.
Reported by Jean Paul Degabriele, Kenny Paterson, Torben Hansen and
Martin Albrecht. ok djm@
guenther [Mon, 18 Jul 2016 09:37:49 +0000 (09:37 +0000)]
Linking against libkvm is unnecessary here
ok mlarkin@
guenther [Mon, 18 Jul 2016 09:36:50 +0000 (09:36 +0000)]
Add 'p' trace point for KTRFAC_PLEDGE, as noted by
Michal Mazurek <akfaew@jasminek.net>
While here, fix handling of -t+ in ltrace.
bluhm [Mon, 18 Jul 2016 09:09:24 +0000 (09:09 +0000)]
Remote regression tests should not run ssh with -t all the time.
This will make it easier to automate them.
guenther [Mon, 18 Jul 2016 08:43:16 +0000 (08:43 +0000)]
Polish:
- copy #define workaround from mips64 to avoid dangling __CERROR symbol
- remove trap DL_SYSCALL2_NOERR() macro with comment explanation
- make DL_SYSCALL2() self-contained
- add END() and ENTRY() macros to make the symbol table shine
ok miod@
djm [Mon, 18 Jul 2016 06:08:01 +0000 (06:08 +0000)]
Add some unsigned overflow checks for extra_pad. None of these
are reachable with the amount of padding that we use internally.
bz#2566, pointed out by Torben Hansen. ok markus@
guenther [Mon, 18 Jul 2016 04:35:57 +0000 (04:35 +0000)]
Updated advice^Wcode from miod@ for passing &_DYNAMIC to _dl_boot_bind
ok aoyama@
bcook [Mon, 18 Jul 2016 01:04:52 +0000 (01:04 +0000)]
don't mix code and decls, ok tedu@
bcook [Sun, 17 Jul 2016 22:01:01 +0000 (22:01 +0000)]
use memset to initialize the union
bcook [Sun, 17 Jul 2016 21:23:50 +0000 (21:23 +0000)]
remove unused OPENSSL_NO_OBJECT case
ok tedu@
bcook [Sun, 17 Jul 2016 21:21:40 +0000 (21:21 +0000)]
Initialize buffers before use, noted by Kinichiro Inoguchi.
ok beck@
kettenis [Sun, 17 Jul 2016 17:45:14 +0000 (17:45 +0000)]
Attach sunxi(4) based on the compatible property of the root node of the
device tree like we do on omap. Add preliminary support for the sun5i
variant which corresponds to the A13 and A10s SoCs.
ok patrick@
otto [Sun, 17 Jul 2016 17:30:47 +0000 (17:30 +0000)]
getopt(3) can be called twice (once for bc and once for dc), so reinit getopt
ok deraadt@
jmc [Sun, 17 Jul 2016 16:33:17 +0000 (16:33 +0000)]
strip back asn1parse; ok beck jsing
description of -out altered on jsing's advice
stefan [Sun, 17 Jul 2016 11:21:07 +0000 (11:21 +0000)]
Talk about event API instead of libevent
Avoids inconsistent capitalization of libevent at start of sentence
suggested by and ok jmc@, ok bluhm@
djm [Sun, 17 Jul 2016 04:20:16 +0000 (04:20 +0000)]
support UTF-8 characters in ssh(1) banners using schwarze@'s
safe fmprintf printer; bz#2058
feedback schwarze@ ok dtucker@
tb [Sun, 17 Jul 2016 04:15:25 +0000 (04:15 +0000)]
Remove now obsolete parenthetical explanation (should have been part of
previous commit).
tb [Sun, 17 Jul 2016 04:04:46 +0000 (04:04 +0000)]
1. Update manpage in view of the change of behavior I introduced in -r1.27.
The bounds are taken inclusive and -w %d doesn't change the output of
integer random sequences anymore. This is the same behavior as that
of Linux and NetBSD, but differs from FreeBSD and OS X.
Issue reported by Philippe Meunier on misc@.
2 Fix a bug from the same commit observed by Otto: if the precision is 0,
values may be printed out of bounds. Fall back to the old behavior if at
least one bound isn't an integer.
General agreement expressed by otto@, tedu@, jmc@, sobrado@
Help with checking other operating systems by sobrado@.
Manpage ok jmc@.
Bugfix discussed with otto@ on icb
jsg [Sun, 17 Jul 2016 02:45:05 +0000 (02:45 +0000)]
Adapt kettenis' pinctrl changes in imx to sitaracm and
pinctrl-single,pins to handle mux settings and pad configuration.
The fdt data has offsets from the start of the pinmux address range so
the am335x specific pinmux offset from the scm base is added to the
offsets. This as not a new driver as sitaracm does manual table
driven pad configuration for gpio. If all the offsets in the
ti_padconf_devmap table were reduced by the am335x pinmux offset (0x800)
it may make sense to map only the pinmux memory region and not the
scm superset.
looks good kettenis@
jsg [Sun, 17 Jul 2016 00:28:46 +0000 (00:28 +0000)]
use the fdt root node instead of board ids to test for am335x
jsg [Sun, 17 Jul 2016 00:25:21 +0000 (00:25 +0000)]
Set function pointers based on the fdt root node instead of board ids.
ok kettenis@ on an earlier version
jsg [Sun, 17 Jul 2016 00:21:13 +0000 (00:21 +0000)]
Set function pointers based on the fdt root node instead of board ids.
ok kettenis@
millert [Sat, 16 Jul 2016 21:03:26 +0000 (21:03 +0000)]
sync
renato [Sat, 16 Jul 2016 19:24:30 +0000 (19:24 +0000)]
Remove potential overflow when validating message's length.
Also, use uint16_t for msg_type on gen_msg_hdr().
renato [Sat, 16 Jul 2016 19:20:16 +0000 (19:20 +0000)]
Fix parsing of mal-formed optional TLVs/Sub-TLVs.
We must detect if a TLV's length extends beyond the end of the containing
message. And, if so, send a fatal "Bad TLV Length" notification message.
Found with the Mu Dynamics Mu-8000 protocol fuzzer.
jca [Sat, 16 Jul 2016 18:55:55 +0000 (18:55 +0000)]
Fix sockopt name: ICMPV6_FILTER -> ICMP6_FILTER
mlarkin [Sat, 16 Jul 2016 18:36:41 +0000 (18:36 +0000)]
remove an unused parameter that wasn't handled during a previous refactor
(reducing the number of XXXs in vmm)
beck [Sat, 16 Jul 2016 16:14:28 +0000 (16:14 +0000)]
Clean up OCSP_check_validity() a bit more.
- Return on first failure rather than continuing.
- Don't compare times by comparing strings that possibly were not parsable as a time.
ok deraadt@
jca [Sat, 16 Jul 2016 16:10:44 +0000 (16:10 +0000)]
Fix example: long long should be print with %lld
sf [Sat, 16 Jul 2016 12:07:21 +0000 (12:07 +0000)]
Support MSI-X in virtio
This increases performance for interrupt heavy loads.
While suspend/resume support for MSI-X is missing, this is also missing for
virtio. So no new issue there.
Currently, qemu's old "82441FX" pci-bridge is still blacklisted for MSI. But
MSI-X is used if qemu is started with "-M q35".
visa [Sat, 16 Jul 2016 10:41:53 +0000 (10:41 +0000)]
Add $OpenBSD$ / replace $Id$ with $OpenBSD$.
visa [Sat, 16 Jul 2016 10:19:55 +0000 (10:19 +0000)]
Remove octeon_disable_interrupt() and octeon_restore_status().
They are unused and equivalent to disableintr() and setsr().
While here, clean up a few other leftovers.
tom [Sat, 16 Jul 2016 08:53:37 +0000 (08:53 +0000)]
Fix typo in comment in three machdep.c files:
s/names are this level/names at this level/
from aalm@ - thanks
jmc [Sat, 16 Jul 2016 07:27:53 +0000 (07:27 +0000)]
since we no longer pull source directly from openssl, the time is
right to try and trim some of the excess from this page. begin now
by cutting some of the fluff from the start.
the section on pass phrase arguments goes to the end of the page: it;s in
the way for now.
jmc [Sat, 16 Jul 2016 06:57:55 +0000 (06:57 +0000)]
- add proxyjump to the options list
- formatting fixes
- update usage()
ok djm
tom [Sat, 16 Jul 2016 06:41:20 +0000 (06:41 +0000)]
Remove unused function process_frame() from arm_machdep.c
ok jsg@
mlarkin [Sat, 16 Jul 2016 06:32:18 +0000 (06:32 +0000)]
remove unused vmm_activate function. all vmm-specific suspend/resume needs
are handled during cpu hatch.
mlarkin [Sat, 16 Jul 2016 06:20:24 +0000 (06:20 +0000)]
Fix an incorrect shift value when calculating the mask for the VMCS MSR
list storage size. Noticed when attempting to get vmm(4) to nest under
Hyper-V.
mlarkin [Sat, 16 Jul 2016 06:08:52 +0000 (06:08 +0000)]
remove some 12 year old code that was never correct, and never compiled
anyway due to a missing #include.
the code was originally intended to handle i386 SMP EISA machines with an
IOAPIC. Since the code never was compiled, and nobody has noticed or
complained for 12 years, I think things are probably fine.
mlarkin [Sat, 16 Jul 2016 06:04:29 +0000 (06:04 +0000)]
remove some unused #includes
beck [Sat, 16 Jul 2016 04:42:35 +0000 (04:42 +0000)]
Limit the support of the "backward compatible" ssl2 handshake to only be
used if TLS 1.0 is enabled. Sugessted/discussed with jsing@ and bcook@.
ok guenther@ sthen@
tom [Fri, 15 Jul 2016 22:28:25 +0000 (22:28 +0000)]
Remove duplicated line in omap mmc driver, which would cause
clkbase to be set to 0 (if it wasn't all commented out anyway).
ok patrick@
tom [Fri, 15 Jul 2016 22:05:40 +0000 (22:05 +0000)]
Remove duplicate line in amd64/acpi_machdep.c
ok krw@
schwarze [Fri, 15 Jul 2016 19:31:53 +0000 (19:31 +0000)]
To remove the const qualifier from a pointer to an object - either
because we know it is actually mutable or because we are passing
it to a function that doesn't accept a const object but won't
actually attempt to modify it - simply casting from (const type *)
to (type *) is legal C and clearly expresses the intent.
So get rid of the obfuscating UNCONST macro.
Basic idea discussed with guenther@.
tom [Fri, 15 Jul 2016 19:02:30 +0000 (19:02 +0000)]
Remove unused re_nbits from dev/rnd.c
"another leftover of the bean counter"
od tedu@ deraadt@
schwarze [Fri, 15 Jul 2016 18:49:53 +0000 (18:49 +0000)]
Fix previous: the mandocdb() prototype was already there, it just
hid among static functions, as noticed by tedu@ (my bad).
schwarze [Fri, 15 Jul 2016 18:02:32 +0000 (18:02 +0000)]
add missing prototypes, no code change;
noticed by Christos Zoulas with -Wmissing-prototypes
renato [Fri, 15 Jul 2016 17:09:25 +0000 (17:09 +0000)]
Improve logging of reserved labels.
Print "exp-null" and "imp-null" instead of "0" and "3", for example. Also,
remove print_label() and print_pw_type() from ldpctl.c and use the
equivalent functions from ldpd's log.c.
While here, be more paranoid and use UINT32_MAX instead of UINT_MAX
for NO_LABEL.
renato [Fri, 15 Jul 2016 17:05:50 +0000 (17:05 +0000)]
Explicitly ignore the Hop Count and Path Vector TLVs.
Since these are "well known" TLVs, we have to explicitly ignore them
otherwise ldpd would send "Unknown TLV" Notification messages when it
shouldn't.
Fixes regression caused by rev1.51.
renato [Fri, 15 Jul 2016 17:03:10 +0000 (17:03 +0000)]
Update per-neighbor GTSM options on config reload.
jcs [Fri, 15 Jul 2016 14:40:15 +0000 (14:40 +0000)]
disable acpicbkbd by default until after the release when acpi ec
issues can be worked out, otherwise this driver will cause the
kernel to spin forever on certain chromebooks
nicm [Fri, 15 Jul 2016 09:52:34 +0000 (09:52 +0000)]
Tweak output of environment logging.
nicm [Fri, 15 Jul 2016 09:28:32 +0000 (09:28 +0000)]
Log environment to new panes.
nicm [Fri, 15 Jul 2016 09:27:35 +0000 (09:27 +0000)]
Wrap some long lines and apply some static.
guenther [Fri, 15 Jul 2016 09:25:47 +0000 (09:25 +0000)]
Switch m88k to pass &_DYNAMIC to _dl_boot_bind()
probably works: this ASM pattern is already used for _dl_dtors
deraadt [Fri, 15 Jul 2016 05:06:24 +0000 (05:06 +0000)]
take us out of -beta
dtucker [Fri, 15 Jul 2016 05:01:58 +0000 (05:01 +0000)]
Reduce the syslog level of some relatively common protocol events
from LOG_CRIT by replacing fatal() calls with logdie(). Part of
bz#2585, ok djm@
nicm [Fri, 15 Jul 2016 00:49:08 +0000 (00:49 +0000)]
Don't update cells in each block of data read from a pane immediately,
instead track them as change (dirty) and update them once at the end,
saves much time if repeatedly writing the same cell. Also fix comparison
of cells being equal in a few places (memcmp is not enough).
nicm [Fri, 15 Jul 2016 00:42:56 +0000 (00:42 +0000)]
Instead of representing colours in several different forms with various
cell flags, convert to use an int with flags marking 256 or RGB colours
in the top byte (except in cells, which we don't want to make any
bigger). From Brad Town.
djm [Fri, 15 Jul 2016 00:24:30 +0000 (00:24 +0000)]
Add a ProxyJump ssh_config(5) option and corresponding -J ssh(1)
command-line flag to allow simplified indirection through a
SSH bastion or "jump host".
These options construct a proxy command that connects to the
specified jump host(s) (more than one may be specified) and uses
port-forwarding to establish a connection to the next destination.
This codifies the safest way of indirecting connections through SSH
servers and makes it easy to use.
ok markus@
jmc [Thu, 14 Jul 2016 17:34:06 +0000 (17:34 +0000)]
kern.usermount is currently a no-op;
ok deraadt
stefan [Thu, 14 Jul 2016 16:23:49 +0000 (16:23 +0000)]
Make sure that amap slot calculation does not overflow
This prevents from too small amaps being allocated by
forcing the allocation of a large number of slots.
Based on an analysis from Jesse Hertz and Tim Newsham.
ok kettenis@
deraadt [Thu, 14 Jul 2016 15:47:33 +0000 (15:47 +0000)]
sync
deraadt [Thu, 14 Jul 2016 15:39:40 +0000 (15:39 +0000)]
kern.usermount=1 is unsafe for everyone, since it allows any non-pledged
program to call the mount/umount system calls. There is no way any user
can be expected to keep their system safe / reliable with this feature.
Ignore setting to =1, and after release we'll delete the sysctl entirely.
ok lots of people
mpi [Thu, 14 Jul 2016 14:39:12 +0000 (14:39 +0000)]
Drop received packets with an IPv4-compatible address as source or
destination as per RFC4213.
We're not in 1999 anymore, what was earlier a "stronger check than
RFC1933" is now a best practice. This matches the behavior of the
reject (R) routes added by default by netstart(8).
ok jca@, florian@, claudio@, bluhm@
kettenis [Thu, 14 Jul 2016 14:05:51 +0000 (14:05 +0000)]
Do board-specific delay/skew corrections for the Micrel KSZ9021 and KSZ9031
PHYs based on device tree properties instead of the board ID. Untested as
I don't have the hardware.
ok jsg@, patrick@
mpi [Thu, 14 Jul 2016 14:01:40 +0000 (14:01 +0000)]
Prevent a use-after-free by not updating an ARP entry that has been
removed from the table.
Currently the storage for L2 addresses is freed when an entry is
removed from the table. That means that we cannot access this
chunk of memory between RTM_DELETE and rtfree(9).
Note that this doesn't apply to MPLS because the associated storage
is currently released by the last rtfree(9).
ok mikeb@
sf [Thu, 14 Jul 2016 12:50:07 +0000 (12:50 +0000)]
vioblk: Properly handle poll timeout
The only way to ensure that the device does not do DMA for the timed out
request is a device reset.
Also increase the timeout to 15s
sf [Thu, 14 Jul 2016 12:44:53 +0000 (12:44 +0000)]
rename virtio_ops.intr to poll_intr
This describes more accurately what it is good for.
Also introduce a virtio_poll_intr macro.
sf [Thu, 14 Jul 2016 12:42:00 +0000 (12:42 +0000)]
virtio: Move interrupt handler into transport specific code
For MSI-X (and also possibly for other transports), the interrupt
handler must do different things. Move it out of virtio.c and into
virtio_pci.
ARM part tested by patrick@