tb [Thu, 16 Mar 2023 15:05:23 +0000 (15:05 +0000)]
Add EVP_CIPHER_meth_* documentation from OpenSSL 1.1
This is essentially the original text with a few tweaks and fixes by me,
removing parts inapplicable to LibreSSL. There are dangling references to
EVP_CIPHER_CTX_copy(3) and EVP_CIPHER_CTX_get_cipher_data(3). This all
isn't great, but it's better than nothing. Probably good enough for these
rarely used functions.
job [Thu, 16 Mar 2023 12:01:47 +0000 (12:01 +0000)]
Update manpage for X509_CRL_get0_tbs_sigalg()
OK tb@
kettenis [Thu, 16 Mar 2023 10:33:44 +0000 (10:33 +0000)]
Add missing dependecy for rkcomphy(4); pointed out by dlg@
tb [Thu, 16 Mar 2023 08:16:21 +0000 (08:16 +0000)]
Bump LibreSSL version to 3.7.2
kn [Thu, 16 Mar 2023 06:57:11 +0000 (06:57 +0000)]
revert previous, stsp made WEP work on bwfm(4)
stsp [Wed, 15 Mar 2023 22:47:35 +0000 (22:47 +0000)]
make WEP encryption work on bwfm(4)
based on an initial diff by jsg@
brokenness pointed out by kn@
ok jsg@
jmc [Wed, 15 Mar 2023 22:39:58 +0000 (22:39 +0000)]
tweak sourceaddr:
- remove "-inet|-inet6" as it is not generally meaningful
- remove the qualifier "if set": sourceaddr now works nicely in cases
where no "address is given
millert [Wed, 15 Mar 2023 22:12:00 +0000 (22:12 +0000)]
Fix a number of out of bound reads in DNS response parsing.
Originally from djm@. OK deraadt@ florian@ bluhm@
benno [Wed, 15 Mar 2023 21:42:23 +0000 (21:42 +0000)]
state that binary updates are not available for all platforms/architectures.
triggered by a bug report by 'kodcode', thanks.
wording adjusted by jmc@, ok phessler@
djm [Wed, 15 Mar 2023 21:19:57 +0000 (21:19 +0000)]
openssh-9.3
deraadt [Wed, 15 Mar 2023 19:54:32 +0000 (19:54 +0000)]
slightly earlier, and tweak some dates
nicm [Wed, 15 Mar 2023 19:23:22 +0000 (19:23 +0000)]
Do not leak screen in popups, GitHub issue 3492.
millert [Wed, 15 Mar 2023 17:01:35 +0000 (17:01 +0000)]
Fix the length check when computing a fake challenge for users not
in the S/Key database. If the system hostname is longer than 126
characters this could result in NUL bytes being written past the
end of a stack buffer. There is no impact on systems with a hostname
126 characters or less. Found by Qualys. OK deraadt@
kettenis [Wed, 15 Mar 2023 13:01:40 +0000 (13:01 +0000)]
Add missing nameref resolving for the _DEP() package elements that indicate
dependencies between ACPI devices.
ok dlg@, deraadt@
job [Wed, 15 Mar 2023 11:09:34 +0000 (11:09 +0000)]
Show MFTs as part of the signature path
no objection tb@
claudio [Wed, 15 Mar 2023 08:43:51 +0000 (08:43 +0000)]
For now pass AF_UNSPEC to printsource() to ensure that both inet and inet6
addrs are fetched from the kernel. This needs more cleanup.
claudio [Wed, 15 Mar 2023 08:42:14 +0000 (08:42 +0000)]
Make route sourceaddr always print the used addresses for inet and inet6.
Print 'default' if no sourceaddr is set and the default algorithm is used.
With and OK kn@ deraadt@
jsg [Wed, 15 Mar 2023 08:36:33 +0000 (08:36 +0000)]
drm/amdgpu/vcn: Disable indirect SRAM on Vangogh broken BIOSes
From Guilherme G. Piccoli in amd-staging-drm-next
https://gitlab.freedesktop.org/drm/amd/-/issues/2385
This fixes amdgpu failing to init on Steam Deck after the drm 6.1 update:
[drm] failed to load ucode VCN0_RAM(0x3A) [drm] psp gfx command LOAD_IP_FW(0x6)
failed and response status is (0xFFFF0000)
[drm] *ERROR* ring vcn_dec_0 test failed (-60)
[drm] *ERROR* hw_init of IP block <vcn_v3_0> failed -60
drm:pid0:amdgpu_device_init *ERROR* amdgpu_device_ip_init failed
drm:pid0:amdgpu_attachhook *ERROR* Fatal error during GPU init
reported and tested by bentley@ on:
bios0: vendor Valve version "
F7A0113" date 11/04/2022
bios0: Valve Jupiter
jsg [Wed, 15 Mar 2023 08:24:56 +0000 (08:24 +0000)]
handle dmi_get_system_info(DMI_BIOS_VERSION)
jsg [Wed, 15 Mar 2023 08:20:52 +0000 (08:20 +0000)]
store bios version, needed for amdgpu Steam Deck quirk
nicm [Wed, 15 Mar 2023 08:15:39 +0000 (08:15 +0000)]
Fix command prompt not to always append argument but only if there has
actually been expansion. GitHub issue 3493.
tb [Wed, 15 Mar 2023 06:34:07 +0000 (06:34 +0000)]
Return the signature length after successful signing operation
This is required behavior of the EVP_DigestSign() API, but seemingly
almost nothing uses this. Well, turns out ldns does.
Reported by Stephane. Helpful comments by sthen.
ok jsing
tb [Wed, 15 Mar 2023 06:30:21 +0000 (06:30 +0000)]
Add comments that explain why things are done in this strange order.
There's some method to this madness.
ok jsing
tb [Wed, 15 Mar 2023 06:28:55 +0000 (06:28 +0000)]
Push calloc() of ndef_aux down as far as possible and
pull the setting of the ex_arg up, so we can do error
checking.
ok jsing
tb [Wed, 15 Mar 2023 06:22:42 +0000 (06:22 +0000)]
Error check BIO_asn1_set_{prefix,suffix}() calls
ok jsing
tb [Wed, 15 Mar 2023 06:14:02 +0000 (06:14 +0000)]
Streaming BIOs assume they can write to NULL BIOs
At least SMIME_text() relies on this. Pushing an error on the stack trips
PKCS7 regress in py-cryptography, so indicate nothing was written instead
of throwing an error.
Reported by Alex Gaynor a while back
ok jsing
jsing [Wed, 15 Mar 2023 04:30:20 +0000 (04:30 +0000)]
Ensure negative input to BN_mod_exp_mont_consttime() is correctly reduced.
A negative input to BN_mod_exp_mont_consttime() is not correctly reduced,
remaining negative (when it should be in the range [0, m)). Fix this by
unconditionally calling BN_nnmod() on the input.
Fixes ossfuzz #55997.
ok tb@
jsing [Wed, 15 Mar 2023 04:26:23 +0000 (04:26 +0000)]
Include tests with negative values in BN_mod_exp* regress.
This currently fails.
tb [Wed, 15 Mar 2023 00:41:04 +0000 (00:41 +0000)]
bn_mod_exp_zero: rename result into got
claudio [Tue, 14 Mar 2023 13:31:16 +0000 (13:31 +0000)]
Prep for rpki-client 8.3
kn [Tue, 14 Mar 2023 11:25:22 +0000 (11:25 +0000)]
WEP in bfwm(4) never worked, sync with reality
"ifconfig bwfm0 [-]nwkey ..." does not work and thus the installer no longer
offers WEP, so unmention support while leaving the recommendation against it.
dtucker [Tue, 14 Mar 2023 07:28:47 +0000 (07:28 +0000)]
Free KRL itself in addition to its contents. From Coverity CID 291841,
ok djm@
dtucker [Tue, 14 Mar 2023 07:26:25 +0000 (07:26 +0000)]
Check pointer for NULL before attempting to deref. None of the existing
callers seem to do that, but it's worth checking. From Coverity CID
291834, ok djm@
tb [Tue, 14 Mar 2023 07:09:11 +0000 (07:09 +0000)]
rpki-client: disallow AIA in self-signed certs
Per RFC 6487, 4.8.7, self-signed certificates must not have an Authority
Info Access extension. In normal operation this is ensured by ta_parse()
and cert_parse(), respectively. In filemode, only partial checks are
performed, so this is not guaranteed.
Issue flagged by and ok job
jmc [Tue, 14 Mar 2023 06:55:31 +0000 (06:55 +0000)]
sync the boot options list, and some macro fixes;
ok miod
deraadt [Tue, 14 Mar 2023 04:51:34 +0000 (04:51 +0000)]
sync
yasuoka [Tue, 14 Mar 2023 00:24:05 +0000 (00:24 +0000)]
To avoid misunderstanding, keep variables for tcp keepalive in
milliseconds, which is the same unit of tcp_now(). However, keep the
unit of sysctl variables in seconds and convert their unit in
tcp_sysctl(). Additionally revert TCPTV_SRTTDFLT back to 3 seconds,
which was mistakenly changed to 1.5 seconds by tcp_timer.h 1.19.
ok claudio
cheloha [Tue, 14 Mar 2023 00:11:58 +0000 (00:11 +0000)]
clockintr: add missing newline to ddb(4) printout
Let's also print the state (running, pending, or established) of each
clockintr.
job [Mon, 13 Mar 2023 21:01:06 +0000 (21:01 +0000)]
Don't lookup the signature path's expiry for trust anchor certs
job [Mon, 13 Mar 2023 20:55:14 +0000 (20:55 +0000)]
In filemode, also print details for .cer certificates
miod [Mon, 13 Mar 2023 20:32:28 +0000 (20:32 +0000)]
Point people to boot(8) rather than duplicating information.
miod [Mon, 13 Mar 2023 20:20:59 +0000 (20:20 +0000)]
Switch alpha to new boot blocks.
miod [Mon, 13 Mar 2023 20:20:13 +0000 (20:20 +0000)]
Add manual page.
miod [Mon, 13 Mar 2023 20:19:22 +0000 (20:19 +0000)]
"ask name" option letter is 'n' instead of 'a' on pmax and alpha for historical
(and firmware) reasons.
job [Mon, 13 Mar 2023 19:54:36 +0000 (19:54 +0000)]
Check that the CMS signing-time is not after the MFT's nextUpdate
Issuing manifests whose validity window is entirely in the past, as
observed from the purported CMS signing-time would be a form of backdating.
OK tb@
job [Mon, 13 Mar 2023 19:51:49 +0000 (19:51 +0000)]
In filemode, display the moment the signature path will expire
Previously this was only shown for ROA+ASPA. Now also show for
GBR, Geofeed, Certs, RSC, and TAK.
OK tb@
job [Mon, 13 Mar 2023 19:46:55 +0000 (19:46 +0000)]
Check that the CMS signing-time isn't after the X.509 notAfter
The CMS signing-time is the purported 'now' from the perspective of the
issuer. It doesn't make sense for an issuer to sign objects that have a
validity window that falls entirely in the past (from the perspective of
the signer). Although CMS signing-time is not a trusted timestamp, it
should never be after X.509 notAfter.
OK tb@
jmc [Mon, 13 Mar 2023 18:31:54 +0000 (18:31 +0000)]
typo fix; ok claudio
dv [Mon, 13 Mar 2023 18:09:41 +0000 (18:09 +0000)]
vmd(8): backout ns8250 changes.
This backs out commit h1IJwTVsYWfnRKWy which intended to fix interrupt
issues on slower host hardware. Unfortunately, this causes a race
condition on much faster host hardware. It still requires investigation.
With an "I told you so" about touching ns8250 from mlarkin@
job [Mon, 13 Mar 2023 18:02:58 +0000 (18:02 +0000)]
In filemode for ROAs/ASPAs display when the Signature path will expire
Also rename 'certification path' to 'signature path' for alignment
OK tb@
claudio [Mon, 13 Mar 2023 17:31:28 +0000 (17:31 +0000)]
Extend bgplgd to handle leaked and invalid options to show rib.
OK tb@
claudio [Mon, 13 Mar 2023 16:59:22 +0000 (16:59 +0000)]
Extend bgpctl show rib with two new options:
- invalid: show only routes that are not valid
- leaked: show only routes where a route leak was detected
OK tb@
claudio [Mon, 13 Mar 2023 16:52:41 +0000 (16:52 +0000)]
Add F_CTL_LEAKED and F_CTL_INELIGIBLE flags for bgpctl to show leaked
and ineligible paths.
While there rename F_PREF_OTC_LOOP to F_PREF_OTC_LEAK since this indicates
that a route leak was detected.
OK tb@
claudio [Mon, 13 Mar 2023 16:39:29 +0000 (16:39 +0000)]
Try to explain that the neighor role is required to enable both
ASPA validation and RFC9234 OTC leak detection and role capability.
The role on iBGP peers is forced to 'none' since it makes no sense there.
After input from benno@
job [Mon, 13 Mar 2023 15:50:40 +0000 (15:50 +0000)]
Merge calling print_certification_path() into adjacent else branch
OK tb@
mbuhl [Mon, 13 Mar 2023 14:58:01 +0000 (14:58 +0000)]
Fix potential underflow when printing STP data.
Reported by Peter J. Philipp
ok claudio
job [Mon, 13 Mar 2023 13:42:01 +0000 (13:42 +0000)]
Refactor whats printed when in filemode
OK tb@
claudio [Mon, 13 Mar 2023 13:36:56 +0000 (13:36 +0000)]
Fix usbpcap handler to properly detect overflows using TCHECK macros.
OK mpi@ mbuhl@
aoyama [Mon, 13 Mar 2023 11:59:39 +0000 (11:59 +0000)]
Add "machine poweroff" command on luna88k bootloader.
ok miod@
tb [Mon, 13 Mar 2023 10:39:03 +0000 (10:39 +0000)]
Revert accidental change from explicit to implicit tagging in r1.86.
ok job
job [Mon, 13 Mar 2023 09:24:37 +0000 (09:24 +0000)]
Rename some data fields to closer match their provenance
OK tb@
tb [Mon, 13 Mar 2023 07:31:09 +0000 (07:31 +0000)]
Stop confusing out and asn_bio in BIO_new_NDEF()
BIO_new_NDEF() sets up an ASN.1 BIO to the output chain and then adds even
more BIOs. Since BIO_push(bio, new_tail) returns bio on success, after the
if ((out = BIO_push(asn_bio, out)) != NULL) the 'out' BIO and the 'asn_bio'
are the same. The code then goes on and uses one or the other. This is very
confusing. Simply stop using out once it's appended to asn_bio.
ok jsing
kettenis [Mon, 13 Mar 2023 07:30:44 +0000 (07:30 +0000)]
regen
kettenis [Mon, 13 Mar 2023 07:30:11 +0000 (07:30 +0000)]
Add Kingston NV2 NVMe drive.
deraadt [Mon, 13 Mar 2023 04:15:44 +0000 (04:15 +0000)]
sync
cheloha [Sun, 12 Mar 2023 22:18:58 +0000 (22:18 +0000)]
sh, landisk: set HZ=64 again
The addition of HZ to sys/kernel.h in v1.26 overrides the default
definition of HZ in sh/clock.c, changing landisk from HZ=64 to HZ=100.
Explicitly set HZ=64 in the GENERIC and RAMDISK config(8) files to can
change it from 100 back to 64.
Not sure if this is the best thing, but it does fix the problem.
Problem confirmed by, and fix tested by, miod@.
ok miod@
jmc [Sun, 12 Mar 2023 20:14:41 +0000 (20:14 +0000)]
correct macro request (.nm -> .Nm);
kettenis [Sun, 12 Mar 2023 19:02:34 +0000 (19:02 +0000)]
rkcomphy(4)
tb [Sun, 12 Mar 2023 17:29:02 +0000 (17:29 +0000)]
pk7_cb() and cms_cb()
Add and fix FALLTHROUGH statement. I was confused for way too long since
I hadn't noticed that this case fell through to the next. Also add and
move some empty lines in the cms_cb() to make this resemble KNF more.
kettenis [Sun, 12 Mar 2023 14:29:50 +0000 (14:29 +0000)]
Add rkcomphy(3), a driver for the "naneng" combo PHY found on the RK356x
(and RK3588). This is a PIPE PHY with support for PCIe, SATA, USB3, SGMII
and QSGMII. For now only PCIe, SATA and USB3 support are implemented.
SATA support has not been tested.
Also add the refernce clocks needed by the PHYs to rkclock(4).
ok mlarkin@
tb [Sun, 12 Mar 2023 13:31:39 +0000 (13:31 +0000)]
zap a tab
job [Sun, 12 Mar 2023 12:11:45 +0000 (12:11 +0000)]
Alphabetically sort various bits and pieces - mechanical change
Might make later refactors easier to follow
OK tb@
job [Sun, 12 Mar 2023 11:55:34 +0000 (11:55 +0000)]
Add crl.c in various places to gain access to the new helper
job [Sun, 12 Mar 2023 11:54:56 +0000 (11:54 +0000)]
Refactor expiration calculation
Unify common code paths which find the exact expiry moment into a new
helper function. Additionally, the new helper offers more accuracy by
checking more applicable CRLs whether their 'nextupdate' is 'sooner'.
tb@ noted: The helper adds a multiplier of log(#crls), but that's
certainly acceptable as it is still very cheap.
OK tb@
tb [Sun, 12 Mar 2023 11:49:02 +0000 (11:49 +0000)]
Avoid an 1 byte out-of-bounds read in ASN1_PRINTABLE_type()
In case the input is not NUL terminated, the reversed check for length
and terminating NUL results in a one-byte overread. The documentation
says that the input should be a string, but in ASN.1 land you never
know...
Reported by Guido Vranken a while back
ok beck
tb [Sun, 12 Mar 2023 11:46:35 +0000 (11:46 +0000)]
Initialize the local signtime variable in the individual *_parse()
functions
ok job
tb [Sun, 12 Mar 2023 11:45:52 +0000 (11:45 +0000)]
Invalidate the signtime output parameter in cms_parse_validate_internal()
and in cms_get_signtime().
ok job
jmatthew [Sun, 12 Mar 2023 10:50:06 +0000 (10:50 +0000)]
Enable mvtemp(4)
jmatthew [Sun, 12 Mar 2023 10:49:05 +0000 (10:49 +0000)]
Update supported hardware list and fix spelling of Marvell while I'm here
jmatthew [Sun, 12 Mar 2023 10:46:27 +0000 (10:46 +0000)]
Match on the Armada 380 temperature sensor, which works the same as the
CP110 sensor.
ok kettenis@
dtucker [Sun, 12 Mar 2023 10:40:39 +0000 (10:40 +0000)]
Put upper bound on number of entries in SSH2_MSG_EXT_INFO request.
This is already constrained by the maximum SSH packet size but this
makes it explicit. Prompted by Coverity CID 291868, ok djm@ markus@
dtucker [Sun, 12 Mar 2023 09:41:18 +0000 (09:41 +0000)]
calloc can return NULL but xcalloc cannot. From Coverity CID 291881,
ok djm@
tb [Sat, 11 Mar 2023 21:14:26 +0000 (21:14 +0000)]
Remove a few extra spaces
miod [Sat, 11 Mar 2023 20:56:01 +0000 (20:56 +0000)]
New alpha secondary boot blocks using the MI code base. Not linked to the
build yet.
miod [Sat, 11 Mar 2023 20:52:02 +0000 (20:52 +0000)]
Remove long dead "tool".
miod [Sat, 11 Mar 2023 20:49:33 +0000 (20:49 +0000)]
Allow strip and objcopy to be overrridden, for easier cross-buildability. NFC
tb [Sat, 11 Mar 2023 16:29:48 +0000 (16:29 +0000)]
Switch an early return into goto err
tb [Sat, 11 Mar 2023 16:02:06 +0000 (16:02 +0000)]
Tiny cleanup for readability
Turn a malloc() into calloc() and check two function calls directly
forever instead of a combined check afterward.
tb [Sat, 11 Mar 2023 15:56:03 +0000 (15:56 +0000)]
Use "if (ptr == NULL)" instead of "if (!ptr)"
Requested by jsing
tb [Sat, 11 Mar 2023 15:50:13 +0000 (15:50 +0000)]
Fix double free after BIO_new_NDEF()
Once the asn_bio is prepended to the out chain, and before the asn1_cb()
has done its thing, asn_bio needs to be popped off again on error. Failing
to do this can cause write after frees or double frees when the out BIO
is used after the function returned.
Based on a very complicated diff by Matt Caswell and Viktor Dukhovni.
This was part of the fixes in OpenSSL 1.1.1t.
ok jsing
tb [Sat, 11 Mar 2023 15:29:03 +0000 (15:29 +0000)]
Fix an off-by-one in dsa_check_key()
The private key is a random number in [1, q-1], so 1 must be allowed.
Since q is at least an 160-bit prime and 2^159 + 1 is not prime (159
is not a power of 2), the probability that this is hit is < 2^-159,
but a tiny little bit wrong is still wrong.
Found while investigating a report by bluhm
ok jsing
jsing [Sat, 11 Mar 2023 14:29:02 +0000 (14:29 +0000)]
Call CRYPTO_cleanup_all_ex_data() from OPENSSL_cleanup().
Issue reported by Graham Percival (@gperciva)
ok tb@
jsing [Sat, 11 Mar 2023 14:27:37 +0000 (14:27 +0000)]
Add OPENSSL_cleanup() calls to some regress.
This gets us some minimal test coverage.
jsing [Sat, 11 Mar 2023 14:14:54 +0000 (14:14 +0000)]
Avoid -0 in BN_div_word().
Currently, the use of BN_div_word() can result in -0 - avoid this by
setting negative again, at the end of the computation.
Should fix oss-fuzz 56667.
ok tb@
jsing [Sat, 11 Mar 2023 14:13:11 +0000 (14:13 +0000)]
Correct sign handling in BN_add_word().
A sign handling bug was introduced to BN_add_word() in bn_word.c r1.18.
When handling addition to a negative bignum, the BN_sub_word() call can
result in the sign being flipped, which we need to account for. Use the
same code in BN_sub_word() - while not technically needed here it keeps
the code consistent.
Issue discovered by tb@
ok tb@
jsing [Sat, 11 Mar 2023 14:05:02 +0000 (14:05 +0000)]
Remove a pesky space.
jsing [Sat, 11 Mar 2023 14:04:21 +0000 (14:04 +0000)]
Add regress coverage for BN_{add,sub,mul,div,mod}_word().
This also provides some indirect coverage for BN_hex2bn(), BN_bn2hex() and
BN_get_word().
Two of these tests are currently failing and will be fixed shortly.
jsing [Sat, 11 Mar 2023 14:02:26 +0000 (14:02 +0000)]
Mark test table as static const.
aoyama [Sat, 11 Mar 2023 10:33:27 +0000 (10:33 +0000)]
Add missing $OpenBSD$ tag.
claudio [Sat, 11 Mar 2023 10:06:17 +0000 (10:06 +0000)]
Bump version to 7.8