jmc [Thu, 29 Jun 2017 15:32:36 +0000 (15:32 +0000)]
some kernel relink bits, tweaked by deraadt;
schwarze [Thu, 29 Jun 2017 15:21:46 +0000 (15:21 +0000)]
warn about some non-portable idioms in .Bl -column;
triggered by a question from Yuri Pankov (illumos)
krw [Thu, 29 Jun 2017 13:55:53 +0000 (13:55 +0000)]
delete_addresses(), interface_status(), addressinuse(),
lease_as_string() and rewrite_option_db() only use the
interface name, so supply just the name.
Tweak interface_link_forceup() to use the same param
name as other functions taking the interface name.
schwarze [Thu, 29 Jun 2017 13:16:39 +0000 (13:16 +0000)]
Clarify that .Ta as a line macro is a portability problem,
even though mandoc(1) handles it;
triggered by a question from Yuri Pankov (illumos).
deraadt [Thu, 29 Jun 2017 13:04:09 +0000 (13:04 +0000)]
0xd4d4d4d4 is a useful 'trap instruction' on arm64, but not on arm32.
0xffffffff seems better in userland and kernel. still not exactly happy
with the situation.
long discussion with kettenis. anyone else have an opinion?
visa [Thu, 29 Jun 2017 10:56:18 +0000 (10:56 +0000)]
Always use the maximum permissible frame size for Rx size limit.
This lets a change of interface MTU take effect immediately without
link cycling and brings cnmac(4) into line with other jumbo frame
capable NIC drivers.
Prompted by Joe Holden on misc@
OK dlg@
tb [Thu, 29 Jun 2017 08:45:20 +0000 (08:45 +0000)]
Move <fcntl.h> to its alphabetic spot and add __dead attribute to usage()
ok mestre
mlarkin [Thu, 29 Jun 2017 08:24:10 +0000 (08:24 +0000)]
add some comments, no functional change
mlarkin [Thu, 29 Jun 2017 08:14:36 +0000 (08:14 +0000)]
suppress local symbols in mptramp. Matches a similar diff in
acpi_wakecode.s that was committed previously. Also remove an extra
symbol (mp_tramp_pdirpa) that was duplicated with mp_pdirpa.
Tested MP boot, un-zzz, un-ZZZ, no issues seen.
mlarkin [Thu, 29 Jun 2017 07:51:59 +0000 (07:51 +0000)]
suppress local symbols in mptramp. Matches a similar diff in
acpi_wakecode.s that was committed previously.
Tested MP boot, un-zzz, un-ZZZ, no issues seen.
mlarkin [Thu, 29 Jun 2017 07:19:40 +0000 (07:19 +0000)]
Remove a block of "#if 0" code that has been in the file since r1.1, 13
years ago. This was part of the original reset code port from i386, and
we've never been able to reset amd64 in the way the code tries to do in
the #if 0 block since we don't have a 'PTD' variable in amd64.
I thought to keep this around for diffability with i386, but that's pretty
pointless now as the diff between the two machdep.c files is over 5000
lines already...
mlarkin [Thu, 29 Jun 2017 07:11:24 +0000 (07:11 +0000)]
Remove an "#if 1" that had been in the code for 16 years. I think it's
safe to say it's been enabled long enough to warrant permanent inclusion.
jmc [Thu, 29 Jun 2017 07:01:49 +0000 (07:01 +0000)]
spelling fix; from greg lehey, freebsd r320427;
mlarkin [Thu, 29 Jun 2017 06:15:30 +0000 (06:15 +0000)]
hide some locore0 symbols that are only used inside locore0.
ok deraadt
deraadt [Thu, 29 Jun 2017 05:40:35 +0000 (05:40 +0000)]
TEMPORARILY disable gap compilation, until lld is fixed/updated to
newer code with a variety of ld.script bugs fixed.
bentley [Thu, 29 Jun 2017 04:24:31 +0000 (04:24 +0000)]
Fix incorrectly swapped labels of left/right arrows.
ok schwarze@
deraadt [Thu, 29 Jun 2017 04:23:12 +0000 (04:23 +0000)]
Switch TIOCSTAT to _IO(). Two decades ago it was mistakenly defined to
take an argument. Discussed with millert and tedu.
deraadt [Thu, 29 Jun 2017 04:10:07 +0000 (04:10 +0000)]
Due to risks known for decades, TIOCSTI now performs no action, and simply
returns EIO. The base system has been cleaned of TIOCSTI uses (collaboration
between anton and I), and the ports tree appears mostly clean. A few
stragglers may be discovered and cleaned up later...
In a month or so, we should see if the #define can be removed entirely.
ok anton tedu, support from millert
tedu [Thu, 29 Jun 2017 03:48:44 +0000 (03:48 +0000)]
set c.c_maxrxlen to something. apparently lost a line somewhere.
maybe it works now? :)
from Colin Stolley via Paul B. Henson
dlg [Thu, 29 Jun 2017 01:25:59 +0000 (01:25 +0000)]
take const off the timeval argument in the pending functions.
event_pending, evtimer_pending, and signal_pending all write to the
timeval because that's how they tell the caller when the event is
meant to fire.
ok deraadt@ millert@ jmc@ schwarze@
mikeb [Wed, 28 Jun 2017 19:30:24 +0000 (19:30 +0000)]
Introduce a simple mechanism to select the appropriate queue manager
Discussed with and OK henning@ at d2k17 as a part of a larger diff.
mikeb [Wed, 28 Jun 2017 19:27:42 +0000 (19:27 +0000)]
Tighten up FQ-CoDel vs HFSC checks
PFQS_FLOWQUEUE is about to become a flag that HFSC classes may specify
as well; thus a better way of telling FQ-CoDel and HFSC apart needs to
be found. At the moment its derived from the queue specification.
Discussed with and OK henning@ at d2k17 as a part of a larger diff.
mikeb [Wed, 28 Jun 2017 19:13:35 +0000 (19:13 +0000)]
Provide pf queue manager API
Discussed with and OK henning@ at d2k17 as a part of a larger diff.
mikeb [Wed, 28 Jun 2017 18:31:03 +0000 (18:31 +0000)]
Extend pf queueing ops to include queue manager hooks
Discussed with and OK henning@ at d2k17 as a part of a larger diff.
mikeb [Wed, 28 Jun 2017 18:24:02 +0000 (18:24 +0000)]
hfsc.c should depend on pf instead of inet
Discussed with and OK henning@ at d2k17 as a part of a larger diff.
jmc [Wed, 28 Jun 2017 17:54:31 +0000 (17:54 +0000)]
reinstate .El removed in previous;
nicm [Wed, 28 Jun 2017 17:28:39 +0000 (17:28 +0000)]
Test for file from stdin.
brynet [Wed, 28 Jun 2017 17:14:15 +0000 (17:14 +0000)]
Fix stdin file read support, accidentally broken in my last commit.
krw [Wed, 28 Jun 2017 16:31:52 +0000 (16:31 +0000)]
Only pass required fields of interface_info to priv_* functions
and friends. i.e. ifi->name, ifi->rdomain, or both.
krw [Wed, 28 Jun 2017 15:45:32 +0000 (15:45 +0000)]
delete_route() doesn't need any info from its struct interface_info
parameter as the route message already has the correct tableid. So
eliminate the useless parameter.
deraadt [Wed, 28 Jun 2017 15:42:49 +0000 (15:42 +0000)]
remove excess #include
deraadt [Wed, 28 Jun 2017 15:40:54 +0000 (15:40 +0000)]
perform an initial pledge very early on, and drop tzset to later.
ok nicm brynet
krw [Wed, 28 Jun 2017 15:23:19 +0000 (15:23 +0000)]
resolv_conf_priority() is a function local to kroute.c, no
need to expose its definition in dhcpd.h. While here change
the parameter from struct interface_info to int and just pass
the only field used (rdomain).
anton [Wed, 28 Jun 2017 15:09:41 +0000 (15:09 +0000)]
Add regression tests for mail.
anton [Wed, 28 Jun 2017 14:58:23 +0000 (14:58 +0000)]
Replace usage of TIOCSTI in mail while editing headers using a more common
IO-loop where ICANON is disabled and a single char of input is read at a time.
This requires the line editing capabilities provided when ICANON is enabled to
be implemented.
ok deraadt@
schwarze [Wed, 28 Jun 2017 14:49:26 +0000 (14:49 +0000)]
Remove the nonsensical "-s - -" in the third example; quirk reported
by Redouan Ait Mallouk <raitmallouk at gmail dot com>.
The paste(1) utility allows two equivalent solutions for many tasks
involving only one input stream; while here, make that more obvious
by always showing both solutions.
krw [Wed, 28 Jun 2017 14:35:43 +0000 (14:35 +0000)]
Stop trying to clean up addresses, routes and "-L" file
whenever dhclient dies. Eliminates differences in handling
and thus need to intercept signals INT, TERM, USR1,
USR2. Eliminates need for 'zapzombies' field and thus
entire struct imsg_flushroutes. Eliminates need for 'imsg'
parameter to and associated logic in priv_flush_routes().
Address, routes and '-L' file are still cleaned out when
binding a lease.
jmc [Wed, 28 Jun 2017 14:07:11 +0000 (14:07 +0000)]
remove a contradictory sentence (see dhcp-options(5)) which claims
hostnames which resolve to muliple ip addresses are all forwarded to
the client;
issue reported by edgar pettijohn;
discussed with dhcpd's de facto maintainer, kenneth westerback;
brynet [Wed, 28 Jun 2017 13:37:56 +0000 (13:37 +0000)]
Simplify file(1) by removing the no longer necessary parent/child separation
and just drop privileges in the main process.
Also allows for a tighter "stdio" pledge.
passing regress tests still pass
ok nicm@ with helpful feedback
deraadt [Wed, 28 Jun 2017 13:34:50 +0000 (13:34 +0000)]
.init stub creation doesn't need a jmp + .align to reach a branch target,
just fall into the code. The .align created a FILL zone in the .init section,
which on i386 was filled with a NOP-sled, something we want to get away
from.
discussed with kettenis and tom
krw [Wed, 28 Jun 2017 12:53:46 +0000 (12:53 +0000)]
Consistently use socket(..., AF_INET) for routing
sockets to cut down on unwanted IPv6 messages.
suggested by & ok claudio@
schwarze [Wed, 28 Jun 2017 12:52:27 +0000 (12:52 +0000)]
fix incomplete handling of roff(7) nodes in man(7) block next-line scope;
assertion failure in tclsh(1) reported by deraadt@ via bentley@
krw [Wed, 28 Jun 2017 11:53:08 +0000 (11:53 +0000)]
Be consistent and always use socket(..., SOCK_DGRAM, ...) for
the sockets being used to issue ioctl()'s.
ok claudio@
nicm [Wed, 28 Jun 2017 11:36:39 +0000 (11:36 +0000)]
Apply the xterm key flag when needed for send-keys, fixes problem
reported by Franky Spamschleuder.
benno [Wed, 28 Jun 2017 11:10:08 +0000 (11:10 +0000)]
whitespace fixes, from Rob Pierce and me
benno [Wed, 28 Jun 2017 10:38:16 +0000 (10:38 +0000)]
usage() gets __dead attribute, from Rob Pierce
espie [Wed, 28 Jun 2017 10:34:10 +0000 (10:34 +0000)]
and emphasize that PKGDIR must exist.
espie [Wed, 28 Jun 2017 10:33:08 +0000 (10:33 +0000)]
document generate-readmes and diagnostic for missing PKGDIR.
aoyama [Wed, 28 Jun 2017 10:31:48 +0000 (10:31 +0000)]
Delete '0x' in DIAGNOSTIC panic message; ipl value is printed in decimal.
espie [Wed, 28 Jun 2017 10:24:23 +0000 (10:24 +0000)]
extra step between fake and package
mlarkin [Wed, 28 Jun 2017 08:51:36 +0000 (08:51 +0000)]
hide symbols in the acpi trampoline pages. matches a previous diff from
amd64.
tested un-zzz and un-ZZZ on i386 VM, no issues seen.
ok deraadt
espie [Wed, 28 Jun 2017 07:40:08 +0000 (07:40 +0000)]
move all the post-Configure stuff to Makefile.bsd-wrapper1 instead of just
the man parts.
just leave Configure and forwarding targets in Makefile.bsd-wrapper,
this allows bsd.lib.mk to function normally without depend, because all
the puzzle is here.
okay millert@ afresh1@
espie [Wed, 28 Jun 2017 07:37:38 +0000 (07:37 +0000)]
if we return nullptr for a "noexec" section, then don't change section.
prevents core dumps :)
okay tedu@
mlarkin [Wed, 28 Jun 2017 07:16:58 +0000 (07:16 +0000)]
hide symbols used in the ACPI resume trampoline pages
ok deraadt@
mlarkin [Wed, 28 Jun 2017 07:10:02 +0000 (07:10 +0000)]
fix potential use of uninitialized variable, noticed by jsg@.
nicm [Wed, 28 Jun 2017 06:45:31 +0000 (06:45 +0000)]
Fix visual-silence (check accidentally the wrong way round), from Brad
Town. Plus some tmux.1 fixes from jmc@.
jmc [Wed, 28 Jun 2017 06:24:38 +0000 (06:24 +0000)]
add -v to SYNOPSIS and STANDARDS;
djm [Wed, 28 Jun 2017 01:09:22 +0000 (01:09 +0000)]
Allow ssh-keygen to use a key held in ssh-agent as a CA when signing
certificates. bz#2377 ok markus
schwarze [Wed, 28 Jun 2017 00:59:30 +0000 (00:59 +0000)]
Rewrite half of this, i was completely unaware how bad it was.
Remove several lies, lots of duplicate information,
and a lengthy discussion of features we don't support.
Clarify the wording in some places and make it more concise in others.
Delete examples from where they don't belong
and write a new EXAMPLES section from scratch.
tedu [Tue, 27 Jun 2017 22:18:24 +0000 (22:18 +0000)]
remove the obsolete timeslot ioctl
tedu [Tue, 27 Jun 2017 21:49:47 +0000 (21:49 +0000)]
fix a few lines of unusual length
tedu [Tue, 27 Jun 2017 21:43:46 +0000 (21:43 +0000)]
add a -v verbose flag to cp, mv, and rm. useful for monitoring progress,
and present on several other systems. some ok, some less ok.
from Job Snijders
benno [Tue, 27 Jun 2017 20:46:34 +0000 (20:46 +0000)]
Hoist some privileged code in preparation for future work.
Based on an approach in vmd with mc146818/ns8250.
diff by Rob Pierce <rob -AT- 2keys -DOT- ca>
ok deraadt@
schwarze [Tue, 27 Jun 2017 19:51:28 +0000 (19:51 +0000)]
test inter-column spacing
schwarze [Tue, 27 Jun 2017 18:23:29 +0000 (18:23 +0000)]
Implement spacing of columns as defined in the table layout;
this is for example used by lftp(1)
and, ironically, misused by our very own tbl(7) manual...
deraadt [Tue, 27 Jun 2017 16:43:29 +0000 (16:43 +0000)]
trapsleds for clang, similar to the change on gas side.
Also from Todd Mortimer
tested by espie
tb [Tue, 27 Jun 2017 16:02:05 +0000 (16:02 +0000)]
Remove an extra '\n' from the printf strings fed into disklabel -E
from corsah () mail ! ru
deraadt [Tue, 27 Jun 2017 15:58:07 +0000 (15:58 +0000)]
move a global into local context; from rob pierce
krw [Tue, 27 Jun 2017 15:56:15 +0000 (15:56 +0000)]
Make if_register_bpf() the same as the other if_register_*() functions
by directly assigning the socket fd to ifi->bfdesc rather than
returning it and having the caller do the assignment.
anton [Tue, 27 Jun 2017 15:02:18 +0000 (15:02 +0000)]
Tweak previous: align declarations and rename local variable.
deraadt [Tue, 27 Jun 2017 14:37:08 +0000 (14:37 +0000)]
in recently commited TIOCSTI replacement code, do not assume
little-endian or unsigned char :-)
ok anton
mikeb [Tue, 27 Jun 2017 13:56:15 +0000 (13:56 +0000)]
Provide a handler stub for the "channel rescind" message
bluhm [Tue, 27 Jun 2017 13:28:02 +0000 (13:28 +0000)]
Convert ip6_input() to a pr_input style function. Goal is to process
IPsec packets without additional enqueueing.
OK mpi@
krw [Tue, 27 Jun 2017 13:24:49 +0000 (13:24 +0000)]
Nuke get_rdomain() and just snag the interface rdomain from the same
ifa we use to get the interface hw address. One less socket() and
ioctl()! MIssed cleanup from shift to just watching RTM_IFINFO
messages for rdomain switch.
schwarze [Tue, 27 Jun 2017 12:17:35 +0000 (12:17 +0000)]
warn about .Ns macros that have no effect because they are followed
by an isolated closing delimiter; inspired by mdoclint
jsg [Tue, 27 Jun 2017 12:10:21 +0000 (12:10 +0000)]
Avoid the possibility of accessing an array out of bounds.
Found with cppcheck. ok krw@
jsg [Tue, 27 Jun 2017 12:04:26 +0000 (12:04 +0000)]
Avoid testing an uninitialised variable in the SCSI_BUSY/SCSI_QUEUE_FULL
paths of hvs_scsi_cmd_done().
ok mikeb@
mpi [Tue, 27 Jun 2017 12:02:43 +0000 (12:02 +0000)]
Add missing solock()/sounlock() dances around sbreserve().
While here document an abuse of parent socket's lock.
Problem reported by krw@, analysis and ok bluhm@
schwarze [Tue, 27 Jun 2017 11:48:00 +0000 (11:48 +0000)]
remove -DSw; the useful parts are now covered by mandoc;
discussed with jmc@
deraadt [Tue, 27 Jun 2017 06:12:51 +0000 (06:12 +0000)]
throw strip into base, until we consider a solution for the
linkkit bsd.gdb strip gongshow
deraadt [Tue, 27 Jun 2017 04:22:13 +0000 (04:22 +0000)]
the illegal instruction is 0x00000000
tedu [Tue, 27 Jun 2017 03:42:00 +0000 (03:42 +0000)]
remove some old cruft.
mikeb [Mon, 26 Jun 2017 20:12:14 +0000 (20:12 +0000)]
Minor cleanup; when polling delay before calling the interrupt handler
schwarze [Mon, 26 Jun 2017 20:11:23 +0000 (20:11 +0000)]
catch up with the recent eqn(7) improvements
schwarze [Mon, 26 Jun 2017 19:53:00 +0000 (19:53 +0000)]
Complete rewrite of the lexer in a single function with four operation
modes instead of four functions, resulting in considerable
simplification, fifty lines less of code, fifteen fewer automatic
variables, and several bug fixes, for example:
1. The delim control statement consumes exactly two bytes of input,
requires no whitespace after these two bytes, and does not treat
quotes in any special way.
2. If the argument of left, right, gfont, gsize, or size is defined
as an alias, only the first word of the value is used as the
delimiter, font name, or font size.
3. If a back, fwd, down, or up keyword is followed by another keyword
instead of the required number, GNU eqn does nothing useful, but
typically errors out. So no need to have special handling (with
an ugly goto!) for it in mandoc.
Also getting rid of one pointless static buffer and twelve redundant
calls to strlcpy(3).
bluhm [Mon, 26 Jun 2017 19:06:12 +0000 (19:06 +0000)]
Convert ip_input() to a pr_input style function. Goal is to process
IPsec packets without additional enqueueing.
OK mpi@
mikeb [Mon, 26 Jun 2017 18:42:23 +0000 (18:42 +0000)]
Rework the deferred interrupt loop
By performing a task_add an interrupt handler can rely on the
taskq_thread to invoke it again with an additional benefit of
being able to sched_pause when required. In the long run more
than 99.8% of calls do not require an additional iteration.
bluhm [Mon, 26 Jun 2017 18:33:24 +0000 (18:33 +0000)]
Fragments for a single connection (a combination of proto,src,dst,af)
may easily reuse the fragment id as it is only 16 bit for IPv4. To
avoid that pf reassembles them into the wrong packet, throw away
stale fragments. With the default timeout this happens after 12,000
newer fragements have been seen.
from markus@; OK sashan@
rpe [Mon, 26 Jun 2017 18:31:57 +0000 (18:31 +0000)]
Add a MDKERNEL variable that contains the name of the boot kernel.
This will be used by the installer in an upcoming change.
OK deraadt@
tb [Mon, 26 Jun 2017 17:00:49 +0000 (17:00 +0000)]
RANDOM1 was subject to rather bad modulus bias. Improve the situation a bit
by implementing an arc4random_uniform(3) clone with beloved jot(1) and
using it.
discussed with and ok deraadt
visa [Mon, 26 Jun 2017 16:54:31 +0000 (16:54 +0000)]
Arrange a phandle for the "ciu" node.
deraadt [Mon, 26 Jun 2017 16:14:24 +0000 (16:14 +0000)]
note.ABI-tag and .MIPS.options are not needed anymore when
we use gapdummy.o
bluhm [Mon, 26 Jun 2017 14:12:35 +0000 (14:12 +0000)]
When pinging an IPv6 link-local address, the reflected packet had
::1 as source address. It should be the link-local address of the
attached interface. The rtalloc() in icmp6_reflect() did not find
the correct local address. The IPv6 routing table does not use
sin6_scope_id, but the embedded scope. So do not recover the scope.
bug report Harald Dunkel; OK mpi@
schwarze [Mon, 26 Jun 2017 11:04:26 +0000 (11:04 +0000)]
when splitting a composite word,
do not forget to close the inserted list box
phessler [Mon, 26 Jun 2017 10:09:13 +0000 (10:09 +0000)]
don't print the WELLKNOWN string for unknown well-known communities
from Job Snijders
ok phessler@ benno@
phessler [Mon, 26 Jun 2017 10:08:06 +0000 (10:08 +0000)]
let admins set an unknown well-known community
from Job Snijders
ok phessler@ benno@
phessler [Mon, 26 Jun 2017 10:05:57 +0000 (10:05 +0000)]
add support for the "graceful shutdown" well-known community as described
in draft-ietf-grow-bgp-gshut
from Job Snijders
ok phessler@ benno@
phessler [Mon, 26 Jun 2017 10:04:21 +0000 (10:04 +0000)]
allow setting localpref to 0
from Job Snijders
ok phessler@ benno@
mpi [Mon, 26 Jun 2017 09:32:31 +0000 (09:32 +0000)]
Assert that the corresponding socket is locked when manipulating socket
buffers.
This is one step towards unlocking TCP input path. Note that all the
functions asserting for the socket lock are not necessarilly MP-safe.
All the fields of 'struct socket' aren't protected.
Introduce a new kernel-only kqueue hint, NOTE_SUBMIT, to be able to
tell when a filter needs to lock the underlying data structures. Logic
and name taken from NetBSD.
Tested by Hrvoje Popovski.
ok claudio@, bluhm@, mikeb@
patrick [Mon, 26 Jun 2017 09:17:55 +0000 (09:17 +0000)]
Allow updating the destination address of an existing TDB. Since the
destination address is used as an index when looking for a TDB, we need
to supply the new destination address in a different member. For this,
re-use the proxy address, that so far no one else has been using. It
would make sense to rename this member in the future.
ok claudio@