openbsd
14 months agosorry, somehow I did redo this line badly and didn't retest
espie [Mon, 23 Oct 2023 21:53:54 +0000 (21:53 +0000)]
sorry, somehow I did redo this line badly and didn't retest

14 months agocreate __OpenBSD__ versions that use futex() with the correct number
deraadt [Mon, 23 Oct 2023 20:40:24 +0000 (20:40 +0000)]
create __OpenBSD__ versions that use futex() with the correct number
of arguments and without using syscall().  the glibc people should be
ashamed of the mess they created.
ok miod

14 months agoonce again, i forgot to update the date in the footer
schwarze [Mon, 23 Oct 2023 20:15:36 +0000 (20:15 +0000)]
once again, i forgot to update the date in the footer

14 months agoSupport some escape sequences, in particular character escape sequences,
schwarze [Mon, 23 Oct 2023 20:07:18 +0000 (20:07 +0000)]
Support some escape sequences, in particular character escape sequences,
inside \w arguments, and skip most other escape sequences when measuring
the output length in this way because most escape sequences contribute
little or nothing to text width: for example, consider font escapes in
terminal output.

This implementation is very rudimentary.  In particular, it assumes that
every character has the same width.  No attempt is made to detect
double-width or zero-width Unicode characters or to take dependencies on
output devices or fonts into account.  These limitations are hard to
avoid because mandoc has to interpolate \w at the parsing stage when the
output device is not yet known.  I really do not want the content of the
syntax tree to depend on the output device.

Feature requested by Paul <Eggert at cs dot ucla dot edu>, who also
submitted a patch, but i chose to commit this very different patch
with almost the same functionality.
His input was still very valuable because complete support for \w is
out of the question, and consequently, the main task is identifying
subsets of the feature that are needed for real-world manual pages
and can be supported without uprooting the whole forest.

14 months agoRevert Subst.pm r1.22. It broke ordinary pkg_add usage
tb [Mon, 23 Oct 2023 19:45:28 +0000 (19:45 +0000)]
Revert Subst.pm r1.22. It broke ordinary pkg_add usage

14 months agoUse xoff instead of *olen in the shift_right() call. xoff is the right
claudio [Mon, 23 Oct 2023 13:07:44 +0000 (13:07 +0000)]
Use xoff instead of *olen in the shift_right() call. xoff is the right
value here since *olen is (conditionally) set a few lines later to the
same value as xoff.

Should fix the CodeQL warnings because *olen is dereferenced without
proper NULL check.

OK tb@

14 months agoUse private key that is allowed by sshd defaults in conch interop tests.
anton [Mon, 23 Oct 2023 11:30:49 +0000 (11:30 +0000)]
Use private key that is allowed by sshd defaults in conch interop tests.

ok dtucker@

14 months agoPrevent wg(4) stuck on peer destruction.
mvs [Mon, 23 Oct 2023 10:22:05 +0000 (10:22 +0000)]
Prevent wg(4) stuck on peer destruction.

While interface going down and output stopped, packets could rest in
`if_snd' queue. So the (!ifq_empty(&sc->sc_if.if_snd)) condition will
always be true and wg_peer_destroy() will sleep until interface became
up and stuck packets transmitted.

Check IFF_RUNNING flag within (!ifq_empty(&sc->sc_if.if_snd)) loop in
wg_peer_destroy(). If the flag is not set that means interface is down,
so drain the `if_snd' queue manually to prevent wg_peer_destroy() stuck.

Problem reported and fix tested by Kirill Miazine.

ok bluhm@

14 months agouse more natural (and new) += with REGRESSION_TESTING
espie [Mon, 23 Oct 2023 08:38:58 +0000 (08:38 +0000)]
use more natural (and new) += with REGRESSION_TESTING

14 months agosplit on spaces as well, to take advantage of +=
espie [Mon, 23 Oct 2023 08:38:14 +0000 (08:38 +0000)]
split on spaces as well, to take advantage of +=

14 months agoadd some limited capability to -DVAR+=value
espie [Mon, 23 Oct 2023 08:37:45 +0000 (08:37 +0000)]
add some limited capability to -DVAR+=value
to be used with REGRESSION_TESTING, where it's somewhat inconvenient to
know the full list in advance.

14 months agoUnzoom window at start of destroy so it doesn't happen later (when
nicm [Mon, 23 Oct 2023 08:12:00 +0000 (08:12 +0000)]
Unzoom window at start of destroy so it doesn't happen later (when
destroying panes) after the layout has been freed, GitHub issue 3717.

14 months agoFix radiusd(8) to fixup MPPE-{Send,Recv}-Key and Tunnel-Password
yasuoka [Mon, 23 Oct 2023 00:58:32 +0000 (00:58 +0000)]
Fix radiusd(8) to fixup MPPE-{Send,Recv}-Key and Tunnel-Password
attributes of the response properly.

14 months agobt(5), btrace(8): execute END probe and print non-empty maps upon exit()
cheloha [Sun, 22 Oct 2023 19:30:35 +0000 (19:30 +0000)]
bt(5), btrace(8): execute END probe and print non-empty maps upon exit()

BPFTrace's exit() statement executes the END probe (if any) and prints
the contents of all non-empty maps before terminating the interpreter.

Implement this in btrace(8) with a halting check after each statement.
If a statement causes the program to halt, the condition bubbles up to
the top-level evaluation loop and causes rules_teardown() to run
immediately.

btrace(8) still performs a full rules_setup() if exit() is called
during the BEGIN probe, though the top-level evaluation loop is never
run.

One edge-like case: an exit() from the END probe is treated as an
early return; END is not executed multiple times.

Thread: https://marc.info/?l=openbsd-tech&m=169765169420751&w=2

ok mpi@

14 months agonew regression test for roff.c rev. 1.270:
schwarze [Sun, 22 Oct 2023 16:54:19 +0000 (16:54 +0000)]
new regression test for roff.c rev. 1.270:
infinite recursion in macro argument expansion

14 months agoWhile doing delayed expansion of escape sequences in macro arguments,
schwarze [Sun, 22 Oct 2023 16:01:58 +0000 (16:01 +0000)]
While doing delayed expansion of escape sequences in macro arguments,
correctly check for failure of the in-place expansion function.
If an argument not only does recursive delayed expansion
but infinitely recursive delayed expansion, this bug could
result in an ESCAPE_EXPAND assertion failure.

Thanks to Eric van Gyzen <vangyzen at FreeBSD> for finding this bug
by inspecting FreeBSD source code.

14 months agocorrect Va in previous;
jmc [Sun, 22 Oct 2023 14:04:52 +0000 (14:04 +0000)]
correct Va in previous;

14 months agoA few more tests
otto [Sun, 22 Oct 2023 12:20:07 +0000 (12:20 +0000)]
A few more tests

14 months agoWhen option D is active, store callers for all chunks; this avoids
otto [Sun, 22 Oct 2023 12:19:26 +0000 (12:19 +0000)]
When option D is active, store callers for all chunks; this avoids
the 0x0 call sites for leak reports. Also display more info on
detected write of free chunks: print the info about where the chunk
was allocated, and for the preceding chunk as well.
ok asou@

14 months agofix 40 MHz channel validation checks for the 2.4 GHz channel range
stsp [Sun, 22 Oct 2023 12:01:36 +0000 (12:01 +0000)]
fix 40 MHz channel validation checks for the 2.4 GHz channel range

Just like the 5 GHz channels, 2.4 GHz channels are spaced 5 MHz apart.
40 MHz wide channels hence span channels [N, N + 4] not [N, N + 1].
Adjust our secondary channel range checks accordingly.

14 months agoregression test for roff.c rev. 1.269:
schwarze [Sat, 21 Oct 2023 17:28:01 +0000 (17:28 +0000)]
regression test for roff.c rev. 1.269:
recursive delayed expansion of escape sequences in macro arguments

14 months agoWhen parsing a macro argument results in delayed escape sequence
schwarze [Sat, 21 Oct 2023 17:10:12 +0000 (17:10 +0000)]
When parsing a macro argument results in delayed escape sequence
expansion, re-check for all contained escape sequences whether they
need delayed expansion, not just for the particular escape sequences
that triggered delayed expansion in the first place.  This is needed
because delayed expansion can result in strings containing nested
escape sequences recursively needing delayed expansion, too.

This fixes an assertion failure in krb5_openlog(3), see:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266882

Thanks to Wolfram Schneider <wosch at FreeBSD> for reporting the bug
and to Baptiste Daroussin <bapt at FreeBSD> for forwarding the report.

14 months agodelete whitespaces that end up in output files
deraadt [Sat, 21 Oct 2023 14:09:15 +0000 (14:09 +0000)]
delete whitespaces that end up in output files

14 months agoRemove mention of alg_section. This never worked in LibreSSL.
tb [Sat, 21 Oct 2023 14:05:49 +0000 (14:05 +0000)]
Remove mention of alg_section. This never worked in LibreSSL.

14 months agostyle tweak: avoid double conjunction to make it read better
schwarze [Sat, 21 Oct 2023 13:53:43 +0000 (13:53 +0000)]
style tweak: avoid double conjunction to make it read better
OK tb@

14 months agoignore wide channel configs that do not appear in the 802.11ac spec
stsp [Sat, 21 Oct 2023 06:47:23 +0000 (06:47 +0000)]
ignore wide channel configs that do not appear in the 802.11ac spec

Wide channel configurations not listed in operating class tables of
the 802.11ac spec can trigger regulatory assertion failures in iwm(4)
firmware, and potentially other device firmware.
Ignore non-standard channels configs such that we downgrade to 40MHz
or even 20MHz to make such APs usable, albeit at lower speed.

Found by dlg@ with a mikrotik AP advertising channel configs that do
not appear as such in the spec:
  80 MHz: |104|108|112|116|
  40 MHz: |primary: 112|secondary above: 116|
Either of these triggered iwm0: 0x000014FD | ADVANCED_SYSASSERT

Fix tested by myself on iwx(4) AX200 and dlg@ on iwm(4) 7260.
Johannes Berg helped with deciphering the error code, thanks!

14 months agoensure that iwm(4) uses the 80Mhz primary channel index announced in beacons
stsp [Sat, 21 Oct 2023 06:41:26 +0000 (06:41 +0000)]
ensure that iwm(4) uses the 80Mhz primary channel index announced in beacons

same fix was applied to iwx(4) some time ago

14 months agoAdopt MI re-upgrade prevention
kn [Fri, 20 Oct 2023 19:58:16 +0000 (19:58 +0000)]
Adopt MI re-upgrade prevention

In comparison to MI boot which only cares about /bsd.upgrade's x bit,
powerpc64 rdboot just wants a regular file.

Require and strip u+x before execution to prevent sysupgrade(8) loops.

OK kettenis

14 months agoAdopt MI re-upgrade prevention
kn [Fri, 20 Oct 2023 19:55:49 +0000 (19:55 +0000)]
Adopt MI re-upgrade prevention

In comparison to MI boot which only cares about /bsd.upgrade's x bit,
octeon rdboot just wants a regular file.

Require and strip u+x before execution to prevent sysupgrade(8) loops.

OK kettenis

14 months agoAvoid forcible mounting a dirty filessystem. Mount such filesystems
kettenis [Fri, 20 Oct 2023 18:53:12 +0000 (18:53 +0000)]
Avoid forcible mounting a dirty filessystem.  Mount such filesystems
read-only instead.  This means that writing to the filesystem will fail.
As a consequence chmod'ing of files in the bootloader will fail, but that
will fix itself on the next clean boot.

Same change as I committed to powerpc64 a few days ago.

ok kn@, deraadt@

14 months agoImprove markup in some cases where .Li was abused.
schwarze [Fri, 20 Oct 2023 18:51:09 +0000 (18:51 +0000)]
Improve markup in some cases where .Li was abused.
Triggered by a smaller diff from jan@.
OK jmc@ jan@

14 months agoAvoid assertion failure when splitting mbuf cluster.
bluhm [Fri, 20 Oct 2023 16:25:15 +0000 (16:25 +0000)]
Avoid assertion failure when splitting mbuf cluster.

m_split() calls m_align() to initialize the data pointer of newly
allocated mbuf.  If the new mbuf will be converted to a cluster,
this is not necessary.  If additionally the new mbuf is larger than
MLEN, this can lead to a panic.
Only call m_align() when a valid m_data is needed.  This is the
case if we do not refecence the existing cluster, but memcpy() the
data into the new mbuf.

Reported-by: syzbot+0e6817f5877926f0e96a@syzkaller.appspotmail.com
OK claudio@ deraadt@

14 months agoAdd missing tcps_outpkttso counter to ixl(4) TSO setup.
jan [Fri, 20 Oct 2023 13:21:15 +0000 (13:21 +0000)]
Add missing tcps_outpkttso counter to ixl(4) TSO setup.

ok bluhm@

14 months agoAllow overriding the locations of the Dropbear binaries similar to what
dtucker [Fri, 20 Oct 2023 07:37:07 +0000 (07:37 +0000)]
Allow overriding the locations of the Dropbear binaries similar to what
we do for the PuTTY ones.

14 months agoImprove bad comment.
jan [Fri, 20 Oct 2023 07:31:12 +0000 (07:31 +0000)]
Improve bad comment.

pointed out by kn@

ok kn@

14 months agoAdd interop test with Dropbear. Right now this is only dbclient not the
dtucker [Fri, 20 Oct 2023 06:56:45 +0000 (06:56 +0000)]
Add interop test with Dropbear.  Right now this is only dbclient not the
Dropbear server since it won't currently run as a ProxyCommand.

14 months agodma-buf: add dma_fence_timestamp helper
jsg [Fri, 20 Oct 2023 03:49:31 +0000 (03:49 +0000)]
dma-buf: add dma_fence_timestamp helper

From Christian Koenig
d67b5a2b97b6e8959117ff71fc2daa30e66c8290 in linux-6.1.y/6.1.59
b83ce9cb4a465b8f9a3fa45561b721a9551f60e3 in mainline linux

14 months agodrm/amd/display: Don't set dpms_off for seamless boot
jsg [Fri, 20 Oct 2023 03:46:56 +0000 (03:46 +0000)]
drm/amd/display: Don't set dpms_off for seamless boot

From Daniel Miess
f0410917561cb56f93ac8c502eb0ec94f25cafe9 in linux-6.1.y/6.1.59
23645bca98304a2772f0de96f97370dd567d0ae6 in mainline linux

14 months agodrm/amdgpu: add missing NULL check
jsg [Fri, 20 Oct 2023 03:45:42 +0000 (03:45 +0000)]
drm/amdgpu: add missing NULL check

From Christian Koenig
a61d905a86879427e330a5a66cba8b2330dac4d1 in linux-6.1.y/6.1.59
ff89f064dca38e2203790bf876cc7756b8ab2961 in mainline linux

14 months agodrm/atomic-helper: relax unregistered connector check
jsg [Fri, 20 Oct 2023 03:43:33 +0000 (03:43 +0000)]
drm/atomic-helper: relax unregistered connector check

From Simon Ser
0fb82afee55fc6e12f3581e87d47fd1beae36a98 in linux-6.1.y/6.1.59
2b7947bd32e243c52870d54141d3b4ea6775e63d in mainline linux

14 months agodrm/i915: Don't set PIPE_CONTROL_FLUSH_L3 for aux inval
jsg [Fri, 20 Oct 2023 03:41:56 +0000 (03:41 +0000)]
drm/i915: Don't set PIPE_CONTROL_FLUSH_L3 for aux inval

From Nirmoy Das
f175665385fe9fdd996080806aa67e666475d3d8 in linux-6.1.y/6.1.59
128c20eda73bd3e78505c574fb17adb46195c98b in mainline linux

14 months agoadd dma_fence_timestamp() for 6.1.59 drm
jsg [Fri, 20 Oct 2023 03:38:58 +0000 (03:38 +0000)]
add dma_fence_timestamp() for 6.1.59 drm

14 months agoAdd test for dropped messages to UDP loghost.
bluhm [Thu, 19 Oct 2023 22:19:16 +0000 (22:19 +0000)]
Add test for dropped messages to UDP loghost.

14 months agosyslogd(8) counts dropped UDP packets.
bluhm [Thu, 19 Oct 2023 22:16:10 +0000 (22:16 +0000)]
syslogd(8) counts dropped UDP packets.

Now that syslogd handles delayed DNS lookups, also count dropped
packets to UDP loghosts.  Although not every outgoing UDP packet
dropped along the path can be detected, the message makes the admin
aware that there is a local blind spot during startup.
Improve debug and log messages, especially if UDP logging is shut
down permanently.  Also do not print 'last message repeated' if the
message was dropped.

OK deraadt@

14 months agoRename the modulus from n into m
tb [Thu, 19 Oct 2023 19:17:46 +0000 (19:17 +0000)]
Rename the modulus from n into m

This matches what other pages use. Also rewrite the definition of the
modular inverse to be less ugly.

14 months agoroot disk can be enrypted with a key disk now
kn [Thu, 19 Oct 2023 18:39:46 +0000 (18:39 +0000)]
root disk can be enrypted with a key disk now

14 months agoAdd missing removal of network interfaces in regress cleanup targets.
anton [Thu, 19 Oct 2023 18:36:40 +0000 (18:36 +0000)]
Add missing removal of network interfaces in regress cleanup targets.
Reducing the risk tests conflicting with each other.

ok bluhm@

14 months agosync
deraadt [Thu, 19 Oct 2023 18:04:44 +0000 (18:04 +0000)]
sync

14 months agoAdd experimental support for secp256r1 aka P-256 aka prime256v1
job [Thu, 19 Oct 2023 17:05:54 +0000 (17:05 +0000)]
Add experimental support for secp256r1 aka P-256 aka prime256v1

ECDSA signatures are much smaller than RSA signatures while offering
similar security. Adding support for P-256 now allows CA developers
to test their implementations, and paving the way for signers in the
production environment in the future to take advantage of ECDSA.

OK tb@

14 months agoEnable TCP Segmentation Offloading for ixl(4)
jan [Thu, 19 Oct 2023 16:28:02 +0000 (16:28 +0000)]
Enable TCP Segmentation Offloading for ixl(4)

Tested on amd64 and sparc64.
Also tested by bluhm@.

ok bluhm@

14 months agoAdd a few more test cases for mod_exp aliasing
tb [Thu, 19 Oct 2023 13:38:12 +0000 (13:38 +0000)]
Add a few more test cases for mod_exp aliasing

14 months agoWhile the ibuf_add calls should not fail the way they are used it
claudio [Thu, 19 Oct 2023 13:14:19 +0000 (13:14 +0000)]
While the ibuf_add calls should not fail the way they are used it
is still better to check for error.
OK tb@

14 months agoConvert rtr_proto.c to use new ibuf API.
claudio [Thu, 19 Oct 2023 11:12:10 +0000 (11:12 +0000)]
Convert rtr_proto.c to use new ibuf API.
More yak shaving required which will follow.
OK tb@

14 months agoGarbage collect weird /* 1 */ and /* 2 */ comments
tb [Thu, 19 Oct 2023 10:27:27 +0000 (10:27 +0000)]
Garbage collect weird /* 1 */ and /* 2 */ comments

If they ever had any meaning, that's long been lost.

Requested by jsing

14 months agoThe bn_mod_exp test is no longer an expected failure
tb [Thu, 19 Oct 2023 10:23:38 +0000 (10:23 +0000)]
The bn_mod_exp test is no longer an expected failure

14 months agoFix aliasing of result and exponent in the internal BN_mod_exp_recp()
tb [Thu, 19 Oct 2023 10:23:00 +0000 (10:23 +0000)]
Fix aliasing of result and exponent in the internal BN_mod_exp_recp()

This is basically the same fix as the one applied in BN_mod_exp_simple().

14 months agoFix aliasing of result with exponent or modulus in BN_mod_exp_simple()
tb [Thu, 19 Oct 2023 10:17:52 +0000 (10:17 +0000)]
Fix aliasing of result with exponent or modulus in BN_mod_exp_simple()

Reported and reminded by Guido Vranken in OpenSSL issue #21110

ok jsing

14 months agoAdd test case checking aliasing of the result with other arguments
tb [Thu, 19 Oct 2023 10:17:24 +0000 (10:17 +0000)]
Add test case checking aliasing of the result with other arguments

These are expected failures for BN_mod_exp_simple() and the internal
BN_mod_exp_recp(), which will be fixed shortly.

14 months agoConvert the session engine to use the new ibuf API.
claudio [Thu, 19 Oct 2023 07:02:45 +0000 (07:02 +0000)]
Convert the session engine to use the new ibuf API.
OK tb@

14 months agoAdd IBM encoded version of "Spleen 8x16".
fcambus [Thu, 19 Oct 2023 06:47:36 +0000 (06:47 +0000)]
Add IBM encoded version of "Spleen 8x16".

The font is 2-Clause BSD licensed and is my original creation.

OK miod@

14 months agoReduce unpractical package URL to usual package name; OK deraadt
kn [Thu, 19 Oct 2023 02:43:58 +0000 (02:43 +0000)]
Reduce unpractical package URL to usual package name; OK deraadt

This section about ports/packages really wants a revamp, though...

14 months agoSupport encrypting the root disk with a key disk
kn [Thu, 19 Oct 2023 02:39:06 +0000 (02:39 +0000)]
Support encrypting the root disk with a key disk

Extend the yes/no question to no/passphrase/keydisk and have users pick an
existing, preformated RAID partition;  no support (yet) for creating one.

OK tb afresh1

14 months agoAvoid forcible mounting a dirty filessystem. Mount such filesystems
kettenis [Wed, 18 Oct 2023 22:44:42 +0000 (22:44 +0000)]
Avoid forcible mounting a dirty filessystem.  Mount such filesystems
read-only instead.  This means that writing to the filesystem will fail.
As a consequence chmod'ing of files in the bootloader will fail, but that
will fix itself on the next clean boot.

ok kn@

14 months agoMake libssl interop server/client tests less flaky by ensuring the
anton [Wed, 18 Oct 2023 19:14:32 +0000 (19:14 +0000)]
Make libssl interop server/client tests less flaky by ensuring the
server has terminated before examining the outcome.

14 months agoadjust sgr0 escape sequence after ncurses update; ok nicm@
anton [Wed, 18 Oct 2023 18:01:10 +0000 (18:01 +0000)]
adjust sgr0 escape sequence after ncurses update; ok nicm@

14 months agoRemove EVP_add_alg_module() prototype
tb [Wed, 18 Oct 2023 17:26:06 +0000 (17:26 +0000)]
Remove EVP_add_alg_module() prototype

This function was the unfortunate protagonist in a series of tragic merge
errors resulting in only a short stint of a year and nine months between
OpenSSL 0.9.8j and 1.0.0a actually present in OpenBSD. Then it said good
bye for good, but somehow a prototype came back with 1.0.1g, a famous
version released when there were slightly more pressing things to be
taken care of than a function supporting a config knob whose only purpose
was to turn off fips mode or to error.

from schwarze

PS: The mechanism that it was supposed to provide is still documented in
openssl.cnf(5). I am going remove the relevant bit at some point, but not
today.

14 months agoSupport the GNU-specific syntax ".IP \\[bu]" for bullet lists in man(7)
schwarze [Wed, 18 Oct 2023 16:11:29 +0000 (16:11 +0000)]
Support the GNU-specific syntax ".IP \\[bu]" for bullet lists in man(7)
pages that Alejandro Colomar recommends in the "Lists" subsection of
https://man7.org/linux/man-pages/man7/man-pages.7.html#STYLE_GUIDE .

For example, this will improve HTML formatting of the first list in
the subsection "Feature test macros understood by glibc" on the page
https://manpages.debian.org/bookworm/manpages/ftm.7.en.html .

Issue reported by Alejandro Colomar <alx at kernel dot org>.

14 months agoBetter document the purpose and features of the file mandoc.css
schwarze [Wed, 18 Oct 2023 14:47:22 +0000 (14:47 +0000)]
Better document the purpose and features of the file mandoc.css
and the purpose and limitations of the embedded stylesheet.

Triggered by a conversation with Alejandro Colomar <alx at kernel dot org>.

14 months agoAvoid segments greater than maxsegsz during map merging
jan [Wed, 18 Oct 2023 14:24:29 +0000 (14:24 +0000)]
Avoid segments greater than maxsegsz during map merging

Found with hints from kettenis@

Tested on Sun-Fire-V215.
Also tested on U2 and UltraBook IIe by miod@

ok miod@

14 months agoonly strip actual file/line part from the eval error
espie [Wed, 18 Oct 2023 08:50:13 +0000 (08:50 +0000)]
only strip actual file/line part from the eval error

14 months agodocument semi-internal parts used by dpb(1)
espie [Wed, 18 Oct 2023 08:03:19 +0000 (08:03 +0000)]
document semi-internal parts used by dpb(1)

14 months agowith pfsync rewrite, pfsync interfaces need an "up" after configuration, not before.
benno [Wed, 18 Oct 2023 07:56:45 +0000 (07:56 +0000)]
with pfsync rewrite, pfsync interfaces need an "up" after configuration, not before.
Noted by Marko Cupac, thanks.

14 months agoUse X509_ALGOR_set_evp_md() in CMS_add1_signer()
tb [Wed, 18 Oct 2023 07:30:49 +0000 (07:30 +0000)]
Use X509_ALGOR_set_evp_md() in CMS_add1_signer()

Contrary to X509_ALGOR_set_md() this allows for error checking. Avoid
local complications by freeing in the exit path and use a const version
of X509_ALGOR for walking a STACK_OF() to avoid a bad free.

Clean up includes

ok jsing

14 months agocms_DigestedData_create() use X509_ALGOR_set_evp_md()
tb [Wed, 18 Oct 2023 07:24:15 +0000 (07:24 +0000)]
cms_DigestedData_create() use X509_ALGOR_set_evp_md()

Our internal version allows for error checking and this avoids a silent
failure leading to corruption later on.

Clean up includes while there.

ok jsing

14 months agoSync the supported hardware list with arm64.html.
fcambus [Wed, 18 Oct 2023 07:23:58 +0000 (07:23 +0000)]
Sync the supported hardware list with arm64.html.

14 months agorpki-client: move inherit in {ip,as}_warn()
tb [Wed, 18 Oct 2023 07:10:24 +0000 (07:10 +0000)]
rpki-client: move inherit in {ip,as}_warn()

While alphabetic order makes sense, having inherit between individual
AS and IP entries and ranges makes little sense. Use the order that we
have elsewhere.

ok claudio job

14 months agorpki-client: rework ip_addr_check_overlap()
tb [Wed, 18 Oct 2023 07:08:19 +0000 (07:08 +0000)]
rpki-client: rework ip_addr_check_overlap()

Avoid conditional early returns and significantly simplify the printing
of ip addresses/ranges by using the new ip_warn(). This also eliminates
an extremely weird usage of the comma operator and reduces noise levels
quite a bit.

ok claudio job

14 months agorpki-client: rework as_check_overlap()
tb [Wed, 18 Oct 2023 07:04:24 +0000 (07:04 +0000)]
rpki-client: rework as_check_overlap()

Avoid early returns and use a single copy of the warning by reworking
the control flow through two nested switches.

ok claudio job

14 months agoMention U-Boot file and offset for Rockchip RK356x.
kevlo [Wed, 18 Oct 2023 06:45:45 +0000 (06:45 +0000)]
Mention U-Boot file and offset for Rockchip RK356x.

"Sure." miod@

14 months agorfc3779: no need for err.h, but we do need asn1.h
tb [Wed, 18 Oct 2023 06:30:40 +0000 (06:30 +0000)]
rfc3779: no need for err.h, but we do need asn1.h

14 months agodrm/amd: Fix logic error in sienna_cichlid_update_pcie_parameters()
jsg [Wed, 18 Oct 2023 01:52:20 +0000 (01:52 +0000)]
drm/amd: Fix logic error in sienna_cichlid_update_pcie_parameters()

From Mario Limonciello
d2894c4f473ab71cd68ef0f9b086148bb2c02132 in linux-6.1.y/6.1.57
2a1fe39a5be785e962e387146aed34fa9a829f3f in mainline linux

14 months agodrm/amd: Fix detection of _PR3 on the PCIe root port
jsg [Wed, 18 Oct 2023 01:49:45 +0000 (01:49 +0000)]
drm/amd: Fix detection of _PR3 on the PCIe root port

From Mario Limonciello
c8bd3e12b3291e632ae189619169914743ba77d1 in linux-6.1.y/6.1.57
134b8c5d8674e7cde380f82e9aedfd46dcdd16f7 in mainline linux

14 months agoIncrease max depth for termcaps
afresh1 [Wed, 18 Oct 2023 01:49:26 +0000 (01:49 +0000)]
Increase max depth for termcaps

With the update to ncurses 6.4-20230826 /etc/termcap now needs at
least a 36 deep search.  Instead, we'll just bump to 64.  It seems
32 has been enough since perl 5.001 in 1995, so hopefully this buys
us at least another 28 years.

"please commit that" deraadt@

14 months agodrm/amd/display: Adjust the MST resume flow
jsg [Wed, 18 Oct 2023 01:47:42 +0000 (01:47 +0000)]
drm/amd/display: Adjust the MST resume flow

From Wayne Lin
71472872932b11ca2591104eb73255fecaae9d33 in linux-6.1.y/6.1.57
ec5fa9fcdeca69edf7dab5ca3b2e0ceb1c08fe9a in mainline linux

14 months agogrow arm64 iso media space
deraadt [Wed, 18 Oct 2023 01:45:42 +0000 (01:45 +0000)]
grow arm64 iso media space

14 months agoNeither sin_len nor sin6_len can be 0 so these checks are not needed.
claudio [Tue, 17 Oct 2023 17:59:59 +0000 (17:59 +0000)]
Neither sin_len nor sin6_len can be 0 so these checks are not needed.

Also reorder the RTF_HOST vs netmask check. RTF_HOST wins if both are set.
Makes the code a bit neater.
OK tb@

14 months agoRemove bogus plen != 0xff check
claudio [Tue, 17 Oct 2023 17:58:15 +0000 (17:58 +0000)]
Remove bogus plen != 0xff check
OK tb@

14 months agosync, from sthen
nicm [Tue, 17 Oct 2023 10:13:53 +0000 (10:13 +0000)]
sync, from sthen

14 months agoUpdate termtypes to 6.4-20230424 with local changes.
nicm [Tue, 17 Oct 2023 10:05:46 +0000 (10:05 +0000)]
Update termtypes to 6.4-20230424 with local changes.

14 months agoSwitch to tiparm_s (added in ncurses 6.4-20230424) instead of tparm,
nicm [Tue, 17 Oct 2023 09:55:32 +0000 (09:55 +0000)]
Switch to tiparm_s (added in ncurses 6.4-20230424) instead of tparm,
which allows ncurses to validate the capabilities correctly.

14 months agoUpdate ncurses and associated libraries (form, panel, menu) to
nicm [Tue, 17 Oct 2023 09:52:08 +0000 (09:52 +0000)]
Update ncurses and associated libraries (form, panel, menu) to
6.4-20230826 (from 5.7-20081102).

Based on result from Thomas Dickey's ncu2openbsd script and then
modified. Switches to the upstream tput. Major bump for the ncurses
libraries and for libedit and libreadline.

Help from tb, millert.

ok deraadt sthen

14 months agoclockintr: move callback-specific API behaviors to "clockrequest" namespace
cheloha [Tue, 17 Oct 2023 00:04:02 +0000 (00:04 +0000)]
clockintr: move callback-specific API behaviors to "clockrequest" namespace

The API's behavior when invoked from a callback function is impossible
to document.  Move the special behavior into a distinct namespace,
"clockrequest".

- Add a 'struct clockrequest'.  Basically a stripped-down 'struct clockintr'
  for exclusive use during clockintr_dispatch().
- In clockintr_queue, replace the "cq_shadow" clockintr with a "cq_request"
  clockrequest.  They serve the same purpose.
- CLST_SHADOW_PENDING -> CR_RESCHEDULE; different namespace, same meaning.
- CLST_IGNORE_SHADOW -> CLST_IGNORE_REQUEST; same meaning.
- Move shadow branch in clockintr_advance() to clockrequest_advance().
- clockintr_request_random() becomes clockrequest_advance_random().
- Delete dead shadow branches in clockintr_cancel(), clockintr_schedule().
- Callback functions now get a clockrequest pointer instead of a special
  clockintr pointer: update all prototypes, callers.

No functional change intended.

14 months agoAdjust lladdr test to use templates in rdomain1 (e.g. fe80::%pair11/64)
claudio [Mon, 16 Oct 2023 12:49:15 +0000 (12:49 +0000)]
Adjust lladdr test to use templates in rdomain1 (e.g. fe80::%pair11/64)

The code allready supports matching of templates with a scope id and
fe80::%pair11/64 and fe80::%gif11/64 are different to session_match_mask().

14 months agoConsider required constraint when moving pages from active to inactive lists.
mpi [Mon, 16 Oct 2023 11:32:54 +0000 (11:32 +0000)]
Consider required constraint when moving pages from active to inactive lists.

Make sure low pages are deactivated first when there is a shortage of inactive
pages.  Without this the system can have a ton of high pages on the active list
and never swapout anything if there's a shortage of low pages.

This prevents a deadlock on amd64 reported and tested by bluhm@.

ok kettenis@

14 months agoAdd regress test to verify that IPv6 link-local addresses work
claudio [Mon, 16 Oct 2023 10:26:51 +0000 (10:26 +0000)]
Add regress test to verify that IPv6 link-local addresses work

14 months agoImprove IPv6 link-local address handling
claudio [Mon, 16 Oct 2023 10:25:45 +0000 (10:25 +0000)]
Improve IPv6 link-local address handling

When a session is established determine the possible interface scope of that
session. The scope is only set when the remote address is directly connected.
This interface scope is passed to the RDE that uses this information when
link-local nexthops are received. Again checking that a link-local nexthop
is actually acceptable.

OK tb@

14 months agoMove declaration of "len" into the block where it's used. This lets
dtucker [Mon, 16 Oct 2023 08:40:00 +0000 (08:40 +0000)]
Move declaration of "len" into the block where it's used.  This lets
us compile Portable with -Werror with when OpenSSL doesn't have Ed25519
support.

14 months agoreinstate space-to-tabstop entry in the manpage
op [Mon, 16 Oct 2023 08:33:16 +0000 (08:33 +0000)]
reinstate space-to-tabstop entry in the manpage

removed in rev 1.95 since was hidden behind NOTAB, and forgot to be
re-added when no-tab-mode was resurrected.

14 months agoSet fib-update no since the fib is not needed here.
claudio [Mon, 16 Oct 2023 06:14:20 +0000 (06:14 +0000)]
Set fib-update no since the fib is not needed here.

14 months agotime(1): miscellaneous style(9) tweaks
cheloha [Sun, 15 Oct 2023 18:20:25 +0000 (18:20 +0000)]
time(1): miscellaneous style(9) tweaks

Use a space after keywords, binary operators require spaces, second-level
indents are four spaces, remove some extraneous parentheses and empty lines,
fill empty loop bodies with a "continue" statement.

No binary change.