anton [Sat, 10 Jul 2021 07:10:31 +0000 (07:10 +0000)]
minor nits:
* compile the edit utility once
* emit a warning during timeout
mpi [Sat, 10 Jul 2021 07:04:59 +0000 (07:04 +0000)]
Sync maxusers with other 64bit archs.
From miod@, ok deraadt@
deraadt [Sat, 10 Jul 2021 03:40:19 +0000 (03:40 +0000)]
sync
jasper [Fri, 9 Jul 2021 20:59:51 +0000 (20:59 +0000)]
use vaddr_t as type for frames as is commonly used elsewhere too
ok kettenis@
jasper [Fri, 9 Jul 2021 20:59:17 +0000 (20:59 +0000)]
fix scentence in db_printsym comment
mvs [Fri, 9 Jul 2021 20:43:28 +0000 (20:43 +0000)]
Remove unused `cc_koperations' and `cc_queued' members from 'cryptocap'
struct.
ok bluhm@
patrick [Fri, 9 Jul 2021 20:19:46 +0000 (20:19 +0000)]
Parse /soc/dma-ranges to populate the openbsd,dma-constraint property.
On the MNT Reform, which uses a i.MX8MQ with 4 GB of memory, this makes
sure that we don't allocate DMA buffers above the 32-bit boundary. As
it turns out the i.MX8MQ's I/O devices are limited to 32-bit addresses.
The i.MX8MP seems to be better in that regard, though at least the USB
controller is still limited. That's a bit harder to fix in a dynamic
fashion, but we'll take care of that as soon as someone shows up with
an i.MX8MP with that much memory.
ok kettenis@
bluhm [Fri, 9 Jul 2021 15:29:55 +0000 (15:29 +0000)]
Use SLIST macro for cryptosoft sessions instead of hand rolled list.
OK mpi@ tobhe@
tb [Fri, 9 Jul 2021 14:41:14 +0000 (14:41 +0000)]
Fix mixup between localKeyID and friendlyName.
"please commit" schwarze
tb [Fri, 9 Jul 2021 14:07:59 +0000 (14:07 +0000)]
KNF: remove whitespace between functions and parentheses
schwarze [Fri, 9 Jul 2021 12:07:27 +0000 (12:07 +0000)]
new manual page for X509_keyid_set1(3), X509_keyid_get0(3),
X509_alias_set1(3), X509_alias_get0(3)
stsp [Fri, 9 Jul 2021 11:41:20 +0000 (11:41 +0000)]
Switch iwm(4) to new firmware images available in iwm-firmware-
20210512.
This updates firmware for 3165, 3168, 7265, 8260, 8265, 9260, 9560 devices.
Other devices did not receive firmware updates from Intel.
New firmware images should contain revelant fixes for fragattacks:
https://www.intel.com/content/www/us/en/security-center/advisory/intel-sa-00473.html
Running fw_update(1) may be required before rebooting into a new kernel.
sysupgrade(8) will take care of this.
Blocking issues reported during the previous attempt at using these firmware
images have been addressed.
When reporting issues, please enable 'ifconfig iwm0 debug', reproduce the
error once more, and include the full dmesg in your bug report.
stsp [Fri, 9 Jul 2021 11:36:14 +0000 (11:36 +0000)]
Print new iwm(4) firmware version numbers like Linux iwlwifi does it.
Starting with major version 35 the Linux driver prints the minor version
number in hexadecimal.
stsp [Fri, 9 Jul 2021 11:33:00 +0000 (11:33 +0000)]
remove unused lines of code from iwm(4) which were specific to iwx(4) devices
stsp [Fri, 9 Jul 2021 11:31:05 +0000 (11:31 +0000)]
Fix errors in the probe request template we provide to iwm(4) firmware.
The SSID should not be inserted into the template itself. The template
just needs an empty SSID information element. Firmware fills in the rest.
Fix the length specification of 2GHz band-specific data in the template.
stsp [Fri, 9 Jul 2021 11:29:08 +0000 (11:29 +0000)]
Do not ask iwm(4) firmware to send probe requests on passive channels.
This seems to fix a problem where newer 9k firmware versions become
unresponsive after association and eventually raise a fatal error.
stsp [Fri, 9 Jul 2021 11:24:55 +0000 (11:24 +0000)]
Make iwm(4) set various scan command flags just like how iwlwifi sets them.
Discrepancies found while investigating an issue related to active scanning.
stsp [Fri, 9 Jul 2021 11:21:31 +0000 (11:21 +0000)]
Fix iwm(4) PHY context updates for newer firmware versions.
Firmware which advertises the BINDING_CDB_SUPPORT capability
needs a remove+add dance when the channel band has changed.
See Linux commit
730a18912bcbde0b94ae7f1b554a9908b3424a22
and Linux commit
91109f42d0ad0c0c282d1fa1257a1548977aa895
stsp [Fri, 9 Jul 2021 11:11:36 +0000 (11:11 +0000)]
Make iwm(4) use only antenna B for single-antenna Tx on 9k devices.
This matches what Linux and FreeBSD do.
According to Linux commit logs using antenna A for single-antenna Tx
on 9k devices is "wrong" (with no further explanation given).
I suspect it only matters if Bluetooth is active, since antenna A has
obviously been working for us. But who knows...
stsp [Fri, 9 Jul 2021 11:04:05 +0000 (11:04 +0000)]
Clear the "persistence bit" on iwm(4) 9k devices during hardware init.
According to iwlwifi commit messages this fixes an edge case where
9k family devices fail to resume after system suspend.
See Linux commit
8954e1eb2270fa2effffd031b4839253952c76f2
stsp [Fri, 9 Jul 2021 10:46:56 +0000 (10:46 +0000)]
Ignore undocumented TLVs found in the iwm(4) 9000-43 firmware image.
stsp [Fri, 9 Jul 2021 10:45:17 +0000 (10:45 +0000)]
Reset sc_ucode_api flags before iwm(4) loads firmware.
Fixes firmware re-loading after an initial attempt to load firmware failed.
stsp [Fri, 9 Jul 2021 10:42:35 +0000 (10:42 +0000)]
Simplify code supporting the new iwm(4) time quota firmware command.
There was no real need to use a separate function for this.
djm [Fri, 9 Jul 2021 09:55:56 +0000 (09:55 +0000)]
silence redundant error message; reported by Fabian Stelzer
dlg [Fri, 9 Jul 2021 01:22:05 +0000 (01:22 +0000)]
ifq_hdatalen can return 0 if ifq_empty is true, which avoids locks.
mlarkin [Thu, 8 Jul 2021 23:19:51 +0000 (23:19 +0000)]
whitespace fixes, no code change.
dlg [Thu, 8 Jul 2021 22:43:59 +0000 (22:43 +0000)]
fix the hibernate io path.
a botched merge meant i was posting the previously used slot to the
chip to process before posting the current slot.
ok deraadt@
millert [Thu, 8 Jul 2021 21:26:39 +0000 (21:26 +0000)]
Avoid a potential buffer overflow in backslash escaping.
https://github.com/onetrueawk/awk/issues/121
bluhm [Thu, 8 Jul 2021 21:07:19 +0000 (21:07 +0000)]
The xformsw array never changes. Declare struct xformsw constant
and map data read only.
OK deraadt@ mvs@ mpi@
deraadt [Thu, 8 Jul 2021 20:04:56 +0000 (20:04 +0000)]
sys/lib/libz isn't configured for lazy optimizations to save space because
those options are incompatible with the kernel anymore. Set DYNAMIC_CRC_TABLE
and BUILDFIXED for these bootblocks, to save space on the media
ok tb mlarkin
deraadt [Thu, 8 Jul 2021 20:02:42 +0000 (20:02 +0000)]
In recent libz update, tb@ overzealously attempted codesize reduction with
option BUILDFIXED -- which is incompatible with kernel hibernate unpack since
it places side-effects into BSS, rather than inside z_streamp or using
the private allocator. While here DYNAMIC_CRC_TABLE could cause similar
problems, so disable this also.
Space savings for the media is best done with bootblock-specific libz
compile options, coming in the following commit.
ok tb mlarkin
tb [Thu, 8 Jul 2021 18:54:21 +0000 (18:54 +0000)]
typo: hibenate -> hibernate
deraadt [Thu, 8 Jul 2021 18:25:07 +0000 (18:25 +0000)]
sync
stsp [Thu, 8 Jul 2021 17:14:08 +0000 (17:14 +0000)]
Support MCC update response used by newer iwm(4) firmware, and verify
the size of the response we receive for MCC_UPDATE commands (even
though we aren't doing anything with this response yet).
With the correct expected response length this time. The driver needs
to expect the maximum response size, not sizeof() the response struct.
The actual response size depends on the number of channels stored
in the "world" regulatory profile of the device.
ok sthen@
mvs [Thu, 8 Jul 2021 16:39:55 +0000 (16:39 +0000)]
Initialize `ipsec_acquire_pool' pool (9) within pfkey_init() instead of
doing that in runtime within ipsp_acquire_sa().
ok bluhm@
bluhm [Thu, 8 Jul 2021 15:13:14 +0000 (15:13 +0000)]
Debug printfs in encdebug were inconsistent, some missing newlines
produced ugly output. Move the function name and the newline into
the DPRINTF macro. This simplifies the debug statements.
OK tobhe@
claudio [Thu, 8 Jul 2021 13:33:05 +0000 (13:33 +0000)]
Remove the code to store intermediary vnodes in the unveil list.
These traversed vnodes are a leftover from early times where realpath(3)
was still all done in userland.
OK semarie@
patrick [Thu, 8 Jul 2021 13:20:26 +0000 (13:20 +0000)]
Attach imxiomuxc(4) to i.MX8MP as well.
jsg [Thu, 8 Jul 2021 13:07:53 +0000 (13:07 +0000)]
revert drm_mm to our previous drm 5.7.y version
Josh Rickmar and several developers reported X would sometimes fail to
start on laptops with raven ridge and picasso apus using amdgpu.
drm:pid71504:amdgpu_bo_pin_restricted *ERROR* 0xffff800001836e18 pin failed
[drm] *ERROR* Failed to pin framebuffer with error -12
ttm_bo_mem_space() ret -ENOMEM
ttm_bo_move_buffer()
ttm_bo_validate()
amdgpu_bo_pin_restricted()
By all reports this does not occur with the old drm_mm.
schwarze [Thu, 8 Jul 2021 13:07:00 +0000 (13:07 +0000)]
document X509_add1_reject_object(3) and X509_reject_clear(3)
schwarze [Thu, 8 Jul 2021 12:30:27 +0000 (12:30 +0000)]
add new manual page for X509_add1_trust_object(3) and X509_trust_clear(3)
nicm [Thu, 8 Jul 2021 11:14:53 +0000 (11:14 +0000)]
Fix mouse_word format now word-separators has no space and position of
menu if too close to the bottom.
bluhm [Thu, 8 Jul 2021 09:22:30 +0000 (09:22 +0000)]
The properties of the crypto algorithms never change. Declare them
constant. Then they are mapped as read only.
OK deraadt@ dlg@
millert [Thu, 8 Jul 2021 00:38:42 +0000 (00:38 +0000)]
csplit(1): Fix extraneous output in edge case
When the input to csplit contains fewer lines than the number of matches
specified, extra output was mistakenly included in some output files.
From FreeBSD via Tim Chase.
stsp [Thu, 8 Jul 2021 00:12:49 +0000 (00:12 +0000)]
Back out support for newer MCC update commands in iwm(4) for now.
This seems to cause "could not init LAR" errors on some devices.
Reported by dv@ (8265) and sthen@ (9560)
patrick [Wed, 7 Jul 2021 21:21:48 +0000 (21:21 +0000)]
Rework TX handling to be more similar and comparable to our other modern
network controller drivers. This also removes a variable modified by
both producer and consumer, making it a little bit more MP friendly.
Fixes a panic reported by Matthieu Estrade.
patrick [Wed, 7 Jul 2021 21:12:51 +0000 (21:12 +0000)]
When the list of free RX descriptors fills up completely, the consumed
and produced index are equal. The RX refill operation did not refill
in that case, because it believed that this means there's nothing to
do. In that case no RX buffers were allocated, and the RX descriptor
ring went dry forever. Instead loop until we reach an empty freelist
entry.
sashan [Wed, 7 Jul 2021 20:19:01 +0000 (20:19 +0000)]
tell ether_input() to call pf_test() outside of smr_read sections,
because smr_read sections don't play well with sleeping locks in pf(4).
OK bluhm@
sashan [Wed, 7 Jul 2021 18:38:25 +0000 (18:38 +0000)]
pfsync_undefer() must be called outside of PF_LOCK
OK @bluhm
bluhm [Wed, 7 Jul 2021 18:03:46 +0000 (18:03 +0000)]
Fix whitespaces in IPsec code.
sthen [Wed, 7 Jul 2021 13:29:42 +0000 (13:29 +0000)]
dedup
deraadt [Wed, 7 Jul 2021 13:19:42 +0000 (13:19 +0000)]
sync
martijn [Wed, 7 Jul 2021 11:21:55 +0000 (11:21 +0000)]
Mention that there are alternatives for ERE '+' and '?' in BRE.
OK kn@, millert@
sthen [Wed, 7 Jul 2021 09:51:28 +0000 (09:51 +0000)]
sync
stsp [Wed, 7 Jul 2021 09:47:40 +0000 (09:47 +0000)]
Support MCC update response used by newer iwm(4) firmware, and verify
the size of the response we receive for MCC_UPDATE commands (even
though we aren't doing anything with this response yet).
stsp [Wed, 7 Jul 2021 09:13:50 +0000 (09:13 +0000)]
Support the SoC configuration command used by newer iwm(4) 9560 firmware.
stsp [Wed, 7 Jul 2021 09:06:23 +0000 (09:06 +0000)]
Support the critical temperature detection feature of newer iwm(4) firmware.
stsp [Wed, 7 Jul 2021 08:52:54 +0000 (08:52 +0000)]
Parse CMD_VERSION TLV found in iwm(4) fw images and add iwm_lookup_cmd_ver().
It seems Intel saw a risk of eventually running out of firmware capability
support and API support flags, so yet another such mechanism was added.
If you want to know which variant of a command needs to be used there are
now at least three places to check for related information.
stsp [Wed, 7 Jul 2021 08:32:00 +0000 (08:32 +0000)]
Support a new variant of the binding command required by new iwm(4) firmware.
stsp [Wed, 7 Jul 2021 08:21:31 +0000 (08:21 +0000)]
Support the larger phy context command required by newer iwm(4) firmware.
stsp [Wed, 7 Jul 2021 08:13:37 +0000 (08:13 +0000)]
Recognize and ignore new debug sections found in latest iwm(4) 9k fw images.
stsp [Wed, 7 Jul 2021 08:05:11 +0000 (08:05 +0000)]
Support a new time quota command required for newer iwm(4) firmware.
mestre [Wed, 7 Jul 2021 07:28:56 +0000 (07:28 +0000)]
Hoist whole TLS initialization instead of loading the cert/key into memory first
and setting them up later on, nowadays it's possible to do both steps in just
one go through tls_config_set_{cert,key}_file(3) so use it and then init TLS.
No functional change.
OK kn@
jsg [Wed, 7 Jul 2021 02:38:21 +0000 (02:38 +0000)]
update drm to linux 5.10.47
hardware support changes include
inteldrm: better support for tiger lake
amdgpu: support for navi12, navi21 "sienna_cichlid", arcturus
amdgpu: support for cezanne "green sardine" ryzen 5000 apu
Thanks to the OpenBSD Foundation for sponsoring this work,
patrick@ for helping adapt rockchip drm, kettenis@ and mpi@
for uvm discussions and various testers.
bluhm [Tue, 6 Jul 2021 19:48:05 +0000 (19:48 +0000)]
Make test more verbose to see commands and error messages in output.
This makes it easier to debug if something fails. Add some ${SUDO}
in a way that this tests runs as root or regular user with and
without SUDO set.
patrick [Tue, 6 Jul 2021 19:09:57 +0000 (19:09 +0000)]
Shifts (<<) of more than 32 bits must be done on 64-bit values.
Reported by some grumpy old cheese lover
"looks reasonable" jsg@
ok kettenis@
jasper [Tue, 6 Jul 2021 18:01:34 +0000 (18:01 +0000)]
fix an m4 macro which showed up unexpanded. kill some trailing whitespace while here
schwarze [Tue, 6 Jul 2021 16:05:44 +0000 (16:05 +0000)]
document X509_signature_dump(3) and X509_signature_print(3)
stsp [Tue, 6 Jul 2021 15:53:33 +0000 (15:53 +0000)]
Fix iwx(4) against access points which use TKIP as the group cipher.
This was broken when key installation was moved into a task context.
Reported by and confirmed fixed by gnezdo@ and zxystd from OpenIntelWireless
ok gnezdo@
anton [Tue, 6 Jul 2021 15:24:02 +0000 (15:24 +0000)]
Make use of the existing bsd.regress.mk logic to flag root only targets,
allowing the actual tests to become less repetitive.
ok bluhm@
bluhm [Tue, 6 Jul 2021 13:19:57 +0000 (13:19 +0000)]
This regress checks that 400 singals are evenly distributed over 4
threads. It works well on idle 4 CPU machines, but with load or
fewer cores the distribution of the threads' signal handlers is
worse. Reduce the limit of signals that each thread must receive
from 75 to 50. This should prevent random test fails.
from Christian Ludwig
bluhm [Tue, 6 Jul 2021 11:50:34 +0000 (11:50 +0000)]
alarm(3) cannot fail, remove error handling.
suggested by millert@
bluhm [Tue, 6 Jul 2021 11:26:47 +0000 (11:26 +0000)]
Fix typo in comment.
schwarze [Tue, 6 Jul 2021 11:26:25 +0000 (11:26 +0000)]
Fix a bug in X509_print_ex(3).
If the user set nmflags == X509_FLAG_COMPAT and X509_NAME_print_ex(3)
failed, the error return value of 0 was misinterpreted as an indicator
of success, causing X509_print_ex(3) to ignore the error, continue
printing, and potentially return successfully even though not all
the content of the certificate was printed.
The X509_NAME_print_ex(3) manual page explains that this function
indicates failure by returning 0 if nmflags == X509_FLAG_COMPAT
and by returning -1 if nmflags != X509_FLAG_COMPAT.
That's definitely atrocious API design (witnessed by the
complexity of the code needed for correct error checking),
but changing the API contract and becoming incompatible
with OpenSSL would make matters even worse.
Note that just checking for <= 0 in all cases would not be correct
either because X509_NAME_print_ex(3) returns 0 to indicate that it
successfully printed zero bytes in some cases, for example when all
three of the following conditions hold:
1. nmflags != X509_FLAG_COMPAT
2. indent == 0 (which X509_print_ex(3) does use in some cases)
3. the name object is NULL or empty
I found the bug by code inspection and proposed an incomplete patch,
then jsing@ proposed this improved version of the patch.
OK jsing@.
kettenis [Tue, 6 Jul 2021 09:34:06 +0000 (09:34 +0000)]
Introduce CPU_IS_RUNNING() and us it in scheduler-related code to prevent
waiting on CPUs that didn't spin up. This will allow us to spin down
CPUs in the future to save power as well.
ok mpi@
nicm [Tue, 6 Jul 2021 08:26:00 +0000 (08:26 +0000)]
Improve error reporting when the tmux /tmp directory cannot be created
or used, GitHub issue 2765 from Uwe Kleine-Koenig.
nicm [Tue, 6 Jul 2021 08:18:38 +0000 (08:18 +0000)]
Forbid empty session names, GitHub issue 2758.
jmc [Tue, 6 Jul 2021 06:26:05 +0000 (06:26 +0000)]
sync man page with changes 1.2.3 -> 1.2.11. some changes:
- update references version number
- Z_NULL -> NULL; from millert
- terminate function synopses in main body with ";"; from tb
- NULL -> NUL; from tb
- update NAME and SYNOPSIS for added functions
- updated copyright, to match zlib.h
- simplify \-1 -> -1
ok tb
anton [Tue, 6 Jul 2021 05:59:20 +0000 (05:59 +0000)]
correct mailto
schwarze [Mon, 5 Jul 2021 17:57:16 +0000 (17:57 +0000)]
document i2a_ASN1_OBJECT(3)
bluhm [Mon, 5 Jul 2021 16:11:52 +0000 (16:11 +0000)]
Write ktrace output files onto NFS mounted file systems.
jca [Mon, 5 Jul 2021 13:56:24 +0000 (13:56 +0000)]
Don't use a non-standard empty statement in while loops
Empty statements accepted by ksh(1) pointed out by millert@, use of this
non-standard grammar in the installer pointed out by halex@.
ok halex@ millert@
millert [Mon, 5 Jul 2021 13:41:46 +0000 (13:41 +0000)]
Do not permit an empty list between "while" and "do".
This avoids a cpu loop for "while do done" and is consistent with
the behavior of AT&T ksh and most other shells. OK jca@ halex@
tobhe [Mon, 5 Jul 2021 12:03:42 +0000 (12:03 +0000)]
Print SA MTU if included in pfkey message.
ok bluhm@ sthen@ mpi@
tobhe [Mon, 5 Jul 2021 12:01:20 +0000 (12:01 +0000)]
Export tdb MTU to userland via SADB_GET. This helps debug path MTU
discovery issues with ESP in UDP.
ok bluhm@ sthen@ mpi@
ratchov [Mon, 5 Jul 2021 08:29:59 +0000 (08:29 +0000)]
Fix off-by-one array access when 64 channel stream is resampled
anton [Mon, 5 Jul 2021 05:50:19 +0000 (05:50 +0000)]
rename kd_put() -> kd_copy()
anton [Mon, 5 Jul 2021 05:49:30 +0000 (05:49 +0000)]
rename kd_put() -> kd_copy()
dlg [Mon, 5 Jul 2021 04:17:41 +0000 (04:17 +0000)]
etherbridge_map was way too clever, so simplify it.
the code tried to carry state from the quick smr based lookup through
to the actual map update under the mutex, but this led to refcnt
leaks, and logic errors. the simplification is that if the smr based
checks say the map needs updating, we prepare the update and then
forget what we learnt inside the smr critical section and redo them
under the mutex again.
entries in an etherbridge map are either in it or they aren't, so
we don't need to refcnt them. this means the thing that takes an
entry out of the map becomes directly responsible for destroy it,
so they can do the smr call or barrier directly rather than via a
refcnt.
found by hrvoje popovski while testing the stack running in parallel,
and fix tested by him too.
ok sashan@
dtucker [Mon, 5 Jul 2021 01:21:07 +0000 (01:21 +0000)]
Fix a couple of whitespace things. Portable already has these so this
removes two diffs between the two.
dtucker [Mon, 5 Jul 2021 01:16:46 +0000 (01:16 +0000)]
Order includes as per style(9). Portable already has these so this
removes a handful of diffs between the two.
dtucker [Mon, 5 Jul 2021 00:50:25 +0000 (00:50 +0000)]
Remove comment referencing now-removed RhostsRSAAuthentication. ok djm@
djm [Mon, 5 Jul 2021 00:25:42 +0000 (00:25 +0000)]
allow spaces to appear in usernames for local to remote, and scp -3
remote to remote copies. with & ok dtucker bz#1164
krw [Sun, 4 Jul 2021 20:37:11 +0000 (20:37 +0000)]
Fix legacy booting.
Don't flag the EFI SYS partition "DOSACTIVE". Leave that status
to the OpenBSD partition. Reverts part of r1.77.
Problem reported and fix tested by Mihai Popescu. Thanks!
Cluebats from deraadt@ and code bisecting by dv@.
ok kettenis@
sthen [Sun, 4 Jul 2021 19:22:31 +0000 (19:22 +0000)]
store provider ID in umb(4), and display it in ifconfig. OK stsp deraadt
Previously only the provider's display name was used. The text used depends
on how the SIM is configured and not just on the network in use (for example,
an MVNO SIM on another network will often display the MVNO's name rather
than that of the underlying network).
I have a SIM that roams to any network in my country - whichever network
it roams onto, the display name is the same, so you can't tell which
network you're really using. By printing the provider ID (in GSM-land this
is MCC+MNC) it's easy to lookup and check this.
As the provider was printed on the ifconfig line also showing subscriber-id
and ICCID it was already a bit long, and adding the provider-id there is
a bit too much, so move it to the output line showing APN, now looking like
: subscriber-id 2400xxxxxxxxxxx ICC-id 8946203xxxxxxxxxxxxx
: device EM7455 IMEI 01458xxxxxxxxxx firmware SWI9X30C_02.24.0
: APN key provider Tele2 IoT provider-id 23420
deraadt [Sun, 4 Jul 2021 17:51:20 +0000 (17:51 +0000)]
tb notices i did not add a copyright in 2011
tb [Sun, 4 Jul 2021 17:41:23 +0000 (17:41 +0000)]
Add missing RCS tags
deraadt [Sun, 4 Jul 2021 17:23:49 +0000 (17:23 +0000)]
sync
kn [Sun, 4 Jul 2021 15:58:51 +0000 (15:58 +0000)]
.Fl marks up options not arguments
POSIX says `-v' is an option, not an argument; options may take arguments,
as documented in getopt(3).
Programs may take arguments as well, e.g. "prog -v -- arg ...", but these
are usually marked up with `.Cm'.
Change "The arguments are as follows:" to "The options are as follows:" in
`.Fl's DESCRIPTION example to match what most of our base manuals say.
OK schwarze jmc
schwarze [Sun, 4 Jul 2021 15:38:08 +0000 (15:38 +0000)]
The mandoc(1) manual already mentions that -T man output mode
neither supports tbl(7) nor eqn(7) input.
If an input file contains such code anyway, tell the user
rather than failing an assert(3)ion.
Fixing a crash reported by Bjarni Ingi Gislason <bjarniig at rhi dot hi dot is>
in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901636 which the
Debian maintainer of mandoc, Michael at Stapelberg dot ch, forwarded to me.