jmc [Wed, 23 Apr 2014 16:26:33 +0000 (16:26 +0000)]
tweak previous; sorry ingo, my review was pretty poor;
schwarze [Wed, 23 Apr 2014 16:07:06 +0000 (16:07 +0000)]
Audit strlcpy(3)/strlcat(3) usage.
* Repair three instances of silent truncation, use asprintf(3).
* Change two instances of strlen(3)+malloc(3)+strlcpy(3)+strlcat(3)+...
to use asprintf(3) instead to make them less error prone.
* Cast the return value of four instances where the destination
buffer is known to be large enough to (void).
* Completely remove three useless instances of strlcpy(3)/strlcat(3).
* Mark two places in -Thtml with XXX that can cause information loss
and crashes but are not easy to fix, requiring design changes of
some internal interfaces.
* The file mandocdb.c remains to be audited.
reyk [Wed, 23 Apr 2014 15:45:16 +0000 (15:45 +0000)]
Fix format string in DEBUG message (not compiled by default).
ok blambert@
tedu [Wed, 23 Apr 2014 15:07:27 +0000 (15:07 +0000)]
remove Z option and default to something halfway to J.
we always junk small chunks now, and the first part of pages,
but only after free. J still does the old thing. j disables everything.
Consider experimental as we evaluate performance in the real world.
ok otto
florian [Wed, 23 Apr 2014 14:43:14 +0000 (14:43 +0000)]
No need for vargs here.
While there move declaration of divert{,6}_output() to .c as it's a
private function. Also switch first two args to make it more like
similar functions (both suggested by mpi@).
Input/OK mpi@, OK lteo@
jca [Wed, 23 Apr 2014 14:15:03 +0000 (14:15 +0000)]
Use arc4random as PRNG backend, instead of libcrypto RAND.
Feedback and ok guenther@ deraadt@
Discussed with upstream, who is preparing an arc4random backend.
schwarze [Wed, 23 Apr 2014 13:58:55 +0000 (13:58 +0000)]
more info about HISTORY; ok jmc@
jca [Wed, 23 Apr 2014 13:16:28 +0000 (13:16 +0000)]
His name is Van Jacobson. ok jmc@
stsp [Wed, 23 Apr 2014 12:45:18 +0000 (12:45 +0000)]
Document RTS5227 support in rtsx(4).
djm [Wed, 23 Apr 2014 12:42:34 +0000 (12:42 +0000)]
don't record duplicate IdentityFiles
jsing [Wed, 23 Apr 2014 12:42:16 +0000 (12:42 +0000)]
Casting from a const unsigned char ** to a const unsigned char ** seems...
unnecessary. Remove the temporary ugly casts - the comments even call them
that!
ok guenther@
jsing [Wed, 23 Apr 2014 12:37:42 +0000 (12:37 +0000)]
We do not need ARGV, Argc and Argv - just use argc and argv like normal
people do.
ok beck@ (although he wanted #Arrrrrrrgv instead).
florian [Wed, 23 Apr 2014 12:27:31 +0000 (12:27 +0000)]
Replace malloc / memset / select song and dance with poll(2) like
ping6.
Prompted by and initial diff from Peter Malone (peter _AT_
petermalone _DOT_ org), thanks!
OK jca@
mpi [Wed, 23 Apr 2014 12:25:35 +0000 (12:25 +0000)]
Don't use varargs for udp_output() and sync the argument order with
udp6_output().
ok henning@, reyk@, jca@
otto [Wed, 23 Apr 2014 11:49:25 +0000 (11:49 +0000)]
don't clear label before readasciilabel(), it will not fill in some
required fields like disk size, causing consistency check failures.
with and ok krw@
jca [Wed, 23 Apr 2014 11:47:04 +0000 (11:47 +0000)]
Kill useless assignement, matchlen is initialized two lines below.
From Fritjof Bornebusch.
naddy [Wed, 23 Apr 2014 11:42:14 +0000 (11:42 +0000)]
Remove badly outdated information: FDDI and Token Ring are gone,
VLAN tags on transmitted packets have been visible to bpf since
the introduction of bpf_mtap_ether(). ok brad@, henning@
jca [Wed, 23 Apr 2014 10:50:18 +0000 (10:50 +0000)]
Don't attempt to deal with link types supported by no drivers in the
tree. ok henning@
espie [Wed, 23 Apr 2014 10:47:15 +0000 (10:47 +0000)]
explain a bit more what's going on for stupid me.
okay otto@
nicm [Wed, 23 Apr 2014 10:14:29 +0000 (10:14 +0000)]
Differentiate between linked and unlinked window closes and renames,
like we already do for adds. From Andre Masella.
ajacoutot [Wed, 23 Apr 2014 09:56:56 +0000 (09:56 +0000)]
Remove krb5 bits from rc(8).
ok reyk@
mpi [Wed, 23 Apr 2014 09:30:57 +0000 (09:30 +0000)]
You don't want to use ifa_ifwithroute(), it exists for to the routing
crazyness only.
florian [Wed, 23 Apr 2014 09:27:13 +0000 (09:27 +0000)]
Merge traceroute6 into traceroute.
Not yet enabled in the build.
OK benno@
florian [Wed, 23 Apr 2014 09:24:36 +0000 (09:24 +0000)]
Prepare for merge: s/hops/ttl/ in struct packetdata
OK benno@
florian [Wed, 23 Apr 2014 09:23:30 +0000 (09:23 +0000)]
Prepare for merge: no more useicmp
OK benno@
florian [Wed, 23 Apr 2014 09:22:34 +0000 (09:22 +0000)]
KNF
OK benno@
florian [Wed, 23 Apr 2014 09:20:15 +0000 (09:20 +0000)]
bzero -> memset
OK benno@
florian [Wed, 23 Apr 2014 09:19:23 +0000 (09:19 +0000)]
s/lastaddr/lastaddr6/
OK benno@
florian [Wed, 23 Apr 2014 09:18:27 +0000 (09:18 +0000)]
Prepare merge: check AF
OK benno@
florian [Wed, 23 Apr 2014 09:17:10 +0000 (09:17 +0000)]
missing break; not reachable
OK benno@
florian [Wed, 23 Apr 2014 09:16:11 +0000 (09:16 +0000)]
No need to set protocol in hints.
OK benno@
florian [Wed, 23 Apr 2014 09:14:49 +0000 (09:14 +0000)]
zap redundant cast
OK benno@
florian [Wed, 23 Apr 2014 09:14:07 +0000 (09:14 +0000)]
Introduce check_tos to unclutter the main loop.
OK benno@
florian [Wed, 23 Apr 2014 09:13:00 +0000 (09:13 +0000)]
move AF independet setsockopts down
OK benno@
florian [Wed, 23 Apr 2014 09:11:35 +0000 (09:11 +0000)]
s/Nxt/nxt/
OK benno@
florian [Wed, 23 Apr 2014 09:10:53 +0000 (09:10 +0000)]
Add error checking to sysctl. While there pass in an int otherwise
it failes with ENOMEM in traceroute.
OK benno@
florian [Wed, 23 Apr 2014 09:09:28 +0000 (09:09 +0000)]
sync to traceroute: move sndsock creation up.
OK benno@
florian [Wed, 23 Apr 2014 08:59:35 +0000 (08:59 +0000)]
Prepare for merge: introduce icmp_code for the AF switch.
OK benno@
florian [Wed, 23 Apr 2014 08:58:26 +0000 (08:58 +0000)]
Prepare for merge: s/icmp_code/icmp4_code/ and use icmp_code for
the AF switch.
OK benno@
florian [Wed, 23 Apr 2014 08:56:31 +0000 (08:56 +0000)]
Prepare for merge: s/packet_ok/packet_ok6/ and use packet_ok
for the AF switch.
florian [Wed, 23 Apr 2014 08:55:42 +0000 (08:55 +0000)]
Prepare for merge: s/packet_ok/packet_ok4/ and use packet_ok
for the AF switch.
florian [Wed, 23 Apr 2014 08:51:32 +0000 (08:51 +0000)]
Prepare merge: s/to/to6/; s/from/from6/
OK benno@
florian [Wed, 23 Apr 2014 08:50:27 +0000 (08:50 +0000)]
Prepare merge: introduce struct sockaddr *from, *to to be used in
AF independet places.
OK benno@
florian [Wed, 23 Apr 2014 08:47:16 +0000 (08:47 +0000)]
Prepare merge: s/to/to4/; s/from/from4/
OK benno@
florian [Wed, 23 Apr 2014 08:44:50 +0000 (08:44 +0000)]
Make this compile with -Wall et al.
OK benno@
otto [Wed, 23 Apr 2014 05:43:25 +0000 (05:43 +0000)]
Better, cleaner hash function that computes the same on be and le archs.
Should improve sparc64 and other be archs. ok matthew@ miod@
beck [Wed, 23 Apr 2014 05:13:57 +0000 (05:13 +0000)]
Make libssl and libcrypto compile with -Werror
ok miod@
beck [Wed, 23 Apr 2014 04:33:10 +0000 (04:33 +0000)]
Make sure ret->name is NULL'ed before return when freeing.
from Dirk Engling <erdgeist@erdgeist.org>
beck [Wed, 23 Apr 2014 04:24:39 +0000 (04:24 +0000)]
Rather than sprinkling magical numbers everywhere, we can use sizeof()
for the size of a fixed size array.
From Dirk Engling <erdgeist@erdgeist.org>
jsg [Wed, 23 Apr 2014 03:37:29 +0000 (03:37 +0000)]
rename some hardware revisions to match FreeBSD
jsg [Wed, 23 Apr 2014 03:20:55 +0000 (03:20 +0000)]
add support for RTL8168EP
From Edward O'Callaghan via FreeBSD
jsg [Wed, 23 Apr 2014 02:58:06 +0000 (02:58 +0000)]
While we always mask the revision with 0x7c800000 linux uses a table
that masks with either 0x7c800000 or 0x7cf00000 depending on the chip.
Some of the hardware revisions I previously added can't be matched with
the current mask, these are already handled by other revision defines
so remove them.
When masking the revision defines with 0x7c800000:
RL_HWREV_8106E_SPIN1 is the same as RL_HWREV_8106E
RL_HWREV_8168G_SPIN1 is the same as RL_HWREV_8168G
RL_HWREV_8168G_SPIN2 is the same as RL_HWREV_8168GU
jsg [Wed, 23 Apr 2014 02:39:28 +0000 (02:39 +0000)]
Add support for RTL8168GU
from Rafael Neves
aoyama [Tue, 22 Apr 2014 22:58:02 +0000 (22:58 +0000)]
Unify the model name to LUNA-88K{,2}, that is considered the
`official' name.
ok jmc@ miod@
miod [Tue, 22 Apr 2014 22:21:32 +0000 (22:21 +0000)]
unifdef -UAES_LONG for we do not intend to run on platforms where int is smaller
than 32 bits.
millert [Tue, 22 Apr 2014 22:11:23 +0000 (22:11 +0000)]
Use calloc() instead of malloc(n * s) followed by memset(). Not
actually used on OpenBSD but changed to avoid false positives in
audits. From Jean-Philippe Ouellet.
miod [Tue, 22 Apr 2014 21:52:21 +0000 (21:52 +0000)]
So it turns out that libcrypto on i386 platforms, unconditionaly compiles this
little gem called OPENSSL_indirect_call(), supposedly to be ``handy under
Win32''.
In my view, this is a free-win ROP entry point. Why try and return to libc
when you can return to libcrypto with an easy to use interface?
Better not give that much attack surface, and remove this undocumented
entry point.
ok beck@ tedu@
miod [Tue, 22 Apr 2014 21:27:11 +0000 (21:27 +0000)]
When compiling with AES_WRAP_TEST, make main() return a meaningful value
instead of garbage, and add this to the libcrypto regress. Note these tests
are incomplete, as they always use the default IV.
tedu [Tue, 22 Apr 2014 21:24:20 +0000 (21:24 +0000)]
use reallocarray
miod [Tue, 22 Apr 2014 21:01:10 +0000 (21:01 +0000)]
Mention 16-bit sound is supported nowadays.
tedu [Tue, 22 Apr 2014 20:48:41 +0000 (20:48 +0000)]
remove dead stores to error. from Fritjof Bornebusch
tedu [Tue, 22 Apr 2014 20:42:01 +0000 (20:42 +0000)]
malloc/memset -> calloc. from peter malone
lteo [Tue, 22 Apr 2014 20:41:43 +0000 (20:41 +0000)]
Remove the certs directory that contains ancient files not used
by anything.
"yes, blow it away" beck@
tedu [Tue, 22 Apr 2014 20:40:37 +0000 (20:40 +0000)]
malloc/memset->calloc. with bonus null check. from peter malone.
tedu [Tue, 22 Apr 2014 20:38:02 +0000 (20:38 +0000)]
null a pointer to prevent double free. from Dirk Engling
miod [Tue, 22 Apr 2014 20:33:29 +0000 (20:33 +0000)]
Remove files which look like actual code compiled in libcrypto, but isn't.
One even says (in comments): HAS BUGS! DON'T USE
tedu [Tue, 22 Apr 2014 20:31:57 +0000 (20:31 +0000)]
fix memory leaks. from Dirk Engling
miod [Tue, 22 Apr 2014 20:31:38 +0000 (20:31 +0000)]
Remove meat which either duplicates code found in apps/, or is only of value
for 20th century historians, and can be put in the Attic.
tedu [Tue, 22 Apr 2014 20:25:16 +0000 (20:25 +0000)]
malloc/memset -> calloc. from peter malone
beck [Tue, 22 Apr 2014 20:14:39 +0000 (20:14 +0000)]
Fix issue where we could jump into getdirtybuf without splbio() on a retry
that probably crashed espie.
ok tedu@
espie [Tue, 22 Apr 2014 18:22:20 +0000 (18:22 +0000)]
turns out there are exactly 3 ports that actually use longnames:
eclipse-plugins-wtp-sdk
openclipart
qt4-html
so switch to pax extended headers now, the transition period is not
really needed. :)
tedu [Tue, 22 Apr 2014 16:58:20 +0000 (16:58 +0000)]
Trojan horse is still a noun. noted by fritjof
naddy [Tue, 22 Apr 2014 15:52:05 +0000 (15:52 +0000)]
Remove RX checksum offloading support. The chip is too limited, and
examining higher protocol layers to adjust the checksum and calculate
the pseudo-header in the driver is too complex to be worthwhile.
ok henning@
sobrado [Tue, 22 Apr 2014 15:22:04 +0000 (15:22 +0000)]
add closing parenthesis.
ok millert@
jmc [Tue, 22 Apr 2014 15:02:16 +0000 (15:02 +0000)]
- one more mallocarray -> reallocarray
- use <>
jsing [Tue, 22 Apr 2014 14:54:13 +0000 (14:54 +0000)]
Nuke the last of the windows related defines from the openssl apps.
ok deraadt@
henning [Tue, 22 Apr 2014 14:47:23 +0000 (14:47 +0000)]
this commit is really florian@'s, since he's the one who made removal
of our forked apache possible by his work on nginx and slowcgi, but he
doesn't want it - so it is my pleasure to tedu it. I spent so much work
on chroot in it 10 years ago - and am very happy to see it go now, nginx
is a far better choice today.
Bye bye, Apache, won't miss you.
reyk [Tue, 22 Apr 2014 14:42:53 +0000 (14:42 +0000)]
Finally remove KERBEROS5? from the Makefile infrastructure.
ok henning@
mpi [Tue, 22 Apr 2014 14:41:03 +0000 (14:41 +0000)]
Remove some altq tentacles.
ok pelikan@, henning@
tedu [Tue, 22 Apr 2014 14:27:25 +0000 (14:27 +0000)]
switch to reallocarray
tedu [Tue, 22 Apr 2014 14:26:26 +0000 (14:26 +0000)]
change mallocarray to reallocarray. useful in a few more situations.
malloc can, as always, be emulated via realloc(NULL).
ok deraadt
jsing [Tue, 22 Apr 2014 14:22:51 +0000 (14:22 +0000)]
KNF.
jmc [Tue, 22 Apr 2014 14:19:04 +0000 (14:19 +0000)]
more kerberos zapping;
jmc [Tue, 22 Apr 2014 14:16:30 +0000 (14:16 +0000)]
zap eol whitespace;
jmc [Tue, 22 Apr 2014 14:15:55 +0000 (14:15 +0000)]
zap stray Pp;
jsing [Tue, 22 Apr 2014 14:05:40 +0000 (14:05 +0000)]
More KNF.
gilles [Tue, 22 Apr 2014 13:57:58 +0000 (13:57 +0000)]
malloc -> calloc
jsing [Tue, 22 Apr 2014 13:48:29 +0000 (13:48 +0000)]
More KNF.
jsing [Tue, 22 Apr 2014 13:32:17 +0000 (13:32 +0000)]
More KNF.
jsing [Tue, 22 Apr 2014 13:13:58 +0000 (13:13 +0000)]
More KNF.
henning [Tue, 22 Apr 2014 12:53:48 +0000 (12:53 +0000)]
no more kerb, ok kettenis
sobrado [Tue, 22 Apr 2014 12:48:17 +0000 (12:48 +0000)]
no more kerberos authentication styles.
ok henning@, reyk@
jsing [Tue, 22 Apr 2014 12:43:34 +0000 (12:43 +0000)]
More KNF.
logan [Tue, 22 Apr 2014 12:42:04 +0000 (12:42 +0000)]
Document sftp upload resume.
OK from djm@, with feedback from okan@.
okan [Tue, 22 Apr 2014 12:36:36 +0000 (12:36 +0000)]
Instead of special casing ftpd, uucpd and others that may have entries
in wtmp, go the other way and exclude entries we know ('console' and
'tty') from pid stripping, then strip the rest.
idea, feedback and ok millert@
mpi [Tue, 22 Apr 2014 12:35:00 +0000 (12:35 +0000)]
ifa_ifwithroute() is the only magic place where an AF_LINK sockaddr
can be given to ifa_ifwithnet().
Handle this specific case directly and let ifa_ifwithnet() do only
one thing: iterate on all the addresses of all the interfaces in a
given routing domain to return the most specific matching address.
ok mikeb@
espie [Tue, 22 Apr 2014 12:21:17 +0000 (12:21 +0000)]
pure reindent
henning [Tue, 22 Apr 2014 12:07:20 +0000 (12:07 +0000)]
NULL is cooler than 0 when pointers are concerned
ok gcc & md5 (aka no binary change)
reyk [Tue, 22 Apr 2014 12:00:03 +0000 (12:00 +0000)]
Update iked to use the same proc.c that relayd uses.
Less differences, less code to audit.
ok mikeb@
naddy [Tue, 22 Apr 2014 11:54:46 +0000 (11:54 +0000)]
If VLAN_HWTAGGING is disabled, we tell the chip not to strip the
tag from the received frame. Do not add the tag from the receive
descriptor in this case so that the packet isn't tagged twice.
Matches FreeBSD.
ok brad@