openbsd
6 years agoadvertise slaacd.8;
jmc [Fri, 3 Aug 2018 20:09:48 +0000 (20:09 +0000)]
advertise slaacd.8;

6 years agosort; ok florian
jmc [Fri, 3 Aug 2018 19:54:11 +0000 (19:54 +0000)]
sort; ok florian

6 years agoImplement single-stepping. Based on an earlier diff from drahn@.
kettenis [Fri, 3 Aug 2018 18:36:01 +0000 (18:36 +0000)]
Implement single-stepping.  Based on an earlier diff from drahn@.
Disable userland debug communication access while there.

ok patrick@

6 years agoreturn is not a function and if (x) -> if (x != NULL)
benno [Fri, 3 Aug 2018 17:57:21 +0000 (17:57 +0000)]
return is not a function and if (x) -> if (x != NULL)
From Ross L Richardson, thanks
ok millert@

6 years agofix error messages from earlier syntax change
benno [Fri, 3 Aug 2018 17:51:40 +0000 (17:51 +0000)]
fix error messages from earlier syntax change
From Ross L Richardson
ok millert@

6 years agocorrect an error message, from Ross L Richardson
benno [Fri, 3 Aug 2018 17:49:57 +0000 (17:49 +0000)]
correct an error message, from Ross L Richardson
ok millert@

6 years agodocument the default in the abscence of a certificate authority.
benno [Fri, 3 Aug 2018 17:48:34 +0000 (17:48 +0000)]
document the default in the abscence of a certificate authority.
From Ross L Richardson

6 years agoDocument that domain certificate is optional.
benno [Fri, 3 Aug 2018 17:46:57 +0000 (17:46 +0000)]
Document that domain certificate is optional.
From Ross L Richardson

6 years agoMove pledge after getopt when we know whether the operation is reboot,
deraadt [Fri, 3 Aug 2018 17:09:22 +0000 (17:09 +0000)]
Move pledge after getopt when we know whether the operation is reboot,
powerdown, halt, or singleuser.  Before pledge, unveil access to
/dev/console, /etc/rc for singleuser entry, execute of /usr/bin/wall
to alert users, and creation of the fastboot and nologin files.  Also
conditionally allow execute of halt, reboot, or the shell depending on mode.
Believe all scenarios were tested -- please exercise this one a bit.

6 years agoImplement DVFS support.
kettenis [Fri, 3 Aug 2018 16:45:17 +0000 (16:45 +0000)]
Implement DVFS support.

ok patrick@

6 years agoMove nexthop and nexthop flags from the rde_aspath to struct prefix.
claudio [Fri, 3 Aug 2018 16:31:22 +0000 (16:31 +0000)]
Move nexthop and nexthop flags from the rde_aspath to struct prefix.
struct prefix will be slowly becomming the hub of the rib.
OK phessler@ job@

6 years agounveil _PATH_UTMP at startup. Time for a commentary:
deraadt [Fri, 3 Aug 2018 16:02:53 +0000 (16:02 +0000)]
unveil _PATH_UTMP at startup.  Time for a commentary:

There is a TOCTOU between unveil() and open() which should always be
considered, since a path is being supplied twice to the kernel.  First
unveil()s define which paths remain in scope, then secondly open()s
try to access paths in scope.  The unveil() generates a vnode
reservation against the final path resolution (including symbolic link
collapse).  Before the open() occurs, root could replace the path with
symbolic traversal pointing elsewhere.  Then open() will traverse a
path which fails to discover the reserved vnode, and thus fail with
ENOENT.  The TOCTOU sequence doesn't succeed against the new path, it
*always fails*.  (Unless the symlink resolves to another unveil'd
vnode object, but that is not new behaviour).

So once a process is running with veiled filesystem view, we can
consider such a symlink change action as PERMANENTLY visible to this
process and correctly contained to the scoped view, rather than the
previous behaviour of being TRANSIENT and global in view.  So this is
not a real race, security implications will be narrow, and generally
the old symlink-race case is the less secure.

When we add this unveil+open TOCTOU scenario to a program, we should
consider who can perform such a symlink snap, and whether behaviour
change to the program is more disruptive than the risks prevented
through filesystem hiding.  How does a program behave if a file
disappears due to active interference?  Are users (and scripts) used
to operating in a racey best-effort way, and is the additional
strictness strangling their freedom to run shitty stuff?

A few general rules for base programs can avoid problems in this area:
don't en masse unveil argv[], then process argv[] in a second phase.
Don't unveil args which get placed into TZ, TERM, and some other
environment variables, unless you completely understand what libc is
doing.

6 years agoWe can only unveil if the prefix is a directory (the input paths, and the
deraadt [Fri, 3 Aug 2018 15:29:51 +0000 (15:29 +0000)]
We can only unveil if the prefix is a directory (the input paths, and the
output directory).  If prefix isn't a directory, that would require
enumerating all prefix<sig>.<id> filenames and unveiling all of them
which isn't reasonable... for the file case can we identify whether it
starts start with '/' or not, and unveil '/' or '.' for "w"?

6 years agoImprove synchronization between the parent and children. This fixes
visa [Fri, 3 Aug 2018 15:19:44 +0000 (15:19 +0000)]
Improve synchronization between the parent and children. This fixes
a spurious test failure spotted by anton@ and eliminates sleeping
in the test.

Feedback and OK anton@

6 years agoMove pledge to after getopt, when the finger program becomes known
deraadt [Fri, 3 Aug 2018 15:14:18 +0000 (15:14 +0000)]
Move pledge to after getopt, when the finger program becomes known
(defaults to /usr/bin/finger, but can be redefined with -P option).
Then unveil that program for "x" (execution), and pledge as before.
No other filesystem accesses occur after that point.

6 years agopledge() a little later, after getopt operation, in case -f option changes
deraadt [Fri, 3 Aug 2018 15:01:28 +0000 (15:01 +0000)]
pledge() a little later, after getopt operation, in case -f option changes
the filename.  We can then unveil that file, pledge() as before, and proceed
to parsing.

6 years agosync
deraadt [Fri, 3 Aug 2018 14:58:21 +0000 (14:58 +0000)]
sync

6 years agowrap long lines
deraadt [Fri, 3 Aug 2018 14:47:56 +0000 (14:47 +0000)]
wrap long lines

6 years agounveil _PATH_DEVDB for devname(). All other filenames are opened
deraadt [Fri, 3 Aug 2018 14:39:55 +0000 (14:39 +0000)]
unveil _PATH_DEVDB for devname().   All other filenames are opened
before unveil/pledge.

6 years agoReshuffle the way bgpd does the softreload after filter changes.
claudio [Fri, 3 Aug 2018 14:10:39 +0000 (14:10 +0000)]
Reshuffle the way bgpd does the softreload after filter changes.
Walk each rib at most once and push it from there to all RIBs or peers
that need the update. Makes the logic more streight and so easier to run
in background.
Tested by and OK phessler@

6 years agoEnable mue(4).
kevlo [Fri, 3 Aug 2018 13:37:08 +0000 (13:37 +0000)]
Enable mue(4).
Tested on Orange Pi Plus 2E (armv7) and Orange Pi PC 2 (arm64).

ok jsg@

6 years agoMove dns settings to global options so that they don't need to be
florian [Fri, 3 Aug 2018 13:14:46 +0000 (13:14 +0000)]
Move dns settings to global options so that they don't need to be
repeated in every interface block - they can still be overwritten
on a per interface basis.
Pointed out by, tweaks & OK sthen

6 years agodocument that wpakey needs a preceeding nwid OR join specification
halex [Fri, 3 Aug 2018 11:21:27 +0000 (11:21 +0000)]
document that wpakey needs a preceeding nwid OR join specification

ok phessler@

6 years agorevert 1.133 and part of 1.131
phessler [Fri, 3 Aug 2018 10:52:45 +0000 (10:52 +0000)]
revert 1.133 and part of 1.131
the stack doesn't always fill in the paramaters correctly

reported by many

6 years agoAccount when the next nd6_timer_to is scheduled in nd6_timer()
florian [Fri, 3 Aug 2018 09:11:56 +0000 (09:11 +0000)]
Account when the next nd6_timer_to is scheduled in nd6_timer()
otherwise nd6_llinfo_settimer() might wrongly assume that a timeout is
already scheduled earlier and not schedule one itself. This in turn
lead to the neighbor cache no longer updating because neighbor
solicitations were not send.
Observed by many.
OK kn

6 years agopledge() a little later, after getopt operation, when we know tty name.
deraadt [Fri, 3 Aug 2018 06:57:34 +0000 (06:57 +0000)]
pledge() a little later, after getopt operation, when we know tty name.
We can then unveil the tty file, and pledge() as before.  No other files
are accessed after that point in time.

6 years agounveil of _PATH_DEVDB "/var/run/dev.db" can be done before pledge for
deraadt [Fri, 3 Aug 2018 06:55:41 +0000 (06:55 +0000)]
unveil of _PATH_DEVDB "/var/run/dev.db" can be done before pledge for
use by ttyname, no other files are accessed after that.

6 years agoactually heed localbase when looking for groff
espie [Fri, 3 Aug 2018 06:49:26 +0000 (06:49 +0000)]
actually heed localbase when looking for groff

6 years agoreorg groff runner so that failures are handled better
espie [Fri, 3 Aug 2018 06:39:12 +0000 (06:39 +0000)]
reorg groff runner so that failures are handled better
do the logic for manpage formatting better, so that we can't miss things
simplify filenames, fullname always has a slash

6 years ago- exit in case of exec error. Prevents code from continuing badly
espie [Fri, 3 Aug 2018 06:37:08 +0000 (06:37 +0000)]
- exit in case of exec error.  Prevents code from continuing badly
- display error message on STDERR... better
- don't extract the code twice

6 years ago- use memset() for for clearing hashtbl
kevlo [Fri, 3 Aug 2018 06:19:15 +0000 (06:19 +0000)]
- use memset() for for clearing hashtbl
- the switch case for IFM_100_TX was the same code as for IFM_1000_T so it
  can be rolled into one.

From Michael W. Bombardieri

6 years agotweak previous;
jmc [Fri, 3 Aug 2018 06:13:14 +0000 (06:13 +0000)]
tweak previous;

6 years agoThe first unveil userland commit!
deraadt [Fri, 3 Aug 2018 04:47:56 +0000 (04:47 +0000)]
The first unveil userland commit!

unveil _PATH_LOGIN_CONF (/etc/login.conf) which is used by
login_getclass(3) and family before doing password encode.  This
is the only filename used by the program during runtime, everything
else happens on stdin/stdout.

6 years agoThis does not need pledge "wpath"
deraadt [Fri, 3 Aug 2018 04:19:34 +0000 (04:19 +0000)]
This does not need pledge "wpath"

6 years agoni_pledge flags are a uint64_t not an int - don't initialize with an int.
beck [Fri, 3 Aug 2018 02:36:11 +0000 (02:36 +0000)]
ni_pledge flags are a uint64_t not an int - don't initialize with an int.

6 years agoPlace a limit on the number of elements in a ber sequence/set. This prevents
rob [Fri, 3 Aug 2018 01:51:28 +0000 (01:51 +0000)]
Place a limit on the number of elements in a ber sequence/set. This prevents
possible stack overflow due to recursion in ber_free_elements().

ok claudio@

6 years agoAdd mue(4), a driver for Microchip LAN75xx/LAN78xx 10/100/1000 USB Ethernet
kevlo [Fri, 3 Aug 2018 01:50:14 +0000 (01:50 +0000)]
Add mue(4), a driver for Microchip LAN75xx/LAN78xx 10/100/1000 USB Ethernet
adapters.

"go ahead commit it" deraadt@

6 years agoLog command arguments.
nicm [Thu, 2 Aug 2018 18:35:21 +0000 (18:35 +0000)]
Log command arguments.

6 years agoreplace excessively wordy and fuzzy introduction
schwarze [Thu, 2 Aug 2018 17:10:26 +0000 (17:10 +0000)]
replace excessively wordy and fuzzy introduction
with a real HISTORY section;
OK jmc@ rob@

6 years agoerrno is never checked after a call to getuint64(). So there is no
krw [Thu, 2 Aug 2018 16:30:01 +0000 (16:30 +0000)]
errno is never checked after a call to getuint64(). So there is no
point to getuint64() setting it to EINVAL when the user enters an
invalid value or aborts input with a ^D.

6 years agoGrammar fix in comment.
rob [Thu, 2 Aug 2018 15:34:07 +0000 (15:34 +0000)]
Grammar fix in comment.

ok deraadt@

6 years agoSome wordsmithing. Comments and tweaks from deraadt, jmc, benno, and tb.
rob [Thu, 2 Aug 2018 15:22:11 +0000 (15:22 +0000)]
Some wordsmithing. Comments and tweaks from deraadt, jmc, benno, and tb.

ok deraadt@

6 years agoSplit out the rule skipping logic into own function and by doing so ensure
claudio [Thu, 2 Aug 2018 14:41:42 +0000 (14:41 +0000)]
Split out the rule skipping logic into own function and by doing so ensure
that both filter lists are treated the same way. This fixes an inconsistency
with ibgp and ebgp filters as used in the example config.
OK benno@ sthen@

6 years agoAccording to code (and testing), each is optional but at least
benno [Thu, 2 Aug 2018 14:40:38 +0000 (14:40 +0000)]
According to code (and testing), each is optional but at least
one must be present.
From Ross L Richardson, thanks
ok sthen@

6 years agoIt's an "X.509 certificate" rather than a "TLS certificate".
benno [Thu, 2 Aug 2018 14:39:26 +0000 (14:39 +0000)]
It's an "X.509 certificate" rather than a "TLS certificate".
As pointed out by sthen@, TLS isn't the only possible use.
From Ross L Richardson
ok shten@

6 years agoits a X.509 certificate, consistency with acme-client.conf.5
benno [Thu, 2 Aug 2018 14:37:32 +0000 (14:37 +0000)]
its a X.509 certificate, consistency with acme-client.conf.5
From Ross L Richardson
ok sthen@

6 years agoEnable ssdfb(4) at I2C.
patrick [Thu, 2 Aug 2018 14:13:44 +0000 (14:13 +0000)]
Enable ssdfb(4) at I2C.

6 years agoAdd I2C attachment code to ssdfb(4). The difference between the I2C
patrick [Thu, 2 Aug 2018 14:09:32 +0000 (14:09 +0000)]
Add I2C attachment code to ssdfb(4).  The difference between the I2C
and SPI bus is simply how to let the chip know it's a command or data
transfer.  Otherwise we push the very same bits.

6 years agontpd(8) has logic in place to delete its control socket on shutdown, but it
mestre [Thu, 2 Aug 2018 13:05:34 +0000 (13:05 +0000)]
ntpd(8) has logic in place to delete its control socket on shutdown, but it
currently doesn't call the function control_cleanup to do so. The solution is
to simply call that function just before the program quits.

"sure" henning@

6 years agoMake a few more rde specific functions static.
claudio [Thu, 2 Aug 2018 12:49:00 +0000 (12:49 +0000)]
Make a few more rde specific functions static.

6 years agoMake free_prefixsets() accept a NULL pointer. Makes it behave more like
claudio [Thu, 2 Aug 2018 12:46:02 +0000 (12:46 +0000)]
Make free_prefixsets() accept a NULL pointer. Makes it behave more like
all other free functions bgpd has.

6 years agosession_groups can be static also.
nicm [Thu, 2 Aug 2018 11:56:12 +0000 (11:56 +0000)]
session_groups can be static also.

6 years agoMake key trees and some other bits static.
nicm [Thu, 2 Aug 2018 11:44:07 +0000 (11:44 +0000)]
Make key trees and some other bits static.

6 years agoMinor tidying.
nicm [Thu, 2 Aug 2018 11:18:34 +0000 (11:18 +0000)]
Minor tidying.

6 years agoThis brings the network code more in line with what regular update
claudio [Thu, 2 Aug 2018 09:46:35 +0000 (09:46 +0000)]
This brings the network code more in line with what regular update
processing does. It adds the prefix to Adj-RIB-In and if "log update" is
set it will also log the addition and removal of a prefix.
OK benno@

6 years agoAdd delay when increasing the voltage of a regulator that has a
kettenis [Thu, 2 Aug 2018 09:45:17 +0000 (09:45 +0000)]
Add delay when increasing the voltage of a regulator that has a
"regulator-ramp-delay" property to guerantee that the target voltage has
been reached when regulator_set_voltage(9) returns.

ok patrick@

6 years agoMake display-panes block the client until a pane is chosen or it times out.
nicm [Thu, 2 Aug 2018 07:55:16 +0000 (07:55 +0000)]
Make display-panes block the client until a pane is chosen or it times out.

6 years agoActually order the promises in their canonical form, missed that in my
mestre [Thu, 2 Aug 2018 06:43:31 +0000 (06:43 +0000)]
Actually order the promises in their canonical form, missed that in my
previous commit.

heads up and OK tb@

6 years agoCurrently when eigrpd(8) shuts down then its unix control socket is being
mestre [Thu, 2 Aug 2018 06:28:35 +0000 (06:28 +0000)]
Currently when eigrpd(8) shuts down then its unix control socket is being
unlink(2)ed from eigrpe engine process, the problem is that this proc is
chrooted and therefore the socket will never be deleted.
In order to solve it we need to bring control_cleanup() function, which calls
unlink(2), into the main proc which is not chrooted. This is the way it's
already done for several other daemons we have in our base.
Additionally we also need to move the "cpath" pledge(2) promise from the child
process to the main process in order for the latter to be allowed to delete the
socket and while here shuffle the promises into their canonical form.

OK florian@ and benno@

6 years agoFix panic when we attempt to mess with "." but have a flags mismatch
beck [Thu, 2 Aug 2018 04:41:47 +0000 (04:41 +0000)]
Fix panic when we attempt to mess with "." but have a flags mismatch
so unveil_check_final returns an error - in this case we can't
just VOP_UNLOCK the parent we have to know we are dealing with "."
found by anton@ - thanks

6 years agoTest messing with "." both when having . unveiled for an operation, and
beck [Thu, 2 Aug 2018 04:39:58 +0000 (04:39 +0000)]
Test messing with "." both when having . unveiled for an operation, and
with . veiled without the right flags for an operation, since these
come out of namei differently and . is the bane of the special
LOCKPARENT corner cases - this tests a panic found by anton@

6 years agoOn AMD CPUs, If the LFENCE serialization MSR bit is already set, then
brynet [Wed, 1 Aug 2018 20:33:53 +0000 (20:33 +0000)]
On AMD CPUs, If the LFENCE serialization MSR bit is already set, then
we don't need to uncondtionally set it.

Worksaround a suspected bug in newer Linux KVM, which may trigger a
#GP fault on writes to this MSR.

ok mlarkin@

6 years agoFix segmentation fault on radiusd(8) when exiting.
mestre [Wed, 1 Aug 2018 17:17:42 +0000 (17:17 +0000)]
Fix segmentation fault on radiusd(8) when exiting.
If one of the configured modules doesn't have a secret setup then
module->secret == NULL which would call strlen(NULL), within freezero(3),
and that shouldn't happen, but in this case since the call is done it
segfaults and the daemon is not properly shutdown.

cluebat stick provided by semarie@, OK tb@ and deraadt@

6 years agoFix an off-by-one string read access that could happen if an empty
schwarze [Wed, 1 Aug 2018 16:00:54 +0000 (16:00 +0000)]
Fix an off-by-one string read access that could happen if an empty
string argument preceded a string argument beginning with "--".
Found by Leah Neukirchen <leah at vuxu dot org> with -Wpointer-compare.

6 years agoFix various RK3399 clocks and add support for getting the clock frequency
kettenis [Wed, 1 Aug 2018 15:55:50 +0000 (15:55 +0000)]
Fix various RK3399 clocks and add support for getting the clock frequency
of the clocks that we can set.

Assign clock rates (and parents) based on the "assigned-clocks" device tree
property, but only on RK3399 for now as the code for the other Rockchip SoCs
isn't quite ready yet.

Last but not least, fixup a mistake on the firmware for the Theobroma
Systems RK3399-Q7 module such that the "big" cluster uses BPLL as intended.

6 years agoAfter rewriting the parse buffer from scratch, we also have to reset
schwarze [Wed, 1 Aug 2018 15:39:47 +0000 (15:39 +0000)]
After rewriting the parse buffer from scratch, we also have to reset
the parse point to the beginning of the new buffer or we risk out
of bounds accesses.  Bug found by Leah Neukirchen <leah at vuxu dot
org> with valgrind on Void Linux.

6 years agoInitialize new lineflag member.
nicm [Wed, 1 Aug 2018 15:22:40 +0000 (15:22 +0000)]
Initialize new lineflag member.

6 years agoAvoid a read access one byte beyond the end of an allocated string
schwarze [Wed, 1 Aug 2018 13:44:15 +0000 (13:44 +0000)]
Avoid a read access one byte beyond the end of an allocated string
which occurred in situations like ".Fl a Cm --"; found by
Leah Neukirchen <leah at vuxu dot org> with valgrind on Void Linux.

6 years agoUse a single space after colon in another errx().
tb [Wed, 1 Aug 2018 13:35:33 +0000 (13:35 +0000)]
Use a single space after colon in another errx().

Pointed out by Kris Katterjohn

6 years agoDisallow negative reps, they make no sense. While here, sscanf -> strtonum.
cheloha [Wed, 1 Aug 2018 13:13:53 +0000 (13:13 +0000)]
Disallow negative reps, they make no sense. While here, sscanf -> strtonum.

From Kris Katterjohn on tech@.

ok tb@

6 years agoImplement a partial update mechanism. Since the SPI-connected display
patrick [Wed, 1 Aug 2018 12:34:36 +0000 (12:34 +0000)]
Implement a partial update mechanism.  Since the SPI-connected display
cannot read the framebuffer memory, we have to push the framebuffer to
the display.  ssdfb(4) will now be able to update only a certain region
region of the framebuffer as soon as there is infrastructure to trigger
it.

6 years agoClarify that we chroot to the users home directory if -u is provided.
florian [Wed, 1 Aug 2018 11:47:29 +0000 (11:47 +0000)]
Clarify that we chroot to the users home directory if -u is provided.
Pointed out by Andrew Daugherity (andrew.daugherity AT gmail), thanks!
Tweaks and OK jmc

6 years agoRemove midsentence period.
rob [Wed, 1 Aug 2018 10:42:55 +0000 (10:42 +0000)]
Remove midsentence period.

6 years agodocument when -exec evaluates to true; from kris katterjohn
jmc [Wed, 1 Aug 2018 07:09:15 +0000 (07:09 +0000)]
document when -exec evaluates to true; from kris katterjohn
ok tb

while here, knock out a useless Tn;

6 years agoUpdate a comment to include -delete, -execdir, -ls and -print0 among
tb [Wed, 1 Aug 2018 06:39:58 +0000 (06:39 +0000)]
Update a comment to include -delete, -execdir, -ls and -print0 among
the primaries that do not imply -print.  From Kris Katterjohn, thanks!

ok jmc

6 years agoDocument that -delete and -execdir prevent -print from being assumed.
tb [Wed, 1 Aug 2018 06:37:33 +0000 (06:37 +0000)]
Document that -delete and -execdir prevent -print from being assumed.
From Kris Katterjohn, thanks.

ok jmc

6 years agoupdate currency exchange rates;
jmc [Wed, 1 Aug 2018 05:55:25 +0000 (05:55 +0000)]
update currency exchange rates;

6 years agoZap v4mask and v6mask in host()
kn [Tue, 31 Jul 2018 22:48:04 +0000 (22:48 +0000)]
Zap v4mask and v6mask in host()

Simply defer checks whether a mask has been specified to where it's set in
host_*(); this is to reduce address family specific code.

OK sashan

6 years agoRelocate some public functions above the internal functions comment.
rob [Tue, 31 Jul 2018 19:38:09 +0000 (19:38 +0000)]
Relocate some public functions above the internal functions comment.

ok claudio@

6 years agoDisplay color depth alongside resolution when attaching simplefb(4).
fcambus [Tue, 31 Jul 2018 17:25:55 +0000 (17:25 +0000)]
Display color depth alongside resolution when attaching simplefb(4).

OK kettenis@, deraadt@

6 years agoReshuffle order in struct rde_peer a bit. No functional change.
claudio [Tue, 31 Jul 2018 15:30:04 +0000 (15:30 +0000)]
Reshuffle order in struct rde_peer a bit. No functional change.

6 years agoDo not leak path or use it after free.
nicm [Tue, 31 Jul 2018 13:06:44 +0000 (13:06 +0000)]
Do not leak path or use it after free.

6 years agoStop reversing bytes read from the framebuffer. That was added since
patrick [Tue, 31 Jul 2018 12:41:57 +0000 (12:41 +0000)]
Stop reversing bytes read from the framebuffer.  That was added since
the 8x16 font showed horizontally flipped characters, but as it turns
out the issue is that with 8-bit wide fonts we use optimized rasops
code that apparently writes out the character with reversed bitorder.

6 years agoMove struct screen_sel into screen.c and tidy up members that are only
nicm [Tue, 31 Jul 2018 11:49:26 +0000 (11:49 +0000)]
Move struct screen_sel into screen.c and tidy up members that are only
used by copy mode.

6 years agoFix some debugging output now that ber type and encoding are unsigned int.
rob [Tue, 31 Jul 2018 11:37:18 +0000 (11:37 +0000)]
Fix some debugging output now that ber type and encoding are unsigned int.

ok claudio@

6 years agoMake ber type and encoding a unsigned int instead of unsigned long.
claudio [Tue, 31 Jul 2018 11:02:01 +0000 (11:02 +0000)]
Make ber type and encoding a unsigned int instead of unsigned long.
This way the size is the same on all archs and 32bit should be good enough.
OK rob@

6 years agoMake ber type and encoding a unsigned int instead of unsigned long.
claudio [Tue, 31 Jul 2018 11:01:29 +0000 (11:01 +0000)]
Make ber type and encoding a unsigned int instead of unsigned long.
This way the size is the same on all archs and 32bit should be good enough.
OK rob@

6 years agoMake ber type and encoding a unsigned int instead of unsigned long.
claudio [Tue, 31 Jul 2018 11:01:00 +0000 (11:01 +0000)]
Make ber type and encoding a unsigned int instead of unsigned long.
This way the size is the same on all archs and 32bit should be good enough.
OK rob@

6 years agoMake ber type and encoding a unsigned int instead of unsigned long.
claudio [Tue, 31 Jul 2018 11:00:12 +0000 (11:00 +0000)]
Make ber type and encoding a unsigned int instead of unsigned long.
This way the size is the same on all archs and 32bit should be good enough.
OK rob@

6 years agoClear history on RIS like most other terminals do.
nicm [Tue, 31 Jul 2018 10:32:19 +0000 (10:32 +0000)]
Clear history on RIS like most other terminals do.

6 years agoImplement setting the voltage of the regulators.
kettenis [Tue, 31 Jul 2018 10:09:25 +0000 (10:09 +0000)]
Implement setting the voltage of the regulators.

6 years agoCorrectly set the dividers for the clock of the "big" cores.
kettenis [Tue, 31 Jul 2018 10:08:24 +0000 (10:08 +0000)]
Correctly set the dividers for the clock of the "big" cores.

6 years agoFix setting the voltage; the code was using the wrong variable as a step size.
kettenis [Tue, 31 Jul 2018 10:07:13 +0000 (10:07 +0000)]
Fix setting the voltage; the code was using the wrong variable as a step size.
Includes some cosmetic fixes as well.

6 years agoThere is no longer the need to be careful in rde_softreconfig_in() when
claudio [Tue, 31 Jul 2018 08:04:49 +0000 (08:04 +0000)]
There is no longer the need to be careful in rde_softreconfig_in() when
traversing the prefix list. Since a while Adj-RIB-In is fully independent
and so updating the local RIB does not modify that list.
OK benno@

6 years agodelay bailout for invalid authenticating user until after the packet
djm [Tue, 31 Jul 2018 03:10:27 +0000 (03:10 +0000)]
delay bailout for invalid authenticating user until after the packet
containing the request has been fully parsed. Reported by Dariusz Tytko
and MichaƂ Sajdak; ok deraadt

6 years agofix some memory leaks spotted by Coverity via Jakub Jelen in bz#2366
djm [Tue, 31 Jul 2018 03:07:24 +0000 (03:07 +0000)]
fix some memory leaks spotted by Coverity via Jakub Jelen in bz#2366
feedback and ok dtucker@

6 years agoKNF
deraadt [Tue, 31 Jul 2018 02:55:57 +0000 (02:55 +0000)]
KNF

6 years agoDeclare then assign local variable, no binary change.
anton [Mon, 30 Jul 2018 20:53:42 +0000 (20:53 +0000)]
Declare then assign local variable, no binary change.

6 years agoIf we keep the BIOS framebuffer, stick to the desired framebuffer size
kettenis [Mon, 30 Jul 2018 19:40:53 +0000 (19:40 +0000)]
If we keep the BIOS framebuffer, stick to the desired framebuffer size
instead of using the actual framebuffer size.  This fixes a problem seen
on various Apple machines where the BIOS framebuffer is bigger than the
actual display.

ok jcs@, mpi@

6 years agoregen
mpi [Mon, 30 Jul 2018 19:10:50 +0000 (19:10 +0000)]
regen